Tuesday, 2017-03-14

*** salv-orlando has quit IRC00:09
*** saneax is now known as saneax-_-|AFK00:54
*** limao has joined #openstack-kuryr00:55
*** yedongcan has joined #openstack-kuryr00:55
*** saneax-_-|AFK is now known as saneax01:42
*** yamamoto has joined #openstack-kuryr01:43
*** hongbin has joined #openstack-kuryr02:00
*** saneax is now known as saneax-_-|AFK02:46
*** hongbin has quit IRC02:46
*** hongbin has joined #openstack-kuryr02:48
*** salv-orlando has joined #openstack-kuryr03:10
*** salv-orlando has quit IRC03:15
*** aojea has joined #openstack-kuryr03:31
*** aojea has quit IRC03:35
*** janonymous has joined #openstack-kuryr03:37
*** hongbin has quit IRC03:59
*** janki has joined #openstack-kuryr05:01
*** salv-orlando has joined #openstack-kuryr05:11
*** salv-orlando has quit IRC05:15
irenabmchiappero, lets meet there!05:42
*** janonymous has quit IRC05:44
*** salv-orlando has joined #openstack-kuryr06:12
*** salv-orlando has quit IRC06:17
*** salv-orlando has joined #openstack-kuryr06:26
*** saneax-_-|AFK is now known as saneax06:34
*** aojea has joined #openstack-kuryr06:38
*** salv-orl_ has joined #openstack-kuryr07:23
*** salv-orlando has quit IRC07:26
irenabltomasbo|away, hi07:28
*** pcaruana has joined #openstack-kuryr07:50
*** salv-orl_ has quit IRC08:10
*** ltomasbo|away is now known as ltomasbo08:14
ltomasboirenab, hi!08:14
*** daidv has joined #openstack-kuryr08:17
*** pmannidi has quit IRC08:29
*** salv-orlando has joined #openstack-kuryr08:54
*** janonymous has joined #openstack-kuryr08:56
*** garyloug has joined #openstack-kuryr09:02
*** yedongcan has quit IRC09:19
*** yedongcan has joined #openstack-kuryr09:20
openstackgerritDongcan Ye proposed openstack/kuryr-libnetwork master: Add fullstack test for IPv6 subnet  https://review.openstack.org/44537609:24
*** limao has quit IRC09:27
irenabltomasbo, I wanted to ask you if there is some order to review the pools patches?09:28
ltomasbohi irenab09:39
ltomasbothere is an initial one:09:39
ltomasbohttps://review.openstack.org/#/c/43687509:39
ltomasbothen a follow up for initial baremetal support09:39
ltomasbohttps://review.openstack.org/#/c/436876/09:40
ltomasboand then, on the one hand there is the extension for the baremetal: https://review.openstack.org/#/c/436877/09:40
ltomasboand on the other hand the 2 related to the nested:09:40
ltomasbohttps://review.openstack.org/#/c/436893/, https://review.openstack.org/#/c/436894/09:40
*** aojea has quit IRC10:00
*** salv-orlando has quit IRC10:18
*** aojea has joined #openstack-kuryr10:21
openstackgerritDongcan Ye proposed openstack/kuryr-libnetwork master: Add docs for IPv6 address pool  https://review.openstack.org/44540510:21
*** daidv has quit IRC10:21
openstackgerritMerged openstack/kuryr-libnetwork master: Split the test of requesting specific address  https://review.openstack.org/44168910:23
*** aojea has quit IRC10:26
openstackgerritDongcan Ye proposed openstack/kuryr-libnetwork master: Add fullstack test for IPv6 subnet  https://review.openstack.org/44537610:27
openstackgerritMerged openstack/kuryr-libnetwork master: Refactor the logic of updating existing port  https://review.openstack.org/44460110:30
openstackgerritMerged openstack/kuryr-libnetwork master: Handle containers with both ipv4 & ipv6  https://review.openstack.org/43993210:30
apuimedovikasc: ping10:34
openstackgerritDongcan Ye proposed openstack/kuryr-libnetwork master: Make port bind on dual-stack port  https://review.openstack.org/44252510:38
*** salv-orlando has joined #openstack-kuryr10:45
*** salv-orl_ has joined #openstack-kuryr10:46
*** salv-orlando has quit IRC10:49
*** salv-orl_ has quit IRC10:51
*** yedongcan has quit IRC10:58
*** yedongcan has joined #openstack-kuryr10:58
mchiapperoanyone familiar with GenericPodVIFDriver, is this driver really supposed to be generic? I guess it's more bridge oriented11:06
mchiapperoas I'm considering the possibility to actually move all the really generic code in a base abstract class11:07
mchiapperoa skeleton one11:07
mchiapperothe Generic could then be renamed "bridge" or something like that11:08
mchiapperoany thoughts?11:08
vikascapuimedo, pong11:09
openstackgerritOpenStack Proposal Bot proposed openstack/kuryr-libnetwork master: Updated from global requirements  https://review.openstack.org/43196611:20
*** yedongcan has left #openstack-kuryr11:22
apuimedovikasc: any news on the ssl patch?11:23
apuimedohttps://review.openstack.org/#/c/440979/11:23
vikascapuimedo, working on adding unit test to address ltomasbo comment11:24
apuimedook11:24
ltomasbothanks vikasc11:24
vikascyw ltomasbo :)11:25
openstackgerritMerged openstack/kuryr-kubernetes master: Add ddt to test-requirements  https://review.openstack.org/43650912:03
*** yuval has joined #openstack-kuryr12:04
*** yuval has quit IRC12:06
*** yuval has joined #openstack-kuryr12:07
*** saneax is now known as saneax-_-|AFK12:10
*** janonymous has quit IRC12:14
apuimedoltomasbo: ping12:16
*** yuval has quit IRC12:31
*** yuval has joined #openstack-kuryr12:31
*** aojea has joined #openstack-kuryr12:45
*** garyloug has quit IRC12:46
openstackgerritvikas choudhary proposed openstack/kuryr-kubernetes master: Add support for HTTPS client  https://review.openstack.org/44097913:12
vikascapuimedo, ltomasbo, irenab ivc_  ^13:12
*** aojea has quit IRC13:15
apuimedothanks vikasc. Will look into it in a little while13:18
vikascapuimedo, thank you!13:20
apuimedoltomasbo: regarding https://review.openstack.org/#/c/436877/7/kuryr_kubernetes/controller/drivers/generic_ports_pool.py . Please look at the paste http://paste.openstack.org/show/602683/13:21
apuimedoI rewrote how you generate the bulk request13:21
apuimedoas you can see in the %timeit run, it's almost 20x faster13:22
ltomasboapuimedo, pong13:22
ltomasbojust came back from lunch13:22
apuimedo:-)13:23
ltomasbogoing to check what did you change!13:23
ltomasbothanks! 20x is great!13:23
apuimedoltomasbo: the crux of it, is that you were generating the same dictionary as many times as ports you wanted13:24
*** garyloug has joined #openstack-kuryr13:24
apuimedowhen you could just have a single dict be included as N elements13:24
apuimedoother small improvements as well13:24
ltomasbogreat thanks!13:25
*** mattmceuen has joined #openstack-kuryr13:32
apuimedoltomasbo: also, I'd like to go over the patches with you13:43
apuimedomaybe we could do a bluejeans13:43
apuimedoivc_: irenab and others, you'd be welcome to it if you want13:43
vikascapuimedo, i am interested13:44
apuimedogood13:45
ltomasbosure, I have a meeting from 4-5, other than that I'm available13:45
vikascapuimedo, so does dict.append recreates a dict ?13:45
apuimedovikasc: where?13:46
vikascapuimedo, ltomasbo code was calling append() number of ports time. you said that ltomasbo is regenerating dict13:47
vikascapuimedo, performance improvement that you did on paste output13:47
apuimedovikasc: he was doing append on a dict13:48
apuimedoappend on a list13:48
apuimedoI mean13:48
apuimedothat then he was adding to the dict13:48
vikascapuimedo, yeah and u said "generating the same dictionary as many times as ports", so does that mean append() generates the same dict?13:49
vikascapuimedo, ahh got it13:49
vikascapuimedo, nevermind13:49
vikasc:) thank you!13:50
apuimedo;-)13:51
*** yedongcan has joined #openstack-kuryr13:51
apuimedoltomasbo: so, what do you think about the paste?13:52
ltomasbosure, I will update the code accordingly!13:53
ltomasbocan't say 'no' to 20x speed up!13:53
ltomasbo:D13:53
vikasc:D13:53
vikascbut just by looking at both logics, its hard to infer that it would be 20x improvement. atleast to me13:54
* vikasc noted down that list.append is too slow13:55
*** mattmceuen has quit IRC13:55
*** mattmceuen__ has joined #openstack-kuryr13:55
apuimedovikasc: there's the numbers at the bottom of the paste13:55
vikascapuimedo, yeah i noticed those13:55
vikascapuimedo, i am not denying :D13:56
apuimedocreating dicts is cheap, but it is not free13:56
apuimedoltomasbo: so let's have the call in 20 minutes13:56
apuimedoI want to understand why we need to watch pod creation13:56
apuimedowhy we need the config option instead of just having a noop pool driver13:57
apuimedoetc13:57
dmelladoltomasbo: 20x?13:57
ltomasboapuimedo, sure!13:58
apuimedodmellado: I'm disapointed though. I wanted https://i.ytimg.com/vi/LqSg9yVfzV0/maxresdefault.jpg14:00
dmelladoapuimedo: LOL14:01
dmelladowhy don't you just have kuryr go into super-saiyan mode? xD14:01
apuimedothat should be a plugin14:04
apuimedosome kind of easter egg14:04
*** IRCFrEAK has joined #openstack-kuryr14:13
*** IRCFrEAK has quit IRC14:14
*** saneax-_-|AFK is now known as saneax14:17
dmelladoapuimedo: note that I won't be speaking about further transformations14:18
apuimedolike?14:21
apuimedoXd14:21
dmelladooh, those weird stuff that they added later14:22
dmelladolike super-saiyan-god and so xD14:22
apuimedoyou don't like the blue hair?14:22
dmelladothat was just going overkill14:23
dmelladoxD14:23
vikascapuimedo, ltomasbo , bj meeting?14:24
ltomasboyep14:24
apuimedodmellado: and no eyebrows third level wasn't?14:25
dmelladoapuimedo: heh, that kinda reminded me about whoopie goldberg14:25
apuimedohttps://bluejeans.com/550870997514:25
* apuimedo facepalms14:26
dmelladoapuimedo: is that for joining the whoopie-saiyan discussion?14:26
*** hongbin has joined #openstack-kuryr14:26
apuimedodmellado: it's for going over luis' patches14:26
dmelladoheh, just joking this time14:26
dmelladoI'll join, but if you mention the saiyan topic I promise I'll go away14:27
*** yedongcan has left #openstack-kuryr14:28
apuimedo:-)15:08
apuimedoI managed not to mention it15:08
apuimedoalraddarla: mattmceuen__: I marked your contrail bp for pike-215:19
apuimedonext monday we can vote on the weekly IRC meeting for direction approval15:20
apuimedoso let's see if the spec already made it through reviews then15:20
alraddarlaapuimedo, for a minute i thought you meant -2 ...not pike2 and I was so sad15:20
*** danil has joined #openstack-kuryr15:28
apuimedoxD15:33
apuimedoalraddarla: I'm really looking forward to it15:33
dmelladoalraddarla: if apuimedo is being mean to you, just let us know xD15:35
alraddarladmellado, thank you. I appreciate the back up15:36
apuimedodmellado: you are risking your fuet supply15:36
apuimedo:B15:36
dmelladoxD15:36
dmelladoapuimedo: btw, you should give me your home address15:37
dmelladoI'll send you some stuff next time I go to Galicia15:37
apuimedoI'm not sure I want the sort of stuff that arrives hidden in the Galicia ports15:37
apuimedoxD15:37
apuimedoI'm not from Ciudadanos15:37
apuimedoxD15:37
dmelladoLOL15:38
dmelladoapuimedo: Ciutadans, don't forget where does he come from15:39
dmelladoxD15:39
apuimedofrom La Caixa15:39
apuimedoxD15:39
dmelladoapart from that xD15:39
*** danil has quit IRC15:39
*** tonanhngo has joined #openstack-kuryr15:48
*** janki has quit IRC15:54
mchiapperopod['status']['hostIP']15:55
mchiapperodo you know whether this info comes from the kubelet or the api-server? I would assume the latter, but it would help to get a confirmation15:56
mchiapperocurrently for nested deployments the 'link_iface' option is provided, but actually is not fully utilized, it could be avoided give the current detection logic based on the pod information15:57
mchiapperodo you have any preference?15:57
apuimedomchiappero: I've never checked. I'd hope the latter15:59
apuimedoUsing the hostIP could be good16:00
apuimedothe link_iface was always a stopgap16:00
mchiapperobut what if you run a single apiserver with many minions within VMs?16:00
apuimedoand an option to force the iface if multiple are there16:00
apuimedomchiappero: not sure I get the point16:00
mchiapperoif the hostIP comes from the host the apiserver runs on, you would get the host/BM IP address16:01
mchiapperosay you have multiple minions running in different VMs16:01
mchiapperowell, I'm not too sure it's a valid usecase16:01
mchiapperobut if it is it would not work16:02
mchiapperoI was considering leveraging the link_iface if present, leverage 'hostIP' otherwise16:02
mchiapperothe important thing is to be able to retrieve the port ID of the master, once you have that I guess it can be cached16:03
*** salv-orlando has joined #openstack-kuryr16:03
mchiapperoany feedback?16:03
*** salv-orlando has quit IRC16:05
*** salv-orlando has joined #openstack-kuryr16:05
apuimedosorry, I got on something else16:06
* apuimedo reading16:06
apuimedomchiappero: with "coming from the apiserver" I meant that the api server checks the API object Node of the node where the scheduler put the pod16:06
apuimedoso it would be the IP of the worker node VM16:07
mchiapperook, perfect16:08
mchiapperoI guess we still want to cache the name of the master interface too, instead of using netlink every time16:08
apuimedomchiappero: yup16:09
mchiapperodo we want to eliminate "link_iface" entirely or leave it optional?16:09
apuimedothat's a good point too16:09
apuimedoI'd prefer to have it optional16:09
mchiapperook, cool16:10
mchiapperoapuimedo: thanks for the feedback :)16:11
*** salv-orlando has quit IRC16:13
apuimedoyou're most welcome :-)16:16
apuimedoirenab: vikasc: ivc_: ltomasbo: dmellado: https://blueprints.launchpad.net/kuryr-kubernetes/+spec/driver-handler-opt-loading16:25
*** ltomasbo is now known as ltomasbo|away16:45
mchiapperois there a way to get that IP without having to wait for a pod?16:51
*** ltomasbo|away is now known as ltomasbo17:05
fkautzmchiappero: you may be able to get it from the kuryr agent updating the pod's annotations which may land before the pod spins up17:11
fkautznot sure which component adds the pod ip, but the pod ip is definitely updated before the pod's state is set to running17:13
apuimedomchiappero: you could do a get on Nodes17:17
apuimedosorry, a watch on nodes17:17
apuimedoand keep it updated on memory17:18
*** ltomasbo is now known as ltomasbo|away17:19
ivc_apuimedo about the opt loading bp, afair we discussed something like that a couple months ago, so i agree with the idea in general. though i'm not sure if i like it as a 'register_opts' method or maybe the cfg object can be declared as an attribute (similar to handler's OBJECT_KIND)17:19
ivc_apuimedo btw, where/how do we discuss blueprints? is there some patchset in gerrit for it?17:21
apuimedoivc_: you mean to have oslo opts as subgroup17:21
apuimedoivc_: the idea was to use irc or ml17:21
apuimedolet me rephrase the subgroup thing17:21
apuimedoyou mean to have an oslo opt subgroup in the handler/driver similar to the object_kind?17:22
ivc_apuimedo yes. opts are declarative17:24
apuimedoI'm fine with that17:24
apuimedoivc_: I never understood why blueprints do not have a comments section17:25
apuimedo:/17:25
ivc_apuimedo i thought the idea was to have an .rst doc/spec in tree that can be discussed under gerrit and once w+1 linked to the bp17:26
apuimedofor small things a single bp should be enough17:27
ivc_apuimedo also regarding group name for a driver, we could probably use Driver's ALIAS + DriverImplClassName as the group name or smth like that17:32
apuimedoivc_: can't we just let the driver/handler choose its own name?17:34
apuimedoivc_: like, driver, handler is supposed to have a class object called17:35
ivc_apuimedo sure, i mean i'd like the subgroup name to be something like '%s:%s' % (ALIAS, something)17:35
apuimedoOPT17:35
apuimedoOPTGROUP17:35
apuimedoand it is an oslo OptGroup17:35
apuimedowhich already includes the name17:35
apuimedoivc_: well, that would help avoid collisions17:36
ivc_apuimedo more like VARIANT for its more generic and could be used not only for OPT, but something else too17:36
apuimedolike?17:36
ivc_apuimedo dunno. just intuition.17:37
ivc_apuimedo we could as well rename ALIAS to TYPE and have NAME for OPTGROUP/VARIANT17:37
apuimedoI'm a bit confused17:38
apuimedolet me make a pastebin17:38
apuimedoivc_: http://paste.openstack.org/show/602731/17:45
apuimedoand then, the loading code in kuryr-controller would make the option group name from the class name17:46
apuimedoit would be handler_classname17:46
apuimedoor driver_classname17:46
apuimedoin this case, the latter17:46
ivc_apuimedo thats what i dont quite like. class names are not that pretty from user's perspective17:47
ivc_apuimedo for the pastebin you linked i'd like the optgroup to be 'pod_vif:nested_vlan'17:48
ivc_apuimedo where pod_vif comes from PodVifDriver.ALIAS and nested_vlan is NestedVlanPodVIFDriver.NAME17:49
ivc_apuimedo s/NAME/VARIANT/ or something. i cant figure a proper name for it now17:50
apuimedoivc_: I actually had played with the idea to convert the class name17:50
apuimedolike this17:50
apuimedoNestedVlanPodVIFDriver -> nested_vlan_pod_vif_driver17:50
apuimedofor the opt group17:50
ivc_apuimedo i thought you hate implicit things :)17:50
apuimedoI do17:50
apuimedobut I also like avoiding naming conflicts17:51
apuimedoivc_: why not NAME?17:52
apuimedo(I didn't get it above)17:52
ivc_apuimedo mostly because i expect NAME to be unique, but in that case it should be unique within the Driver.ALIAS17:53
ivc_apuimedo but if we rename Driver.ALIAS to Driver.TYPE, it makes sense as NAME (so the opt group is 'TYPE:NAME')17:54
ivc_apuimedo also as part of renaming ALIAS to TYPE we'd get rid of package.module...ALIAS notation for driver/handler's names in setup.cfg17:56
ivc_apuimedo since TYPE:NAME would have to be unique for kuryr.conf17:57
ivc_apuimedo also imho Driver.TYPE + DriverImpl.NAME would be quite easy to explain in docs and for other devs to understand17:59
*** aojea has joined #openstack-kuryr18:02
*** pcaruana has quit IRC18:03
*** garyloug has quit IRC18:07
mchiapperoI think we should start merging with or moving some code to kuryr.lib18:08
ivc_mchiappero too early. APIs are not stable yet18:20
apuimedoagreed18:22
ivc_apuimedo mchiappero i'm also considering making Handlers and Drivers share a common base. a) to allow loading Handlers similar to Drivers and b) to allow lifecycle management for Drivers similar to Retry/Log from Handlers (e.g. the LBaaS driver has own 'retry' now)18:23
ivc_apuimedo so probably both Handlers and Drivers will become Actors :)18:24
apuimedothat's radical18:24
apuimedoxD18:24
ivc_cmon we discussed it many times already :)18:25
apuimedoI know18:25
apuimedobut not for Pike18:25
apuimedothat's the radical part18:25
ivc_not if we can pull it off by the end of p-2 milestone18:26
apuimedothat's ambitious18:27
apuimedoivc_: http://paste.openstack.org/show/602736/18:30
ivc_apuimedo aye. and [pod_vif/nested_vlan] or [pod_vif:nested_vlan] in kuryr.conf, right?18:32
apuimedoand then, in base.py http://paste.openstack.org/show/602737/18:32
apuimedothe rename from ALIAS to TYPE18:32
apuimedoivc_: either '/' or '|'18:32
apuimedoI have to check what oslo ini reader tolerates18:33
ivc_apuimedo and also get rid of '.controller.drivers' in setup.cfg at some point later18:34
apuimedothat's for a separate blueprint though, isn't it?18:37
ivc_apuimedo yup18:38
ivc_apuimedo btw, we still have that 'Please fill here a long description which must be at least 3 lines' in our README.rst :)18:55
alraddarlaI noticed that when I was digging around....should have mentioned it.18:58
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes master: Add project description to README.rst  https://review.openstack.org/44562119:01
ivc_apuimedo ^^19:02
ivc_apuimedo btw, maybe we should also reference http://superuser.openstack.org/articles/networking-kubernetes-kuryr/ in our README.rst?19:07
apuimedolol19:07
apuimedoI didn't notice it19:07
apuimedoivc_: feel free to mention it19:07
apuimedoivc_: what's that character that you used instead of an apostrophe?19:08
apuimedoin "it's"19:09
ivc_apuimedo i've copied it from our article :)19:09
ivc_you know i'm lazy19:10
apuimedoxD19:11
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes master: Add project description to README.rst  https://review.openstack.org/44562119:15
ivc_apuimedo updated ^^19:21
apuimedofkautz: I reviewed your patch19:27
*** mattmceuen__ has quit IRC19:40
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes master: K8s Services support: LBaaSv2Driver  https://review.openstack.org/43335920:05
apuimedo:O20:10
apuimedoI'm excited to look at it!20:10
apuimedoivc_: +2 :-)20:11
ivc_apuimedo :)20:12
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes master: [WIP] K8s Services support: LoadBalancerHandler  https://review.openstack.org/37604520:19
portdirectapuimedo (or anyone!): you have a moment to talk about tests?20:19
ivc_portdirect sure20:20
portdirectI'd like to get the ball rolling on creating a similar setup to my old harbor project (been talking about it long enough...)20:20
portdirectwhat testing is being run in the gate atm? looks just like a smoke test from the logs?20:20
portdirect(this in in the context of kuryr-kubernetes)20:22
openstackgerritIlya Chukhnakov proposed openstack/kuryr-kubernetes master: [WIP] K8s Services support: LoadBalancerHandler  https://review.openstack.org/37604520:22
ivc_portdirect are you referring to the python27/python35 tests or dsvm ones? the former only do unit testing and afaik the latter only test the success of ./stack.sh.20:28
ivc_portdirect fullstack&functional tests are yet to be implemented20:29
portdirectivc_: cool - thanks for the info, that was what it looked like from 1st parse of the logs20:30
portdirectivc_: I'm currently knocking together a PoC of running kuryr-kubernetes in openstack-helm20:30
portdirectivc_: and we should be moving to openstack governance in a couple of weeks20:31
portdirectivc_: would be great if we could colab on providing functional/fullstack testing?20:31
ivc_portdirect thats interesting20:32
ivc_apuimedo ^^20:32
*** alraddarla_ has joined #openstack-kuryr20:37
*** alraddarla_ has quit IRC20:37
*** tonanhngo has quit IRC21:04
fkautzapuimedo: thanks, i'll update soon21:39
*** mchiappero is now known as mchiappe|vacatio22:04
*** mchiappe|vacatio is now known as mchiappe|timeoff22:05
openstackgerritHongbin Lu proposed openstack/kuryr-libnetwork master: Add fullstack test for containers with dual-net  https://review.openstack.org/44466122:18
*** aojea has quit IRC22:41
*** aojea has joined #openstack-kuryr22:42
*** aojea has quit IRC22:46
*** saneax is now known as saneax-_-|AFK23:05
*** tonanhngo has joined #openstack-kuryr23:35
*** pmannidi has joined #openstack-kuryr23:41
openstackgerritHongbin Lu proposed openstack/kuryr-libnetwork master: [WIP] Reset neutron existing port on release_address  https://review.openstack.org/44568323:44
*** hongbin has quit IRC23:45

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!