| *** salv-orl_ has quit IRC | 00:05 | |
| *** hongbin_ has quit IRC | 00:30 | |
| *** limao has joined #openstack-kuryr | 00:50 | |
| *** limao has quit IRC | 00:52 | |
| *** limao_ has joined #openstack-kuryr | 00:52 | |
| openstackgerrit | Merged openstack/fuxi master: Fixes some typo errors on fuxi project. https://review.openstack.org/424506 | 01:28 |
|---|---|---|
| openstackgerrit | Merged openstack/fuxi master: [Trivial] Fix broken Link https://review.openstack.org/425998 | 01:28 |
| *** yedongcan has joined #openstack-kuryr | 01:32 | |
| *** hongbin has joined #openstack-kuryr | 02:55 | |
| openstackgerrit | Merged openstack/fuxi master: Modify comment about FuxiException https://review.openstack.org/429606 | 03:08 |
| *** vikasc has joined #openstack-kuryr | 03:10 | |
| *** limao_ has quit IRC | 03:47 | |
| openstackgerrit | feng.shengqin proposed openstack/fuxi master: Fix logging format https://review.openstack.org/430051 | 04:17 |
| *** limao has joined #openstack-kuryr | 04:23 | |
| *** hongbin has quit IRC | 04:26 | |
| *** limao has quit IRC | 04:33 | |
| *** limao_ has joined #openstack-kuryr | 04:33 | |
| *** tonanhngo_ has quit IRC | 04:47 | |
| *** tonanhngo has joined #openstack-kuryr | 04:52 | |
| *** salv-orlando has joined #openstack-kuryr | 05:39 | |
| *** salv-orlando has quit IRC | 05:44 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork master: Modify fake v4 subnet result https://review.openstack.org/426698 | 06:04 |
| *** salv-orlando has joined #openstack-kuryr | 06:40 | |
| *** salv-orlando has quit IRC | 06:44 | |
| *** saneax-_-|AFK is now known as saneax | 06:45 | |
| *** salv-orlando has joined #openstack-kuryr | 07:11 | |
| *** tonanhngo has quit IRC | 07:36 | |
| *** yamamoto has quit IRC | 07:38 | |
| *** pcaruana has joined #openstack-kuryr | 07:46 | |
| *** pcaruana has quit IRC | 07:48 | |
| apuimedo | ivc_: irenab: I filled https://bugs.launchpad.net/kuryr-kubernetes/+bug/1662448 for https://review.openstack.org/#/c/422946/2//COMMIT_MSG | 07:49 |
| openstack | Launchpad bug 1662448 in kuryr-kubernetes "Handlers fail to update resources when unrelevant changes happened to the resource" [High,Confirmed] - Assigned to Ilya Chukhnakov (ichukhnakov) | 07:49 |
| apuimedo | I'll update the patch now | 07:49 |
| *** salv-orl_ has joined #openstack-kuryr | 07:49 | |
| janonymous | apuimedo: hi, i was chcking how to test tls one, but i am facing issue on how to restart services? | 07:51 |
| *** salv-orlando has quit IRC | 07:52 | |
| apuimedo | which issue? | 07:52 |
| apuimedo | IMHO you could probably use post-config section of devstack, so the changes happen before the services start | 07:52 |
| janonymous | apuimdeo: how to restart services with different parametes in FT and restore to original state | 07:53 |
| janonymous | apuimedo: ohkay, should i go with devstack or FT? | 07:53 |
| *** limao_ has quit IRC | 07:54 | |
| janonymous | yeah devstack would be good, thanks | 07:54 |
| irenab | janonymous, sounds like both are required | 07:54 |
| irenab | devstack to deploy, FT to verify | 07:54 |
| *** pcaruana has joined #openstack-kuryr | 07:55 | |
| janonymous | irenab: But in FT i have to use os.something call for docker and kuryr server startup with parameters which might change original env | 07:56 |
| irenab | I meant that both are useful for different purposes | 07:56 |
| *** yedongcan1 has joined #openstack-kuryr | 07:56 | |
| *** yedongcan has quit IRC | 07:57 | |
| janonymous | Would this go in pike cycle then? as it would take some time for me | 07:58 |
| *** limao has joined #openstack-kuryr | 07:59 | |
| apuimedo | janonymous: I think tls should be a separate job | 08:00 |
| janonymous | apuimedo: totally agree | 08:01 |
| *** tonanhngo has joined #openstack-kuryr | 08:03 | |
| janonymous | apuimedo: irenab: so, would this be going in next release or this? | 08:03 |
| *** tonanhngo has quit IRC | 08:04 | |
| irenab | janonymous, I will let apuimedo to decide, he is checking regarding the dates to cut Ocata release branch | 08:08 |
| janonymous | sure, If in pike cycle i was thinking to do after vtg session on high priority, but if now then no option :) | 08:09 |
| apuimedo | then we move it :P | 08:10 |
| janonymous | Haha :P | 08:11 |
| janonymous | apuimedo, irenab: Thanks | 08:12 |
| janonymous | one thing to mention, i ran fullstack tests a few times but some problems in that after first run, like network quota exceed, for which i have to increase limit and rerun.. | 08:13 |
| apuimedo | understood | 08:15 |
| *** salv-orlando has joined #openstack-kuryr | 08:15 | |
| janonymous | also some problem with network deletions, but that i will check to be sure of it is a problem | 08:16 |
| *** salv-orl_ has quit IRC | 08:21 | |
| irenab | janonymous, quota issue may be related to deletion problem | 08:23 |
| janonymous | irenab: yeah, but by default also, for kuryr some quote needs might need to be increased | 08:24 |
| janonymous | irenab: might be for ports and network | 08:24 |
| irenab | ok | 08:24 |
| janonymous | thanks! | 08:24 |
| *** yamamoto has joined #openstack-kuryr | 08:32 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork master: Use Neutron tag-ext extension https://review.openstack.org/428002 | 09:04 |
| *** salv-orlando has quit IRC | 09:04 | |
| *** salv-orlando has joined #openstack-kuryr | 09:07 | |
| yedongcan1 | irenab: thanks for your suggestion and review, update a new patch now. | 09:08 |
| irenab | yedongcan1, please consider my comment as suggestion only, just wanted to skip code duplication | 09:09 |
| yedongcan1 | irenab: it's a good idea. :) | 09:10 |
| *** limao has quit IRC | 09:19 | |
| *** yamamoto has quit IRC | 09:30 | |
| *** yamamoto has joined #openstack-kuryr | 09:33 | |
| *** yamamoto has quit IRC | 09:39 | |
| *** garyloug has joined #openstack-kuryr | 09:40 | |
| *** salv-orl_ has joined #openstack-kuryr | 10:19 | |
| *** salv-orlando has quit IRC | 10:21 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork master: Use Neutron tag-ext extension https://review.openstack.org/428002 | 10:42 |
| *** gsagie has joined #openstack-kuryr | 10:54 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork master: Use Neutron tag-ext extension https://review.openstack.org/428002 | 11:04 |
| *** yedongcan1 has left #openstack-kuryr | 11:12 | |
| *** garyloug has quit IRC | 11:12 | |
| *** garyloug has joined #openstack-kuryr | 11:25 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork master: Use Neutron tag-ext extension https://review.openstack.org/428002 | 11:35 |
| *** salv-orl_ has quit IRC | 11:47 | |
| *** salv-orlando has joined #openstack-kuryr | 11:48 | |
| *** tonanhngo has joined #openstack-kuryr | 12:05 | |
| *** tonanhngo has quit IRC | 12:06 | |
| *** garyloug has quit IRC | 12:40 | |
| *** saneax is now known as saneax-_-|AFK | 12:53 | |
| *** garyloug has joined #openstack-kuryr | 12:59 | |
| *** salv-orlando has quit IRC | 13:09 | |
| *** salv-orlando has joined #openstack-kuryr | 13:50 | |
| *** limao has joined #openstack-kuryr | 14:11 | |
| *** limao has quit IRC | 14:22 | |
| *** limao has joined #openstack-kuryr | 14:30 | |
| *** limao has quit IRC | 14:32 | |
| *** limao has joined #openstack-kuryr | 14:33 | |
| *** limao has quit IRC | 14:53 | |
| *** limao has joined #openstack-kuryr | 14:54 | |
| *** tonanhngo has joined #openstack-kuryr | 14:58 | |
| *** tonanhngo has quit IRC | 14:58 | |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: Resolve 'resourceVersion' conflicts https://review.openstack.org/422946 | 14:59 |
| apuimedo | irenab: ivc_: vikasc: ltomasbo: please review ^^ | 14:59 |
| apuimedo | I'd like to get it in this week | 14:59 |
| ltomasbo | apuimedo, ok | 15:00 |
| apuimedo | thanks! | 15:00 |
| ltomasbo | done, just one nit (extra unit test) | 15:10 |
| apuimedo | :P | 15:11 |
| ltomasbo | as that was what I hit when testing | 15:11 |
| apuimedo | ltomasbo: that's a very good idea! | 15:13 |
| apuimedo | I'll push it soon | 15:13 |
| apuimedo | I'm on the meeting about how to evaluate the submissions to openstack Boston | 15:13 |
| apuimedo | Did any of you submit talks? | 15:13 |
| ltomasbo | I did not | 15:14 |
| *** limao has quit IRC | 15:15 | |
| *** limao has joined #openstack-kuryr | 15:15 | |
| *** hongbin has joined #openstack-kuryr | 15:21 | |
| apuimedo | ltomasbo: :/ Next time you should! | 15:23 |
| ltomasbo | yep! I definitely do | 15:24 |
| ltomasbo | as this is the first time the split it, I was not sure how this was going to be handled | 15:24 |
| apuimedo | I personally find it a bit weird | 15:25 |
| apuimedo | but I guess it will mean more relaxed work for the presenters in Boston | 15:25 |
| apuimedo | since no work sessions will be going on then | 15:25 |
| *** limao has quit IRC | 15:36 | |
| *** gsagie has quit IRC | 15:36 | |
| *** limao has joined #openstack-kuryr | 15:36 | |
| ltomasbo | I guess so | 15:45 |
| *** salv-orlando has quit IRC | 15:46 | |
| ivc_ | apuimedo ltomasbo i've added comment on https://review.openstack.org/#/c/422946/3 regarding the unit test | 15:54 |
| ivc_ | imo we can avoid duplicating code/ut there | 15:54 |
| ltomasbo | not sure that will work, I left another follow up comments to yours | 15:57 |
| *** limao has quit IRC | 15:57 | |
| *** limao has joined #openstack-kuryr | 15:58 | |
| *** tonanhngo has joined #openstack-kuryr | 15:59 | |
| ivc_ | ltomasbo updated | 16:02 |
| ivc_ | async chat xD | 16:02 |
| apuimedo | ivc_: ltomasbo: I already wrote the new unit test | 16:02 |
| apuimedo | pushing it now | 16:02 |
| ivc_ | apuimedo i'm pushing too lol | 16:02 |
| ltomasbo | :D | 16:02 |
| apuimedo | ivc_: come on, let me steal your work | 16:02 |
| apuimedo | xD | 16:02 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: Resolve 'resourceVersion' conflicts https://review.openstack.org/422946 | 16:03 |
| openstackgerrit | Ilya Chukhnakov proposed openstack/kuryr-kubernetes master: Resolve 'resourceVersion' conflicts https://review.openstack.org/422946 | 16:03 |
| apuimedo | ivc_: ltomasbo: check it | 16:03 |
| ivc_ | xD | 16:03 |
| ivc_ | rofl | 16:03 |
| apuimedo | ivc_: darn | 16:03 |
| apuimedo | yours ended up on top | 16:03 |
| apuimedo | anyway, whichever is fine | 16:03 |
| apuimedo | ivc_: although you should be doing services :P | 16:03 |
| ivc_ | yeah ikr | 16:04 |
| *** salv-orlando has joined #openstack-kuryr | 16:04 | |
| apuimedo | ivc_: hey, in your patchset you simplified the k8s_client code :-) | 16:05 |
| apuimedo | https://review.openstack.org/#/c/422946/4..5/kuryr_kubernetes/k8s_client.py | 16:05 |
| ivc_ | yup | 16:05 |
| apuimedo | ivc_: though your code will search needlessly through all the annotations that you are pushing | 16:06 |
| apuimedo | even though we could know that it is empty | 16:06 |
| apuimedo | now this is tempting | 16:06 |
| apuimedo | usually I prefer simpler code... | 16:06 |
| apuimedo | specially since there's not many annotations to cycle through typically | 16:06 |
| ivc_ | the overhead is trivial and it removes if/else | 16:06 |
| apuimedo | tru | 16:07 |
| apuimedo | *true | 16:07 |
| apuimedo | agreed | 16:07 |
| * apuimedo looking at the UT now | 16:07 | |
| ivc_ | i prefer to keep branching minimal | 16:07 |
| apuimedo | Hey, you killed the UT | 16:07 |
| ivc_ | yup | 16:07 |
| apuimedo | I think I'm merging your code with my UT | 16:07 |
| ivc_ | well ok. that ut is not rly needed but i dont mind :) | 16:08 |
| apuimedo | It's a legitimate test, to check that we do the right thing when there's no annotations in the conflicting object | 16:08 |
| apuimedo | ivc_: it crashed Luis | 16:08 |
| apuimedo | :P | 16:08 |
| ivc_ | that was before {} added to get | 16:08 |
| apuimedo | yes, but you need to verify that we do the right thing, otherwise future changes could regress | 16:09 |
| ltomasbo | agree with apuimedo | 16:10 |
| ivc_ | apuimedo ltomasbo i thought i had it in 'test_annotate_diff_resource_vers_no_conflict' but indeed its missing | 16:10 |
| ltomasbo | better to adapt the UT for the new code | 16:10 |
| apuimedo | ltomasbo: it works | 16:11 |
| * apuimedo pushing | 16:11 | |
| ltomasbo | ivc_, apuimedo: you are so sync! did the git review almost in the very same second! | 16:11 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: Resolve 'resourceVersion' conflicts https://review.openstack.org/422946 | 16:12 |
| ltomasbo | :D | 16:12 |
| ivc_ | apuimedo might as well update 'test_annotate_diff_resource_vers_no_conflict' | 16:12 |
| apuimedo | ivc_: about? | 16:12 |
| apuimedo | you mean to use that one for both cases? | 16:12 |
| apuimedo | I prefer to keep the cases separate | 16:12 |
| ivc_ | no i dont mind separate case | 16:13 |
| ivc_ | but for 'no_conflict' i was sure i had {a:1,b:2,c:3} ~= {a:1,b:2} case | 16:13 |
| apuimedo | ivc_: if you are ok with the code, I'll +2 | 16:13 |
| apuimedo | ivc_: did I remove some code inadvertently? | 16:14 |
| ivc_ | nope | 16:14 |
| ivc_ | gimme a sec i'll add that | 16:14 |
| ivc_ | its a good thing to test | 16:14 |
| apuimedo | very well | 16:15 |
| apuimedo | I don't suppose we have any other core up to merge this now | 16:15 |
| apuimedo | so it'll have to be tomorrow | 16:15 |
| apuimedo | ivc_: ltomasbo how does tomorrow afternoon work for you for the resource management meeting? | 16:16 |
| *** pcaruana has quit IRC | 16:17 | |
| *** limao has quit IRC | 16:17 | |
| ltomasbo | apuimedo, works for me | 16:17 |
| apuimedo | very well | 16:17 |
| ivc_ | apuimedo sorry i'm busy tomorrow, Thursday maybe? | 16:19 |
| apuimedo | ivc_: ok. I'll reschedule | 16:20 |
| ivc_ | apuimedo thnx | 16:22 |
| apuimedo | ivc_: did you get the invite? | 16:22 |
| ivc_ | apuimedo yes | 16:22 |
| apuimedo | cool | 16:22 |
| apuimedo | I'll send it to the list now | 16:22 |
| ivc_ | apuimedo ok i will not update 'no_conflict'. it gets too complicated :/ | 16:25 |
| apuimedo | :P | 16:26 |
| apuimedo | so then you can +1 :P | 16:26 |
| ivc_ | apuimedo already | 16:30 |
| apuimedo | cool | 16:31 |
| *** openstackgerrit has quit IRC | 16:35 | |
| *** openstackgerrit has joined #openstack-kuryr | 16:50 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork master: Modify fake v4 subnet result https://review.openstack.org/426698 | 16:50 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-kubernetes master: Resolve 'resourceVersion' conflicts https://review.openstack.org/422946 | 17:03 |
| openstackgerrit | Merged openstack/fuxi master: RBD:Make the volume to do local attach after created https://review.openstack.org/419767 | 17:20 |
| *** saneax-_-|AFK is now known as saneax | 17:36 | |
| *** tonanhngo has quit IRC | 17:47 | |
| *** garyloug has quit IRC | 17:54 | |
| *** saneax is now known as saneax-_-|AFK | 18:58 | |
| *** tonanhngo has joined #openstack-kuryr | 19:14 | |
| *** tonanhngo has quit IRC | 19:19 | |
| *** tonanhngo has joined #openstack-kuryr | 19:35 | |
| *** salv-orl_ has joined #openstack-kuryr | 19:50 | |
| *** salv-orlando has quit IRC | 19:52 | |
| *** salv-orl_ has quit IRC | 20:04 | |
| *** salv-orlando has joined #openstack-kuryr | 21:37 | |
| *** salv-orlando has quit IRC | 21:42 | |
| *** yamamoto has joined #openstack-kuryr | 21:43 | |
| *** salv-orlando has joined #openstack-kuryr | 21:50 | |
| *** yamamoto has quit IRC | 22:07 | |
| *** dougbtv has quit IRC | 22:08 | |
| *** yamamoto has joined #openstack-kuryr | 22:12 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!