| *** yamamoto has joined #openstack-kuryr | 00:00 | |
| *** yamamoto has quit IRC | 00:01 | |
| *** yamamoto has joined #openstack-kuryr | 00:05 | |
| *** yuanying has quit IRC | 00:08 | |
| *** yamamoto has quit IRC | 00:11 | |
| *** yamamoto has joined #openstack-kuryr | 00:12 | |
| janonymous | Please review : https://review.openstack.org/#/c/405203/ | 00:25 |
|---|---|---|
| *** limao has joined #openstack-kuryr | 00:44 | |
| *** roeyc has quit IRC | 00:58 | |
| *** yuanying has joined #openstack-kuryr | 01:04 | |
| *** mattmceuen is now known as mattmceuen_away | 01:08 | |
| *** saneax-_-|AFK is now known as saneax | 01:18 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Delete kuryr-subnet in existing Neutron network https://review.openstack.org/411144 | 01:42 |
| *** yedongcan has joined #openstack-kuryr | 01:44 | |
| janonymous | irenab: ping | 01:49 |
| openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: Tls support configurations https://review.openstack.org/410609 | 01:51 |
| *** saneax is now known as saneax-_-|AFK | 02:45 | |
| *** yuanying_ has joined #openstack-kuryr | 02:57 | |
| *** saneax-_-|AFK is now known as saneax | 02:58 | |
| *** yuanying has quit IRC | 03:00 | |
| openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: Tls support configurations https://review.openstack.org/410609 | 03:01 |
| *** vikasc has joined #openstack-kuryr | 03:06 | |
| *** saneax is now known as saneax-_-|AFK | 03:09 | |
| *** yuanying_ has quit IRC | 03:13 | |
| *** yuanying has joined #openstack-kuryr | 03:13 | |
| *** irenab_ has joined #openstack-kuryr | 03:15 | |
| *** irenab has quit IRC | 03:17 | |
| *** irenab_ is now known as irenab | 03:17 | |
| *** yuanying has quit IRC | 03:17 | |
| openstackgerrit | Cao Xuan Hoang proposed openstack/kuryr: Removes unnecessary utf-8 encoding https://review.openstack.org/412269 | 03:39 |
| vikasc | ivc_, ping | 04:00 |
| *** yedongcan has quit IRC | 04:26 | |
| *** limao has quit IRC | 04:28 | |
| *** limao has joined #openstack-kuryr | 04:51 | |
| *** hongbin has joined #openstack-kuryr | 04:53 | |
| *** yedongcan has joined #openstack-kuryr | 05:04 | |
| *** hongbin has quit IRC | 05:11 | |
| *** janki has joined #openstack-kuryr | 05:28 | |
| *** saneax-_-|AFK is now known as saneax | 05:35 | |
| *** yedongcan1 has joined #openstack-kuryr | 05:37 | |
| *** yamamoto has quit IRC | 05:37 | |
| *** yedongcan has quit IRC | 05:39 | |
| *** janki has quit IRC | 05:40 | |
| *** janki has joined #openstack-kuryr | 05:40 | |
| *** yedongcan1 has quit IRC | 05:42 | |
| *** yedongcan has joined #openstack-kuryr | 05:44 | |
| *** jchhatbar has joined #openstack-kuryr | 05:45 | |
| *** janki has quit IRC | 05:48 | |
| *** jchhatbar is now known as janki | 05:53 | |
| *** yuanying has joined #openstack-kuryr | 06:14 | |
| *** yuanying has quit IRC | 06:19 | |
| *** pmannidi has quit IRC | 06:32 | |
| *** yamamoto has joined #openstack-kuryr | 06:38 | |
| *** yamamoto has quit IRC | 06:38 | |
| *** yamamoto has joined #openstack-kuryr | 06:38 | |
| openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: Tls support configurations https://review.openstack.org/410609 | 06:48 |
| janonymous | apuimedo: Hi, can you please provide your inputs on ^^ | 06:49 |
| *** pmannidi has joined #openstack-kuryr | 06:49 | |
| irenab | janonymous: hi | 06:54 |
| janonymous | irenab: i pinged you regarding a comment on ^^ patch.. i guess there is not much in it to write dev op apart from readme.. | 06:55 |
| janonymous | irenab: please suggest your view | 06:56 |
| janonymous | irenab:as i could not find much on it in docker docker documentation also | 06:56 |
| irenab | janonymous: sure, will review asap | 06:57 |
| janonymous | irenab: thanks, basically i looking for more suggestions on how it could be improved or working etc.. | 06:58 |
| janonymous | irenab:thanks :) | 06:58 |
| *** oanson has joined #openstack-kuryr | 06:59 | |
| *** pmannidi has quit IRC | 07:03 | |
| *** pmannidi has joined #openstack-kuryr | 07:05 | |
| janonymous | irenab: thanks! i will wait for more comments and incorporate them in next patch :) | 07:10 |
| irenab | janonymous: thanks | 07:11 |
| irenab | janonymous: do you think its possible to add functional test for the TLS support? | 07:12 |
| janonymous | irenab: ahh..it would be quite tricky at the moment, because this patch add the supports for tls but is not a guarantee.. | 07:13 |
| janonymous | irenab: maybe not now but i will leave the bp open to do it later | 07:13 |
| irenab | janonymous: sure, as a follow up patch | 07:14 |
| janonymous | irenab:yeah, i was thinking devstack could test that , and i tried to do it in my local env | 07:14 |
| janonymous | irenab: but that has some problems .. | 07:14 |
| janonymous | irenab: FT would be cool though.. | 07:15 |
| irenab | janonymous: yes, I think unit test is not much helpful, except of checking that all expected conf values are preset or if not, there is an expected exit | 07:16 |
| janonymous | irenab: one more thing currently endpoints are not registered in keystone for kuryr.. is it expected as mostly it interact with docker on api layer? | 07:18 |
| irenab | janonymous: I am not sure, kuryr also interacts with neutron, but it behaves like cli (consuming neutron client) | 07:20 |
| janonymous | irenab: yeah, please check when you have time and let me know if that needs to be added. | 07:21 |
| irenab | janonymous: lets add it to the IRC meeting agenda in case I won’t have answer before, probably there was some decision, I just do not recall | 07:22 |
| janonymous | irenab: yeah sure! | 07:23 |
| janonymous | irenab:thanks | 07:23 |
| irenab | janonymous: you welcome | 07:23 |
| *** pcaruana has joined #openstack-kuryr | 07:33 | |
| *** dimak has joined #openstack-kuryr | 07:33 | |
| *** yedongcan has quit IRC | 07:44 | |
| *** yedongcan has joined #openstack-kuryr | 07:44 | |
| *** yedongcan has left #openstack-kuryr | 07:52 | |
| *** yedongcan has joined #openstack-kuryr | 08:12 | |
| *** yamamoto has quit IRC | 08:13 | |
| *** dimak has quit IRC | 08:19 | |
| *** gsagie has joined #openstack-kuryr | 08:57 | |
| *** dimak has joined #openstack-kuryr | 09:00 | |
| openstackgerrit | Hong Hui Xiao proposed openstack/kuryr: Add the missing AddressInUseException https://review.openstack.org/412354 | 09:02 |
| *** roeyc has joined #openstack-kuryr | 09:11 | |
| *** yamamoto has joined #openstack-kuryr | 09:14 | |
| *** yamamoto has quit IRC | 09:28 | |
| *** gsagie has quit IRC | 09:50 | |
| *** yuanying has joined #openstack-kuryr | 10:15 | |
| *** limao has quit IRC | 10:33 | |
| *** limao has joined #openstack-kuryr | 10:34 | |
| apuimedo | janonymous: will do | 10:35 |
| *** limao has quit IRC | 10:38 | |
| *** apuimedo has quit IRC | 10:41 | |
| *** apuimedo has joined #openstack-kuryr | 10:41 | |
| janonymous | apuimedo: thanks | 10:59 |
| apuimedo | you're welcome | 11:02 |
| *** yamamoto has joined #openstack-kuryr | 11:11 | |
| *** yamamoto has quit IRC | 11:22 | |
| *** janki has quit IRC | 11:38 | |
| *** lmdaly has joined #openstack-kuryr | 11:52 | |
| *** yamamoto has joined #openstack-kuryr | 12:02 | |
| *** yamamoto has quit IRC | 12:02 | |
| *** yamamoto has joined #openstack-kuryr | 12:09 | |
| *** yedongcan has left #openstack-kuryr | 12:24 | |
| *** lmdaly has quit IRC | 12:33 | |
| *** yamamoto has quit IRC | 12:44 | |
| *** yamamoto has joined #openstack-kuryr | 12:49 | |
| ivc_ | vikasc hi | 12:51 |
| *** lmdaly has joined #openstack-kuryr | 13:05 | |
| *** limao has joined #openstack-kuryr | 13:14 | |
| *** yamamoto has quit IRC | 13:15 | |
| *** limao has quit IRC | 13:34 | |
| *** limao has joined #openstack-kuryr | 13:35 | |
| vikasc | ivc_, hi | 13:40 |
| *** yamamoto has joined #openstack-kuryr | 13:44 | |
| ivc_ | vikasc you pinged me in the morning, got some questions? | 13:47 |
| vikasc | ivc_, oh i forgot totally :P | 13:48 |
| *** mattmceuen_away is now known as mattmceuen | 13:50 | |
| *** limao_ has joined #openstack-kuryr | 13:52 | |
| *** limao has quit IRC | 13:56 | |
| apuimedo | xD | 13:58 |
| irenab | ivc_: I checked the time it takes for native ovs to create large deployments, it looks likeit takes half of the time comparing to hybrid | 14:01 |
| *** garyloug has joined #openstack-kuryr | 14:02 | |
| apuimedo | irenab: Yay! | 14:03 |
| ivc_ | irenab i wish hybrid was't the 'default' one in neutron devstack. it's just such a mess by itself | 14:03 |
| apuimedo | so do we all | 14:04 |
| *** hongbin has joined #openstack-kuryr | 14:05 | |
| ivc_ | irenab also did you check with 'master' branch? in the 'services' patch i've updated async/k8sclient a bit to be more forgiving with event bursts. without it there are few unnecessary port-create->port-delete in our master branch. | 14:07 |
| irenab | ivc_: only on master branch for now, before the services patch | 14:07 |
| ivc_ | irenab i'll add those as separate patches (cut them from 'services' one) later | 14:07 |
| irenab | ivc_: great | 14:08 |
| ivc_ | irenab if you have some spare time, you could try with current services patch (for those async/k8sclient changes). it would probably give you even better results | 14:09 |
| irenab | ivc_: thanks, will try later today/tomorrow | 14:09 |
| *** yedongcan has joined #openstack-kuryr | 14:12 | |
| apuimedo | irenab: with native ovs binding it should work already with dragonflow right? Or are there extra modifications necessary? | 14:12 |
| irenab | apuimedo: tested with dragonflow | 14:12 |
| ivc_ | irenab thats even more awesome then! xD | 14:12 |
| irenab | apuimedo: it uses native ovs, no special additions | 14:12 |
| apuimedo | irenab: well, there's some differences, AFAIK there's no OVS agent <--> neutron rpc dances | 14:13 |
| apuimedo | is there? | 14:13 |
| *** limao has joined #openstack-kuryr | 14:13 | |
| irenab | apuimedo: correct, I was refering to the integration code. the devstack config is different | 14:14 |
| irenab | apuimedo: DF is similar to MidoNet in this sense | 14:14 |
| apuimedo | irenab: so your halved times may have a lot to do with that, right? | 14:15 |
| ivc_ | apuimedo i think what irenab means is that we'll probably have the same code in kuryr for all of df/midonet/ovn/native-ovs | 14:15 |
| irenab | apuimedo: yea | 14:15 |
| *** limao_ has quit IRC | 14:16 | |
| apuimedo | ivc_: I was hinting at the reduction being a behind the scenes thing, not due to our bridge part of the handling | 14:16 |
| ivc_ | apuimedo like in 'df is faster than neutron-ovs-native by itself'? | 14:17 |
| apuimedo | ivc_: right | 14:18 |
| apuimedo | ivc_: the port getting active most likely takes much less | 14:18 |
| ivc_ | apuimedo anyway, it only proves that kuryr is not the problem :) | 14:20 |
| irenab | ivc_: neutron-native-ovs is supposed to work? | 14:20 |
| ivc_ | irenab not in master, but with your patch it probably will | 14:21 |
| apuimedo | ivc_: but we need to pinpoint who to nag | 14:21 |
| apuimedo | :-) | 14:21 |
| janonymous | review link: https://review.openstack.org/#/c/405203/ | 14:49 |
| mchiappero | about mox, my test_kuryr.py still has mox | 14:59 |
| openstackgerrit | Merged openstack/fuxi: Updated from global requirements https://review.openstack.org/373745 | 15:00 |
| janonymous | mchiappero: please use mock | 15:00 |
| alraddarla_ | mchiappero, this patch removes mox from test_kuryr.py | 15:00 |
| mchiappero | janonymous: do you think it would be possible for you to get mine merged first? | 15:00 |
| mchiappero | I did some additions, I would need to rebase | 15:00 |
| mchiappero | either me or you | 15:01 |
| mchiappero | alraddarla_: I used mock for new tests, of course | 15:01 |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi: Separate unit tests from fullstack tests https://review.openstack.org/403931 | 15:01 |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi: Add basic fullstack volume tests https://review.openstack.org/403941 | 15:01 |
| alraddarla_ | mchiappero: either way. I believe janonymous and I had recently rebased this patch | 15:02 |
| alraddarla_ | Don't remember which patch caused the merge conflict though | 15:02 |
| *** limao has quit IRC | 15:04 | |
| *** yedongcan has left #openstack-kuryr | 15:04 | |
| mchiappero | rebased on top of? | 15:04 |
| janonymous | mchiappero: tough call.. | 15:05 |
| *** limao has joined #openstack-kuryr | 15:06 | |
| *** hongbin has quit IRC | 15:06 | |
| janonymous | mchiappero: cores can decide which way they prefer i am okay, just we had rebased and created whole patch again | 15:06 |
| janonymous | mchiappero: so was trying not to rework again | 15:07 |
| janonymous | mchiappero: :) | 15:07 |
| mchiappero | me too | 15:07 |
| mchiappero | that's why I was hoping for your partch to be merged earlier past week :) | 15:07 |
| openstackgerrit | Antoni Segura Puimedon proposed openstack/kuryr-libnetwork: Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 15:08 |
| apuimedo | sorry to both | 15:08 |
| apuimedo | it's sometimes hard to avoid this kind of issues when in the middle of several refactoring | 15:08 |
| apuimedo | *refactoring efforts | 15:08 |
| apuimedo | irenab: vikasc: https://review.openstack.org/#/c/400365/29 | 15:09 |
| apuimedo | I added the comments in the commit message about the workaroudn | 15:09 |
| apuimedo | *workaround | 15:09 |
| apuimedo | ok, it seems it's easier to rebase the mock patch | 15:15 |
| apuimedo | mchiappero: alraddarla_: janonymous: ^^ | 15:15 |
| janonymous | i will leave it to you guys :) .. gtg ! gn :) | 15:16 |
| mchiappero | I'm okay with any solution, I just have little time this week I'm afraid | 15:16 |
| apuimedo | janonymous: thanks | 15:17 |
| alraddarla_ | mchiappero, let me know when your patch gets merged and i will rebase on top of that. I have some time this week | 15:17 |
| apuimedo | alraddarla_: thanks a lot for that | 15:17 |
| apuimedo | and sorry for the trouble | 15:17 |
| mchiappero | apuimedo: alraddarla_: thank you | 15:17 |
| alraddarla_ | no problem :) | 15:17 |
| *** limao_ has joined #openstack-kuryr | 15:22 | |
| *** limao has quit IRC | 15:25 | |
| openstackgerrit | Merged openstack/kuryr-kubernetes: Updated from global requirements https://review.openstack.org/409797 | 15:27 |
| *** mattmceuen is now known as mattmceuen_away | 15:36 | |
| *** yamamoto has quit IRC | 15:38 | |
| *** limao has joined #openstack-kuryr | 15:43 | |
| *** saneax is now known as saneax-_-|AFK | 15:43 | |
| *** limao_ has quit IRC | 15:45 | |
| *** roeyc has quit IRC | 16:03 | |
| *** limao_ has joined #openstack-kuryr | 16:04 | |
| *** dimak has quit IRC | 16:05 | |
| *** limao has quit IRC | 16:06 | |
| *** hongbin has joined #openstack-kuryr | 16:10 | |
| *** pcaruana has quit IRC | 16:15 | |
| mattmceuen_away | I have a kuryr-libnetwork newbie question, and was wondering whether anyone can point me in the right direction. I'm pulling a container via "docker pull kuryr/libnetwork:latest", and am pointing it at my keystone and starting it per the readme. | 16:21 |
| *** mattmceuen_away is now known as mattmceuen | 16:21 | |
| mattmceuen | I get the following error when trying to create a network: "Error response from daemon: failed to allocate gateway (): No address returned" | 16:21 |
| mattmceuen | I see logs in my kuryr docker logs, but nothing that looks like an error. Is that message a smoking gun for anything in particular? | 16:22 |
| mchiappero | anyone: the order of the unit tests is not predictable, right? | 16:22 |
| apuimedo | mattmceuen: I have to update that container | 16:23 |
| mattmceuen | Ok - better if I build from source? | 16:23 |
| apuimedo | my server that was mirroring kuryr-libnetwork for docker hub did not survive my moving to a new housing | 16:23 |
| mattmceuen | haha | 16:23 |
| apuimedo | yeah... I need to move it again to the cubieboard2 | 16:24 |
| apuimedo | mattmceuen: please, use devstack in the meantime | 16:24 |
| apuimedo | mchiappero: nope | 16:24 |
| mattmceuen | ok, thanks apuimedo! will try that later today. | 16:24 |
| apuimedo | but you can trigger them individually if you are trying to reproduce some disaster | 16:24 |
| apuimedo | :-) | 16:24 |
| apuimedo | mattmceuen: great! | 16:24 |
| apuimedo | Let us know | 16:24 |
| mchiappero | apuimedo: nope = not predictable? | 16:25 |
| mchiappero | :D | 16:25 |
| *** limao has joined #openstack-kuryr | 16:25 | |
| apuimedo | mchiappero: less predictable than the departure of a Spanish train | 16:25 |
| mchiappero | :D | 16:26 |
| mchiappero | ok, so i need to update the tests then | 16:26 |
| mchiappero | how do I mock config values? | 16:26 |
| mchiappero | I think the tests failed because in some tests I need to change the config value | 16:27 |
| mchiappero | I guess I needto patch | 16:27 |
| apuimedo | mchiappero: for which reason you think the order made it fail | 16:27 |
| apuimedo | tests should be self standing, or did you mock something in one expecting it to be the same afterwards? | 16:28 |
| mchiappero | http://logs.openstack.org/65/400365/29/gate/gate-kuryr-libnetwork-python35/a553887/testr_results.html.gz | 16:29 |
| *** limao_ has quit IRC | 16:29 | |
| mchiappero | the failed one tests the default value, but in other tests I change the value of that config entry for further testing | 16:29 |
| mchiappero | I guess that's why it failed there but did not previously | 16:30 |
| apuimedo | mchiappero: can you point me to where you change that value? | 16:31 |
| apuimedo | maybe I missed something | 16:31 |
| mchiappero | https://review.openstack.org/#/c/400365/29/kuryr_libnetwork/tests/unit/port_driver/test_driver.py | 16:32 |
| mchiappero | L47 | 16:32 |
| mchiappero | L60 | 16:32 |
| mchiappero | L73 | 16:32 |
| apuimedo | maybe the value should be mocked instead | 16:33 |
| mchiappero | exactly | 16:33 |
| mchiappero | indeed I added a question in my review | 16:34 |
| mchiappero | what's the best way there? | 16:34 |
| mchiappero | how can I mock a string? Do I need to mock the conf dictionary? | 16:34 |
| apuimedo | for small things like that I usually like the patch context manager or decorator https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch | 16:36 |
| mchiappero | yes... i know | 16:38 |
| mchiappero | I used the decorator already elsewhere | 16:38 |
| *** yamamoto has joined #openstack-kuryr | 16:39 | |
| apuimedo | mchiappero: I was more meaning the ctxt manager for short tests | 16:39 |
| *** limao has quit IRC | 16:48 | |
| *** yamamoto has quit IRC | 16:49 | |
| *** limao has joined #openstack-kuryr | 16:50 | |
| *** limao has quit IRC | 17:02 | |
| *** mattmceuen is now known as mattmceuen_away | 17:08 | |
| *** lmdaly has quit IRC | 17:40 | |
| *** garyloug has quit IRC | 17:55 | |
| *** tonanhngo has joined #openstack-kuryr | 18:02 | |
| *** pc_m has quit IRC | 18:37 | |
| *** pc_m has joined #openstack-kuryr | 18:39 | |
| *** david-lyle_ has joined #openstack-kuryr | 19:13 | |
| *** david-lyle has quit IRC | 19:13 | |
| *** openstack has joined #openstack-kuryr | 19:13 | |
| *** roeyc has joined #openstack-kuryr | 19:55 | |
| *** roeyc has quit IRC | 20:29 | |
| *** saneax-_-|AFK is now known as saneax | 21:51 | |
| *** dougbtv_ has quit IRC | 22:11 | |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi: Separate unit tests from fullstack tests https://review.openstack.org/403931 | 22:35 |
| openstackgerrit | Hongbin Lu proposed openstack/fuxi: Add basic fullstack volume tests https://review.openstack.org/403941 | 22:35 |
| hongbin | jgriffith: ping | 22:41 |
| *** huikang has joined #openstack-kuryr | 23:14 | |
| *** huikang has quit IRC | 23:26 | |
| *** neiljerram has quit IRC | 23:27 | |
| *** neiljerram has joined #openstack-kuryr | 23:27 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!