| *** pmannidi has quit IRC | 00:29 | |
| *** pmannidi has joined #openstack-kuryr | 00:38 | |
| *** limao has joined #openstack-kuryr | 00:42 | |
| *** limao has quit IRC | 00:42 | |
| *** limao has joined #openstack-kuryr | 00:43 | |
| *** jgriffith is now known as jgriffith_AutoAw | 00:49 | |
| *** mattmceuen has quit IRC | 01:00 | |
| *** tonanhngo_ has quit IRC | 01:19 | |
| *** yedongcan has joined #openstack-kuryr | 01:28 | |
| *** saneax is now known as saneax-_-|AFK | 01:30 | |
| *** tonanhngo has joined #openstack-kuryr | 01:33 | |
| *** tonanhngo has quit IRC | 01:37 | |
| openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: [WIP]Unittest with mock https://review.openstack.org/405203 | 02:24 |
|---|---|---|
| *** yuanying has quit IRC | 02:50 | |
| *** yamamot__ has joined #openstack-kuryr | 02:51 | |
| *** yuanying has joined #openstack-kuryr | 03:50 | |
| *** yuanying has quit IRC | 03:50 | |
| *** yuanying has joined #openstack-kuryr | 03:51 | |
| *** yuanying has quit IRC | 04:23 | |
| *** yuanying has joined #openstack-kuryr | 04:24 | |
| *** yuanying has quit IRC | 04:24 | |
| *** yuanying has joined #openstack-kuryr | 04:25 | |
| *** yuanying has quit IRC | 04:25 | |
| *** yedongcan has quit IRC | 04:43 | |
| *** yedongcan has joined #openstack-kuryr | 05:06 | |
| *** yuanying has joined #openstack-kuryr | 05:26 | |
| *** yuanying has quit IRC | 05:35 | |
| *** yuanying has joined #openstack-kuryr | 05:36 | |
| *** tonanhngo has joined #openstack-kuryr | 05:42 | |
| *** saneax-_-|AFK is now known as saneax | 05:46 | |
| *** yuanying has quit IRC | 05:49 | |
| *** yedongcan has quit IRC | 06:09 | |
| *** yedongcan has joined #openstack-kuryr | 06:20 | |
| *** yuanying has joined #openstack-kuryr | 06:28 | |
| *** oanson has joined #openstack-kuryr | 06:45 | |
| *** yuanying_ has joined #openstack-kuryr | 06:55 | |
| *** yuanying has quit IRC | 06:58 | |
| *** yuanying_ has quit IRC | 07:14 | |
| *** yamamot__ has quit IRC | 07:14 | |
| *** yedongcan1 has joined #openstack-kuryr | 07:25 | |
| *** yedongcan has quit IRC | 07:27 | |
| *** janki has joined #openstack-kuryr | 07:27 | |
| *** ram______ has quit IRC | 07:29 | |
| *** oanson has quit IRC | 07:33 | |
| apuimedo | yedongcan1: done | 07:47 |
| apuimedo | thanks! | 07:47 |
| *** tonanhngo has quit IRC | 07:49 | |
| apuimedo | yedongcan1: I put a comment on https://bugs.launchpad.net/kuryr-libnetwork/+bug/1648326 | 07:51 |
| openstack | Launchpad bug 1648326 in kuryr-libnetwork "Plugin lifecycle order should be correct" [Undecided,New] - Assigned to janonymous (janonymous) | 07:51 |
| yedongcan1 | apuidemo: thanks, :P | 07:53 |
| apuimedo | mchiappero: as soon as we have the vlan/macvlan drivers on kuryr-libnetwork | 07:54 |
| *** tonanhngo has joined #openstack-kuryr | 08:00 | |
| *** yamamot__ has joined #openstack-kuryr | 08:02 | |
| *** tonanhngo has quit IRC | 08:05 | |
| janonymous | apuimedo: thanks :P | 08:13 |
| janonymous | apuimedo: should it needs to be changed? | 08:14 |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Fix default subnetpool assignments from config file https://review.openstack.org/397640 | 08:14 |
| *** pcaruana has joined #openstack-kuryr | 08:16 | |
| openstackgerrit | Zhigang Li proposed openstack/kuryr-libnetwork: Replace six.iteritems() with .items() https://review.openstack.org/401056 | 08:19 |
| *** yamamot__ has quit IRC | 08:41 | |
| apuimedo | janonymous: I'm not sure | 08:45 |
| *** janki has quit IRC | 08:47 | |
| janonymous | apuimedo: okays.. | 08:47 |
| apuimedo | janonymous: what was the question? :P | 08:49 |
| janonymous | apuimedo: haha | 08:50 |
| janonymous | >>https://bugs.launchpad.net/kuryr-libnetwork/+bug/1648326 | 08:51 |
| openstack | Launchpad bug 1648326 in kuryr-libnetwork "Plugin lifecycle order should be correct" [Undecided,New] - Assigned to janonymous (janonymous) | 08:51 |
| *** janki has joined #openstack-kuryr | 08:53 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Replace six.iteritems() with .items() https://review.openstack.org/401056 | 08:54 |
| apuimedo | janonymous: ah right! | 09:00 |
| apuimedo | I think that it is okay as it is. But I'm not against it being fixed | 09:00 |
| janonymous | apuimedo: i will fix the bug as invalid :P | 09:00 |
| apuimedo | janonymous: I just confirmed it and set the importance | 09:00 |
| apuimedo | to low | 09:01 |
| apuimedo | so that we keep awareness of it | 09:01 |
| janonymous | apuimedo: that makes sense. | 09:01 |
| janonymous | apuimedo: thanks | 09:01 |
| apuimedo | thanks to you for checking! | 09:01 |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: Fix bug in ipam_release_address https://review.openstack.org/401874 | 09:02 |
| openstackgerrit | Merged openstack/fuxi: Move from "tenant" to "project" https://review.openstack.org/406189 | 09:02 |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Fix bug in ipam_release_address https://review.openstack.org/401874 | 09:30 |
| openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: [WIP]Unittest with mock https://review.openstack.org/405203 | 09:32 |
| *** garyloug has joined #openstack-kuryr | 09:59 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: OS_HOST_IP is not working, replacing with HOST_IP https://review.openstack.org/407352 | 10:05 |
| mchiappero | hi all | 10:14 |
| mchiappero | is there any observer pattern/subscription model for neutron? | 10:15 |
| apuimedo | mchiappero: for which data? | 10:23 |
| apuimedo | ivc_: http://paste.openstack.org/show/591912/ | 10:23 |
| apuimedo | this is with the services devstack patch | 10:23 |
| mchiappero | whatever, ports, networks | 10:23 |
| mchiappero | say someone else from the outside manipulates our ports? | 10:24 |
| apuimedo | well, there is a subscription you can do in rabbitmq | 10:24 |
| apuimedo | like ceilometer does | 10:24 |
| apuimedo | (or the neutron agents) | 10:24 |
| mchiappero | a bit low level | 10:24 |
| apuimedo | which is the use case? | 10:24 |
| mchiappero | whatever, say someone breaks the port of your vm? | 10:25 |
| mchiappero | probably it's actually impossible | 10:25 |
| mchiappero | but in general, port goes down | 10:25 |
| mchiappero | if you are not the only player in the system you might need to know if someone else did something that might affect you | 10:26 |
| apuimedo | I guess you'd use some notification system | 10:37 |
| apuimedo | I think vitrage had some alerts | 10:37 |
| * apuimedo has to go for a few hours | 10:37 | |
| *** apuimedo is now known as apuimedo|away | 10:37 | |
| *** yedongcan1 has left #openstack-kuryr | 10:39 | |
| *** garyloug has quit IRC | 10:45 | |
| *** janki has quit IRC | 10:47 | |
| mchiappero | is kuryr-libnetwork multi threading? | 10:50 |
| mchiappero | is there a change of concurrent calls for containers? | 10:50 |
| mchiappero | sorry, *a chance | 10:52 |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: [WIP] Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 10:53 |
| *** janki has joined #openstack-kuryr | 10:58 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: [WIP] Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 11:12 |
| mchiappero | ok, rebased once again | 11:15 |
| mchiappero | please review | 11:15 |
| mchiappero | I might add a hook for ipam_request_pool but I might not, or do it in a follow up patch | 11:16 |
| *** yedongcan1 has joined #openstack-kuryr | 11:17 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: [WIP] Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 11:30 |
| *** limao has quit IRC | 11:34 | |
| *** david-lyle_ has joined #openstack-kuryr | 11:35 | |
| *** david-lyle has quit IRC | 11:37 | |
| mchiappero | janonymous: is 405203 done? | 11:46 |
| mchiappero | it's probably the only change I would like to be merged before our patch | 11:47 |
| mchiappero | :D | 11:47 |
| *** tonanhngo has joined #openstack-kuryr | 12:02 | |
| *** tonanhngo has quit IRC | 12:03 | |
| *** oanson has joined #openstack-kuryr | 12:13 | |
| *** yedongcan1 has left #openstack-kuryr | 12:37 | |
| *** garyloug has joined #openstack-kuryr | 12:42 | |
| *** pcaruana has quit IRC | 13:05 | |
| *** pcaruana has joined #openstack-kuryr | 13:08 | |
| *** fkautz has quit IRC | 13:28 | |
| *** fkautz has joined #openstack-kuryr | 13:29 | |
| *** mchiappero has quit IRC | 13:52 | |
| *** janki has quit IRC | 13:59 | |
| *** mchiappero has joined #openstack-kuryr | 14:06 | |
| *** yamamoto has joined #openstack-kuryr | 14:25 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: [WIP] Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 14:33 |
| *** yamamoto has quit IRC | 14:39 | |
| *** pcaruana has quit IRC | 14:42 | |
| *** yamamoto has joined #openstack-kuryr | 14:44 | |
| *** saneax is now known as saneax-_-|AFK | 14:52 | |
| *** pcaruana has joined #openstack-kuryr | 14:56 | |
| *** tonanhngo has joined #openstack-kuryr | 15:02 | |
| *** tonanhngo has quit IRC | 15:02 | |
| *** yamamoto has quit IRC | 15:10 | |
| *** yamamoto has joined #openstack-kuryr | 15:14 | |
| *** yamamoto has quit IRC | 15:16 | |
| *** yamamoto has joined #openstack-kuryr | 15:18 | |
| *** vikasc has joined #openstack-kuryr | 15:18 | |
| *** yamamoto has quit IRC | 15:21 | |
| *** yamamoto has joined #openstack-kuryr | 15:43 | |
| *** yamamoto has quit IRC | 15:47 | |
| *** yamamoto has joined #openstack-kuryr | 15:48 | |
| *** hongbin has joined #openstack-kuryr | 15:59 | |
| *** tonanhngo has joined #openstack-kuryr | 16:09 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: [WIP] Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 16:21 |
| apuimedo|away | mchiappero: it is not multithreading unless you run it under uwsgi (In contrib I have some sample uwsgi for the docker container) | 16:27 |
| *** mattmceuen has joined #openstack-kuryr | 16:30 | |
| *** yamamoto has quit IRC | 16:33 | |
| *** yamamoto has joined #openstack-kuryr | 16:37 | |
| *** yamamoto has quit IRC | 16:41 | |
| *** yamamoto has joined #openstack-kuryr | 16:43 | |
| *** yamamoto has quit IRC | 16:43 | |
| apuimedo|away | mchiappero: still fails the unit tests | 16:44 |
| *** yamamoto has joined #openstack-kuryr | 16:46 | |
| mchiappero | I know, working on it | 16:48 |
| mchiappero | there are a few things I'm not sure about, I'll ask later | 16:48 |
| mchiappero | but what I don't understand is whether the code is ok with you or not | 16:49 |
| *** yamamoto has quit IRC | 16:51 | |
| apuimedo|away | mchiappero: I'm reviewing it now | 16:52 |
| apuimedo|away | mchiappero: 'or_throw' Java is leaking! | 16:55 |
| apuimedo|away | xD | 16:55 |
| mchiappero | it's rather c++, not java | 17:01 |
| mchiappero | never saw anything like that in java | 17:01 |
| mchiappero | it would be possible to cache the port_id there, but then we would need locks | 17:02 |
| mchiappero | let's do that later, if useful | 17:02 |
| *** pcaruana has quit IRC | 17:03 | |
| apuimedo|away | I'm gonna post other comments asap | 17:04 |
| mchiappero | I'm still not 100% sure on certain expectations from neutron, some values are optional, but still there and not removable, the API is clear with what is mandatory and what is not, but still... | 17:04 |
| apuimedo|away | I'm on driver.py | 17:04 |
| mchiappero | cool, thanks :) | 17:04 |
| mchiappero | otherwise UT can't be fully unblocked | 17:04 |
| mchiappero | and I need some help there, I have a few questions | 17:05 |
| apuimedo|away | which? | 17:06 |
| mchiappero | Uhm, I need to check exactly but do we need to test each driver? (I guess so) | 17:11 |
| apuimedo|away | yup | 17:11 |
| mchiappero | When mocking elsewhere, which one should be faked? | 17:11 |
| mchiappero | any behaviour is fine? | 17:12 |
| apuimedo|away | in a few cases you can maybe use a sentinel | 17:12 |
| mchiappero | that is? | 17:12 |
| mchiappero | so, say successes, are to be tested agains all the drivers or one is fine? | 17:13 |
| apuimedo|away | for each driver you only test its specific part | 17:13 |
| *** garyloug has quit IRC | 17:14 | |
| apuimedo|away | and for the generic part, you test that the right driver method is being selected | 17:14 |
| mchiappero | yes, but for testing controllers | 17:14 |
| *** yamamoto has joined #openstack-kuryr | 17:15 | |
| mchiappero | and faking any driver there is fine? | 17:15 |
| apuimedo|away | https://github.com/openstack/kuryr-kubernetes/blob/97e8cad63d0523952cc325057bf19f29b758c88b/kuryr_kubernetes/tests/unit/controller/drivers/test_generic_vif.py | 17:15 |
| apuimedo|away | exactly | 17:15 |
| mchiappero | I'll have a look :) | 17:15 |
| apuimedo|away | faking driver should be used | 17:15 |
| mchiappero | thanks | 17:15 |
| apuimedo|away | thanks to you ;-) | 17:15 |
| *** yamamoto has quit IRC | 17:18 | |
| apuimedo|away | mchiappero: review posted | 17:28 |
| mchiappero | thank you, I'll have a look asap | 17:29 |
| apuimedo|away | ;-) | 17:31 |
| apuimedo|away | you're welcome | 17:31 |
| *** apuimedo|away is now known as apuimedo | 17:31 | |
| mchiappero | have you been gentle enough? :P | 17:31 |
| *** yamamoto has joined #openstack-kuryr | 17:34 | |
| apuimedo | hopefully | 17:36 |
| *** yamamoto has quit IRC | 17:36 | |
| *** yamamoto has joined #openstack-kuryr | 17:39 | |
| mchiappero | apuimedo: https://review.openstack.org/#/c/400365/7/kuryr_libnetwork/port_driver/drivers/nested.py@177 | 17:44 |
| mchiappero | I agree with your comment BTW | 17:44 |
| mchiappero | regarding _get_port_from_host_iface_or_throw the two methods can be merged but have a slighly differen purposes | 17:46 |
| mchiappero | *different | 17:46 |
| *** yamamoto has quit IRC | 17:52 | |
| *** yamamoto has joined #openstack-kuryr | 17:56 | |
| *** yamamoto has quit IRC | 17:58 | |
| *** vikasc has quit IRC | 18:00 | |
| *** yamamoto has joined #openstack-kuryr | 18:00 | |
| *** jgriffith_AutoAw is now known as jgriffith | 18:14 | |
| *** yamamoto has quit IRC | 18:22 | |
| *** david-lyle_ is now known as david-lyle | 19:13 | |
| apuimedo | mchiappero: can you expand on the different purposes? | 19:17 |
| *** jgriffith is now known as jgriffith_AutoAw | 19:24 | |
| *** jgriffith_AutoAw is now known as jgriffith | 19:40 | |
| *** openstack has joined #openstack-kuryr | 19:44 | |
| mchiappero | the first one is for retrieving the matching port, the second is more for lookup purposes (at the moment retrieving all the time), and have different contract, I don't personally understand what you mean by "idiomatic", also the first one can throw, but has a different contract | 19:46 |
| mchiappero | http://paste.openstack.org/show/prSMkVmlJlVMYv0O4oZs/ | 19:46 |
| mchiappero | anyway I'll place everything in a single method | 19:47 |
| *** mattmceuen is now known as mattmceuen_away | 19:51 | |
| *** mattmceuen_away is now known as mattmceuen | 20:16 | |
| *** mattmceuen is now known as mattmceuen_away | 20:53 | |
| *** mattmceuen_away is now known as mattmceuen | 21:15 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: [WIP] Driver based model for kuryr-libnetwork https://review.openstack.org/400365 | 21:39 |
| *** mattmceuen is now known as mattmceuen_away | 22:16 | |
| *** jgriffith is now known as jgriffith_AutoAw | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!