| *** shashank_hegde has quit IRC | 00:20 | |
| *** shashank_hegde has joined #openstack-kuryr | 00:22 | |
| *** limao has joined #openstack-kuryr | 00:29 | |
| *** yedongcan has joined #openstack-kuryr | 00:58 | |
| *** tonanhngo has quit IRC | 01:17 | |
| *** yedongcan has quit IRC | 01:20 | |
| *** yedongcan has joined #openstack-kuryr | 01:20 | |
| *** tonanhngo has joined #openstack-kuryr | 01:28 | |
| *** devlaps has quit IRC | 01:32 | |
| *** tonanhngo has quit IRC | 01:32 | |
| *** shashank_hegde has quit IRC | 01:40 | |
| *** hongbin has joined #openstack-kuryr | 01:42 | |
| *** shashank_hegde has joined #openstack-kuryr | 01:42 | |
| openstackgerrit | Dongcan Ye proposed openstack/kuryr-libnetwork: DO NOT MERGE: TEST https://review.openstack.org/405043 | 01:50 |
|---|---|---|
| *** shashank_hegde has quit IRC | 01:57 | |
| *** pmannidi has quit IRC | 01:58 | |
| *** pmannidi has joined #openstack-kuryr | 02:00 | |
| *** wanghua has joined #openstack-kuryr | 02:22 | |
| *** dougbtv has joined #openstack-kuryr | 02:42 | |
| *** yuanying has quit IRC | 02:51 | |
| *** yuanying has joined #openstack-kuryr | 02:51 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Unittests with mock https://review.openstack.org/394324 | 02:51 |
| *** saneax-_-|AFK is now known as saneax | 02:56 | |
| *** vikasc has quit IRC | 03:07 | |
| *** vikasc has joined #openstack-kuryr | 03:21 | |
| *** shashank_hegde has joined #openstack-kuryr | 03:28 | |
| *** vikasc has quit IRC | 03:45 | |
| *** yuanying has quit IRC | 03:46 | |
| *** vikasc has joined #openstack-kuryr | 03:58 | |
| *** yedongcan has quit IRC | 04:01 | |
| *** yedongcan has joined #openstack-kuryr | 04:01 | |
| *** yamamot__ has joined #openstack-kuryr | 04:16 | |
| *** hongbin has quit IRC | 04:21 | |
| *** yedongcan has quit IRC | 04:21 | |
| *** jgriffith is now known as jgriffith_away | 04:28 | |
| *** shashank_hegde has quit IRC | 04:31 | |
| *** saneax is now known as saneax-_-|AFK | 04:36 | |
| *** shashank_hegde has joined #openstack-kuryr | 04:36 | |
| *** tonanhngo has joined #openstack-kuryr | 04:37 | |
| *** yuanying has joined #openstack-kuryr | 04:48 | |
| *** yuanying_ has joined #openstack-kuryr | 04:55 | |
| *** yuanying has quit IRC | 04:57 | |
| *** yuanying has joined #openstack-kuryr | 05:02 | |
| *** yuanying_ has quit IRC | 05:04 | |
| *** shashank_hegde has quit IRC | 05:07 | |
| *** yuanying_ has joined #openstack-kuryr | 05:10 | |
| *** yuanying has quit IRC | 05:11 | |
| *** yedongcan has joined #openstack-kuryr | 05:33 | |
| *** yamamot__ has quit IRC | 05:37 | |
| *** yamamot__ has joined #openstack-kuryr | 05:37 | |
| *** pmannidi_ has joined #openstack-kuryr | 05:48 | |
| *** pmannidi has quit IRC | 05:48 | |
| *** pmannidi_ is now known as pmannidi | 05:48 | |
| *** janki has joined #openstack-kuryr | 05:56 | |
| *** shashank_hegde has joined #openstack-kuryr | 06:17 | |
| *** yuanying_ has quit IRC | 06:18 | |
| *** shashank_hegde has quit IRC | 06:45 | |
| *** saneax-_-|AFK is now known as saneax | 06:45 | |
| *** shashank_hegde has joined #openstack-kuryr | 06:54 | |
| *** oanson has joined #openstack-kuryr | 07:24 | |
| *** tonanhngo has quit IRC | 07:25 | |
| *** tonanhngo has joined #openstack-kuryr | 07:26 | |
| *** vikasc has quit IRC | 07:27 | |
| *** vikasc has joined #openstack-kuryr | 07:31 | |
| *** yuanying has joined #openstack-kuryr | 08:27 | |
| *** shashank_hegde has quit IRC | 08:32 | |
| *** lezbar has joined #openstack-kuryr | 08:49 | |
| *** lezbar has quit IRC | 08:51 | |
| *** gsagie has joined #openstack-kuryr | 08:52 | |
| apuimedo|away | ivc_: can you confirm that when you install kuryr-kubernetes from master it pulls 0.2.0 ? | 09:01 |
| *** gsagie has quit IRC | 09:03 | |
| openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/kuryr-libnetwork: WIP: Unittest with mock https://review.openstack.org/405203 | 09:09 |
| ivc_ | apuimedo|away, i've not tried installing it after the requirements got merged. but i've manually patched upper-constraints.txt in requirements and it does pull 0.2.0 | 09:16 |
| *** lezbar has joined #openstack-kuryr | 09:17 | |
| apuimedo|away | ok | 09:21 |
| *** apuimedo|away is now known as apuimedo | 09:21 | |
| apuimedo | ivc_: I'm now trying to fix the certificate generation | 09:21 |
| janonymous | alraddarla_: Hi, please continue with patch if you would like to work on mox, patch 405203 . i have uploaded semi completed one | 09:22 |
| ivc_ | apuimedo now this is stupid... i've set kuryr-lib>=0.2.0 in requirements.txt but it does complain about conflict with requirements/requirements.txt having 0.1.0 | 09:22 |
| apuimedo | ivc_: you can't :-) | 09:22 |
| apuimedo | I had to abandon my patch | 09:22 |
| apuimedo | because of it | 09:22 |
| ivc_ | apuimedo i'll set to 0.1.0, but that does not make sense - i'm using api from 0.2.0! | 09:22 |
| apuimedo | you can't have different values on any project than in global requirements | 09:23 |
| *** devvesa has joined #openstack-kuryr | 09:23 | |
| janonymous | alraddarla_: let me know in case any assistance is required | 09:23 |
| apuimedo | I know | 09:23 |
| apuimedo | their checker is a bit silly IMHO | 09:23 |
| openstackgerrit | Ilya Chukhnakov proposed openstack/kuryr-kubernetes: Experimental CNI & VIFBridge binding https://review.openstack.org/404038 | 09:23 |
| apuimedo | they should allow projects to enforce contrants that are subsets of global reuqirements | 09:23 |
| ivc_ | yeah. otherwise it only leads to bugs | 09:24 |
| apuimedo | indeed | 09:25 |
| apuimedo | when I fix the setup files I'll check with the requirements team | 09:25 |
| apuimedo | this is bothering | 09:25 |
| *** yedongcan has left #openstack-kuryr | 09:36 | |
| *** wanghua has quit IRC | 09:38 | |
| *** yuanying_ has joined #openstack-kuryr | 09:38 | |
| *** garyloug has joined #openstack-kuryr | 09:40 | |
| *** yuanying has quit IRC | 09:41 | |
| *** huats has quit IRC | 09:45 | |
| *** lmdaly has joined #openstack-kuryr | 09:50 | |
| *** huats has joined #openstack-kuryr | 09:50 | |
| *** openstack has joined #openstack-kuryr | 10:03 | |
| *** ram___ has joined #openstack-kuryr | 10:12 | |
| ram___ | Hi. I am new to kuryr. How can i deploy Kuryr for just testing /gaining knowledge on that. | 10:14 |
| ram___ | Is there any nice document (or) Anyone please provide me instruction on how to start with Kuryr. | 10:15 |
| openstackgerrit | Ilya Chukhnakov proposed openstack/kuryr-kubernetes: Experimental CNI & VIFBridge binding https://review.openstack.org/404038 | 10:17 |
| *** tonanhngo has quit IRC | 10:26 | |
| *** _oanson has joined #openstack-kuryr | 10:31 | |
| *** tonanhngo has joined #openstack-kuryr | 10:32 | |
| *** tonanhngo has quit IRC | 10:34 | |
| *** oanson has quit IRC | 10:39 | |
| *** limao has quit IRC | 10:42 | |
| *** tonanhngo has joined #openstack-kuryr | 10:45 | |
| *** dougbtv has quit IRC | 10:46 | |
| *** tonanhngo has quit IRC | 10:47 | |
| *** janki has quit IRC | 10:57 | |
| *** tonanhngo has joined #openstack-kuryr | 10:58 | |
| *** tonanhngo has quit IRC | 11:00 | |
| *** janki has joined #openstack-kuryr | 11:01 | |
| *** tonanhngo has joined #openstack-kuryr | 11:06 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: Move interface creation and deletion https://review.openstack.org/394547 | 11:07 |
| *** tonanhngo has quit IRC | 11:07 | |
| mchiappero | I hope I don't need to rebase again :P | 12:02 |
| mchiappero | I'm sorry to ask again about mentioning the exception in the inline documentation, but I don't understand how they should be specified when you don't have them imported in that module | 12:03 |
| *** tonanhngo has joined #openstack-kuryr | 12:04 | |
| *** lmdaly has quit IRC | 12:05 | |
| *** tonanhngo has quit IRC | 12:05 | |
| ivc_ | mchiappero, about your patch https://review.openstack.org/394547 | 12:09 |
| ivc_ | mchiappero, why do we use front-end 'app.post' api for unit tests? | 12:10 |
| ivc_ | mchiappero, would not it be easier/cleaner if we tested our internal api's directly? | 12:10 |
| mchiappero | ivc_: that's the way code was already | 12:15 |
| mchiappero | I just moved it from other files and updated to support the changes in controllers | 12:16 |
| mchiappero | what would you suggest? | 12:16 |
| mchiappero | maybe we can think of another patch? | 12:17 |
| ivc_ | mchiappero, i understand its outside the scope of your patch, but was just curious about why it is done the way it is done | 12:17 |
| mchiappero | ivc_: well I don't know :) | 12:18 |
| *** tonanhngo has joined #openstack-kuryr | 12:18 | |
| *** tonanhngo has quit IRC | 12:18 | |
| ivc_ | mchiappero ok :) | 12:19 |
| mchiappero | maybe git blame can help? :P | 12:20 |
| mchiappero | ivc_: "this is the tested method, right? maybe add a # comment to outline it" | 12:33 |
| mchiappero | I'm not sure what you mean... | 12:33 |
| *** garyloug has quit IRC | 12:35 | |
| *** tonanhngo has joined #openstack-kuryr | 12:37 | |
| *** tonanhngo has quit IRC | 12:38 | |
| *** dougbtv has joined #openstack-kuryr | 12:44 | |
| *** tonanhngo has joined #openstack-kuryr | 12:57 | |
| *** tonanhngo has quit IRC | 12:59 | |
| *** lmdaly has joined #openstack-kuryr | 13:07 | |
| *** tonanhngo has joined #openstack-kuryr | 13:11 | |
| *** tonanhngo has quit IRC | 13:12 | |
| *** lmdaly has quit IRC | 13:14 | |
| *** _oanson is now known as oanson | 13:20 | |
| apuimedo | ram___: you could use devstack :-) | 13:23 |
| *** tonanhngo has joined #openstack-kuryr | 13:24 | |
| *** tonanhngo has quit IRC | 13:27 | |
| *** gsagie has joined #openstack-kuryr | 13:42 | |
| *** lmdaly has joined #openstack-kuryr | 13:43 | |
| apuimedo | ivc_: I found the issue already with the 1.4.6 file setup | 13:45 |
| apuimedo | I'll be pushing a patch in a moment | 13:45 |
| *** garyloug has joined #openstack-kuryr | 13:46 | |
| *** limao has joined #openstack-kuryr | 13:47 | |
| *** lmdaly has quit IRC | 13:48 | |
| *** limao_ has joined #openstack-kuryr | 13:51 | |
| ram___ | apuimedo: Hi. In devstack local.conf file we need to just enable the kuryr service? Could you please provide that configuration file. (or) Is there any neat document for that? | 13:52 |
| *** limao has quit IRC | 13:52 | |
| apuimedo | in kuryr-libnetwork devstack directory there is a sample local.conf | 13:52 |
| apuimedo | also in contrib/vagrant there are samples | 13:53 |
| apuimedo | for usage with vagrant | 13:53 |
| *** garyloug has quit IRC | 13:57 | |
| mchiappero | [commercial]: review https://review.openstack.org/394547 | 13:58 |
| mchiappero | :P | 13:59 |
| ram___ | apuimedo: OK. I will try that . thank you. | 13:59 |
| ram___ | Can we deploy kuryr through kolla? | 13:59 |
| ram___ | apuimedo: Can we deploy kuryr through kolla? | 13:59 |
| ram___ | apuimedo: if we can do Please tell me how we can do in a detailed manner. | 14:01 |
| *** oanson has quit IRC | 14:06 | |
| *** gsagie has quit IRC | 14:11 | |
| apuimedo | ram___: you can | 14:12 |
| apuimedo | but there was some issue with the kolla deployment that I didn't get around to debug yet | 14:13 |
| apuimedo | :( | 14:13 |
| apuimedo | mchiappero: :-D | 14:13 |
| ram___ | apuimedo: OK. Thanks | 14:15 |
| ivc_ | mchiappero, regarding the '# comment to outline it' - there's a huge blob of ~100 lines code in that test and its quite hard to tell the 'preparation' part from the call to the function being tested. | 14:22 |
| ivc_ | mchiappero, apuimedo, also it is nearly impossible to tell whats going on in that test and what calls are being tested without running it through debugger since these tests are calling front-end api and do not seem to be 'unit' tests but more of a 'mocked black-box' tests. | 14:28 |
| *** janki has quit IRC | 14:29 | |
| openstackgerrit | Liping Mao proposed openstack/kuryr-libnetwork: container connect both bridge and kuryr network in Rally https://review.openstack.org/396048 | 14:29 |
| apuimedo | ivc_: vikasc: https://review.openstack.org/405426 | 14:46 |
| apuimedo | this is the fix | 14:47 |
| *** saneax is now known as saneax-_-|AFK | 14:57 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Unittest with mock https://review.openstack.org/394788 | 14:59 |
| *** lmdaly has joined #openstack-kuryr | 15:01 | |
| *** devlaps has joined #openstack-kuryr | 15:02 | |
| mchiappero | ivc_: I don't disagree but it was already that way :P | 15:02 |
| mchiappero | that applies to the vast majority of UT there, can we split the refactoring from restructuring? | 15:05 |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Unittests with mock https://review.openstack.org/394251 | 15:05 |
| *** tonanhngo has joined #openstack-kuryr | 15:07 | |
| *** tonanhngo has quit IRC | 15:08 | |
| openstackgerrit | Merged openstack/kuryr-libnetwork: Unittests with Mock and add a TestCase https://review.openstack.org/393996 | 15:10 |
| *** lmdaly has quit IRC | 15:11 | |
| apuimedo | alraddarla_: thanks for the mock changes | 15:12 |
| alraddarla_ | apuimedo, glad I could help :) | 15:12 |
| apuimedo | alraddarla_: will you remove the remaining usages of mox? | 15:13 |
| alraddarla_ | janonymous pointed me to a partially complete patch that is doing so in test_kuryr.py ...are there other files that still use mox as well? | 15:13 |
| apuimedo | I see kuryr_libnetwork/tests/unit/base.py | 15:16 |
| apuimedo | kuryr_libnetwork/tests/unit/test_kuryr.py | 15:16 |
| *** oanson has joined #openstack-kuryr | 15:21 | |
| alraddarla_ | Oh yes, I remember seeing base.py somewhere. I can do that | 15:21 |
| *** tonanhngo has joined #openstack-kuryr | 15:21 | |
| *** tonanhngo has quit IRC | 15:22 | |
| alraddarla_ | https://review.openstack.org/#/c/394324/ & https://review.openstack.org/#/c/394001/ both have base.py ...I need to look into it more but is this file not complete then? | 15:24 |
| apuimedo | ivc_: you decided against using OVO for the output then https://review.openstack.org/#/c/404038/5/kuryr_kubernetes/cni/api.py ? | 15:26 |
| apuimedo | alraddarla_: seems not | 15:26 |
| apuimedo | do 'git grep mox' | 15:26 |
| apuimedo | after all got merged | 15:26 |
| alraddarla_ | apuimedo, got it. I will work on that too! | 15:27 |
| apuimedo | thanks! | 15:27 |
| ivc_ | apuimedo yeah, the idea behind OVO was that we gonna support different versions, but then it came to me that it is the CNIRunner who defines the version. plus OVO still needs to be converted to CNI-valid json | 15:28 |
| ivc_ | apuimedo so i must admit the whole idea about using OVO for CNI wasn't all that great, sry i made you waste time on that | 15:29 |
| ivc_ | apuimedo, maybe we'll have to use OVO eventually if K8s will set CNI_VERSION and read output from CNI plugin. right now it does not seem to be the case | 15:32 |
| *** jgriffith_away is now known as jgriffith | 15:32 | |
| ivc_ | apuimedo, haven't confirmed it in k8s code yet, but it does seem the only case k8s reads CNI output is for errors (for ip info it just checks 'eth0') | 15:34 |
| *** tonanhngo has joined #openstack-kuryr | 15:40 | |
| apuimedo | ivc_: what do you mean with "just checks 'eth0'" ? It enters the namespace and checks? | 15:42 |
| *** tonanhngo has quit IRC | 15:43 | |
| *** garyloug has joined #openstack-kuryr | 15:53 | |
| *** hongbin has joined #openstack-kuryr | 16:00 | |
| ivc_ | apuimedo, yeah. i guess thats why it requires 'nsenter' | 16:02 |
| apuimedo | :-) | 16:02 |
| *** lmdaly has joined #openstack-kuryr | 16:08 | |
| mchiappero | question: is there a policy on ifs vs. returns? | 16:09 |
| *** yamamoto has joined #openstack-kuryr | 16:09 | |
| ivc_ | mchiappero what do you mean? | 16:09 |
| mchiappero | I mean for "if not contidion: return" rathern than "if condition: do_something" | 16:09 |
| mchiappero | any preference? | 16:10 |
| mchiappero | well, actually I think only one really makes sense in my case | 16:11 |
| ivc_ | (IMHO) "if something: return" is ok at the start of function but not in the middle | 16:11 |
| mchiappero | that's the case :) | 16:11 |
| mchiappero | I realized of the move just after asking | 16:12 |
| *** yamamot__ has quit IRC | 16:12 | |
| ivc_ | cool :) | 16:13 |
| *** lmdaly has quit IRC | 16:22 | |
| *** devvesa has quit IRC | 16:31 | |
| *** limao_ has quit IRC | 16:35 | |
| *** yamamoto has quit IRC | 16:52 | |
| *** yamamoto has joined #openstack-kuryr | 16:52 | |
| *** yamamoto has quit IRC | 17:00 | |
| *** shashank_hegde has joined #openstack-kuryr | 17:14 | |
| *** diogogmt has joined #openstack-kuryr | 17:34 | |
| *** shashank_hegde has quit IRC | 17:39 | |
| *** tonanhngo has joined #openstack-kuryr | 17:47 | |
| *** garyloug has quit IRC | 17:47 | |
| *** tonanhngo has quit IRC | 17:48 | |
| *** tonanhngo has joined #openstack-kuryr | 17:49 | |
| *** saneax-_-|AFK is now known as saneax | 18:23 | |
| *** lmdaly has joined #openstack-kuryr | 18:26 | |
| *** vikasc has quit IRC | 18:27 | |
| openstackgerrit | Luis Tomas Bolivar proposed openstack/kuryr-libnetwork: Nested-Containers: trunk subports management https://review.openstack.org/402462 | 18:29 |
| *** vikasc has joined #openstack-kuryr | 18:31 | |
| *** tonanhngo has quit IRC | 18:37 | |
| *** shashank_hegde has joined #openstack-kuryr | 18:42 | |
| *** lmdaly has quit IRC | 18:43 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: Move interface creation and deletion https://review.openstack.org/394547 | 19:19 |
| *** david-lyle_ has joined #openstack-kuryr | 19:28 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: Move interface creation and deletion https://review.openstack.org/394547 | 19:28 |
| *** david-lyle has quit IRC | 19:31 | |
| mchiappero | could you please approve this time? | 19:32 |
| *** openstackgerrit has quit IRC | 19:32 | |
| mchiappero | test_leave_unbinding in test_leave.py was misplaced | 19:33 |
| *** openstackgerrit has joined #openstack-kuryr | 19:33 | |
| mchiappero | and has been approved | 19:33 |
| mchiappero | had to fix it | 19:33 |
| *** openstackgerrit has quit IRC | 19:36 | |
| *** saneax is now known as saneax-_-|AFK | 19:40 | |
| *** lmdaly has joined #openstack-kuryr | 19:43 | |
| *** david-lyle_ is now known as david-lyle | 20:01 | |
| *** lmdaly has quit IRC | 20:26 | |
| *** openstack has joined #openstack-kuryr | 20:43 | |
| *** openstackgerrit has joined #openstack-kuryr | 20:47 | |
| openstackgerrit | Marco Chiappero proposed openstack/kuryr-libnetwork: Move interface creation and deletion https://review.openstack.org/394547 | 20:47 |
| *** diogogmt has quit IRC | 21:45 | |
| *** oanson has quit IRC | 21:49 | |
| *** openstackgerrit has quit IRC | 22:03 | |
| dougbtv | hey ram___ -- i wrote a blog article for kind of a "try kuryr / kuryr hello world" from a variety of documentation sources, in this case I use devstack and then install kuryr on it (and just have two containers ping one another) http://dougbtv.com/nfvpe/2016/12/01/kuryr/ | 22:24 |
| dougbtv | also for anyone else who would be interested, but, I wanted to operate kuryr, and really looking forward to seeing/trying/contributing to it openshift-on-openstack | 22:26 |
| *** ivc_ has quit IRC | 22:37 | |
| apuimedo | dougbtv: ;-) | 22:51 |
| apuimedo | hopefully we'll get to small demos of openshift on openstack with kuryr soon | 22:51 |
| *** ivc_ has joined #openstack-kuryr | 22:54 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!