| *** tonanhngo has quit IRC | 00:15 | |
| *** sdake has joined #openstack-kuryr | 00:17 | |
| *** limao has joined #openstack-kuryr | 00:28 | |
| *** pablochacin has quit IRC | 00:46 | |
| *** sdake_ has joined #openstack-kuryr | 01:06 | |
| *** sdake has quit IRC | 01:10 | |
| *** salv-orl_ has joined #openstack-kuryr | 01:15 | |
| *** salv-orlando has quit IRC | 01:18 | |
| *** sdake_ has quit IRC | 01:19 | |
| *** sdake has joined #openstack-kuryr | 01:22 | |
| *** salv-orl_ has quit IRC | 01:26 | |
| *** hongbin has joined #openstack-kuryr | 01:35 | |
| *** xiangxinyong has quit IRC | 02:02 | |
| *** yuanying has quit IRC | 02:10 | |
| *** shashank_hegde has quit IRC | 02:16 | |
| *** tonanhngo has joined #openstack-kuryr | 02:34 | |
| *** tonanhngo has quit IRC | 03:10 | |
| *** tonanhngo has joined #openstack-kuryr | 03:11 | |
| *** salv-orlando has joined #openstack-kuryr | 03:30 | |
| *** salv-orlando has quit IRC | 03:38 | |
| *** shashank_hegde has joined #openstack-kuryr | 03:45 | |
| *** yuanying has joined #openstack-kuryr | 03:59 | |
| *** hongbin has quit IRC | 04:03 | |
| *** salv-orlando has joined #openstack-kuryr | 04:37 | |
| *** janki has joined #openstack-kuryr | 04:46 | |
| *** salv-orlando has quit IRC | 04:49 | |
| *** salv-orlando has joined #openstack-kuryr | 04:58 | |
| *** sdake_ has joined #openstack-kuryr | 05:21 | |
| *** sdake has quit IRC | 05:24 | |
| *** sdake_ has quit IRC | 05:41 | |
| *** tonanhngo has quit IRC | 05:46 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Use generic config options from kuryr-lib https://review.openstack.org/350406 | 06:05 |
|---|---|---|
| *** _oanson has joined #openstack-kuryr | 06:07 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Use generic config options from kuryr-lib https://review.openstack.org/350406 | 06:10 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Use generic config options from kuryr-lib https://review.openstack.org/350406 | 06:14 |
| *** shashank_hegde has quit IRC | 06:24 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Avoid registration of config parameters https://review.openstack.org/358978 | 06:28 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Use generic config options from kuryr-lib https://review.openstack.org/350406 | 06:30 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Add neutron client generic rest driver https://review.openstack.org/342624 | 06:40 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Add neutron client generic rest driver https://review.openstack.org/342624 | 06:45 |
| *** tonanhngo has joined #openstack-kuryr | 07:00 | |
| *** tonanhngo has quit IRC | 07:03 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Avoid registration of config parameters https://review.openstack.org/358978 | 07:08 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Add neutron client generic rest driver https://review.openstack.org/342624 | 07:10 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Use generic config options from kuryr-lib https://review.openstack.org/350406 | 07:11 |
| *** salv-orl_ has joined #openstack-kuryr | 07:16 | |
| *** salv-orlando has quit IRC | 07:19 | |
| *** salv-orl_ has quit IRC | 07:21 | |
| *** salv-orlando has joined #openstack-kuryr | 07:25 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Avoid registration of config parameters https://review.openstack.org/358978 | 07:33 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: Add neutron client generic rest driver https://review.openstack.org/342624 | 07:34 |
| *** yamamoto has quit IRC | 07:38 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Code restructuring: neutron client as rest driver from Kuryr lib https://review.openstack.org/342614 | 07:57 |
| *** diga has joined #openstack-kuryr | 07:57 | |
| *** _oanson is now known as oanson | 08:02 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #openstack-kuryr | 08:04 | |
| *** yuanying has quit IRC | 08:05 | |
| *** yamamoto has joined #openstack-kuryr | 08:16 | |
| *** pablochacin has joined #openstack-kuryr | 08:21 | |
| vikasc | irenab, apuimedo Why kuryr-k8s supports python3 only and not python2.7? | 08:21 |
| vikasc | pablochacin, | 08:21 |
| irenab | vikasc: I think its due to asyncio lib | 08:22 |
| vikasc | ok | 08:22 |
| vikasc | irenab, is it not possible to get working with 2.7 | 08:22 |
| pablochacin | Hi, vikasc, it is also my understanding | 08:23 |
| vikasc | thanks pablochacin | 08:23 |
| vikasc | was just wondering how difficult (if possible) it is to get it working with 2.7 | 08:24 |
| vikasc | since many projects in openstackare still on 2.7 | 08:24 |
| vikasc | *openstack are | 08:24 |
| vikasc | i think jerome or apuimedo can give more details | 08:25 |
| irenab | vikasc: https://github.com/openstack/kuryr/blob/master/doc/source/devref/k8s_api_watcher_design.rst#asyncio-and-python-3-by-default | 08:25 |
| * vikasc reading | 08:26 | |
| vikasc | thanks irenab | 08:27 |
| pablochacin | I think the rationale is this "since [Kuryr] it's a container related project it should be able to be run inside a container. So do Raven. Therefore we take a path to support for only Python 3 and drop Python 2." | 08:27 |
| vikasc | i will read more and get back if any doubts | 08:28 |
| irenab | vikasc: CNI driver should not have such requirements | 08:30 |
| *** garyloug has joined #openstack-kuryr | 08:30 | |
| vikasc | irenab, got it. | 08:31 |
| openstackgerrit | vikas choudhary proposed openstack/kuryr-libnetwork: Add optional neutron rpc driver support https://review.openstack.org/340143 | 08:35 |
| vikasc | irenab, test cases are missing in this patch, https://review.openstack.org/#/c/342624/9 . "rest driver support" in kuryr repo. You rightly pointed out the same. | 08:37 |
| irenab | vikasc: checking now the conf registration patch | 08:38 |
| vikasc | irenab, should i add a test file for this file https://review.openstack.org/#/c/342624/9/kuryr/lib/neutron_rest.py | 08:39 |
| vikasc | irenab, ok | 08:39 |
| *** yamamoto has quit IRC | 08:40 | |
| irenab | vikasc: yes, I think the one to catch changes in the expected REST driver contract should have unit tests | 08:41 |
| *** salv-orl_ has joined #openstack-kuryr | 08:44 | |
| vikasc | irenab, that means will have to mock calling of each api and then mock the neutron response for each api such as "create_network", "delete_network" etc etc ? | 08:45 |
| *** salv-orlando has quit IRC | 08:45 | |
| vikasc | irenab, but this testing is already covered by kuryr-libnetwork test cases? | 08:48 |
| *** yamamoto has joined #openstack-kuryr | 08:48 | |
| *** salv-orl_ has quit IRC | 08:49 | |
| *** salv-orlando has joined #openstack-kuryr | 08:50 | |
| irenab | vikasc: there should be tests to cover the expected versus real REST API contract | 08:51 |
| vikasc | irenab, hmm.. got it :) | 08:52 |
| irenab | if there is already such, no need to add something else. Can you please point to the one that verifies the code modified in this patch? | 08:53 |
| vikasc | irenab, nope, none is there. Kuryr-libnetwork tests will ensure till calling of apis defined in neutron_rest.py but there is no test to ensure whether this api is making correct rest call or not. | 08:56 |
| vikasc | irenab, understodd | 08:56 |
| vikasc | *understood | 08:56 |
| irenab | vikasc: sorry for giving you hard time with testing, but I believe in longer term it is very good return of investment | 08:58 |
| vikasc | irenab, no problem. Your point is valid. :) | 08:58 |
| vikasc | irenab, thanks for your patience | 08:58 |
| irenab | vikasc: patience is my middle name :-) | 08:59 |
| vikasc | irenab, :D great | 08:59 |
| vikasc | irenab, then you should be | 09:00 |
| pablochacin | irenab, vikasc, i have a doubt regarding the tests. I think that check that the rest api works according the contract if responsability of the other side. Our side should be to handle exceptions, which is not exactly the same. | 09:00 |
| vikasc | pablochacin, right | 09:01 |
| pablochacin | (or better stated, how do you define "contract"?) | 09:01 |
| vikasc | irenab, rest api format is already being tested in kuryr-libnetwork | 09:04 |
| vikasc | https://review.openstack.org/#/c/342614/11/kuryr_libnetwork/tests/unit/test_kuryr.py | 09:04 |
| vikasc | irenab, i should actually revert my changes in above pasted link | 09:04 |
| irenab | vikasc: pablochacin : agree on the contract between kuryr and neutron API/RPC, this is what I meant, that it given the proper input and gets the output it handles | 09:05 |
| vikasc | no actually.. i am wrong. what we initially discussed seems fine to me now. | 09:06 |
| vikasc | irenab, i am in sync with you | 09:07 |
| vikasc | pablochacin, can you please elaborate, if possible | 09:08 |
| pablochacin | vikasc, basically that we should assume the other side works as expected (returns correct values), but need to check we handle it properly. | 09:09 |
| pablochacin | And that we handle expected exceptions, like timeouts, connection failures. | 09:09 |
| vikasc | pablochacin, those testcases are there in kuryr-libnetwork for hadling each scenario such as correct response and exceptions | 09:10 |
| vikasc | pablochacin, i think i understood what you saying.. fine grain exception handling test cases should be on kuryr-lib and assuming that kuryr-lib is giving correct response, such test cases should be with kuryr-libnetwork or kuryr-kubernetes. Have I got you right? | 09:14 |
| pablochacin | vicasc I mean the API/RPC specific contract. For example in a rest api you must check http return codes. | 09:14 |
| vikasc | pablochacin, got you | 09:15 |
| *** salv-orlando has quit IRC | 09:21 | |
| *** salv-orlando has joined #openstack-kuryr | 09:21 | |
| *** reedip has quit IRC | 09:27 | |
| *** icoughla has joined #openstack-kuryr | 09:31 | |
| *** prithiv has joined #openstack-kuryr | 09:52 | |
| limao | ping vikas | 10:01 |
| limao | ping vikasc | 10:01 |
| vikasc | hi | 10:02 |
| limao | hello vikasc, I'm still not understand why we need to pass bindir as param | 10:02 |
| limao | I think this should be a little bit similiar with oslo case | 10:02 |
| limao | https://github.com/openstack/oslo.concurrency/blob/master/oslo_concurrency/lockutils.py | 10:03 |
| limao | can we do it similiar with this? | 10:03 |
| * vikasc looking | 10:03 | |
| limao | Somthing like : if external and not CONF.oslo_concurrency.disable_process_locking: | 10:04 |
| vikasc | limao, in mid of something.. will go through what you suggested and ping back | 10:05 |
| *** prithiv has quit IRC | 10:06 | |
| limao | thanks~ take your time | 10:06 |
| limao | I will reply in your commit, you can reply me there, thanks | 10:07 |
| *** limao has quit IRC | 10:10 | |
| *** prithiv has joined #openstack-kuryr | 10:23 | |
| *** diga has quit IRC | 10:24 | |
| *** prithiv has quit IRC | 10:45 | |
| *** oanson has quit IRC | 10:59 | |
| *** tonanhngo has joined #openstack-kuryr | 11:03 | |
| *** tonanhngo has quit IRC | 11:04 | |
| *** tonanhngo has joined #openstack-kuryr | 11:10 | |
| *** devvesa has joined #openstack-kuryr | 11:15 | |
| *** tonanhngo has quit IRC | 11:22 | |
| *** tonanhngo has joined #openstack-kuryr | 11:22 | |
| *** limao has joined #openstack-kuryr | 11:31 | |
| *** limao_ has joined #openstack-kuryr | 11:32 | |
| *** limao has quit IRC | 11:35 | |
| *** garyloug has quit IRC | 11:37 | |
| *** limao_ has quit IRC | 11:52 | |
| *** limao has joined #openstack-kuryr | 11:52 | |
| *** prithiv has joined #openstack-kuryr | 12:00 | |
| *** garyloug has joined #openstack-kuryr | 12:05 | |
| *** limao has quit IRC | 12:08 | |
| *** prithiv has quit IRC | 12:25 | |
| *** prithiv has joined #openstack-kuryr | 12:38 | |
| *** reedip has joined #openstack-kuryr | 12:40 | |
| *** janki is now known as janki|afk | 13:14 | |
| *** janki|afk is now known as janki | 13:24 | |
| *** sdake has joined #openstack-kuryr | 13:36 | |
| *** sdake_ has joined #openstack-kuryr | 13:37 | |
| *** tonanhngo has quit IRC | 13:40 | |
| *** sdake has quit IRC | 13:41 | |
| *** prithiv has quit IRC | 13:57 | |
| *** hongbin has joined #openstack-kuryr | 13:58 | |
| *** icoughla_ has joined #openstack-kuryr | 14:01 | |
| *** tonanhngo has joined #openstack-kuryr | 14:01 | |
| *** oanson has joined #openstack-kuryr | 14:02 | |
| *** tonanhngo has quit IRC | 14:03 | |
| *** icoughla has quit IRC | 14:04 | |
| *** icoughla_ has quit IRC | 14:22 | |
| *** oanson has quit IRC | 14:23 | |
| *** icoughla_ has joined #openstack-kuryr | 14:33 | |
| *** sdake_ has quit IRC | 14:35 | |
| *** sdake has joined #openstack-kuryr | 14:41 | |
| *** tonanhngo has joined #openstack-kuryr | 14:41 | |
| *** tonanhngo has quit IRC | 14:42 | |
| *** tonanhngo has joined #openstack-kuryr | 14:43 | |
| *** yamamoto has quit IRC | 14:57 | |
| *** yamamoto has joined #openstack-kuryr | 15:01 | |
| *** yamamoto has quit IRC | 15:06 | |
| *** salv-orlando has quit IRC | 15:08 | |
| *** salv-orlando has joined #openstack-kuryr | 15:08 | |
| *** icoughla_ has quit IRC | 15:12 | |
| *** janki has quit IRC | 15:12 | |
| *** yamamoto has joined #openstack-kuryr | 15:31 | |
| *** yamamoto has quit IRC | 15:32 | |
| *** yamamoto has joined #openstack-kuryr | 15:33 | |
| *** yamamoto has quit IRC | 15:33 | |
| *** janki has joined #openstack-kuryr | 15:45 | |
| *** prithiv has joined #openstack-kuryr | 15:54 | |
| *** icoughla has joined #openstack-kuryr | 16:13 | |
| *** icoughla has quit IRC | 16:27 | |
| *** shashank_hegde has joined #openstack-kuryr | 16:31 | |
| *** yamamoto has joined #openstack-kuryr | 16:33 | |
| *** prithiv has quit IRC | 16:33 | |
| *** yamamoto has quit IRC | 16:41 | |
| *** garyloug has quit IRC | 16:43 | |
| *** tonanhngo has quit IRC | 17:00 | |
| *** devvesa has quit IRC | 17:11 | |
| *** janki has quit IRC | 17:14 | |
| *** oanson has joined #openstack-kuryr | 17:25 | |
| *** oanson has quit IRC | 17:36 | |
| *** shashank_hegde has quit IRC | 17:40 | |
| *** shashank_hegde has joined #openstack-kuryr | 17:42 | |
| *** pablochacin has quit IRC | 17:54 | |
| *** tonanhngo has joined #openstack-kuryr | 18:42 | |
| *** salv-orlando has quit IRC | 19:28 | |
| *** salv-orlando has joined #openstack-kuryr | 19:28 | |
| *** salv-orlando has quit IRC | 19:32 | |
| *** pablochacin has joined #openstack-kuryr | 20:59 | |
| *** salv-orlando has joined #openstack-kuryr | 21:32 | |
| *** sdake has quit IRC | 21:45 | |
| *** sdake has joined #openstack-kuryr | 21:46 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/kuryr: Updated from global requirements https://review.openstack.org/357683 | 22:17 |
| *** pablochacin has quit IRC | 22:40 | |
| *** sdake has quit IRC | 22:44 | |
| *** sdake has joined #openstack-kuryr | 22:44 | |
| *** yamamoto has joined #openstack-kuryr | 22:51 | |
| *** hongbin has quit IRC | 23:26 | |
| *** yuanying has joined #openstack-kuryr | 23:30 | |
| *** gsagie has quit IRC | 23:34 | |
| *** gsagie has joined #openstack-kuryr | 23:34 | |
| *** salv-orlando has quit IRC | 23:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!