Thursday, 2016-01-14

*** apuimedo has quit IRC00:01
*** apuimedo has joined #openstack-kuryr00:02
*** apuimedo has quit IRC00:06
*** apuimedo has joined #openstack-kuryr00:07
*** apuimedo has quit IRC00:12
*** apuimedo has joined #openstack-kuryr00:13
*** apuimedo has quit IRC00:18
*** apuimedo has joined #openstack-kuryr00:19
*** dingboopt has quit IRC00:27
*** apuimedo has quit IRC00:28
*** apuimedo has joined #openstack-kuryr00:29
*** irenab_ has joined #openstack-kuryr00:30
*** salv-orl_ has quit IRC00:31
*** irenab has quit IRC00:33
*** irenab_ is now known as irenab00:33
*** salv-orlando has joined #openstack-kuryr00:34
*** apuimedo has quit IRC00:36
*** apuimedo has joined #openstack-kuryr00:36
*** apuimedo has quit IRC00:43
*** apuimedo has joined #openstack-kuryr00:44
*** salv-orlando has quit IRC00:45
*** salv-orlando has joined #openstack-kuryr00:46
*** banix has joined #openstack-kuryr00:49
*** apuimedo has quit IRC00:51
*** apuimedo has joined #openstack-kuryr00:51
*** apuimedo has quit IRC00:56
*** apuimedo has joined #openstack-kuryr00:58
*** apuimedo has quit IRC01:02
*** apuimedo has joined #openstack-kuryr01:05
*** apuimedo has quit IRC01:09
*** apuimedo has joined #openstack-kuryr01:11
*** apuimedo has quit IRC01:16
*** apuimedo has joined #openstack-kuryr01:16
*** apuimedo has quit IRC01:21
*** apuimedo has joined #openstack-kuryr01:23
*** apuimedo has quit IRC01:30
*** apuimedo has joined #openstack-kuryr01:30
*** apuimedo has quit IRC01:35
*** apuimedo has joined #openstack-kuryr01:36
*** apuimedo has quit IRC01:50
*** apuimedo has joined #openstack-kuryr01:50
*** apuimedo has quit IRC01:55
*** apuimedo has joined #openstack-kuryr01:56
*** apuimedo has quit IRC02:00
*** apuimedo has joined #openstack-kuryr02:01
*** apuimedo has quit IRC02:06
*** apuimedo has joined #openstack-kuryr02:06
*** apuimedo has quit IRC02:13
*** apuimedo has joined #openstack-kuryr02:15
*** vikasc has quit IRC02:21
*** banix has quit IRC02:21
*** apuimedo has quit IRC02:22
*** apuimedo has joined #openstack-kuryr02:23
*** apuimedo has quit IRC02:30
*** apuimedo has joined #openstack-kuryr02:32
*** apuimedo has quit IRC02:41
*** banix has joined #openstack-kuryr02:42
*** apuimedo has joined #openstack-kuryr02:42
*** apuimedo has quit IRC02:46
*** apuimedo has joined #openstack-kuryr02:48
*** wangfeng_yellow has quit IRC02:52
openstackgerritBaohua Yang proposed openstack/kuryr: Fix wrong checking code  https://review.openstack.org/26509802:52
*** tfukushima has joined #openstack-kuryr02:57
*** apuimedo has quit IRC03:00
*** apuimedo has joined #openstack-kuryr03:01
*** diogogmt has joined #openstack-kuryr03:04
*** apuimedo has quit IRC03:08
*** apuimedo has joined #openstack-kuryr03:09
*** apuimedo has quit IRC03:14
*** apuimedo has joined #openstack-kuryr03:14
*** apuimedo has quit IRC03:19
*** apuimedo has joined #openstack-kuryr03:20
*** apuimedo has quit IRC03:24
*** apuimedo has joined #openstack-kuryr03:25
*** apuimedo has quit IRC03:30
*** apuimedo has joined #openstack-kuryr03:31
*** yuanying_ has quit IRC03:34
*** vikasc has joined #openstack-kuryr03:37
*** apuimedo has quit IRC03:40
*** apuimedo has joined #openstack-kuryr03:41
*** yuanying has joined #openstack-kuryr03:46
*** apuimedo has quit IRC03:48
*** k-yasui has quit IRC03:48
*** apuimedo has joined #openstack-kuryr03:49
banixhi vikasc03:52
vikaschi banix03:52
banixdo you have a couple of minutes?03:52
vikascsure03:53
banixso i was looking at the subnetpool creation in the IPAM code03:53
*** apuimedo has quit IRC03:53
vikascok03:53
banixis there a part that is missing or being planned?03:53
banixthe reason i am asking is that03:54
*** apuimedo has joined #openstack-kuryr03:54
banixwe never use the subnetpool for anything03:54
banixam i missing something here?03:54
vikascgiving me few secs to get into context and recall :)03:54
banixsure take your time03:55
banixpls use my nickname so i know you are writing03:55
vikascbanix, sure03:56
*** yuanying_ has joined #openstack-kuryr03:56
*** yuanying has quit IRC03:59
*** yuanying_ has quit IRC04:00
vikascbanix,  subnetpool is being created just to hold subnet_cidr(received from docker user) and passing subnetpool-ID back to libnetwork in response. In other words, IMO all we need is to store cidr and generate an ID and have this mapping stored locally in kuryr.04:05
*** yuanying has joined #openstack-kuryr04:06
vikascbanix, so if generate this pool-id locally in kuryr and have this mapping also stored, creation of subnetpool can be avoided04:07
banixvikasc: let me have a look at the code again quickly04:07
*** yuanying has quit IRC04:07
*** yuanying_ has joined #openstack-kuryr04:07
vikascbanix, sure04:08
*** apuimedo has quit IRC04:08
vikascbanix,  please see ipam_request_address04:08
*** apuimedo has joined #openstack-kuryr04:08
vikascbanix, or look for _get_subnetpools_by_attrs04:09
*** salv-orl_ has joined #openstack-kuryr04:10
vikascbanix, i have 5 patches under review. Can you please have a look once you get some time.04:10
banixvikasc: 4 or 5? I will review tomorrow my time (late today your time)04:12
banixstill not clear about subnetpool04:12
banixgive me a few minutes please04:12
vikascbanix,  sure04:12
*** salv-orlando has quit IRC04:12
vikascbanix, i think you are missing the 'devref' one04:12
vikascbanix, Taku is owner of that patch04:13
vikascbanix,  now i am taking that forward04:13
banixvikasc: got it04:13
*** apuimedo has quit IRC04:15
*** apuimedo has joined #openstack-kuryr04:16
vikascbanix, subnetpool we creating just to have a placeholder for cidr which we get from docker04:16
banixso if we get a request with pool and subpool1 we returna pool id. then we get a request for pool and subpool2. we return a different pool id? is that correct?04:19
banixvikasc: ^04:19
vikascbanix, yes, assuming subpool1 for one docker network  and subpool2 for another04:20
*** apuimedo has quit IRC04:20
vikascthere are --subnet --iprange options,  if --iprange is given  .. cidr is selected from --ip_range04:21
*** apuimedo has joined #openstack-kuryr04:21
banixhmmm, shouldn’t the same pool id be returned based on the docker spec?04:21
vikasceven if both pools are for different networks?04:21
banixso each pool belongs to a single network?04:22
vikascyes04:22
vikascbanix, docker network create --driver=kuryr --ipam-driver=kuryr --subnet 102.11.0.0/16  --ip-range 102.11.0.0/24 test2504:23
vikascthis is the sample command04:23
banixyes04:23
vikascso each network is telling its pools04:23
vikascby telling --subnet04:23
banixthen why the need for using subnet and ip-range?04:23
vikascsubnet and ip-range are providing pool cidr only04:24
vikascits just like iprange will be a subset of --subnet cidr04:24
banixpls be patient with me; I am getting confused04:25
vikascsure04:25
banixso following your example, let us look at the following two commands:04:25
vikascok04:25
banixdocker network create --driver=kuryr --ipam-driver=kuryr --subnet 102.11.0.0/16  --ip-range 102.11.0.0/24 test2504:25
banixand04:25
banixdocker network create --driver=kuryr --ipam-driver=kuryr --subnet 102.11.0.0/16  --ip-range 102.11.1.0/24 test2604:26
vikascok04:26
banixif these are different pools, what is the point of specifying the subnet at all04:26
banixwhy not just have ip-range04:26
vikascbanix, ip-range cannot be given without giving --subnet. Though --subnet can be given without --ip-range04:27
banixi understand that04:27
*** apuimedo has quit IRC04:28
banixbut I am saying what would be the point of having pools and subpools?04:28
vikascthat is how docker people have discussed their usecases may be04:28
*** apuimedo has joined #openstack-kuryr04:29
vikasci too could not understand why they (docker) have these two (pool and subpool)04:29
vikascwhatever little i understood is04:29
banixvikasc: ok thanks, let me look into this a bit more.04:30
vikascbanix, i got your doubt now04:31
vikascbanix, give me 2 mins more to explain04:31
vikasc:)04:31
banixsure04:31
vikascin both the commands you mentioned above,04:31
vikascfirst will create a pool with cidr 102.11.0.0/24 and let say ID X04:32
vikascsecond will create a pool with cidr 102.11.1.0/24 and let say ID Y04:33
*** apuimedo has quit IRC04:33
vikascokk now your point is where --subnet has been used04:34
banixyes04:35
*** apuimedo has joined #openstack-kuryr04:35
vikascmay be we could have created a neutron subnetpool with --subnet cidr and for first network return back 102.11.0.0/24 and for second return back 102.11.1.0/24. Both times same pool ID04:37
vikascthis is you point04:37
vikasc*your04:37
vikascsorry for taking long to understand04:37
*** apuimedo has quit IRC04:39
vikascbut this will not work in our case. We need seperate ids to differentiate cidrs.04:40
vikascbanix,04:40
banixyes that is how I thought it was supposed to be; i understand the issue with implementation but want to make sure i understand the expected behavior04:41
banixthen we can worry about implementation issues04:41
*** apuimedo has joined #openstack-kuryr04:41
banixfrom docker docs:04:42
banixRequestPool04:42
banixThis API is for registering a address pool with the IPAM driver. Multiple identical calls must return the same result. It is the IPAM driver's responsibility to keep a reference count for the pool.04:42
banixlet me ask the libnetwork guys tomorrow to make sure we are understanding the API04:44
*** apuimedo has quit IRC04:51
*** apuimedo has joined #openstack-kuryr04:51
*** apuimedo has quit IRC04:56
*** apuimedo has joined #openstack-kuryr04:57
openstackgerritvikas choudhary proposed openstack/kuryr: /NetworkDriver.CreateNetwork: Handle 'Gateway' parameter properly  https://review.openstack.org/26730205:02
*** apuimedo has quit IRC05:04
*** apuimedo has joined #openstack-kuryr05:04
*** banix has quit IRC05:04
*** vikasc has quit IRC05:06
*** baohua has joined #openstack-kuryr05:06
*** apuimedo has quit IRC05:09
*** apuimedo has joined #openstack-kuryr05:10
*** apuimedo has quit IRC05:15
*** apuimedo has joined #openstack-kuryr05:16
*** apuimedo has quit IRC05:20
*** apuimedo has joined #openstack-kuryr05:22
*** apuimedo has quit IRC05:37
*** apuimedo has joined #openstack-kuryr05:37
*** apuimedo has quit IRC05:47
*** apuimedo has joined #openstack-kuryr05:48
*** apuimedo has quit IRC05:53
*** apuimedo has joined #openstack-kuryr05:53
*** vikasc has joined #openstack-kuryr05:55
vikascbaohua, ping05:56
vikascbaohua, Can you please review this https://review.openstack.org/#/c/265744/05:57
vikascand othe patches as well05:57
*** apuimedo has quit IRC05:58
*** apuimedo has joined #openstack-kuryr06:00
*** apuimedo has quit IRC06:07
*** apuimedo has joined #openstack-kuryr06:08
*** apuimedo has quit IRC06:15
*** apuimedo has joined #openstack-kuryr06:16
*** apuimedo has quit IRC06:21
*** apuimedo has joined #openstack-kuryr06:22
openstackgerritBaohua Yang proposed openstack/kuryr: Check if the return net list is empty before deleting it  https://review.openstack.org/26508706:25
baohuavikasc, sure, will review it. and please help review https://review.openstack.org/#/c/265087/. thanks!06:25
*** apuimedo has quit IRC06:27
*** apuimedo has joined #openstack-kuryr06:28
*** apuimedo has quit IRC06:33
*** apuimedo has joined #openstack-kuryr06:34
*** apuimedo has quit IRC06:38
*** apuimedo has joined #openstack-kuryr06:39
*** apuimedo has quit IRC06:44
*** apuimedo has joined #openstack-kuryr06:44
*** apuimedo has quit IRC06:51
*** apuimedo has joined #openstack-kuryr06:52
*** apuimedo has quit IRC06:59
*** apuimedo has joined #openstack-kuryr07:00
*** apuimedo has quit IRC07:07
*** apuimedo has joined #openstack-kuryr07:08
*** apuimedo has quit IRC07:12
*** apuimedo has joined #openstack-kuryr07:13
*** apuimedo has quit IRC07:29
*** apuimedo has joined #openstack-kuryr07:30
*** apuimedo has quit IRC07:34
*** apuimedo has joined #openstack-kuryr07:35
*** apuimedo has quit IRC07:40
*** apuimedo has joined #openstack-kuryr07:40
*** apuimedo has quit IRC07:47
*** apuimedo has joined #openstack-kuryr07:48
*** salv-orl_ has quit IRC07:53
*** salv-orlando has joined #openstack-kuryr07:53
*** apuimedo has quit IRC07:57
*** apuimedo has joined #openstack-kuryr07:58
*** apuimedo has quit IRC08:05
*** apuimedo has joined #openstack-kuryr08:06
*** apuimedo has quit IRC08:13
*** apuimedo has joined #openstack-kuryr08:14
*** apuimedo has quit IRC08:23
*** apuimedo has joined #openstack-kuryr08:24
*** apuimedo has quit IRC08:29
*** apuimedo has joined #openstack-kuryr08:29
*** devvesa has joined #openstack-kuryr08:40
*** apuimedo has quit IRC08:41
*** apuimedo has joined #openstack-kuryr08:42
*** diga has joined #openstack-kuryr08:53
openstackgerritLiuNanke proposed openstack/kuryr: Clean up removed hacking rule from [flake8] ignore lists  https://review.openstack.org/26741008:53
*** apuimedo has quit IRC08:53
*** apuimedo has joined #openstack-kuryr08:55
*** salv-orlando has quit IRC08:57
*** reedip is now known as outofmemory08:57
*** salv-orlando has joined #openstack-kuryr08:58
apuimedoI'm back people!08:58
apuimedoso if anybody needs to contact me, I'll be here08:59
openstackgerritLiuNanke proposed openstack/kuryr: Clean up removed hacking rule from [flake8] ignore lists  https://review.openstack.org/26741009:05
*** salv-orlando has quit IRC09:05
*** salv-orlando has joined #openstack-kuryr09:05
baohuaapuimedo, welcome back, and please help review, many patches stay recently :)09:11
*** baohua has quit IRC09:31
apuimedoindeed09:49
*** tfukushima has quit IRC09:54
*** salv-orl_ has joined #openstack-kuryr10:10
*** salv-orlando has quit IRC10:12
*** baohua has joined #openstack-kuryr10:40
*** diga has quit IRC10:45
openstackgerritvikas choudhary proposed openstack/kuryr: /NetworkDriver.CreateNetwork: Handle 'Gateway' parameter properly  https://review.openstack.org/26730211:13
*** vikasc has quit IRC11:16
*** fawadkhaliq has joined #openstack-kuryr11:25
*** vikasc has joined #openstack-kuryr11:32
irenabvikasc: baohua : please reply on the comments posted on your reviews and not just upload new patch sets please11:50
*** vikasc has quit IRC11:54
apuimedoor do both :P12:03
*** irenab_ has joined #openstack-kuryr12:32
*** irenab_ has quit IRC12:33
*** irenab has quit IRC12:33
*** irenab has joined #openstack-kuryr12:35
*** irenab_ has joined #openstack-kuryr12:38
*** irenab has quit IRC12:40
*** irenab_ is now known as irenab12:40
*** fawadkhaliq has quit IRC13:07
*** diogogmt has quit IRC13:14
*** diogogmt has joined #openstack-kuryr13:17
*** diogogmt has quit IRC13:41
*** WANG_Feng has quit IRC14:02
*** banix has joined #openstack-kuryr15:15
baohuairenab: thanks for the suggestion, will try doing both :)15:47
*** WANG_Feng has joined #openstack-kuryr15:57
*** salv-orlando has joined #openstack-kuryr16:09
*** fawadkhaliq has joined #openstack-kuryr16:11
*** fawadkhaliq has joined #openstack-kuryr16:12
*** salv-orl_ has quit IRC16:13
*** apuimedo has quit IRC16:18
*** apuimedo has joined #openstack-kuryr16:19
*** diogogmt has joined #openstack-kuryr16:21
*** apuimedo has quit IRC16:24
*** apuimedo has joined #openstack-kuryr16:24
*** apuimedo has quit IRC16:29
*** apuimedo has joined #openstack-kuryr16:31
*** apuimedo has quit IRC16:42
*** apuimedo has joined #openstack-kuryr16:44
*** baohua has quit IRC16:52
*** apuimedo has quit IRC16:53
*** apuimedo has joined #openstack-kuryr16:55
*** salv-orlando has quit IRC16:58
*** banix has quit IRC16:58
*** salv-orlando has joined #openstack-kuryr16:58
*** apuimedo has quit IRC17:00
*** apuimedo has joined #openstack-kuryr17:01
*** salv-orlando has quit IRC17:03
*** salv-orlando has joined #openstack-kuryr17:04
*** apuimedo has quit IRC17:11
*** apuimedo has joined #openstack-kuryr17:11
*** apuimedo has quit IRC17:16
*** apuimedo has joined #openstack-kuryr17:16
*** salv-orlando has quit IRC17:29
*** salv-orlando has joined #openstack-kuryr17:29
*** apuimedo has quit IRC17:43
*** apuimedo has joined #openstack-kuryr17:44
*** apuimedo has quit IRC17:51
*** apuimedo has joined #openstack-kuryr17:52
*** banix has joined #openstack-kuryr17:58
*** devvesa has quit IRC18:08
*** apuimedo has quit IRC18:11
*** apuimedo has joined #openstack-kuryr18:12
*** apuimedo has quit IRC18:19
*** apuimedo has joined #openstack-kuryr18:20
*** apuimedo has quit IRC18:27
*** apuimedo has joined #openstack-kuryr18:28
*** irenab has quit IRC18:32
*** irenab has joined #openstack-kuryr18:33
*** irenab has quit IRC18:35
*** irenab has joined #openstack-kuryr18:37
*** apuimedo has quit IRC18:37
*** apuimedo has joined #openstack-kuryr18:38
*** apuimedo has quit IRC18:43
*** apuimedo has joined #openstack-kuryr18:44
*** apuimedo has quit IRC19:00
*** apuimedo has joined #openstack-kuryr19:02
*** apuimedo has quit IRC19:06
*** apuimedo has joined #openstack-kuryr19:07
*** apuimedo has quit IRC19:16
*** fawadkhaliq has quit IRC19:17
*** fawadkhaliq has joined #openstack-kuryr19:17
*** apuimedo has joined #openstack-kuryr19:18
*** fawadkhaliq has quit IRC19:19
*** apuimedo has quit IRC19:23
*** apuimedo has joined #openstack-kuryr19:24
*** apuimedo has quit IRC19:33
*** apuimedo has joined #openstack-kuryr19:34
*** apuimedo has quit IRC19:39
*** apuimedo has joined #openstack-kuryr19:40
*** diogogmt has quit IRC19:43
*** apuimedo has quit IRC19:45
*** apuimedo has joined #openstack-kuryr19:46
*** diogogmt has joined #openstack-kuryr19:53
*** apuimedo has quit IRC20:05
*** apuimedo has joined #openstack-kuryr20:06
*** apuimedo has quit IRC20:15
*** apuimedo has joined #openstack-kuryr20:16
*** irenab has quit IRC20:19
*** irenab has joined #openstack-kuryr20:22
*** apuimedo has quit IRC20:25
*** apuimedo has joined #openstack-kuryr20:26
*** apuimedo has quit IRC20:45
*** apuimedo has joined #openstack-kuryr20:46
*** apuimedo has quit IRC21:13
*** apuimedo has joined #openstack-kuryr21:14
*** apuimedo has quit IRC21:25
*** apuimedo has joined #openstack-kuryr21:25
*** diogogmt has quit IRC21:27
*** irenab has quit IRC21:33
*** irenab has joined #openstack-kuryr21:34
*** irenab has quit IRC21:36
*** irenab has joined #openstack-kuryr21:38
*** irenab has quit IRC21:40
*** diogogmt has joined #openstack-kuryr21:42
*** irenab has joined #openstack-kuryr21:42
*** apuimedo has quit IRC21:47
*** apuimedo has joined #openstack-kuryr21:48
*** salv-orl_ has joined #openstack-kuryr22:09
*** salv-orlando has quit IRC22:12
*** banix has quit IRC22:18
*** banix has joined #openstack-kuryr22:19
*** banix has quit IRC22:19
*** apuimedo has quit IRC22:39
*** apuimedo has joined #openstack-kuryr22:39
*** apuimedo has quit IRC22:51
*** apuimedo has joined #openstack-kuryr22:53
*** apuimedo has quit IRC23:00
*** apuimedo has joined #openstack-kuryr23:01
*** apuimedo has quit IRC23:08
*** apuimedo has joined #openstack-kuryr23:09
*** apuimedo has quit IRC23:14
*** apuimedo has joined #openstack-kuryr23:14
*** diogogmt has quit IRC23:23
*** apuimedo has quit IRC23:24
*** apuimedo has joined #openstack-kuryr23:24
*** apuimedo has quit IRC23:29
*** apuimedo has joined #openstack-kuryr23:30
*** apuimedo has quit IRC23:35
*** apuimedo has joined #openstack-kuryr23:36
*** apuimedo has quit IRC23:40
*** apuimedo has joined #openstack-kuryr23:42
*** apuimedo has quit IRC23:47
*** apuimedo has joined #openstack-kuryr23:48

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!