| *** diogogmt has quit IRC | 00:09 | |
| *** salv-orl_ has joined #openstack-kuryr | 00:18 | |
| *** salv-orlando has quit IRC | 00:20 | |
| *** openstack has joined #openstack-kuryr | 00:51 | |
| *** diogogmt has joined #openstack-kuryr | 01:21 | |
| *** banix has joined #openstack-kuryr | 01:42 | |
| *** tfukushima has joined #openstack-kuryr | 01:54 | |
| *** tfukushima has quit IRC | 02:20 | |
| *** diogogmt has quit IRC | 02:53 | |
| *** fawadkhaliq has joined #openstack-kuryr | 03:53 | |
| *** fawadkhaliq has quit IRC | 04:00 | |
| *** banix has quit IRC | 04:28 | |
| *** fawadkhaliq has joined #openstack-kuryr | 04:45 | |
| *** fawadkhaliq has quit IRC | 04:47 | |
| *** kexiaodong has quit IRC | 04:50 | |
| *** fawadkhaliq has joined #openstack-kuryr | 05:33 | |
| *** salv-orl_ has quit IRC | 06:00 | |
| *** salv-orlando has joined #openstack-kuryr | 06:00 | |
| *** fsunaval has joined #openstack-kuryr | 06:17 | |
| *** salv-orl_ has joined #openstack-kuryr | 06:17 | |
| *** salv-orlando has quit IRC | 06:20 | |
| *** irenab has joined #openstack-kuryr | 06:31 | |
| *** tbh has joined #openstack-kuryr | 06:50 | |
| *** irenab has quit IRC | 06:51 | |
| openstackgerrit | Taku Fukushima proposed openstack/kuryr: [WIP] Add spec of blueprint existing-neutron-network https://review.openstack.org/254005 | 06:54 |
|---|---|---|
| openstackgerrit | Taku Fukushima proposed openstack/kuryr: [WIP] Add description about the IPAM to devref https://review.openstack.org/248010 | 06:58 |
| *** tfukushima has joined #openstack-kuryr | 06:59 | |
| gsagie | :( i see that Vikas didnt resolve the conflicts yet :( | 07:11 |
| openstackgerrit | Taku Fukushima proposed openstack/kuryr: Add trailing commans to follow the coding standard https://review.openstack.org/254493 | 07:18 |
| openstackgerrit | Taku Fukushima proposed openstack/kuryr: Add missing descriptions about tests for Discover APIs https://review.openstack.org/255109 | 07:28 |
| *** irenab has joined #openstack-kuryr | 07:30 | |
| *** devvesa has joined #openstack-kuryr | 07:32 | |
| openstackgerrit | Taku Fukushima proposed openstack/kuryr: Add a unit test for /NetworkDriver.GetCapabilities https://review.openstack.org/255110 | 07:34 |
| gsagie | I think we need to decouple some code to seperate files | 07:35 |
| gsagie | controller.py is getting too big | 07:35 |
| tfukushima | Right. Originally the APIs are very few. | 07:35 |
| tfukushima | Maybe we can controllers directory and put separated files under it and import them in controllers/__init__.py. | 07:37 |
| tfukushima | s/we can/we can create/ | 07:37 |
| irenab | tfukushima: what will be contained in Controllers directory? | 07:48 |
| tfukushima | IMHO, we still keep the single controllers.py atm but if the libnetwork APIs grow further, there'd be corresponding files, i.e., network_driver.py and ipam_driver.py. | 07:49 |
| tfukushima | irenab: But they share the same logic, retrieving Neutron resources for instance, so we need to make the internal functions public with the docstring. | 07:50 |
| tfukushima | In this way we can keep "from kuryr import controllers" usable. | 07:51 |
| irenab | I think you may break it per ‘driver’ and maybe API vs internal handling of the API | 07:52 |
| gsagie | yeah, i think the IPAM code could go into its seperate files | 07:52 |
| tfukushima | That's an option and there'd be some ways to split controllers.py into multiple files. | 07:52 |
| gsagie | i am re copying vikas work | 07:53 |
| irenab | tfukushima: if we keep API + its validation separate from rest of the logic, we may potentially add other APIs (maybe k8s) later and reuse the same kuryr-neutron logic | 07:56 |
| tfukushima | Originally I was not thinking in that way but yes, it'd be better to think about Kuryr as a library for the container networking with Neutron now. | 07:58 |
| openstackgerrit | Taku Fukushima proposed openstack/kuryr: Add trailing commans to follow the coding standard https://review.openstack.org/254493 | 08:32 |
| *** fawadkhaliq has quit IRC | 08:32 | |
| *** fawadkhaliq has joined #openstack-kuryr | 08:48 | |
| *** fawadkhaliq has quit IRC | 08:49 | |
| openstackgerrit | Gal Sagie proposed openstack/kuryr: Add Docker pluggable IPAM implementation to Kuryr https://review.openstack.org/255132 | 08:51 |
| *** tfukushima has quit IRC | 08:51 | |
| *** tfukushima has joined #openstack-kuryr | 08:52 | |
| gsagie | i re-sent vikas patch: https://review.openstack.org/255132 | 08:55 |
| gsagie | all combined in one | 08:55 |
| gsagie | lets try to review it so we can merge this code because these dependency chains are killing me :) | 08:55 |
| *** salv-orl_ has quit IRC | 08:58 | |
| tfukushima | We should look at them one by one. The big gigantic patch is killing me and makes the review difficult and careless. | 09:04 |
| *** lezbar has joined #openstack-kuryr | 09:04 | |
| *** openstack has joined #openstack-kuryr | 09:07 | |
| openstackgerrit | Gal Sagie proposed openstack/kuryr: Create subnets in /NetworkDriver.CreateNetwork using IPv4Data and IPv6Data https://review.openstack.org/255143 | 09:14 |
| openstackgerrit | Gal Sagie proposed openstack/kuryr: /NetworkDriver.CreateEndpoint cleanup https://review.openstack.org/255153 | 09:31 |
| *** openstackgerrit has quit IRC | 09:32 | |
| *** openstackgerrit has joined #openstack-kuryr | 09:32 | |
| *** fawadkhaliq has joined #openstack-kuryr | 09:34 | |
| gsagie | apuimedo: ping | 09:47 |
| *** tfukushima has quit IRC | 09:52 | |
| irenab | gsagie: hi | 09:53 |
| gsagie | hi | 09:55 |
| *** salv-orlando has joined #openstack-kuryr | 09:59 | |
| openstackgerrit | Merged openstack/kuryr: Add missing descriptions about tests for Discover APIs https://review.openstack.org/255109 | 09:59 |
| irenab | Can you please let me know if there is some priority n the patches you resubmitted? It may take me time today to review all | 10:00 |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #openstack-kuryr | 10:02 | |
| *** salv-orlando has quit IRC | 10:03 | |
| gsagie | well, its just Vikas patches re-submmited | 10:04 |
| gsagie | because i didnt want him to start doing the rebases on my change | 10:04 |
| gsagie | and it kinda did some mess | 10:04 |
| gsagie | so i thought its easier to iterate it like that, if you have time please review, i am going to do it myself as well | 10:05 |
| apuimedo | gsagie: pong | 10:07 |
| irenab | gsagie: ok, thanks | 10:10 |
| openstackgerrit | Merged openstack/kuryr: Add a unit test for /NetworkDriver.GetCapabilities https://review.openstack.org/255110 | 10:21 |
| *** fawadkhaliq has quit IRC | 10:57 | |
| *** fawadkhaliq has joined #openstack-kuryr | 10:57 | |
| *** fawadkhaliq has quit IRC | 11:03 | |
| *** salv-orlando has joined #openstack-kuryr | 11:10 | |
| openstackgerrit | Gal Sagie proposed openstack/kuryr: Add rally integration point https://review.openstack.org/255219 | 11:57 |
| *** salv-orl_ has joined #openstack-kuryr | 12:17 | |
| *** salv-orlando has quit IRC | 12:20 | |
| *** devvesa has quit IRC | 12:20 | |
| *** fawadkhaliq has joined #openstack-kuryr | 12:38 | |
| *** gsagie has quit IRC | 12:39 | |
| *** salv-orl_ has quit IRC | 12:44 | |
| *** salv-orlando has joined #openstack-kuryr | 12:49 | |
| *** gsagie has joined #openstack-kuryr | 12:52 | |
| *** tbh has quit IRC | 12:55 | |
| *** fawadkhaliq has quit IRC | 13:27 | |
| *** gsagie has quit IRC | 13:27 | |
| *** gsagie has joined #openstack-kuryr | 13:36 | |
| *** diogogmt has joined #openstack-kuryr | 13:42 | |
| *** banix has joined #openstack-kuryr | 14:22 | |
| *** diogogmt has quit IRC | 14:24 | |
| *** diogogmt has joined #openstack-kuryr | 14:26 | |
| *** devvesa has joined #openstack-kuryr | 14:33 | |
| *** diogogmt has quit IRC | 14:38 | |
| *** fawadkhaliq has joined #openstack-kuryr | 14:43 | |
| *** gsagie_ has joined #openstack-kuryr | 14:56 | |
| *** irenab has quit IRC | 15:07 | |
| *** diogogmt has joined #openstack-kuryr | 15:25 | |
| *** gsagie_ has quit IRC | 15:53 | |
| *** irenab has joined #openstack-kuryr | 15:56 | |
| *** lezbar has quit IRC | 16:00 | |
| *** lezbar has joined #openstack-kuryr | 16:04 | |
| *** diogogmt has quit IRC | 16:22 | |
| *** apuimedo is now known as away | 16:44 | |
| *** away is now known as Guest32752 | 16:45 | |
| *** diogogmt has joined #openstack-kuryr | 17:08 | |
| *** diogogmt_ has joined #openstack-kuryr | 17:13 | |
| *** diogogmt has quit IRC | 17:13 | |
| *** diogogmt_ is now known as diogogmt | 17:13 | |
| *** salv-orlando has quit IRC | 17:30 | |
| *** devvesa has quit IRC | 17:36 | |
| *** salv-orlando has joined #openstack-kuryr | 17:49 | |
| *** gsagie_ has joined #openstack-kuryr | 17:50 | |
| *** salv-orlando has quit IRC | 17:52 | |
| *** gsagie_ has quit IRC | 18:32 | |
| *** gsagie_ has joined #openstack-kuryr | 18:49 | |
| *** gsagie_ has quit IRC | 18:54 | |
| *** fawadkhaliq has quit IRC | 19:04 | |
| *** salv-orlando has joined #openstack-kuryr | 19:05 | |
| *** salv-orlando has quit IRC | 19:36 | |
| *** fsunaval has quit IRC | 19:57 | |
| *** salv-orlando has joined #openstack-kuryr | 20:10 | |
| *** fsunaval has joined #openstack-kuryr | 20:58 | |
| *** fsunaval has quit IRC | 21:25 | |
| *** Guest32752 is now known as apuimedo | 21:49 | |
| *** dingboopt has quit IRC | 22:39 | |
| *** banix has quit IRC | 23:04 | |
| *** fsunaval has joined #openstack-kuryr | 23:22 | |
| *** dingboopt has joined #openstack-kuryr | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!