| *** banix has joined #openstack-kuryr | 00:17 | |
| *** apuimedo has quit IRC | 01:04 | |
| *** apuimedo has joined #openstack-kuryr | 01:05 | |
| *** apuimedo has quit IRC | 01:22 | |
| *** apuimedo has joined #openstack-kuryr | 01:23 | |
| *** apuimedo has quit IRC | 01:27 | |
| *** apuimedo has joined #openstack-kuryr | 01:28 | |
| openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Adding plug/unplug for OVS https://review.openstack.org/253285 | 01:35 |
|---|---|---|
| openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Adding plug/unplug for OVS https://review.openstack.org/253285 | 01:37 |
| *** apuimedo has quit IRC | 01:42 | |
| *** apuimedo has joined #openstack-kuryr | 01:43 | |
| openstackgerrit | Merged openstack/kuryr: Correct location of auto-generated config file https://review.openstack.org/252548 | 01:43 |
| openstackgerrit | Merged openstack/kuryr: Add docker-py to requierments https://review.openstack.org/252927 | 01:44 |
| *** apuimedo has quit IRC | 01:48 | |
| *** apuimedo has joined #openstack-kuryr | 01:48 | |
| *** apuimedo has quit IRC | 01:53 | |
| openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Completing the basic configuration for Kuryr https://review.openstack.org/251532 | 01:54 |
| *** apuimedo has joined #openstack-kuryr | 01:55 | |
| openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Completing the basic configuration for Kuryr https://review.openstack.org/251532 | 01:55 |
| *** salv-orlando has joined #openstack-kuryr | 02:02 | |
| *** apuimedo has quit IRC | 02:04 | |
| *** tfukushima has joined #openstack-kuryr | 02:04 | |
| *** apuimedo has joined #openstack-kuryr | 02:05 | |
| *** salv-orlando has quit IRC | 02:07 | |
| *** apuimedo has quit IRC | 02:09 | |
| *** apuimedo has joined #openstack-kuryr | 02:10 | |
| *** apuimedo has quit IRC | 02:14 | |
| *** apuimedo has joined #openstack-kuryr | 02:16 | |
| banix | tfukushima: hi Taku | 02:20 |
| banix | I just put a print statement in controllers.py and see that it gets executed before anything else in server.start() | 02:22 |
| openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Completing the basic configuration for Kuryr https://review.openstack.org/251532 | 02:23 |
| *** apuimedo has quit IRC | 02:28 | |
| tfukushima | Hi banix, | 02:30 |
| *** apuimedo has joined #openstack-kuryr | 02:30 | |
| banix | tfukushima: hi, just posted the comment on review | 02:32 |
| *** apuimedo has quit IRC | 02:40 | |
| *** apuimedo has joined #openstack-kuryr | 02:41 | |
| *** apuimedo has quit IRC | 02:45 | |
| *** apuimedo has joined #openstack-kuryr | 02:47 | |
| *** apuimedo has quit IRC | 02:54 | |
| *** apuimedo has joined #openstack-kuryr | 02:55 | |
| *** banix has quit IRC | 03:02 | |
| *** apuimedo has quit IRC | 03:12 | |
| *** apuimedo has joined #openstack-kuryr | 03:12 | |
| *** apuimedo has quit IRC | 03:17 | |
| *** apuimedo has joined #openstack-kuryr | 03:18 | |
| *** apuimedo has quit IRC | 03:23 | |
| *** apuimedo has joined #openstack-kuryr | 03:24 | |
| *** apuimedo has quit IRC | 03:29 | |
| *** apuimedo has joined #openstack-kuryr | 03:31 | |
| *** tfukushima has quit IRC | 03:35 | |
| *** tfukushima has joined #openstack-kuryr | 03:37 | |
| *** tfukushi_ has joined #openstack-kuryr | 03:38 | |
| *** tfukushima has quit IRC | 03:38 | |
| *** apuimedo has quit IRC | 03:38 | |
| *** apuimedo has joined #openstack-kuryr | 03:38 | |
| *** vikasc has joined #openstack-kuryr | 03:42 | |
| *** apuimedo has quit IRC | 03:45 | |
| *** apuimedo has joined #openstack-kuryr | 03:47 | |
| vikasc | Hi tfukushi_ | 03:48 |
| tfukushi_ | Hi vikasc, | 03:48 |
| vikasc | do we still need ipam placeholders patch | 03:48 |
| vikasc | i was never inactive on ipam | 03:49 |
| vikasc | neither i missed any meeting | 03:49 |
| tfukushi_ | Sorry I was reviewing banix's patch. | 03:49 |
| vikasc | Even i had discussed with you that i am going to push changes, but somehow you pushed placeholders patch | 03:50 |
| tfukushi_ | My point is I can't see any problem for --ipam-driver=kuryr. | 03:50 |
| tfukushi_ | And we'd have more complexities than advantages to introduce another server only for the name kuryr-ipam. | 03:51 |
| vikasc | thats a very small change if you are so hard on that i welcome you point and will update patch which i have co-authored | 03:51 |
| vikasc | there is single server only | 03:52 |
| vikasc | running on port 2377 | 03:52 |
| vikasc | --ipam-driver=kuryr-ipam is just another name pointing to same server | 03:52 |
| vikasc | I think you got confused by two names | 03:53 |
| vikasc | server is same, just two different names. | 03:54 |
| tfukushi_ | Ah, I see. Actually it's confusing. | 03:54 |
| vikasc | But like this there will be more points on which you along with other reviewers will have to help to improve quality | 03:55 |
| vikasc | and i commit that i will never be late in addressing review comments | 03:55 |
| vikasc | so you keeping placeholders patch active is making me nervous | 03:56 |
| vikasc | i am not able to think whats on your mind. | 03:56 |
| *** yasui_ has joined #openstack-kuryr | 03:57 | |
| *** apuimedo has quit IRC | 03:58 | |
| tfukushi_ | vikasc: I don't mean to take over the IPAM work at all but I think my patch could be put there. | 04:00 |
| *** apuimedo has joined #openstack-kuryr | 04:00 | |
| vikasc | :) | 04:00 |
| tfukushi_ | (If --ipam-driver=kuryr is Ok for you) | 04:00 |
| tfukushi_ | In general the spec should be first, then some small patches for the foundation and then implementations should come finally. | 04:00 |
| vikasc | now complete implementation i have pushed | 04:01 |
| vikasc | please Taku | 04:01 |
| vikasc | try to understand | 04:01 |
| vikasc | IMO gap was on your side that you pushed your patch even when you know that i am working actively on ipam | 04:02 |
| vikasc | and now when i have complete implementations you want me to abandon my patches to get your placeholders merge | 04:03 |
| vikasc | :) | 04:03 |
| vikasc | common Taku | 04:03 |
| vikasc | are you serious | 04:03 |
| vikasc | Mate | 04:04 |
| vikasc | please understand | 04:04 |
| vikasc | just for few lines dont be so harsh | 04:04 |
| tfukushi_ | I don't know what to say and I'm not sure what you want. Lets' just discuss resonably. | 04:06 |
| vikasc | I was actively working on ipam and in every meeting was telling my plans and status | 04:07 |
| tfukushi_ | First, my concern is just kuryr-ipam is confused. That's what we need to discuss. | 04:07 |
| tfukushi_ | Second, you didn't add reviewers and we couldn't recognise your activity. So our work was unfortunately conflicted. | 04:08 |
| vikasc | that question is whether we want two seperate names , kuryr and kuryr-ipam or just single name kuryr. | 04:08 |
| vikasc | on this, i had two seperate names but i am not strict on that | 04:09 |
| vikasc | if you feel names should be same, "kuryr" will remove that json file which is pointing to server | 04:09 |
| tfukushi_ | Third, if my patch was totally conflicted with your work until then, I'll abandon my patch. But it doesn't seem the same and you took some from my patch. | 04:11 |
| vikasc | i dint add reviewers but you missed meeting and you ipam bp was assigned to me. Plus i had told you on irc that i am goint ot push changes. So should not you have looked for a moment before pushing your patch? | 04:11 |
| vikasc | i just took doc strings, and for that i have added you as co-author. | 04:12 |
| vikasc | Taku there is huge work in kuryr..long way to go | 04:13 |
| tfukushi_ | Plus unit test foundation. Thanks for doing that. But what I care is not that. I just want the merge process faster and our effort minimum. | 04:13 |
| tfukushi_ | Adding Co-Authored-By to every patch doesn't look good. | 04:14 |
| vikasc | so for that after welcoming your review comment i split that into muliplt patches | 04:14 |
| vikasc | just for doc-string why will i add you co-author in each patch | 04:14 |
| vikasc | ? | 04:14 |
| vikasc | Given when your patch submission was totally unethical | 04:15 |
| vikasc | Taku is very demotivating for me | 04:15 |
| vikasc | kuryr is not reason for my life's survival :) | 04:16 |
| vikasc | Taku this is very demotivating for me | 04:16 |
| tfukushi_ | vikasc: I'm sorry if you feel like that. I totally don't mean it. | 04:17 |
| vikasc | what else then.. there are so many open source projects. I think you alone want to write kuryr | 04:17 |
| vikasc | Please justify pushing of placeholders patch. That is the root cause of conflict. | 04:19 |
| vikasc | Thats all from my side :) | 04:20 |
| vikasc | Now upto you and Team. I know i am not wrong anywhere | 04:21 |
| tfukushi_ | vikasc: Please don't feel like that and let me put my lines. And please don't get confused with the patch review itself and the conflict problem. | 04:21 |
| *** tbh has joined #openstack-kuryr | 04:22 | |
| tfukushi_ | Kuryr is not my life and I also don't want this. | 04:22 |
| vikasc | tfukushi_, i want to work with you Taku. As i said earlier also you are a great technical guy | 04:22 |
| vikasc | i want to learn from you , please let me complete this. | 04:23 |
| vikasc | As patches are smaller now, help me through your reviews . There will be no delay from my side | 04:24 |
| tfukushi_ | So You told you worked on the "null" IPAM driver and I'm confused it with the empty something. That's why I told I worked on the IPAM spec and submitted the placeholders. | 04:25 |
| tfukushi_ | I didn't mean it intension as you know I din't know about your patch. | 04:25 |
| vikasc | But in "null" case also how a driver would have worked without placeholdrs | 04:26 |
| tfukushi_ | And I was on holiday when you had the IRC meeting. Plus it's 0am in Japan. I have put myself very hard for last few months. It was not easy for me. | 04:27 |
| vikasc | bp is assigned to me, every irc meeting i am reporting my status, on irc we are talking.. how come you dint bother to have a word with me before submitting your patch | 04:27 |
| *** fawadkhaliq has joined #openstack-kuryr | 04:28 | |
| tfukushi_ | Now I'm happier because we have multiple meeting times. | 04:28 |
| vikasc | :D | 04:28 |
| vikasc | Bro lets please close this. Lets forget whatever happened. | 04:29 |
| tfukushi_ | Yes, and as I told in review, "please think about it". I'm not forcing my patch merged. | 04:30 |
| vikasc | Lets be more careful in future. IMO, his kind of situations not good at all for kuryr. | 04:30 |
| tfukushi_ | Yes. I'll abandon my patches. | 04:31 |
| vikasc | I will keep same name, kuryr. will update that patch. Anyways server is single only | 04:31 |
| vikasc | Truely appreciate for understanding. And apologies if i have spoken more. | 04:32 |
| tfukushi_ | 1. Let's discuss carefully about the task assignments and make it claer who is working what | 04:33 |
| tfukushi_ | 2. Let's add reviewers when you submit patch. I personally want Kuryr group that adds we all in one shot | 04:33 |
| tfukushi_ | I know Gerrit has the capability but I don't know how to do that in OpenStack review system | 04:34 |
| tfukushi_ | 3. Let's make patches small pieces and easy to be reviewed | 04:37 |
| *** apuimedo has quit IRC | 04:40 | |
| tfukushi_ | vikasc: Personally, the spec should come first and the implementations should follow | 04:40 |
| *** apuimedo has joined #openstack-kuryr | 04:40 | |
| tfukushi_ | devref style is much clearer to know what's going on | 04:40 |
| vikasc | I also keeping an eye and provind comments on dev ref also | 04:41 |
| vikasc | will keep updating patches as per devref | 04:41 |
| *** fawadkhaliq has quit IRC | 04:42 | |
| tfukushi_ | vikasc: And please update the blueprint. You patch is beyond the range of it already. https://blueprints.launchpad.net/kuryr/+spec/remote-ipam-driver | 04:42 |
| vikasc | I will add description there. | 04:42 |
| tfukushi_ | "2. Ipam drver will return empty responses." is not true anymore and I'm pretty sure it's not null IPAM driver. | 04:43 |
| vikasc | things were not that clear initially. Will update this also | 04:43 |
| vikasc | that was intended for case when --subnet is not used | 04:44 |
| vikasc | will update this and link of devref there. | 04:46 |
| *** apuimedo has quit IRC | 04:47 | |
| *** apuimedo has joined #openstack-kuryr | 04:48 | |
| tfukushi_ | vikasc: And we think in the different ways but I think even documents and something except for code are even someone's work. So I think they should be treated as like code in my opinion. | 04:50 |
| *** salv-orlando has joined #openstack-kuryr | 04:51 | |
| tfukushi_ | I'm out to lunch for a while. | 04:51 |
| *** tfukushi_ has quit IRC | 04:53 | |
| *** salv-orlando has quit IRC | 04:56 | |
| *** apuimedo has quit IRC | 05:00 | |
| *** apuimedo has joined #openstack-kuryr | 05:01 | |
| *** fawadkhaliq has joined #openstack-kuryr | 05:04 | |
| *** apuimedo has quit IRC | 05:10 | |
| *** apuimedo has joined #openstack-kuryr | 05:11 | |
| *** apuimedo has quit IRC | 05:20 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: /NetworkDriver.CreateEndpoint cleanup https://review.openstack.org/253323 | 05:22 |
| *** apuimedo has joined #openstack-kuryr | 05:22 | |
| *** apuimedo has quit IRC | 05:29 | |
| *** apuimedo has joined #openstack-kuryr | 05:30 | |
| *** apuimedo has quit IRC | 05:35 | |
| *** apuimedo has joined #openstack-kuryr | 05:35 | |
| *** apuimedo has quit IRC | 05:40 | |
| *** apuimedo has joined #openstack-kuryr | 05:41 | |
| *** irenab_ has joined #openstack-kuryr | 05:42 | |
| *** irenab has quit IRC | 05:44 | |
| *** irenab_ is now known as irenab | 05:44 | |
| *** apuimedo has quit IRC | 05:50 | |
| *** apuimedo has joined #openstack-kuryr | 05:50 | |
| *** salv-orlando has joined #openstack-kuryr | 05:52 | |
| *** tfukushima has joined #openstack-kuryr | 05:54 | |
| *** apuimedo has quit IRC | 05:55 | |
| *** salv-orl_ has joined #openstack-kuryr | 05:56 | |
| *** salv-orlando has quit IRC | 05:56 | |
| *** salv-orl_ has quit IRC | 05:56 | |
| *** apuimedo has joined #openstack-kuryr | 05:57 | |
| *** salv-orlando has joined #openstack-kuryr | 05:57 | |
| *** tfukushima has quit IRC | 05:59 | |
| *** apuimedo has quit IRC | 06:06 | |
| *** apuimedo has joined #openstack-kuryr | 06:07 | |
| *** salv-orlando has quit IRC | 06:10 | |
| *** apuimedo has quit IRC | 06:11 | |
| *** apuimedo has joined #openstack-kuryr | 06:12 | |
| *** apuimedo has quit IRC | 06:17 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: IPAM: Implement /Plugin.Activate and /IpamDriver.RequestPool https://review.openstack.org/252796 | 06:18 |
| *** apuimedo has joined #openstack-kuryr | 06:18 | |
| *** tfukushima has joined #openstack-kuryr | 06:21 | |
| *** apuimedo has quit IRC | 06:25 | |
| *** apuimedo has joined #openstack-kuryr | 06:26 | |
| *** tbh has quit IRC | 06:28 | |
| openstackgerrit | vikas choudhary proposed openstack/kuryr: IPAM: Implement /IpamDriver.RequestAddress https://review.openstack.org/252835 | 06:30 |
| *** tbh has joined #openstack-kuryr | 06:44 | |
| *** vikasc has quit IRC | 06:53 | |
| *** yasui_ has quit IRC | 06:59 | |
| *** devvesa has joined #openstack-kuryr | 07:30 | |
| *** salv-orlando has joined #openstack-kuryr | 07:44 | |
| *** kexiaodong has joined #openstack-kuryr | 08:08 | |
| *** fawadkhaliq has quit IRC | 08:31 | |
| *** fawadkhaliq has joined #openstack-kuryr | 08:31 | |
| *** yasui_ has joined #openstack-kuryr | 08:32 | |
| *** tbh has quit IRC | 08:34 | |
| *** tbh has joined #openstack-kuryr | 08:35 | |
| *** salv-orlando has quit IRC | 08:42 | |
| *** fawadkhaliq has quit IRC | 08:47 | |
| *** fawadkhaliq has joined #openstack-kuryr | 08:47 | |
| *** salv-orlando has joined #openstack-kuryr | 08:48 | |
| *** tfukushima has quit IRC | 08:48 | |
| *** devvesa has quit IRC | 08:48 | |
| *** tfukushima has joined #openstack-kuryr | 08:49 | |
| *** tfukushima has quit IRC | 08:51 | |
| *** vikasc has joined #openstack-kuryr | 08:51 | |
| *** tfukushima has joined #openstack-kuryr | 08:51 | |
| *** apuimedo has quit IRC | 08:53 | |
| *** apuimedo has joined #openstack-kuryr | 08:54 | |
| *** apuimedo has quit IRC | 09:01 | |
| *** apuimedo has joined #openstack-kuryr | 09:03 | |
| *** apuimedo has quit IRC | 09:41 | |
| *** apuimedo has joined #openstack-kuryr | 09:42 | |
| *** salv-orlando has quit IRC | 09:52 | |
| *** vikasc has quit IRC | 09:58 | |
| *** vikasc has joined #openstack-kuryr | 10:03 | |
| *** salv-orlando has joined #openstack-kuryr | 10:10 | |
| *** yasui_ has quit IRC | 10:11 | |
| *** openstackgerrit has quit IRC | 10:32 | |
| *** openstackgerrit has joined #openstack-kuryr | 10:33 | |
| *** tfukushima has quit IRC | 10:34 | |
| *** tbh has quit IRC | 10:34 | |
| *** vikasc has quit IRC | 10:36 | |
| *** vikasc has joined #openstack-kuryr | 10:52 | |
| *** vikasc has quit IRC | 11:01 | |
| *** devvesa has joined #openstack-kuryr | 11:05 | |
| *** salv-orlando has quit IRC | 11:07 | |
| *** vikasc has joined #openstack-kuryr | 11:18 | |
| *** salv-orlando has joined #openstack-kuryr | 11:18 | |
| *** tfukushima has joined #openstack-kuryr | 11:33 | |
| *** salv-orlando has quit IRC | 11:36 | |
| *** fawadkhaliq has quit IRC | 11:53 | |
| *** vikasc has quit IRC | 11:59 | |
| *** vikasc has joined #openstack-kuryr | 12:12 | |
| *** tfukushima has quit IRC | 12:24 | |
| *** salv-orlando has joined #openstack-kuryr | 12:54 | |
| *** salv-orlando has quit IRC | 12:58 | |
| *** devvesa has quit IRC | 13:00 | |
| *** vikasc has quit IRC | 13:36 | |
| *** devvesa has joined #openstack-kuryr | 13:37 | |
| *** salv-orlando has joined #openstack-kuryr | 14:16 | |
| *** gsagie_ has joined #openstack-kuryr | 14:34 | |
| *** fawadkhaliq has joined #openstack-kuryr | 14:46 | |
| *** banix has joined #openstack-kuryr | 14:50 | |
| *** kexiaodong_ has joined #openstack-kuryr | 14:54 | |
| *** kexiaodong has quit IRC | 14:54 | |
| *** kexiaodong_ is now known as kexiaodong | 14:54 | |
| *** salv-orlando has quit IRC | 14:57 | |
| *** banix has quit IRC | 15:02 | |
| *** salv-orlando has joined #openstack-kuryr | 15:12 | |
| *** banix has joined #openstack-kuryr | 15:19 | |
| *** gsagie_ has quit IRC | 15:38 | |
| *** fawadkhaliq has quit IRC | 15:41 | |
| *** salv-orlando has quit IRC | 15:44 | |
| openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Completing the basic configuration for Kuryr https://review.openstack.org/251532 | 15:45 |
| *** banix has quit IRC | 16:38 | |
| *** salv-orlando has joined #openstack-kuryr | 17:01 | |
| *** devvesa has quit IRC | 17:08 | |
| *** fawadkhaliq has joined #openstack-kuryr | 17:46 | |
| *** lezbar has quit IRC | 18:01 | |
| *** lezbar has joined #openstack-kuryr | 18:01 | |
| *** lezbar has quit IRC | 18:06 | |
| *** banix has joined #openstack-kuryr | 18:39 | |
| openstackgerrit | Mohammad Banikazemi proposed openstack/kuryr: Completing the basic configuration for Kuryr https://review.openstack.org/251532 | 18:46 |
| *** fawadkhaliq has quit IRC | 19:29 | |
| *** banix has quit IRC | 20:47 | |
| *** banix has joined #openstack-kuryr | 21:09 | |
| *** salv-orl_ has joined #openstack-kuryr | 22:54 | |
| *** salv-orlando has quit IRC | 22:57 | |
| *** openstack has joined #openstack-kuryr | 23:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!