| opendevreview | Michal Arbet proposed openstack/kolla master: Change copy-cacerts behaviour https://review.opendev.org/c/openstack/kolla/+/926882 | 06:23 |
|---|---|---|
| kevko | \o/ | 07:42 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: link venv/etc to /etc https://review.opendev.org/c/openstack/kolla/+/936733 | 08:15 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: link venv/etc to /etc https://review.opendev.org/c/openstack/kolla/+/936733 | 08:16 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: link venv/etc to /etc https://review.opendev.org/c/openstack/kolla/+/936733 | 08:20 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: link venv/etc to /etc https://review.opendev.org/c/openstack/kolla/+/936733 | 08:22 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: link venv/etc to /etc https://review.opendev.org/c/openstack/kolla/+/936733 | 08:23 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: link venv/etc to /etc https://review.opendev.org/c/openstack/kolla/+/936733 | 08:26 |
| kevko | mnasiadka: Looking at your review, it occurred to me (and actually, even in the past)... why are we dealing with permissions in Dockerfiles when we have the kolla_set_configs script? We have it in sudoers, and config.json is the source of truth for permissions. So, every time a container starts, we can nicely utilize this. Instead, I feel like in | 08:50 |
| kevko | some places it's done this way, in others differently, and in some cases, it's a mix :D | 08:50 |
| mnasiadka | Yeah, unfortunately that's the case - in a lot of cases we copy config files that are not required anywhere ;-) | 08:54 |
| kevko | mnasiadka: what do you mean ? | 08:55 |
| mnasiadka | Well, a lot of openstack projects don't copy config files into /etc/$service_name, we do, some old keystone auth configs for example in Magnum, and so on | 08:55 |
| mnasiadka | some projects copy rootwrap stuff into /etc/$service_name, some don't, it's a mess :D | 08:56 |
| kevko | mnasiadka: yeah, but it shouldn't be the case to generate it in container ... oslopolicy generator, oslo generator ...etc ..etc | 08:56 |
| kevko | mnasiadka: only thing which can be issue is maybe paste-ini ? | 09:00 |
| kevko | as it's only one manually provided by developers .. | 09:00 |
| kevko | mnasiadka: https://review.opendev.org/c/openstack/kolla/+/926882 << what about this patch ..would you like to give second +2 ? | 09:12 |
| kevko | mnasiadka: needed by https://review.opendev.org/c/openstack/kolla-ansible/+/924651 and whole chain | 09:13 |
| priteau | Hello. Could core reviewers please have a look at https://review.opendev.org/c/openstack/kolla-ansible/+/934419? It's quite trivial. | 10:03 |
| priteau | Thank you frickler | 10:29 |
| priteau | However you said "single-approving" but didn't set W+1 :) | 10:37 |
| frickler | yes, I wanted to drop that comment but it stuck. I'll give others an hour or two, given that the fix is almost a month old and the bug much older | 10:38 |
| priteau | mnasiadka has voted +2 too | 10:39 |
| frickler | ah, ok, and done | 10:40 |
| priteau | Thanks. This other trivial one is also waiting: https://review.opendev.org/c/openstack/kolla-ansible/+/924605. Should I propose it to stable/2024.2 though, given https://docs.openstack.org/reno/latest/user/usage.html#updating-stable-branch-release-notes? | 10:45 |
| kevko | priteau: done | 11:09 |
| yosef | mnasiadka: Hi, can you checkout these: 1. ovn election timeout: https://review.opendev.org/c/openstack/kolla-ansible/+/934106 2. refactor ovn dbs remotes: https://review.opendev.org/c/openstack/kolla-ansible/+/935467 3. ovn relay: https://review.opendev.org/c/openstack/kolla-ansible/+/929646 | 11:28 |
| yosef | SvenKieske: Can you check out the election timeout patch I have edited it, https://review.opendev.org/c/openstack/kolla-ansible/+/934106 | 11:29 |
| opendevreview | Merged openstack/kolla-ansible master: Fix internal endpoint for the heat-cfn service https://review.opendev.org/c/openstack/kolla-ansible/+/934419 | 11:59 |
| frickler | priteau: hmm, iiuc that patch should only be made against the branch in which the reno lives. so cancel the merge and only update in 2024.2? | 11:59 |
| frickler | ah, wasn't merging yet due to reviewer oversight of merge-requirements. so I -3d it | 12:08 |
| opendevreview | Pierre Riteau proposed openstack/kolla-ansible stable/2024.2: Fix internal endpoint for the heat-cfn service https://review.opendev.org/c/openstack/kolla-ansible/+/936826 | 12:33 |
| opendevreview | Pierre Riteau proposed openstack/kolla-ansible stable/2024.2: Fix hyperlink syntax in release notes https://review.opendev.org/c/openstack/kolla-ansible/+/936827 | 12:36 |
| opendevreview | Pierre Riteau proposed openstack/kolla master: Add Python 3.12 classifier https://review.opendev.org/c/openstack/kolla/+/936834 | 13:29 |
| opendevreview | Merged openstack/kolla-ansible stable/2024.2: Fix hyperlink syntax in release notes https://review.opendev.org/c/openstack/kolla-ansible/+/936827 | 13:30 |
| kevko | frickler: are you now ok with my comments ? https://review.opendev.org/c/openstack/kolla/+/926882 | 13:31 |
| frickler | kevko: yes, +2d, thx | 13:51 |
| kevko | frickler: thank you also | 13:52 |
| kevko | mnasiadka: what about you ? Can we merge now ? | 13:52 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Add TLS support for MariaDB Connections https://review.opendev.org/c/openstack/kolla-ansible/+/933924 | 14:23 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: openstack-base: link venv/etc to /etc https://review.opendev.org/c/openstack/kolla/+/936733 | 16:10 |
| kevko | mnasiadka: thanks | 16:39 |
| mnasiadka | np | 16:40 |
| kevko | mnasiadka: i've checked patch which is reverting openstack_release and noticed that designate is failing because of rootwrap.conf | 16:41 |
| kevko | mnasiadka: i think it was also inspiration for you to manipulate with paths ? | 16:41 |
| kevko | mnasiadka: because i probably have an idea how to do it permanently OK :) | 16:42 |
| mnasiadka | yeah, maybe - don't really remember, but the more I look into that code, the worse I feel ;-) | 16:43 |
| kevko | mnasiadka: :D :D :D | 16:43 |
| kevko | going to try | 16:44 |
| mnasiadka | but at least now the build should pass | 16:45 |
| kevko | mnasiadka: let me try something | 16:46 |
| kevko | how it can work right ? :D | 16:49 |
| frickler | designate renamed rootwrap.conf, which I consider rather unfortunate, in particular without a reno https://review.opendev.org/c/openstack/designate/+/934526 | 17:31 |
| opendevreview | Merged openstack/kolla master: Change copy-cacerts behaviour https://review.opendev.org/c/openstack/kolla/+/926882 | 17:46 |
| -opendevstatus- NOTICE: Gerrit will have a short outage while we update to the latest 3.9 release in preparation for our 3.10 upgrade on Friday | 21:31 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!