Tuesday, 2024-09-10

arcaynehey all! anyone around at the moment? hoping to get some clarity on vf-lag config w/ kayobe00:27
arcaynemainly trying to understand how the group_vars should be set for network-interfaces - I've got bonds/bridges in place, but I suspect I took it a little too far which is causing the vf-lags to not bind properly during the service deployment stage.00:30
opendevreviewMatúš Jenča proposed openstack/kolla-ansible master: Add certificates for RabbitMQ internode TLS  https://review.opendev.org/c/openstack/kolla-ansible/+/92138006:51
mnasiadkaarcayne: your timezone might not be ideal for communicating with us :)07:59
arcaynemnasiadka: haha, I've noticed that - thankfully I'm a night owl :)08:01
opendevreviewRoman Krček proposed openstack/kolla-ansible master: Refactor nova upgrade task  https://review.opendev.org/c/openstack/kolla-ansible/+/92832508:10
arcaynemnasiadka: do you know if there is a good day of the week for asking questions? I don't want to interrupt important dev discussions with my n00b problems.08:10
SvenKieskewell if you see nobody writing, it's a good way to not interrupt something ;) if our timezone is non fitting you could also ask questions via the mailing list, but that usually takes longer to answer, but also has the benefit of higher visibility.08:12
SvenKieskepersonally I'm not really involved in kayobe, but the stackhpc people should be able to help :)08:12
bbezakarcayne: did you see https://www.stackhpc.com/vflag-kayobe.html ? updated playbooks lies here - https://github.com/stackhpc/kayobe-ops/blob/master/vf-lag-host-configure.yml https://github.com/stackhpc/kayobe-ops/blob/master/vf-lag-service-deploy.yml08:13
opendevreviewRoman Krček proposed openstack/kolla-ansible master: Don't notify handlers during copy-cert  https://review.opendev.org/c/openstack/kolla-ansible/+/92465108:13
arcayneSvenKieske: haha good point ;p I don't mind hanging out late, but the mailing list is a good idea! may resort to that later this week if I'm still stuck on this issue08:14
arcaynebbezak: I have, yes. Been trying to piece together my config based on all those resources you linked. I think I'm just misunderstanding something, kinda jumped in the deep end trying to learn kayobe/kolla + achieve dual NIC SR-IOV/VF-LAG right off the bat.08:16
arcayneI've been able to run the playbooks all the way to the final `kayobe overcloud service deploy`, but when ssh'ing into a node to confirm vf-lag is working, the output from `dmesg | grep 'mlx5.*lag'` indicates that the ports are not properly lag'd.08:21
arcayneI followed this gist from jovial the other week and just kind of built ontop of it with my sriov/vflag config, and I'm wondering if that was a bad move on my part: https://gist.github.com/jovial/939f6436884fcc512e63c2ef407ec47a08:22
arcayneto be clear, jovial's gist worked great prior to me trying to get vf-lag working - I'm just thinking that having those existing bridges in place might be interfering?08:25
dswebbHi, I was wondering if there was a reason kolla creates images for the prometheus-ovn-exporter but kolla-ansible doesn't have a deployment of it?  I'm happy adding it to kolla ansible, but wasn't sure if there was a specific reason why it wasn't deployed.08:38
mnasiadkaThere is a patch in progress already08:49
dswebbhttps://review.opendev.org/c/openstack/kolla-ansible/+/855498 ?08:50
bbezakyes arcayne, physnet needs to be on bond directly, as written in the blog post: "./etc/kayobe/inventory/group_vars/overcloud/network-interfaces"09:00
bbezak:) copy paste fail: "OpenStack networking must be configured without a Linuxbridge directly attached to the bond0 interface"09:00
arcaynebbezak: ah! I did notice that in the blog post, which is what made me think I was incorrect to build upon the bond/bridge example from jovial. I suppose my question then becomes, if I only define the bonds, with no bridges - what is the correct method of mapping the logical networks I've defined in networks.yml to my various group_var network-interfaces configs? (could be a very dumb question, I apologize)09:09
arcaynefor example, in my controller group I'd like to ensure my public & external networks are mapped to nic0/bond0, and my internal, storage, and tunnel networks are mapped to nic1/bond1. easy to do with bridges, but trying to achieve this in a way that supports vf-lag is where I'm getting lost.09:16
bbezakwell, this gist looks good - https://gist.github.com/jovial/939f6436884fcc512e63c2ef407ec47a09:20
bbezakno bridges ther09:20
bbezake09:20
arcayneohh my god you're right. jovial shared that example when we were discussing how to properly add bridges/vlans on top of bonds... I completely overlooked the fact that the example itself isn't using bridges. holy cow, if this solves my problem I'm going to feel super dumb, but super grateful :) let me give it a shot09:25
bbezak:)09:27
*** ravlew is now known as Guest305509:31
*** Guest3055 is now known as ravlew09:40
kevkomorning \o/ ... do anyone please know how it is possible that pull not working here https://review.opendev.org/c/openstack/kolla-ansible/+/913724 ? 10:14
mnasiadkakevko: fix setup_gate.sh to build proxysql in all scenarios?10:19
kevkomnasiadka: nope 10:21
kevkomnasiadka: oh, maybe you are right ...10:22
kevkomnasiadka: firstly i thought it is about keepalived ...10:23
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Switch mariadb's loadbalancer from HAProxy to ProxySQL  https://review.opendev.org/c/openstack/kolla-ansible/+/91372410:44
opendevreviewMerged openstack/kolla-ansible master: Fix indentation in haproxy config  https://review.opendev.org/c/openstack/kolla-ansible/+/92867411:34
arcaynebbezak, got different results on this last deployment attempt, but still no joy with the vf lags. dmesg output shows `lag map active ports: 1, 2` rather than 1:2, 2:2, etc. I'm assuming I've made an error somewhere in the sriov/vf-lag playbooks that I've hooked into kayobe. gonna get some sleep and review in the morning. thanks for your help tonight :)11:52
arcayneactually, I'll leave one more question here in case someone can answer while I'm away - are there any modifications needed on the stackhpc sriov role and/or the vf-lag playbooks to accommodate systems with more than one dual-port NIC that needs to have vf-lag configured? (hopefully that makes sense.)12:02
opendevreviewMerged openstack/kolla-ansible stable/2023.1: Apply public firewalld rules immediately  https://review.opendev.org/c/openstack/kolla-ansible/+/92833112:06
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: WIP: Add support for Ubuntu Noble Numbat (24.04 LTS)  https://review.opendev.org/c/openstack/kolla-ansible/+/92558112:22
kevko SvenKieske: can u explain why I should catch the errof if /proc/pid/stat not found ? https://review.opendev.org/c/openstack/oslo.messaging/+/928034 12:52
SvenKieskekevko: I'm in a meeting, short explanation would be to always catch errors and not spill stack traces everywhere? But I'm no real oslo maintainer, so if they are fine with spewing stacktraces I guess it's "ok"?12:53
SvenKiesketbh I find this a weird question, maybe I misunderstand but I read this as "why should I do error handling?" -> well, because there are errors which need to be handled?12:54
SvenKieskenotice I don't say you can't bubble up errors, because it's a library, of course it's maybe better to not finally handle the error in oslo, if the calling software which uses oslo can do something meaningful it's fine to just report the error to the caller, but still the error should be imho handled, even if you only print a nice error message to the caller12:58
SvenKieskethat's just programming 101 for me, so maybe I really miss something?12:59
mmalchukcores, please review https://review.opendev.org/c/openstack/kolla-ansible/+/92878913:03
mmalchukmerge please to unblock CI13:04
opendevreviewMerged openstack/kolla-ansible stable/2023.2: Apply public firewalld rules immediately  https://review.opendev.org/c/openstack/kolla-ansible/+/92833013:11
mnasiadkammalchuk: can you stop adding +1 to patches post-merge?13:18
mmalchukcan13:18
mmalchukwhy You ask? 13:19
mmalchukthis needed for me that I see change13:19
mnasiadkajust add yourself to cc13:20
mnasiadkait's a bit irritating and can be seen as a way to ramp up your stats13:20
mmalchukbackports don't passed to stats if You don't know13:21
mmalchukanyway ok13:21
mmalchukjust curious13:21
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597113:29
kevkoSvenKieske: so you mean I should catch FileNotFoundError exception and what ? Raise MyFileNotFoundError or what ? :D 13:36
kevkoSvenKieske: exceptions are for raising ...not all you want to catch ... yes, some you can catch and handle ..but some you will just leave as they are and fail code ... or ? 13:37
kevkoSvenKieske: only print a nice error message to the caller << But default FileNotFoundError is very nice message i think 13:38
kevkoSvenKieske: That's why I am using with statement of course ..because the file is automatically closed when the block under the with statement is exited, even if exceptions occur within the block and  It handles exceptions more gracefully, ensuring the file is closed in case of errors. ... TLDR ..why to enclose with open(..... with try and except13:42
kevko... it is like  try : try: except : except ...  13:42
kevkoSvenKieske: different case would be if I just open file .....   because if open raise and exception ...you need to catch it and ensure everything in except block ...with statement has this built in.. ...13:43
SvenKieskeokay, I didn't really investigate if the error message is already nice13:43
kevkoSvenKieske: https://paste.openstack.org/show/b8jWD8wBWqX9vlcjwRYH/13:44
SvenKieskeacked13:46
kevkoSvenKieske: in some complicated code where the code is exuted through several modules ..files ...  code is trying to create a lock, delete a lock, somewhere connect, use some username and password ...yeah It can be very usefull to say to user ..this is bad .... so you will catch everything upper and upper ... but if code needs that file ... i don't13:46
kevkosee a reason catch NotFileFound and raise MyNotFileFound :D 13:46
kevkoSvenKieske: or something generic from oslo.exceptions import superOsloExepction ...raise ..or something ...13:46
kevkoSvenKieske: but maybe on the end they will also ask ... but it's silent there for now 13:46
kevko:( 13:47
SvenKieskeI acked the review, I guess it's fine :)13:52
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597114:01
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597114:31
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597114:57
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597116:41
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Switch mariadb's loadbalancer from HAProxy to ProxySQL  https://review.opendev.org/c/openstack/kolla-ansible/+/91372416:52
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597116:55
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597117:05
opendevreviewMagnus Lööf proposed openstack/kolla-ansible master: Enable TLS backend for designate  https://review.opendev.org/c/openstack/kolla-ansible/+/86652417:16
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix TLS settings when letsencrypt turned on  https://review.opendev.org/c/openstack/kolla-ansible/+/92597118:59

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!