Wednesday, 2024-05-22

opendevreviewMark Goddard proposed openstack/kayobe stable/2023.1: Fix Dell OS6 and Dell OS9 switch configuration  https://review.opendev.org/c/openstack/kayobe/+/91951404:12
opendevreviewMatt Crees proposed openstack/kayobe stable/2023.1: Add script to migrate to RabbitMQ quorum queues  https://review.opendev.org/c/openstack/kayobe/+/91992504:13
mnasiadkaSvenKieske[m]: upper-constraints are limiting it? https://github.com/openstack/requirements/blob/ee26dad310f68661cc5d0b25d4d2b03076f92df4/upper-constraints.txt#L23404:53
mnasiadkabut we're not using it by default in ack04:55
mnasiadkaand we're not using it in CI, so I have no clue why it's not breaking04:56
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: cinder: Add prechecks and docs for HA/clustering  https://review.opendev.org/c/openstack/kolla-ansible/+/90997405:01
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: bump up ansible-lint  https://review.opendev.org/c/openstack/kolla-ansible/+/89429505:15
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: bump up ansible-lint  https://review.opendev.org/c/openstack/kolla-ansible/+/89429505:15
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: bump up ansible-lint  https://review.opendev.org/c/openstack/kolla-ansible/+/89429505:15
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: bump up ansible-lint  https://review.opendev.org/c/openstack/kolla-ansible/+/89429505:37
mnasiadkaSvenKieske[m]: actually it does fail06:32
mnasiadkahttps://91b9af26fab1ea0d09ab-54e0403a491d4a4f41f7ae86cc027e77.ssl.cf2.rackcdn.com/909974/7/check/kolla-ansible-rocky9/62c00fd/primary/logs/ansible/deploy-prechecks06:32
kevkoSvenkieske: no still didn't create a bug report as it is weird ..I mean.. findings doesn't make a sense ...but if I revert this commit ..everything works https://github.com/openstack/oslo.concurrency/commit/9800d58cb3e7315a1941629c3dd961cfa3b63f2506:39
kevkoSvenkieske[m]: ^^ 06:39
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Make CI roles passable with ansible-lint shared profile  https://review.opendev.org/c/openstack/kolla-ansible/+/92015907:08
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Make CI roles passable with ansible-lint shared profile  https://review.opendev.org/c/openstack/kolla-ansible/+/92015907:09
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: bump up ansible-lint  https://review.opendev.org/c/openstack/kolla-ansible/+/89429507:09
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Make CI roles passable with ansible-lint shared profile  https://review.opendev.org/c/openstack/kolla-ansible/+/92015907:09
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Make CI roles passable with ansible-lint shared profile  https://review.opendev.org/c/openstack/kolla-ansible/+/92015907:10
opendevreviewRoman Krček proposed openstack/kolla-ansible master: CI: Fix faling kolla_container_facts  https://review.opendev.org/c/openstack/kolla-ansible/+/92016107:27
sylvrHello!07:39
sylvrI think there might be an error in the generation of ironic config file on the seed container07:48
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Adapt playbooks to ansible-lint 6.22  https://review.opendev.org/c/openstack/kolla-ansible/+/92016207:59
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: bump up ansible-lint  https://review.opendev.org/c/openstack/kolla-ansible/+/89429508:01
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Make CI roles passable with ansible-lint shared profile  https://review.opendev.org/c/openstack/kolla-ansible/+/92015908:01
opendevreviewMerged openstack/kayobe stable/2023.1: Fix Dell OS6 and Dell OS9 switch configuration  https://review.opendev.org/c/openstack/kayobe/+/91951408:25
r-krcekHello, I see that CI is failing. I've tried to track down the issue and it looks like it is this one: https://github.com/docker/docker-py/issues/3256 According to the conversation, it looks like the best option for now is to set limit for requests==2.31.0. However, I am not sure how to implement it. When looking at openstack/requirements, the upper-contraints.txt already mentions 2.31.0, but in CI 2.32.0 is getting installed.08:29
SvenKiesker-krcek: yes, I posted as much yesterday in the evening08:30
SvenKieskewait a second, let me fix it..08:31
SvenKieskemhm, not so trivial as I thought..08:35
opendevreviewSven Kieske proposed openstack/kolla master: CI: Fix breakage due to requests bug  https://review.opendev.org/c/openstack/kolla/+/92016508:43
SvenKieskenot 100% sure this will actually work, let's see..08:43
opendevreviewSven Kieske proposed openstack/kolla master: CI: Fix breakage due to requests bug  https://review.opendev.org/c/openstack/kolla/+/92016508:51
mnasiadkaSvenKieske: and I think first we need to fix kolla-ansible08:59
mnasiadkausing upper-constraints in a-c-k probably would help09:00
SvenKieskemnasiadka: replied09:01
SvenKieskeah okay09:01
SvenKieskeI was not sure, the pipeline I saw failed during kolla build so I figured I fix that first, but might very well be wrong09:02
SvenKieskeI actually thought we already use u-c everywhere09:03
SvenKieskecan I just include it in tox.ini like this? https://github.com/openstack/kolla/blob/master/tox.ini#L1209:05
SvenKieskeand not just in testenv I guess09:05
SvenKieskewell might be sufficient there09:06
SvenKieskemhm, that's already present in a-c-k09:06
SvenKieskeI'm confused, shouldn't this already be sufficient? currently looking at tox docs.. the requirements file has requests===2.31.0 as well09:10
SvenKieskeseems constraint resolving was changed, I hope we didn't run into some newly created behaviour there (this is some months old already) https://pip.pypa.io/en/stable/user_guide/#watch-out-for09:13
SvenKieskemhm, we only set env:TOX_CONSTRAINTS_FILE maybe that env gets reset somehow/is not propagated everywhere? see https://github.com/openstack/ansible-collection-kolla/blob/master/tox.ini#L1109:20
SvenKieskeah nvm, that's just the default value if the file is not set09:26
fricklerwell this doesn't use tox https://review.opendev.org/c/openstack/kolla/+/920165/2/tests/playbooks/pre.yml09:30
SvenKieskethese as well: https://github.com/openstack/kolla-ansible/blob/master/tests/setup_gate.sh#L9709:33
SvenKieskeshould I just add "-c https://releases.openstack.org/constraints/upper/master" there?09:34
fricklerI would rather just pin requests09:35
fricklerthe use of u-c in kolla is IMO a bad thing in general, in particular for stable branches09:35
SvenKieskeyeah, tested locally wouldn't work with u-c actually:09:36
SvenKieskeconstraints/bin/python -m pip install -c https://releases.openstack.org/constraints/upper/master pip install 'docker<7' 09:37
SvenKieskeERROR: Cannot install docker<7 because these package versions have conflicting dependencies. 09:37
SvenKieskewe have docker===7.0.0 in u-c :D09:37
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Use upper-constraints for docker sdk  https://review.opendev.org/c/openstack/kolla-ansible/+/92016909:38
mnasiadkaah, so no uc - let me rework that in a better way09:38
SvenKieskewell, I think it would - in theory - be nice to use it everywhere, but it seems that it's not that easy, unfortunately. I don't know where the docker 7 stuff comes from, for example. :(09:40
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Pin requests for docker sdk  https://review.opendev.org/c/openstack/kolla-ansible/+/92016909:40
mnasiadkaso let's try this09:40
frickleralso sad that docker-py >= 7 is still broken. maybe we need to fork it? ;)09:40
mnasiadkaif this works, we could do it in a-c-k for all people09:40
SvenKieskeah I remember/looked up why we pinned it.. well the bugfix is there, just no release, maybe we should also switch to master/main branch instead? :D09:43
mnasiadkahave a feeling docker-py is not getting any love09:48
mnasiadkawe have may, no release since december09:49
SvenKieskeyep09:52
SvenKieskeyour patch fails in setup-gate.sh https://zuul.opendev.org/t/openstack/build/3c0539dbdd4d40e0af9bc315495dedb909:53
SvenKieskeneed to pin it manually there as well I guess09:54
SvenKieskemaybe define a variable at the start and reference this everywhere throughout the script, should not be necessary but is more robust when things are moved around again, there are multiple pip installs there09:54
SvenKieskewell it's only two pip installs, so might be sufficient to just add the constraint there..09:56
fricklerhmm, only failing centos-9 though10:07
opendevreviewMichal Nasiadka proposed openstack/kayobe master: Add support for Cumulus NVUE switches  https://review.opendev.org/c/openstack/kayobe/+/91463810:07
fricklerI'm putting a hold on the debian job so we can faster iterate if more issues occur10:07
SvenKieskeI'm out for lunch10:14
mnasiadkaSvenKieske: setup_gate.sh is from kolla10:17
mnasiadkaah no10:17
mnasiadkaI'm not awake10:17
mnasiadkalet me fix this as well10:17
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Pin requests for docker sdk  https://review.opendev.org/c/openstack/kolla-ansible/+/92016910:19
opendevreviewMark Goddard proposed openstack/kayobe master: Add support for Cumulus NVUE switches  https://review.opendev.org/c/openstack/kayobe/+/91463810:24
opendevreviewOlivier Delhomme proposed openstack/kolla-ansible master: kolla-ansible now uses default inventory file  https://review.opendev.org/c/openstack/kolla-ansible/+/91399310:25
opendevreviewMichal Nasiadka proposed openstack/kayobe master: Add support for Cumulus NVUE switches  https://review.opendev.org/c/openstack/kayobe/+/91463810:30
guesswhat[m]Hi, is support for Ubuntu 22.04 planned anytime soon? Thanks11:10
mnasiadkaIt is, in D - and then most probably backported to C11:16
fricklerguesswhat[m]: are you talking about 24.04? 22.04 is supported for ages already. for the former, needs somebody to work on it, so no plan yet 11:16
guesswhat[m]frickler:  oh, yes, 24.0411:16
mnasiadkahmm, rhel 10 coming out first half 2025, fantastic11:22
opendevreviewMerged openstack/kayobe master: Fix issue removing docker volumes  https://review.opendev.org/c/openstack/kayobe/+/90959411:24
mnasiadkafrickler, SvenKieske: the pin seems to work, but I'll try to fix that for now in a-c-k so we could backport that for users11:35
opendevreviewMichal Nasiadka proposed openstack/ansible-collection-kolla master: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92017211:39
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Pin requests to <2.32 for docker sdk  https://review.opendev.org/c/openstack/kolla-ansible/+/92016911:40
SvenKieskelooks good on the surface, let's see what CI says :)11:50
SvenKieskedeploy precheck fails on rocky9 slurp upgrade :( https://zuul.opendev.org/t/openstack/build/e08a75966e2049eaa4b0f72bd6ee9d8a/log/primary/logs/ansible/deploy-prechecks11:52
SvenKieskeI'll reply on the review11:53
SvenKieskemnasiadka: might be that we need the fixes for these first on the slurp branches so slurp jobs work again? or do you just merge this through with +2 powers in those cases? (I think I saw something like this last year)11:55
opendevreviewMichal Nasiadka proposed openstack/ansible-collection-kolla stable/2023.1: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92012411:58
opendevreviewMichal Nasiadka proposed openstack/ansible-collection-kolla stable/2023.1: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92012412:04
opendevreviewMichal Nasiadka proposed openstack/ansible-collection-kolla stable/2023.2: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92012512:04
opendevreviewPierre Riteau proposed openstack/kayobe stable/2023.2: Fix issue removing docker volumes  https://review.opendev.org/c/openstack/kayobe/+/92012612:08
opendevreviewPierre Riteau proposed openstack/kayobe stable/2023.1: Fix issue removing docker volumes  https://review.opendev.org/c/openstack/kayobe/+/92012712:09
fricklerthose upgrade jobs are voting, so you can't simply override them. let's hope fixing in 2023.1 first does work, though12:36
opendevreviewMartin Hiner proposed openstack/kolla-ansible master: Add container engine migration scenario  https://review.opendev.org/c/openstack/kolla-ansible/+/83694112:45
mnasiadkamgoddard mnasiadka bbezak frickler kevko SvenKieske mmalchuk gkoper jangutter jsuazo jovial osmanlicilegi mattcrees dougszu - meeting in 512:55
mnasiadkafrickler, SvenKieske: actually https://review.opendev.org/c/openstack/ansible-collection-kolla/+/920172 passed12:57
mnasiadkaso we could merge that, and then fix setup_gate.sh in reverse order12:57
SvenKieskealright, very nice! :)12:59
fricklerno upgrade jobs on that repo, yes13:00
SvenKieskenow if only upstream docker-py could do a release sometime, other people with different problems are also already asking.13:00
mnasiadka#startmeeting kolla13:01
opendevmeetMeeting started Wed May 22 13:01:23 2024 UTC and is due to finish in 60 minutes.  The chair is mnasiadka. Information about MeetBot at http://wiki.debian.org/MeetBot.13:01
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.13:01
opendevmeetThe meeting name has been set to 'kolla'13:01
mnasiadka#topic rollcall13:01
SvenKieskeanother solution would be to move more to podman, at least in the last few months it didn't break quite as much ;)13:01
SvenKieskeo/13:01
r-krceko/13:01
mnasiadkao/13:01
mhinero/13:01
frickler\o13:01
mnasiadkawell, given the podman bug in Ubuntu 22.04 that breaks bifrost - I'm not moving anywhere yet ;)13:02
mmalchuko/13:02
SvenKieskeneed to write our own container-py I guess :D13:02
mattcreeso/13:03
mnasiadka#topic agenda13:04
mnasiadka* CI status13:04
mnasiadka* Release tasks13:04
mnasiadka* Regular stable releases (first meeting in a month)13:04
mnasiadka* Current cycle planning13:04
mnasiadka* Additional agenda (from whiteboard)13:04
mnasiadka* Open discussion13:04
mnasiadka#topic CI status13:04
mnasiadkableeding red13:04
mnasiadkarequests 2.32 all over the place13:04
opendevreviewJake Hutchinson proposed openstack/kayobe master: Add Ironic Python Agent (IPA) NTP parameter configuration  https://review.opendev.org/c/openstack/kayobe/+/89519913:05
mnasiadkabeing fixed in https://review.opendev.org/c/openstack/ansible-collection-kolla/+/920172 and some others13:05
fricklerso hopefully under control13:08
mnasiadka#topic Release tasks13:08
mnasiadkamattcrees: in absence of Will - can you share the status of Kayobe rc1?13:09
mattcreesThe Anbile bump patch is the main priority: https://review.opendev.org/c/openstack/kayobe/+/910513  but there's some prior patches to resolve the SLURP jobs that need merging first: https://review.opendev.org/c/openstack/kayobe/+/919925 https://review.opendev.org/c/openstack/kayobe/+/91387813:10
mnasiadkaok then - and the failures in the last one is requests version fail?13:11
mattcreesNo the failure in the last one is because the script needs merging in 2023.1 first13:12
mnasiadkaok, you have my +2 on the script13:13
mnasiadkacan you chase someone so it gets merged today?13:13
mnasiadkaand you can continue the work?13:13
mattcreesSure thing13:13
mnasiadkathanks13:14
mnasiadka#topic Current cycle planning13:14
mnasiadkaI tried to remove rp-1 from all patches that we needed13:14
mnasiadkaI'll try to go through some features plan and also existing patches that didn't go into Caracal13:14
mnasiadkaand will start RP+1 those that are ready for reviews13:15
opendevreviewWill Szumski proposed openstack/kayobe master: Bump up Ansible supported versions to 8.x/9.x  https://review.opendev.org/c/openstack/kayobe/+/91051313:15
mnasiadkaWill also tidy up the whiteboard so we have clear priorities for this cycle - which we could discuss next week13:15
mnasiadkaBut for now priority is getting out of requests 2.23 (or whatever the version is) hell13:16
mnasiadka#topic Additional agenda (from whiteboard)13:16
mnasiadka(MatusJenca): 13:17
mnasiadkacore reviewers, please look at my patch https://review.opendev.org/c/openstack/kolla-ansible/+/91590113:17
mnasiadkaI think that's reviewed - kevko's point is valid - when it will be resolved we can go forward13:17
SvenKieskeyes, discussed this with kevko here, seems like a good simplification13:18
SvenKieskeI'll ping Matus13:18
mnasiadka(mhiner): migration patch https://review.opendev.org/c/openstack/kolla-ansible/+/83694113:18
mnasiadkaBest effor removal of old container engine files? Sometimes there are leftover processes running there, which prevents the removal.13:18
mnasiadkaI am unable to make migration work (in Zuul) while VMs are alive, the migration has to be done with stopped VMs. This is outlined in documentation.13:18
mnasiadkaThoughts on this?13:18
mhineralso, after I fix up linter issues it's now ready for review13:19
mnasiadkaFrom my perspective - we should just support host destroy - and then deploy with podman - and have some docs that it should be a rolling process for the cloud13:19
mnasiadkaBecause I see there's more and more problems13:19
mnasiadkaDoes it make sense?13:19
mhinerI dont really understand what you mean13:20
fricklersame as distro upgrades I'd say13:20
fricklermhiner: doing a host redeploy to change the container engine instead of trying to do it in place?13:21
mnasiadkamhiner: you're trying to support migration - I'm saying we shouldn't support migration in that form - just ask the user to remove all containers and volumes from a host - and then do a re-deploy with podman13:21
mnasiadkaprobably the destroy function limited to one host should work13:22
SvenKieskewould a mixed deployment work? not really, would it? (so some hosts still with docker, new ones with podman)13:22
fricklerwhy should that not work?13:22
SvenKieskewell I think it would work in the sense you could manually destroy host $foo, redeploy it, but then you have switched container engine and can't manage any remaining docker hosts until you have finished the migration13:23
SvenKieskeat least that caveat should be documented I think, it might surprise some users? :)13:23
mhinermnasiadka: but isn't the objective to preserve all the volumes with their data, so it can be used for re-deploy?13:24
SvenKieskeotherwise looks like this is easier doable13:24
mnasiadkamhiner: It's your objective, but I don't think it's the project objective :)13:25
mnasiadkawith distribution upgrades you reinstall the OS completely and then run a deploy to get containers in place13:25
mnasiadkafor controllers you need to have HA - so that data will be replicated13:25
mnasiadkacomputes should not have any data besides nova_compute volume - but that's ephemeral storage13:26
mhinerI see, so instead of this patch we should just have some document detailing how to do the migration?13:26
kevko\o13:27
mnasiadkamhiner: yup, and some testing would be nice of course13:27
kevkosorry ..another meeting .. but now i am here ..let me re-read 13:27
SvenKieskewell it certainly would be nice if mhiner's objective would work, would be a really smooth transition for users, but it seems it's rather hard to achieve, so maybe just implement the "easier" solution first?13:27
mhinerI mean, in its current form, where you have to stop VMs beforehand, it works13:28
mhinereven our CI tests for it passed13:28
SvenKieskeso you need to stop workload VMs? I didn't follow the last patches I think, why is that necessary?13:28
SvenKieskebecause of the vm volumes?13:29
mnasiadkawell, if we have something working - just the user needs to evacuate the instances from that host - probably that's fine as well - but needs to be documented13:29
kevkopodman migration path  is the same as for quorum queue ...even if that script will land kolla ..you will be afraid to just run it :D 13:30
SvenKieskeyes, if that's really working with only the caveat of migrating VMs, just document it and merge/move on, I guess?13:30
kevkoso you will probably migrate manually ...13:30
SvenKieskekevko: :D you might have a point there13:30
mhinerSvenKieske: sometimes there are qemu processes left running in /var/lib/docker which prevents its removal13:30
SvenKieskemhiner: ah, yes I remember a note about this.13:31
kevkofirst time i saw that there is a migration to quorum queues i was happy ...and wondering how ? blue-green deployment ? or federation ? 13:31
kevkono, rabbitmq reset and restart all services :D 13:31
SvenKieskekevko: well "easy" "nuke it from orbit" solution first. more complicated solution..later..maybe :P13:32
kevkomhiner: really ? qemu processes left running var/lib/docker ? how ? 13:32
kevkoand why some ? 13:32
SvenKieskeafaik the qemu process is spawned in the host pid namespace outside dockers control, isn't it?13:33
mnasiadkaif you boot from local ephemeral storage, then probably it's obvious?13:33
kevkoit's 13:33
mnasiadkaas in qcow2 files in /var/lib/nova/instances ?13:33
mhinerkevko: I am not really sure because it only happens in Zuul - I was not able to reproduce it even when I built our version of Rocky9 with DIB13:33
SvenKieskeso of course shutting down the container might leave qemu processes around if they can't be closed. lsof -p should tell why13:33
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible stable/2023.1: CI: Pin requests to <2.32 for docker sdk  https://review.opendev.org/c/openstack/kolla-ansible/+/92013113:34
mnasiadkaanyway, let's document the limitation of the migration process and be gone with it?13:34
mnasiadkaany way to check if VMs are running and failing beforehand?13:35
kevkomnasiadka: if it is in /var/lib/nova/instances ..it's probably volume (didn't check the code) and it can be migrated ? i mean data can be migrated  ?13:35
mnasiadkakevko: it's not a volume, it's an ephemeral root disk - of course you can do live migration to copy that to other host - and that's what we should document + have a precheck before running the migration to podman13:35
chembervintHi to all,13:37
chembervintI wana discuss https://review.opendev.org/c/openstack/kolla-ansible/+/918639 - starting Antelope we have no more chance to restart Docker daemon without container. Small fix into systemd unit file will fix it13:37
mnasiadkaStop13:38
mnasiadkaWe have a meeting now13:38
mnasiadkaYou can raise that when we get to Open discussion13:38
chembervintoh, ok, thank you13:38
SvenKieskewell looking into it qemu writes the instance log to /var/lib/nova and the qemu domain monitor socket is also located in /var/lib/libvirt/13:38
mnasiadkaok, the technical discussion is fantastic - but for the sake of time - can we agree to not support migration of a host that has running instances?13:39
SvenKieskeseems fine to me :) +113:39
mnasiadkajust for the simplicity and no angry people throwing things at us on OpenInfra conferences ;-)13:39
SvenKieskeand also +1 to move the remaining discussion into the review :)13:39
mnasiadkamhiner: are you fine with that?13:39
mhinersure13:40
mnasiadkaok then13:40
mnasiadkanext one13:40
mnasiadka(r-krcek): please review:13:40
mnasiadkaon behalf of wu.chunyang: https://review.opendev.org/c/openstack/kolla-ansible/+/79749813:40
mnasiadkaThoughts on the last comments? https://review.opendev.org/c/openstack/kolla-ansible/+/59973513:40
SvenKieskeI'll review the swift role thing later this week (TM), can't really test much as we use ceph-rgw as most deployments (I guess)13:42
mnasiadkaok, so cores - please have a look in both - I think the swift role modernization is really something we should finally try to merge13:42
SvenKiesketo add to that: I think if swift gets changed it also should receive some more tests, because some stuff in swift was broken for quite some releases and nobody noticed because of the lack of tests13:43
mnasiadkafor check command - I agree the name is a bit vague, but if we do check-containers - then it clashes a bit with check-containers.yml ;-)13:43
SvenKieskeI'll make sure to also mention this in the review13:43
mnasiadkaI'll be happy to have around anybody that uses Swift and cares for it13:43
mnasiadkabut sadly I think we don't have such a person13:43
mnasiadkamaybe wuchunyang ;-)13:43
mmalchukits me)13:43
mmalchukwill review13:44
SvenKieskewell check command: don't know about naming clashes any name works for me.13:44
* mmalchuk about Swift13:44
mnasiadkaok, reviews are good13:45
kevkomnasiadka: commented ..13:45
mnasiadkaLet's move on13:45
kevkowhy we want to add check to kolla ? 13:45
r-krcekthank you :)13:45
mnasiadkacheck the comments in the patch13:45
kevkowe have monitoring documented 13:45
mnasiadkaI'm fine with anything people need ;-)13:45
mmalchuknot only review, will try to check on Xena/Yoga too))13:45
mnasiadkawell, we could have also some command that fails if any container healthcheck is bad13:45
kevkowell, i have couple of patches i need ..still waiting :) 13:46
mnasiadkaeverybody has those13:46
mnasiadkaI'm overloaded this week, might have some time next week13:46
mnasiadkabut then I have some business trip in first week of June13:46
mnasiadkaso complicated patches needing my attention might need to wait13:46
r-krcekmnasiadka: the patch covers both not running and unhealthy containers13:46
mnasiadkar-krcek: that's nice13:47
kevkoit's 10 minutes for review and merge ...i really need only two patches ...only init-core-once ..so i can work on tempest 13:47
mnasiadkaI'm not convinced I want more bash scripts to be able to run tempest ;-)13:47
kevkoit's ctrl+c and ctrl+v what is already done + 2 additional lines ..common 13:47
SvenKieskespeaking of healthchecks, this got reworked to only check actually supported HTTP checks: https://review.opendev.org/c/openstack/kolla-ansible/+/918437 I think that's a great improvement for the project13:47
SvenKieskekevko: I'm not sure I can follow, which patch are you talking about?13:48
SvenKieskeI'll add above patch to the whiteboard for next week13:48
kevkomnasiadka: yes, i can also setup dynamic users, networks etc geneeration ...but it's overkill ...13:48
kevkoSvenKieske: https://review.opendev.org/c/openstack/kolla-ansible/+/914191 << 13:49
mnasiadkaYou don't understand, we've had that discussion on the PTG - we have such high number of bash scripts - that we wanted to move to Tempest to get rid of them13:49
mnasiadkanot multiply them or add new ones13:49
mnasiadkaBut if moving to Tempest means we add more bash scripts and more dependencies to testing13:50
SvenKieskemhm I'll not be around next week, I'm on PTO from 29.5. until 3.6.13:50
mnasiadkaI don't know if that's worth the risk of breaking CI for some time and resolving those issues13:50
mnasiadkaespecially that it seems we've got more stable now13:50
mnasiadkaI propose that everybody interested does get a look on kevko's patches13:50
mnasiadkaand we discuss that in one of the future meetings13:51
SvenKieskejust move all those stuff from bash to python or ansible? I don't see anything there that's not possible to do in a basic ansible playbook, no? am I missing something?13:51
mnasiadkaLet's stop that discussion now, it's 9 minutes to closure :)13:51
SvenKieskeok13:51
mnasiadka#topic Open discussion13:52
kevkomnasiadka: okay then, so i will provide drop for tools/init-runonce bash  and rewrite to ansible ok ? 13:52
mnasiadkachembervint: now13:52
mnasiadkakevko: I think it would be good if we would have an etherpad on plan for improvements13:52
mnasiadkanot just spend time writing something, that we later argue on :)13:52
mnasiadkaand once we agree on the way forward - we can get to writing code that will easily get accepted13:53
kevkomnasiadka: https://etherpad.opendev.org/p/KollaWhiteBoard << it is here 13:53
mnasiadkaWhich line?13:53
kevko25813:53
opendevreviewMark Goddard proposed openstack/kayobe master: Add support for Cumulus NVUE switches  https://review.opendev.org/c/openstack/kayobe/+/91463813:53
mnasiadkakevko: Tempest testing instead of maintaining all those bash scripts13:53
kevkoand it was discussed i think on previous ptg (not the last)13:54
mnasiadkado you see the whole sentence?13:54
opendevreviewMark Goddard proposed openstack/kayobe master: Add support for Cumulus NVUE switches  https://review.opendev.org/c/openstack/kayobe/+/91463813:54
mmalchukcores please merge two orphans: https://review.opendev.org/q/Id6e4bbe0aab2360c4e7e5f74fff6170bcc71080b13:54
kevkomnasiadka: yep, I will process13:54
chembervintok, I'm here. so https://review.opendev.org/c/openstack/kolla-ansible/+/918639 - I propose a fix, which enable us back to configure live-restore to docker daemon and keep containers alive during docker restarts, which is important for production environments13:54
SvenKieskekevko: thanks for working on it :)13:54
chembervintand worked fine untill systemd units were introduced into Kolla13:55
mnasiadkachembervint: thanks, I'll add review priority and we'll try to timely review that13:55
chembervintthank you!13:55
mnasiadkaok then13:56
mnasiadkaanybody else?13:56
mnasiadka(we have 4 minutes)13:56
SvenKieskewell I need to process: https://bugs.launchpad.net/kolla-ansible/+bug/2065168 @chembervint first13:56
SvenKieskeand I guess all reviewers of https://review.opendev.org/c/openstack/kolla-ansible/+/918639 should read that as well13:56
SvenKieskerepeating myself from above: the healthcheck rework seems really like a good addition: https://review.opendev.org/c/openstack/kolla-ansible/+/91843713:57
SvenKieskeRP+1 on that would be nice the author is very responsive13:57
mnasiadkawell, I added RP+113:57
mnasiadkaThe patch is nice, but needs thorough testing13:58
SvenKieskeespecially for a first time contributor :) thanks13:58
SvenKieskefor sure13:58
mnasiadkaEspecially that we don't allow people to go back to previous setting easily13:58
mnasiadkamaybe we should?13:58
kevkomnasiadka: sorry ..but i need to again say something ...on line 253 is "Tempest testing instead of maintaining all those bash scripts"   ....so if you allow tempest ...you can drop almost ALL bashes ... but you don't want to approve 10 lines of bash to allow work on tempest which will replace and remove all bashes ? 13:58
SvenKieskeokay, that might be a good addition13:58
chembervintit's not my first time ... :) but thank you! :)13:58
mnasiadkakevko: I know you can do better and you can do Ansible instead of those bashes - and your patches don't include dropping of those bashes13:58
SvenKieskechembervint: I was talking about https://review.opendev.org/c/openstack/kolla-ansible/+/918437 I think that's not you, is it? :)13:59
kevkomnasiadka: thanks :D 13:59
chembervintoh, sorry :) 13:59
mnasiadkaAnd I would rather see tenths of rechecks of the Tempest runs to make sure everything works like we want13:59
SvenKieskechembervint: I'll re-review your patch as well13:59
mnasiadkaBecause if it fails - we're going to chase and blame kevko :)13:59
SvenKieskechembervint: no problem :)13:59
kevkokolla -> kevko -> tempest cores14:00
kevko:) 14:00
SvenKieskeshould we add rally to the list :D14:00
SvenKieskeok, it's 16:00 here.14:00
mnasiadkaok14:01
mnasiadkathanks for coming!14:01
mnasiadkasee you next week14:01
mnasiadka#endmeeting14:01
opendevmeetMeeting ended Wed May 22 14:01:34 2024 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:01
opendevmeetMinutes:        https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-05-22-13.01.html14:01
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-05-22-13.01.txt14:01
opendevmeetLog:            https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-05-22-13.01.log.html14:01
mmalchukmnasiadka thanks14:02
SvenKieskemhm I really need to reread this whole docker restart thing, thanks for all the comment on the launchpad bugs14:02
SvenKieskethanks mnasiadka!14:02
jovial[m]Any ideas why doesn't CI seem to be re-triggering on: https://review.opendev.org/c/openstack/kayobe/+/910513? 14:04
mmalchukSvenKieske we had a short discussion outside the launchpad, not added any conclusion there14:04
mmalchukso feel free to recheck from the scratch14:04
kevkosorry, need to run ... but will be around if anything 14:05
* mmalchuk too14:09
mmalchukcu14:09
opendevreviewMark Goddard proposed openstack/kayobe master: Add support for Cumulus NVUE switches  https://review.opendev.org/c/openstack/kayobe/+/91463814:09
opendevreviewMerged openstack/ansible-collection-kolla master: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92017214:25
opendevreviewMerged openstack/ansible-collection-kolla stable/2023.1: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92012414:25
opendevreviewMichal Nasiadka proposed openstack/ansible-collection-kolla stable/2024.1: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92013214:39
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible stable/2023.1: CI: Pin requests to <2.32 for docker sdk  https://review.opendev.org/c/openstack/kolla-ansible/+/92013114:55
opendevreviewMerged openstack/ansible-collection-kolla stable/2023.2: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92012514:58
opendevreviewKevin Tindall proposed openstack/kolla-ansible master: Add TLS proxy for novncproxy  https://review.opendev.org/c/openstack/kolla-ansible/+/91114115:00
opendevreviewMatt Crees proposed openstack/kolla stable/2023.1: Build RabbitMQ 3.11, 3.12 and 3.13 in 2023.1  https://review.opendev.org/c/openstack/kolla/+/91897416:04
-opendevstatus- NOTICE: There will be a short Gerrit outage while we update to the latest 3.8 release in preparation for next weeks 3.9 upgrade.17:01
mnasiadkafrickler: we also need https://review.opendev.org/c/openstack/kolla-ansible/+/920131 first, and then I’ll do cherry picks forward17:40
opendevreviewMichal Nasiadka proposed openstack/kayobe master: Bump up Ansible supported versions to 8.x/9.x  https://review.opendev.org/c/openstack/kayobe/+/91051317:56
kevkomnasiadka: stil here ? 18:09
fricklermnasiadka: you need to remember that backport-candidate!=0 is a required vote now. though I wonder how that makes sense for reviews that are backports already. maybe we want to restrict this to the master branch? cc SvenKieske 18:25
mnasiadkaYeah, restricting that to master makes sense18:26
mnasiadkakevko: sort of18:26
opendevreviewMerged openstack/ansible-collection-kolla stable/2024.1: docker_sdk: Pin requests to <2.32 due to docker-py incompatibility  https://review.opendev.org/c/openstack/ansible-collection-kolla/+/92013218:30
kevkomnasiadka: regarding bash removal and replace by ansible ... It is very unfortunate that the openstack.cloud Galaxy collection does not correspond at all with the upper-constraints... but we take that into account in CI ... for now i just rewrited minimal version in a galaxy code :D ...18:32
kevkoi mean openstacksdk18:33
kevkowill see ..i will send something :) 18:34

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!