*** jhorstmann is now known as Guest3206 | 00:27 | |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 00:36 |
---|---|---|
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 00:37 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 01:08 |
*** jhorstmann is now known as Guest3210 | 01:17 | |
opendevreview | Martin Hiner proposed openstack/kolla-ansible master: Add container engine migration scenario https://review.opendev.org/c/openstack/kolla-ansible/+/836941 | 08:39 |
kevko | frickler: do you have vote rights for requirements ? i mean +2 and +w ? | 10:54 |
*** parallax is now known as Guest3296 | 11:25 | |
opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add Redfish rules to Ironic and Bifrost introspection https://review.opendev.org/c/openstack/kayobe/+/902772 | 11:31 |
opendevreview | Will Szumski proposed openstack/kayobe master: Bump KA Ansible versions to match new defaults https://review.opendev.org/c/openstack/kayobe/+/913571 | 11:57 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Refactor external ceph https://review.opendev.org/c/openstack/kolla-ansible/+/907166 | 11:57 |
opendevreview | Will Szumski proposed openstack/kayobe master: Bump KA Ansible versions to match new defaults https://review.opendev.org/c/openstack/kayobe/+/913571 | 12:16 |
frickler | kevko: I do as a member of the infra-root group, so not directly member of the team, more of an auxillary role | 12:26 |
opendevreview | Michal Nasiadka proposed openstack/kayobe master: Add dynamic-login to default ipa elements https://review.opendev.org/c/openstack/kayobe/+/913760 | 12:29 |
opendevreview | Michal Nasiadka proposed openstack/kayobe master: Add dynamic-login to default ipa elements https://review.opendev.org/c/openstack/kayobe/+/913760 | 12:37 |
fungi | kevko: yeah, mostly the infra inclusion in requirements-core is so that we can fill in to un-block testing in emergencies | 12:44 |
Fl1nt | Hi folks! | 13:18 |
Fl1nt | I've validated that my yesterday bug on ZED isn't just CentOS related, I've solved it too, so I'll create the bugtrack but also push the bugfix in the meantime. | 13:26 |
Fl1nt | it happens on full fledge Ubuntu 22.04.4 LTS too | 13:26 |
Fl1nt | full kolla vanilla, no corporation mess. | 13:27 |
supamatt | what bug Fl1nt ? | 13:47 |
opendevreview | Gaël THEROND proposed openstack/kolla stable/zed: Fix bug prohibiting images plugins archive creation. https://review.opendev.org/c/openstack/kolla/+/913786 | 13:47 |
Fl1nt | This one supamatt | 13:47 |
opendevreview | Gaël THEROND proposed openstack/kolla stable/zed: Fix bug prohibiting images build: * Plugins archive can't be build correctly, missing key. https://review.opendev.org/c/openstack/kolla/+/913786 | 13:51 |
SvenKieske | Fl1nt: mhm weird, does this bug only affect zed? | 13:54 |
Fl1nt | Only tested zed and yoga, yoga isn't but I can test 2023.1 if needed. | 13:55 |
mmalchuk | Zed's dead... zeds dead baby... (c) Pulp Fiction | 13:55 |
Fl1nt | :D | 13:55 |
Fl1nt | got this ref mmalchuk | 13:55 |
Fl1nt | :D | 13:55 |
SvenKieske | that would be nice if you could test this. if this affects newer releases as well I will try to test master myself and reapply the fix to master first, as is usual | 13:56 |
Fl1nt | SvenKieske, test ongoing | 13:56 |
SvenKieske | at least the code is the same in this function on master, don't know if anything else changed with regards to the source processing though, so likely affects master I guess (just by looking at the code) | 13:59 |
Fl1nt | I think its related to the way images call for plugins enabled status. | 13:59 |
mnasiadka | mgoddard mnasiadka bbezak frickler kevko SvenKieske mmalchuk gkoper jangutter jsuazo jovial osmanlicilegi mattcrees dougszu - meeting NOW | 14:00 |
mnasiadka | #startmeeting kolla | 14:00 |
opendevmeet | Meeting started Wed Mar 20 14:00:16 2024 UTC and is due to finish in 60 minutes. The chair is mnasiadka. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
opendevmeet | The meeting name has been set to 'kolla' | 14:00 |
mnasiadka | #topic rollcall | 14:00 |
mmalchuk | o/ | 14:00 |
SvenKieske | o/ | 14:00 |
mattcrees | \o | 14:00 |
mhiner | o/ | 14:01 |
SvenKieske | aravindh: it would be very welcome if you can rewrite it in python, I don't know about the cli framework you mentioned though. | 14:01 |
SvenKieske | ah they are gone | 14:01 |
Fl1nt | o/ | 14:02 |
frickler | \o | 14:02 |
jovial | o/ | 14:03 |
mnasiadka | https://www.irccloud.com/pastebin/wjoS0J7a/ | 14:03 |
mnasiadka | oops | 14:03 |
mnasiadka | #topic agenda | 14:03 |
mnasiadka | * CI status | 14:03 |
mnasiadka | * Release tasks | 14:03 |
mnasiadka | * Current cycle planning | 14:03 |
mnasiadka | * Additional agenda (from whiteboard) | 14:03 |
mnasiadka | * Open discussion | 14:03 |
mnasiadka | #topic CI status | 14:03 |
mnasiadka | I think it's mainly green, especially after fixing mariadb timeouts | 14:04 |
mnasiadka | jovial: how's kayobe CI fixing? | 14:04 |
jovial | I've submitted a change to Matt's patch. Just awaiting CI. | 14:05 |
mnasiadka | great | 14:06 |
mnasiadka | #topic Release tasks | 14:06 |
mnasiadka | It's R-6 - client libraries release time | 14:06 |
mnasiadka | Any volunteer to switch Kolla to use Caracal UCA? | 14:07 |
mnasiadka | RDO as well for CentOS/Rocky builds | 14:07 |
SvenKieske | I guess I can make that again | 14:09 |
mnasiadka | Fantastic | 14:09 |
SvenKieske | #link https://review.opendev.org/c/openstack/kolla/+/891018 | 14:09 |
SvenKieske | just for my personal reference | 14:09 |
mmalchuk | mnasiadka I can | 14:09 |
mnasiadka | great | 14:09 |
mnasiadka | two volunteers | 14:09 |
SvenKieske | mmalchuk: can you do RDO and I do UCA? | 14:10 |
mmalchuk | lets swap | 14:10 |
mmalchuk | I've already made change | 14:10 |
SvenKieske | okay, have to look up the RDO stuff again :D | 14:10 |
SvenKieske | ah alright, that makes sense then | 14:10 |
SvenKieske | no need for duplicate work | 14:10 |
Fl1nt | what does UCA stadn for? | 14:10 |
mnasiadka | Ubuntu Cloud Archive | 14:11 |
Fl1nt | ah! Ok! thx | 14:11 |
mnasiadka | #topic Current cycle planning | 14:11 |
mnasiadka | Let's go through dashboards | 14:12 |
mnasiadka | #link https://tiny.cc/kolla-dashboard | 14:12 |
opendevreview | Maksim Malchuk proposed openstack/kolla master: [release] Use UCA Caracal https://review.opendev.org/c/openstack/kolla/+/913788 | 14:12 |
mnasiadka | two exit code related patches and proxysql bump awaiting reviews | 14:12 |
mnasiadka | I just noticed comments on https://review.opendev.org/c/openstack/kolla/+/905116/2 (thanks frickler ) | 14:13 |
mnasiadka | I'll update today | 14:13 |
mnasiadka | #link https://tiny.cc/kolla-ansible-dashboard | 14:14 |
mmalchuk | mnasiadka UCA: https://review.opendev.org/c/openstack/kolla/+/913788 | 14:14 |
mnasiadka | Kolla-Ansible dashboard - seems some patches also awaiting reviews | 14:14 |
mnasiadka | mmalchuk: thanks | 14:15 |
mnasiadka | Ok, anybody has any feature/patch that he needs reviews on - or just wants to talk about them? | 14:15 |
SvenKieske | well it would be nice if we have a clear plan with regards to bash and if people would like to have more bash linting (shellcheck) | 14:15 |
SvenKieske | so if we abandon bash (big | 14:16 |
mnasiadka | So, my first problem with shellcheck is that it seems the most widely adopted tool in openstack land is bashate | 14:16 |
SvenKieske | sorry hint enter to fast: +1 from me), I would not put much time in refactoring our bash | 14:16 |
mnasiadka | second of all, I prefer to reduce our bashisms instead of promoting them :) | 14:17 |
mhiner | mnasiadka: yes, what about this small podman fix: https://review.opendev.org/c/openstack/kolla-ansible/+/912521 | 14:17 |
mnasiadka | any other comments? | 14:17 |
SvenKieske | I can agree to the second statement, I don't understand the first tbh. that's like saying: we already do pep8 linting on python, no need for any flake8 rules? they really don't conflict with each other | 14:17 |
SvenKieske | and honstly bashate doesn't really do much, you can count the checks it does on 2 hands and they are almost all only about optics, not about actual errors. | 14:18 |
bbezak | o/ | 14:18 |
opendevreview | Maksim Malchuk proposed openstack/kolla master: [release] Change RDO's DELOREAN_DEPS repo to Antelope https://review.opendev.org/c/openstack/kolla/+/913790 | 14:18 |
SvenKieske | but agreed, no new bash scripts then? | 14:18 |
mmalchuk | mnasiadka RDO: https://review.opendev.org/c/openstack/kolla/+/913790 | 14:19 |
jovial | Just on the podman support in kayobe. Do you think it is OK to land whilst podman is broken on ubuntu (https://review.opendev.org/c/openstack/ansible-collection-kolla/+/911422)? Otherwise how do I proceed? | 14:19 |
mnasiadka | SvenKieske: from my perspective it would be good to have a plan around what we can do to reduce number of bash scripts on the deployment side - and also have a plan for the CI side (if needed) | 14:19 |
mnasiadka | jovial: I think we should have that problem documented for users, that should be fine - and since next release we should be supporting 24.04 - it might get fixed there | 14:20 |
mnasiadka | maybe we should also have a precheck in kayobe/kolla-ansible warning users about possible problems? | 14:20 |
SvenKieske | can we maybe finish one topic before we start the next one? | 14:21 |
SvenKieske | so what about new bash scripts, e.g. https://review.opendev.org/c/openstack/kolla-ansible/+/836941/43/tests/test-container-engine-migration.sh ? | 14:21 |
Fl1nt | I'm a strong support of get ride of bash as much as possible. | 14:21 |
SvenKieske | just a random example | 14:21 |
SvenKieske | imho at first we should document in our dev guide that people please at least not add new bash scripts, bugfixes in existing scripts are fine I guess. | 14:22 |
SvenKieske | I guess I will write a docs patch for that and see if that gets traction | 14:22 |
jovial | What is the replacement for bash? | 14:22 |
Fl1nt | python? | 14:23 |
mnasiadka | there is no replacement for now | 14:23 |
mnasiadka | once we have one, and patches like this one can reuse a ,,framework'' | 14:23 |
mnasiadka | then I'm fine with saying no bash, or whatever - adapt to current ,,framework'' | 14:23 |
mnasiadka | but now nobody has made any plan if we should continue with CI based on bash scripts | 14:24 |
mnasiadka | and it feels like PTG topic | 14:25 |
mnasiadka | do we all agree here - or is there some other proposal? | 14:25 |
SvenKieske | so I'm back at square one: if we don't have a plan to replace bash (and I don't really get the distinction between code for testing in CI and deployment code, both are equally important to me) we need to somehow ensure bash code quality, no? | 14:25 |
jovial | There seems to be a lot of hate for bash. IMO stringing a load of shell commands together in bash script is a lot more readable than the python equivalent. | 14:25 |
mnasiadka | For me there are two types of bash usage in Kolla-Ansible | 14:25 |
Fl1nt | mnasiadka, CI = zuul so python/ansible/yaml as much as possible meaning almost everywhere. | 14:25 |
SvenKieske | I already added it to the PTG topics and I fear I do disagree on some fundamentals, but maybe let's discuss this at PTG then | 14:25 |
mnasiadka | the CI scripts - I'm fine with them being as they are today | 14:25 |
mnasiadka | But I'm also fine with whatever we decide | 14:26 |
Fl1nt | jovial, bash isn't portable neither it is readable imho | 14:26 |
kevko | \o | 14:26 |
mnasiadka | the bash that we use in some places that gets executed on normal deployment - it might be better to replace that with Ansible/Python - on a case by case basis | 14:26 |
jovial | bash runs on most systems ;-) | 14:26 |
mnasiadka | and that bash probably could do some linting | 14:26 |
mnasiadka | but we already have bashate | 14:26 |
SvenKieske | jovial: I don't hate bash - if that came across like that - I just wrote enough of it to know that it's very very hard to write bash without serious bugs without a linter like shellcheck | 14:27 |
mnasiadka | and I'm not going to tell it's bad or something, it might be limited | 14:27 |
mnasiadka | but we also don't lint a lot of other things | 14:27 |
Fl1nt | jovial, not really, there are so many exemple against that; Like the tests conditions for instance. | 14:27 |
SvenKieske | agreed, let's move the discussion to PTG then because I don't think we can agree on something actionable right now. I'll think about it for PTG to maybe come up with some proposal. | 14:28 |
mnasiadka | yeah, flame wars on PTG | 14:28 |
jovial | Fl1nt, Do you mean running a bash script in alternative shell? | 14:28 |
mmalchuk | I've missed something... do we have any time slots for PTG with Google Calendar links? | 14:28 |
SvenKieske | and please also bring your proposals :) | 14:28 |
jovial | Sounds like an interesting session :) | 14:29 |
Fl1nt | jovial, shell/bash/ksh/whatever bash isn't made to do code, it's made for commands chaining. | 14:29 |
Fl1nt | it's a useful tool sure | 14:29 |
Fl1nt | on daily ops looping :D | 14:30 |
mnasiadka | mmalchuk: https://etherpad.opendev.org/p/kolla-dalmatian-ptg - line 44 | 14:30 |
Fl1nt | but for dev, it's horrible | 14:30 |
mnasiadka | and https://ptg.opendev.org/ptg.html | 14:30 |
mmalchuk | mnasiadka last PTG we use some website with planing where I can add google calendar events. do we have it now? | 14:31 |
SvenKieske | I wanted to add to the podman breakage: might it be worth to file a bug against the actual podman package in ubuntu? all I have seen so far is a bug against the linux kernel (which is also technically true, but there is a workaround patch in upstream podman) | 14:32 |
mnasiadka | mmalchuk: google calendar events? maybe it was on the doodle poll, but the timeslots are the same as usual | 14:32 |
mmalchuk | mnasiadka yep. doodle. do we have it now? | 14:33 |
mnasiadka | no, we don't | 14:33 |
mmalchuk | :( | 14:33 |
mnasiadka | doodle was only for a poll when to meet | 14:33 |
mnasiadka | you can ask on #openinfra-events if there's support for .ics file generation via the ptg website ;-) | 14:34 |
mnasiadka | (and maybe even contribute) | 14:34 |
mmalchuk | nevermind. will create events myself | 14:34 |
mnasiadka | jovial: it might make sense to file the bug as SvenKieske says | 14:34 |
mnasiadka | let's go forward | 14:34 |
mnasiadka | #topic Additional agenda (from whiteboard) | 14:34 |
mnasiadka | (SvenKieske): Skyline patches need core reviewers, look finished to me: https://review.opendev.org/c/openstack/kolla-ansible/+/910514 , basically all currently owned by Uwe: https://review.opendev.org/q/owner:uwe.jaeger@valiton.com | 14:35 |
SvenKieske | yeah, Uwe is pretty active actually and responds rather fast if you have feedback for improvements :) | 14:36 |
SvenKieske | but what I looked at myself is in good shape now imho | 14:36 |
SvenKieske | I noticed some stuff just got merged yesterday, thanks | 14:37 |
SvenKieske | and there's also some activity in the other stuff afaik, I need to re-review those myself, thanks so far. | 14:39 |
mnasiadka | (SvenKieske): please also review keystone bugfix: https://review.opendev.org/c/openstack/kolla-ansible/+/912452 | 14:39 |
mnasiadka | CI is failing | 14:39 |
SvenKieske | yeah about that one, it's on my todo for today to investigate the upgrade job that fails with this in CI | 14:40 |
mnasiadka | Could not find versioned identity endpoints when attempting to authenticate. Please check that your auth_url is correct. Service Unavailable (HTTP 503)\n | 14:40 |
SvenKieske | noticed that myself but was busy, I thought I would have fixed CI until the meeting, sorry. | 14:40 |
jovial | mnasiadka, For the ubuntu packaging issue. There is this one: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2052961, but now much activity. Adding a known issue to the release notes sounds like a good path forward for now. | 14:41 |
SvenKieske | this seems clearly related to the patch, maybe the task is called at the wrong place (to early)? not sure though | 14:41 |
SvenKieske | jovial: this is a bug against the linux kernel source, afaik. it would be better to report this against podman in ubuntu instead, if you want the fix to be backported, that is. | 14:42 |
mmalchuk | strange that all upgrade jobs are failed | 14:42 |
mnasiadka | ok then, next one | 14:42 |
mnasiadka | (ihalomi/mhiner): Patchset that bumped version of docker ( https://review.opendev.org/c/openstack/ansible-collection-kolla/+/910751 )didn't work because we install package python3-docker during tests using package manager and not pip. Debian currently doesn't support release of docker-py higher than 5.0.3, would it be possible to change installation using pip for all cases? Or maybe adding package package by ourselves to osbpo | 14:42 |
mnasiadka | repository as is it done in podman role | 14:42 |
mhiner | tldr: if venv is not used, the docker python package is installed through system package manager and required minimal version 6.0.0 is not available there | 14:42 |
SvenKieske | mmalchuk: yes, strange | 14:42 |
mnasiadka | mhiner: where do we install python3-docker? | 14:42 |
mnasiadka | from rpm/deb? | 14:43 |
mhiner | yes, but only if virtual environment is not used | 14:43 |
mnasiadka | and only on debian | 14:43 |
jovial | SvenKieske, That makes sense. Totally missed that one was against the kernel :facepalm: | 14:44 |
mnasiadka | kevko: how do we get python3-docker bumped in Debian? | 14:44 |
SvenKieske | mhmm, but didn't we switch to use venvs everywhere? | 14:44 |
kevko | mnasiadka: i've built and upload :D | 14:44 |
mnasiadka | mhiner: solves your problem? :D | 14:44 |
SvenKieske | jovial: no problem :) but I guess you won't get an answer there with regards to backports of podman patches ;) | 14:44 |
mnasiadka | if we don't use venvs in all CI - we should alter the CI I guess | 14:44 |
SvenKieske | +1 imho | 14:45 |
kevko | I am a maintainer https://packages.debian.org/sid/python3-podman << it's sid ...but I've asked zigo to add to osbpo deb repo | 14:45 |
SvenKieske | or was that on purpose? (what would that be? local mirror instead of pypi?) | 14:45 |
mhiner | mnasiadka: I guess, since I'm only a middle man in this because Ivan can't attend these meetings :) | 14:45 |
mnasiadka | mhiner: ok, makes sense | 14:45 |
mnasiadka | mhiner: can you check where in CI python3-docker/podman gets installed and we rework this CI to use venvs? | 14:45 |
kevko | oh, sorry python3-docker ... that package i asked also zigo to backport from sid | 14:45 |
kevko | i don't think we should install packages via pip in operating system | 14:46 |
kevko | also new ubuntu and debian distros don't allow installation via pip | 14:47 |
SvenKieske | no we didn't talk about operating system but to use a venv instead? at least to me that implies to not overwrite system-packages? | 14:47 |
SvenKieske | and the issue seems to be that we don't use venv everywhere so system package is used and version there is wrong. and the solution should be to just use venv everywhere | 14:47 |
mnasiadka | anyway, I hope mhiner/ihalomi can find the place and hopefully improve that | 14:48 |
kevko | so you will set ansible_python_interpreter to something local env ? | 14:48 |
SvenKieske | kevko: afaik a proper venv everywhere would sidestep this :) | 14:48 |
Fl1nt | I confirm, it does, that's the way we build everything, container > venvs > pip > kolla > whatever | 14:49 |
kevko | my point is that there are minimum python packages installed in system ... it would be better to handle it in system | 14:49 |
kevko | what i know ..it's only python3-docker and python3-podman | 14:49 |
kevko | what else do we need to run ansible modules against the host ? | 14:49 |
SvenKieske | sysctl stuff springs to mind, there's a current patchset floating around splitting it into it's own role | 14:50 |
Fl1nt | kevko, that's is just for kolla scope, not if you step back then you've got the same for ceph-ansible and many others that will necessarily collide with kolla at some point. | 14:51 |
SvenKieske | I find our distinction with host/container also rather fuzzy, because we tend to mount lot's of host stuff into the containers and stuff bleeds through everything (pid namespaces, net namespaces, user namespaces..) | 14:51 |
kevko | Fl1nt: i don't think | 14:53 |
Fl1nt | kevko, it is, we do HPC and it does collide | 14:53 |
kevko | Fl1nt: with system-wide python packages ? | 14:54 |
mnasiadka | we basically use venv everytime, so it makes sense to use that in CI - especially that we only use python3-docker/podman only on Debian in CI | 14:55 |
Fl1nt | kevko, yes | 14:55 |
opendevreview | Mark Goddard proposed openstack/kayobe master: CI: Test custom routes & rules on EL9 https://review.opendev.org/c/openstack/kayobe/+/899941 | 14:55 |
mnasiadka | we install from pip on other distros even if there is no venv | 14:55 |
SvenKieske | mnasiadka: ack +1; imho we should do in CI what we do in actual deployments (where possible) | 14:55 |
mnasiadka | I think I had some patches about that, will try to dig them out later | 14:55 |
kevko | Fl1nt: containerize whatever it is ? | 14:55 |
SvenKieske | that doesn't mean that system packages can't be updated separately :) | 14:55 |
mnasiadka | Sorry, but we need to move to the last topic ;) | 14:56 |
mnasiadka | #topic Open discussion | 14:56 |
Fl1nt | kevko, wdym? | 14:56 |
mnasiadka | Any other topics? | 14:56 |
SvenKieske | just wanted to say thank you all for letting me learn a lot in the past year (it's almost a year since I work almost full time on this) | 14:56 |
mnasiadka | a year, nice - we all learn every day ;) | 14:57 |
mmalchuk | nice work ;) | 14:57 |
SvenKieske | yeah, the learning never stops :) | 14:58 |
frickler | also just a couple of hours left for TC election, if you waited to make your vote, do it now | 14:58 |
SvenKieske | I actually just did that today, because I forgot it yesterday :D | 14:59 |
mmalchuk | frickler I didn't receive email with personal link... maybe google spam filter | 14:59 |
SvenKieske | mmalchuk: it doesn't come from opendev domain, but from a university, kevko had also trouble finding it | 14:59 |
mmalchuk | I know. so spam in progress) | 14:59 |
frickler | mmalchuk: did you actually register? you may want to check the instructions https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/PXG7D3AUTFDOITTTLMJJHPUTXEHNMCMB/ | 15:00 |
mmalchuk | thats all, folks I need to go. mnasiadka thanks for chairing | 15:00 |
SvenKieske | mmalchuk: you might want to check for a mail sent 7. of march 2024 from "Condorcet Internet Voting Service (on behalf of Ian Y. Choi) <civs@cornell.edu>" | 15:00 |
mnasiadka | ok then, it's time to finish the meeting | 15:00 |
mnasiadka | thanks for attending! | 15:00 |
mnasiadka | #endmeeting | 15:00 |
opendevmeet | Meeting ended Wed Mar 20 15:00:58 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-03-20-14.00.html | 15:00 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-03-20-14.00.txt | 15:00 |
opendevmeet | Log: https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-03-20-14.00.log.html | 15:00 |
SvenKieske | thanks all | 15:01 |
Fl1nt | SvenKieske, tested the build, broke on 2023.1 too, so stakes are high it should broke on master too | 15:01 |
Fl1nt | SvenKieske, the patch have the advantage to fix the issue and indeed shield yourself for the upper issue if there is one :D | 15:01 |
SvenKieske | Fl1nt: yeah I thought so. will try to replicate locally. could you rebase your patch on master and change the MR to master as well? | 15:02 |
Fl1nt | sure | 15:02 |
SvenKieske | thanks, much appreciated. | 15:02 |
Fl1nt | mmalchuk, what do you mean by "Header is absent" ? | 15:04 |
opendevreview | Gaël THEROND proposed openstack/kolla master: Fix bug prohibiting images build. https://review.opendev.org/c/openstack/kolla/+/913795 | 15:19 |
Fl1nt | SvenKieske, done | 15:20 |
Fl1nt | mmalchuk, tried to fix what you mean by "header" not sure if it's what you meant :D | 15:21 |
opendevreview | Martin Hiner proposed openstack/kolla-ansible master: Fix incorrect condition in kolla_container_facts https://review.opendev.org/c/openstack/kolla-ansible/+/912521 | 15:21 |
SvenKieske | Fl1nt: thanks, will test locally, but looks good | 15:23 |
Fl1nt | perfect! | 15:25 |
Fl1nt | SvenKieske, I could indeed even patch the logger message as it will probably not log the source name if the enabled key isn't present as the whole dict is indeed empty when happening. | 15:31 |
opendevreview | Martin Hiner proposed openstack/kolla-ansible master: WIP: Add action for getting container names list https://review.opendev.org/c/openstack/kolla-ansible/+/905837 | 15:32 |
SvenKieske | anybody around for some quick +2 docs only changes? https://review.opendev.org/c/openstack/kolla-ansible/+/913426 :) | 15:46 |
kevko | SvenKieske: done | 15:47 |
SvenKieske | kevko: ty | 15:48 |
mnasiadka | SvenKieske: try moving adding the service role after flush handlers ;-) | 15:49 |
SvenKieske | mnasiadka: very good idea! that sounds about right! | 15:50 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.2: fix creation of keystone service role on upgrade https://review.opendev.org/c/openstack/kolla-ansible/+/912452 | 15:52 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.2: fix confusing jammy upgrade docs https://review.opendev.org/c/openstack/kolla-ansible/+/913520 | 16:01 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/2023.1: fix confusing jammy upgrade docs https://review.opendev.org/c/openstack/kolla-ansible/+/913801 | 16:01 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/zed: fix confusing jammy upgrade docs https://review.opendev.org/c/openstack/kolla-ansible/+/913802 | 16:01 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible stable/zed: fix confusing jammy upgrade docs https://review.opendev.org/c/openstack/kolla-ansible/+/913802 | 16:04 |
Fl1nt | guys, how do you push some changes on an already existing review you're not the owner of once you've fetch the topic? | 16:20 |
opendevreview | Merged openstack/kolla-ansible master: fix confusing jammy upgrade docs https://review.opendev.org/c/openstack/kolla-ansible/+/913426 | 16:24 |
opendevreview | Will Szumski proposed openstack/kayobe master: Bump KA Ansible versions to match new defaults https://review.opendev.org/c/openstack/kayobe/+/913571 | 16:44 |
SvenKieske | Fl1nt: just like you would do on your own changes? git add foo; git commit --amend; {optional tox -e $yourtest}; git review; In general it's nice to ask/coordinate with the original change owner, if they are not unrepsonsive in general. | 16:47 |
SvenKieske | the UCA change failed in test-core-openstack https://review.opendev.org/c/openstack/kolla/+/913788 | 16:57 |
SvenKieske | I wrote up what I _think_ might have gone wrong, but I'm not 100% sure. | 16:57 |
jovial | I have an issue with slurp upgrade from 2023.1 to master: {"action": "community.rabbitmq.rabbitmq_feature_flag", "ansible_loop_var": "item", "changed": false, "item": "restart_streams", "msg": "restart_streams feature flag is not available"}. I think restart_streams only came in 3.12, but we have 3.11 on 2023.1. | 16:58 |
jovial | Is that a known issue or am I doing something stupid? | 16:59 |
SvenKieske | jovial: not known to me, might be we must bump rmq in 2023.1? afaik we talked about this last ptg or planned to do it next ptg? we certainly scratched the surface of which rmq version to support where.. | 17:00 |
SvenKieske | jovial: at least it's not on the dalmatian PTG etherpad just yet, I just checked. | 17:01 |
jovial | restart_streams seems to have only been added recently: https://github.com/openstack/kolla-ansible/commit/b2a187e84e156afc76edc54cd4b15bd811694206 | 17:02 |
SvenKieske | I'd suggest to file a bug with this and investigate if we can bump rmq release for 2023.1 we have afaik done so in the past as well to support these upgrades. mnasiadka knows probably better though | 17:02 |
jovial | I guess I'm wondering why the kolla slurp upgrade job didn't catch that :D | 17:02 |
SvenKieske | https://review.opendev.org/c/openstack/kolla-ansible/+/911094?tab=change-view-tab-header-zuul-results-summary | 17:03 |
SvenKieske | well at least one slurp upgrade job timed out | 17:03 |
SvenKieske | but I guess each one should've catched it? good question! | 17:03 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible master: Add ovn-exporter https://review.opendev.org/c/openstack/kolla-ansible/+/855498 | 17:32 |
jovial | SvenKieske, I think the slurp upgrade job does a reconfigure on rabbitmq here: https://github.com/openstack/kolla-ansible/blob/master/tests/upgrade.sh#L40. That deploys the new containers and the the upgrade in line 44 succeeds. I didn't see anything int he upgrade procedure suggesting that, so will file a bug. | 17:54 |
jovial | That seems a bit weird to me as you are essentially upgrading with reconfigure :-/ | 17:55 |
jovial | https://bugs.launchpad.net/kolla-ansible/+bug/2058512 | 18:04 |
SvenKieske | yeah, would be imho nicer to have dedicated command verbs for upgrade instead of overloading reconfigure, but I guess there was a reason to do it this way :) | 18:06 |
SvenKieske | thanks for filing the bug | 18:06 |
opendevreview | Will Szumski proposed openstack/kayobe master: CI: Make SLURP jobs non-voting https://review.opendev.org/c/openstack/kayobe/+/913825 | 18:11 |
SvenKieske | mnasiadka: btw there is a patch for the rmq ipv6 only issue and we are asked to test it: https://github.com/rabbitmq/rabbitmq-server/issues/10728; has anybody here experience compiling rmq? | 18:37 |
opendevreview | Sven Kieske proposed openstack/kolla-ansible master: DNM test enable_ovn in ovn scenario https://review.opendev.org/c/openstack/kolla-ansible/+/913838 | 18:53 |
opendevreview | Maksim Malchuk proposed openstack/kolla master: [release] Use UCA Caracal https://review.opendev.org/c/openstack/kolla/+/913788 | 20:37 |
opendevreview | Maksim Malchuk proposed openstack/kolla master: [release] Change RDO's DELOREAN_DEPS repo to Antelope https://review.opendev.org/c/openstack/kolla/+/913790 | 20:37 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 22:12 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 22:12 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 22:19 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 23:08 |
opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Just test rally baby https://review.opendev.org/c/openstack/kolla-ansible/+/913728 | 23:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!