| opendevreview | Merged openstack/ansible-collection-kolla stable/zed: Fix: include missing docker log-opts in config https://review.opendev.org/c/openstack/ansible-collection-kolla/+/909254 | 09:07 |
|---|---|---|
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Allow overriding of Skyline logos https://review.opendev.org/c/openstack/kolla-ansible/+/909481 | 09:15 |
| opendevreview | Merged openstack/ansible-collection-kolla stable/2023.1: Fix: include missing docker log-opts in config https://review.opendev.org/c/openstack/ansible-collection-kolla/+/909253 | 09:17 |
| opendevreview | Verification of a change to openstack/kolla-ansible master failed: Adjust Ceph metrics scrape interval in Prometheus https://review.opendev.org/c/openstack/kolla-ansible/+/902129 | 09:20 |
| opendevreview | Merged openstack/ansible-collection-kolla stable/2023.2: Fix: include missing docker log-opts in config https://review.opendev.org/c/openstack/ansible-collection-kolla/+/909252 | 09:20 |
| SvenKieske | mnasiadka: you restored https://review.opendev.org/c/openstack/kolla-ansible/+/888496 do you have any insight/now the contributor? because we also have https://review.opendev.org/c/openstack/kolla-ansible/+/905860 which imho works now. | 10:17 |
| SvenKieske | *know | 10:17 |
| mnasiadka | works now - as in it has been tested by anybody? ;-) | 10:18 |
| SvenKieske | mnasiadka: afaik Uwe tested it, but I have to ask. I only "know" him indirectly though. But the other patch has no activity since october afaik, so I figure let's ask around. | 10:19 |
| SvenKieske | code wise it looks good to me. I personally don't use skyline though. | 10:22 |
| SvenKieske | it's missing a release note though :) | 10:23 |
| mnasiadka | well, we don't have a CI that tests this | 10:26 |
| mnasiadka | I don't even know if we have skyline CI job | 10:26 |
| SvenKieske | mhm, I'm all in favor of adding CI tests to all the stuff, that seems good. I just want to know: is that a new requirement for new features? Because I'm fairly certain it wasn't a requirement in the past? | 10:27 |
| mnasiadka | not a new requirement, but if people come in and raise bugs - who will fix them? ;-) | 10:31 |
| mnasiadka | I don't have a problem merging non-CI tested patches from trusted people | 10:31 |
| mnasiadka | trusted == active in the community with some track record | 10:32 |
| SvenKieske | I just was about to ask where can I find that list? :D | 10:32 |
| SvenKieske | I understand your sentiment, but I personally find it better if we have the same rules for all contributors tbh. | 10:33 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Break OVN cluster before reconfigure https://review.opendev.org/c/openstack/kolla-ansible/+/897935 | 10:33 |
| SvenKieske | but then again I guess we would come to a grinding halt if we would mandate CI tests for everything starting from now. meh :/ | 10:34 |
| SvenKieske | mnasiadka: maybe you can eludicate my confusion: where do I find the kolla-ansible-ovn-base job results? https://review.opendev.org/c/openstack/kolla-ansible/+/897935/9/zuul.d/base.yaml | 10:40 |
| SvenKieske | is that a subtest of test-ovn? I'm lost in a maze of tests :D | 10:41 |
| mnasiadka | the base jobs are only to be used as template for distro specific jobs | 10:41 |
| mnasiadka | look in jobs.yaml in zuul.d | 10:41 |
| SvenKieske | mhm, ah I guess I see it now. Is it necessary to add this test to the "reconfigure" test? I would find it semantically better if this was a dedicated test file maybe starting with "ovn-"? don't know if that's too complicated from the chain of commands being run | 10:45 |
| SvenKieske | nvm, from the code part it of course needs to run there, before the reconfigure takes place | 10:46 |
| SvenKieske | in theory we could just source a different file named "destroy-ovn-dbs.sh" there, but I guess that's just another layer of indirection and has not much benefit | 10:47 |
| SvenKieske | still LGTM | 10:47 |
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Update Skyline configuration to enable SSO https://review.opendev.org/c/openstack/kolla-ansible/+/905860 | 10:51 |
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Add more services to nginx.conf https://review.opendev.org/c/openstack/kolla-ansible/+/909482 | 10:53 |
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Update Skyline configuration to enable SSO https://review.opendev.org/c/openstack/kolla-ansible/+/905860 | 11:02 |
| SvenKieske | doesn't look like we have skyline tests, only generic dashboard tests, at least ripgrep doesn't find anything matching "skyline" in "tests". | 11:09 |
| SvenKieske | mnasiadka: I added a note about adding CI tests for skyline to the patch | 11:09 |
| opendevreview | Merged openstack/kolla-ansible master: Adjust Ceph metrics scrape interval in Prometheus https://review.opendev.org/c/openstack/kolla-ansible/+/902129 | 11:59 |
| opendevreview | Martin Hiner proposed openstack/kolla-ansible master: Add container engine migration scenario https://review.opendev.org/c/openstack/kolla-ansible/+/836941 | 12:28 |
| opendevreview | Martin Hiner proposed openstack/kolla-ansible master: Add container engine migration scenario https://review.opendev.org/c/openstack/kolla-ansible/+/836941 | 12:36 |
| frickler | skyline isn't an official openstack project yet, still in emerging state, so I wouldn't overdo it in that case for testing | 12:52 |
| SvenKieske | oh it isn't? I thought it was, interesting! | 12:54 |
| opendevreview | Matúš Jenča proposed openstack/kolla-ansible master: Implement TLS for Redis https://review.opendev.org/c/openstack/kolla-ansible/+/909188 | 13:20 |
| opendevreview | Merged openstack/kolla stable/2023.2: toolbox: Improve retry loop for ansible-galaxy https://review.opendev.org/c/openstack/kolla/+/910181 | 13:52 |
| opendevreview | Mark Goddard proposed openstack/ansible-collection-kolla master: Add stats callback plugin https://review.opendev.org/c/openstack/ansible-collection-kolla/+/910347 | 14:54 |
| mnasiadka | frickler, SvenKieske: actually I'm dumb, we have skyline jobs | 16:19 |
| SvenKieske | we do? I didn't check very carefully because I trusted you :D | 16:30 |
| SvenKieske | just grepped for skyline in tests/ | 16:30 |
| SvenKieske | there are generic dashboard tests in test-dashboard.sh but I'm not sure if they would work for skyline | 16:31 |
| SvenKieske | at least the git log has no mentions of skyline with regards to this file | 16:36 |
| SvenKieske | ah lol, there is test-skyline.sh nevermind.. | 16:38 |
| opendevreview | Will Szumski proposed openstack/kolla-ansible master: Support mode in named volumes when using podman https://review.opendev.org/c/openstack/kolla-ansible/+/910016 | 17:09 |
| opendevreview | Will Szumski proposed openstack/kolla-ansible master: Support mode in named volumes when using podman https://review.opendev.org/c/openstack/kolla-ansible/+/910016 | 17:11 |
| spatel | mnasiadka for /neutron/policy.yaml file. all i just need to add my new policy rules right not dump entire policy file correct? | 17:58 |
| mnasiadka | let me see | 17:58 |
| mnasiadka | yes, right | 17:59 |
| mnasiadka | spatel: ^^ | 17:59 |
| spatel | "delete_floatingip": "rule:admin_only" | 17:59 |
| spatel | just add this line in policy.json? | 18:00 |
| spatel | or any syntax or rules i should follow? | 18:00 |
| spatel | I would like to have example here for understanding - https://docs.openstack.org/kolla-ansible/latest/admin/advanced-configuration.html#openstack-policy-customisation | 18:01 |
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Allow overriding of Skyline logos https://review.opendev.org/c/openstack/kolla-ansible/+/909481 | 18:32 |
| opendevreview | Uwe Jäger proposed openstack/kolla-ansible master: Update Skyline configuration to enable SSO https://review.opendev.org/c/openstack/kolla-ansible/+/905860 | 19:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!