| *** jph7 is now known as jph | 01:40 | |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2023.2: Handle removal of Docker devicemapper https://review.opendev.org/c/openstack/kayobe/+/907064 | 07:40 |
|---|---|---|
| mnasiadka | morning | 07:42 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2023.1: Handle removal of Docker devicemapper https://review.opendev.org/c/openstack/kayobe/+/907292 | 07:42 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/zed: Handle removal of Docker devicemapper https://review.opendev.org/c/openstack/kayobe/+/907293 | 07:42 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/yoga: Handle removal of Docker devicemapper https://review.opendev.org/c/openstack/kayobe/+/907294 | 07:49 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/yoga: Handle removal of Docker devicemapper https://review.opendev.org/c/openstack/kayobe/+/907294 | 07:56 |
| mnasiadka | frickler, bbezak, kevko: What did I miss? | 08:00 |
| kevko | mnasiadka: morning | 08:00 |
| kevko | mnasiadka: we were testing upgrade jobs from master->master | 08:00 |
| kevko | mnasiadka: some podman CI fixes | 08:01 |
| kevko | mnasiadka: upper constrainsts were bumped so horizon was broken which is now fixed ..but i had an inspiration to little bit rework horizon https://review.opendev.org/q/topic:%22kolla-horizon-fix%22 ..reviews welcome :) | 08:03 |
| kevko | mnasiadka: designate rework merged | 08:03 |
| kevko | mnasiadka: we had to add some exceptions for ansible lint as it was also bumped and linters were failing | 08:06 |
| kevko | nothing else i think | 08:06 |
| frickler | mnasiadka: welcome back. https://bugs.launchpad.net/kolla/+bug/2051575 may be interesting for you (/me says that with the hope you may want to actually fix it ;) | 08:13 |
| frickler | also stable/yoga should no longer get new patches, which people still do (hello priteau), and will hopefully migrate to unmaintained very soon | 08:14 |
| frickler | there was also some discussion about moving to EOL right away, but it seems shpc/kayobe isn't quite ready for that yet? | 08:15 |
| kevko | frickler: are u sure that it's really tox issue and not related with user setup or something ? because my tox 4 is working .... https://paste.openstack.org/show/bKfrRUZqxonzCOrIMgfV/ | 08:18 |
| mnasiadka | I think for now SHPC is interested in not moving to EOL directly, but let's discuss that on the meeting today | 08:18 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/zed: Handle removal of Docker devicemapper https://review.opendev.org/c/openstack/kayobe/+/907293 | 08:22 |
| frickler | kevko: check the generated file, does it contain more than one line? | 08:23 |
| kevko | frickler: good point :D | 08:23 |
| frickler | mnasiadka: also, not directly related to kolla, but do you use ceph-ansible? https://github.com/ceph/ceph-ansible/commit/a9d1ec844d24fcc3ddea7c030eff4cd6c414d23d | 08:25 |
| mnasiadka | don't use it anymore, we moved to cephadm | 08:25 |
| opendevreview | Rafal Lewandowski proposed openstack/kolla-ansible master: [WIP] Enable ML2/OVN and distributed FIP by default https://review.opendev.org/c/openstack/kolla-ansible/+/904959 | 08:30 |
| kevko | btw, guys, do you use some wysiwig .rst editor ? i mean ..for docs :P | 08:40 |
| kevko | with some cheatsheet ideally :D | 08:40 |
| mnasiadka | some people use vs code | 08:54 |
| mnasiadka | frickler: that was long coming | 09:07 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add Redfish rules to Ironic introspection https://review.opendev.org/c/openstack/kayobe/+/902772 | 09:36 |
| *** zigo_ is now known as zigo | 09:43 | |
| opendevreview | Will Szumski proposed openstack/kayobe master: Remove docker devicemapper support https://review.opendev.org/c/openstack/kayobe/+/906386 | 09:50 |
| SvenKieske | I use vs code, the diff and rendered preview are quite nice. for quick edits I just stick with vim on the cli. | 09:53 |
| SvenKieske | for questions regarding restructuredText I just look at the spec | 09:56 |
| SvenKieske | https://docutils.sourceforge.io/docs/ref/rst/restructuredtext.html | 09:56 |
| SvenKieske | or look at the quick ref: https://docutils.sourceforge.io/docs/user/rst/quickref.html | 09:57 |
| SvenKieske | markdown is somewhat simpler, but can't do everything rst can do | 09:57 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add Redfish rules to Ironic introspection https://review.opendev.org/c/openstack/kayobe/+/902772 | 10:01 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add Redfish rules to Ironic introspection https://review.opendev.org/c/openstack/kayobe/+/902772 | 10:04 |
| opendevreview | Matt Crees proposed openstack/kayobe master: Fix: configure etc-hosts for overcloud group https://review.opendev.org/c/openstack/kayobe/+/907306 | 10:39 |
| mnasiadka | kevko: https://review.opendev.org/c/openstack/kolla/+/906516 - have a minute to take a look? or frickler | 10:42 |
| opendevreview | Piotr Parczewski proposed openstack/kolla stable/2023.2: trivial: fix typos in let's encrypt status logs https://review.opendev.org/c/openstack/kolla/+/907265 | 11:10 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add Redfish rules to Ironic and Bifrost introspection https://review.opendev.org/c/openstack/kayobe/+/902772 | 11:20 |
| opendevreview | Verification of a change to openstack/kayobe stable/2023.2 failed: Handle removal of Docker devicemapper https://review.opendev.org/c/openstack/kayobe/+/907064 | 11:28 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Refactor external ceph https://review.opendev.org/c/openstack/kolla-ansible/+/907166 | 11:35 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Copy all keyrings and configs to cinder-backup https://review.opendev.org/c/openstack/kolla-ansible/+/907167 | 11:35 |
| kevko | mnasiadka: let me check | 11:39 |
| mnasiadka | kevko: we're using that now, so might be more fixes will come later ;-) | 11:46 |
| opendevreview | Bartosz Bezak proposed openstack/kolla-ansible master: Disable new defaults and scope for Ironic (RBAC) https://review.opendev.org/c/openstack/kolla-ansible/+/906858 | 11:49 |
| kevko | mnasiadka: haha, hope that not :) | 11:49 |
| opendevreview | Michal Arbet proposed openstack/kolla master: [follow-up] Use full binary path when invoking ip https://review.opendev.org/c/openstack/kolla/+/907315 | 12:43 |
| kevko | mnasiadka: approved, but i realized that there is also another place where ip is used ... so patch here ^^^ | 12:43 |
| mnasiadka | what about rsync sed and ssh - are we sure those work? :-) | 12:45 |
| kevko | bbezak | 12:45 |
| kevko | We will see | 12:45 |
| opendevreview | Bartosz Bezak proposed openstack/kolla-ansible master: Disable new defaults and scope for Ironic (RBAC) https://review.opendev.org/c/openstack/kolla-ansible/+/906858 | 12:52 |
| frickler | why on earth is "ip" in sbin? | 13:03 |
| mnasiadka | Well, it's in sbin on RH derivatives | 13:05 |
| mnasiadka | wonder if we didn't break Debian/Ubuntu | 13:05 |
| frickler | no, it is in sbin there, too. I'm just wondering why | 13:07 |
| frickler | also thankfully /sbin is a symlink to /usr/sbin on modern systems, else I'd have suggested to use /sbin/ip instead. although one could still prefer that since it is shorter | 13:08 |
| mnasiadka | don't ask me :) | 13:09 |
| opendevreview | Merged openstack/kolla master: Use full binary path when invoking ip https://review.opendev.org/c/openstack/kolla/+/906516 | 13:27 |
| mmalchuk | frickler just compare 'find /sbin -perm -4000' and 'find /usr/bin -perm -4000' and you will find no ordinary user tools which need root permissions in /sbin | 13:52 |
| mmalchuk | ip needs root permissions almost for all operations | 13:53 |
| mmalchuk | so in in /sbin because not ordinary user tool, but tool for root) | 13:54 |
| mmalchuk | ip* | 13:54 |
| bbezak | meeeting in 4 mgoddard mnasiadka bbezak frickler kevko SvenKieske mmalchuk gkoper jangutter jsuazo jovial osmanlicilegi mattcrees | 13:56 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2023.2: Deprecate devicemapper due to removal in Docker https://review.opendev.org/c/openstack/kayobe/+/907064 | 13:58 |
| frickler | actually on ubuntu I have lrwxrwxrwx 1 root root 7 Jun 29 2022 /usr/sbin/ip -> /bin/ip | 13:58 |
| frickler | and all show commands should not require root | 13:58 |
| opendevreview | Pierre Riteau proposed openstack/kayobe stable/2023.1: Deprecate devicemapper due to removal in Docker https://review.opendev.org/c/openstack/kayobe/+/907292 | 13:59 |
| bbezak | #startmeeting kolla | 14:00 |
| opendevmeet | Meeting started Wed Jan 31 14:00:34 2024 UTC and is due to finish in 60 minutes. The chair is bbezak. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'kolla' | 14:00 |
| bbezak | #topic rollcall | 14:00 |
| mmalchuk | \o | 14:00 |
| jangutter | o/ | 14:00 |
| jovial | \o | 14:00 |
| mattcrees | o/ | 14:00 |
| mnasiadka | o/ | 14:01 |
| SvenKieske | o/ | 14:01 |
| frickler | \o | 14:01 |
| bbezak | #topic agenda | 14:02 |
| bbezak | * Roll-call | 14:02 |
| bbezak | * Agenda | 14:02 |
| bbezak | * Announcements | 14:02 |
| bbezak | * Review action items from the last meeting | 14:02 |
| bbezak | * CI status | 14:02 |
| bbezak | * Release tasks | 14:02 |
| bbezak | * Regular stable releases (first meeting in a month) | 14:02 |
| bbezak | * Current cycle planning | 14:02 |
| bbezak | * Additional agenda (from whiteboard) | 14:02 |
| bbezak | * Open discussion | 14:02 |
| bbezak | #topic CI status | 14:03 |
| bbezak | Kayobe is red, because of Ironic RBAC | 14:03 |
| bbezak | but workaround is raised in k-a | 14:03 |
| mnasiadka | link to a patch? | 14:04 |
| bbezak | https://review.opendev.org/c/openstack/kolla-ansible/+/906858 | 14:04 |
| mnasiadka | #link https://review.opendev.org/c/openstack/kolla-ansible/+/906858 | 14:04 |
| bbezak | I addressed review comments | 14:04 |
| mnasiadka | +2ed | 14:04 |
| bbezak | and I outlined the status in bug #link https://bugs.launchpad.net/kolla-ansible/+bug/2051837 | 14:05 |
| mnasiadka | remember to raise a revert after it merges and RP+1, so we don't forget :-) | 14:05 |
| bbezak | ok | 14:05 |
| bbezak | I'll track this. When ironic fixes its policy, we should add service role | 14:06 |
| bbezak | even we should do it regardless of ironic case | 14:06 |
| mnasiadka | Well, only Ironic does system scope | 14:06 |
| bbezak | but it should work also with project scope service role | 14:06 |
| mnasiadka | (and Keystone because of Ironic) | 14:06 |
| bbezak | after the patch in progress | 14:06 |
| bbezak | at least for nova-compute-ironic | 14:07 |
| bbezak | the other question is kayobe and its baremetal management | 14:07 |
| bbezak | Kayobe also has a issue with devicemapper being dropped in docker | 14:08 |
| bbezak | #link https://review.opendev.org/c/openstack/kayobe/+/906386 | 14:08 |
| mnasiadka | if project scope will work, that seems optional | 14:08 |
| mnasiadka | but if anybody wants to work on this - then sure, why not | 14:08 |
| bbezak | enabling system scope support would need rewrite a big service-ks role to use ansible-collection-openstack modules for role assignment, as they support system scope | 14:09 |
| bbezak | (not big of course, just a rewrite) :) | 14:09 |
| mnasiadka | since our CI is ansible-core now, then we use ansible-collection-openstack now | 14:10 |
| mnasiadka | we would just need some not-so-big-rewrite ;) | 14:10 |
| bbezak | yeap | 14:10 |
| jovial | bbezak, good point about the kayobe baremetal management playbooks. I guess the admin user configured public-openrc.sh won't have the right permissions? | 14:10 |
| bbezak | not a big deal, and probably we need to do it at some point anyway | 14:10 |
| mnasiadka | I doubt more projects are going to do system scope | 14:11 |
| bbezak | jovial probably there will be some issues with project scoped admin | 14:11 |
| bbezak | which reminds me that kayobe don't have proper depends-on support on kolla-ansible? | 14:12 |
| bbezak | (to test it later in CI) | 14:12 |
| mnasiadka | it does I think, but not in all cases | 14:12 |
| bbezak | ok | 14:13 |
| jovial | I see references to the zuul project at least: https://github.com/openstack/kayobe/blob/395bd34f645da28600fdd84eaf6bf4075a3d5636/playbooks/kayobe-overcloud-base/overrides.yml.j2#L12 | 14:14 |
| bbezak | I recalled that somebody was complaining about it | 14:14 |
| bbezak | #topic Current cycle planning | 14:14 |
| mnasiadka | I did, I think it didn't work with kolla patches | 14:15 |
| mnasiadka | kolla-ansible worked ok, and I don't know what about a-c-k | 14:15 |
| jovial | ahh, how could we make that work? | 14:16 |
| mnasiadka | I'm speculating, don't really remember :) | 14:16 |
| mnasiadka | for kolla patches it would only need to build images and use them | 14:16 |
| bbezak | ok, worth a bug then in kayobe to make test coverage better | 14:17 |
| jovial | +1 | 14:17 |
| jovial | Is that how you do it k-a? Build the images locally then? We can't consume the ones built from the kolla patch? | 14:18 |
| mnasiadka | no, the images are not pushed anywhere, just the local registry on the CI node | 14:19 |
| mnasiadka | there is some intermediate registry in Zuul, I don't remember how it works | 14:19 |
| jovial | OK, I'll make a bug in kayobe for the backlog. Thanks for the details. | 14:21 |
| bbezak | thx jovial mnasiadka | 14:21 |
| bbezak | sorry for changing the topic in a middle of conversation | 14:22 |
| bbezak | (I thought we finished the discussion) | 14:22 |
| mnasiadka | no problem :) | 14:22 |
| bbezak | I guess we finished CI chat for now | 14:22 |
| mattcrees | In CI status, the ansible-collection-kolla tox linters are also failing, due to a dependency change it seems: https://zuul.opendev.org/t/openstack/build/6cda783bcd2e4e21bdebc87d2a8692ba | 14:23 |
| bbezak | ok, so a-c-k CI in red status | 14:23 |
| mnasiadka | so we might need to bump lint | 14:23 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add Redfish rules to Ironic and Bifrost introspection https://review.opendev.org/c/openstack/kayobe/+/902772 | 14:24 |
| mnasiadka | I'll have a look, unless somebody else wants to | 14:24 |
| mattcrees | I can have a look, but probably won't have the time until Friday | 14:24 |
| bbezak | it looks like we need branch status for a-c-k in the kolla whiteboard | 14:25 |
| opendevreview | Michal Nasiadka proposed openstack/ansible-collection-kolla master: CI: Bump ansible-core and ansible-lint versions https://review.opendev.org/c/openstack/ansible-collection-kolla/+/907329 | 14:26 |
| mnasiadka | yeah, would be also nice to find a volunteer to get proper grafana dashboards for CI | 14:26 |
| mnasiadka | so we don't have to click our way through Zuul | 14:26 |
| bbezak | you mean grafana.opendev.org ? | 14:27 |
| mnasiadka | yup | 14:27 |
| mnasiadka | can point a volunteer to proper place - https://review.opendev.org/c/openstack/project-config/+/605026 | 14:28 |
| mnasiadka | somewhere in those files - my old patch | 14:28 |
| bbezak | I recall fixing it couple of years ago | 14:28 |
| kevko | \o | 14:28 |
| bbezak | any volunteer? :) | 14:29 |
| bbezak | ok, maybe somebody show up later on, let's move on then | 14:31 |
| bbezak | (I'll make a not for it) | 14:31 |
| SvenKieske | it's not entirely clear from your request what you want these dashboards to display, exactly, maybe it would be good to write that up, somewhere? | 14:32 |
| bbezak | and thx mattcrees for pointing out a-c-k issue | 14:32 |
| mattcrees | np | 14:33 |
| opendevreview | Rafal Lewandowski proposed openstack/kayobe master: Add Redfish rules to Ironic and Bifrost introspection https://review.opendev.org/c/openstack/kayobe/+/902772 | 14:33 |
| bbezak | yeah, I'll write it up in the whiteboard | 14:34 |
| bbezak | thx SvenKieske | 14:34 |
| bbezak | #topic Current cycle planning | 14:35 |
| bbezak | unfortunately not much of a progress from my side at least on tasks with mine name below | 14:36 |
| bbezak | it looks like we need asignee for Kayobe podman support jovial https://etherpad.opendev.org/p/KollaWhiteBoard#L251 | 14:36 |
| jovial | Would be good. Is anyone keen to take that on? | 14:37 |
| mnasiadka | L259 - those are done and can be crossed out - right? | 14:38 |
| bbezak | looks all merged | 14:38 |
| bbezak | so yes mnasiadka | 14:39 |
| mnasiadka | done | 14:40 |
| mnasiadka | I'll try to push forward on OVN BGP agent next week | 14:40 |
| mnasiadka | and maybe add support for OVN VPNaaS because there's an RFE with a description | 14:40 |
| mnasiadka | mattcrees: https://review.opendev.org/c/openstack/ansible-collection-kolla/+/907329 - seems that works | 14:41 |
| mattcrees | Nice | 14:41 |
| mnasiadka | while we're at bumping Ansible | 14:42 |
| mnasiadka | Should we have a list of what needs bumping on the Whiteboard? | 14:42 |
| bbezak | at minimum I think | 14:43 |
| mattcrees | Sounds useful to me | 14:43 |
| mnasiadka | anybody did have a look in my SLURP patch? | 14:43 |
| mnasiadka | ah, it's failing | 14:44 |
| mnasiadka | I'll bring it to shape and we can discuss | 14:44 |
| mnasiadka | #link https://review.opendev.org/c/openstack/kolla-ansible/+/905322 | 14:44 |
| bbezak | I'm wondering about test coverage. i.e. if all services will like SLURP | 14:45 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Run SLURP upgrade job https://review.opendev.org/c/openstack/kolla-ansible/+/905322 | 14:45 |
| bbezak | of course we can't test every service in CI | 14:45 |
| mnasiadka | well, we don't have upgrade jobs for octavia and others | 14:45 |
| mnasiadka | but I was thinking of adding octavia and testing to the core job | 14:45 |
| mnasiadka | since octavia is not really optional :) | 14:46 |
| SvenKieske | sounds like a good plan to extend coverage | 14:46 |
| mnasiadka | ok, so will add that, then we test that in slurp as well | 14:46 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Run SLURP upgrade job https://review.opendev.org/c/openstack/kolla-ansible/+/905322 | 14:46 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Run SLURP upgrade job https://review.opendev.org/c/openstack/kolla-ansible/+/905322 | 14:48 |
| bbezak | ok then. please progress the caracal priority changes if possible then. thx | 14:48 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Run SLURP upgrade job https://review.opendev.org/c/openstack/kolla-ansible/+/905322 | 14:48 |
| bbezak | #topic Additional agenda (from whiteboard) | 14:50 |
| bbezak | we've got there only one task which I forgot to clean up last time :) | 14:50 |
| bbezak | namely (mhiner) Container engine migration - https://review.opendev.org/c/openstack/kolla-ansible/+/836941 | 14:50 |
| bbezak | we've decided to move discussion to the patch itself | 14:51 |
| bbezak | no additional agenda, so next topic then | 14:51 |
| bbezak | #topic Open discussion | 14:51 |
| SvenKieske | anybody at FOSDEM, Brussels, this weekend? | 14:52 |
| SvenKieske | https://fosdem.org/2024/ for those not familiar :) | 14:53 |
| mmalchuk | https://www.youtube.com/watch?v=_OC0n7Hefpw | 14:53 |
| mmalchuk | for online watch CentOS Connect 2024 | 14:54 |
| mmalchuk | the part of FOSDEM | 14:54 |
| mmalchuk | SvenKieske i'm online watcher) | 14:54 |
| SvenKieske | nice :) I make sure to wave at the cameras :D | 14:55 |
| bbezak | :) | 14:56 |
| mmalchuk | ;) | 14:57 |
| opendevreview | Will Szumski proposed openstack/kayobe master: Remove docker devicemapper support https://review.opendev.org/c/openstack/kayobe/+/906386 | 14:58 |
| bbezak | nice, thx for the links | 14:58 |
| bbezak | some nice sessions there | 14:59 |
| bbezak | good that Rocky and Alma is there too | 14:59 |
| bbezak | anything else to discuss for today? | 14:59 |
| SvenKieske | I guess that's it for today :) | 15:00 |
| bbezak | cool, thx everybody | 15:00 |
| bbezak | #endmeeting | 15:00 |
| opendevmeet | Meeting ended Wed Jan 31 15:00:35 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-01-31-14.00.html | 15:00 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-01-31-14.00.txt | 15:00 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/kolla/2024/kolla.2024-01-31-14.00.log.html | 15:00 |
| mmalchuk | thanks bbezak | 15:00 |
| SvenKieske | thanks bbezak! | 15:01 |
| kevko | thx | 15:01 |
| opendevreview | Dawud proposed openstack/kayobe master: Fix wipe-disks role to work on newer distros https://review.opendev.org/c/openstack/kayobe/+/907105 | 15:59 |
| SvenKieske | kevko: mhm, should we backport https://review.opendev.org/c/openstack/kolla-ansible/+/905852 ? if yes, how far? | 16:01 |
| mnasiadka | SvenKieske: this changes behaviour from what I see, we don't backport such things usually | 16:11 |
| SvenKieske | mnasiadka: true, but the new behaviour is imho better, could we backport when we change it to use the old behaviour by default or doesn't that really add anything? mhmm | 16:16 |
| frickler | the patch only makes sense for new deployments I think, so why would you need it on stable branches? | 16:17 |
| kevko | mnasiadka: well, it's compatible ..but i don't care .. | 16:17 |
| kevko | same thing can be fullfilled with config overrides and read neutron designate docs :) | 16:18 |
| mnasiadka | ah right, neutron_dns_integration is set to enable_designate | 16:18 |
| mnasiadka | but designate_ns_record change is not backwards compatible | 16:19 |
| mnasiadka | so anybody that wants this backported, would need to adapt it | 16:19 |
| kevko | mnasiadka: yeah, but there is a precheck | 16:19 |
| mnasiadka | making something backwards compatible is not about failing in precheck :D | 16:20 |
| kevko | mnasiadka: well, if anyone using it ...he had to use confg-override | 16:20 |
| kevko | so even if you backport this change ..nothing will change ..because he is using override | 16:20 |
| kevko | (if using designate ) | 16:21 |
| mnasiadka | override what? | 16:21 |
| kevko | designate_ns_record is used in pools.yaml but also in neutron.conf | 16:21 |
| kevko | so if user set designate_ns_record ..it's rendered in neutron ... but he needed to provide custom pools.yaml | 16:21 |
| kevko | but if it is a list .. pools.yaml is rendered correctly ...but missing in neutron :D | 16:22 |
| mnasiadka | yeah well ;) | 16:22 |
| kevko | so all of koalas needed to workaround somehow :D | 16:22 |
| kevko | did you get it right ? :D | 16:22 |
| mnasiadka | in theory this is right, but we don't know all the edge cases | 16:23 |
| kevko | so I am ok to not backport as anyone can cherry-pick | 16:23 |
| kevko | BUT | 16:23 |
| mnasiadka | I prefer to be on the safe side | 16:23 |
| kevko | the first patch from the chain should be backported i think | 16:23 |
| kevko | mnasiadka: this one https://review.opendev.org/c/openstack/kolla-ansible/+/905502/19 | 16:24 |
| mnasiadka | it seems backports are in gerrit | 16:24 |
| mnasiadka | we are just bad in reviewing, as always | 16:24 |
| mnasiadka | https://review.opendev.org/q/(project:openstack/kolla-ansible+OR+project:openstack/ansible-collection-kolla)+status:open+NOT+label:Workflow%3C%3D-1+NOT+label:Code-Review%3C%3D-2+branch:%5Estable/.*+status:open+NOT+label:Review-Priority%3D-1 | 16:25 |
| kevko | yeah - just saying that those patches are safe to backport and should be backported | 16:25 |
| kevko | share some bookmarks with me and i will try to do better work :) | 16:26 |
| mnasiadka | kollawhiteboard - there are gerrit dashboard links on L27 and L28 | 16:26 |
| mnasiadka | those in theory should make our work better | 16:26 |
| mnasiadka | I see craploads of priority changes :) | 16:27 |
| opendevreview | Will Szumski proposed openstack/kayobe master: Remove docker devicemapper support https://review.opendev.org/c/openstack/kayobe/+/906386 | 16:43 |
| opendevreview | Martin Hiner proposed openstack/kolla-ansible master: Add container engine migration scenario https://review.opendev.org/c/openstack/kolla-ansible/+/836941 | 16:46 |
| SvenKieske | mhm, gerrit gui is slow for me today, am I the only one? | 16:48 |
| mnasiadka | not slower than usual | 16:55 |
| opendevreview | Will Szumski proposed openstack/kayobe master: Remove docker devicemapper support https://review.opendev.org/c/openstack/kayobe/+/906386 | 16:58 |
| opendevreview | Maksim Malchuk proposed openstack/kolla-ansible master: Fix gnocchi-metricd when TLS and Swift enabled https://review.opendev.org/c/openstack/kolla-ansible/+/907254 | 16:59 |
| kevko | anyone here ? | 17:21 |
| kevko | mnasiadka: if i have nova_ceph_user != cinder_ceph_user why we are copying both keyrings into nova-compute/libvirt ? | 17:22 |
| mnasiadka | does it hurt? | 17:22 |
| kevko | mnasiadka: because only one user is used always | 17:22 |
| kevko | no no ..it don't hurts ... | 17:22 |
| kevko | root@compute0:~# grep -ri b1352eba-154e-4e9c-acc1-741b8657efad /etc/kolla/ | 17:22 |
| kevko | root@compute0:~# grep -ri 34629c81-1c5d-4761-aa21-7a9b825a02b6 /etc/kolla/ | 17:22 |
| kevko | mnasiadka: i am just refatoring because i need to | 17:23 |
| kevko | mnasiadka: and found that we have two secrets in libvirt but i can found only one used ... | 17:23 |
| mnasiadka | well, you're the one that touched ceph code recently, I haven't looked into that one for ages | 17:23 |
| kevko | mnasiadka: well, it just means that we are copying two keyring but need only one | 17:24 |
| kevko | mnasiadka: i am just confused :) | 17:24 |
| kevko | mnasiadka: i mean this -> https://paste.openstack.org/show/bKvZ0ArywDNOUX5f7VUK/ | 17:26 |
| kevko | mnasiadka: b1352eba-154e-4e9c-acc1-741b8657efad is not used ... | 17:26 |
| mnasiadka | are you sure it's not used when nova_key != cinder_key for cinder volumes? | 17:26 |
| kevko | mnasiadka: well, I am asking ..where to find any reference for second libvirt secret ? | 17:27 |
| kevko | mnasiadka: because as you can see above ..grep didn't help :P | 17:28 |
| SvenKieske | did you look at the git log? maybe the commit introducing it has a hint? | 17:28 |
| mnasiadka | kevko: https://github.com/openstack/kolla-ansible/blob/f0b7bf33abb6faff506599c99863b823ca108ef5/ansible/roles/cinder/templates/cinder.conf.j2#L159 | 17:30 |
| mnasiadka | we set that for cinder and I assume cinder uses that for cinder volumes, right? | 17:30 |
| kevko | mnasiadka: okay i now got it | 17:34 |
| kevko | mnasiadka: from this article | 17:34 |
| kevko | https://superuser.openinfra.dev/articles/ceph-as-storage-for-openstack/ | 17:34 |
| kevko | mnasiadka: I thought I had lost my way, thanks for the help | 17:37 |
| SvenKieske | seems this is the commit? https://github.com/openstack/kolla-ansible/commit/d06efcecc52b00f3e26dce3016accd04f6a52793 "Booting from volume require cinder's ceph client secret now. Move cinder before nova in site.yml, because nova depends on cinder ceph client key now." | 17:37 |
| SvenKieske | https://review.opendev.org/c/openstack/kolla-ansible/+/442519 | 17:38 |
| kevko | SvenKieske: yep -> it's connected .. | 17:39 |
| kevko | SvenKieske: thanks for commit | 17:41 |
| SvenKieske | got to love git blame :) also that's actually a good commit message that explains why it's needed! :) | 17:42 |
| SvenKieske | it could also just say "fix ceph auth" or something like that :) | 17:43 |
| SvenKieske | mnasiadka: guess we need to look again at service_users: https://bugs.launchpad.net/kolla-ansible/+bug/2049762/comments/1 | 17:51 |
| kevko | SvenKieske: but , if the keyrings are stored in libvirt as secrets xmls ...then keyrings are not needed :D | 17:54 |
| SvenKieske | I added it to the Whiteboard, maybe our handling of service tokens in cinder is a little wrong, when reading seans comment at least. I didn't look at the code again. | 17:55 |
| kevko | SvenKieske: are u talking about service token roles rquired ? <-> nova cinder ? | 17:57 |
| kevko | SvenKieske: i have it in backlog :D | 17:57 |
| kevko | SvenKieske: point is that code has service_token_roles_required = something ... and we have admin there | 17:58 |
| kevko | SvenKieske: point is that in a code is some type of hack which is checking if it is admin/service ..and even if it is admin and not service role ...it will disable action ...but you will get different reply | 17:59 |
| kevko | tempests are failing on that if it's kolla deployment | 17:59 |
| SvenKieske | kevko: I talk about the bug report I linked above: https://bugs.launchpad.net/kolla-ansible/+bug/2049762/comments/1 | 18:00 |
| kevko | SvenKieske: yeah, I've read already | 18:00 |
| SvenKieske | yeah, service_role admin seems wrong, at least to seans comments, and he is usually right, as far as I know :D | 18:01 |
| kevko | SvenKieske: aaaa yeah ..that patch refered is bad | 18:03 |
| kevko | SvenKieske: from you actually :) | 18:04 |
| kevko | SvenKieske: there definitely shouldn't be admin role as role required ..because then normal admin can do the stuff as service user .. | 18:04 |
| opendevreview | Merged openstack/kolla-ansible stable/2023.2: Fix OpenSearch upgrade tasks idempotency https://review.opendev.org/c/openstack/kolla-ansible/+/906493 | 21:58 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Refactor external ceph https://review.opendev.org/c/openstack/kolla-ansible/+/907166 | 23:14 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Copy all keyrings and configs to cinder-backup https://review.opendev.org/c/openstack/kolla-ansible/+/907167 | 23:14 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Refactor external ceph https://review.opendev.org/c/openstack/kolla-ansible/+/907166 | 23:31 |
| opendevreview | Michal Arbet proposed openstack/kolla-ansible master: Copy all keyrings and configs to cinder-backup https://review.opendev.org/c/openstack/kolla-ansible/+/907167 | 23:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!