Tuesday, 2023-12-19

opendevreviewXing Zhang proposed openstack/kolla-ansible master: Fix default_share_type for manila-api  https://review.opendev.org/c/openstack/kolla-ansible/+/89158804:02
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387106:58
SvenKieskesamcat116: can you tell me more about this amqp exception? is this thrown by the agent itself, or by rabbitmq?09:05
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387109:50
opendevreviewscoopex proposed openstack/kolla-ansible master: configuration improvements  https://review.opendev.org/c/openstack/kolla-ansible/+/90052809:55
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387110:40
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: treat ansible-lint warnings as errors  https://review.opendev.org/c/openstack/kolla-ansible/+/90394210:47
mnasiadkaSvenKieske: ^^10:47
SvenKieskemhm, but did you find docs which say what "strict" actually does? the ansible-lint page is a mess..10:54
mnasiadkahttps://ansible.readthedocs.io/projects/lint/usage/10:55
SvenKieskeah ty10:55
SvenKieskeif you search for "strict" on their page this result is buried after a link, because the preview is too long for the page..10:57
SvenKieskeall other results are meaningless though and don't explain the term :D10:58
SvenKieskemnasiadka: should we add this also as a command line switch to the tox.ini? it's a little split now with config in a dot file and in the tox.ini as commandline switches?11:00
mnasiadkaSvenKieske: well, if we can have everything in .ansible-lint.cfg then we can drop those options from tox.ini11:01
mnasiadkathis way at least it's consistent when somebody just runs ansible-lint11:01
SvenKieskesure11:03
SvenKieskeso if we merge my patch the linter will be fine ;)11:05
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: treat ansible-lint warnings as errors  https://review.opendev.org/c/openstack/kolla-ansible/+/90394211:05
mnasiadkaok, rebased this on your patch, if everything goes green - I'll merge it, it's CI only basically11:06
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: quorum: add missing octavia and masakari  https://review.opendev.org/c/openstack/kolla-ansible/+/90394611:13
SvenKieskeoh, did I miss some services? :/11:27
mnasiadkaseems so11:28
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387111:49
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: WIP: CI: Template out kolla-build.conf using role  https://review.opendev.org/c/openstack/kolla-ansible/+/90377111:57
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Drop masakari jobs from project.yml  https://review.opendev.org/c/openstack/kolla-ansible/+/90396912:07
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: CI: Drop masakari jobs from project.yaml  https://review.opendev.org/c/openstack/kolla-ansible/+/90396912:11
samcat116SvenKieske: it was being thrown by the agent itself. I looked into it more and it seems like the agent forces auto_delete to true no matter what you set in the config. auto_delete isn’t compatible with quorum queues12:36
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387112:49
opendevreviewMatúš Jenča proposed openstack/kolla-ansible master: Implement Redis as caching backend  https://review.opendev.org/c/openstack/kolla-ansible/+/90397812:50
sylvrHi ! I'm using kayobe and in my deployment network and controllers are different nodes, should I add a file for network in inventory/group_vars for network nodes ? I already tweaked inventory/groups to separate network from controllers12:54
opendevreviewMerged openstack/kolla-ansible master: CI: fix two ansible-lint warnings  https://review.opendev.org/c/openstack/kolla-ansible/+/90390612:59
opendevreviewMerged openstack/kolla-ansible master: CI: treat ansible-lint warnings as errors  https://review.opendev.org/c/openstack/kolla-ansible/+/90394213:00
opendevreviewMerged openstack/kolla-ansible master: CI: Drop masakari jobs from project.yaml  https://review.opendev.org/c/openstack/kolla-ansible/+/90396913:00
mnasiadkasylvr: you can use group_vars or host_vars13:02
sylvrthanks! also, for now, all of my nodes are put in the same group (controllers) is it normal or should they already be "sorted" within the correct groups ? (according to their network interfaces for exemple)13:04
SvenKieskesamcat116: then that sounds like a bug worth reporting to the ironic folks? if they plan to support quorum queues, that is.13:14
SvenKieskesamcat116: If you file a bug, please link it here, so I can track that. if you can't file a bugreport yourself I can do that as well, but I would need a little bit more details like versions deployed, exact error message etc.13:15
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387113:54
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387114:26
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: WIP: CI: Template out kolla-build.conf using role  https://review.opendev.org/c/openstack/kolla-ansible/+/90377114:26
opendevreviewSven Kieske proposed openstack/kolla-ansible stable/2023.1: provide a flag to enable quorum queues  https://review.opendev.org/c/openstack/kolla-ansible/+/90238714:51
samcat116SvenKieske: Bug filed: https://bugs.launchpad.net/networking-baremetal/+bug/204696214:58
*** EugenMayer440189 is now known as EugenMayer4401814:59
SvenKieskesamcat116: thank you!15:00
SvenKieskesamcat116: looking at that code I maybe can even provide a sane patch for that, let's see if I find some time for that15:02
samcat116I was thinking that, but looking back at the reason it was introduced, I am not familiar enough with RabbitMQ to try and achieve the same thing with a newer method15:03
mnasiadkasamcat116: posted a reply - that should work as a workaround15:18
mnasiadkasamcat116: seems this is at least 4 years old - https://storyboard.openstack.org/#!/story/200493315:22
mnasiadkabut yes, quorum queues are to be persistent, so not temporary, so not autodeleted15:23
mnasiadkamaybe networking-baremetal should finally decide how they want to use RMQ15:23
SvenKieskemnasiadka: I proposed a patch for networking-baremetal15:31
SvenKieskeI read the upstream code as, if this is disabled by config they explicitly enable that setting, so your workaround should not work?15:32
SvenKieskeah my bad, I read that wrong15:32
SvenKieskeyeah I found the old commit mentioning this/that introduced this. It somehow feels like they are really using this message system wrong..15:33
SvenKieskethey should use a queue/message system that guarantees at-least-once-delivery to each consumer and not invent funny algorithms that reinvent solutions to already solved problems.15:35
SvenKieskesamcat116: maybe you can test my patch? don't know if neutron will accept it, but worth a try? :)15:36
mnasiadkaSvenKieske: I think they invented this to orchestrate a rename for their queues, but what do I know ;)15:37
SvenKieskeinteresting that OVH and others didn't stumble upon this, well maybe they don't use this agent15:38
mnasiadkamaybe they don't use Ironic ;)15:42
SvenKieskemight be :) do you think I can review the quorum queue precheck now or do you want to fiddle with it some more? :)15:44
mnasiadkaI think you can review, it's passing15:46
mnasiadkaat least the opensearch jobs are passing now15:48
mnasiadkaand you can see which queue is misconfigured15:48
SvenKieskethat's pretty nice; I had to look up that loop_control label stuff again though :D15:49
opendevreviewscoopex proposed openstack/kolla-ansible master: rabbitmq: configuration improvements  https://review.opendev.org/c/openstack/kolla-ansible/+/90052816:01
opendevreviewMerged openstack/kolla-ansible master: quorum: add missing octavia and masakari  https://review.opendev.org/c/openstack/kolla-ansible/+/90394616:12
opendevreviewSven Kieske proposed openstack/kolla-ansible stable/2023.2: quorum: add missing octavia and masakari  https://review.opendev.org/c/openstack/kolla-ansible/+/90400316:16
opendevreviewSven Kieske proposed openstack/kolla-ansible stable/2023.1: quorum: add missing octavia and masakari  https://review.opendev.org/c/openstack/kolla-ansible/+/90400416:16
opendevreviewSven Kieske proposed openstack/kolla-ansible stable/zed: quorum: add missing octavia and masakari  https://review.opendev.org/c/openstack/kolla-ansible/+/90400516:17
SvenKieskemeh, some of these backports should probably wait until the proper quorum support is there in these release, but at least I will not forget them this way :D16:26
mnasiadkawould make sense to stack them on top of the quorum patch16:33
mnasiadkaso we don't merge them before :)16:33
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible stable/2023.2: CI: treat ansible-lint warnings as errors  https://review.opendev.org/c/openstack/kolla-ansible/+/90400616:35
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible stable/2023.1: CI: treat ansible-lint warnings as errors  https://review.opendev.org/c/openstack/kolla-ansible/+/90400716:35
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible stable/zed: CI: treat ansible-lint warnings as errors  https://review.opendev.org/c/openstack/kolla-ansible/+/90400816:36
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible stable/yoga: CI: treat ansible-lint warnings as errors  https://review.opendev.org/c/openstack/kolla-ansible/+/90400916:36
SvenKieskewell let me first backport the CI lint fixes ;)16:57
opendevreviewSven Kieske proposed openstack/kolla-ansible stable/2023.2: CI: fix two ansible-lint warnings  https://review.opendev.org/c/openstack/kolla-ansible/+/90401016:57
NeilHanlonmnasiadka: just wondering, how have rocky jobs been for you the last ... week or so?16:58
SvenKieskemhm, already got a merge conflict on stable/2023.1 .. :/16:58
opendevreviewSven Kieske proposed openstack/kolla-ansible stable/2023.1: CI: fix two ansible-lint warnings  https://review.opendev.org/c/openstack/kolla-ansible/+/90401117:00
SvenKieskenvm, that backport is unneeded for 2023.117:04
mnasiadkaNeilHanlon: I think they have been ok, but we haven't switched to baseurl vs mirrorlist17:57
opendevreviewSven Kieske proposed openstack/kolla-ansible stable/2023.1: provide a flag to enable quorum queues  https://review.opendev.org/c/openstack/kolla-ansible/+/90238718:01
opendevreviewMerged openstack/kolla-ansible master: Rework quorum queues precheck  https://review.opendev.org/c/openstack/kolla-ansible/+/90387119:11
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: WIP: CI: Template out kolla-build.conf using role  https://review.opendev.org/c/openstack/kolla-ansible/+/90377119:36
opendevreviewPierre Riteau proposed openstack/kayobe-config-dev master: [DNM] Testing ansible facts  https://review.opendev.org/c/openstack/kayobe-config-dev/+/90403720:59
opendevreviewPierre Riteau proposed openstack/kayobe master: [DNM] Testing ansible facts  https://review.opendev.org/c/openstack/kayobe/+/90403821:01
opendevreviewPierre Riteau proposed openstack/kayobe-config-dev master: Use dummy1 as bridge port instead of eth1  https://review.opendev.org/c/openstack/kayobe-config-dev/+/90404422:49
opendevreviewPierre Riteau proposed openstack/kayobe master: Use dummy1 as bridge port instead of eth1  https://review.opendev.org/c/openstack/kayobe/+/90404522:53

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!