| mnasiadka | somebody better tell me why kolla has docker unpinned in requirements.txt and ansible-collection-kolla installs docker<5 ;-) | 05:46 |
|---|---|---|
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Fix docker version check after docker-py>=6.0.0 https://review.opendev.org/c/openstack/kolla/+/882343 | 06:20 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: DNM: pin docker https://review.opendev.org/c/openstack/kolla/+/882333 | 06:21 |
| SvenKieske | I didn't know a program like expect does exists: https://linux.die.net/man/1/expect | 07:01 |
| mnasiadka | well, I guess best case what we can do - is wait for docker-py to sort out it's problems | 07:39 |
| SvenKieske | yeah; I mean there's an upstream PR already, I linked it in our bugreport. | 07:54 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: DNM: pin docker https://review.opendev.org/c/openstack/kolla/+/882333 | 07:59 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: DNM: pin docker https://review.opendev.org/c/openstack/kolla/+/882333 | 08:11 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: DNM: pin docker https://review.opendev.org/c/openstack/kolla/+/882333 | 08:29 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: DNM: pin docker https://review.opendev.org/c/openstack/kolla/+/882333 | 08:30 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: DNM: pin docker https://review.opendev.org/c/openstack/kolla/+/882333 | 09:03 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: CI: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882333 | 09:13 |
| SvenKieske | imho you should put a link to the upstream issue/patch into a comment near the workaround code; else workarounds tend to stick around forever, is my experience. | 09:21 |
| mnasiadka | will do, just want to make sure it passes | 09:24 |
| SvenKieske | sure, that's the reason I commented here and not on the WIP changeset :) | 09:27 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: CI: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882333 | 09:27 |
| mnasiadka | actually done, it looks like passing | 09:27 |
| mnasiadka | just to unblock master development | 09:27 |
| SvenKieske | I noticed we do not seem to use something like shellcheck for bash scripts in kolla, was this discussed previously and rejected? my personal opinion is that no one can write secure bash scripts without a good linter. | 09:29 |
| mnasiadka | what's wrong with bashate? | 09:33 |
| mnasiadka | maybe it's basic or something, if shellcheck improves anything - we can switch (after a discussion on the weekly meeting) | 09:34 |
| SvenKieske | mhm, let me have a look, I don't know "bashate" | 09:40 |
| SvenKieske | I didn't realize openstack has it's own bash linter, you never stop learning new things :D | 09:43 |
| SvenKieske | okay, if the documentation is current shellcheck supports way way more checks than bashate, which basically only enforces some indentation stuff imho, if the docs are up to date? | 09:47 |
| SvenKieske | compare: https://docs.openstack.org/bashate/latest/readme.html#currently-supported-checks with: https://gist.github.com/nicerobot/53cee11ee0abbdc997661e65b348f375 (it might be debatable if you want to enable all of shellcheck, but you can disable rules on multiple levels) | 09:48 |
| SvenKieske | for my own coding and at my old company we always used shellcheck, but it can be a bit of a pain to introduce it in older code bases | 09:49 |
| SvenKieske | I don't want to force it upon anyone though, it's a good tool, but if you are not used to it, it might feel a bit draconian at the start, because it screams at a lot of errors, like unquoted variables and so on | 09:52 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/yoga: https: remove dhparams.pem before running gencerts https://review.opendev.org/c/openstack/kolla/+/881467 | 12:02 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/yoga: https: remove dhparams.pem before running gencerts https://review.opendev.org/c/openstack/kolla/+/881467 | 12:23 |
| opendevreview | Michal Nasiadka proposed openstack/ansible-collection-kolla master: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/ansible-collection-kolla/+/882437 | 12:27 |
| opendevreview | Michal Nasiadka proposed openstack/kolla master: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882438 | 12:29 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/zed: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882394 | 14:14 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/zed: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882394 | 14:14 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882395 | 14:15 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882395 | 14:15 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/xena: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882396 | 14:17 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/xena: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882396 | 14:17 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/xena: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882396 | 14:17 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/wallaby: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882397 | 14:18 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/wallaby: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882397 | 14:18 |
| opendevreview | Michal Nasiadka proposed openstack/ansible-collection-kolla stable/zed: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/ansible-collection-kolla/+/882398 | 14:18 |
| opendevreview | Michal Nasiadka proposed openstack/ansible-collection-kolla stable/yoga: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/ansible-collection-kolla/+/882399 | 14:18 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/zed: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882394 | 14:19 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/yoga: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882395 | 14:19 |
| laz0rshi | I have a question for stackhpc, regarding pulp and repositories. Is there anyone that can direct me in the right location? * Note I am new to IRC | 14:24 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/xena: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla-ansible/+/882447 | 14:24 |
| mnasiadka | laz0rshi: I'm from StackHPC, feel free to ask on a private chat query | 14:26 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/wallaby: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla-ansible/+/882400 | 14:26 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/wallaby: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882397 | 14:27 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/xena: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882396 | 14:27 |
| opendevreview | Michal Nasiadka proposed openstack/kolla stable/wallaby: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla/+/882397 | 14:38 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/wallaby: Work around docker-py requests/urllib3 issue https://review.opendev.org/c/openstack/kolla-ansible/+/882400 | 14:39 |
| opendevreview | Maksim Malchuk proposed openstack/kolla stable/yoga: https: remove dhparams.pem before running gencerts https://review.opendev.org/c/openstack/kolla/+/881467 | 16:43 |
| opendevreview | Franco Mariotti proposed openstack/kolla-ansible master: Clarifies misleading error on ceilometer role's precheck task https://review.opendev.org/c/openstack/kolla-ansible/+/882480 | 19:28 |
| opendevreview | Franco Mariotti proposed openstack/kolla-ansible master: Clarifies misleading error on ceilometer role`s precheck task Signed-off-by: FelipeAFV <ffigueroa@whitestack.com> Change-Id: I7553ad674c6c8b4a7255cfe57c9c9eafbaec9b5a https://review.opendev.org/c/openstack/kolla-ansible/+/876599 | 19:30 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!