| frickler | mnasiadka: yoctozepto: https://review.opendev.org/c/openstack/releases/+/860521 Tag monthly kolla stable releases | 05:10 |
|---|---|---|
| opendevreview | Bartosz Bezak proposed openstack/kayobe master: Move to CentOS Stream 9 / Rocky Linux 9 https://review.opendev.org/c/openstack/kayobe/+/855656 | 07:55 |
| opendevreview | Bartosz Bezak proposed openstack/kayobe master: Move to CentOS Stream 9 / Rocky Linux 9 https://review.opendev.org/c/openstack/kayobe/+/855656 | 07:55 |
| opendevreview | Michal Nasiadka proposed openstack/kayobe master: Bump up Ansible supported versions to 5.x/6.x https://review.opendev.org/c/openstack/kayobe/+/860529 | 07:55 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/yoga: Disable c8s upgrade jobs https://review.opendev.org/c/openstack/kolla-ansible/+/860531 | 08:03 |
| mnasiadka | yoctozepto: ^^ | 08:03 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/yoga: Disable c8s upgrade jobs https://review.opendev.org/c/openstack/kolla-ansible/+/860531 | 08:08 |
| frickler | mnasiadka: do you also want to make a patch to drop the openeuler job from yoga? the old openeuler image is no longer available in infra | 08:18 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/yoga: Disable c8s upgrade jobs https://review.opendev.org/c/openstack/kolla-ansible/+/860531 | 08:23 |
| mnasiadka | bloody space | 08:23 |
| mnasiadka | frickler: I guess that makes sense | 08:23 |
| frickler | hmm, why do we lint zuul configuration at all? I've never seen anyone do that so far | 08:25 |
| mnasiadka | I think we've done it since when I remember ;) | 08:40 |
| opendevreview | Radosław Piliszek proposed openstack/kolla-ansible stable/yoga: Keystone OIDC JWKS fix https://review.opendev.org/c/openstack/kolla-ansible/+/860431 | 08:44 |
| yoctozepto | frickler: we are awesome (TM) | 08:47 |
| opendevreview | Merged openstack/kolla-ansible stable/yoga: Disable c8s upgrade jobs https://review.opendev.org/c/openstack/kolla-ansible/+/860531 | 08:50 |
| mnasiadka | yay | 08:55 |
| hrw | elo | 08:57 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible stable/xena: Enable back c8s upgrade jobs https://review.opendev.org/c/openstack/kolla-ansible/+/860535 | 09:05 |
| mnasiadka | RDO fixed Xena it seems | 09:06 |
| hrw | f8c21dbe3 (HEAD -> master) Introduce EngineAdapter | 09:06 |
| hrw | be16b9188 sq: kolla worker | 09:06 |
| hrw | fe28dd685 WIP4: tasks | 09:06 |
| hrw | a5a9d6b41 WIP3: kolla worker | 09:06 |
| hrw | e00e28d6f WIP2: status/log | 09:06 |
| hrw | b474035aa WIP1: move unbuildable | 09:06 |
| hrw | now to sort that our into proper pieces | 09:06 |
| hrw | s/our/out | 09:07 |
| yoctozepto | ++ hrw | 09:11 |
| opendevreview | Bartosz Bezak proposed openstack/kayobe master: Move to CentOS Stream 9 / Rocky Linux 9 https://review.opendev.org/c/openstack/kayobe/+/855656 | 09:31 |
| hrw | if you use vim then I recommend 'ale' plugin for syntax checking | 09:33 |
| hrw | yoctozepto: https://paste.centos.org/view/6f445e90 | 09:34 |
| hrw | https://paste.centos.org/view/19d363e5 is better | 09:35 |
| hrw | https://paste.centos.org/view/2b8149dc even (had to amend one file) | 09:35 |
| hrw | and final split: Add engine adapter module to allow additon of other container engines, | 09:43 |
| hrw | create one common EngineClient that would be called in | 09:43 |
| hrw | all other modules. | 09:43 |
| hrw | ops | 09:43 |
| hrw | and final split: https://paste.centos.org/view/319fca27 | 09:43 |
| thelounge44 | Is there anyone from the skyline team? Seems that final release is out https://github.com/openstack/skyline-console/releases/tag/1.0.0 | 09:45 |
| thelounge44 | Would be this backported to kolla ? | 09:46 |
| hrw | thelounge44: iirc we do not have skyline merged yet | 09:46 |
| thelounge44 | hrw: oh, so its planned, right? will it make it to the zed release? :) | 09:47 |
| hrw | thelounge44: https://review.opendev.org/c/openstack/kolla/+/826948 was sent, reviewed as -1 as it was very incomplete and nothing happened | 09:47 |
| hrw | so I do not see it in Zed | 09:48 |
| hrw | we are after feature freeze | 09:48 |
| yoctozepto | we can backport if it is done properly after the release, so nothing is lost, but the initial release will not ship skyline support | 09:52 |
| thelounge44 | ack, thanks | 09:52 |
| hrw | yoctozepto: can you reply in https://review.opendev.org/c/openstack/kolla/+/828716 patch? | 09:53 |
| thelounge44 | yoctozepto: do the skyline team know that is possible to backport it to zed release? seems that according to them, they are planning it to release it in next release, hope its not 2023,Q2 :( | 09:54 |
| hrw | thelounge44: anyone can add skyline support into kolla | 09:55 |
| yoctozepto | hrw: done | 09:58 |
| hrw | thx | 09:58 |
| yoctozepto | thelounge44: as hrw said; also, you can let them know it is possible | 09:58 |
| hrw | yoctozepto: this way it is not only my opinion ;) | 09:59 |
| yoctozepto | hrw: indeed | 10:02 |
| hrw | heh. split into 5 patches and now when I look at them I see that I need some changes before pushing for review | 10:04 |
| yoctozepto | oh noe | 10:04 |
| hrw | some imports need to be moved between patches | 10:05 |
| hrw | 0001 builds, 0002 will fail, 0003 works, 0004 works, 0005 works | 10:05 |
| hrw | and then one cleanup on top ;d | 10:05 |
| hrw | Does someone uses kolla in other way than: 1. kolla-build, 2. kolla/cmd/build.py or 3. tools/build.py one? | 10:06 |
| mnasiadka | I didn't even think about 2. ;) | 10:08 |
| hrw | mnasiadka: tools/build.py is a symlink to 2 ;D | 10:10 |
| yoctozepto | hrw: I only ever use kolla-build as it's the public/recommended/supported way to do stuff | 10:11 |
| hrw | cool | 10:11 |
| hrw | than cleanup makes sense | 10:12 |
| hrw | mnasiadka: https://review.opendev.org/c/openstack/kolla/+/828716 - please read comments and reply if you think it is needed | 10:12 |
| mnasiadka | we all agree, do I also need to add that such a patch needs multi-hour review in current form, from people that are doing that for free and have limited capacity? :) | 10:16 |
| hrw | https://paste.centos.org/view/656a54ef is refactor of refactor | 10:19 |
| hrw | (git log --stat only) | 10:19 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Add a way to add other container engines https://review.opendev.org/c/openstack/kolla/+/828716 | 10:21 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move info about unbuildable images to separate file https://review.opendev.org/c/openstack/kolla/+/860542 | 10:21 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move status and log related things to separate file https://review.opendev.org/c/openstack/kolla/+/860543 | 10:21 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move build related tasks to separate file https://review.opendev.org/c/openstack/kolla/+/860544 | 10:21 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move KollaWorker stuff to separate file https://review.opendev.org/c/openstack/kolla/+/860545 | 10:21 |
| hrw | go for it! | 10:21 |
| mnasiadka | let's see how CI behaves, but now it's way easier to review | 10:23 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: drop shebang from Python files https://review.opendev.org/c/openstack/kolla/+/860546 | 10:26 |
| hrw | shit. I posted version without original author info | 10:26 |
| yoctozepto | mnasiadka: might be good to say that, yes ;-) | 10:29 |
| hrw | ok, looks like broken ;d | 10:31 |
| opendevreview | Bartosz Bezak proposed openstack/kayobe master: Move to CentOS Stream 9 / Rocky Linux 9 https://review.opendev.org/c/openstack/kayobe/+/855656 | 10:35 |
| hrw | one 'git clean' too much ;( | 10:56 |
| hrw | removed whole fixed series ;( | 11:00 |
| bbezak | Hi. frickler: I can't reach any rocky-9 img in kayobe CI, for instance - mirror.mtl01.iweb.opendev.org:4447/openstack.kolla/keystone-fernet:master-rocky-9 | 11:11 |
| bbezak | it is in quay.io though - https://quay.io/repository/openstack.kolla/keystone-fernet?tab=tags | 11:11 |
| mnasiadka | bbezak: can you share a link to CI logs? | 11:12 |
| bbezak | https://zuul.opendev.org/t/openstack/build/f9ff0a06643b40dfbc6fd5328dcf2bb6/log/primary/ansible/overcloud-deploy | 11:12 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move info about unbuildable images to separate file https://review.opendev.org/c/openstack/kolla/+/860542 | 11:14 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move status and log related things to separate file https://review.opendev.org/c/openstack/kolla/+/860543 | 11:14 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move build related tasks to separate file https://review.opendev.org/c/openstack/kolla/+/860544 | 11:14 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move KollaWorker stuff to separate file https://review.opendev.org/c/openstack/kolla/+/860545 | 11:14 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Add a way to add other container engines https://review.opendev.org/c/openstack/kolla/+/828716 | 11:14 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: drop shebang from Python files https://review.opendev.org/c/openstack/kolla/+/860546 | 11:14 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: do not play with PROJECT_ROOT in build.py https://review.opendev.org/c/openstack/kolla/+/860547 | 11:14 |
| hrw | now each step should pass tox | 11:14 |
| hrw | I like the last one | 11:15 |
| bbezak | https://paste.openstack.org/show/blNokHLAAmah6jQtLtMq/ | 11:16 |
| bbezak | hmm, looks like quay.io issue? | 11:20 |
| bbezak | docker pull quay.io/openstack.kolla/keystone-fernet:master-rocky-9 | 11:20 |
| hrw | uf. so far no red on zuul | 11:26 |
| bbezak | kolla-toolbox pull works fine though - docker pull quay.io/openstack.kolla/kolla-toolbox:master-rocky-9 | 11:27 |
| bbezak | all keystone images seems to be impacted | 11:28 |
| bbezak | keaystone-ssh, keystone, keystone-fernet | 11:29 |
| bbezak | similar error in publish jobs - https://zuul.opendev.org/t/openstack/build/579db32fbd8040e99a0307ea8d330cbe | 11:39 |
| bbezak | https://zuul.opendev.org/t/openstack/builds?job_name=kolla-publish-rocky9-quay | 11:40 |
| frickler | yeah, quay.io is having some issues, also seeing the same with osism images | 11:43 |
| frickler | maybe some special handling triggered by "keystone" keyword | 11:45 |
| * yoctozepto guessing this is probably a part of an exploit as many start with an observation of weird handling of a special word ;-) | 11:51 | |
| opendevreview | Merged openstack/kolla-ansible stable/yoga: Keystone OIDC JWKS fix https://review.opendev.org/c/openstack/kolla-ansible/+/860431 | 11:55 |
| mnasiadka | bbezak, frickler: I mailed quay support, let’s see | 11:56 |
| hrw | common zuul... | 11:59 |
| hrw | come on zuul... (fixed) | 11:59 |
| opendevreview | Merged openstack/kolla-ansible stable/xena: Enable back c8s upgrade jobs https://review.opendev.org/c/openstack/kolla-ansible/+/860535 | 12:06 |
| hrw | https://review.opendev.org/q/topic:refactor%252Fengine-adapter gets first +1 from zuul | 12:33 |
| yoctozepto | gj hrw, I managed to review it all | 12:58 |
| yoctozepto | ALL | 12:58 |
| yoctozepto | :D | 12:58 |
| yoctozepto | mostly CR+2 | 12:59 |
| yoctozepto | but there are some comments of various impact | 12:59 |
| hrw | cool | 12:59 |
| yoctozepto | please have a look | 12:59 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Move build related tasks to separate file https://review.opendev.org/c/openstack/kolla/+/860544 | 13:01 |
| yoctozepto | also, two easy fixes to be done on https://review.opendev.org/c/openstack/kolla-ansible/+/860075 | 13:03 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Add a way to add other container engines https://review.opendev.org/c/openstack/kolla/+/828716 | 13:03 |
| yoctozepto | and 3 for another change (guessing mnasiadka could do the other change) | 13:03 |
| hrw | that after food | 13:04 |
| yoctozepto | enjoy your meal | 13:04 |
| hrw | yoctozepto: addressed some of your comments. rest will leave to Konstantin as engine adapter is his stuff | 13:05 |
| yoctozepto | hrw: please reply this on the change | 13:05 |
| hrw | sure | 13:05 |
| opendevreview | Radosław Piliszek proposed openstack/kolla master: Move KollaWorker stuff to separate file https://review.opendev.org/c/openstack/kolla/+/860545 | 13:05 |
| hrw | thx | 13:06 |
| hrw | bbl | 13:06 |
| opendevreview | Radosław Piliszek proposed openstack/kolla master: Add a way to add other container engines https://review.opendev.org/c/openstack/kolla/+/828716 | 13:06 |
| opendevreview | Radosław Piliszek proposed openstack/kolla master: drop shebang from Python files https://review.opendev.org/c/openstack/kolla/+/860546 | 13:07 |
| opendevreview | Radosław Piliszek proposed openstack/kolla master: do not play with PROJECT_ROOT in build.py https://review.opendev.org/c/openstack/kolla/+/860547 | 13:07 |
| yoctozepto | I fixed the bases | 13:07 |
| yoctozepto | awesome, the stack is now 1 merging, 5 CR+2 (with one minor comment/question) and 1 -1 for the engine adapter parts | 13:09 |
| yoctozepto | now it was possible to easily see, pinpoint and discuss the shortcomings of the proposal | 13:09 |
| * yoctozepto in awe | 13:09 | |
| opendevreview | Jakub Darmach proposed openstack/kolla-ansible stable/xena: Keystone OIDC JWKS fix https://review.opendev.org/c/openstack/kolla-ansible/+/860453 | 13:39 |
| opendevreview | Jakub Darmach proposed openstack/kolla-ansible stable/xena: Keystone OIDC JWKS fix https://review.opendev.org/c/openstack/kolla-ansible/+/860453 | 13:41 |
| hrw | yoctozepto: looks good | 13:47 |
| yoctozepto | mhm | 13:50 |
| opendevreview | Merged openstack/kolla master: Move info about unbuildable images to separate file https://review.opendev.org/c/openstack/kolla/+/860542 | 14:18 |
| mnasiadka | quay.io claims their nginx config is now correct | 14:34 |
| mnasiadka | bbezak: can you validate? | 14:34 |
| bbezak | yeap | 14:35 |
| bbezak | works fine | 14:35 |
| bbezak | mnasiadka: | 14:35 |
| frickler | mnasiadka: I can confirm for osism images, too. thx | 14:37 |
| opendevreview | Merged openstack/kolla master: Move status and log related things to separate file https://review.opendev.org/c/openstack/kolla/+/860543 | 14:40 |
| bbezak | thx! | 14:40 |
| hrw | 3rd patch on gate... | 14:42 |
| hrw | yoctozepto: I think that this patch(set) asks for blog post ;D | 14:43 |
| yoctozepto | hrw: hah, on your blog? /me would read it | 14:43 |
| hrw | looks like I will need to rebase two patches from series ;) | 14:46 |
| hrw | as 2 are on top of engine adapter patch | 14:47 |
| yoctozepto | hmm, if possible, please | 14:47 |
| mnasiadka | If we're discussing patches - anyone cares to review https://review.opendev.org/c/openstack/kolla-ansible/+/847769 ? ;-) | 14:47 |
| hrw | yoctozepto: let first zuul merge what can be merged | 14:48 |
| yoctozepto | hrw: ++ | 14:48 |
| yoctozepto | mnasiadka: added to review queue, seems simple enough | 14:48 |
| hrw | yoctozepto: working title is "From a diary of AArch64 porter — handling big patches" | 14:51 |
| yoctozepto | hrw: not that this has any actual relation to aarch64 ;-) but it gives an accurate description of your work profile | 14:51 |
| yoctozepto | could also mention: | 14:51 |
| yoctozepto | "how to refactor and get it merged" | 14:51 |
| hrw | yoctozepto: I plain to pinpoint to some aarch64 ones in past | 14:52 |
| yoctozepto | with a big sentence in red telling to do no refactor-wise-unnecessary changes | 14:52 |
| yoctozepto | ack | 14:52 |
| hrw | yoctozepto: also it makes it visible with other in series. look at https://marcin.juszkiewicz.com.pl/2020/09/16/from-a-diary-of-aarch64-porter-drive-by-coding/ for example. | 14:54 |
| hrw | yoctozepto: at top you have a list of other entries | 14:55 |
| yoctozepto | makes sense | 14:56 |
| opendevreview | Michal Nasiadka proposed openstack/kolla-ansible master: CI: Fix init-swift https://review.opendev.org/c/openstack/kolla-ansible/+/858669 | 14:58 |
| yoctozepto | mnasiadka: https://review.opendev.org/c/openstack/kolla-ansible/+/858669 see my comment - that should make it more digestible | 15:42 |
| yoctozepto | and actually limit the scope to the right scenario | 15:42 |
| opendevreview | Merged openstack/kolla master: Move build related tasks to separate file https://review.opendev.org/c/openstack/kolla/+/860544 | 15:46 |
| hrw | 3rd | 15:51 |
| opendevreview | Merged openstack/kolla master: Move KollaWorker stuff to separate file https://review.opendev.org/c/openstack/kolla/+/860545 | 16:03 |
| hrw | 4rd | 16:05 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: drop shebang from Python files https://review.opendev.org/c/openstack/kolla/+/860546 | 16:06 |
| hrw | rebased on master | 16:06 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: do not play with PROJECT_ROOT in build.py https://review.opendev.org/c/openstack/kolla/+/860547 | 16:27 |
| opendevreview | Marcin Juszkiewicz proposed openstack/kolla master: Add a way to add other container engines https://review.opendev.org/c/openstack/kolla/+/828716 | 16:27 |
| hrw | reversed order | 16:27 |
| hrw | so we can merge PROJECT_ROOT one | 16:27 |
| yoctozepto | mnasiadka: done https://review.opendev.org/c/openstack/kolla-ansible/+/847769 | 16:29 |
| yoctozepto | hrw: have you checked the answer to my comment on https://review.opendev.org/c/openstack/kolla/+/860546 ? | 16:30 |
| * yoctozepto too lazy to check myself | 16:30 | |
| hrw | file permissions? | 16:30 |
| hrw | tools/build.py and common/config.py have +x | 16:31 |
| hrw | tried to take it down and failed | 16:31 |
| yoctozepto | hmm | 16:32 |
| yoctozepto | odd | 16:32 |
| opendevreview | Radosław Piliszek proposed openstack/kolla master: Drop executable perms from non-executables https://review.opendev.org/c/openstack/kolla/+/860592 | 16:35 |
| yoctozepto | hrw: ^ | 16:36 |
| * yoctozepto off | 16:38 | |
| hrw | https://marcin.juszkiewicz.com.pl/2022/10/06/from-a-diary-of-aarch64-porter-handling-big-patches/ | 16:44 |
| opendevreview | Merged openstack/kolla-ansible stable/xena: Keystone OIDC JWKS fix https://review.opendev.org/c/openstack/kolla-ansible/+/860453 | 16:51 |
| opendevreview | Merged openstack/kolla master: drop shebang from Python files https://review.opendev.org/c/openstack/kolla/+/860546 | 18:48 |
| opendevreview | Jakub Darmach proposed openstack/kolla-ansible stable/wallaby: Keystone OIDC JWKS fix https://review.opendev.org/c/openstack/kolla-ansible/+/860469 | 19:26 |
| opendevreview | Jakub Darmach proposed openstack/kolla-ansible stable/wallaby: Keystone OIDC JWKS fix https://review.opendev.org/c/openstack/kolla-ansible/+/860469 | 19:27 |
| hrw | mnasiadka: https://review.opendev.org/c/openstack/kolla/+/860547 | 21:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!