Thursday, 2021-08-12

*** rpittau|afk is now known as rpittau06:22
opendevreviewMichal Arbet proposed openstack/kolla master: Allow build debian/ubuntu-binary cloudkitty images  https://review.opendev.org/c/openstack/kolla/+/79743306:40
opendevreviewMichal Arbet proposed openstack/kolla master: ironic-neutron-agent: enable for Debuntu binary  https://review.opendev.org/c/openstack/kolla/+/79961107:00
opendevreviewMichal Arbet proposed openstack/kolla master: Allow build debian/ubuntu-binary cloudkitty images  https://review.opendev.org/c/openstack/kolla/+/79743307:03
kevko\o/07:05
mgoddardmorning07:45
mgoddardyoctozepto: I think your framework is actually a toolkit07:45
mgoddardhttps://martinfowler.com/bliki/InversionOfControl.html07:46
opendevreviewMark Goddard proposed openstack/kayobe-config-dev stable/wallaby: Support specifying a Kayobe environment to use  https://review.opendev.org/c/openstack/kayobe-config-dev/+/80433207:56
opendevreviewMark Goddard proposed openstack/kayobe-config-dev stable/wallaby: Support reading Kayobe environment name from file  https://review.opendev.org/c/openstack/kayobe-config-dev/+/80433307:56
opendevreviewMark Goddard proposed openstack/kolla-ansible stable/wallaby: fluentd: Fix check for external elasticsearch  https://review.opendev.org/c/openstack/kolla-ansible/+/80433407:57
kevkohello guys ..07:59
opendevreviewMark Goddard proposed openstack/kolla-ansible stable/victoria: fluentd: Fix check for external elasticsearch  https://review.opendev.org/c/openstack/kolla-ansible/+/80435708:00
kevkoi was just testing upgrade nova (compute part - two computes) and I wonder why from 5 instances 2 instances are shutdown (compute0,compute1) while other instances are normally alive  ? I know that it's no kolla related ...but have you seen anyone before ? 08:01
kevkonormally i am migrating all to another compute ..but i was curious if it is OK to upgrade online 08:01
opendevreviewPierre Riteau proposed openstack/kolla master: [release] Use RDO master Delorean packages  https://review.opendev.org/c/openstack/kolla/+/80426908:07
priteaumgoddard: I thought of a simpler approach for the neutron api-paste kolla/kolla-ansible dependency08:08
priteauI can switch to xena and keep using the old file location for now08:08
opendevreviewPierre Riteau proposed openstack/kolla-ansible master: Use api-paste.ini from /etc/neutron  https://review.opendev.org/c/openstack/kolla-ansible/+/80428808:11
priteauSorry for the double review08:13
yoctozeptomgoddard: well, the project's certainly both as it is meant to deliver the tools as well as the framework (the framework "frames" [defines] the way of thinking or working with it)08:14
mgoddardthe code it produced would not be a framework08:14
yoctozeptomgoddard: the way to structure the roles would be08:15
mgoddardit's almost the opposite08:15
mgoddardif we allowed users to replace the service* roles with their own, we could call kolla-ansible a framework08:16
mgoddardbut we won't do that08:16
yoctozeptoI think you are drawing a wrong boundary; the boundary is on project roles; the service roles compose the accompanying toolkit08:17
mgoddardthe project roles are not a framework, since the service roles are not intended to be replaceable08:19
yoctozeptomoreover, this framework is shifting towards accepting more declarative than imperative code08:19
mgoddardagreed, service roles are a toolkit08:19
yoctozeptoyes, that we agree on :-)08:19
yoctozeptothe way we enforce the structure of the project roles is the framework08:20
yoctozeptohttps://en.wikipedia.org/wiki/Software_framework08:20
mgoddardas a user of a framework, I do not modify the framework code. I plug my code into it, and it executes my code at the right time08:20
mgoddardthere is no other code in our case, only config08:21
mgoddardwe're just building an application (kolla-ansible) that uses a toolkit (service-*), and accepts config08:21
yoctozeptothe config is code; the code is config08:22
mgoddardsort of, but I draw a distinction between globals.yml and a playbook/role08:22
mgoddardespecially since users modify globals.yml, but not playbooks or roles08:23
yoctozeptoyes, but notice the framework is not for users of kolla-ansible but for us, cores, and contributors, and extenders, and general tinkerers08:24
yoctozeptoit is about maintainability and extensibility with DRY08:24
yoctozeptoand I assure you it matches the definition of a framework08:24
mgoddardI disagree08:25
mgoddarddespite your assurances08:25
mgoddardperhaps you have some additional magic planned08:27
mgoddardif you can demonstrate inversion of control, I may come around08:28
yoctozeptothe way we have dedicated playbooks per kolla ansible action is actually a way of ioc possible in ansible08:33
yoctozeptothis is already a part of the "latent framework" that I discuss there08:33
yoctozeptodo note we are not dealing with a general purpose programming language exercise here so comparing with, e.g., web frameworks is going to be blurry ;-)08:35
mgoddardhere's how I see a framework working in ansible08:41
mgoddardit includes a playbook08:41
mgoddardand includes a role with a dynamic name08:41
mgoddardas a user of the framework, you provide a role name via a variable08:41
mgoddardthe role must accept specific variable names08:42
mgoddardthe playbook might setup a DB, LB and app server08:42
mgoddardand your role deploys your code08:43
mgoddardobviously a basic example, but the key point is that the framework's playbook is in control, and calls out to code provided by the developer08:43
mgoddardanyway, enough debate. There's time to change my mind08:46
yoctozeptoyeah, we call out to provided roles using chosen playbook as an entry point, the role should consume certain variables - all in check - the latent framework is already here :-)08:48
mgoddarddisagree08:49
mgoddardI cannot add a new role without modifying the playbook08:49
yoctozeptoyes, because this one part is rigid now08:51
yoctozeptowe can agree that the framework is handicapped for now08:51
mgoddardit's just a pattern08:51
yoctozepto... that you must follow to get it right08:52
yoctozeptoyou can abuse web frameworks as well08:52
yoctozeptosome assumptions are only in docs08:53
yoctozeptonot verifiable by the framework08:53
yoctozeptoit's just how life goes :-)08:53
yoctozeptoin ansible it's even worse08:53
yoctozeptook, enough debate really; whatever we call it's meant to increase the productivity and not start flame wars :-)08:53
jingvarhi! can someone help to undertand how to run node config generator ("fake")09:02
mnasiadkaI love academic debates in the morning ;)09:02
kevkofinally there is some discussion to read :D 09:10
opendevreviewMichal Arbet proposed openstack/kolla master: Allow build debian/ubuntu-binary cloudkitty images  https://review.opendev.org/c/openstack/kolla/+/79743309:13
kevko./tools/kolla-ansible -i /etc/kolla/inventory upgrade -t neutron --limit compute <<< should this run following tasks ? 09:14
kevkoRunning Neutron database expand container09:14
kevkoChecking neutron pending contract scripts09:14
kevkoStopping all neutron-server for contract db09:14
kevkoetc.. ? 09:14
kevkobecause firstly it is failing ..and secondly ..i think it should not run any db migrations if limiting to compute group, shouln't it ? 09:15
yoctozeptohmm, indeed it seems weird to match these tasks on computes09:17
opendevreviewMerged openstack/kolla master: Fix naming of CentOS Stream in reno  https://review.opendev.org/c/openstack/kolla/+/80425109:17
yoctozeptoconsider it a bug and fix09:17
opendevreviewRadosław Piliszek proposed openstack/kolla stable/wallaby: Fix naming of CentOS Stream in reno  https://review.opendev.org/c/openstack/kolla/+/80433609:18
opendevreviewRadosław Piliszek proposed openstack/kolla-ansible stable/ussuri: fluentd: Fix check for external elasticsearch  https://review.opendev.org/c/openstack/kolla-ansible/+/80433709:20
mgoddardit's due to run_once09:23
mgoddardideal solution would be a separate play/role, similar to nova/nova-cell09:24
mgoddardbut that's a bigger job09:24
yoctozeptowe love ansible quirks09:33
mnasiadkadoes it mean we should split all roles into -server and -agent side? :)09:33
yoctozeptowould not hurt :-)09:34
yoctozeptoping cores on https://review.opendev.org/c/openstack/kolla-ansible/+/787875 -  feedback welcome09:44
kevkomnasiadka: so you want to generate new bugs :) ? 09:45
mnasiadkakevko: if we decide it's boring enough to do so - why not ;)09:45
mgoddardmost roles don't have a compute component, but those that do might be good to split09:56
mgoddardat least from a performance perspective09:57
yoctozeptoindeed, due to how ansible works09:59
yoctozeptoin fact, it makes sense because the *role* to be a compute target is different from being a controller10:00
yoctozeptoour default split is service-centric instead of node-centric10:00
yoctozeptoand this causes hiccups10:00
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Validate if running CentOS OS is CentOS Stream  https://review.opendev.org/c/openstack/kolla-ansible/+/80407210:08
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Trivial fix nova's healthchecks  https://review.opendev.org/c/openstack/kolla-ansible/+/80438111:18
kevko^^ please approve this after zuul +1 as this is very trivial fix11:19
yoctozeptokevko: commented11:38
kevkoyoctozepto: aaaa, i forgot 11:39
kevkodone11:40
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Trivial fix nova's healthchecks  https://review.opendev.org/c/openstack/kolla-ansible/+/80438111:40
opendevreviewMichal Nasiadka proposed openstack/kolla-ansible master: Validate if running CentOS OS is CentOS Stream  https://review.opendev.org/c/openstack/kolla-ansible/+/80407212:03
opendevreviewRadosław Piliszek proposed openstack/kolla-ansible master: Validate if running CentOS OS is CentOS Stream  https://review.opendev.org/c/openstack/kolla-ansible/+/80407212:45
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix neutron upgrade when running with limit  https://review.opendev.org/c/openstack/kolla-ansible/+/80438413:24
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Fix neutron upgrade when running with limit  https://review.opendev.org/c/openstack/kolla-ansible/+/80438413:26
yoctozeptomgoddard: not triggered by Ironic being called a framework? :-)14:04
mgoddardin this case, not so much!14:04
yoctozeptobut still a bit I see! haha14:05
mgoddardthe driver model is closer to a framework14:05
opendevreviewMichal Arbet proposed openstack/kolla-ansible master: Use Docker healthchecks for nova-spicehtml5proxy service  https://review.opendev.org/c/openstack/kolla-ansible/+/80439114:20
kevkoyoctozepto: what do you mean because of ansible quirk ? 14:22
kevkoyoctozepto: i was testing it and it's working ..but not saying it is wrong approach from my side 14:22
jingvarI see Mark :)14:26
yoctozeptokevko: https://github.com/ansible/ansible/issues/1149614:28
yoctozeptomgoddard can confirm14:29
kevkook, i will rework then14:30
kevkobut i've sent you already another trivial patch :P14:30
opendevreviewPierre Riteau proposed openstack/kayobe master: Fix documentation links for routed control plane networks  https://review.opendev.org/c/openstack/kayobe/+/80439814:52
opendevreviewPierre Riteau proposed openstack/kayobe master: Fix documentation links for routed control plane networks  https://review.opendev.org/c/openstack/kayobe/+/80439815:03
*** rpittau is now known as rpittau|afk15:31
opendevreviewMerged openstack/kolla stable/wallaby: Fix naming of CentOS Stream in reno  https://review.opendev.org/c/openstack/kolla/+/80433615:38
yoctozeptoheads-up: we are going to retire murano (cc mgoddard who had this wish)15:55
yoctozepto(continue wishing)15:55
opendevreviewRadosław Piliszek proposed openstack/kolla-ansible master: Bump libvirtd memlock ulimit  https://review.opendev.org/c/openstack/kolla-ansible/+/80445018:39
opendevreviewRadosław Piliszek proposed openstack/kolla-ansible master: [CI] Fix Debian upgrade  https://review.opendev.org/c/openstack/kolla-ansible/+/80445519:15
opendevreviewRadosław Piliszek proposed openstack/kolla-ansible master: Detect outward-rabbitmq and rabbitmq group overlaps  https://review.opendev.org/c/openstack/kolla-ansible/+/80174719:20

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!