*** mixor has joined #openstack-kolla | 00:02 | |
*** mixor has quit IRC | 01:58 | |
*** calbers has quit IRC | 02:06 | |
*** calbers has joined #openstack-kolla | 02:09 | |
*** BjoernT has joined #openstack-kolla | 02:11 | |
openstackgerrit | caoyuan proposed openstack/kolla-cli master: tox: Move the whitelist_externals to testenv section https://review.opendev.org/688306 | 03:06 |
---|---|---|
openstackgerrit | Merged openstack/kolla-cli master: tox: Move the whitelist_externals to testenv section https://review.opendev.org/688306 | 03:43 |
*** k_mouza has joined #openstack-kolla | 03:43 | |
*** k_mouza has quit IRC | 03:48 | |
*** dave-mccowan has quit IRC | 04:18 | |
*** BjoernT has quit IRC | 04:24 | |
openstackgerrit | jacky06 proposed openstack/kolla-cli master: Add --hosts support for check action https://review.opendev.org/688325 | 04:43 |
openstackgerrit | caoyuan proposed openstack/kolla-cli master: Add --hosts support for check action https://review.opendev.org/688325 | 05:03 |
openstackgerrit | caoyuan proposed openstack/kolla-cli master: Add --hosts flag into deploy unit test https://review.opendev.org/688327 | 05:29 |
openstackgerrit | Eddie Yen proposed openstack/kolla master: Add disk dev name check function https://review.opendev.org/688328 | 05:32 |
openstackgerrit | Merged openstack/kolla-cli master: Add --hosts support for check action https://review.opendev.org/688325 | 05:35 |
openstackgerrit | Dincer Celik proposed openstack/kolla-ansible stable/stein: Remove /etc/hosts entries pointing hostname to localhost and prevent cloud-init to manage /etc/hosts https://review.opendev.org/688329 | 05:35 |
*** jbadiapa has joined #openstack-kolla | 05:36 | |
openstackgerrit | Eddie Yen proposed openstack/kolla master: Add disk dev name check function https://review.opendev.org/688328 | 05:39 |
openstackgerrit | caoyuan proposed openstack/kolla-cli master: Add --hosts flag into deploy unit test https://review.opendev.org/688327 | 05:48 |
*** cah_link has joined #openstack-kolla | 06:06 | |
openstackgerrit | caoyuan proposed openstack/kolla-cli master: Add --hosts flag into deploy unit test https://review.opendev.org/688327 | 06:06 |
*** dpawlik has joined #openstack-kolla | 06:23 | |
*** pcaruana has joined #openstack-kolla | 06:43 | |
mnasiadka | morning | 07:11 |
*** gfidente has joined #openstack-kolla | 07:37 | |
*** rpittau|afk is now known as rpittau | 07:40 | |
openstackgerrit | Michal Nasiadka proposed openstack/kolla master: DNM: Train RDO RC testing https://review.opendev.org/687615 | 07:41 |
*** ivve has joined #openstack-kolla | 07:46 | |
yoctozepto | morning | 07:47 |
mnasiadka | seems we should be good with RDO, the only unbuildable thing is tripleoclient due to the fact tripleo did not do an RC yet | 07:53 |
*** gfidente has quit IRC | 07:59 | |
*** dpawlik has quit IRC | 08:03 | |
*** dougsz has joined #openstack-kolla | 08:06 | |
*** iniazi_ has joined #openstack-kolla | 08:09 | |
*** iniazi has quit IRC | 08:12 | |
*** k_mouza has joined #openstack-kolla | 08:12 | |
*** kevinz has joined #openstack-kolla | 08:14 | |
hrw | gooooood | 08:24 |
hrw | morning | 08:24 |
*** rgogunskiy has joined #openstack-kolla | 08:24 | |
yoctozepto | mnasiadka: nice :-) | 08:32 |
mnasiadka | although I see UCA is not in the same state :D | 08:32 |
mnasiadka | hmm, seems Ceph broke at some point - maybe after changing the keys a bit | 08:34 |
yoctozepto | mnasiadka: broken where | 08:42 |
openstackgerrit | Radosław Piliszek proposed openstack/kolla-ansible master: Set RabbitMQ cluster_partition_handling to pause_minority https://review.opendev.org/672562 | 08:42 |
*** kevinz has quit IRC | 08:44 | |
openstackgerrit | Radosław Piliszek proposed openstack/kolla-ansible master: Set RabbitMQ cluster_partition_handling to pause_minority https://review.opendev.org/672562 | 08:44 |
hrw | mnasiadka: will we manage to move kolla-ansible to use py3 in Ussuri? | 08:44 |
mnasiadka | yoctozepto: http://zuul.openstack.org/build/2e89e20098ef45fb876209ae3d3f700a/log/primary/logs/ansible/deploy#57925 | 08:45 |
mnasiadka | hrw: first we need to identify what needs to be done :-) | 08:45 |
hrw | D: | 08:49 |
*** gfidente has joined #openstack-kolla | 08:51 | |
hrw | fsck. managed to remove my _do_all_to_deploy.sh script | 08:54 |
yoctozepto | hrw: happens | 08:54 |
hrw | and it expired from paste.debian ;( | 08:54 |
yoctozepto | mnasiadka: ah yeah, looking bad | 08:55 |
yoctozepto | hrw: :< | 08:55 |
openstackgerrit | caoyuan proposed openstack/kolla-cli master: Add Generating Documentation https://review.opendev.org/688355 | 08:59 |
mnasiadka | yoctozepto: well, I haven't touched that in any change, so that is even more interesting | 08:59 |
yoctozepto | mnasiadka: ubuntu b0rken? | 09:01 |
mnasiadka | yoctozepto: seems so, like some path missing... | 09:05 |
mnasiadka | but fetch_ceph_keys.py is in /usr/bin/ | 09:06 |
mnasiadka | gah | 09:06 |
hrw | meh... | 09:07 |
hrw | (venv3) 09:06 (0s) hrw@j13-qrep-04:kolla-ansible$ kolla-genpwd -p $PWD/hrw/passwords.yml | 09:08 |
hrw | FileNotFoundError: [Errno 2] No such file or directory: '/home/hrw/devel/kolla/kolla-ansible/hrw/passwords.yml' | 09:08 |
hrw | (venv3) 09:06 (0s) hrw@j13-qrep-04:kolla-ansible$ touch hrw/passwords.yml | 09:08 |
hrw | (venv3) 09:08 (0s) hrw@j13-qrep-04:kolla-ansible$ kolla-genpwd -p $PWD/hrw/passwords.yml | 09:08 |
hrw | AttributeError: 'NoneType' object has no attribute 'items' | 09:08 |
hrw | so to generate passwords I need to generate passwords? | 09:08 |
yoctozepto | hrw: it needs the template used | 09:10 |
yoctozepto | it's kind of counterintuitive | 09:10 |
yoctozepto | but yeah | 09:10 |
hrw | thanks | 09:10 |
stingrayza | morning folks o/ | 09:12 |
*** dpawlik has joined #openstack-kolla | 09:13 | |
*** dpawlik has quit IRC | 09:18 | |
*** skramaja has joined #openstack-kolla | 09:20 | |
openstackgerrit | Will Szumski proposed openstack/kayobe master: format pxe_append_params as string and not a list https://review.opendev.org/688102 | 09:21 |
openstackgerrit | Will Szumski proposed openstack/kayobe master: Fix issue with image download when checksum url is none https://review.opendev.org/688359 | 09:21 |
openstackgerrit | Will Szumski proposed openstack/kayobe master: format pxe_append_params as string and not a list https://review.opendev.org/688102 | 09:22 |
*** vmixor has joined #openstack-kolla | 09:23 | |
openstackgerrit | Will Szumski proposed openstack/kayobe master: Fix issue with image download when checksum url is none https://review.opendev.org/688359 | 09:24 |
hrw | ~hail 96GB ram for allowing /var/lib/docker to be in tmpfs | 09:25 |
openstackgerrit | Will Szumski proposed openstack/kayobe-config-dev master: DNM: Switch to CentOS based IPA images https://review.opendev.org/687830 | 09:25 |
yoctozepto | mnasiadka: yup, http://zuul.openstack.org/builds?job_name=kolla-ansible-ubuntu-source-ceph&branch=master | 09:29 |
yoctozepto | very b0rken | 09:29 |
*** dpawlik has joined #openstack-kolla | 09:30 | |
yoctozepto | only https://review.opendev.org/687544 to blame mnasiadka | 09:31 |
yoctozepto | though needs investigating why | 09:31 |
*** brtknr_ has quit IRC | 09:31 | |
mnasiadka | yoctozepto: well, and it caused no such file or directory when running a python script? :D | 09:31 |
*** brtknr has joined #openstack-kolla | 09:32 | |
yoctozepto | mnasiadka: hint: upgrades not broken http://zuul.openstack.org/builds?job_name=kolla-ansible-ubuntu-source-ceph&branch=master&job_name=kolla-ansible-ubuntu-source-upgrade-ceph# | 09:32 |
yoctozepto | well, no idea | 09:32 |
yoctozepto | could be something the script wants | 09:32 |
mnasiadka | https://www.irccloud.com/pastebin/lKmGRdBp/ | 09:32 |
mnasiadka | bingo | 09:32 |
yoctozepto | but only fresh deploys are affected | 09:32 |
yoctozepto | mnasiadka: yeah but that is a lol | 09:33 |
hrw | how could you run unversioned python... | 09:33 |
yoctozepto | as how could your change break that then | 09:33 |
mnasiadka | it's not my change - I guess we stopped installing python2 in ubuntu images? | 09:33 |
mgoddard | morning all | 09:33 |
hrw | mnasiadka: s/python2/unversioned-python/ even | 09:34 |
yoctozepto | but when mnasiadka | 09:34 |
yoctozepto | you mean ubuntu stopped shipping it for us by default? | 09:34 |
yoctozepto | morning mgoddard | 09:34 |
yoctozepto | both bosses agree to your trip to Białystok? :-) | 09:35 |
hrw | speaking of it... | 09:35 |
yoctozepto | today/tomorrow I should know if we are going to do it this month | 09:35 |
hrw | how many days we want for it? | 09:35 |
yoctozepto | yeah, that's important too, as it makes coordination different | 09:36 |
hrw | and can we do it on 6th Nov? so I can go for Red Hat Forum 2019 Warsaw on 5th and next day drive to Białystok | 09:36 |
yoctozepto | hrw: thanks for reminding | 09:37 |
yoctozepto | I should register immediately | 09:38 |
hrw | yoctozepto: RHF? | 09:38 |
yoctozepto | hrw: yup | 09:41 |
yoctozepto | hrw: 6th Nov is actually bad as I have a doctor's appointment then, at least during the morning and then depends on how I feel :-) | 09:44 |
hrw | yoctozepto: 6th as 'let arrive in Białystok' and then 7-8th meetings, 9th go home | 09:44 |
yoctozepto | sounds like a plan | 09:46 |
yoctozepto | mnasiadka, mgoddard: ^ if you could confirm that | 09:46 |
yoctozepto | I would be able to work on detail | 09:46 |
yoctozepto | details* | 09:46 |
mnasiadka | Let's await mgoddard's attention :) | 09:48 |
mgoddard | just speaking to boss 1 | 09:48 |
mnasiadka | hrw: so, we have python2.7 in CentOS and python3 in Ubuntu - what should I use so it works on both? :D | 09:48 |
mnasiadka | mgoddard: well, you can include me in the financial plan ;) | 09:48 |
hrw | mnasiadka: proper ansible tasks to be sure that you have unversioned python installed? | 09:49 |
mnasiadka | hrw: ugh, I’ll probably rework that crap and get rid of this python cli script | 09:55 |
hrw | ;D | 09:55 |
openstackgerrit | Viktor Michalek proposed openstack/kolla-ansible master: Neutron: Added option to force legacy iptables in neutron_openvswitch_agent https://review.opendev.org/685967 | 09:57 |
*** k_mouza has quit IRC | 10:07 | |
hrw | INFO:kolla.common.utils.aodh-api:Trying to push the image | 10:12 |
hrw | ERROR:kolla.common.utils.aodh-api:Get http://10.101.16.1:5000/v2/: dial tcp 10.101.16.1:5000: connect: no route to host | 10:12 |
hrw | INFO:kolla.common.utils.aodh-api:Pushed successfully | 10:12 |
hrw | ;D | 10:12 |
hrw | have to take a look at code... | 10:13 |
mnasiadka | lol | 10:19 |
hrw | another piece of kolla code where technical debt has to be paid | 10:20 |
openstackgerrit | jacky06 proposed openstack/kolla-ansible master: tox: Keeping going with docs https://review.opendev.org/688371 | 10:21 |
mgoddard | hrw: was it a retry? | 10:22 |
hrw | mgoddard: first. my builds do not retry | 10:22 |
openstackgerrit | jacky06 proposed openstack/kolla master: tox: Keeping going with docs https://review.opendev.org/688373 | 10:24 |
*** k_mouza has joined #openstack-kolla | 10:27 | |
openstackgerrit | Will Szumski proposed openstack/kolla-ansible master: Add extras directory to prometheus config https://review.opendev.org/688374 | 10:28 |
openstackgerrit | jacky06 proposed openstack/kolla master: tox: Keeping going with docs https://review.opendev.org/688373 | 10:33 |
hrw | and I see why it goes that way | 10:34 |
hrw | in case of error set status to error. and then set to built anyway | 10:37 |
openstackgerrit | Eddie Yen proposed openstack/kolla master: Add disk dev name check function https://review.opendev.org/688328 | 10:43 |
hrw | INFO:kolla.common.utils.base:Trying to push the image | 10:48 |
hrw | ERROR:kolla.common.utils.base:Get https://some.example.com:8432/v2/: dial tcp: lookup some.example.com: no such host | 10:48 |
hrw | INFO:kolla.common.utils:=========================== | 10:48 |
hrw | INFO:kolla.common.utils:Images that failed to build | 10:48 |
hrw | INFO:kolla.common.utils:=========================== | 10:48 |
hrw | ERROR:kolla.common.utils:base Failed with status: push_error | 10:48 |
hrw | now it looks better | 10:48 |
yoctozepto | hrw: ah, mgoddard "fixed" that and I accepted :D | 10:52 |
yoctozepto | see https://review.opendev.org/683200 | 10:52 |
yoctozepto | well, you did too | 10:53 |
yoctozepto | the technical is "to be paid" as always | 10:53 |
yoctozepto | debt* | 10:53 |
yoctozepto | ;D | 10:53 |
hrw | check http://paste.debian.net/1106572/ | 10:53 |
yoctozepto | exceptions ftw | 10:54 |
hrw | if there is an error during push then raise up and consider it done | 10:54 |
yoctozepto | what about retries though, sir | 10:54 |
hrw | retries should be forbidden ;D | 10:55 |
yoctozepto | xD | 10:55 |
hrw | tested - it just retries | 10:59 |
hrw | INFO:kolla.common.utils:Attempt number: 4 to run task: PushTask(base) | 11:00 |
hrw | INFO:kolla.common.utils.base:Trying to push the image | 11:00 |
hrw | ERROR:kolla.common.utils.base:Get https://some.example.com:8432/v2/: dial tcp: lookup some.example.com: no such host | 11:00 |
hrw | 1/2/3/4 | 11:00 |
openstackgerrit | Eddie Yen proposed openstack/kolla master: Add disk dev name check function https://review.opendev.org/688328 | 11:01 |
hrw | btw - kolla/image/build.py will probably need split as it has 1481 lines already | 11:01 |
openstackgerrit | Merged openstack/kolla-ansible stable/stein: Remove /etc/hosts entries pointing hostname to localhost and prevent cloud-init to manage /etc/hosts https://review.opendev.org/688329 | 11:04 |
yoctozepto | it does | 11:08 |
*** dswebb has quit IRC | 11:10 | |
*** kplant has joined #openstack-kolla | 11:16 | |
mgoddard | hrw: change looks sensible. use logger.exception rather than logger.error though | 11:18 |
hrw | mgoddard: good catch | 11:18 |
*** pcaruana has quit IRC | 11:34 | |
*** dave-mccowan has joined #openstack-kolla | 11:39 | |
*** pcaruana has joined #openstack-kolla | 11:41 | |
hrw | mgoddard: no. logger.error is proper. logger.exception shows traceback which is not relevant here | 11:44 |
*** k_mouza has quit IRC | 11:46 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/kolla master: handle push error properly https://review.opendev.org/688390 | 11:46 |
*** k_mouza has joined #openstack-kolla | 11:47 | |
*** hjensas has quit IRC | 11:54 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/kolla master: handle push error properly https://review.opendev.org/688390 | 12:02 |
hrw | yoctozepto: can you extend what you mean about commit message? | 12:02 |
yoctozepto | hrw: the change id is above your message | 12:04 |
yoctozepto | and they got treated as tags in there | 12:04 |
hrw | moved | 12:04 |
yoctozepto | and about the revert - it should be in the commit message for posterity | 12:05 |
yoctozepto | and is it possible to have this tested | 12:05 |
yoctozepto | removing unit tests is a bad practice ;p | 12:05 |
*** FlorianFa has joined #openstack-kolla | 12:05 | |
hrw | have to check it ;d | 12:06 |
openstackgerrit | Michal Nasiadka proposed openstack/kolla-ansible master: Allow fetch ceph keyrings to work with unversioned python binary https://review.opendev.org/688392 | 12:07 |
openstackgerrit | Will Szumski proposed openstack/kolla-ansible master: Add extras directory to prometheus config https://review.opendev.org/688374 | 12:12 |
*** jroll has quit IRC | 12:14 | |
*** jroll has joined #openstack-kolla | 12:15 | |
yoctozepto | mgoddard, mnasiadka: quick for review: https://review.opendev.org/672562 | 12:20 |
yoctozepto | "quickie" ;-) | 12:20 |
mgoddard | yoctozepto: did you look at the issue raised by noxoid? | 12:21 |
yoctozepto | mgoddard: I could not reproduce | 12:21 |
yoctozepto | and no google results | 12:21 |
yoctozepto | nothing I can do | 12:21 |
yoctozepto | but we surely need this done as default | 12:22 |
yoctozepto | at lest in all new deployments | 12:22 |
*** schwicht has joined #openstack-kolla | 12:24 | |
openstackgerrit | Will Szumski proposed openstack/kayobe master: Fix issue with image download when checksum url is none https://review.opendev.org/688359 | 12:25 |
*** devep has joined #openstack-kolla | 12:25 | |
mgoddard | yoctozepto: did you speak to noxoid about it? | 12:26 |
yoctozepto | mgoddard: hmm, in all my wisdom I have forgot about this simple thing | 12:27 |
mgoddard | yoctozepto: communication :) | 12:27 |
yoctozepto | noxoid: please let me know if there are any details regarding the partitioning control in rabbitmq - just ping me :-) | 12:28 |
yoctozepto | mgoddard: yeah, I usually remember | 12:28 |
yoctozepto | too much ipv6 | 12:28 |
yoctozepto | and having said that, I think you should review that sooner than later ;-) | 12:28 |
*** schwicht has quit IRC | 12:30 | |
openstackgerrit | Merged openstack/kolla-ansible master: Do not install ntp package on host when not used https://review.opendev.org/688270 | 12:32 |
*** schwicht has joined #openstack-kolla | 12:33 | |
mgoddard | yoctozepto: I'll scratch yours if you scratch mine ;) | 12:34 |
mgoddard | (cells) | 12:34 |
yoctozepto | mgoddard: yeah, I have it open in a tab | 12:34 |
yoctozepto | but mine is simpler | 12:35 |
mgoddard | I'm currently writing docs | 12:35 |
yoctozepto | trust me | 12:35 |
mgoddard | no doubt, but I have already given you one review :p | 12:35 |
yoctozepto | oh and docs are being written | 12:35 |
yoctozepto | true | 12:35 |
mgoddard | complexity is why I'd like reviews sooner than later | 12:35 |
yoctozepto | ok, so we will be trading w+1s now | 12:35 |
yoctozepto | :D | 12:35 |
mgoddard | especially as I'm out thursday and friday this week | 12:35 |
yoctozepto | oh my, then it's top prio :O | 12:36 |
*** sm806 has quit IRC | 12:36 | |
*** sm806 has joined #openstack-kolla | 12:37 | |
mgoddard | dougsz should be around though | 12:37 |
dougsz | 👍 | 12:39 |
*** schwicht has quit IRC | 12:46 | |
hrw | btw - https://review.opendev.org/#/c/399426/ is interesting | 12:49 |
hrw | speaking of out... I will skip Wed meeting | 12:50 |
openstackgerrit | Marcin Juszkiewicz proposed openstack/kolla master: handle push error properly https://review.opendev.org/688390 | 12:53 |
hrw | just added bug | 12:54 |
*** dswebb has joined #openstack-kolla | 12:54 | |
yoctozepto | hrw: why is that interesting? | 12:55 |
hrw | yoctozepto: bug shown sensible usecase | 12:56 |
hrw | the 'I am in internal network and the only registry I have requires login but I forgot to login before run kolla' | 12:56 |
mgoddard | hrw: you missed this comment? "Please don't revert my patch, or you'll break retries again. Please test a retry that eventually succeeds." | 12:57 |
hrw | mgoddard: one step at time, ok? | 12:57 |
yoctozepto | xD | 12:57 |
mgoddard | hrw: two steps please | 12:57 |
yoctozepto | dancers | 12:58 |
hrw | mgoddard: your test assumes that retries are in PushTask when they are outside of it | 12:58 |
*** Guest31368 has joined #openstack-kolla | 12:58 | |
yoctozepto | then rewrite :D | 12:58 |
hrw | yoctozepto: I did. by dropping it | 12:59 |
hrw | ;d | 12:59 |
yoctozepto | yeah, indeed | 12:59 |
hrw | now looking at how to test it right | 12:59 |
yoctozepto | good boy | 12:59 |
yoctozepto | ;D | 12:59 |
*** hjensas has joined #openstack-kolla | 13:00 | |
*** Guest31368 is now known as redrobot_ | 13:00 | |
hrw | build.PushTask->run() is expected to raise exception once there is any error | 13:00 |
*** redrobot_ is now known as redrobot | 13:01 | |
hrw | but in tox it is run in a way that exception is handled other way | 13:02 |
yoctozepto | how so | 13:02 |
hrw | PushTask->run() is called by tox, calls push_image() which errors out, raise generic exception, gets back to PushTask->run() but not as PushError | 13:03 |
yoctozepto | hmmm | 13:04 |
yoctozepto | I still don't get it how tox is doing that | 13:05 |
yoctozepto | tox is just running some stuff in a virtual environment | 13:05 |
yoctozepto | you must mean something else | 13:05 |
hrw | self.dc is mocked | 13:06 |
*** Guest69423 has quit IRC | 13:06 | |
hrw | so self.dc.push() call goes to mock_client->push() which probably just raise Exception and consider it done | 13:06 |
yoctozepto | ah, you mean the mock | 13:07 |
mgoddard | hrw: I don't think my test assumes retries are in PushTask - it calls task.run() twice | 13:07 |
hrw | mgoddard: but we go back to run() in a wrong way. | 13:07 |
mgoddard | hrw: why? | 13:07 |
openstackgerrit | Merged openstack/kayobe master: format pxe_append_params as string and not a list https://review.opendev.org/688102 | 13:08 |
hrw | mgoddard: look at build.PushTask.push_image() function | 13:08 |
mgoddard | hrw: in the case I was testing, the Docker client raises an exception | 13:08 |
mgoddard | your case is different - it returns an error message, so we raise a new exception | 13:09 |
hrw | mgoddard: 'for response in self.dc.push()' call goes to mock, mock raises GENERIC exception, build.PushTask.run() gets into wrong part of Exception handling | 13:09 |
mgoddard | hrw: that was what happened in the bug that was raised | 13:10 |
mgoddard | hrw: we saw "Unknown error when pushing" | 13:10 |
hrw | mgoddard: and once PushTask->run() fails then we have PushTask->run() added into queue if there are any retries left | 13:10 |
mgoddard | if you want to test a different path, add another new unit test | 13:10 |
yoctozepto | unit test, unit test | 13:10 |
mgoddard | hrw: here's the bug: https://bugs.launchpad.net/tripleo/+bug/1844697 | 13:11 |
openstack | Launchpad bug 1844697 in tripleo "[kolla] periodic: container build job can fail during push" [Undecided,New] | 13:11 |
hrw | ok | 13:12 |
*** schwicht has joined #openstack-kolla | 13:12 | |
openstackgerrit | Merged openstack/kolla-ansible master: setup.cfg: Cleanup https://review.opendev.org/688293 | 13:14 |
*** schwicht has quit IRC | 13:14 | |
*** schwicht has joined #openstack-kolla | 13:14 | |
*** openstackstatus has quit IRC | 13:15 | |
hrw | imho whole 'image.status = STATUS_BUILT' inside of push is wrong. it should be done before as we do not push unbuilt images | 13:17 |
mgoddard | hrw: built == success | 13:20 |
hrw | mgoddard: built == built, exists as docker image in local docker storage. we can now push | 13:20 |
hrw | if need | 13:21 |
mgoddard | well yes, but in terms of our state machine, if we're pushing images then they end up in 'built' on success | 13:21 |
mgoddard | you'd need to it to change that | 13:22 |
mgoddard | *to modify | 13:22 |
hrw | ok | 13:23 |
openstackgerrit | Will Szumski proposed openstack/kayobe stable/stein: format pxe_append_params as string and not a list https://review.opendev.org/688403 | 13:24 |
openstackgerrit | Will Szumski proposed openstack/kayobe stable/rocky: format pxe_append_params as string and not a list https://review.opendev.org/688404 | 13:25 |
openstackgerrit | Will Szumski proposed openstack/kayobe stable/queens: format pxe_append_params as string and not a list https://review.opendev.org/688405 | 13:25 |
*** BjoernT has joined #openstack-kolla | 13:26 | |
openstackgerrit | Marcin Juszkiewicz proposed openstack/kolla master: handle push error properly https://review.opendev.org/688390 | 13:27 |
hrw | this version should satisfy | 13:28 |
openstackgerrit | Michal Nasiadka proposed openstack/kolla-ansible master: Allow fetch ceph keyrings to work with unversioned python binary https://review.opendev.org/688392 | 13:30 |
openstackgerrit | Viktor Michalek proposed openstack/kolla-ansible master: Neutron: Added option to force legacy iptables in neutron_openvswitch_agent https://review.opendev.org/685967 | 13:32 |
hrw | tox passed | 13:44 |
*** dougsz has quit IRC | 13:47 | |
*** BjoernT_ has joined #openstack-kolla | 13:47 | |
*** BjoernT has quit IRC | 13:49 | |
*** dougsz has joined #openstack-kolla | 14:04 | |
*** munimeha1 has joined #openstack-kolla | 14:06 | |
*** dpawlik has quit IRC | 14:07 | |
noxoid | yoctozepto, re rabbitmq partitioning. im afraid i can only offer anecdotal evidence. my cluster may have been silently partitioned when i made the change to pause_minority. i have since stopped relying solely on cluster_health and added "rabbitmqctl node_health_check" to a list of things to check | 14:11 |
noxoid | if you cant replicate then i wouldnt worry about it. although adding a node_health_check before converting may be useful as cluster_health reported no partitions but node health checks would fail on stuck processes | 14:13 |
*** Blinkiz has joined #openstack-kolla | 14:18 | |
*** priteau has joined #openstack-kolla | 14:20 | |
hrw | pep8 is funny | 14:21 |
hrw | you fix W503 and then it became W504 ;D | 14:21 |
*** ivve has quit IRC | 15:05 | |
openstackgerrit | James Kirsch proposed openstack/kolla-ansible master: Custom CA certificates deployment https://review.opendev.org/686024 | 15:23 |
openstackgerrit | Joseph M proposed openstack/kolla stable/stein: Bump stein octavia to 4.1.0 (CVE-2019-17134) https://review.opendev.org/688426 | 15:31 |
noxoid | ^ fixes CVE-2019-17134 | 15:31 |
noxoid | at least on the kolla end | 15:31 |
mgoddard | nice, thanks noxoid | 15:33 |
noxoid | dont thank me yet, i didnt propose changes for the other affected stable branches :P | 15:33 |
noxoid | i guess i can go ahead and do that | 15:33 |
mgoddard | please :) | 15:34 |
openstackgerrit | Joseph M proposed openstack/kolla stable/rocky: Bump rocky octavia to 3.2.0 (CVE-2019-17134) https://review.opendev.org/688429 | 15:38 |
yoctozepto | noxoid: thanks! | 15:40 |
mnasiadka | yoctozepto: https://review.opendev.org/#/c/675659 - go have a look and let's finish this cells soap opera :) | 15:41 |
openstackgerrit | Joseph M proposed openstack/kolla stable/queens: Bump queens octavia to 2.1.2 (CVE-2019-17134) https://review.opendev.org/688430 | 15:42 |
yoctozepto | mnasiadka: unfortunately it will take more than a "look" for me :-) | 15:42 |
yoctozepto | I'm too thorough | 15:42 |
mnasiadka | yoctozepto: oh come on, Mark and Doug have been polishing it for too long :) | 15:42 |
yoctozepto | but I'm into closing this today/tomorrow | 15:43 |
yoctozepto | I am sure of their dedication though it's about doing the review | 15:43 |
yoctozepto | not honorary w+1 :-) | 15:43 |
openstackgerrit | Michal Nasiadka proposed openstack/kolla-ansible master: Allow fetch ceph keyrings to work with unversioned python binary https://review.opendev.org/688392 | 15:44 |
mgoddard | yoctozepto: comments welcome | 15:44 |
mnasiadka | yoctozepto: just joking :) | 15:44 |
mnasiadka | so - do we have any features that we need to squeeze in Train? | 15:44 |
mnasiadka | (apart the cells one)? | 15:44 |
mnasiadka | ugh, I need to raise two more issues in ceph-ansible... | 15:45 |
mgoddard | mnasiadka: IP6 | 15:45 |
openstackgerrit | Mark Goddard proposed openstack/kolla-ansible master: Docs: add nova cells https://review.opendev.org/688432 | 15:45 |
mnasiadka | mgoddard: I was looking for something less complicated than cells :) | 15:46 |
mgoddard | yoctozepto, mnasiadka: ^ some docs which may help in the grokking of code | 15:46 |
*** hamzaachi has joined #openstack-kolla | 15:51 | |
*** hamzaachi has quit IRC | 15:52 | |
yoctozepto | mnasiadka: ipv6 is simpler but tedious | 15:53 |
noxoid | k patches have been proposed for all stable versions where a fixed tarball is available on tarballs.openstack.org | 15:54 |
noxoid | older stable versions have had their release notes updated but there are no tarballs avail | 15:54 |
openstackgerrit | Viktor Michalek proposed openstack/kolla-ansible master: Neutron: Added option to force legacy iptables in neutron_openvswitch_agent https://review.opendev.org/685967 | 16:02 |
*** rgogunskiy has quit IRC | 16:02 | |
*** openstackstatus has joined #openstack-kolla | 16:03 | |
*** ChanServ sets mode: +v openstackstatus | 16:03 | |
hrw | mnasiadka: can you just use ansible_python_interpreter var? | 16:06 |
mnasiadka | hrw: and then ubuntu containers on centos stop working?:) | 16:06 |
*** rpittau is now known as rpittau|afk | 16:06 | |
hrw | mnasiadka: jsut asking | 16:07 |
hrw | noxoid: +2 on all. thanks | 16:07 |
noxoid | no problem | 16:08 |
mnasiadka | hrw: we could gather facts in the container image, but probably current approach is faster and simpler | 16:09 |
*** hamzaachi has joined #openstack-kolla | 16:10 | |
hrw | mnasiadka: /usr/bin/python{{ distro_python_version }} | 16:12 |
mnasiadka | hrw: that var is only in kolla? Or we have that in k-a also? | 16:13 |
hrw | both | 16:13 |
hrw | mnasiadka: https://review.opendev.org/#/c/675581/ | 16:13 |
* hrw off | 16:17 | |
*** igordc has joined #openstack-kolla | 16:21 | |
openstackgerrit | Merged openstack/kayobe stable/queens: format pxe_append_params as string and not a list https://review.opendev.org/688405 | 16:22 |
*** dave-mccowan has quit IRC | 16:23 | |
*** hamzaachi has quit IRC | 16:24 | |
yoctozepto | hrw, mnasiadka: so distro_python_version or not? :S | 16:25 |
*** hamzaachi has joined #openstack-kolla | 16:25 | |
mnasiadka | Geez, static var | 16:26 |
mnasiadka | Whatever, I’ll use it. | 16:26 |
yoctozepto | WHATEVA :D | 16:28 |
*** BjoernT_ is now known as BjoernT | 16:34 | |
*** k_mouza_ has joined #openstack-kolla | 16:44 | |
yoctozepto | mnasiadka: anyways, did you get why this command suddenly started failing? | 16:45 |
yoctozepto | was it just not run before | 16:46 |
yoctozepto | or what | 16:46 |
*** k_mouza has quit IRC | 16:47 | |
*** devep has quit IRC | 16:49 | |
*** k_mouza_ has quit IRC | 16:49 | |
mnasiadka | yoctozepto: well, that's the effect of non-voting CIs :) | 16:51 |
yoctozepto | mnasiadka: that's what I get | 16:52 |
yoctozepto | but how was it done by your change | 16:52 |
yoctozepto | is yet beyond me | 16:52 |
mnasiadka | it was rather not my change, let me analyse when it started failing | 16:52 |
*** hamzaachi has quit IRC | 16:54 | |
openstackgerrit | Mark Goddard proposed openstack/kolla-ansible master: Docs: add nova cells https://review.opendev.org/688432 | 16:55 |
mnasiadka | ok, it started failing on 10th in the evening | 16:55 |
openstackgerrit | Merged openstack/kayobe stable/rocky: format pxe_append_params as string and not a list https://review.opendev.org/688404 | 16:56 |
mnasiadka | humm, no changes that could cause this | 16:59 |
*** munimeha1 has quit IRC | 17:02 | |
openstackgerrit | Pierre Riteau proposed openstack/kayobe master: Try running `docker info` again if it fails https://review.opendev.org/688474 | 17:05 |
mnasiadka | whatever, not going to track bionic changefs | 17:05 |
mnasiadka | changes | 17:05 |
*** dougsz has quit IRC | 17:05 | |
*** hjensas has quit IRC | 17:08 | |
openstackgerrit | Michal Nasiadka proposed openstack/kolla-ansible master: Allow fetch ceph keyrings to work with unversioned python binary https://review.opendev.org/688392 | 17:09 |
*** priteau has quit IRC | 17:11 | |
yoctozepto | mnasiadka: and your change had this passing? | 17:16 |
mnasiadka | yoctozepto: of course | 17:16 |
yoctozepto | mnasiadka: though so | 17:16 |
yoctozepto | (saw so) | 17:16 |
mnasiadka | anyway - normally I would rework this, but I don't like to meddle with a dead (deprecated) horse :) | 17:16 |
yoctozepto | mnasiadka: dead indeed | 17:17 |
mnasiadka | at least ceph-ansible is nearly there, needs some more testing and some docs how to set it up | 17:18 |
*** hamzaachi has joined #openstack-kolla | 17:18 | |
mnasiadka | but ceph-ansible guys broke key fetching in 4.0 | 17:18 |
yoctozepto | oh my | 17:18 |
*** hjensas has joined #openstack-kolla | 17:20 | |
*** BjoernT has quit IRC | 17:20 | |
*** signed8bit has joined #openstack-kolla | 17:22 | |
kplant | mnasiadka: yeah.... | 17:22 |
kplant | i noticed that myself | 17:22 |
kplant | it kind-of works with non-containerized | 17:22 |
kplant | but then, for some reason, the flow for containerized was totally different | 17:22 |
mnasiadka | kplant: well, they fixed it for mds, but now seems rgw has the same problem | 17:23 |
mnasiadka | so I need to raise another issue | 17:23 |
kplant | i was in the middle of submitting a package to make it symetrical | 17:23 |
kplant | but then i fell down :> | 17:23 |
mnasiadka | kplant: I wouldn't bother, this is a downstream managed open source project | 17:23 |
yoctozepto | uplifting kolla does better with its CI :-) | 17:23 |
*** k_mouza has joined #openstack-kolla | 17:23 | |
kplant | stable-3.2 was great in terms of keys | 17:24 |
kplant | even dumped the fsid to a nice file for you | 17:24 |
kplant | now, as far as i can tell, if you don't statically set it - you have no idea wqhat it is | 17:24 |
kplant | just hope it's the only dir in /etc/ceph/fetch/ | 17:24 |
*** gmann is now known as gmann_afk | 17:25 | |
mnasiadka | kplant: they removed the fetch dir in 4.0 | 17:27 |
mnasiadka | (just like this) | 17:27 |
mnasiadka | :) | 17:27 |
mnasiadka | no deprecation, no nothing :) | 17:27 |
kplant | nah, it's still there | 17:27 |
kplant | i use stable-4.0 myself | 17:27 |
kplant | # Directory to fetch cluster fsid, keys etc... | 17:27 |
kplant | fetch_directory: fetch/ | 17:27 |
kplant | it does output | 17:28 |
mnasiadka | kplant: yeah, but they removed it from most of the plays, and in containerised mode - it does not put anything in there :) | 17:28 |
kplant | yeah that's what i was mentioning earlier | 17:28 |
kplant | for containerized it's different which makes no sense | 17:28 |
mnasiadka | kplant: and they plan to remove the rest - so I wouldn't stick to it :) | 17:28 |
kplant | well that's dumb | 17:28 |
kplant | how am i supposed to programmatically get my fsid and keys if they're not outputted? | 17:29 |
*** hjensas has quit IRC | 17:34 | |
*** hjensas has joined #openstack-kolla | 17:37 | |
mnasiadka | kplant: and you think they care? RH just cares for their own customers using this :) | 17:38 |
mnasiadka | ok, over and out :) | 17:43 |
kplant | lol - you mean ibm! | 17:47 |
*** hamzaachi has quit IRC | 17:47 | |
openstackgerrit | Merged openstack/kayobe stable/stein: format pxe_append_params as string and not a list https://review.opendev.org/688403 | 17:51 |
*** verdurin has quit IRC | 17:51 | |
*** k_mouza has quit IRC | 17:51 | |
*** verdurin has joined #openstack-kolla | 17:51 | |
*** ivve has joined #openstack-kolla | 17:53 | |
*** k_mouza has joined #openstack-kolla | 18:17 | |
openstackgerrit | Merged openstack/kolla master: Custom CA certificates installation mechanism https://review.opendev.org/686121 | 18:24 |
*** cah_link1 has joined #openstack-kolla | 18:25 | |
*** cah_link has quit IRC | 18:27 | |
*** cah_link1 is now known as cah_link | 18:27 | |
*** schwicht has quit IRC | 18:38 | |
*** schwicht has joined #openstack-kolla | 18:38 | |
openstackgerrit | Merged openstack/kolla stable/rocky: Bump rocky octavia to 3.2.0 (CVE-2019-17134) https://review.opendev.org/688429 | 18:41 |
openstackgerrit | Merged openstack/kolla stable/stein: Bump stein octavia to 4.1.0 (CVE-2019-17134) https://review.opendev.org/688426 | 18:41 |
yoctozepto | mgoddard: are you doing the ascii graphics by hand or using some tool? cause they look nice | 18:47 |
yoctozepto | also in kayobe case | 18:47 |
*** factor has quit IRC | 18:50 | |
*** k_mouza has quit IRC | 19:11 | |
*** Jeffrey4l has quit IRC | 19:23 | |
*** Jeffrey4l has joined #openstack-kolla | 19:24 | |
*** kplant has quit IRC | 19:38 | |
*** dpawlik has joined #openstack-kolla | 19:56 | |
*** gfidente has quit IRC | 19:57 | |
*** gmann_afk is now known as gmann | 20:01 | |
openstackgerrit | Merged openstack/kolla master: setup.cfg: Cleanup https://review.opendev.org/688274 | 20:17 |
*** BjoernT has joined #openstack-kolla | 20:24 | |
*** pcaruana has quit IRC | 20:26 | |
*** benj has joined #openstack-kolla | 20:28 | |
*** benj is now known as Guest39910 | 20:28 | |
*** dpawlik has quit IRC | 20:31 | |
*** BjoernT_ has joined #openstack-kolla | 20:32 | |
*** BjoernT has quit IRC | 20:32 | |
*** dpawlik has joined #openstack-kolla | 20:42 | |
*** dpawlik has quit IRC | 20:46 | |
*** ldumont has joined #openstack-kolla | 21:04 | |
*** LaurentDumont has quit IRC | 21:05 | |
*** k_mouza has joined #openstack-kolla | 21:12 | |
openstackgerrit | Merged openstack/kolla stable/queens: Bump queens octavia to 2.1.2 (CVE-2019-17134) https://review.opendev.org/688430 | 21:12 |
*** k_mouza has quit IRC | 21:16 | |
*** goldyfruit has joined #openstack-kolla | 21:20 | |
*** vmixor has quit IRC | 21:22 | |
*** k_mouza has joined #openstack-kolla | 21:23 | |
*** schwicht has quit IRC | 21:37 | |
*** schwicht has joined #openstack-kolla | 21:40 | |
*** k_mouza has quit IRC | 21:41 | |
*** cah_link has quit IRC | 21:49 | |
*** jistr has quit IRC | 21:52 | |
*** vesper11- has joined #openstack-kolla | 21:53 | |
*** vesper11 has quit IRC | 21:53 | |
*** jistr has joined #openstack-kolla | 22:01 | |
*** jistr has quit IRC | 22:02 | |
*** jistr has joined #openstack-kolla | 22:03 | |
*** schwicht has quit IRC | 22:32 | |
*** ivve has quit IRC | 22:49 | |
*** schwicht has joined #openstack-kolla | 22:53 | |
*** schwicht has quit IRC | 23:29 | |
*** vmixor has joined #openstack-kolla | 23:34 | |
*** k_mouza has joined #openstack-kolla | 23:41 | |
*** k_mouza has quit IRC | 23:46 | |
*** schwicht has joined #openstack-kolla | 23:54 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!