Thursday, 2019-03-21

*** iniazi has quit IRC00:15
*** iniazi has joined #openstack-kolla00:20
*** zhanglong has quit IRC00:32
*** jbadiapa has joined #openstack-kolla00:41
*** k_mouza has joined #openstack-kolla01:23
*** k_mouza has quit IRC01:32
*** unicell has joined #openstack-kolla02:07
*** unicell has quit IRC02:07
*** unicell has joined #openstack-kolla02:07
*** unicell has quit IRC02:08
*** janki has quit IRC02:44
*** wolverineav has joined #openstack-kolla02:55
*** Sravan has quit IRC03:21
*** Sravan has joined #openstack-kolla03:22
*** vblando has joined #openstack-kolla03:23
vblandotried doing a 2 node setup (controller, compute) and disabled haproxy (enable_haproxy=no) but kola still trying to use VIP, is this a normal behavior? Is setting up VIP still required even without haproxy on?03:24
*** dciabrin has quit IRC03:33
*** dciabrin has joined #openstack-kolla03:33
*** andrein has joined #openstack-kolla03:59
*** andrein has quit IRC03:59
*** janki has joined #openstack-kolla04:00
*** unicell has joined #openstack-kolla04:49
*** Sravan has joined #openstack-kolla04:56
*** wolverineav has quit IRC05:02
*** wolverineav has joined #openstack-kolla05:02
*** wolverineav has quit IRC05:08
*** JamesBenson has joined #openstack-kolla05:11
*** Sravan has quit IRC05:15
*** JamesBenson has quit IRC05:16
*** skramaja has joined #openstack-kolla05:18
*** ivve has quit IRC05:18
*** janki has quit IRC05:20
*** Sravan has joined #openstack-kolla05:21
*** wolverineav has joined #openstack-kolla05:34
*** JamesBenson has joined #openstack-kolla05:37
*** JamesBenson has quit IRC05:41
mnasiadkavblando: tried setting the vip to first node ip?05:48
*** janki has joined #openstack-kolla05:51
*** jbadiapa has quit IRC05:51
*** unicell has quit IRC06:00
*** wolverineav has quit IRC06:07
*** pcaruana has joined #openstack-kolla06:11
*** Sravan has quit IRC06:17
*** ivve has joined #openstack-kolla06:22
*** wolverineav has joined #openstack-kolla06:41
*** Luzi has joined #openstack-kolla06:44
*** ivve has quit IRC06:58
*** ivve has joined #openstack-kolla07:03
*** JamesBenson has joined #openstack-kolla07:03
*** JamesBenson has quit IRC07:07
*** hjensas has quit IRC07:25
hrwmorning07:35
hrwkarbor change merged07:36
*** luksky has joined #openstack-kolla07:46
openstackgerritMarcin Juszkiewicz proposed openstack/kolla master: Debian/Ubuntu: move to Python 3 for binary/source images  https://review.openstack.org/64237507:50
hrwnow it should pass07:51
hrwubuntu builds I mean ;D07:51
*** wolverineav has quit IRC07:54
*** hjensas has joined #openstack-kolla08:03
*** openstackgerrit has quit IRC08:17
*** chrizl has joined #openstack-kolla08:18
*** chrizl has quit IRC08:22
*** gfidente has joined #openstack-kolla08:24
*** tosky has joined #openstack-kolla08:27
hrwkolla-build-ubuntu passed for both binary and source08:29
hrwk-a jobs fail but good to see that it is finally buildable08:29
vblando@mnasiadka: i'll try that08:30
mnasiadkahrw: I was looking at this placement-api wsgi bug... but I need more coffee to understand what is causing it ;)08:31
vblandoin the inventory file, there's an entry for [deployment]08:33
vblandolocalhost     ansible_connection=local08:33
hrwmnasiadka: can you look at http://logs.openstack.org/75/642375/15/check/kolla-ansible-ubuntu-source/45ded2d/ and tell me what is wrong?08:33
vblandois that needed even if you deployer is remote?08:33
*** gkadam has joined #openstack-kolla08:33
hrwvblando: that's for all-in-one08:33
*** gkadam has quit IRC08:33
hrwvblando: when you deploy on deployer08:34
vblandohrw:  ah, so for multinode, it can be commented out08:34
hrwvblando: if you want all-in-one on remote then change inventory08:34
mnasiadkahrw: that one seems like some network issue, it was waiting for vip to appear after starting/restarting keepalived, but it timed out...08:34
*** iniazi has quit IRC08:35
hrwvblando: that's how I always did. in-repo all-in-one for 'deploy all-in-one on deployer', own all-in-one for 'deploy on remote' and multinode for multi08:35
hrwmnasiadka: dzięki08:35
hrwmnasiadka: it is not first time I see such failure ;(08:35
vblandohrw:  both sample inventory files for all-in-one and multinode has that entry08:35
mnasiadkahrw: and it's single node, so that's even more weird ;)08:36
mnasiadkahrw: ah, it's ovh08:36
mnasiadkahrw: try recheck to land at some different nodepool provider ;)08:36
mnasiadkahrw: or ask ovh guys on #openstack-pl to fix their env :D08:37
hrwmnasiadka: ;D)08:37
egonzalezhrw k-a centos binary is failing due an error in the deployment of placement-api08:37
hrwegonzalez: thx08:37
hrwI am happy anyway - my py3 patch passed build phase for first time08:37
egonzalezthe package bundles the wsgi file and the name conflict with our deployed wsgi process name08:38
mnasiadkaegonzalez: ah, that's the reason - so we should remove the bundled file? ;)08:38
egonzalezasked to tripleo guys and they dont use it, they copy their own file too, so probably is the option08:38
egonzalezor copy ours as 00-placement-api.conf to override the original08:39
mnasiadkamaybe that's even better08:39
egonzalezor change wsgi process name to something else08:39
mnasiadkabut then it's not in the same manner as all others08:40
mnasiadkaor raise a bug to RDO to remove that bundled file :)08:40
egonzalezother rdo packages doesnt have the wsgi file on it, so is probably better remove the original file08:40
*** JamesBenson has joined #openstack-kolla08:44
*** JamesBenson has quit IRC08:49
*** dougsz has joined #openstack-kolla08:55
*** iniazi has joined #openstack-kolla09:03
dougszthanks for reviewing those kolla patches hrw!09:09
hrwdougsz: yw09:10
*** jbadiapa has joined #openstack-kolla09:13
*** dteselkin has quit IRC09:32
*** dteselkin has joined #openstack-kolla09:33
egonzalezmgoddard hrw mnasiadka i think we cannot make the tripleo job voting because is 3rd party job, trying to find some gobernance rule for that, but other projects doesnt allow -1 to 3rd party job09:35
hrwok, then stays as is09:35
*** priteau has joined #openstack-kolla09:37
egonzalezjobs can -1 but not -209:39
egonzalezdont know if this still applies to zuul v3 but neutron have this in their docs https://docs.openstack.org/neutron/latest/contributor/policies/thirdparty-ci.html#third-party-ci-voting09:40
mgoddardegonzalez: so we could make it voting but not gating? does that even make sense?09:40
mgoddardegonzalez: is third party more about vendors than cross-project though?09:41
*** pcaruana has quit IRC09:45
*** pcaruana has joined #openstack-kolla09:46
*** wolverineav has joined #openstack-kolla09:51
*** jbadiapa has quit IRC09:55
*** zbr has quit IRC10:08
*** zbr has joined #openstack-kolla10:10
*** jbadiapa has joined #openstack-kolla10:15
*** zbr has quit IRC10:16
*** jbadiapa has quit IRC10:16
*** k_mouza has joined #openstack-kolla10:17
*** jbadiapa has joined #openstack-kolla10:18
*** zbr has joined #openstack-kolla10:22
*** zbr has quit IRC10:22
*** jbadiapa has quit IRC10:25
*** wolverineav has quit IRC10:25
*** jbadiapa has joined #openstack-kolla10:37
mnasiadkaegonzalez: https://docs.openstack.org/infra/system-config/third_party.html#permissions-on-your-third-party-system10:53
*** openstackgerrit has joined #openstack-kolla11:02
openstackgerritMichal Nasiadka proposed openstack/kolla-ansible master: Fix placement-api WSGI error  https://review.openstack.org/64508111:02
*** iniazi_ has joined #openstack-kolla11:05
*** iniazi has quit IRC11:07
*** Sravan has joined #openstack-kolla11:11
*** Sravan has quit IRC11:15
*** priteau has quit IRC11:19
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664011:21
openstackgerritMark Goddard proposed openstack/kolla-ansible stable/rocky: Fix swift reconfigure  https://review.openstack.org/64513111:21
openstackgerritMark Goddard proposed openstack/kolla-ansible stable/queens: Fix swift reconfigure  https://review.openstack.org/64513211:21
openstackgerritMark Goddard proposed openstack/kolla-ansible stable/pike: Fix swift reconfigure  https://review.openstack.org/64513311:21
*** wolverineav has joined #openstack-kolla11:23
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664011:31
erolgGuys when we enable fluentd, we are not configuring oslo.log fluent handler for os services right? Alternatively we are using tail from files with fluentd.11:35
erolgI wondering is there any reason to use this method instead of configure oslo.log fluentd handler11:36
mgoddarderolg: I'm not sure about that. Perhaps the fluentd handler was not available when the logging system was created?11:38
*** zbr has joined #openstack-kolla11:39
mgoddarderolg: I quite like the current setup. It means that if fluentd or your log aggregation system fails you still have a copy of logs11:39
mgoddarderolg: it's quite configurable though, I expect you could probably change it to work how you want via config11:39
*** wolverineav has quit IRC11:40
*** luksky has quit IRC11:41
*** k_mouza has quit IRC11:46
erolgmgoddard, actually we can provide both (file and fluent handler). What do you think? Is this more suitable way for our fully containerized environment?11:47
openstackgerritMark Goddard proposed openstack/kolla-ansible master: Fix MariaDB 10.3 upgrade  https://review.openstack.org/64425011:48
*** dave-mccowan has joined #openstack-kolla11:49
mgoddarderolg: what happens if fluentd is down? Do logs get dropped by oslo.log?11:50
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664011:52
*** dave-mccowan has quit IRC11:53
*** k_mouza has joined #openstack-kolla11:56
*** k_mouza has quit IRC12:05
erolgI have nothing to say about that, I have not used fluent with oslo.log before I will digging into it in my free time and compare this two scenario.12:05
*** k_mouza_ has joined #openstack-kolla12:05
openstackgerritBrent Eagles proposed openstack/kolla stable/queens: Install packages into octavia-api image to support wsgi  https://review.openstack.org/64515412:08
openstackgerritBrent Eagles proposed openstack/kolla stable/queens: Fix Octavia-API extend_start.sh  https://review.openstack.org/64515512:08
*** iniazi_ has quit IRC12:09
*** jbadiapa has quit IRC12:10
*** luksky has joined #openstack-kolla12:20
*** iniazi_ has joined #openstack-kolla12:21
*** k_mouza_ has quit IRC12:22
*** beagles has joined #openstack-kolla12:25
mgoddarderolg: one nice thing about using the fluentd support in oslo.log is (I assume) we would send logs in a more machine-friendly format12:30
*** goldyfruit has quit IRC12:31
erolgmgoddard, and cpu time? fluentd will not parse the files.12:34
mgoddarderolg: no, but it will have to process whatever is sent to it12:34
erolgmgoddard, hmm ok.12:37
*** skramaja has quit IRC12:40
*** S4ren has joined #openstack-kolla12:41
openstackgerritMerged openstack/kolla master: install ncurses explicitly for tput for rpm distro  https://review.openstack.org/64485312:44
openstackgerritMerged openstack/kolla master: Introduce clean_package_cache  https://review.openstack.org/63664612:44
openstackgerritMerged openstack/kolla master: Update programming language mentioned in setup.cfg  https://review.openstack.org/64329812:47
openstackgerritMerged openstack/kolla master: Install qemu-system in nova-libvirt on ubuntu  https://review.openstack.org/64356312:47
openstackgerritMark Goddard proposed openstack/kolla-ansible master: Fix neutron rolling upgrade  https://review.openstack.org/64510212:47
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664012:47
openstackgerritMerged openstack/kolla master: Use virtual package for ansible  https://review.openstack.org/64287412:48
openstackgerritMark Goddard proposed openstack/kolla stable/rocky: Pin sensu mailer and slack plugins  https://review.openstack.org/64516412:53
openstackgerritMark Goddard proposed openstack/kolla stable/queens: Pin sensu mailer and slack plugins  https://review.openstack.org/64516512:53
*** irclogbot_1 has quit IRC13:07
*** irclogbot_1 has joined #openstack-kolla13:09
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Add initial support for upgrade checkers  https://review.openstack.org/64452813:13
*** altlogbot_2 has quit IRC13:23
*** iniazi has joined #openstack-kolla13:23
*** altlogbot_0 has joined #openstack-kolla13:24
*** iniazi_ has quit IRC13:25
*** janki has quit IRC13:28
*** k_mouza has joined #openstack-kolla13:29
*** k_mouza has quit IRC13:29
*** jbadiapa has joined #openstack-kolla13:29
*** lemko has joined #openstack-kolla13:36
*** wolverineav has joined #openstack-kolla13:37
*** altlogbot_0 has quit IRC13:39
*** altlogbot_1 has joined #openstack-kolla13:40
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Add initial support for upgrade checkers  https://review.openstack.org/64452813:40
*** baha has joined #openstack-kolla13:41
*** irclogbot_1 has quit IRC13:45
*** irclogbot_3 has joined #openstack-kolla13:46
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664013:49
openstackgerritMerged openstack/kolla-ansible master: Fix placement-api WSGI error  https://review.openstack.org/64508113:52
*** jistr is now known as jistr|call13:52
*** hjensas has quit IRC13:52
*** jistr|call is now known as jistr14:00
openstackgerritJon Schlueter proposed openstack/kolla master: introduce install_packages chain option  https://review.openstack.org/64518514:02
*** mjturek has joined #openstack-kolla14:02
openstackgerritJon Schlueter proposed openstack/kolla master: Move top package installed in every *-base container to openstack-base  https://review.openstack.org/64518714:05
openstackgerritMark Goddard proposed openstack/kolla-ansible master: Fix MariaDB 10.3 upgrade  https://review.openstack.org/64425014:09
*** wolverineav has quit IRC14:12
openstackgerritMerged openstack/kolla master: monasca, tempest: install librdkafka-dev to get it built for non-x86/source  https://review.openstack.org/64282614:12
openstackgerritMerged openstack/kolla master: Fix MariaDB 10.3 upgrade  https://review.openstack.org/64424414:12
openstackgerritMark Goddard proposed openstack/kolla stable/rocky: Fix MariaDB 10.3 upgrade  https://review.openstack.org/64519114:17
*** iniazi has quit IRC14:27
openstackgerritMark Goddard proposed openstack/kolla stable/rocky: Pin sensu mailer and slack plugins, fix rabbitmq  https://review.openstack.org/64516414:33
*** iniazi has joined #openstack-kolla14:33
*** mjturek has quit IRC14:33
*** gfidente has quit IRC14:33
openstackgerritMark Goddard proposed openstack/kolla stable/queens: Pin sensu mailer and slack plugins, fix rabbitmq  https://review.openstack.org/64516514:35
*** altlogbot_1 has quit IRC14:35
*** altlogbot_0 has joined #openstack-kolla14:36
openstackgerritMark Goddard proposed openstack/kolla stable/pike: rabbitmq container error.  https://review.openstack.org/64519714:37
*** irclogbot_3 has quit IRC14:38
*** gfidente has joined #openstack-kolla14:38
*** irclogbot_1 has joined #openstack-kolla14:39
*** mjturek has joined #openstack-kolla14:39
*** hjensas has joined #openstack-kolla14:44
*** JamesBenson has joined #openstack-kolla14:45
hrwit is visible that release time is coming ;d14:53
hrwjschlueter: https://review.openstack.org/645187 - that oslo-upgradecheck gets installed as popular dependency in images, not directly - right?14:58
jschlueterhrw: yes as a dep of nova/cinder and others15:01
hrwjschlueter: thx15:02
hrwjschlueter: commented https://review.openstack.org/#/c/64518515:02
*** hjensas has quit IRC15:07
jschlueterhrw: ack thanks, I don't have a good patch yet for kolla but I'm using something like this in a local branch for introducing yum/dnf -y update  all in one line to keep layer count and size down15:08
*** wolverineav has joined #openstack-kolla15:08
hrwjschlueter: will wait for patch which uses it then15:08
jschlueterjust this morning I was contemplating introducing a macro or option to the macro to do the update and cleanup ... so we don't have repeated code in multiple spots15:09
jschlueterhrw: ack15:09
hrwjschlueter: imho chaining install_package() is just wrong. list should be joined and installed once15:09
jschlueterhrw: chaining would be ... RUN <do something> && dnf -y update && {{ macros.package_install.... }}15:10
hrwjschlueter: I see that it may be useful for base image. DEB systems first install packages to get APT https working, then install standard stuff. RPM systems install *-release packages and then some stuff15:10
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664015:10
jschlueterhrw: currently the deb has update entry for all calls15:11
*** Sravan has joined #openstack-kolla15:11
hrwjschlueter: yum/dnf does metadata fetching when needed. apt has it explicit15:11
jschlueterhrw: yea I think that area could benifet from something this way but haven't worked through all of the options and use cases yet there15:12
jschlueterhrw: that's right ...15:12
hrwjschlueter: https://review.openstack.org/46256715:12
jschlueterso atp-get upgrade would be the thing to map through  to match dnf -y update15:12
hrwjschlueter: yum/dnf update == (apt update + ) apt upgrade15:13
* jschlueter nods15:13
jschlueterthanks for reminding me  ... I knew that but wasn't connecting it when I was reading the code this morning15:13
hrwjschlueter: ;)15:14
*** Sravan has quit IRC15:15
hrwjschlueter: speaking of yum and macros... base image may benefit some cleanups for rpm systems. there are few places asking for macro15:15
jschlueterhrw: yea that's what I was thinking  ... let me start there and see what I come up with15:18
*** baha has quit IRC15:18
hrwjschlueter: I wrote a comment about it in some patch but forgot which one15:18
jschlueterhrw: I think the python3 bp that Alex proposed15:19
hrwpossible15:19
jschlueterbut was out of scope for that patch15:19
hrwjschlueter: still prefer to leave such comment so maybe patch author will follow with another one15:20
jschlueteryep15:20
jschlueterI alway appreciate it when they are pointed out15:21
*** Luzi has quit IRC15:25
*** unicell has joined #openstack-kolla15:26
*** jbadiapa has quit IRC15:26
*** unicell has quit IRC15:27
openstackgerritJon Schlueter proposed openstack/kolla master: refactor to pull out rpm_security_update macro  https://review.openstack.org/64520915:39
jschlueterhrw, mandre: iterating on the theme here ^^ first pass at that refactor15:40
jschlueterby inspection of a couple of quick template only runs looks to be a clean refacter but feedback welcome15:41
*** wolverineav has quit IRC15:42
*** ivve has quit IRC15:42
jschlueterhrw: in that block there is where I could make use of the chain macro entry for package_install line 175 of base/Dockerfile.j2 ...15:43
jschlueterbut I would want to also add cleanup option so you could override and not do cleanup until last one in list of chained ...15:43
*** baha has joined #openstack-kolla15:44
*** spiette has quit IRC15:47
*** spiette has joined #openstack-kolla15:48
hrwjschlueter: commented15:52
jschlueterhrw: thanks15:53
*** unicell has joined #openstack-kolla15:55
jschluetermandre, hrw: are there any unittests for the macros that I could add a test for the new macro to make sure we don't add extra whitespace at end of the macro regardless of how it's called?15:57
*** hjensas has joined #openstack-kolla15:58
hrwjschlueter: do not know but sounds like very good idea15:58
hrwjschlueter: especially when you read mandre's comments15:58
* jschlueter nods16:00
mandrejschlueter: I do not know off the top of my head about unit testing macros but it would indeed be nice to have16:01
* jschlueter nods16:02
*** unicell has quit IRC16:06
*** goldyfruit has joined #openstack-kolla16:13
*** mjturek has quit IRC16:16
openstackgerritMerged openstack/kolla-ansible master: Use endpoint_override for nova-compute-ironic  https://review.openstack.org/64391116:22
openstackgerritMerged openstack/kolla-ansible stable/queens: Create /volumes when using external ceph  https://review.openstack.org/64308716:22
openstackgerritMerged openstack/kolla-ansible stable/queens: Fix failure to mount cephfs  https://review.openstack.org/64308816:22
*** mjturek has joined #openstack-kolla16:24
*** hjensas has quit IRC16:24
*** baha has quit IRC16:24
*** baha has joined #openstack-kolla16:35
openstackgerritMark Goddard proposed openstack/kolla stable/queens: Pin sensu mailer and slack plugins, fix rabbitmq  https://review.openstack.org/64516516:38
openstackgerritMark Goddard proposed openstack/kolla stable/rocky: Pin sensu mailer and slack plugins, fix rabbitmq  https://review.openstack.org/64516416:39
openstackgerritMark Goddard proposed openstack/kolla stable/queens: Pin sensu mailer and slack plugins, fix rabbitmq  https://review.openstack.org/64516516:39
openstackgerritMark Goddard proposed openstack/kolla stable/pike: Fix rabbitmq container error and oraclelinux  https://review.openstack.org/64519716:44
*** Sravan has joined #openstack-kolla16:48
openstackgerritJon Schlueter proposed openstack/kolla master: refactor to pull out rpm_security_update macro  https://review.openstack.org/64520916:49
*** ivve has joined #openstack-kolla16:54
*** luksky has quit IRC17:02
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664017:03
*** henriqueof has joined #openstack-kolla17:06
hrwsee you on Monday17:12
openstackgerritJon Schlueter proposed openstack/kolla master: Fixup whitespace issue in chaining  https://review.openstack.org/64524217:17
jschluetermandre: found one whitespace issue not in my patch but related to what I was digging on17:17
mandrejschlueter: wow, nice one17:24
openstackgerritJon Schlueter proposed openstack/kolla master: cleanup in base for yum install entries  https://review.openstack.org/64518517:24
jschluetermandre: and here is the other piece one that actually does cleanup for the yum -y install entries in base17:25
jschluetermandre: yea not sure how to do regex search but shouldn't be too hard if we have construct for multi-line searches .... look for \ continuation mark at end of line followed by  2 line returns in any of the rendered Dockerfiles17:26
jschlueterhrw: ^^ found usage of the chain option in install_packages macro ... to do cleanup of the extra yum -y install entries17:28
openstackgerritMark Goddard proposed openstack/kolla-ansible master: Fix MariaDB 10.3 upgrade  https://review.openstack.org/64425017:35
openstackgerritMark Goddard proposed openstack/kolla-ansible master: Wait for cinder volume to become available in CI  https://review.openstack.org/64527717:35
*** S4ren has quit IRC17:41
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664017:42
jschluetermgoddard: question do you guys prefer smaller easily verified by visual inspection patches and a patch series if they are tightly related or would you prefer them not stacked up like this set is?17:42
*** gmann is now known as gmann_afk17:43
* jschlueter just checking so I'm not flooding the system or causing issues17:43
mgoddardjschlueter: depends, I can deal with either. If there are going to be lots of iterations then a big patch will be easier on resources17:44
* jschlueter nods17:44
jschlueterack if I get more than a couple of iterations on this I'll work on collapsing it down otherwise I'll leave them individual improvements that stand alone but don't collide if applied in this order17:45
jschlueterI see another patch but it will need some thinking about it ... so that we can get both rpm and deb blocks to call through to a macro for the upgrade with or without installing packages and cleaning up caches afterwards17:46
jschlueterboth tripleo and deb/ubuntu has room for improvement here ...17:47
jschlueterbut that's for another day17:47
mgoddardjschlueter: splitting is also good if earlier patches can get merged before later ones17:47
jschlueterincremental improvements is good17:47
* jschlueter nods17:47
mgoddard+117:47
mgoddardnice to see you getting more involved in kolla recently jschlueter17:47
jschlueterright now all of these are incrementally refactors that should preserve the same code paths just reduce duplicated code17:48
jschluetermgoddard: yea I've been learning/using it more and the more that I find problems using it the more I dig in, and for the most part it's been a matter of figuring out how to adjust or fix holes in the scripts that I'm hitting17:48
* jschlueter involved with Red Hat OSP17:49
mgoddardalways nice too keep thinks DRY17:49
jschlueter:-)17:49
mgoddardGood stuff, I sometimes wonder how big the tripleo template overrides file is these days, and whether there is stuff in there we could all benefit from in kolla17:50
jschluetermgoddard: it's bigger than it should be and likely yes17:51
jschluetermgoddard: this cycle I've collapsed most of the OSP specific overrides into tripleo-common overrides or patches to it ...  or into kolla to make life easier17:52
mgoddardjschlueter: maybe something we can discuss at the PTG, if you're there?17:52
mgoddardwe're not doing any kolla meetings at the PTG, but I'll be there and could join TripleO people at some point17:53
jschlueterI'm not going to be this year but at some future one, mandre, mwhahaha, or Emillian would likely be interested in it17:53
jschluetermgoddard: https://github.com/openstack/tripleo-common/blob/master/container-images/tripleo_kolla_template_overrides.j2  750 lines long17:54
mgoddardthat would be good. I'll follow up with them17:54
*** ivve has quit IRC17:54
mgoddardjschlueter: ...17:54
jschluetera lot of healthcheck entries, a STOPSIGNAL entry, a yum -y update in base17:54
jschluetersome of them are naming fixups17:55
mgoddardwould love me some healthchecks17:55
jschlueterIIRC the healthcheck scripts are currently in one of the tripleo packages I think tripleo-common17:56
jschlueteralso a few blocks adding wsgi type wrappers ... that might be low hanging fruit17:56
mgoddardhttps://github.com/openstack/tripleo-common/blob/master/healthcheck/cinder-volume17:56
jschlueterbut I don't know enough about that just that I've seen it updated some places in kolla and sometimes only in tripleo-common17:56
mgoddardwould be great if there were a common way of doing healthchecks17:57
* jschlueter nods17:57
jschlueterhttps://github.com/openstack/tripleo-common/blob/master/healthcheck/common.sh17:57
mgoddardI seem to remember it being discussed as a cross project goal at some point, not sure what happened17:57
* jschlueter nods17:59
jschlueterI think part of difficulty is healthchecks are dependent on how you deploy/configure things17:59
jschluetermgoddard: I'm not sure why ect_api doesn't have the httpd/mod_ssl + runtime tweaks embedded in kolla18:00
jschlueter*ec2_api18:00
mgoddardseems like it should do18:01
jschlueterbut nova-api does18:01
jschlueterI think there are some patches I've seen in the queue unmerged that add similar httpd/mod_ssl + tweaks ...18:02
*** ivve has joined #openstack-kolla18:02
jschlueterwhich should almost be a macros at this point18:02
jschluetersince it's repeated in almost the same exact form across many images18:02
mgoddard+118:02
jschlueterbut beyond my current grasp to make it just work yet18:03
mgoddardI proposed a patch that added a common variables file, similar to macros, but just some shared variables18:03
mgoddardhttps://review.openstack.org/64271318:04
mgoddardcould be used to create e.g. wsgi_packages variable18:04
jschlueterack18:05
* jschlueter on wind down for this week ... I'm taking PTO next week18:05
* jschlueter EBRAINFULL18:06
mgoddardnice, enjoy jschlueter18:06
jschluetermgoddard: but good idea and might be useful for where we have repeated package lists across a lot of container images18:06
*** gfidente has quit IRC18:14
*** dougsz has quit IRC18:23
*** ivve has quit IRC18:36
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Add CI job for ironic  https://review.openstack.org/56882918:36
*** gmann_afk is now known as gmann18:40
*** itlinux has quit IRC18:55
*** sshnaidm|rover is now known as sshnaidm|off19:03
jschlueterhttp://logs.openstack.org/09/645209/2/check/kolla-build-oraclelinux-source/b4b62ca/logs/build/000_FAILED_grafana.txt.gz19:10
jschluetergot failure on trying to download/extract INFO:kolla.common.utils.grafana:from url: https://grafana.com/api/plugins/gnocchixyz-gnocchi-datasource/versions/1.7.0/download19:10
jschlueteris that known?19:10
openstackgerritMark Goddard proposed openstack/kolla stable/pike: Fix rabbitmq container error, oraclelinux and percona  https://review.openstack.org/64519719:17
*** vblando has quit IRC19:21
*** hjensas has joined #openstack-kolla19:28
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Add CI job for ironic  https://review.openstack.org/56882919:28
*** luksky has joined #openstack-kolla19:29
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664019:31
openstackgerritMark Goddard proposed openstack/kolla-ansible master: Check containers during kolla-ansible check  https://review.openstack.org/59973519:33
openstackgerritMark Goddard proposed openstack/kolla-ansible master: Check containers during kolla-ansible check  https://review.openstack.org/59973519:33
*** iniazi_ has joined #openstack-kolla19:45
*** iniazi has quit IRC19:48
hrwjschlueter: I prefer granular patches if possible as they are easier to review. But if you need to make a series of small patches (depending on order) then sometimes it is better to collapse them into smaller amount of bigger patches.19:49
hrwjschlueter: longer the series, longer to review/CI/merge19:50
hrwjschlueter: you do not want to beat my record of 50 (fifty) revisions of one patch19:50
openstackgerritMerged openstack/kolla stable/rocky: Pin sensu mailer and slack plugins, fix rabbitmq  https://review.openstack.org/64516419:51
*** Sravan has quit IRC20:00
*** Sravan has joined #openstack-kolla20:04
*** Sravan has quit IRC20:05
*** Sravan has joined #openstack-kolla20:07
jschlueterhrw: ack thanks, got it20:09
jschlueteras long as I can keep them clean for number of revisions, conflicts keep them small, and if some order keep them stacked otherwise start collecting into larger patches for review/work load for check/gate jobs20:10
jschlueterhmm looks like there was an issue with grafana plugin install20:20
jschlueterdo you guys track what failure modes are most common transient failure modes?20:20
*** dciabrin_ has joined #openstack-kolla20:25
*** dciabrin has quit IRC20:27
rwellumHi folks, is Kolla-Ansible ok installing on Ubuntu 18.04? I ask because 'bootstrap-servers' is failing due to this version of Ubuntu having removed the 'easy_install' scripts (https://bugs.launchpad.net/ubuntu/+source/python-setuptools/+bug/1774419)20:55
openstackLaunchpad bug 1774419 in python-setuptools (Ubuntu) "easy_install command is missing" [Undecided,Confirmed]20:55
*** iniazi_ has quit IRC21:02
*** mjturek has quit IRC21:06
*** henriqueof has quit IRC21:07
*** baha has quit IRC21:11
*** iniazi_ has joined #openstack-kolla21:12
*** S4ren has joined #openstack-kolla21:31
*** pcaruana has quit IRC21:33
*** S4ren has quit IRC21:33
*** JamesBenson has quit IRC22:01
*** yankcrime has quit IRC22:04
*** irclogbot_1 has quit IRC22:05
*** mgoddard has quit IRC22:08
*** mgoddard has joined #openstack-kolla22:09
*** ivve has joined #openstack-kolla22:11
*** dciabrin_ has quit IRC22:13
*** dciabrin__ has joined #openstack-kolla22:13
openstackgerritMark Goddard proposed openstack/kolla-ansible master: WIP: Test upgrades in CI  https://review.openstack.org/61664022:19
*** tolisbar has joined #openstack-kolla22:56
*** tosky has quit IRC22:59
*** ivve has quit IRC23:27
*** luksky has quit IRC23:32
*** goldyfruit has quit IRC23:35
*** JamesBenson has joined #openstack-kolla23:40
*** wolverineav has joined #openstack-kolla23:40
*** JamesBenson has quit IRC23:45
*** wolverineav has quit IRC23:45

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!