Monday, 2017-01-02

*** tyrola has quit IRC00:00
*** tyrola has joined #openstack-kolla00:01
*** sacharya_ has quit IRC00:10
*** sacharya has joined #openstack-kolla00:11
sdake_sup peeps00:13
sdake_happy new year!00:13
sdake_kfox1111 about?00:14
*** haplo37_ has quit IRC00:15
sbezverksdake_: hey early return from pto ;-)?00:20
sdake_ya the svp/vp has summoned me to sjc on the 3rd00:21
sdake_so prepping a bit00:21
*** sdake_ is now known as sdake00:21
sdakehow about you?00:21
sbezverknot much, just relaxing00:22
sbezverkare you an expert in go by any chance?00:23
*** Pavo has quit IRC00:23
*** haplo37_ has joined #openstack-kolla00:23
*** Pavo has joined #openstack-kolla00:25
sdakenope00:25
sdakehaven't even picked up my go book yet00:25
sdake;)00:25
sdakealthough I do plan to consume it when the time is right for me00:26
sdakewhich is not now00:26
sdakesbezverk mind updtiang me on where kola-k8s is atm00:26
sdakei've been on pto for a couple weeks00:26
sdakemicroservices done?00:26
sbezverksdake: most of microservices is done00:30
sdakeare things moving to a more hiearcharal approach?00:31
sdakei.e. when the service layer is done, will the  new features in helm we asked for solve the problems we have?00:31
sbezverkover the christmas I used Kevin's ceph gate and built iscsi/lvm gate00:31
sdakethe new features we asked for that have already been implemented rather00:32
sdakenice gating work fttw :)00:32
sbezverksdake: as far as I know there is no show stopper from helm perspective atm00:32
sdakeso helm install openstack can be a thing00:32
sdakewith only a limited set of components deployed?00:32
sdakeor mix and match?00:33
sbezverkwe are not there yet, we still have not finialized api00:33
sbezverkbut I do not see why not00:33
sdakeok - so lets say the api was finalized00:33
sdakeis current helm gap free?00:34
sbezverkno show stoppers afaik00:34
sdakenice00:34
sdakeneed to get back into reviewing the implementation00:34
sdakei'll be back in the office after the 6th00:34
sdakegiven that i'm in sjc from 4th-6th00:34
sdakeand traveling the 3rd00:35
sdakeso expect some reviews then :)00:35
sdakeare we good to go for a release on the 4th?00:35
sbezverkwell I mean this release is just a milestone just for papers00:35
Pavowow the channel is ALIVE!!!!!!!!!!!00:36
sdakejust a milestoen to close somethign out00:36
sdakesup pavo00:36
Pavohappy new years everyone btw00:36
sdakewe finished the job on microservices - would like that closed out this milestone if possible00:36
sdakehappy new years pavo :)00:36
Pavoand cherro sdake00:36
sbezverksdake: if something left is just minor. The main goal is finalize api. if it is well designed, then we will have flexibility we need to address different type of deployment00:41
sbezverkI need to find go expert :-) I came accross a piece of code, need to understand it00:42
sdakesbezverk danehans00:42
sdakesbezverk i know a few others00:42
sdakesbezverk asalkeld if he is around00:42
*** salv-orlando has joined #openstack-kolla00:43
sdakesbezverk most people off on pto atm00:43
sdakeasalkeld out of all the people i know that co uld help is probably your best bet atm00:43
sbezverksdake: cool, thanks I will ping him when he shows up00:43
sdakemight try him via other comms channels - not sure if he still keeps an irc window open or not00:44
sdakewirehead would know a bunch of goberts00:44
sdakewirehead_ ^^00:44
sdakesbezverk how close is the api to being finalized?00:45
sbezverksdake: hard to say, kfox1111 had some ideas before the holidays but he did not psu any reviews..00:47
sdakeroger00:47
*** salv-orlando has quit IRC00:48
*** jmccarthy has quit IRC00:50
*** jmccarthy has joined #openstack-kolla00:51
*** saneax is now known as saneax-_-|AFK00:53
*** sacharya has quit IRC01:17
*** Pavo has quit IRC01:40
*** Pavo has joined #openstack-kolla01:40
*** salv-orlando has joined #openstack-kolla01:44
*** salv-orlando has quit IRC01:48
*** sdake_ has joined #openstack-kolla01:52
*** sdake has quit IRC01:54
*** sdake_ has quit IRC02:08
*** sacharya has joined #openstack-kolla02:11
*** eaguilar has quit IRC02:17
*** sdake has joined #openstack-kolla02:18
*** david-lyle has joined #openstack-kolla02:35
*** david-lyle has quit IRC02:39
*** sp_ has joined #openstack-kolla02:41
*** salv-orlando has joined #openstack-kolla02:44
*** Pavo has quit IRC02:48
*** salv-orlando has quit IRC02:49
sdaketime for sherlock!!02:55
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: Optimize reconfigure action for glance  https://review.openstack.org/40697802:58
*** Jeffrey4l__ has joined #openstack-kolla03:05
*** l4yerffeJ has quit IRC03:08
*** Jeffrey4l_ has quit IRC03:09
*** Pavo has joined #openstack-kolla03:09
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: Optimize reconfiguration for keystone  https://review.openstack.org/40893303:10
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: Optimize reconfigure action for nova  https://review.openstack.org/40741603:10
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: Optimize reconfigure action for memcached  https://review.openstack.org/41222503:10
*** Pavo has quit IRC03:16
*** Pavo has joined #openstack-kolla03:40
*** salv-orlando has joined #openstack-kolla03:45
*** sacharya has quit IRC03:47
*** salv-orlando has quit IRC03:50
*** Pavo has quit IRC03:56
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: Support multi key in merge_config module  https://review.openstack.org/41210103:59
*** Pavo has joined #openstack-kolla04:01
*** sdake has quit IRC04:07
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: TEST MASTER BRANCH  https://review.openstack.org/39809504:11
*** bmace has quit IRC04:13
*** bmace has joined #openstack-kolla04:14
*** sp_ has quit IRC04:18
*** mdnadeem has joined #openstack-kolla04:26
*** Pavo has quit IRC04:29
*** sdake has joined #openstack-kolla04:32
*** sdake_ has joined #openstack-kolla04:36
*** david-lyle has joined #openstack-kolla04:36
openstackgerritMerged openstack/kolla-ansible: Add empty precheck.yml file for tacker and octavia  https://review.openstack.org/41512004:39
*** sdake has quit IRC04:40
*** david-lyle has quit IRC04:41
*** Pavo has joined #openstack-kolla04:45
*** Pavo has quit IRC04:45
*** salv-orlando has joined #openstack-kolla04:46
*** salv-orlando has quit IRC04:51
*** l4yerffeJ has joined #openstack-kolla05:06
openstackgerritJeffrey Zhang proposed openstack/kolla: Add tarballs-base parameter for kolla-build  https://review.openstack.org/39683005:06
*** l4yerffeJ has quit IRC05:07
*** l4yerffeJ has joined #openstack-kolla05:07
*** mdnadeem has quit IRC05:18
openstackgerritJeffrey Zhang proposed openstack/kolla: packing and uploading registry  https://review.openstack.org/40443505:20
*** skramaja has joined #openstack-kolla05:22
*** coolsvap has joined #openstack-kolla05:24
*** mdnadeem has joined #openstack-kolla05:45
*** sacharya has joined #openstack-kolla05:47
*** salv-orlando has joined #openstack-kolla05:47
*** sdake has joined #openstack-kolla05:48
*** sdake_ has quit IRC05:51
*** salv-orlando has quit IRC05:51
*** mdnadeem has quit IRC05:52
*** mdnadeem has joined #openstack-kolla05:54
*** sacharya has quit IRC05:55
*** saneax-_-|AFK is now known as saneax06:08
*** satyar has joined #openstack-kolla06:15
*** mdnadeem_ has joined #openstack-kolla06:28
*** mdnadeem has quit IRC06:28
*** salv-orlando has joined #openstack-kolla06:29
*** sdake has quit IRC06:31
*** sdake has joined #openstack-kolla06:38
*** mdnadeem_ has quit IRC06:53
*** mdnadeem has joined #openstack-kolla06:53
openstackgerritSteven Dake proposed openstack/kolla-kubernetes: Add kolla-kubernetes tags to README.rst  https://review.openstack.org/41601107:08
openstackgerritSteven Dake proposed openstack/kolla-kubernetes: Updated README.rst with deliverable information  https://review.openstack.org/41601207:08
openstackgerritSteven Dake proposed openstack/kolla-kubernetes: Add Kolla project mission  https://review.openstack.org/41601307:11
*** salv-orl_ has joined #openstack-kolla07:13
*** salv-orlando has quit IRC07:16
openstackgerritSteven Dake proposed openstack/kolla-kubernetes: Standardize the documentation a bit more related to README.rst  https://review.openstack.org/41601407:16
*** pcaruana has joined #openstack-kolla07:23
*** sdake has quit IRC07:28
*** sdake has joined #openstack-kolla07:37
*** coolsvap has quit IRC07:39
openstackgerritMerged openstack/kolla-kubernetes: Use assertGreater(len(x), 0) instead of assertTrue(len(x) > 0)  https://review.openstack.org/40188408:12
openstackgerritSteven Dake proposed openstack/kolla: Enable zookeeper for CentOS/OracleLinux  https://review.openstack.org/40996508:21
*** salv-orl_ has quit IRC08:30
*** msimonin has joined #openstack-kolla08:31
openstackgerritSteven Dake proposed openstack/kolla: Fix docs to require docker config on all nodes  https://review.openstack.org/38085108:32
*** mdnadeem has quit IRC08:36
*** mdnadeem has joined #openstack-kolla08:36
*** sdake has quit IRC08:38
*** salv-orlando has joined #openstack-kolla09:02
*** msimonin has quit IRC09:05
*** msimonin has joined #openstack-kolla09:05
*** msimonin has quit IRC09:05
*** haplo37 has quit IRC09:10
*** haplo37_ is now known as haplo3709:10
*** haplo37_ has joined #openstack-kolla09:14
*** sacharya has joined #openstack-kolla09:52
*** sacharya has quit IRC09:57
*** prameswar has joined #openstack-kolla10:15
*** satyar has quit IRC10:27
*** chas has joined #openstack-kolla10:52
*** haplo37_ has quit IRC11:02
*** haplo37_ has joined #openstack-kolla11:05
*** msimonin has joined #openstack-kolla11:16
*** msimonin has quit IRC11:23
*** msimonin has joined #openstack-kolla11:23
*** msimonin has quit IRC11:23
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move trove precheck into its own role  https://review.openstack.org/41603211:27
* berendt is back from the holiday11:29
*** JoseMello has joined #openstack-kolla11:29
*** skramaja has quit IRC11:46
*** sacharya has joined #openstack-kolla11:53
*** sacharya has quit IRC11:57
*** salv-orlando has quit IRC12:04
*** eaguilar has joined #openstack-kolla12:19
openstackgerritnarasimha18sv proposed openstack/kolla: user wont be associated to project is ldap is keystone backend  https://review.openstack.org/41604312:21
openstackgerritnarasimha18sv proposed openstack/kolla: user wont be associated to project is ldap is keystone backend  https://review.openstack.org/41604312:23
*** msimonin has joined #openstack-kolla12:28
*** saneax is now known as saneax-_-|AFK12:29
*** msimonin has quit IRC12:32
*** salv-orlando has joined #openstack-kolla12:41
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: optimize bootstrap.yml file  https://review.openstack.org/41550412:56
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: optimize register  https://review.openstack.org/41604612:56
*** pcaruana has quit IRC13:00
*** mdnadeem has quit IRC13:04
*** pcaruana has joined #openstack-kolla13:04
*** salv-orl_ has joined #openstack-kolla13:13
*** salv-orl_ has quit IRC13:15
*** salv-orlando has quit IRC13:16
*** msimonin has joined #openstack-kolla13:18
*** zhubingbing has joined #openstack-kolla13:19
*** zhubingbing has quit IRC13:21
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move sahara precheck into its own role  https://review.openstack.org/41605113:22
*** zhubingbing has joined #openstack-kolla13:23
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move sahara precheck into its own role  https://review.openstack.org/41605113:23
*** msimonin has quit IRC13:30
*** msimonin has joined #openstack-kolla13:30
*** msimonin has quit IRC13:30
*** sdake has joined #openstack-kolla13:34
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move tacker precheck into its own role  https://review.openstack.org/41605213:36
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move tacker precheck into its own role  https://review.openstack.org/41605213:38
sdakemorning peeps13:41
*** david-lyle has joined #openstack-kolla13:43
openstackgerritnarasimha18sv proposed openstack/kolla: user wont be associated to project is ldap is keystone backend  https://review.openstack.org/41604313:44
*** david-lyle has quit IRC13:47
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move grafana precheck into its own role  https://review.openstack.org/41605513:48
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: optimize register.yml file  https://review.openstack.org/41604613:49
openstackgerritMerged openstack/kolla: Add footer to Ceilometer base image  https://review.openstack.org/41574913:52
*** sacharya has joined #openstack-kolla13:54
kfox1111morning.13:54
*** sacharya has quit IRC13:59
*** zhubingbing has quit IRC14:01
*** zhubingbing has joined #openstack-kolla14:02
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move memcached precheck into its own role  https://review.openstack.org/41605914:04
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move memcached precheck into its own role  https://review.openstack.org/41605914:06
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move mongodb precheck into its own role  https://review.openstack.org/41606014:15
*** salv-orlando has joined #openstack-kolla14:15
*** zhubingbing has quit IRC14:17
*** satyar has joined #openstack-kolla14:20
*** salv-orlando has quit IRC14:21
*** zhubingbing has joined #openstack-kolla14:21
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move etcd precheck into its own role  https://review.openstack.org/41606314:23
berendtJeffrey4l__:  is it possible to exclude rax-iad for our gate jobs to avoid the issues with libvirt 2.0?14:25
Jeffrey4l__berendt, i do not think so.14:26
Jeffrey4l__it is controlled by infra team.14:26
kfox1111no control over where jobs land. :/14:27
kfox1111at least last I asked. Could hurt to ask again to see if they have a way to exclude a broken provider?14:28
berendti had a quick look in project-config repository but i have not seen a way to exclude a provider14:31
berendtlet's ask in openstack-infra, maybe it is possible14:31
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move ceph precheck into its own role  https://review.openstack.org/41606614:33
berendtdone14:34
sbezverkgood morning14:37
kfox1111morning.14:37
kfox1111sorry I disapeared there for a while. got the flu. :/14:37
sbezverkkfox1111: I know the feeling, I got cold for whole holidays..14:38
kfox1111:/14:38
kfox1111yeah. its going around. no fun. :/14:38
sbezverkkfox1111: I chatted with sdake last night and he asked to send him a summary of the current state of API14:39
sdakesup kfox111114:39
sdakesorry to hear about the flu14:39
kfox1111sbezverk: hi.14:39
sdakekfox1111 ya - if you could spend 5-10 minutes writing an email to me about state of the api I'd appreciate it14:39
sdakeor better yet, the mailing list14:39
sbezverkkfox1111: ignore my last post, sdake is here14:39
sdakesbezverk morning fine sir :)14:40
sbezverksdake: good morning14:40
kfox1111sdake: I'll see what I can do.14:40
sdakekfox1111 cool - need before 4th if possible14:40
sdakekfox1111 a TLDIDread versio nwould be helpful :)14:40
sdakesay - I have some rubber stamp documentaiton changes in kolla-kubernetes I submitted yesterday14:41
sdakesince both sbezverk and kfox1111 are about, can you guys stamp em :)14:41
kfox1111trying to get a new prototype into review real quick.14:41
kfox1111links?14:41
sdakekfox1111 moment on links14:41
sbezverkkfox1111: I would like to close a loop with lvm/iscsi gate.. I am ok to go back later and get it modularized14:41
sdakehttps://review.openstack.org/#/c/416014/14:42
sdakehttps://review.openstack.org/#/c/416013/114:42
openstackgerritcaoyuan proposed openstack/kolla-ansible: Move horizon precheck into its own role  https://review.openstack.org/41606814:42
sdakehttps://review.openstack.org/#/c/416012/114:42
sdakehttps://review.openstack.org/#/c/416011/114:42
satyarHi sdake14:42
sdakesup satyar14:43
sdakesbezverk i think going back later could be a mistake - maintenance of two gate jobs will be a huge pita :)14:43
sdakesbezverk but whatever works14:43
sdakesbezverk as long as we keep it experimental until the scripts are unified, it makes little difference14:44
sbezverksdake: unifiying the script is mistake imho because then you get nightmare of maitaining it. getting reusable small modules is good thing, but I would like to concentrate on another thing now...14:45
kfox1111sdake: all look good to me.14:45
sdakekfox1111 thanks14:45
kfox1111sbezverk: k. I'll try and review soon.14:45
sbezverkso it is either it gets merged as is, since it is working, or gets postponed until better time14:46
sdakesbezverk can you +2/+w those readme.rst links above14:46
satyarsdake i am getting an issue where cinder volume is using very high cpu ans the mysql and rabbit connections getting lost14:46
sdakeagain see no issue with merging as is, since the job is experimental14:46
sdakeit just means nobody will maintain it until its atleast non-voting :)14:46
sdakesatyar no idea what causes that - try ask.openstack.org (see topic)14:46
*** zhubingbing has quit IRC14:47
satyarbug is raised by someone14:47
satyarhttps://bugs.launchpad.net/cinder/+bug/165296114:47
openstackLaunchpad bug 1652961 in Cinder "Cinder Volume and rabbitmq connections is getting terminated very frequently" [Undecided,Confirmed]14:47
kfox1111sbezverk: yeah, I agree with sdake. which I stated in an earlier review.14:47
kfox1111sbezverk: I think we're probably not done working on ceph_workflow as part of the api changes. so will have to start tweaking it in 3 places with that new file.14:47
sdakethe general idea of experimental jobs is they are promoted to non-voting after a short period and voting if possible14:48
sdakevoting gates are a bit of a problem with kolla since we rely on so much external infrastructure14:48
kfox1111ok... this code seems to be holding up.14:48
openstackgerritMerged openstack/kolla-kubernetes: Add kolla-kubernetes tags to README.rst  https://review.openstack.org/41601114:48
kfox1111I'll get it submitted for review.14:48
sdakei've been working to get it internalized to openstack but it is very difficult to get all the mirroring done14:48
openstackgerritMerged openstack/kolla-kubernetes: Updated README.rst with deliverable information  https://review.openstack.org/41601214:48
openstackgerritMerged openstack/kolla-kubernetes: Add Kolla project mission  https://review.openstack.org/41601314:48
sbezverksdake: I think keeping them experimental until final version is good approach14:48
openstackgerritMerged openstack/kolla-kubernetes: Standardize the documentation a bit more related to README.rst  https://review.openstack.org/41601414:48
sdakesbezverk you see the hceck experimental job fialed though? :)14:50
sdakesbezverk anyway - its a good first start - we can always iterate on that as long as the iscsi path for gating doesn't become the main path14:50
*** zhubingbing has joined #openstack-kolla14:50
sdakesbezverk i'd ask you file a tech debt bug so we can keep track of it14:51
kfox1111+1 for tech debt bug14:51
sdakewe did this early in kolla and it worked well until kolla became super large deliverable (and kolla-ansible)14:51
*** mdnadeem has joined #openstack-kolla14:51
sdakefor smaller deliverables, tech debt bugs work14:51
sdakenot smaller in scope, smaller in community14:51
sbezverksdake: because you started wrong PS ;-)14:51
sdakelarger community = tech debt bugs dont work14:51
sdakeoh did i :)14:52
sbezverksdake: there is another one based on the one you reviewed14:52
sbezverkthat one works for centos14:52
sdakeSteven Dake14:52
sdake12:38 AM14:52
sdake↩14:52
sdakePatch Set 19:14:52
sdakecheck experimental14:52
sdakepatch set 19 is where i ran check experiemtnal14:52
sbezverksdake: this one https://review.openstack.org/#/c/414348/14:52
sdakeand patch set 19 didn't pass14:52
kfox1111nice... trunk ceph_workflow only has one non configmap/secret reference to res create.14:52
sdakesbezverk got it14:53
sdakemoment14:53
kfox1111just gotta get that one done and the test ceph and we're in good shape. :)14:53
sdakequestion: https://review.openstack.org/#/c/414348/42/helm/all_values.yaml14:54
sdakeline 441 - is that on our wishlist for helm features14:54
*** msimonin has joined #openstack-kolla14:54
sbezverksdake: no14:54
kfox1111441? the image tag thing?14:55
sdakei think we should add templating of all_values.yaml right?14:55
sdakerather ask for it to be added14:55
sdakekfox1111 right the image tag templating14:55
kfox1111I've asked for some kind of child -> parent value merging.14:55
sdakecool tha twill work14:55
sdakehow did that go over? :)14:55
sbezverksdake: image tag here is just because iscsi gets supported since 3.0.014:55
sbezverkother microservices still use 2.0.214:56
sdakesbezverk i think we are talking about different things - i'm looking for gaps in helm14:56
kfox1111they acknowleged multiple folks wanting that. they just gotta figure out how to do it.14:56
sdakekfox1111 cool14:56
sbezverksdake: got it14:56
sdakekfox1111 if we could keep a list of github issues next to the wishlist item in the ehterpad - that would be helpful :)14:56
kfox1111that would be nice yes....14:57
kfox1111focus right now though is on api for the 4th...14:57
kfox1111afraid that's really tight with folks being sick. :/14:57
sdakeman reloading the brain is hard14:57
sdakeespeciall ywhen it wasn't loaded to begin with14:57
sdake(context I mean)14:57
kfox1111this new aproach should be quicker to implement then the previous attempt14:57
kfox1111but 2 days is really short.14:57
sdakekfox1111 if you need another week take it14:57
sdakewe have plenty :)14:58
kfox1111yeah. I think 1 more week would go a long way.14:58
sdakei'd still like to know what the api looks like prior to the 4th14:58
sdakekfox1111 you can change the schedule if you like in launchpad14:58
kfox1111I'm merging the lib code into a review right now.14:58
kfox1111should have it posted in the next hour for discussion.14:58
sdakeor i can do ti - up to you :)14:58
kfox1111sdake: please do. then I can continue on getting this up.14:58
sdakekfox1111 roger14:58
sdakesbezverk quick question - init containers are still beta in 1.5.0?14:59
sdakeor were they alpha in 1.4.0?14:59
sbezverkthey were alpha in 1.4 now bea in 15.14:59
sbezverkbeta that was14:59
kfox1111alpha in 1.4 beta in 15.14:59
sdakeand 1.6.0 will be released?14:59
* kfox1111 shrugs14:59
kfox1111they don't hold to timetables on that.14:59
sdakein general sounds like we can expect atleast 2 major kubernetes releases before api changes14:59
sbezverkthere is alpha in the master14:59
kfox1111they usually have an issue somewhere to track what needs to happen for feature graduation though.15:00
sbezverkfor 1.6.0 but I doubt anybody will play with it15:00
sdakesbezverk hate to be a noob but:15:00
sdake             "image": {{ include "kolla_toolbox_image_full" . | quote }},15:00
kfox1111yeah. its been very stable. they really should just graduate it.15:00
sdakewhat does the . doo in this line15:00
kfox1111sdake: its non obvious.15:01
kfox1111'.' is the current variables.15:01
sbezverksdake: it passes variables15:01
kfox1111current scope.15:01
kfox1111so passing '.' is passing everything the parent sees.15:01
sdakewill that work if we have nested charts?15:02
kfox1111yup.15:02
sdakecool15:02
sdakewhat data exactly does it put in there (the parser)15:02
sdakeya . makes sense - although your right non-obvious15:03
sdake.Values15:03
sdake. should be everything15:03
kfox1111helm builds out its values in the Values dict which goes in .15:03
kfox1111so .Values is the '.' dict, sub item, Values passed in from helm.15:03
kfox1111kind of weird. :/15:04
sdakeyup makes sense to me kfox111115:05
sdakenot sure how image: dictofallvalues makes sense15:06
sdakebut I'll go with it :)15:06
sdakenice work sbezverk  :) - and you fellas tought me something new today :)15:06
kfox1111heh. yeah.15:06
sdakeso last year I earned 40k SPG points15:07
sdakeI traded them in for 450$ in AMZN gift cards15:07
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606915:07
kfox1111sdake: :)15:10
kfox1111ok. there's the functions I came up with over vacation.15:10
sdakemy wife has like 120k in spg points and 120k in some other hotel15:10
sdakei think we are burning them all down into gift cards15:10
kfox1111the code itself looks kind of scary.15:10
kfox1111which I won't say it isnt... :)15:10
kfox1111but its ment to hide all the ugly logic into one, easy to reuse/debug place.15:11
sdakewow talk about hard to read ;-)15:11
kfox1111yeah. gotl was never intended to have code written in it.15:11
sdakekfox1111 you have heard - it takes someone twice as smart to read code as the original author was? :)15:12
kfox1111yeah. and the corralary,15:12
sdakekfox1111 i think if we dont make a habit out of such constructs15:12
sdakea one-off is probably ok15:12
kfox1111"if debugging is always harder then programming, then if you write your best code, you can't debug it" :)15:12
sdakemaking the entire code base like this would be super detrimental15:13
kfox1111sdake: agreed.15:13
kfox1111the rest of the code would look like the example usage. the templates would provide the valPath.15:13
kfox1111the macros would do a kolla_val_get_str with the key they were interested in, and then get the value back.15:14
kfox1111there was a previous attempt to do something just like it but a bit more automagical, but the value naming just doesn't fit well to automagical.15:15
kfox1111the docs on the functions are probably not the best. they were my first swag at them though.15:16
kfox1111so anything that in partcular helps folks wanting to understand the code we can stick in the docs woudl be great.15:16
*** salv-orlando has joined #openstack-kolla15:17
sdakekfox1111 i have one nitpick - the code is super hard to read - how about better comments on the functions - (see review)15:17
kfox1111the new set function really changes how templates can work.15:17
kfox1111sdake: yeah. +1 for better docs.15:17
sbezverkreading it with out example of code walk15:17
sbezverkin doc makes it I am afraid unusable15:18
kfox1111sdake: I waas wafling on one thing though. its bundled and pushed into configmaps I think in tiller.15:18
sdakekfox1111 nah I don't mean docs, just comments in the header15:18
kfox1111so not sure if it really belongs in the templates, or an... api document somewhere.15:18
sbezverksince only kfox111 will be able to debug it15:18
sdakekfox1111 we ca nburn that bridge when we get to it15:18
kfox1111k.15:18
sdakekfox1111 lets get the API model described in the code first :)15:18
sdakei gave a reasonable template you can use - others may work too15:19
kfox1111k.15:19
sdakeis ther erisk of comments breaking the implementation (assuming helm is bug free)15:19
kfox1111yeah. I looked for something like that for a bit but go doesn't seem to have one.15:19
sdakewe just made one up :)15:20
sdakeits more like a gotpl comment rather then a go comment right?15:20
kfox1111have a format for inputs / outputs/ example?15:21
*** salv-orlando has quit IRC15:21
sdakekfox1111 whatever works - I'd go with something like variable(type)15:21
kfox1111?15:21
sbezverksdake: maybe it will be more efficient just to add a doc instead of adding massive commenting to the code?15:23
sbezverkand in the code make a reference to the doc.15:23
kfox1111diaper change.... brb.15:23
sbezverkin the doc there is more freedom of expression15:24
sdakesbezverk code should be self-documenting15:36
sdakesbezverk from code docs should be generatable in a utopian (e.g. Python) universe :)15:36
kfox1111sdake: heh.15:36
kfox1111sdake: languages should be used that allow self documenting. ;)15:37
kfox1111gotl, not so much.15:37
sdakeyup15:37
sdakesince its a one time thing15:37
sdakeits not of much bother i think15:37
sdakeunless we plan a scorched earth policy to the codebase to implement defines like these15:37
kfox1111should be pretty isolated to just this one file.15:38
kfox1111went to the urgent care place when on travel. got a good inhailer. cough's finally under control. helps so much.15:41
*** salv-orlando has joined #openstack-kolla15:41
kfox1111breathing's so overratted until you can't... :)15:41
kfox1111sdake: not sure what you would like the example to look like15:42
kfox1111thoughts?15:42
sdakeyou posted an example in the review15:43
sdakesomething like that but simplier?15:43
sdakejust a one line15:43
sdakeone liner15:43
sdake"Usage: xyz"15:43
kfox1111ah. so, like example of how its calld, not a full working example?15:44
sdakeright15:44
kfox1111k.15:44
sdakeusage probably better word then example :)15:44
* kfox1111 shrugs.15:44
*** david-lyle has joined #openstack-kolla15:45
sdakekfox1111 clearly yolu haven't seen the title of my blog :)15:45
SamYaplehola15:46
sdakesup SamYaple15:46
*** chas_ has joined #openstack-kolla15:47
SamYaplenot to much15:47
SamYaplei got mariadb+galera in salt done15:48
SamYapleit can autorecover from full cluster stops!15:48
SamYapleno additional steps or tasks15:48
kfox1111nice15:48
*** chas__ has joined #openstack-kolla15:48
*** david-lyle has quit IRC15:49
*** Pavo has joined #openstack-kolla15:50
*** chas___ has joined #openstack-kolla15:50
*** chas has quit IRC15:51
SamYapleThe only scenario I can find that it _wont_ recover from with _at_ _most_ the normal playbook run, is when you have a hard outage (like a power outage or kill -9) _and_ you lose a node at the same time15:52
*** chas_ has quit IRC15:52
SamYaplebut out side of that, it will autorecover from a power outage with a simple container start, no 'playbook' (or in saltstack, state run) needed15:52
*** chas__ has quit IRC15:53
*** sacharya has joined #openstack-kolla15:54
*** chas___ has quit IRC15:54
kfox1111aaaahhh.15:56
kfox1111sdake: not going to work.15:56
kfox1111just occurred to me. :)15:56
kfox1111well...15:56
kfox1111maybe..15:56
sdakeya its in a comment block15:56
sdakeif gotpl parses it properly it hsould work15:56
kfox1111might work..15:56
sdakedepends on order of operations15:56
kfox1111yeah...15:57
sdakecomments are typically first order15:57
sdakethey are handled by a preprocessor to strip them out in most languages15:57
sdakeno idea how gotpl works15:57
Pavonice to see the channel live again and good morning everyone15:57
kfox1111ok. I'm almost done. will post and see if it breaks.15:57
sdakepavo morning - although i'm about ready to dpeart for tech support with family :)15:58
kfox1111after cutting a release thought, we really probably should split it to a different file though.15:58
sbezverkkfox1111: .list where it is coming from?15:58
kfox1111sbezverk: uh, sec.15:58
kfox1111sbezverk: from the caller.15:58
sdakekfox1111 split the comments you mean?15:59
kfox1111sdake: move the documentation to its own file somewhere.15:59
sdakekfox1111 that is another option right away15:59
sbezverkkfox1111: I guessed ;-) but what it was populated with and where15:59
sdakeif it doesn't break the helm chart15:59
*** kristian__ has joined #openstack-kolla15:59
sdakelike file_readme.RST15:59
sdakeor file_README.rst15:59
*** rhallisey has joined #openstack-kolla15:59
kfox1111wouldn't be part of the chart. like put it under docs or something?15:59
kfox1111well...16:00
sdake"Ok those definitions looklike black magic and they are.  Here is what it does"16:00
kfox1111I think helm has a way to exclude stuff from being packaged.16:00
sdakecode should be kept near comments if possible :)16:00
sdakeinline commenting is best16:00
sbezverkkfox1111: yep helm ignore list16:00
sdakeout of file is a second alternative16:00
kfox1111sbezverk: can it ignore a dir?16:00
sdakekfox1111 ignore RST files16:01
sbezverkkfox1111: no idea, sorry16:01
kfox1111could we make a docs dir under kolla-common/ and have a rst file per template?16:01
sdakekfox1111 that will be really hard to maintain16:01
sbezverkI think we can make rst files and ignore them16:01
kfox1111sdake: would only use it for the templates that would need that level of documenation.16:01
sbezverkregardless of their location16:01
kfox1111which is like 3 maybe.16:01
sdakecool lets just put em in the charts dir and use helmignore16:02
kfox1111k. can try that.16:02
sdakenobody will ever look at those docs unless they are devs16:02
sdakeand we can link it from docs dir16:02
kfox1111works for me.16:02
kfox1111sbezverk: have a link to an example of that handy somewhere?16:02
sbezverksdake: so self documenting code is not the only solution ;-)16:02
sbezverkkfox1111: looking16:03
kfox1111sbezverk: but the perfered one. :)16:03
sdakein this case rst sort of kills two birds with one stone16:03
sdakeI would leave a comment at the top of the file saying "please update the readme if changing the api" :)16:04
*** chas has joined #openstack-kolla16:04
kfox1111sdake: isn't that always true? :)16:04
sdakesaw rogue one over holidays at ipic16:04
kfox1111and what reviewers are for? :)16:04
sdakefantastic movie16:04
kfox1111nice. I'm looking fowarard to it.16:05
kfox1111no spoilers. ;)16:05
sdakenothing to be said16:05
sdakeother  then if you watch any movie from 2016, thats one of em  :)16:05
*** Pavo has quit IRC16:05
sdakesbezverk is rogue one available in ca atm in theaters?16:06
rhalliseyI saw la la land instead of star wars sdake  :)16:07
sdakela la land16:07
sdakehrm16:07
rhalliseylol16:07
sdakehavne't heard of that one ;)16:07
sbezverkkfox1111: it seems you need to use .helmignore16:07
sbezverkall files in it will be not included in rendering process16:08
sdake*.RST should do the trick16:08
sdakerather *.rst16:08
kfox1111k16:08
kfox1111thx.16:08
sbezverkthe main question is do we need it at parent only or every subcharts too16:09
sdakedo we need rsts int  he packagedd charts?16:09
sbezverksdake: do not think so16:09
sdakeeverywhere makes sense to me if thats the case16:10
sdakeclearly gotpl commenting is deficient16:10
sdakeand we will have to maintain comments in rst files outside in some casess16:10
kfox1111parnet charts shouldn't need it unless they get rst's too.16:11
sdakeplanet charts ftw ;)16:11
*** Pavo has joined #openstack-kolla16:11
kfox1111I have no idea how you might want this rst formatted, so I'll just hack something real quick and you can comment.16:11
sbezverkkfox1111: helm_prebuild_micro could take care of copying .helmignore if it exists16:12
sdakehey fellas - i know i've been on PTO awhile, however, I will be traveling the 3rd-6th16:12
kfox1111sbezverk: +1.16:12
sdakeso will be OOO then as well16:12
kfox1111k16:12
sdakei'll spend an hour at night reviewing after our meetings finish up assuming they dont run until 10pm :)16:13
kfox1111k. hows this look?16:13
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606916:13
openstackgerritJeffrey Zhang proposed openstack/kolla-ansible: Support multi key in merge_config module  https://review.openstack.org/41210116:14
SamYaplerhallisey: yo!16:14
rhalliseySamYaple, hey!16:14
SamYaplerhallisey: ive spent the last week digging into all things galera recovery16:15
*** matrohon has joined #openstack-kolla16:15
*** Pavo has quit IRC16:15
rhalliseynice! Anything interesting?16:15
SamYaplein kolla-salt it is now setup in such a way it can autorecover from most situations16:15
sbezverkkfox1111: I did not get relation between .Values and .list I thought you walk through .list to get value defined, no?16:15
SamYaple_without_ --wsrep-new-cluster16:15
*** Pavo has joined #openstack-kolla16:15
kfox1111list is the list of locations to check in .Values.16:16
kfox1111it could be renamed to something else if it would make it more clear.16:16
SamYaplewith --wsrep-new-cluster it has to perform a full SST and transfer _all_ data again, which isnt great if you have a large database, so it should be avoided where possible16:16
rhalliseySamYaple, so is it applying the proper workflow? Or does galera have most the tools in place?16:16
SamYaplerhallisey: both16:16
rhalliseyok16:17
SamYaplerhallisey: so if gvwstate.dat file exists, then the node was likely running when it crashed. we can start up all mariadb with gvwstate.dat file and it will sync with the cluster and come online16:17
sbezverkkfox1111: yes please renaming it to something like checkpoints or in this area would be helpfull16:18
kfox1111checkpoints?16:18
kfox1111hmmm..16:18
sbezverkkfox1111: maybe wrong example :)16:18
kfox1111I refer to it as valPath in other places.16:18
kfox1111maybe that?16:19
sbezverkthere might be multiple path in valPath?16:19
kfox1111right.16:20
kfox1111{{- $valPathB := ":global.kolla.a:global.kolla.b:global.kolla.c" }}16:20
sbezverkhow about pathInValues?16:20
kfox1111there are multiple though.16:21
kfox1111pathsInValues?16:21
sbezverkit shows relation between them just by reading var name16:21
kfox1111searchPath?16:21
sbezverkI like searchPath16:21
kfox1111valPath?16:21
kfox1111valuesPath?16:21
kfox1111k.16:22
kfox1111searchPath sounds good to me too. just doesn't have the tie back to values quite as much.16:22
sbezverksearchPath tels exactly what you will do :)16:22
kfox1111yeah.16:22
*** sdake has quit IRC16:23
*** Pavo has quit IRC16:23
*** Pavo has joined #openstack-kolla16:24
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606916:25
kfox1111k. here's it with s/list/searchPath/16:25
sbezverkkfox1111: each microservice will have it is own code to build searchPath or it will be another macro?16:26
kfox1111wherever's easiest.16:26
kfox1111so for things like common_deployment, that can probably be built right in the common_deployment macro16:27
kfox1111same with common_service.16:27
kfox1111for things that don't have a common thing, they can define it however needed.16:27
kfox1111I can prototype that up farily quickly I think.16:28
sbezverkkfox1111: ok so what are searchPath can be? .Values .Values.globals what else?16:28
kfox1111kind of the same thing we were talking about before with the layers.16:29
kfox1111it was working quite well for most things,16:29
kfox1111but ran into issue with things like neutron-create-keystone-endpoints16:29
kfox1111it needs to see neutron-server port's config value.16:29
sbezverkkfox1111: if I understand the use case correctly searchPath is mainly to address disconnected configurable items, right?16:30
kfox1111so like ":globals.kolla.neutron-server.all:globals.kolla.all"16:30
kfox1111yeah. you set the "default" value in the farthest to the right side of things, and then the user can easily overwrite the default at any of the steps in the search path.16:31
sbezverkkfox1111: ok got it16:31
openstackgerritMerged openstack/kolla: Move Kafka down to the "Infrastructure components" section  https://review.openstack.org/41390916:32
sbezverkit is like a "hint" for more prefered option..16:32
kfox1111exactly.16:32
kfox1111ok. I gota get ready to pick up the dog from the kennel. be back in about an hour.16:33
sbezverkttyl16:33
kfox1111so, I think the older layered functions can be simply rewritten on top of these other functions.16:33
kfox1111they just specify the default searchPath.16:34
sbezverkkfox1111: to make things easier we need to merge some non intrusive changes to all_values.yaml and maybe as a separate PS merge these three macro16:39
sbezverkin this case mutliple people can play with it..16:39
sbezverkwithout massive merge conflicts16:40
*** tyrola has quit IRC16:42
*** tyrola has joined #openstack-kolla16:43
*** kristian__ has quit IRC16:47
*** dave-mccowan has joined #openstack-kolla16:53
*** Pavo has quit IRC17:00
kfox1111back.17:05
kfox1111sbezverk: yeah. sounds good. :)17:07
sbezverkkfox1111: you need to change helm_prebuild17:09
sbezverkto copy .helmignore to microservices17:09
sbezverkotherwise the gate is failing17:09
kfox1111k.17:11
*** Pavo has joined #openstack-kolla17:18
*** msimonin has quit IRC17:29
*** msimonin has joined #openstack-kolla17:29
*** msimonin has quit IRC17:30
*** msimonin has joined #openstack-kolla17:30
*** msimonin has quit IRC17:30
*** msimonin has joined #openstack-kolla17:31
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: Visual feedback  https://review.openstack.org/41607717:31
*** msimonin has quit IRC17:31
*** msimonin has joined #openstack-kolla17:31
*** mdnadeem has quit IRC17:32
*** msimonin has quit IRC17:32
*** msimonin has joined #openstack-kolla17:32
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606917:45
*** NachoDuck has quit IRC17:51
*** macsz has quit IRC17:51
*** JoseMello has quit IRC17:52
*** kelv has quit IRC17:52
*** mgkwill has quit IRC17:52
*** sindhu has quit IRC17:52
*** turvey has quit IRC17:53
*** qwang has quit IRC17:53
*** peterjenkins_ has quit IRC17:53
*** macsz has joined #openstack-kolla17:55
*** JoseMello has joined #openstack-kolla17:55
*** kelv has joined #openstack-kolla17:56
*** mgkwill has joined #openstack-kolla17:56
*** sindhu has joined #openstack-kolla17:56
*** NachoDuck has joined #openstack-kolla17:57
*** qwang has joined #openstack-kolla17:57
*** turvey has joined #openstack-kolla17:57
*** peterjenkins_ has joined #openstack-kolla17:57
*** dave-mccowan has quit IRC17:57
*** salv-orlando has quit IRC18:04
*** salv-orlando has joined #openstack-kolla18:05
*** sacharya has quit IRC18:08
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606918:15
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606918:17
*** prameswar has quit IRC18:42
*** dave-mccowan has joined #openstack-kolla18:51
*** haplo37_ has quit IRC18:51
*** chas has quit IRC18:52
*** chas has joined #openstack-kolla18:54
*** haplo37_ has joined #openstack-kolla18:54
*** sacharya has joined #openstack-kolla19:08
*** sacharya has quit IRC19:13
*** salv-orl_ has joined #openstack-kolla19:14
*** salv-orlando has quit IRC19:17
*** salv-orl_ has quit IRC19:25
kfox1111yeah.... this I think will work out nicely.19:31
*** cliles has quit IRC19:32
*** cliles has joined #openstack-kolla19:33
*** eaguilar_ has joined #openstack-kolla19:48
*** eaguilar has quit IRC19:49
*** dave-mccowan has quit IRC19:58
openstackgerritMerged openstack/kolla-ansible: Enable magnum dashboard when enable_magnum is yes  https://review.openstack.org/40535119:59
*** pcaruana has quit IRC20:00
*** JoseMello has quit IRC20:05
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606920:06
*** sacharya has joined #openstack-kolla20:13
*** sacharya has quit IRC20:17
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606920:32
*** eaguilar_ has quit IRC20:39
*** satyar has quit IRC20:43
*** Pavo has quit IRC20:45
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606920:47
*** david-lyle has joined #openstack-kolla20:48
*** david-lyle has quit IRC20:52
*** salv-orlando has joined #openstack-kolla20:55
*** pcaruana has joined #openstack-kolla21:00
*** salv-orlando has quit IRC21:00
*** salv-orlando has joined #openstack-kolla21:01
SamYapleanyone want to review https://review.openstack.org/#/c/415908/ ?21:15
SamYapleit kinda falls under security. kinda21:15
*** pcaruana has quit IRC21:20
*** chas_ has joined #openstack-kolla21:24
*** chas has quit IRC21:27
*** l4yerffeJ_ has joined #openstack-kolla21:33
*** Jeffrey4l__ has quit IRC21:34
*** l4yerffeJ has quit IRC21:35
*** Jeffrey4l__ has joined #openstack-kolla21:36
*** chas_ has quit IRC21:38
*** chas has joined #openstack-kolla21:38
*** pcaruana has joined #openstack-kolla21:42
*** chas has quit IRC21:43
*** chas has joined #openstack-kolla21:46
*** chas_ has joined #openstack-kolla21:47
*** chas has quit IRC21:51
*** sdake has joined #openstack-kolla21:51
*** sdake has quit IRC21:56
*** chas has joined #openstack-kolla21:58
*** chas__ has joined #openstack-kolla21:59
*** chas_ has quit IRC22:01
*** chas has quit IRC22:02
*** pcaruana has quit IRC22:13
*** sacharya has joined #openstack-kolla22:14
*** sacharya has quit IRC22:19
*** david-lyle has joined #openstack-kolla22:49
*** david-lyle has quit IRC22:54
kfox1111nice.22:57
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606922:57
kfox1111I think this should work pretty well.22:57
SamYaplekfox1111: are you.... are you saying 'nice' to your own patches?23:01
kfox1111nice to the stuff helm is supporting.23:02
SamYaple:)23:02
kfox1111having a macro with no means of returning anything but a blob of text and no encoding/decoding is really really confining.23:03
kfox1111but the ability to tweak a dict has made all the difference.23:03
*** Pavo has joined #openstack-kolla23:04
sbezverkkfox1111: should we use globals instead of global to be consistent with helm?23:04
kfox1111hmm? is it not global?23:04
sbezverkhm, let me double check23:05
kfox1111I think the docs call it globals, but hwne you look ath there examples, it uses global.23:05
kfox1111I had it wrong the first time I tried it. :/23:05
sbezverkkfox1111: ok I think you are right.. it is global in yaml23:06
sbezverkI hope at one point we get rid of common: as it is clearly duplication of what global does..23:08
kfox1111which common?23:09
kfox1111oh.23:09
kfox1111yeah.23:09
openstackgerritKevin Fox proposed openstack/kolla-kubernetes: kolla-common value get functions  https://review.openstack.org/41606923:12
*** sacharya has joined #openstack-kolla23:13
*** msimonin has quit IRC23:16
*** msimonin has joined #openstack-kolla23:16
*** msimonin has quit IRC23:16
*** salv-orlando has quit IRC23:29
*** Hallfonce has joined #openstack-kolla23:33
HallfonceHello, I've been struggling for days trying to setup a kolla platform... Here is my case: https://ask.openstack.org/en/question/100970/kolla-aio-external-network-with-single-nic/23:36
HallfonceI've setup veth pairs, but it does not seem to be sufficient to reach my VMs23:37
Hallfonceam I missing anything?23:43
SamYapleHallfonce: you havent talked at all about the vms23:55
SamYaplealso, you havent posted anything confirming your veth pair setup (like brctl or ovs-vsctl outputs)23:56
HallfonceIn my post you mean?23:56
SamYapleanywhere as far as ive seen, yea23:57
Hallfoncewell I've tried both openvswitch and linuxbridge23:57
Hallfonceso with linuxbridge23:57
Hallfoncebrctl would show23:57
Hallfoncebr0 with veth0 and eth0 (enp0s31f6 in my case)23:58
HallfonceI tried an install with this setup, no success23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!