Tuesday, 2016-05-31

*** ssurana has quit IRC00:00
*** ssurana has joined #openstack-kolla00:03
*** salv-orlando has joined #openstack-kolla00:09
*** diogogmt has joined #openstack-kolla00:09
*** salv-orlando has quit IRC00:12
*** d_code has quit IRC00:16
*** godleon has joined #openstack-kolla00:20
*** ssurana has quit IRC00:20
*** ssurana has joined #openstack-kolla00:33
*** ssurana has quit IRC00:34
*** d_code has joined #openstack-kolla00:44
*** zhiwei has joined #openstack-kolla00:45
*** phuongnh has joined #openstack-kolla00:53
*** tfukushima has joined #openstack-kolla00:55
*** weiyu_ has joined #openstack-kolla01:07
*** salv-orlando has joined #openstack-kolla01:12
*** sacharya has joined #openstack-kolla01:12
*** sacharya has quit IRC01:17
*** salv-orlando has quit IRC01:17
*** britthouser has joined #openstack-kolla01:26
*** britthouser has quit IRC01:31
openstackgerritJeffrey Zhang proposed openstack/kolla: Log the traceback in the kolla libraries  https://review.openstack.org/28966701:40
openstackgerritJeffrey Zhang proposed openstack/kolla: DO NOT MERGE: TEST MASTER BRANCH  https://review.openstack.org/29490601:41
openstackgerritJeffrey Zhang proposed openstack/kolla: Pin the base distro release version  https://review.openstack.org/31999201:41
*** weiyu_ has quit IRC01:46
*** Jeffrey4l has joined #openstack-kolla01:50
*** weiyu_ has joined #openstack-kolla01:51
*** weiyu_ has quit IRC01:55
*** weiyu_ has joined #openstack-kolla01:56
*** sacharya has joined #openstack-kolla01:59
*** weiyu_ has quit IRC02:03
*** weiyu_ has joined #openstack-kolla02:04
*** daneyon_ has joined #openstack-kolla02:06
*** daneyon_ has quit IRC02:11
*** d_code has quit IRC02:32
*** salv-orlando has joined #openstack-kolla02:33
*** weiyu_ has quit IRC02:37
openstackgerritChris Ricker proposed openstack/kolla: Install missing package in spiceproxy container  https://review.openstack.org/32305402:37
*** salv-orlando has quit IRC02:38
*** fragatin_ has joined #openstack-kolla02:41
*** fragatin_ has quit IRC02:44
*** fragatin_ has joined #openstack-kolla02:45
*** fragatina has quit IRC02:45
*** sdake_ has joined #openstack-kolla02:46
*** yuanying has quit IRC02:47
*** fragatin_ has quit IRC02:49
*** sdake has quit IRC02:50
*** yuanying has joined #openstack-kolla02:52
*** weiyu_ has joined #openstack-kolla02:52
*** fragatina has joined #openstack-kolla02:57
*** fragatina has quit IRC03:02
*** sdake_ has quit IRC03:07
*** d_code has joined #openstack-kolla03:10
*** yuanying has quit IRC03:43
*** yuanying has joined #openstack-kolla03:47
*** fragatina has joined #openstack-kolla03:48
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/kolla: change keyfile to key  https://review.openstack.org/32058903:51
*** neophy has joined #openstack-kolla03:54
*** d_code has quit IRC03:59
*** mdnadeem has joined #openstack-kolla04:01
*** mdnadeem has quit IRC04:02
*** mdnadeem has joined #openstack-kolla04:03
*** mdnadeem has quit IRC04:09
*** mdnadeem has joined #openstack-kolla04:10
*** mdnadeem has quit IRC04:13
*** mdnadeem has joined #openstack-kolla04:13
*** mdnadeem has quit IRC04:18
*** mdnadeem has joined #openstack-kolla04:18
*** mdnadeem has quit IRC04:19
*** d_code has joined #openstack-kolla04:19
*** sacharya has quit IRC04:19
*** mdnadeem has joined #openstack-kolla04:19
*** sacharya has joined #openstack-kolla04:20
*** sacharya has quit IRC04:21
*** sacharya_ has joined #openstack-kolla04:21
*** salv-orlando has joined #openstack-kolla04:39
*** salv-orlando has quit IRC04:44
*** zhiwei has quit IRC05:04
openstackgerritJeffrey Zhang proposed openstack/kolla: Fix the cinder backup permission issue when enable ceph  https://review.openstack.org/32312105:04
*** zhiwei has joined #openstack-kolla05:04
*** unicell has quit IRC05:05
*** tfukushima has quit IRC05:05
*** unicell has joined #openstack-kolla05:06
*** unicell1 has joined #openstack-kolla05:08
*** sacharya_ has quit IRC05:09
*** unicell has quit IRC05:10
*** salv-orlando has joined #openstack-kolla05:31
*** diogogmt has quit IRC05:31
*** diogogmt has joined #openstack-kolla05:32
*** neophy has quit IRC05:46
openstackgerritJeffrey Zhang proposed openstack/kolla: DO NOT MERGE: TEST LIBERTY BRANCH  https://review.openstack.org/32313305:54
*** fragatina has quit IRC06:08
*** Mr_Broken has joined #openstack-kolla06:11
*** Mr_Broken has quit IRC06:15
*** Serlex has joined #openstack-kolla06:31
openstackgerritJeffrey Zhang proposed openstack/kolla: DO NOT MERGE: TEST LIBERTY BRANCH  https://review.openstack.org/32313306:34
*** Serlex has left #openstack-kolla06:39
*** Serlex has joined #openstack-kolla06:39
*** salv-orlando has quit IRC06:49
*** neophy has joined #openstack-kolla06:53
*** Serlex has quit IRC06:54
*** salv-orlando has joined #openstack-kolla06:59
*** neophy has quit IRC07:04
*** ravig has quit IRC07:04
*** Mr_Broken has joined #openstack-kolla07:05
*** sacharya has joined #openstack-kolla07:09
*** sacharya has quit IRC07:14
*** Serlex has joined #openstack-kolla07:23
*** salv-orlando has quit IRC07:29
*** mikelk has joined #openstack-kolla07:30
*** Jeffrey4l has quit IRC07:34
*** sdake has joined #openstack-kolla07:34
sdakeevening folks07:35
*** kklimonda_ has quit IRC07:47
*** kjelly has quit IRC07:57
*** Mr_Broke_ has joined #openstack-kolla08:02
coolsvapi suspect its not evening for you sdake08:02
coolsvappast midnight i suppose08:02
*** Mr_Broken has quit IRC08:05
*** sacharya has joined #openstack-kolla08:11
*** fragatina has joined #openstack-kolla08:12
*** sacharya has quit IRC08:16
*** mdnadeem has quit IRC08:16
*** mdnadeem has joined #openstack-kolla08:16
*** gfidente|afk is now known as gfidente08:16
*** dmk0202 has joined #openstack-kolla08:26
sdakecoolsvap whats up08:28
*** jmccarthy has left #openstack-kolla08:28
*** Serlex has quit IRC08:28
*** tfukushima has joined #openstack-kolla08:31
*** jmccarthy has joined #openstack-kolla08:31
*** sdake_ has joined #openstack-kolla08:32
openstackgerritSteven Dake proposed openstack/kolla: Implements elemental.yml DSL for openstack-base  https://review.openstack.org/32235008:33
openstackgerritSteven Dake proposed openstack/kolla: Implements elemental.yml DSL for base  https://review.openstack.org/32146808:33
openstackgerritSteven Dake proposed openstack/kolla: Implement elemental DSL parser  https://review.openstack.org/32234608:33
openstackgerritSteven Dake proposed openstack/kolla: Implements elemental.yml DSL for keystone  https://review.openstack.org/32253308:33
openstackgerritSteven Dake proposed openstack/kolla: Documentation for elemental DSL  https://review.openstack.org/32234508:33
openstackgerritSteven Dake proposed openstack/kolla: Implements elemental.yml DSL for aodh  https://review.openstack.org/32233608:33
openstackgerritSteven Dake proposed openstack/kolla: Implements elemental.yml DSL for mariadb  https://review.openstack.org/32233708:33
coolsvapsdake, nothing having lunch08:34
*** sdake has quit IRC08:35
pbourke_sdake_: not so sure on this "elemental" name08:36
coolsvapsdake_, why are you working so late?08:36
pbourke_whats the thinking behind that?08:36
sdake_coolsvap because I choose to?08:37
coolsvapsdake_, hmm08:37
sdake_pbourke_ elemental = play on words - elemental things were the foundation of everything08:38
sdake_in greek08:38
sdake_kolla a= greek word for glue08:39
sdake_along with all the other container stuff (some type of greek word)08:39
sdake_we are building hte foundation of the containers in a fail08:39
sdake_ile08:39
sdake_not fail08:39
sdake_file08:39
sdake_and that foundation is elemental ;-)08:39
sdake_pbourke_ anwer yoru question?08:40
sdake_it has to have some type of name08:40
sdake_heat's dsl is called "HOT"08:40
pbourke_sure :)08:40
sdake_pbourke_ besides the name, what are your thoughts about its progress08:40
pbourke_looking good. going through some of the reviews now08:41
sdake_the parser in particular needs alot ore attention08:41
sdake_as well as elemetnal.yml files for every container08:41
sdake_at present it doesn't hose the correct output file to write teh containers to in teh case o faodh (or containers with -base in them)08:43
pbourke_would you say its ready for review though08:43
pbourke_theres stuff that clearly needs cleaned up Im sure you dont need me to tell you08:44
sdake_here is what i'd like08:44
sdake_the documentaiton ,please review08:44
sdake_the yaml files, please review08:44
sdake_the parser, give me some time to make it work properly08:44
sdake_then we can bikeshet on the implementation08:45
pbourke_sure thing08:45
sdake_because the last python code i wrote as over 1 year ago08:45
sdake_little rusty08:45
sdake_the documentation in particular is what needs reviewing08:45
sdake_so make sure the syntax of the elemental.yml file can handle every condition we through at it08:46
sdake_throw08:46
*** papacz has joined #openstack-kolla08:49
openstackgerritMerged openstack/kolla: change keyfile to key  https://review.openstack.org/32058908:52
pbourke_sdake_: its neat to see all the packages neatly enumerated in the yml without all the RUN && \ jinja crap08:56
sdake_i agree08:57
sdake_as well as he commands08:57
sdake_it offloads the coplexity of maintaing the dockerfiles into a parser08:57
sdake_instead of across our development team08:57
sdake_now, one could argue the parser is hard to write08:57
*** efoley has joined #openstack-kolla08:57
sdake_but it can be written in a crappy way that works pretty quickly08:57
sdake_reference my eparse.py review ;)08:57
sdake_pbourke_ if you have suggestions for that python code, feel free to make them08:58
sdake_pbourke_ my thinking was we would merge something that "works" and refactor it into nice tidy pythonic over time08:58
pbourke_that seems to be the way its worked in the past08:58
pbourke_someone comes out of nowhere with a massive refactor08:59
*** efoley_ has joined #openstack-kolla08:59
sdake_i think we are nearing completion of the mssive refactors08:59
sdake_unless at some point we want to refactor the ansible code to use parallel execution08:59
pbourke_I would really like to see it merge with some level of basic unit tests though09:00
sdake_i am not pro at writing unit tests09:00
pbourke_I can try add something if you like09:00
sdake_i really struggle09:00
sdake_yes tha would be great!09:00
sdake_90% o fthe problem is I dont know how the tools work09:01
sdake_so I have to copy and paste from other places09:01
sdake_and try to figure out how to get it all to work09:01
sdake_i had to change about 1500 test cases on introduction of oslo.messaging to heat09:01
sdake_that took about 2 months09:01
sdake_oslo.messaging = 3-4 days09:01
sdake_test cases = 2 months09:01
pbourke_it can be a bit of a black art09:02
sdake_over time I'd like us to consider breaking our services out into pipelineable services that can run in jenkins or the like09:02
*** efoley has quit IRC09:03
sdake_so the ockerfile producer would be a pipeline, the docker compiler wold be a pipeline09:03
sdake_and a third component would glue them together09:03
sdake_i dont like the structure of build.py09:03
sdake_I think it should build the imagess09:03
sdake_do one thing do it well so to speak09:03
pbourke_im just glad we're putting the brakes on build.py09:04
sdake_instead it does customization, image building, tagging, registry support, pushing, etc09:04
sdake_i dont know anone hs put the brakes on build.py09:04
sdake_but clearly it is out of control09:04
*** Mech422 has joined #openstack-kolla09:04
sdake_i dont mind if we ship one tool to do the whole job09:05
sdake_but it should be in separate files09:05
sdake_with good separation o concerns in the code implementation09:05
sdake_all of these basic things programmers should be doing were not done in build.py09:05
sdake_which is ok, that is how software evolves09:05
Mech422Morning ... can anyone tell me what my network config should look like given 2 nics bonded via ovs, with seperate vlans for internal,external,db, etc ?09:05
Mech422I tried creating 'layer 3' ('linux' ) devices with the right settings...09:06
Mech422but kolla wants to do stuff with the ovs setup ?09:06
sdake_separte vlans?09:06
sdake_the way kolla isolates networks now is through separate interfaces09:06
Mech422sdake_: yes, I tried creating seperate 'linux' interfaces for each vlan via ovs and feeding that to kolla...but its wasn't happy09:07
sdake_i honestly don't see how that would work in a kolla universe without seprate interfaces per network type09:08
*** Serlex has joined #openstack-kolla09:08
sdake_maybe kolla should offer complete network isolatuion using vlans rather then physical nics09:08
sdake_but it does not at this time09:08
sdake_pbourke_ is that acurate?09:08
Mech422sdake_: ahh - I set the interfaces up at 'ovsIntPorts' in the bare metal09:08
Mech422s/at/as/09:09
*** SiRiuS has joined #openstack-kolla09:09
sdake_Mech422 i dont know details of ovs09:09
sdake_I can barely get neutron to work ;)09:09
sdake_we recommend separate networks09:09
pbourke_im not familiar enough with vlans to advise how they could be used with kolla09:09
sdake_let me show you a diagram09:09
Mech422sdake_: LOL - me too... the 'IntPort' ones look like 'real' interface (eg eth0, em1, etc)09:09
pbourke_im similarly struggling with neutron :/09:10
Mech422sdake_: so what would be your advise if you only have a single bonded pair of nics to work with ?09:10
pbourke_you need a minimum of two interfaces to deploy kolla09:10
Mech422pbourke_: heh - my next step after getting Kolla working is to try and get midonet working with it...09:10
sdake_Mech422 http://www.gliffy.com/go/publish/image/10486755/L.png09:11
pbourke_one for the management network and one for the external network09:11
Mech422sdake_: thank you09:11
*** tfukushima has quit IRC09:12
sdake_pbourke_ there is the diagram of our system09:12
pbourke_sdake_: have you given much thought to how the "interit" functionality of the dsl will work09:13
Mech422Hmm...so I could use my nics, without bonding  -but lose HA...09:13
*** pbourke_ has quit IRC09:13
Mech422what if I manually create br-ex ? is kolla smart enough not to mess with it ?09:13
*** pbourke_ has joined #openstack-kolla09:13
sdake_Mech422 ou need more then 1 bonded interface :)09:13
sdake_for example the controller node09:14
sdake_needs 3 nics09:14
sdake_one for he management network (unisolated, compeltely insecure)09:14
sdake_the api network (locked down, only specific ports open, totally and completely firewalled)09:14
Mech422sdake_: yeah - I don't have more... I have 2 10GigE, and a GigE for mgmt09:14
sdake_and the storage network (not isolated, but shouldn't be on an externally routed network)09:14
sdake_Mech422 thatis the same exact setup I use09:15
Mech422sdake_: ahh - cool - so you just don't bond the 10GigE's then ?09:15
sdake_pbourke_ I think inherit will take from one object and copy the contents to a different object09:15
sdake_pbourke_ so fedora:09:16
sdake_  inherit: centos09:16
sdake_would just pull in centos into fedora09:16
pbourke_im just thinking we may not want to pull everything in09:16
sdake_that way we dont hae to type the same thing a million times for distros which don't have much variance09:16
sdake_what wouldn't you pull in?09:16
pbourke_wondering would yaml's anchor feature be a more natural solution09:16
sdake_i dont knwo yamls anchro feature09:17
Mech422sdake_: heh - I do that with machine configs - I have a 'hardware' dict in ansible with a 'default' key09:17
pbourke_you basically tag a block and can then reuse that tag elsewhere in the yaml09:17
pbourke_so its explicit to the reader which parts are being reused09:17
sdake_pbourke_ that sounds pretty good09:17
sdake_can you make a proof of concept from the aodh or openstack-base or base containers09:17
pbourke_https://gist.github.com/bowsersenior/979804#file-stooges-yml09:17
sdake_openstack-base would probablybe best09:18
pbourke_yeah ill hack on these a bit today09:18
Mech422assuming I was dumb enough to want to play with the Kolla networking stuff - any idea which ansible roles are setting it up ?09:18
pbourke_id like the derivative distro support to be solid before merging as that has proved a core issue to be solved in previous solutions09:18
*** daneyon_ has joined #openstack-kolla09:20
sdake_pbourke_ if you modify any of my patches let me knwo so I can reintegrate the changes into my patch stream09:20
sdake_pbourke_ agree that is why there a bi fat -2 on the first review in the queue09:20
pbourke_Mech422: most of it is just in the config templates, where we bind the services to "api_interface"09:20
sdake_that was the core issue we solved09:21
sdake_but we have identified a whole slew of othe problems we want to solve09:21
Mech422pbourke_: thanks09:21
sdake_other then multidistro, jinja2 didn't solve much else09:21
coolsvapsdake_, i updated the parser patch yesterday seems like it is overwritten in patch 5, will update it again09:21
patchbotcoolsvap: https://review.openstack.org/#/c/5/ - openstack-infra/system-config - Fix problem with jenkins known_hosts url. (MERGED)09:21
sdake_coolsvap if you do that pull down he whole patch stream09:21
*** matrohon has joined #openstack-kolla09:22
sdake_so when I pull down the whoel patch stream I have your changes in it09:22
pbourke_Mech422: there's also stuff then in the neutron tasks to configure the neutron_external_interface for the external network. those are the two main variables to grep for09:22
coolsvapsdake_, ya09:22
coolsvapwill do09:22
*** berendt has quit IRC09:22
Mech422pbourke_: I think thats whats biting me atm - I try that first - thanks again!09:22
sdake_Mech422 what you want is to use vlan's with 1 network interface to isolate traffic09:22
sdake_what kolla offers is multiple network interfaces without vlan to isolate traffic09:22
coolsvapthis is something new of patchbot,  we don't need to provide complete url, didn't knew that09:22
sdake_exception being in the neutron external network which uses vlanv/vxlan to isolate traffic iiuc09:23
Mech422sdake_: yeah - I realize I'm going out in the weeds...09:23
Mech422sdake_: and I want to try and get midonet into the mix as well09:23
pbourke_sdake_: only if you use ovs or another driver that supports overlay networks09:23
sdake_kolla implements ovs and linuxbridge09:23
Mech422sdake_: I'm hoping if i manually configure br-ex, etc - that kolla won't touch it09:24
pbourke_Mech422: it will09:24
*** daneyon_ has quit IRC09:24
pbourke_:p09:24
sdake_gah why would you want to manually configure your bridges?09:24
Mech422pbourke_: well, crud puppies09:24
Mech422sdake_: so I can go out in the weeds ?? :-)09:24
sdake_Mech422 try hitting up vhosakot or dave_mccowan tomorrow09:24
sdake_they are both networking nerds09:25
sdake_sbezverk is a CCIE09:25
Mech422sdake_: oh - thank you!09:25
sdake_and even thugh I am not big on certifications, CCIE is a super hard certification09:25
sdake_sbezverk can likely get you pointed in the right direction or translate to me so we can get work scheduled09:25
sdake_or both :)09:25
Mech422sdake_: thanks - I didn't really think anyone else would be interested...09:26
Mech422sdake_: though the neutron midonet plugin looks interesting09:26
sdake_if it means we need to implement some magic to add vlan tagging to specific networks, I thnk that may make sense09:26
sdake_but i am not a networking genius09:26
pbourke_Mech422: it would be pretty easy to disable it though. kolla is simple enough to hack on once you're familiar with the layout09:26
Mech422cool :-)09:27
Mech422rather then worrying about a bunch of wierd network configs - it might just be enough to have kolla not touch br-ex, etc. if they already exist09:28
sdake_that is easy enough09:28
Mech422then people can manually setup whatever they want/need without pestering you guys09:28
sdake_just take out the task09:28
sdake_we like being pestered - it lets us know we are loved :)09:29
Mech422cool - I'll look at that once my coffee is ready :-)09:29
sdake_but seriously, if kolla doesnt work correctly we want to make it work correctly09:29
Mech422LOL - you're very loved - kolla is awesome :-)09:29
sdake_well thanks for that - i'm sure the community appreciates the positive feedback09:29
Mech422sdake_: I think networking will be one area where 'providers' will have all sorts of weird setups09:29
sdake_it was a long painful road to get there09:29
Mech422sdake_: storage too - sans, ceph, s3 buckets, etc09:30
Mech422sdake_: I can imagine - it took me a month just to write the ansible stuff to configure kolla :-P09:30
sdake_kolla iplements ceph09:30
sdake_and we expect people to deploy with it too09:30
Mech422sdake_: I saw that :-)  ceph rocks!09:30
sdake_what stuf did you write to confgiure kolla09:31
sdake_that is probably stuff that needs to go upstream at some point :)09:31
Mech422sdake_: the kolla side was just some simple stuff to pre-configure the config files...09:31
sdake_you mean /etc/kolla/config?09:31
Mech422sdake_: I also built users for runnign stuff and all that jazz09:31
sdake_or /etc/kolla/globals.yml?09:31
Mech422mostly globals.yml at this point -  I _just_ got deploy working tonight09:32
Mech422so I still have to configure a lot of stuff09:32
sdake_nice- an AIO deploy?09:32
Mech422nah - umm... 6 nodes ?  my ansible stuff build multinode.yml dynamically09:32
Mech4227 nodes if you count the deployment host09:33
sdake_ok past my bedtime09:33
sdake_its 2:3009:33
sdake_night all09:34
sdake_Mech422 sbezverk is on the esat coast in candara iirc09:34
sdake_so he should be around in 4-5 hours09:34
Mech422sdake_: thanks! Gnite!09:34
Mech422its 2:30 AM here...so I'll prolly be heading to bed myself09:34
sdake_pbourke_ ancor thing looks ok - kind of hard to read09:34
sdake_pbourke_ but if there is already a cut and repace feature of yml we should probably use it09:35
pbourke_sure09:35
sdake_pbourke_ re eparse, at present its broken on the adoh image09:35
sdake_pbourke_ if you get into it and decide it needs major rewriting, knock yurself out09:36
Mech422oh btw - I had to manually upgrade the pip and virtualenv/tox on ubuntu 14.04...I finally found your messages about them in the irc logs sdake_ :-)09:36
sdake_i knwo you youngins have your opinions about python09:36
*** SiRiuS has quit IRC09:36
sdake_just like i do with my old daddy school lanuage C:)09:36
pbourke_:)09:37
pbourke_sdake_: by the way, any idea how we can get your infra patch merged to add the oraclelinux gates09:38
pbourke_poked a few times on #openstack-infra, no luck09:38
sdake_pbourke_ they are all asleep atm09:39
pbourke_ah, maybe wrong timezone for me09:39
sdake_or alternatively in some foreign country doing something related to openstack09:39
sdake_I have pinged them a few times over the last week09:39
sdake_and that got 1 +2 :)09:39
sdake_so I'll hunt down a second one, if you remind me hte morning it might work best09:39
sdake_patch sitting around with 1 +2 for 2 weeks, logn lag time09:40
sdake_after summit, openstack lags or about 2-4 weeks09:40
sdake_or/for09:40
*** SiRiuS has joined #openstack-kolla09:40
sdake_pbourke_ probably the best one to go with is bse, then that is the most complexx09:40
sdake_also I didn't iplement any ubuntu rendering of the images09:40
sdake_only centos09:40
pbourke_right09:41
sdake_and there is that major glaring bug that images don't gte created if they have a -base in their catalog09:41
sdake_but i am not superman and need to hit the rack :)09:41
sdake_pbourke_ what does this do https://gist.github.com/bowsersenior/979804#file-stooges-yml-L1009:43
*** weiyu_ has quit IRC09:45
*** weiyu_ has joined #openstack-kolla09:46
openstackgerritMerged openstack/kolla: Fix the incompatibility for ansible 2.1.0  https://review.openstack.org/32175409:47
*** phuongnh has quit IRC09:47
openstackgerritMerged openstack/kolla: Fix the cinder backup permission issue when enable ceph  https://review.openstack.org/32312109:48
*** phuongnh has joined #openstack-kolla09:49
pbourke_sdake_: actually not familiar with that line. I think it will take the content of default and override the URL and stooges keys09:50
pbourke_the merging stuff is a little funky Im not sure we'll need it09:50
sdake_i have a use case for merging i need now09:50
sdake_are yo utalkingabout the elemental-merge.yml file i talked about in the docs?09:51
pbourke_no i like that09:51
pbourke_I mean the yaml anchor merging09:51
sdake_the reaon I added that inherit thing is i didn't wnt to repeat oraclelinux almost word for word from the entos section09:52
sdake_for like 50 docker file groupings09:56
*** sdake_ is now known as sdake09:57
pbourke_so how do we handle for example something like the part where ol requires rpm --nodeps for the packages section09:59
*** rhallisey has joined #openstack-kolla10:01
pbourke_i guess we could specify that section in the yml and the parser will do the right thing10:01
pbourke_its the same as what Im proposing with anchors really10:01
*** mgoddard has joined #openstack-kolla10:04
*** pbourke_ has quit IRC10:09
*** pbourke_ has joined #openstack-kolla10:10
*** sacharya has joined #openstack-kolla10:12
Mech422I'm an idgit...10:12
Mech422looks like I can use the bonded interfaces just by creating a couple of pairs of veth interfaces, tagged with the right vlans and pass those to kolla10:13
*** sacharya has quit IRC10:16
*** mdnadeem has quit IRC10:16
*** mdnadeem has joined #openstack-kolla10:17
*** weiyu_ has quit IRC10:17
*** mdnadeem has quit IRC10:17
*** mdnadeem has joined #openstack-kolla10:17
*** zhiwei has quit IRC10:18
*** mdnadeem has quit IRC10:19
*** mdnadeem has joined #openstack-kolla10:19
openstackgerritMerged openstack/kolla: Compile the messages in the horizon  https://review.openstack.org/32202010:22
sdakepbourke_ for that case (nodeps) nodeps will always be the cae10:25
sdakeI was thinking we would just have a oraclelinux parser for that part of the yaml markup10:25
sdakepbourke_ with the nodeps stuff10:25
sdakealternativelly, the parser knows which section its parsing10:26
sdakeif its parsing anything oraclelinux and there is a repo section, it could use the special parser for le that prints out --nodeps10:26
*** rhallisey has quit IRC10:27
*** weiyu_ has joined #openstack-kolla10:28
*** berendt has joined #openstack-kolla10:28
*** weiyu_ has quit IRC10:30
*** weiyu_ has joined #openstack-kolla10:31
*** weiyu_ has quit IRC10:33
*** SiRiuS has quit IRC10:42
*** SiRiuS has joined #openstack-kolla10:42
pbourke_sdake: still around?10:49
sdakeshoot10:50
pbourke_do we support per node augment files?10:50
pbourke_see line 183 here https://review.openstack.org/#/c/322334/1/doc/pci-passthrough.rst10:50
patchbotpbourke_: patch 322334 - kolla (stable/mitaka) - Adds documentation of how to perform SR-IOV10:50
pbourke_actually its in the docs so I guess we do :)10:53
pbourke_didnt know that though10:53
*** tfukushima has joined #openstack-kolla10:53
coolsvapbut we dont have docs backported to stable branche10:54
coolsvapi saw this patchset today10:54
openstackgerritMerged openstack/kolla: Adding Upgrade to iscsid/tgtd container  https://review.openstack.org/31409610:56
pbourke_coolsvap: ah just noticed its targeted for mitaka10:58
coolsvapi think both doc and associated change should go through master to stable branches10:59
*** tfukushima has quit IRC10:59
pbourke_+111:01
*** rhallisey has joined #openstack-kolla11:06
*** phuongnh has quit IRC11:07
*** dmk0202 has quit IRC11:07
openstackgerritMerged openstack/kolla: Fix kolla-build return codes  https://review.openstack.org/32211511:08
openstackgerritMerged openstack/kolla: Update Documentation  https://review.openstack.org/31989911:08
openstackgerritMerged openstack/kolla: Compile the messages in the horizon  https://review.openstack.org/32202111:08
*** godleon has quit IRC11:09
openstackgerritMerged openstack/kolla-kubernetes: Add more details to the quickstart and usage guide.  https://review.openstack.org/32190511:12
openstackgerritMerged openstack/kolla-kubernetes: Adding kuebctl setup task to point to local hyperkube  https://review.openstack.org/32188611:20
openstackgerritMerged openstack/kolla-kubernetes: Add bootstrap directory to usr/local/share/kolla-kubernetes  https://review.openstack.org/32189711:22
openstackgerritPaul Bourke proposed openstack/kolla: Move developer related docs into their own section  https://review.openstack.org/32329811:31
openstackgerritPaul Bourke proposed openstack/kolla: Retitle quick start to make it more obvious in index  https://review.openstack.org/32330411:35
*** dmk0202 has joined #openstack-kolla11:42
*** weiyu has joined #openstack-kolla11:42
sdakecoolsvap we don't backport documentation becausae our docs are published on the internets11:46
sdakeand for some godawful reason people want to write the docs separately from the patch11:46
sdakewhich means, they dont get rwritten11:46
*** mdnadeem has quit IRC11:46
sdakebut its to late now, we dont knwo what doc patches were made to cherrypick11:46
sdakebecause theywere nt tracked with bug ids11:47
*** mdnadeem has joined #openstack-kolla11:47
sdakeif you want to make the docs sync, sort out how to do the backporting11:47
sdakeand we can do that11:47
sdakeotherwise, I think we have more important things to concern ourselves with11:47
*** mdnadeem has quit IRC11:47
sdakenobody will actually read the documenation shipped witht eh software11:47
sdakethey will go to the rendered documentation11:48
coolsvapsdake, yes11:48
*** mdnadeem has joined #openstack-kolla11:48
*** mdnadeem has quit IRC11:48
sdakecoolsvap yes to what, I said 10 different things there11:48
*** mdnadeem has joined #openstack-kolla11:48
*** mdnadeem has quit IRC11:48
coolsvapi just wanted to make pbourke_ aware that the docs and related fix is targeted to mitaka not master11:49
*** mdnadeem has joined #openstack-kolla11:49
*** mdnadeem has quit IRC11:49
sdakepatches should go in master first obviously11:49
*** mdnadeem has joined #openstack-kolla11:49
coolsvapi know the reasoning behind the doc thing11:49
*** mdnadeem has quit IRC11:49
coolsvapjust wanted to make sure he's also aware that we need to ask it to submit to master not to mitaka directly11:50
*** mdnadeem has joined #openstack-kolla11:50
*** Mr_Broke_ has quit IRC11:50
*** mdnadeem has quit IRC11:50
*** mdnadeem has joined #openstack-kolla11:50
*** Mr_Broken has joined #openstack-kolla11:50
*** mdnadeem has quit IRC11:51
coolsvapnothing else11:51
sdakecool11:51
coolsvap:)11:51
*** mliima has joined #openstack-kolla11:51
*** mdnadeem has joined #openstack-kolla11:52
*** Mr_Broken has quit IRC11:55
*** weiyu has quit IRC12:01
*** mdnadeem has quit IRC12:01
openstackgerritPaul Bourke proposed openstack/kolla: Implement elemental DSL parser  https://review.openstack.org/32234612:04
*** Mr_Broken has joined #openstack-kolla12:05
*** mgoddard has quit IRC12:08
*** mgoddard has joined #openstack-kolla12:08
*** JoseMello has joined #openstack-kolla12:12
*** sacharya has joined #openstack-kolla12:13
openstackgerritMerged openstack/kolla: Move developer related docs into their own section  https://review.openstack.org/32329812:13
openstackgerritMerged openstack/kolla: Retitle quick start to make it more obvious in index  https://review.openstack.org/32330412:13
openstackgerritMerged openstack/kolla: Use file module instead of running rm to remove a directory  https://review.openstack.org/32183212:15
*** d_code has quit IRC12:16
*** sacharya has quit IRC12:17
*** dwalsh has joined #openstack-kolla12:17
*** Jeffrey4l has joined #openstack-kolla12:20
*** d_code has joined #openstack-kolla12:23
openstackgerritJeffrey Zhang proposed openstack/kolla: Fix the cinder backup permission issue when enable ceph  https://review.openstack.org/32333012:23
sbezverkrhallisey ping12:24
rhalliseysbezverk, hey12:24
*** dave-mccowan has joined #openstack-kolla12:25
*** cu5 has joined #openstack-kolla12:26
sbezverkrhallisey I figured out the issue with dns.. it is HostNetwork: True, when I start busybox with this setting, it mounts host's resolv.conf, without HostNetwork true, it uses kubelet's provided resolv.conf12:26
sbezverkrhallisey it looks like this issue will be fixed in 1.12 docker.. currently specifying dns and using host net are mutually exclusive..12:27
*** sdake has quit IRC12:27
rhalliseyog12:28
rhalliseyoh12:28
rhalliseysbezverk, interesting12:28
sbezverkrhallisey yeah, unfortunately it is interesting with -1 ;-)12:29
rhalliseysbezverk, :) no worries. I'm glad you tracked this down12:31
rhalliseycan you comment on this in your spec12:31
rhalliseyjust so we track the issue12:31
openstackgerritJeffrey Zhang proposed openstack/kolla: Fix the cinder backup permission issue when enable ceph  https://review.openstack.org/32333812:33
*** ppowell has joined #openstack-kolla12:37
sbezverkrhallisey will do12:40
*** zhiwei has joined #openstack-kolla12:47
openstackgerritJeffrey Zhang proposed openstack/kolla: Bump the ansible version to 2.0.2.0-1 in the kolla-toolbox  https://review.openstack.org/31162512:47
*** zhiwei has quit IRC12:51
*** SiRiuS has quit IRC12:54
*** absubram has joined #openstack-kolla12:54
*** absubram_ has joined #openstack-kolla12:55
*** daneyon_ has joined #openstack-kolla12:56
*** diogogmt has quit IRC12:56
*** efoley_ is now known as efoley12:57
*** diogogmt has joined #openstack-kolla12:57
*** jtriley has joined #openstack-kolla12:58
*** absubram has quit IRC12:59
*** absubram_ is now known as absubram12:59
*** dwalsh has quit IRC13:00
*** daneyon_ has quit IRC13:01
*** SiRiuS has joined #openstack-kolla13:03
*** stvnoyes has joined #openstack-kolla13:03
*** dwalsh has joined #openstack-kolla13:03
*** dwalsh has quit IRC13:08
*** fragatina has quit IRC13:09
*** fragatina has joined #openstack-kolla13:10
*** fragatina has quit IRC13:11
*** dwalsh has joined #openstack-kolla13:12
*** dwalsh has quit IRC13:13
*** dwalsh has joined #openstack-kolla13:14
*** fragatina has joined #openstack-kolla13:15
*** ayoung has joined #openstack-kolla13:22
*** diogogmt has quit IRC13:25
*** absubram has quit IRC13:33
*** diogogmt has joined #openstack-kolla13:36
*** mgoddard_ has joined #openstack-kolla13:45
*** mgoddard has quit IRC13:45
*** d_code has quit IRC13:47
*** mgoddard__ has joined #openstack-kolla13:55
*** mgoddard_ has quit IRC13:58
openstackgerritMerged openstack/kolla: Log the traceback in the kolla libraries  https://review.openstack.org/28966713:59
*** diogogmt has quit IRC14:01
*** mdnadeem has joined #openstack-kolla14:02
*** d_code has joined #openstack-kolla14:03
openstackgerritSerguei Bezverkhi proposed openstack/kolla-kubernetes: Kolla Kubernetes Service Discovery BP  https://review.openstack.org/31753714:03
Mr_BrokenHey guys14:04
Mr_Brokenusing kolla-ansible reconfigure in stable/mitaka14:04
Mr_Brokenworks great, but how do i remove the line from existing config ?14:04
Mr_Brokenor at least comment it ?14:04
Mr_Brokentrying to change glance-api.conf, and remove ( or comment ) #filesystem_store_datadir = /var/lib/glance/images/14:05
Mr_Brokenbecause i want only swift to handle glance backend14:05
rhalliseyMr_Broken, when you comment it out what happens?  Does it get added back in?14:05
Mr_Brokennothing happens when i comment it14:06
Mr_Brokenlike it getting ignored14:06
rhalliseyso reconfigure never picks it up?14:06
berendtin this case it should be sufficient to overwrite the value of default_store in [glance_storage]14:06
openstackgerritMauricio Lima proposed openstack/kolla: Manila driver session is needed only in manila-share  https://review.openstack.org/31123214:06
sbezverkMr_Broken when you change default store type to swift, all file related config becomes irrelevant.14:06
sbezverkMr_Broken I do not think you need to worry about it14:07
Mr_Brokeni did change it14:07
Mr_Brokenbut now i am having a problem when trying to create image :14:07
Mr_Brokenlet ma paste sec14:07
sbezverkMr_Broken have you tested your swift to make sure that it is working?14:08
Mr_Brokenyes14:08
Mr_Brokenits working14:08
Mr_Brokencan access it with swift client itself14:08
Mr_Brokenplease have a look :14:10
Mr_Brokenhttp://paste.openstack.org/show/506590/14:10
berendthave you configure swift inside glance?14:10
Mr_Brokenwant me to paste glance-api.conf ? and glance-swift.conf ?14:10
Mr_Brokeni tried configuring it for like 6 hours now ;]14:10
berendtI think it makes sense to paste the generated glance-api.conf file of the controller node14:11
*** ravig has joined #openstack-kolla14:12
sbezverkMr_Broken please paste those config files.. Cannot say I saw this error before..14:13
Mr_Brokenhttp://paste.openstack.org/show/506591/14:13
Mr_Brokensbezverk: same here - didnt have those issues in Liberty #JSYK ;]14:13
sbezverkMr_Broken man, I think you are missing bunch of config for swift14:17
sbezverkin glance-api.conf14:17
sbezverkunless you did not paste all info14:17
Mr_Brokeni didnt config all14:18
Mr_Brokeni didnt paste all sorry14:18
Mr_Brokenthere were some passwords and logins :>14:18
Mr_Brokendidnt bother to edit :]14:18
Mr_Brokeni pasted only sections that are responsible for glance14:18
Mr_Brokenyou want it all ?14:18
sbezverkMr_Broken, just remove passwords14:19
Mr_Brokenkk14:19
Mr_Brokensec14:19
Mr_Brokenhere You go:14:20
Mr_Brokenhttp://paste.openstack.org/show/506592/14:20
Mr_Brokenany ideas ?14:25
Mr_Brokenneed to switch locations will be offline for like 45mins.14:26
*** Mr_Broken has quit IRC14:27
*** b_bezak has joined #openstack-kolla14:27
openstackgerritPaul Bourke proposed openstack/kolla: Implement elemental DSL parser  https://review.openstack.org/32234614:27
*** Mr_Broken has joined #openstack-kolla14:28
berendtdoes it makes sense to interpret the include_footer/include_header files as jinja templates? at least for me this would be useful.14:29
*** Mr_Broken has quit IRC14:32
openstackgerritPaul Bourke proposed openstack/kolla: Implements elemental.yml DSL for base  https://review.openstack.org/32146814:32
*** cu5 has quit IRC14:33
berendtIt looks like the merge of https://review.openstack.org/#/c/322115/ introduced a new bug, I mentioned this in the already closes bug report. Should the bug report be re-opened?14:34
patchbotberendt: patch 322115 - kolla - Fix kolla-build return codes (MERGED)14:34
coolsvapberendt, no open a new bug report14:35
*** inc0 has joined #openstack-kolla14:35
berendtcoolsvap ok14:35
berendtcoolsvap reported as https://bugs.launchpad.net/kolla/+bug/158750114:37
openstackLaunchpad bug 1587501 in kolla "TypeError exception when running kolla-build with --template-only" [Undecided,New]14:37
Lyncosinc1  ping14:37
coolsvapberendt, will you be working on this?14:38
inc0good morning14:39
inc0I'm back to the land of the living14:39
*** mgoddard__ has quit IRC14:39
*** mgoddard has joined #openstack-kolla14:39
inc0Lyncos, wassup? I'm still 0 :(14:39
berendtcoolsvap no I think it the author of the merged patch should have a look on it14:39
Lyncosinc0 lol sorry14:39
Lyncosinc0 we figured out our millions mount points problem14:39
coolsvapmaybe we can revert it for time being then14:39
coolsvapdoes not look like a big fix14:40
berendtI think a revert is not necessary, normal builds are working14:40
inc0Lyncos, do tell please14:40
Lyncosinc0 it was because in ubuntu by default LXC is installed .. we removed it and now the when we restart our DHCP container it's stable14:41
inc0oh? interesting14:41
Lyncosit is some sort of incompatibility with LXC / Docker in ubuntu14:41
inc0maybe something we should do in our base image14:41
Lyncosit's on the host system14:41
inc0ahh14:41
berendtLyncos a note in the getting started documentation would be nice14:41
inc0well, truth be told, docker did state it in documentation14:41
coolsvaplets see, I dont know will miller lets see will wait for some time14:41
Lyncosinc0 yes14:42
inc0but sure, pop a patch to make node in our quickstart14:42
inc0I'm glad that you got this figured out14:42
coolsvapmgoddard, wmiller  ping can you guys have a look at https://bugs.launchpad.net/kolla/+bug/158750114:42
openstackLaunchpad bug 1587501 in kolla "TypeError exception when running kolla-build with --template-only" [High,New]14:42
*** diogogmt has joined #openstack-kolla14:43
mgoddardcoolsvap, sure14:43
coolsvapseems like aftereffect of patch 32211514:43
patchbotcoolsvap: https://review.openstack.org/#/c/322115/ - kolla - Fix kolla-build return codes (MERGED)14:43
openstackgerritMerged openstack/kolla: Fix the cinder backup permission issue when enable ceph  https://review.openstack.org/32333814:49
*** Lyncos has quit IRC14:50
*** ayoung has quit IRC14:51
mgoddardcoolsvap: I think you're right. wmiller is on it14:52
openstackgerritMerged openstack/kolla: Set ServerTokens parameter to 'Prod' for Ubuntu Apache config  https://review.openstack.org/32179814:54
openstackgerritMerged openstack/kolla: Manila driver session is needed only in manila-share  https://review.openstack.org/31123214:55
*** mliima has quit IRC15:06
*** d_code has quit IRC15:11
Mech422anyone happen to know a trick for dynamically querying ansible vars?  I'm trying to get say ansible_eth0 when 'eth0' varies at runtime15:11
pbourke_hostvars15:12
Mech422pbourke_: problem is ansible_eth0 isn't a dict? so I can't do ansible[ interface] to get it...15:13
Mech422pbourke_: ahh...I see...ansible_eth0 is a key in hostvars....15:14
Mech422never thought of it that way - thanks!15:14
*** d_code has joined #openstack-kolla15:14
openstackgerritPaul Bourke proposed openstack/kolla: Implements elemental.yml DSL for base  https://review.openstack.org/32146815:14
openstackgerritPaul Bourke proposed openstack/kolla: Implement elemental DSL parser  https://review.openstack.org/32234615:14
*** zhiwei has joined #openstack-kolla15:15
*** ravig has quit IRC15:18
*** zhiwei has quit IRC15:19
*** vhosakot has joined #openstack-kolla15:21
Mech422huh - ansible doesn't notice veth interfaces... no ansible_foo.ipv4.address for me :-P15:22
*** mliima has joined #openstack-kolla15:23
*** berendt has quit IRC15:31
*** openstackgerrit has quit IRC15:33
*** openstackgerrit has joined #openstack-kolla15:33
*** b_bezak has quit IRC15:36
*** b_bezak has joined #openstack-kolla15:36
*** sacharya has joined #openstack-kolla15:38
*** matrohon_ has joined #openstack-kolla15:38
*** matrohon_ has quit IRC15:38
*** b_bezak has quit IRC15:41
*** dmk0202 has quit IRC15:42
*** ayoung has joined #openstack-kolla15:45
*** dwalsh has quit IRC15:48
inc0Mech422, hmm, that's strange15:48
Mech422inc0: actually - it looks like thats an ordering problem on my side15:48
Mech422inc0: I referenced it before the playbook runs that creates it :-P15:49
inc0yeah, having veth created helps with using it15:49
inc0;)15:49
Mech422inc0: nah...after my perpetual motion machines, use before definition should be cake!! :-)15:50
inc0are you running cloud on your perpetum mobile? And it doesn't break?15:51
*** ravig has joined #openstack-kolla15:52
pbourke_inc0: I think the main value in the DSL is it's easier to override/extend than using includes15:55
pbourke_it gives us more control over the API than currently15:55
inc0pbourke_, well, I disagree. We will be limited to options we thought of15:56
inc0it won't give us more control than we have15:56
pbourke_its not so much a true DSL as it is a parser15:56
inc0it will generate dockerfile at the end, so it won't be more than Dockerfile API offers15:56
pbourke_or a more structured way of representing what we already have15:56
inc0yeah, but that should be done by refactoring of what we have15:57
inc0and I think we have all the toolset we need15:57
inc0we can do macro in jinja2 and such15:57
openstackgerritMerged openstack/kolla: Do not use bare variables in the ceph role  https://review.openstack.org/32183415:57
inc0I just don't want to lose opportunity to easily edit dockerfile itself15:57
pbourke_I can see the worry of that being restictive15:58
inc0most of abstraction layers are at some point15:58
inc0and adding yet another one isn't good patter imho15:59
pbourke_we need to enumerate the issues with the current approach and see if they can be resolved in jinja15:59
inc0let's first rule out refactoring stuff without adding new layers of complexity to it15:59
inc0yeah, if it can't be solved, then we should think of solutions16:00
inc0not before16:00
pbourke_the big one is customisations16:00
pbourke_say we you want to install one more package in base, how do you do that16:00
pbourke_(specific to your environment)16:01
pbourke_i.e. wont be going upstream16:01
*** mdnadeem_home has joined #openstack-kolla16:01
inc0well, you'd need to fork stuff now16:02
inc0and that's good imho16:02
inc0forking dockerfiles isn't bad, it's not logic per se16:02
inc0which also adds to my argument, if you want to fork Dockerfile, its less likely to bite you later16:03
inc0as Dockerfile API will be more stable than DSL one16:03
inc0jinja2 was created to build super-complicated html pages and it does it well16:05
inc0it's a tool to simplify building large documents, we don't need to reinvent it16:05
pbourke_hmm maybe16:06
inc0so, how about that, I'll write demo of what I'd have in mind16:06
inc0and we'll confront both ideas16:06
pbourke_I agree we need to be sure this can't be solved/improved with the current methods16:06
inc0my point exactly16:07
Mech422inc0: heh - I like that 'perpetum mobile' :-)16:07
inc0well it's latin for perpetual motion machine16:07
pbourke_what i had in mind originally was something like the yaml but using jinja include blocks16:08
inc0yeah that's how I'd do it too16:08
inc0like {% include base_packages_install_{{ install_base }}_{{ install_type }} %}16:09
pbourke_yeah16:09
inc0this won't work, but I'll figure out how to make it works16:09
inc0and we'll have base_packages_install_centos_binary16:09
inc0a file16:09
*** ravig has quit IRC16:09
pbourke_i think one thing sdake has an issue with also, which I agree with is the proliferation of options going into build.py16:10
inc0with RUN yum -i install ...16:10
inc0what do you mean?16:10
*** fragatina has quit IRC16:10
pbourke_so any time people want to customise something it ends up becoming a jinja2 variable and another arg gets added build.py16:11
pbourke_not saying those couldn't be moved elsewhere though16:12
inc0well, that won't be solved in DSL16:12
inc0if we need additional input, then we need it16:12
inc0however we'll turn it into Dockerfile at the end16:12
*** d_code has quit IRC16:12
pbourke_well with the DSL people would supply chunks of yaml that would be easily mergable16:12
pbourke_but I agree it's essentially the same as jinja includes just solved with yaml16:13
inc0and now they'll supply chunks of dockerfile16:13
inc0you'll have 2 languages to learn instead of 3 (jinja, dockerfile, DSL)16:13
inc0and 0 parsers to support instead of 1;)16:13
pbourke_the jinja would go away16:13
inc0then I'm total -2 to it16:14
pbourke_lol16:14
inc0I don't want reimplementing jinja16:14
inc01 backwards compatibility16:14
inc02 we'll reimplement jinja...16:14
inc0only in yamls16:14
inc0I agree yamls are cute, but really?16:14
pbourke_ha16:14
pbourke_i dunno16:14
inc0also I don't really see problem it solves16:15
inc0I agree, Dockerfiles we have are ugly16:15
*** vhosakot has quit IRC16:15
inc0but that's because we made a call of only using "if" statement from jinja16:15
inc0I was opposed to this limitation, but that what we agreed in Santa Clara16:15
inc0now we can move beyond that and refactor our dockerfiles using full power jinja2 offers16:16
pbourke_i like the abstraction of a list of data without all the RUN && \ && curl blah blah16:16
inc0but what if you have to make a RUN that wasn't considered in DSL?16:16
inc0like add some option to RUN or whatever?16:16
inc0pip install with proxy settings16:16
*** vhosakot has joined #openstack-kolla16:17
inc0or private mirror of repo16:17
inc0you know...all the things we didn't think of16:17
*** matrohon has quit IRC16:17
inc0with jinja it's just adding few things to RUN in one of files16:17
inc0with DLS is to reverse engineer whole thing and hope it will never change16:17
*** thumpba has joined #openstack-kolla16:18
pbourke_one will probably tell you we've arrived on a stable API that shouldn't change for the forseeable future16:18
*** mikelk has quit IRC16:18
inc0until it does...16:18
inc0also how long it would take to get this "stable API"?16:18
inc0and people like Lyncos, they already fork our dockerfiles16:19
inc0to enable their own stuff in it16:19
inc0and thats cool!16:19
inc0we should make it easier, not harder16:19
pbourke_so do oracle16:19
inc0I expect many people to do it16:19
inc0snowflakes are there in a plenty16:19
pbourke_if forking is so great why do we support config merging?16:22
inc0well there are things you can only do with merging16:23
inc0like chaniging config per node16:23
*** thumpba has quit IRC16:23
*** thumpba has joined #openstack-kolla16:24
inc0and I'm not saying it's great, I'm saying sometimes it's required16:24
inc0for us more than for usual projects16:24
pbourke_ah good point16:25
inc0and adding layer of complexity will make it harder16:25
*** ayoung has quit IRC16:25
*** tyrola has joined #openstack-kolla16:27
pbourke_oh well, heading home. see what sdake thinks :)16:29
inc0sure, have a good one16:29
*** Mr_Broken has joined #openstack-kolla16:29
inc0I'll tinker up some demo of what I have in mind16:29
pbourke_cool16:29
*** unicell1 has quit IRC16:30
*** dwalsh has joined #openstack-kolla16:32
*** daneyon_ has joined #openstack-kolla16:33
*** dwalsh has quit IRC16:36
*** dwalsh has joined #openstack-kolla16:37
*** daneyon_ has quit IRC16:37
*** d_code has joined #openstack-kolla16:41
*** ayoung has joined #openstack-kolla16:42
*** ssurana has joined #openstack-kolla16:42
*** mark-casey has joined #openstack-kolla16:47
mark-caseyhey all. how are server reboots handled in multinode? do you just run kolla-ansible reconfigure?16:52
mark-caseyand, I guess, is this any different if only one server got rebooted16:52
*** berendt has joined #openstack-kolla16:52
inc0mark-casey, well, you shouldn't have to run anything16:54
inc0stuff should just work16:54
inc0problem is with all controllers reboot as you need to rescue mariadb16:55
inc0we have play for that16:55
*** ppowell has quit IRC16:58
mark-caseyinc0: ok. so docker comes up and the restart=always takes care of it except galera?16:58
inc0well, in theory16:58
mark-caseyhehe, sure16:58
inc0if you have aio you will run into race conditions16:58
inc0but with multinode it should work16:58
mark-caseyinc0: is that because aio is lacking the HA bits so won't retry as much if out of order?17:00
inc0well, with aio nova will stand before keystone or mariadb and such17:00
inc0order is random17:00
inc0with multinode you still have haproxy dealing with that17:00
inc0now when I think about it if keepalived migrate floating ip before haproxy stands we might have race17:01
inc0but that's unlikely and it will cause subsecond downtime17:01
mark-casey:)17:01
*** diogogmt has quit IRC17:02
*** diogogmt has joined #openstack-kolla17:03
*** dwalsh has quit IRC17:05
openstackgerritMark Goddard proposed openstack/kolla: Don't always unpack image build results tuple, as it may be None  https://review.openstack.org/32350517:19
*** dwalsh has joined #openstack-kolla17:20
*** ppowell has joined #openstack-kolla17:21
*** dwalsh has quit IRC17:26
*** unicell has joined #openstack-kolla17:26
*** d_code has quit IRC17:27
*** zhiwei has joined #openstack-kolla17:31
*** vhosakot has quit IRC17:34
*** zhiwei has quit IRC17:36
*** Serlex has quit IRC17:36
*** vhosakot has joined #openstack-kolla17:37
*** dwalsh has joined #openstack-kolla17:40
openstackgerritKen Wronkiewicz proposed openstack/kolla-kubernetes: Adding the password generation step to the docs.  https://review.openstack.org/32236217:43
*** ravig has joined #openstack-kolla17:45
openstackgerritKen Wronkiewicz proposed openstack/kolla-kubernetes: [doc] change Ansible version to exactly 2.0.x in quickstart.  https://review.openstack.org/32236117:46
*** ravig has quit IRC17:47
*** Lyncos has joined #openstack-kolla17:49
*** ravig has joined #openstack-kolla17:54
mag009_inc0: i found my problem btw... the mount issue that I had17:57
mag009_apparently it was caused by the lxd installed on my ubuntu server17:57
mag009_after uninstalling anything to do with lxd and lxc docker work like a charm17:57
inc0yeah Lyncos already told me, be a good community people and make a note in quickstart please;)17:58
*** fragatina has joined #openstack-kolla18:03
*** d_code has joined #openstack-kolla18:04
vhosakotyes, please add this info in quickstart18:05
openstackgerritMarc-Andre Gatien proposed openstack/kolla: adding Note for ubuntu 16.04  https://review.openstack.org/32351918:13
mag009_done18:14
*** mark-casey has quit IRC18:17
*** ravig has quit IRC18:17
openstackgerritMarc-Andre Gatien proposed openstack/kolla: adding Note for ubuntu 16.04  https://review.openstack.org/32351918:20
*** SiRiuS has quit IRC18:23
mliimamag009_, add . after )18:24
openstackgerritMarc-Andre Gatien proposed openstack/kolla: adding Note for ubuntu 16.04  https://review.openstack.org/32351918:25
mag009_are you guys going to focus on reducing the size of the images ? like using alpine18:26
mag009_mliima thanks!18:26
*** ravig has joined #openstack-kolla18:26
*** Mr_Broken has quit IRC18:28
*** Mr_Broken has joined #openstack-kolla18:29
*** mdnadeem_home has quit IRC18:33
*** nilk has joined #openstack-kolla18:36
nilkHey guys18:36
nilkso... we've tried to deploy an OpenStack cluster with stable/mitake18:36
nilkbut all we got is this error in production: https://bugs.launchpad.net/kolla/+bug/158722618:37
openstackLaunchpad bug 1587226 in kolla "gate failed with the error publicURL endpoint for compute service not found" [Undecided,New]18:37
nilktwo controller nodes, two network nodes, one compute node (for now)18:37
nilkstable/mitake18:37
nilksource-based18:37
nilkCentOS 718:37
nilkthe MariaDB deployment doesn't work either since the timeouts are too short, it gets stuck in a funny state where both instances hang in a loop and write multiple MB of logfiles18:41
nilkwe fixed that one, but no idea about the compute node issues18:42
nilkthe endpoint simply isn't created (neither is the service)18:42
*** SiRiuS has joined #openstack-kolla18:47
*** fragatina has quit IRC18:51
*** tyrola has quit IRC18:51
*** d_code has quit IRC18:52
*** fragatina has joined #openstack-kolla18:52
inc0hmm19:05
inc0nilk, so deployment succeeded?19:05
inc0I mean ansible ran correctly?19:05
*** mdnadeem has quit IRC19:08
*** mdnadeem has joined #openstack-kolla19:09
*** ravig has quit IRC19:11
*** efoley has quit IRC19:11
*** ravig has joined #openstack-kolla19:15
*** daneyon_ has joined #openstack-kolla19:15
Davieynilk: Actually, i agree with the timeout... I've seen that a few times... I upped it to 120 seconds.  What worked for you?19:17
*** ravig has quit IRC19:18
*** daneyon_ has quit IRC19:20
*** ravig has joined #openstack-kolla19:21
*** tyrola has joined #openstack-kolla19:22
*** inc0 has quit IRC19:23
*** Mr_Broken has quit IRC19:29
*** Mr_Broken has joined #openstack-kolla19:30
*** Jeffrey4l_ has joined #openstack-kolla19:32
*** Jeffrey4l has quit IRC19:34
*** Mr_Broken has quit IRC19:34
*** ravig has quit IRC19:34
*** mdnadeem has quit IRC19:38
*** mdnadeem has joined #openstack-kolla19:39
*** dwalsh has quit IRC19:39
*** mdnadeem has quit IRC19:39
*** dwalsh has joined #openstack-kolla19:39
*** tyrola has quit IRC19:39
*** mdnadeem has joined #openstack-kolla19:40
*** mdnadeem has quit IRC19:40
*** mdnadeem has joined #openstack-kolla19:41
nilkinc0: yes, it deployed, Horizon works, it's just that the endpoint did not get created19:42
nilkDaviey: 60s19:42
*** ravig has joined #openstack-kolla19:44
*** sdake has joined #openstack-kolla19:45
*** sdake_ has joined #openstack-kolla19:49
nilkinc0: what actually happens is that register.yml is skipped for the controller nodes19:49
*** sdake has quit IRC19:51
*** inc0 has joined #openstack-kolla19:52
*** mdnadeem has quit IRC19:53
inc0Texas...19:53
inc0storm came in and power went out19:54
*** mdnadeem has joined #openstack-kolla19:54
inc0it's been storming every day for few days now19:54
*** ayoung has quit IRC19:54
*** ayoung has joined #openstack-kolla19:55
nilkinc0, weather has been a bit rough in Germany, too19:56
inc0I've seen photos from Czech with hail19:56
nilkwe got lucky, a few villages got destroyed19:56
inc0we had similar hais few months back19:56
nilkbut people have been really lucky19:57
inc0nilk, which part of germany?19:57
nilkSouth19:57
inc0yeah...that was crazy19:57
inc0global warming all right19:57
inc0nilk, you mentioned some issues you were having?19:57
inc0I lost it due to well...storm19:58
*** tyrola has joined #openstack-kolla19:58
nilkhttp://www.tagesschau.de/multimedia/bilder/unwetter-383.html19:58
nilknp I mostly figured it out anyway19:58
nilkwhat happens is that it only attempts to run nova's register.yml on the compute nodes19:58
inc0ok19:58
nilkwhich is pointless since inventory_hostname in groups['nova-api'] does not match19:59
inc0hmm, it should do this on controller nodes19:59
nilkyeah that's what I thought, too19:59
nilkno idea why this happens but if I manually patch it, it works19:59
nilkthe controller nodes are in nova-api, the compute node isn't20:00
nilkhttp://paste.openstack.org/show/506649/20:00
inc0which ansible are you using?20:01
inc01.9.4 for stable/mitaka?20:02
nilkyes20:02
inc0it sometimes does that, there is bug for it20:02
inc0hold o20:02
inc0n20:02
*** tyrola has quit IRC20:02
inc0it was about ordering of hosts, bug in ansible20:02
nilkfun fact: it worked a few times and we have no idea why it no longer does20:03
inc0well, can't find bug now, but it was apearing from time to time in neutron20:03
inc0anyway move to ansible 2 should help, but we just merged ansible 2 support20:03
nilkwe're scared of master20:04
nilkalso we don't want to rebuild all images20:04
inc0https://github.com/openstack/kolla/blob/master/ansible/site.yml#L100 try to move nova-controller above compute20:04
inc0nilk, wise20:04
inc0mitaka should be good, I don't advice moving to master20:05
inc0just saying it should be better20:05
nilkI think Ansible 2 is only in master?20:05
*** dmk0202 has joined #openstack-kolla20:05
inc0yeah20:05
inc0anyway, try hack I shown you20:05
inc0change order of hosts in this file20:06
inc0and see if it helps20:06
inc0nova-api above compute **20:06
nilkit worked20:07
nilkthank you so much20:07
nilkbut... WTF20:07
inc0no problem20:07
inc0yeah, this is one of *these* bugs20:07
nilkthat one cost me a lot of time :P20:07
inc0anyway, should be fixed after move to ansible220:07
inc0glad I could help20:07
inc0you can publish a patch with order change if you want20:08
*** mdnadeem has quit IRC20:08
nilkwe undid everything we did since we believed that something we did broke it20:08
inc0so others won't catch the same issue20:08
nilksince it worked in the beginning20:08
nilknice one20:08
inc0yeah I know the pain20:08
inc0this is a bug in ansible itself20:08
*** mdnadeem has joined #openstack-kolla20:08
inc0we hit that in neutron and we change the ordering there20:09
*** SiRiuS has quit IRC20:09
inc0issue is, it kinda happen randomly20:09
nilkyeah I realize, I'm not even complaining20:09
inc0I deployed mitaka multiple times and never seen it20:09
nilkjust... WTF20:09
nilkeverything else has been smooth so far, except for that MariaDB issue20:10
inc0yeah, we have issues with galera from times to times20:10
inc0what did you change?20:10
inc0which timeout?20:10
nilkactually, I added pause statements after starting each container20:11
nilkit works in master20:11
nilknot in mitaka20:11
nilkas in, it works out of the box in master but we had to fix in Mitaka20:11
nilkI'm really impressed with Kolla, great job20:12
nilkwe're using it for our new production cloud20:12
inc0I'm glad to hear that:)20:12
inc0wonderful, we need people deploying it so we'll test ourselves in fire so to say20:12
nilkdocs are a bit lacking at times, I hope that I'll find time to commit a few fixes20:13
inc0let us know if you run into any issues, we're happy to help20:13
inc0docs are one of big priorities this release20:13
inc0they're horrible now, but we're getting there20:13
nilkalso it's easy to make mistakes that result in non-descript errors20:13
inc0yeah, ansible 2 helps a bit20:13
inc0but really we need better prechecks and sanity checks20:14
Davieyinc0: Thinking of adding support for ansible --diff|--check (dry run stuff?)20:14
nilkyes20:14
nilkit shouldn't even run with SELinux enabled or wrong Ansible or Docker version20:14
inc0Daviey, well we have playbook with some check stuff, but that's a good idea20:14
inc0we need lots of infrastructure like that20:15
inc0for now we were focused on main features, now user experience20:15
Davieyinc0: Call me a scaredy cat, but i'm really worried about making a fat fingered typo and flushing all the data away :)20:15
inc0I'm working on refactoring of dockerfiles as we speak;)20:15
inc0Daviey, I totally get that, fortunately it'll be hard to flush data with kolla20:16
nilkwe made a nice script which tears down the entire cluster in a few seconds20:16
nilkpretty cool20:16
inc0as we have cleanup tools completely separate from our plays20:16
nilkalso extremely scary20:16
inc0nilk, tools/cleanup-host and tools/cleanup-containers20:16
inc0these are scary scripts20:16
inc0but do what you just said20:17
nilkyes we use those20:17
inc0ansible -m script and go ahead;20:17
sdake_kolla-ansible cleanup does the job too :)20:17
nilkwe made sure that no customer data survives either20:17
Davieyyeah, i wrapped scp'ing them along with flushing the parition table and renaming the ceph block device20:17
Davieyand executing them over ssh20:17
inc0Daviey, use ansible, ssh is passe;)20:18
Davieysdake_: not in stable/mitaka it doesn't20:18
inc0sdake_, btw, I'm working on providing alternative to DSL20:18
Davieyinc0: fair point :)20:18
inc0I really dislike this idea, I'll publish demo of refactored dockerfiles to make use of more advanced jinja20:18
nilkso. fix deployed, I'll re-deploy the cluster20:19
nilkif it works I'll get drunk20:19
inc0haha20:19
nilkspent three days fighting this20:19
inc0drink one for us;)20:19
Davieynilk: 3 days? n00b.20:20
inc0god I miss European beer20:20
sdake_inc0 jinja2 = not convinced20:20
nilkDaviey, yes, for sure20:20
nilklots of auxiliary stuff unrelated to Kolla20:20
inc0sdake_, well, we already have it20:20
sdake_inc0 but if you can meet the numerous requreiments I have - then we can consider it :)20:20
inc0what are the requirements?20:20
Davieynilk: (i'm only about 3 x more than you)20:20
inc0also we already use jinja220:21
nilk:P20:21
inc0it's your DSL we should consider not the other way around:P20:21
inc0you're one making a revolution20:21
sdake_I need to be able to customize any part of any dockerfile by 1) merging one section into another 2) overridding whats there20:21
inc0well, you can change dockerfiles...20:21
sdake_inc0 i will make surer there is no feature loss20:21
sdake_without changing dockerfiles20:21
inc0well you need to change something20:22
sdake_i am good with changing a user provided file20:22
inc0either it's dockerfile, jinja tpl or your dsl tpl20:22
inc0conditional includes, there you go..20:22
inc0I don't like DSLs, will make stuff super hard20:22
inc0not to mention that we'll have bunch of code to support20:23
sdake_ok first up - need a separate repository per container20:23
inc0eee? why?20:23
sdake_how do you do that with conditions in a sane way?20:23
sdake_$$dayjob wants that20:23
inc0repository per container? We specifically didn't want that20:23
sdake_we need flexibility to be able to handle it20:24
sdake_and we didn't want it by default, we never said we didn't want it at all20:24
inc0but git clone --recursive is answer for you20:24
*** mliima has quit IRC20:24
inc0well we either have all it kolla repo or create shitload of repos20:24
sdake_inc0 have you tried my dsl implementation?20:25
Daviey(or, move the files to the source project)20:25
*** mark-casey has joined #openstack-kolla20:25
*** jtriley has quit IRC20:25
inc0I did look at it20:25
inc0and I didn't really like it tbh20:25
inc0all sorts of things may go wrong20:25
sdake_inc0 what would need to happen for include per repo is you would have to do a #include nova-compute-repo.txt20:25
sdake_yo uwould need that for very type of includeable thing20:25
inc0also I'd rather start by stating a problem, then discuss how can we solve it with what we already have20:25
sdake_and it would have to do the right thing when the file is not present20:26
sdake_inc0 did you run the tool that generates parsed dockerfiles?20:26
inc0no, I believe it works20:26
inc0I just don't like idea itself20:26
sdake_its so simple and straightforward20:26
inc0until it stops being simple20:26
sdake_build.py is out of hand20:26
sdake_even pbourke_ agrees20:27
inc0people already started to create their own tailored dockerfiles20:27
inc0and we're screwing them off20:27
*** ayoung has quit IRC20:27
inc0and I'm -2 to screwing people off20:27
sdake_tailored dockerfiles are not the answer20:27
sdake_but lets assume someone has a tailored dockerfile20:27
*** dmk0202 has quit IRC20:28
sdake_I'll personally write a conversion to the new technique for them - so no screw off for them20:28
sdake_if there are such people20:28
sdake_if you had tried the tool20:28
inc0sdake_, please, let's start with problems we want to solve20:28
sdake_yo uwould see its super simple20:28
sdake_i told you the problem I want to solve20:28
inc0multiple repos, got it20:28
inc0can do with jinja20:28
sdake_not just multiple repos20:29
sdake_i want to be able to customize anything in the dockerfile20:29
sdake_in a  programmatic way20:29
inc0conditional includes, can do with jinja20:29
inc0dockerfiles are DSL20:29
sdake_ok let me give you a scenario20:29
inc0I don't like idea of DSL for DSL20:29
sdake_i have custom repo20:29
sdake_I have two binary rpms that must be installed for plugins20:29
sdake_I want to override all of the custom repositories provided by CentOS because I have some sort of business relationship with Mirantis and want to ship their distro instead20:30
sdake_can that be done in j2?20:31
inc0so, first one is easy20:31
inc0--include-header << dockerfile with setup of repos and install packages >>20:31
inc0you can do this now20:31
sdake_yes but  that is per build20:31
sdake_we need it per repo!20:31
sdake_rather per conttainer20:32
inc0second one, with refactoring I'm doing now you'll have separate file called "redhat-dockerfile" with block "setup-repo"20:32
inc0all you need to do is create your own new myown-dockerfile20:32
DavieyHow are you planning to have known good version compatability with multiple external branches?20:32
kklimondainc0: I have local ubuntu mirrors, and I want to use them instead of archive.ubuntu.com - I can't do that easily right now20:32
inc0with block setup_repo20:32
inc0and point build.py7 to it20:32
sdake_inc0 here is where we are in disagreement20:33
sdake_I think build.py has too much logic20:33
sdake_I think it muddles how the dockerfiles are built20:33
inc0well, let's refactor build.py20:33
sdake_and you are proposing addding even more logic20:33
inc0I agree20:33
inc0well, you want to replace this logic with new logic of a DSL20:33
Davieykklimonda: I used to rewrite dns for  to easily solve that.20:33
inc0kklimonda, for apt packages you have this file:20:34
nilkw00t20:34
nilkit worked!20:34
sdake_inc0 if you can deliver the 3 things above in some consistent way using j2, by providing all those files ahead of time, then i guess that would wfm, although I think it would be clunky20:34
inc0https://github.com/openstack/kolla/blob/stable/mitaka/docker/base/sources.list20:34
nilk0 to OpenStack in a few minutes20:34
*** fragatina has quit IRC20:34
nilkI really like this project :)20:34
sdake_nilk kolla pretty sweeet huh :)20:34
inc0sdake_, I can provide it and I disagree20:34
inc0that it would be clunky20:34
inc0remember that I was opposet to limit ourselves to "only using if statement in jinja"20:35
inc0that was discussion we had in Santa Clara20:35
inc0but we decided to only use if's so here we are20:35
Davieynilk: Why did you choose to roll your own images, rather than use kollaglue's?20:35
sdake_that is so we could get a basic implementation down before people started rocket scientisting20:35
*** godleon has joined #openstack-kolla20:35
inc0now we can move ouit of this limit and write proper temnplates20:35
sdake_inc0 i am by no means a inj2 template expert20:36
inc0sdake_, I know, now we can refactor and include some syntactic sugars from jinja20:36
sdake_but imo this problem cannot be solved by teplates20:36
nilkDaviey: easier to implement custom fixes that way20:36
nilkalso, security considerations20:36
inc0it can by templates AND refactor of build20:36
Davieynilk: Such as?  I'm genuinely interested20:36
inc0and we should do both, I agree20:36
kklimondainc0: good point, although I also had to provide my own gpg keys.20:36
sdake_inc0 also the dsl parser produces more optimized output:)20:37
nilkDaviey: say we want to backport something from OpenStack master, or fix a bug related to our setup20:37
inc0kklimonda, --include-header << path to file with dockerfile code that includes them >>20:37
sdake_but you think docker.inc would sort that problem out on their own20:37
inc0during build20:37
nilkthis way, we know that the build process works and we can just rebuild it from Git20:37
sdake_inc0 here is what I think you are proposing20:37
sdake_in every dockerfile20:37
sdake_follow a structure like20:37
kklimondainc0: yes, that's doable but I just don't think it's the right way to extend templates - I consider it a hack tbh20:38
sdake_{include my own bins}20:38
sdake_{include external bins}20:38
sdake_{include my own srcs}20:38
sdake_{include external srcs}20:38
inc0kklimonda, it is, and extending dockerfiles is what we're discussing20:38
Davieykklimonda: Why would you need to do your own gpg?20:38
sdake_{include my own repos}20:38
sdake_{include external repos}20:38
inc0sdake_, no, that's not what I propose20:38
inc0let me polish idea a bit but essentially what I want20:38
inc0is20:38
kklimondaDaviey: I have a custom repository with some additional packages20:38
nilkDaviey: many serious deployments end up carrying their own patches on top of stable OpenStack and this way, we know that it won't hurt us in the future20:39
inc0in main Dockerfile we have block {% block include_repos %}20:39
nilkalso, the fewer external dependencies, the better20:39
Davieynilk: perfect, thanks20:39
inc0then we have ubuntu-dockerfile.j2 which has {% block include_repos %}<<ubuntu logic with repos20:39
inc0centos will be centos-dockerfile.j220:40
inc0and you can add myown-dockerfile20:40
inc0wich, if present will be used20:40
inc0and you can override blocks on your own20:40
sdake_what about per container repos?20:40
sdake_I totallly get how you can include one file in another in jinja2 ;)20:40
inc0it's not just file inclusion20:40
Davieynilk: Are you using insecure docker registry?  Did you HA it all?20:40
inc0ehh, I'll show it by example20:41
inc0just give me a few20:41
nilkDaviey: secured registry20:41
nilkHA is unnecessary since it's not production critical20:42
sdake_inc0 to me, what wins is what offers the easiest user interaction20:43
Davieynilk: you aren't worried about losing images?20:43
inc0sdake_, devil is in the details as always20:43
inc0it will work until we find some edge case and need to code around it20:43
inc0this is why build.py is big and ugly now20:43
inc0all the edge cases20:43
sdake_yes - dsl solves this :)20:44
inc0and you want to add another layer of complexity above it20:44
inc0no, it will add layer of complexity20:44
sdake_i'd like to make build.py just build raw dockerfiles with dependency management20:44
kklimondaDaviey: is there a reason to keep images around? rebuilding them is pretty fast20:44
sdake_I'd like this eparse.py code to produce the raw dockerfiles20:44
*** dmk0202 has joined #openstack-kolla20:44
sdake_and yes I'd like a cli on top that  integrates these two things togetheer20:44
sdake_I'd like to eject all the speciial snowflakes from build.py20:45
inc0we can solve it with making build.py a better tool20:45
inc0and optimize jinja220:45
nilkDaviey: backups for sure, but apart from that, no worries20:45
inc0sdake_, agree...this is refactoring20:45
sdake_i haven't passed judgement on jinja220:45
inc0instead of reinventing wheel let's try to make ones we have more round20:45
sdake_other then to think I thought it couldn't be done20:45
sdake_again if it works better for the operator, thats a win in my booko20:45
inc0well, more things can be done than you think20:46
sdake_like I said not a  jinj2 rocket scientist20:46
inc0operators likes to have insight into what's happening20:46
inc0obscuring it by DSL is not that20:46
inc0dockerfiles are little more than shell scripts20:46
sdake_the buld process produces the exact dockerfiles needed for the build20:46
inc0all commands are there and it's visible20:46
sdake_that doesn't obscure anything20:46
inc0well until you want to change something20:46
Davieykklimonda: I want to have a consistent infra'.  Ie, know that my cloud has all the same version of the image20:46
sdake_inc0 right - end users should never have to change something in a dockerfile!20:47
*** wmiller has quit IRC20:47
inc0ofc they should, they could and they will20:47
inc0we are deployment tool20:47
inc0changing repo is an example20:48
sdake_no, dockerfiles are what kolla provides to buid limages20:48
sdake_user provides their own customization logic20:48
inc0only one example among 100s20:48
sdake_not logic data20:48
inc0ehh, trust me we'll have snowflakes deployed by kolla20:49
inc0and you can't code for every single one of them20:49
inc0especially if you want to keep k8s and such working20:49
kklimondaDaviey: yes, but in that case you'd probably want to use frozen repository and frozen base image anyway? otherwise you can't be sure that image you are building to patch a service will have all the same dependencies anyway20:49
inc0for me it's better to keep API close to source of normal dockerfiles20:49
inc0and allow people to change it easily withpout us limiting them by features of DSL20:50
sdake_inc0 i'd like to measure success on objective use cases20:50
inc0and time to get them in place20:50
inc0and stability of resulting code20:51
sdake_some ide athat someone will come alog and change the dockerfile is not objective, I can't see it being done if we do the customization job correctly20:51
sdake_if we don't do the customization job correctly, then yes of course the dockerfiles will have to change20:51
sdake_this is what led to the dsl development in the first place20:51
inc0so we should strive to accomodate as much use cases as possible without destabilize what we have20:51
inc0and that's what you're proposing20:51
inc0destabilization20:51
Davieykklimonda: agreed20:51
sdake_inc0 i'm not sure how you jumped to destabilization from new code ;)20:51
inc0well you want to chagne architecture of what we have20:52
inc0that's always destabilization20:52
sdake_two 6 week windows under which to fix bugs20:52
inc0also I care about upgrades with as much backward compatibility as possible20:52
sdake_its the same thing we went through when we ejected the symlinks20:52
* kklimonda wishes that docker tags other than :latest were immutable..20:52
sdake_fwiw I had thought a dsl would work at that time20:52
inc0and backward compatibility means if people used something in mitaka it should work in liberty20:52
inc0newton**20:53
sdake_but I didn't think we could technically pull it off correctly because we had too many unknowns in our dockerfiles20:53
sdake_now all the unknowns are knowns20:53
inc0by newton people will have cicd systems based on build.py20:53
inc0which you'll break20:53
inc0so before we'll break stuff like that20:53
inc0let's try to solve problems without breaking them20:53
sdake_you jsut said above the fundamental structure of bulild.py is unsound20:54
inc0which I'm certain we can, just lets have a discussion not jump to conclusions20:54
inc0I agree, refactor it20:54
sdake_refactoring a bad design leads to another bad design20:54
inc0we need to break build.py into more managable chunks of code20:54
sdake_the breaking of build.py apart could potentiallly fix it20:54
inc0but it's not bad design, it evolved from "Another simple script"20:55
sdake_however jinja2 and the logic are all mixed up in the build tool20:55
inc0and you want to replace it with "Another simple script"20:55
sdake_i want to keep most of build.py instact20:55
sdake_minus the jinja2 parts20:55
inc0build.py is baded on jinja20:55
inc0that's why it's in python20:55
sdake_ok instead of circular arguments20:56
inc0you want to remove a year of work we put into it20:56
sdake_that is sunk cost thinking!20:56
inc0no, I'm trying to make you realize that PoCs are nice20:56
inc0but reality often breaks stuff20:56
sdake_avoidance of sunk cost thinking is what got us to where we are today - which is from dead to emergent20:56
inc0tell me that, how do you add proxy setting to your dsl?20:57
sdake_i am totally willing to admit this dsl coudl have bugs20:57
sdake_but we have an etire 6 months to fix it20:57
inc0it's not about bugs, it's about edge use cases20:57
sdake_inc0 can you leave that question in the review20:57
inc0we will spend a lot of time to arrive to feature parity we have now20:57
sdake_yes plus a whole slew of new features with a radically simpler implementation20:58
inc0and then we'll have another bunch of code that's hard to maintain20:58
inc0I prefer starting from "let's try to refactor what we have" than "let's throw it away and start over"20:58
sdake_inc0 figuring out what *I* want customized is easy20:58
sdake_its anything with a top level DSL tag in my dsl documentation20:58
*** prithiv has joined #openstack-kolla20:59
inc0ehh, let me provide counter proposal20:59
sdake_i want the customizations done once (on disk) but applied to ALL dockerfiles during build20:59
inc0also please let's have a spec for this one20:59
*** dwalsh has quit IRC20:59
inc0this one requires a spec, too much controversy20:59
inc0and start a spec with stating a problem you're solving20:59
sdake_inc0 your the only one controversing but if you want a spec you got it :)20:59
inc0including all the use cases you want to solve20:59
inc0well, I am controversing, that's my job as "guardian of the gate" right?21:00
sdake_i wasn't making insult21:00
inc0so yes, please spec it up, formalize a problems and we will discuss how to solve them best21:00
sdake_i was pointing out your the only one not on board out of the cores I've spoken with :)21:00
inc0I didn't feel insulted21:00
inc0well, sorry21:01
inc0:P21:01
sdake_so a spec vote will be a waste of time21:01
inc0but I'm a stubborn person21:01
*** pbourke-home has joined #openstack-kolla21:01
sdake_but whatever - wfm :)21:01
inc0I don't want a vote, I want problem statement21:01
inc0and discussion before jumping to conclusions21:01
sdake_inc0 the conclusion of a spec is a vote21:01
sdake_inc0 i am just jumping to hte fact there will be a vote and it will pass21:02
sdake_hence waste of time21:02
sdake_but if yo uwant further docs, I am happy to provide ;)21:02
inc0cool, in the menatime I'll work out some demo of jinja2 refactor21:03
*** thumpba has quit IRC21:03
inc0and an idea how to make it super extensible with allowance of user-provided stuff21:03
kklimondaif it were possible to cover all usecases you're designing DSL for, just by making better use of jinja2 templates, then not adding additional layer of complexity is a goal worth pursuing imo.21:03
sdake_cool i've already proven a dsl can work for this use case in princple21:03
inc0kklimonda, +2 to that21:04
inc0dsl can work, it's cost of making it working and making old stuff stop working that I don't want21:04
inc0people already build around our API21:05
inc0and API shouldn't change that much21:05
inc0and build.py is our API21:05
sdake_i had not tried jinja2 because I didn't think it offered programmatic manipulation21:05
sdake_but i guess that can be done in hacky fashion which is aok for a ci/cd gate21:06
sdake_which is typically full of hacking21:06
sdake_inc0 you recognize if I had not written prototype, I could not write spec :)21:07
inc0no, it can be done with pretty elegant way21:07
openstackgerritChristian Berendt proposed openstack/kolla: Add passwords parameter to LONG_OPTS in kolla-ansible script  https://review.openstack.org/32358521:07
inc0prototypes are cool21:07
sdake_in that vein, can you rpovide a prototype of base, openstack-base, mariadb, and neutron21:08
sdake_this is what I intend to provide - we can compare the implementations21:08
inc0working on it21:09
rhalliseysdake_, so I'm not sure about dsl yet either.  Since I think we can do plugins with j221:10
rhalliseybut we can have that discussion tmr.  I'm on my way out21:10
sdake_one thing I really hate in build.py very much, is it includes repository names21:10
sdake_that is just plain wrong21:10
sdake_inc0 also yml has an inclusion thing - called anchor blocks21:11
*** rhallisey has quit IRC21:11
sdake_inc0 acnhor blocks are one way to solve the include header and footer21:12
sdake_the beuty of the dsl is it includes only what is necessary and nothing else21:12
inc0until it starts being necessary and then we need to extend dsl21:14
inc0so we extend dsl and it becomes uglier in time21:14
inc0that's what happend with build.py21:14
*** ppowell has quit IRC21:14
sdake_this is beuty of dsl, its in yaml it can easily be converted from one format to another with a few python calls21:15
sdake_vs jinja2 which requires significant human hand holding21:15
sdake_the main thing I am after is that the base dockerfiles *we* provide in the kolla project are completely unmodified21:16
sdake_(I get they need to be modified to support the work you speak of)21:16
openstackgerritMichal Jastrzebski (inc0) proposed openstack/kolla: Refactor of base Dockerfile to allow custom repo  https://review.openstack.org/32358921:18
inc0just to demo up what jinja2 can do21:19
inc0we can break this up even more, as much as we want21:19
inc0working on openstack-base with all it's long installs21:20
sdake_inc0 the immediate problem I see with your implementation is twofold - 1) extending build.py 2) we will end up with a custom file for every type - how to handle that for every container?21:21
sdake_oh and 3 ) all the infroatmion is now spread out throug hthe system instead of in one place21:21
sdake_there is logic for processing the jinja2 files, logic to including inside jinja2 in separate locations21:22
sdake_but don't just cusstomize repositories, customize *everything*21:22
inc0extending build.py won't be an issue if we refactor it21:22
inc0which we should do21:22
inc0we can customize just repos if we want to, by adding more blocks21:23
*** ayoung has joined #openstack-kolla21:23
inc0this is effect of 2hrs of work, bear with me, it will take more to refactor all the stuff21:24
sdake_i want customization of everything21:25
sdake_not just repos21:25
sdake_and i want to be able to delete stuff that is already there and stock replace it21:25
sdake_or altneratively merge with what is therre21:25
sdake_these are my objectives for the dsl21:25
inc0so, I can do that21:26
inc0you can't21:26
inc0because21:26
inc0how will you add custom option to apt-get install run?21:26
sdake_not custom options, custom packages21:27
inc0like for example proxy or sth21:27
inc0no, I want custom option21:27
inc0impossible with your dsl21:27
inc0easy with my macro21:27
sdake_not impossible would require another key21:27
sdake_i dont see the use case for that though21:27
inc0 self.output.append('RUN yum -y install %s \\' % value) << from eparse21:28
sdake_why would you possibly want to customize what is passed to apt or yum?21:28
inc0sdake_, proxy config21:28
inc0-o HttpProxy::whatever21:28
sdake_inc0 could you expand21:28
sdake_can you provide an example where that is used today?21:28
inc0instead of apt-get -y install I want apt-get -y -o HttpProxy::whatever install21:28
inc0in custom dockerfiles people might have21:29
sdake_ok, where is that used in current dockerfiles?21:29
sdake_isnt' include header and footer for proxies?21:29
kklimondano21:29
inc0you were one sayng "customize everything"21:29
kklimondaI mean, there is also http_proxy and https_proxy env variables login in build.py files21:29
sean-k-mooneyinclude header and fuooter does work for proxies21:29
kklimondalogic*21:29
sdake_inc0 we are not amking progress - I will write spec to unblock us21:29
inc0please do21:30
inc0and make sure to specify problems you're trying to solve21:30
inc0because I struggle with this part21:30
sdake_of course21:30
sdake_what I reallyt need right now is cusstom repositories21:30
inc0that's one is doable21:30
sdake_what I really want is for the pain in build..py to go away21:31
sdake_the structure of build.py is not ideal21:31
inc0that's one is called refactoring21:31
sdake_it does dep management, variable replacemnet, now macro insertions, etc21:31
sdake_and it communicates with docker as well ;-)21:31
inc0therefore we should split it into modules21:31
inc0for jinja2 parsing, docker communication21:32
inc0refactoring in a word21:32
inc0refactoring != write new prettier wheel21:32
sdake_i am pretty sure I know what refactoring is21:32
*** ravig has quit IRC21:32
sdake_i want a bunch of stuff customizable, and a bunch of stuff overrideable21:33
sdake_(the same things)21:33
sdake_these are21:33
sdake_binaries installed, pip installed, repos installed21:33
sdake_i would like to keep c&p to a minimum21:34
sdake_run the eparse code21:34
sdake_look at the output21:34
sdake_it wlil take ou 5 minutes21:34
sean-k-mooneyone thing that has been raised in the past is the ablity to build non openstack project from source to allow custimisablity21:34
sean-k-mooneye.g. openvswitch to allow dpdk or ovn support21:35
inc0sean-k-mooney, that's a different discussion to have..21:35
sdake_sean-k-mooney actually my wife had suggested I take this dsl thing to a wider audience but I'd like to limit to kolla for the moment21:35
dmsimardI haven't been very involved in kolla but creating and maintaining a new DSL and parser exclusive to Kolla docker files sounds nuts, this sounds like a problem that other people should have had and solved before Kolla21:35
sean-k-mooneyinc0: my point was that makeing the docker files more overriable would allow for that without requireing the code to be in tree21:35
wirehead_Well, I just showed one of the Helm developers Kolla-Kubernetes today. :D21:35
inc0sean-k-mooney, yeah, I have idea how to do it;)21:36
inc0dmsimard, +2 to that21:36
inc0sean-k-mooney, https://review.openstack.org/#/c/323589/21:36
patchbotinc0: patch 323589 - kolla - Refactor of base Dockerfile to allow custom repo21:36
inc0idea is - we'll add bunch of {% block %} in our code21:36
sean-k-mooneydmsimard: this is one example https://github.com/avirshup/DockerMake21:36
inc0and you'll be able to put custom stuff in each21:37
inc0including building and such21:37
sdake_inc0 what about custom stuff in the neutron container?21:37
wirehead_I think there are some big concerns that are fairly specific to Kolla.  c.f. the majority of software bundlers are OK with picking one distro, but picking a single distro to run OpenStack on would be a disaster.  Thus, we’re always going to need some artisinal handmade software.21:37
inc0we can add {% block neutron_server_post_install %}21:37
inc0and then you have custom dockerfile that injects stuff there21:38
inc0easy and clean21:38
sean-k-mooneyare people familar with devstack plugin model?21:38
dmsimardSurely there has to be a solution outside of Kolla, I wish I was more familiar with both docker and kolla but I'm not. You're the experts and I'm sure you've looked at what was out there like docker-compose and whatever. It just strikes me as odd that this would be a problem just for Kolla.21:38
sean-k-mooneythey have a number of phase that allow externel plugins to execute at different stages in the install.21:38
*** dmk0202 has quit IRC21:38
inc0dmsimard, imho we already have an answer - jinja221:38
dmsimardsurely it has it's flaws, but it's certainly more approachable than a custom dsl that would higher the barrier to entry imo21:39
sean-k-mooneyinc0: if you add entry points a block and define different phases such as (pre-repo-setup, post-repos-setup ...) it would allow costimisation as you suggest21:40
inc0sean-k-mooney, jinja2 allows that in a better way imho21:40
dmsimardsean-k-mooney: so docker make is essentially a dsl :p21:40
sdake_inc0 in closing read this: https://review.openstack.org/#/c/322345/2/doc/elemental-guide.rst21:40
patchbotsdake_: patch 322345 - kolla - Documentation for elemental DSL21:40
inc0in a way that people will be able to create whole projects consuming our jinja2 dockerfiles21:40
inc0dmsimard, yeah, dockerfile is a dsl, jinja2 is a dsl...and when we create dsl for dsl I become suspicious21:41
inc0and we're thinking about dsl for dsl for dsl21:41
sean-k-mooneydmsimard: yes my point there was you are right there are DSLs for this already so rather then invent an new one for kolla we could extend an existing one.21:41
sean-k-mooneydmsimard: if that was a better path then jinja221:41
dmsimardsean-k-mooney: ah, yes, agreed. Creating a new one is probably not the right approach.21:41
wirehead_I repeat: Most of the world of software doesn’t need multi-distro.21:42
inc0sean-k-mooney, we already have jinja2 so we don't include new stuff21:42
inc0wirehead_, but there is not a single distro they need21:42
sdake_wirehead_ if your tlaking about openstack, you do need multidistro21:42
sdake_wirehead_ that topic isn't open for debate ;)21:42
wirehead_Yep.21:42
inc0but I agree, there is no value in having multidistro coexist in same deployment21:42
inc0we won't support that21:43
wirehead_OpenStack needs multi-distro.  The rest of the world, largely, doesn’t.  With Docker, doubly so.21:43
sdake_docker doesns't solve world hunger ;)21:43
sdake_dmsimard on your point about more complexity, tell me how this is complex:21:43
sean-k-mooneyinc0: oh im not opposed to just just more of jinja2 i previously proposed using the macros for this https://review.openstack.org/#/c/275932/1/docker/openvswitch/openvswitch-base/Dockerfile.j221:43
patchbotsean-k-mooney: patch 275932 - kolla - [WIP] Support installing openvswitch from source (ABANDONED)21:43
sdake_https://review.openstack.org/#/c/321468/21:44
patchbotsdake_: patch 321468 - kolla - Implements elemental.yml DSL for base21:44
wirehead_Ergo, since we need multi-distro and the majority of other container infras aren’t needing it, we’re kinda stuck in Kolla-land writing our own tools.21:44
inc0sean-k-mooney, yeah, that'd fit nicely to my idea21:44
wirehead_I’m wondering if it’s eventually going to be simpler to not write a DSL that builds Dockerfiles but a new DSL that generates container images.21:45
sdake_dmsimard that link was for you ^^21:45
sdake_wirehead_ sounds like an optimization21:45
sdake_but my take would be no its not going to be simpler ;)21:46
*** ravig has joined #openstack-kolla21:46
wirehead_Heh.21:46
sean-k-mooneyinc0: i keep coming back to devstack but if we started to use more of jinja2 we could have "functions_common" with common macros21:47
*** ravig has quit IRC21:48
inc0yup21:48
inc0and easily add new ones21:48
inc0customized21:48
sean-k-mooneyinc0: e.g. install_package enable_repo ...21:48
inc0in fact there is install package macro in my review;)21:48
sean-k-mooneyyep i see that :)21:49
inc0this is only todays work, so more will come21:49
sean-k-mooneyout of interest and for contex why was the decision to only use if statements in jinja2 originally made?21:49
sean-k-mooneykeep docker files as close to raw docker as posible?21:50
*** fragatina has joined #openstack-kolla21:52
*** ravig has joined #openstack-kolla21:52
inc0sean-k-mooney, issue was "it's new language, operators doesn't know it"21:58
inc0let's keep it simple21:59
mark-caseywirehead_: what was the feedback from the Helm dev?21:59
sean-k-mooneyinc0: makes sense but im also sure docker was failly new to them too :)21:59
inc0sean-k-mooney, yeah, now we can move forward with advanced jinja22:00
sean-k-mooneyinc0: jinja2 is certenly a good options in my view. the only factor that i can see as appealing to a dsl is if we decople it for docker files entirely22:01
sean-k-mooneya dsl would allow building rkt containers for example if a parser for the dsl was written22:02
inc0yeah, but dockerfiles, simple as they are, doesn't limit you22:02
inc0dsl might if we fail to include something22:02
inc0which I'm sure we will22:03
sean-k-mooneyyeah, im not sure kolla is at a point where extending its contaiers to other container enginges is a need that must be addressed now22:03
sean-k-mooneyespically since you can execute docker images in rkt22:04
inc0open container format will solve that22:05
sean-k-mooneyyes that is true22:05
sean-k-mooneyin any case i look forward to seeing a spec on this topic22:06
*** ravig has quit IRC22:07
*** nilk has quit IRC22:09
*** sdake has joined #openstack-kolla22:10
*** sean-k-mooney has quit IRC22:12
*** sdake_ has quit IRC22:12
wirehead_mark-casey: I didn’t get any yet.22:16
wirehead_Like, with me as a proxy for Helm…  Helm doesn’t need to deal with building containers, but it does need to deal with orchestrating the deployment thereof, but only in the Kubernetes context.22:17
*** JoseMello has quit IRC22:19
wirehead_They had the same discussions that Kolla did with respect to startup order and went strictly towards the direction that software that requires complex bootstrapping is not going to fit into the world of Helm and that processes should detect if they are able to continue starting up and either wait-loop or crash-with-docker-restarting-it.22:19
wirehead_Helm does things on a more grandular level.  c.f. Nova would be a Chart and would be self-contained.22:20
*** pbourke-home has quit IRC22:21
*** vhosakot has quit IRC22:22
*** vhosakot has joined #openstack-kolla22:23
wirehead_The Kolla way of templating the Dockerfile is weird, but I honestly can’t see many alternatives given the unique set of constraints placed on Kolla.22:23
*** vhosakot has quit IRC22:29
*** ravig has joined #openstack-kolla22:33
*** ravig has quit IRC22:36
openstackgerritSteven Dake proposed openstack/kolla: Introduction of a new DSL: Elemental  https://review.openstack.org/32361222:37
sdakeinc0 there ya go22:37
inc0kk will read through it and we can discuss it on meeting tomorrow22:38
sdakeinstead of using the meeting time for that lets use thee mailing list pls22:44
sdakethat way there is a permanent record and people can think about what they are thinking :)22:44
sdakethinking/writing22:44
sdakeinc0 also i dind't make up the reuqirements out of thin air, they are legitimately what I htink we need as far as customization goes22:47
inc0sdake, ok, wfm22:48
inc0in fact right now I'm working on specifying your own sources list22:48
sdakemy own sources list?22:48
sdakedont grok22:49
inc0apt-get uses sources.list file22:49
inc0for repos22:49
inc0and that won't be trivial with dsl22:49
inc0as it's well...a file22:49
inc0https://github.com/openstack/kolla/blob/master/docker/base/sources.list22:49
sdakeit is trivial with a dsl22:49
sdakei implemented repo files and uris for centos22:49
sdakeif it can be done for centos it can be done for ubuntu22:49
inc0well, it's even more trivial with jinja;)22:50
sdakethe challenge for people's attention ;)22:50
sdakeyou can make uris and repo files work in one include in jinja2?22:51
inc0yup22:51
sdakei think if we take the approach you recommend to its extreme conclusion at present we would end up with 316 files on teh disk22:51
sdakeat minimum22:51
sdaketo customize everything22:51
inc0nope22:51
inc0in fact22:51
sdakeexpalin that to me because that is where i am at big odds with jinja222:52
inc0it will take at most as much files as we have containers22:52
inc0because we don't only do includes but also block syntax22:52
sdake11922:52
inc0well if you want to have one yaml per multiple containers, that will be ugly as fuck22:53
inc0I mean, still doable with jinja22:53
sdakei had it all in one file22:53
inc0but ugly as fuck22:53
sdakebut sbezverk wanted it per container22:53
inc0and he's right22:53
sdakeso I split the different and made it per container set22:53
sdakewhich is 3922:53
inc0bottom line, we can do whatever22:53
sdakebut my technique still allows full customization :)22:53
sdakeof all 119 containers22:54
sdakeso anyway back on topic22:54
sdakehow do you have a repo file for neutron and then for say neutron_lbaas_agent?22:54
inc0you want different base images for both?22:55
sdakedifferent repo file syes22:55
inc0since repo file is included in base you want different base image22:56
sdakeright22:56
sdakei want to override the base image22:56
inc0or change repo in fly which is ugly as...you know22:56
sdakeand throw out its repo files :)22:56
inc0just for one neutron container?22:56
sdakein my case, for the whole thing22:56
sdakei was using neutron as an example22:57
inc0ok, so you want custom sources.list right?22:57
sdakefor all 119 dockerfiles, I need custom repositories22:57
sdakethat is one of 12 things i want :)22:57
inc0hold on, example coming right up22:57
*** ravig has joined #openstack-kolla22:57
openstackgerritMichal Jastrzebski (inc0) proposed openstack/kolla: Refactor of base Dockerfile to allow custom repo  https://review.openstack.org/32358922:59
sdakeinc0 just to be clear ,for all of the 119 dockerfiles, I want *different* custom repositories22:59
inc0which means you want custom repo for base image22:59
sdakei want to build the world22:59
sdakenot build nova22:59
sdakebuild neutron22:59
sdakeetc22:59
sdakei dont want to rebuild the base each itme23:00
sdaketoo pokey23:00
inc0because thats where we setup repos23:00
sdakei recognize that23:00
sdakelets just assume we didn't do that23:00
sdakeor we did it, and what came later overrode what was already there23:00
inc0look at my example, this is how you can change repos for everything23:00
sdakeinc0 yes but I need it per dockerfile23:01
sdakenot global23:01
inc0ehh...you have neutron-base and nova-base with same repos or each with different?23:01
sdakeinc0 different repos23:02
sdakeexample - one is juno one is kilo23:02
sdakewe have real world use cases around this scenario and we are not alone23:03
openstackgerritMichal Jastrzebski (inc0) proposed openstack/kolla: Refactor of base Dockerfile to allow custom repo  https://review.openstack.org/32358923:03
sdakenow take that example out to the other stuff you want to customize23:03
inc0but in same deployment 2 containers will have different stuff in it?23:03
sdakethe binary packages installed23:03
sdakethe source packages installed23:03
sdakeinc0 neutron will have kilo nova will have liberty23:04
sdakeinc0 but I want to run build.py once23:04
inc0ok...you do that by tags...23:04
sdakeclearly I could hack the base dockerfile and rebuild each one indivdually23:04
sdakeyour solution is more complex then mine is ;)23:04
inc0no, you should have tags for mitaka and liberty and override ansible deploy23:05
sdakeexplain tags please23:05
inc0that's how you should do it23:05
inc0we do have vars in ansible for that23:05
sdakeyes i understand23:05
sdakethatis one approach23:05
sdakelisten, I can't give you the goddamn fucking examle that I want23:05
sdakebecause i am not permitted23:05
inc0that's only approach because we don't support mitaka code deploying liberty repos23:05
*** ravig has quit IRC23:05
sdakewhat I can do is give you examples that are "LIKE" the example I have23:06
inc0ok...23:06
sdakebut in essence, I need repo files per container23:06
sdakepick a reason out of thin air23:06
sdakeI did :)23:06
inc0still doable23:06
inc0you add block neutron-lbaas-pre-install23:06
sdakeso you will have 119 custom files for repos?23:07
inc0and then in your custom-dockerfile you change stuff there23:07
inc0no, just these you want to edit23:07
inc0and yes, we can scale it down to even one file23:07
inc0with lots of blocks in it23:07
inc0but I feel that would be horrible and we should have customization file per dockerfile23:07
sdake119 containers23:07
inc0either way works23:07
sdakedo the math :)23:07
inc0yes, I can do all the customization in single file if you want23:08
sdakei think when you get done with your dockerfile it will look more like a jinj2 file and not a dockerfile23:08
sdakeand it will still be DSL->DSL23:08
sdakebut not general purpose23:08
inc0with block neutron-lbaas-pre-install -> <<change repos here>> and then nova-compute-pre-install -> << change repo there >>23:08
sdakerather general purpose and not domain specific23:08
inc0well, your dsl will look like completely nothing around23:09
inc0I'd rather have it look like jinja2 based dockerfile23:09
sdakeoh well the spec process is started since once is submitted23:09
sdakecommunity can decide23:10
inc0true23:10
inc0that's how we should handle that23:10
inc0have a proper discussion and then make a call as community23:10
inc0we'll make it work sdake so don't worry, your day job won't get hurt23:11
sdakeduh23:11
sdakewhat I have already works for producing dockerfiles23:11
sdakemy day job is not in jeaporady23:11
inc0I'm saying we can do all of that without rearchitecturing whole thing23:11
sdakelike i said before, I'd strongly have preferred to have done a DSL upfront23:11
sdakebut I didn't think we could pull it off23:11
sdakedsl was discussed at our  first midcycle23:12
inc0and now we released stable23:12
inc0and we need to follow deprecation23:12
inc0we can't just throw away stuff now23:12
sdakei wasn't suggesting not following deprecation polices23:12
sdakebut dockerfiles are not somethign that are part of the deprecation process23:12
sdakeonly cli and config options are23:13
inc0well, that'd mean that your dsl would be our main way in O at its earliest23:13
inc0and I can give you working solution before N23:13
sdakei was thinking more like newton23:13
inc0no,23:13
sdakedockerfiles dont have any deprecation policy associated with them23:13
inc0deprecation means whatever used to work will work for 1 release23:13
sdakethat would be like saying "setup.py has a deprecation policy"23:13
sdakeinc0 yes user visible changes work the same23:14
inc0well, if you can make build.py with every possible option work, that would be sufficient for me23:14
sdakeall the jinja2 stuff is black magic the operator never sees23:14
inc0as for deprecation goes, I still don't like DSL23:14
inc0well, not true23:14
inc0people do change dockerfiles now23:14
sdakethat needs to stop23:14
sdakeor we are in a world of pain coming23:14
*** mark-casey has left #openstack-kolla23:15
inc0nah, I like that23:15
inc0if we allow them to make snowflakes without affecting trunk23:15
inc0it's on them23:15
inc0and they're happy with that23:15
wirehead_It should at the very least be a big black block in the docs.23:15
sdakewirehead_ which should be23:15
wirehead_People making snowflake dockerfiles.23:16
inc0well, if we make jinja2 extensible, we can make super detailed howto make kolla behave however you like23:16
sdakei had not thought of this include mechanism, it works sort of like how our /etc/kollaconfig directory works, but I have serious concerns about being able to implement it and have it work correctly23:18
*** rhallisey has joined #openstack-kolla23:18
sdakeas well as the raw number of custom files needed23:19
*** diogogmt has quit IRC23:19
*** pbourke-home has joined #openstack-kolla23:20
inc0pbourke-home, https://review.openstack.org/#/c/323589/ <- demo I promised you this morning23:21
patchbotinc0: patch 323589 - kolla - Refactor of base Dockerfile to allow custom repo23:21
*** pbourke-home has quit IRC23:22
*** vhosakot has joined #openstack-kolla23:37
*** vhosakot has quit IRC23:43
*** vhosakot has joined #openstack-kolla23:44
sdakeinc0 are you planning to have debain-dockerfile.j2 and ubuntu-dockerfile.j2 in every container directory?23:45
inc0havent decided yet, playing around23:46
*** vhosakot has quit IRC23:46
*** daneyon_ has joined #openstack-kolla23:46
prithivis it just me or anyone else facing issue with master branch23:47
prithivImportError: No module named plugins.action23:47
prithivin task TASK: [ceph | Copying over ceph.conf] *****************************************23:47
prithivthough i have enable_ceph: "no"23:47
sbezverkprithiv you need to update your ansible23:47
prithivi have 1.9.423:48
prithivrecommended in quickstart guide23:48
sbezverkI had similar issue with ansiblew 1.9.4 but with new 2.0.2 it works fine23:48
wirehead_prithiv: The quickstart guide hasn’t been updated.23:48
*** daneyon_ has quit IRC23:51
*** ravig has joined #openstack-kolla23:52
*** berendt has quit IRC23:54
wirehead_rhallisey: I’m digging into mariadb bootstrapping.  Is that just not ready yet?23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!