| *** mhen_ is now known as mhen | 01:12 | |
| opendevreview | OpenStack Proposal Bot proposed openstack/keystone master: Imported Translations from Zanata https://review.opendev.org/c/openstack/keystone/+/930663 | 03:01 |
|---|---|---|
| opendevreview | Antonia Gaete proposed openstack/keystone master: Add JSON Schema to `endpoints` and validation decorators to endpoints resource. https://review.opendev.org/c/openstack/keystone/+/927856 | 14:39 |
| cardoe | mnaser: https://github.com/Homebrew/homebrew-core/pull/192049 btw | 15:15 |
| opendevreview | Artem Goncharov proposed openstack/keystone master: Add JsonSchema to `credentials` https://review.opendev.org/c/openstack/keystone/+/923324 | 16:02 |
| opendevreview | Merged openstack/keystone master: Add JsonSchema validation framework https://review.opendev.org/c/openstack/keystone/+/923067 | 16:05 |
| opendevreview | Merged openstack/keystone master: Prevent circlular imports in keystone.api https://review.opendev.org/c/openstack/keystone/+/926351 | 16:05 |
| opendevreview | Merged openstack/keystoneauth master: typing: Make abstract method actually abstract https://review.opendev.org/c/openstack/keystoneauth/+/928807 | 16:17 |
| opendevreview | Merged openstack/keystoneauth master: typing: Synchronise overridden method signatures https://review.opendev.org/c/openstack/keystoneauth/+/928808 | 16:17 |
| opendevreview | Merged openstack/keystoneauth master: typing: Add variable for auth plugin opts https://review.opendev.org/c/openstack/keystoneauth/+/928809 | 16:21 |
| opendevreview | Merged openstack/keystoneauth master: typing: Resolve remaining initial issues https://review.opendev.org/c/openstack/keystoneauth/+/928810 | 16:21 |
| opendevreview | Merged openstack/keystoneauth master: Enable mypy https://review.opendev.org/c/openstack/keystoneauth/+/928811 | 16:34 |
| opendevreview | Merged openstack/keystoneauth master: discover: Expand use of kwargs https://review.opendev.org/c/openstack/keystoneauth/+/928812 | 16:34 |
| opendevreview | Merged openstack/keystoneauth master: discover: Rework normalization https://review.opendev.org/c/openstack/keystoneauth/+/928813 | 16:34 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.discover https://review.opendev.org/c/openstack/keystoneauth/+/928814 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.plugin https://review.opendev.org/c/openstack/keystoneauth/+/930762 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.session https://review.opendev.org/c/openstack/keystoneauth/+/930763 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: trivial: Consistent f prefixes https://review.opendev.org/c/openstack/keystoneauth/+/930764 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.adapter https://review.opendev.org/c/openstack/keystoneauth/+/930765 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1._fair_semaphore https://review.opendev.org/c/openstack/keystoneauth/+/930766 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate various plugin modules https://review.opendev.org/c/openstack/keystoneauth/+/930767 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1._utils https://review.opendev.org/c/openstack/keystoneauth/+/930768 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.exceptions https://review.opendev.org/c/openstack/keystoneauth/+/930769 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.access.service_catalog https://review.opendev.org/c/openstack/keystoneauth/+/930770 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.access.service_providers https://review.opendev.org/c/openstack/keystoneauth/+/930771 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: access: Add more helper attributes to AccessInfoV3 https://review.opendev.org/c/openstack/keystoneauth/+/930772 | 18:05 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: access: Remove use of _missingproperty wrapper https://review.opendev.org/c/openstack/keystoneauth/+/930773 | 18:06 |
| opendevreview | Stephen Finucane proposed openstack/keystoneauth master: typing: Annotate keystoneauth1.access.access https://review.opendev.org/c/openstack/keystoneauth/+/930774 | 18:06 |
| cardoe | gtema: so I wanna come back to some of those OIDC docs patches. I've abandoned the old ones and I'm starting new. I've got https://review.opendev.org/c/openstack/keystone/+/929315 as the first one. This is something that has bitten me 4 years ago when I first messed with federation. And it's bitten me again cause I forgot exactly what was up. | 18:36 |
| cardoe | I understand at the PTG there's a plan to change the federation logic. I heard something similar previously when I tried to make docs and example changes. | 18:36 |
| cardoe | I really care about having the docs today reflect what the code does today (and frankly for the past 4 years). | 18:36 |
| JayF | I wonder if keystone has a policy around doc backporting | 18:37 |
| cardoe | I'm happy to improve the docs when the behavior changes. | 18:37 |
| JayF | if you did this in Ironic we'd probably backport it on request to fix up the old docs too | 18:37 |
| cardoe | But I think it's a detriment to welcoming new users and people to have the documentation be wrong. | 18:37 |
| cardoe | Already 2 others in the channel have spoken up about how they've had to do stuff outside of the upstream tree to work around it. | 18:38 |
| cardoe | So clearly there's a user demand for this to function. How many users tried with just the docs and failed and just gave up and said OpenStack sucks and walked away if there were at least 2 that went and made out of tree patches and modules? | 18:39 |
| gtema | cardoe, my "issue" with your doc change is that there many installations deployed and working without changes you describe. It is always an issue on how you set up in general and eventually deployment tool you use while the doc is in basics correct (it worked for me perfectly fine few times already) | 18:53 |
| gtema | My intention is to make it all working out of box and reduce amount of possible bombs without changing document with what worked for you but will break others | 18:55 |
| cardoe | So this one change I've proposed literally does nothing except explain what the settings are. There's only TWO "breaking" changes about my wording. | 19:07 |
| cardoe | 1) The part that says X is Y in the OpenID Connect spec. Well it literally uses a name for something that doesn't exist in the spec at all. So I fixed it to use the correct thing from the spec. | 19:07 |
| JayF | It'd be nice to have some of this chatter about the PR contents in gerrit | 19:08 |
| JayF | so it's not limited to folks awake/watching IRC | 19:08 |
| cardoe | 2) the docs (and the code require) that list fields in the token be transmitted in a string-ified header with the separator being a ; except the example in the docs tells mod_auth_oidc to use a comma. So it literally fails. | 19:09 |
| cardoe | Good point JayF. I'm happy to expand in my commit messages. | 19:13 |
| d34dh0r53 | Thanks cardoe | 19:22 |
| cardoe | d34dh0r53: I just wanna help. And just trying to figure out how to best do that. | 19:28 |
| cardoe | It just bubbled up again to me today because someone was asking about OIDC internally. | 19:39 |
| opendevreview | Antonia Gaete proposed openstack/keystone master: Add JSON Schema to `endpoints` and validation decorators to endpoints resource. https://review.opendev.org/c/openstack/keystone/+/927856 | 20:42 |
| opendevreview | Antonia Gaete proposed openstack/keystone master: Add JSON Schema to `endpoint groups` and validation decorators to endpoint groups resource. https://review.opendev.org/c/openstack/keystone/+/929686 | 20:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!