*** mhen_ is now known as mhen | 01:23 | |
*** sfinucan is now known as stephenfin | 09:01 | |
opendevreview | Markus Hentsch proposed openstack/keystone master: Implement the Domain Manager Persona for Keystone https://review.opendev.org/c/openstack/keystone/+/924132 | 09:19 |
---|---|---|
opendevreview | Dmitriy Rabotyagov proposed openstack/keystone master: Fix implied roles in the application credentials https://review.opendev.org/c/openstack/keystone/+/910337 | 13:14 |
opendevreview | Dmitriy Rabotyagov proposed openstack/keystone master: Add a release note to cover fix of implied role for application credentials https://review.opendev.org/c/openstack/keystone/+/924150 | 13:14 |
gtema | thanks noonedeadpunk, I just today realized rn was missing since we were unsure which way to go | 13:15 |
noonedeadpunk | I've added it in a follow-up though, and rebased the change | 13:16 |
noonedeadpunk | (rebase was more accidental, but it didn't reset votes, so it's fine I guess :D) | 13:16 |
noonedeadpunk | I _hope_ that reno in a follow-up will be fine for the team | 13:16 |
noonedeadpunk | as change is nicely voted, don't wanna reset votes... | 13:17 |
gtema | yupp, I would update the text since it is not very precise. We were discussing quite long and agreed that AppCreds are designed to be immutable. That means more correct statement is "respect implied/inherited roles during creation of Application Credentials" | 13:17 |
noonedeadpunk | yeah, true | 13:18 |
gtema | existing AppCreds are not modified since this is against their design | 13:18 |
noonedeadpunk | give a sec and will update it | 13:18 |
gtema | perfect, thks | 13:18 |
opendevreview | Dmitriy Rabotyagov proposed openstack/keystone master: Add a release note to cover fix of implied role for application credentials https://review.opendev.org/c/openstack/keystone/+/924150 | 13:19 |
noonedeadpunk | looks better now? | 13:19 |
gtema | perfect, thanks | 13:20 |
noonedeadpunk | d34dh0r53: would be nice if you could check for this once around, and if we can set +w for the change :) | 13:20 |
gtema | Dave is in PTO this week | 13:20 |
gtema | maybe we can ask dmendiza / Grzegorz Grasza to push +w | 13:22 |
opendevreview | Jens Harbott proposed openstack/keystone master: Only log a small debug message for NotFound https://review.opendev.org/c/openstack/keystone/+/924153 | 13:45 |
frickler | kevko: ^^ iirc you mentioned this some time ago, and I've been annoyed by it for even longer. not sure though if treating all notfounds the same is good or whether it should only be done for some, user, domain, project, role? | 13:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!