Friday, 2023-12-08

*** mhen_ is now known as mhen02:17
opendevreviewMarkus Hentsch proposed openstack/keystone-specs master: Add identity spec for domain-manager role  https://review.opendev.org/c/openstack/keystone-specs/+/90317213:18
mhenhi :) is there a reviewathon today?14:04
bbobrovsome time ago https://review.opendev.org/c/openstack/keystone/+/834181 was merged. It exposed a big issue: keystone does not properly catch a lot of exceptions16:56
bbobrovtake a look at the tempest run: https://ed33be9e77348e089777-ffccc72cd1a336bccef8b981ce42be9d.ssl.cf2.rackcdn.com/902705/5/check/tempest-full-py3/66ebb81/controller/logs/index.html16:56
bbobrov(just a run from a change)16:57
bbobrovopen screen-keystone.txt there to see the logs and search for "keystone.server.flask.application"16:58
bbobrovevery minor error and gets the whole traceback - for RoleNotFound, DomainNotFound, Conflict - all of them16:59
bbobrovand they are logged with the loudest level - ERROR.17:02
bbobrovit does not even take an error for the messages to appear: all you have to do is say `openstack domain get <domain name>` - it tries to fetch /v3/domains/<domain name> first17:04
bbobrovwhat would be the best way to fix this? Catch every exception? Or revert the change mentioned in the first message?17:15
fricklerbbobrov: I've been annoyd by this for some time, too. likely it would be best to create a bug report and discuss possible solutions there. IMHO even logging a Warning for ItemNotFound situations is too much, so I would go even further than just reverting17:18
bbobrovhttps://bugs.launchpad.net/keystone/+bug/204599518:01
opendevreviewDouglas Mendizábal proposed openstack/keystone master: Consistent and Secure RBAC (Phase 1)  https://review.opendev.org/c/openstack/keystone/+/90273018:32

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!