*** mhen_ is now known as mhen | 02:17 | |
opendevreview | Markus Hentsch proposed openstack/keystone-specs master: Add identity spec for domain-manager role https://review.opendev.org/c/openstack/keystone-specs/+/903172 | 13:18 |
---|---|---|
mhen | hi :) is there a reviewathon today? | 14:04 |
bbobrov | some time ago https://review.opendev.org/c/openstack/keystone/+/834181 was merged. It exposed a big issue: keystone does not properly catch a lot of exceptions | 16:56 |
bbobrov | take a look at the tempest run: https://ed33be9e77348e089777-ffccc72cd1a336bccef8b981ce42be9d.ssl.cf2.rackcdn.com/902705/5/check/tempest-full-py3/66ebb81/controller/logs/index.html | 16:56 |
bbobrov | (just a run from a change) | 16:57 |
bbobrov | open screen-keystone.txt there to see the logs and search for "keystone.server.flask.application" | 16:58 |
bbobrov | every minor error and gets the whole traceback - for RoleNotFound, DomainNotFound, Conflict - all of them | 16:59 |
bbobrov | and they are logged with the loudest level - ERROR. | 17:02 |
bbobrov | it does not even take an error for the messages to appear: all you have to do is say `openstack domain get <domain name>` - it tries to fetch /v3/domains/<domain name> first | 17:04 |
bbobrov | what would be the best way to fix this? Catch every exception? Or revert the change mentioned in the first message? | 17:15 |
frickler | bbobrov: I've been annoyd by this for some time, too. likely it would be best to create a bug report and discuss possible solutions there. IMHO even logging a Warning for ItemNotFound situations is too much, so I would go even further than just reverting | 17:18 |
bbobrov | https://bugs.launchpad.net/keystone/+bug/2045995 | 18:01 |
opendevreview | Douglas Mendizábal proposed openstack/keystone master: Consistent and Secure RBAC (Phase 1) https://review.opendev.org/c/openstack/keystone/+/902730 | 18:32 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!