| *** gyee has quit IRC | 00:23 | |
| *** markvoelker has joined #openstack-keystone | 00:29 | |
| *** markvoelker has quit IRC | 01:02 | |
| *** jamesmcarthur has joined #openstack-keystone | 01:14 | |
| *** jamesmcarthur has quit IRC | 01:18 | |
| *** markvoelker has joined #openstack-keystone | 01:59 | |
| *** jamesmcarthur has joined #openstack-keystone | 02:29 | |
| *** markvoelker has quit IRC | 02:32 | |
| *** threestrands has joined #openstack-keystone | 02:54 | |
| *** jamesmcarthur has quit IRC | 02:58 | |
| *** whoami-rajat has joined #openstack-keystone | 03:10 | |
| *** shyamb has joined #openstack-keystone | 03:51 | |
| *** threestrands has quit IRC | 04:12 | |
| *** lbragstad has quit IRC | 04:20 | |
| *** markvoelker has joined #openstack-keystone | 04:30 | |
| *** shyamb has quit IRC | 04:57 | |
| *** shyam89 has joined #openstack-keystone | 04:57 | |
| *** markvoelker has quit IRC | 05:03 | |
| *** shyam89 has quit IRC | 05:08 | |
| *** shyamb has joined #openstack-keystone | 05:18 | |
| *** shyamb has quit IRC | 05:37 | |
| cmurphy | it passes, please review ^ | 05:43 |
|---|---|---|
| *** shyamb has joined #openstack-keystone | 05:48 | |
| *** markvoelker has joined #openstack-keystone | 06:00 | |
| *** hoonetorg has quit IRC | 06:21 | |
| *** markvoelker has quit IRC | 06:32 | |
| *** itlinux_ has joined #openstack-keystone | 06:34 | |
| *** itlinux has quit IRC | 06:34 | |
| *** pcaruana has joined #openstack-keystone | 06:35 | |
| *** hoonetorg has joined #openstack-keystone | 06:38 | |
| *** itlinux_ has quit IRC | 06:54 | |
| *** itlinux has joined #openstack-keystone | 06:59 | |
| *** itlinux has quit IRC | 07:05 | |
| *** mvkr has joined #openstack-keystone | 07:09 | |
| *** tesseract has joined #openstack-keystone | 07:09 | |
| *** itlinux has joined #openstack-keystone | 07:12 | |
| *** imacdonn has quit IRC | 07:16 | |
| *** markvoelker has joined #openstack-keystone | 07:30 | |
| *** shyamb has quit IRC | 07:30 | |
| *** jaosorior has joined #openstack-keystone | 07:51 | |
| *** xek has joined #openstack-keystone | 07:51 | |
| *** Emine has joined #openstack-keystone | 07:52 | |
| *** rcernin has quit IRC | 07:55 | |
| *** shyamb has joined #openstack-keystone | 07:57 | |
| *** markvoelker has quit IRC | 08:03 | |
| *** trident has quit IRC | 08:35 | |
| *** trident has joined #openstack-keystone | 08:37 | |
| *** imacdonn has joined #openstack-keystone | 08:37 | |
| *** emine__ has joined #openstack-keystone | 08:51 | |
| *** Emine has quit IRC | 08:52 | |
| *** markvoelker has joined #openstack-keystone | 09:00 | |
| *** jaosorior has quit IRC | 09:30 | |
| *** markvoelker has quit IRC | 09:32 | |
| *** tkajinam has quit IRC | 09:37 | |
| *** jaosorior has joined #openstack-keystone | 09:47 | |
| *** jaosorior has quit IRC | 10:13 | |
| *** shyamb has quit IRC | 10:25 | |
| *** shyam89 has joined #openstack-keystone | 10:25 | |
| *** jaosorior has joined #openstack-keystone | 11:07 | |
| *** xek has quit IRC | 11:29 | |
| *** markvoelker has joined #openstack-keystone | 11:30 | |
| *** shyam89 has quit IRC | 11:47 | |
| *** shyamb has joined #openstack-keystone | 11:48 | |
| *** xek has joined #openstack-keystone | 11:53 | |
| *** markvoelker has quit IRC | 12:03 | |
| *** dtruong has quit IRC | 12:27 | |
| *** dtruong has joined #openstack-keystone | 12:27 | |
| *** aloga has quit IRC | 12:27 | |
| *** aloga has joined #openstack-keystone | 12:28 | |
| *** dansmith has quit IRC | 12:29 | |
| *** dansmith has joined #openstack-keystone | 12:32 | |
| *** shyamb has quit IRC | 12:48 | |
| *** markvoelker has joined #openstack-keystone | 12:49 | |
| *** lbragstad has joined #openstack-keystone | 13:03 | |
| *** mvkr has quit IRC | 13:09 | |
| *** lbragstad_ has joined #openstack-keystone | 13:26 | |
| *** lbragstad has quit IRC | 13:27 | |
| *** jamesmcarthur has joined #openstack-keystone | 13:32 | |
| *** lbragstad_ is now known as lbragstad | 13:38 | |
| *** notq has joined #openstack-keystone | 13:55 | |
| cmurphy | lbragstad: knikolla gagehugo can i get another review on https://review.opendev.org/663373 to unbreak the gate? | 14:39 |
| knikolla | cmurphy: pushed | 14:40 |
| cmurphy | tyvm | 14:40 |
| *** itlinux has quit IRC | 14:46 | |
| *** itlinux has joined #openstack-keystone | 14:47 | |
| *** itlinux has quit IRC | 14:52 | |
| *** itlinux has joined #openstack-keystone | 14:59 | |
| *** jc_ has joined #openstack-keystone | 15:00 | |
| kmalloc | o/ | 15:01 |
| kmalloc | i couldn't review it in depth from a phone | 15:01 |
| kmalloc | so i didn't want to single-core it | 15:01 |
| kmalloc | knikolla: thanks for following up on it | 15:02 |
| *** ksavich has joined #openstack-keystone | 15:02 | |
| kmalloc | mnaser: how much battery life are you getting on your x1extreme? | 15:16 |
| kmalloc | mnaser: because that might be the tipping point for me back to the X1C | 15:16 |
| *** jc_ has quit IRC | 15:20 | |
| *** bnemec is now known as beekneemech | 15:29 | |
| mnaser | kmalloc: to be honest, I got 2.5 hours yesterday out of it doing some shell / browser work | 15:35 |
| mnaser | Nothing intense | 15:35 |
| mnaser | But that's with zero tweaking anything | 15:35 |
| kmalloc | mnaser: that is pretty low, apparantly there is an issue with the GPU on them (in general) that burns battery unless you do some wonky stuff | 15:36 |
| kmalloc | in windows* | 15:36 |
| kmalloc | I'm getting ~6hrs on a "dying" battery on my X1C6 | 15:37 |
| kmalloc | i used to get 12+ hrs | 15:37 |
| kmalloc | mnaser: just issues with gpu not sleeping/swapping correctly. I think i'll go X1C again. the added ram would be great. | 15:38 |
| *** cmurphy is now known as cmorpheus | 15:38 | |
| kmalloc | but i often work without power nearby | 15:38 |
| * kmalloc feels weird being on the east coast timezone wise. | 15:38 | |
| mnaser | kmalloc: yeah I rarely need it for that long. I feel that probably has to do with the fact it has a full on graphics card | 15:39 |
| kmalloc | mnaser: yep, in windows you can remove the device and re-add it and push 10hrs (up from 5). but tuning from 2.5 hrs up on linux means probably wont get evne close to 10hrs with changes | 15:40 |
| kmalloc | that's fine, brie will be happy i am spending closer to $2k rather than $3k for a laptop. | 15:40 |
| mnaser | kmalloc: yeah I hear that id a common things. In windows it's much more different I'm sure. I can't imagine optimizing that much | 15:40 |
| clarkb | I'm having a hard time giving up my x240 because I can replace the battery in it trivially and still get > 8hours of battery life total after ~5 years of service | 15:41 |
| clarkb | but consumers apparently don't like those features and need a backup butter knife instead :) | 15:42 |
| kmalloc | clarkb: i'm going to get the sealed battery warranty on the next one. it costs like $20 for 5 years. if the laptop lasts me 5 years, i'm stoked | 15:42 |
| kmalloc | clarkb: if i do x1c | 15:42 |
| * lbragstad hopes to make his x1c last 3 years | 15:43 | |
| cmorpheus | i think i've had my 3rd gen at least that long | 15:43 |
| lbragstad | you've had a pretty rock solid machine cmorpheus | 15:44 |
| lbragstad | you haven't had any issues have you? | 15:44 |
| cmorpheus | a few weeks ago it had some kind of hardware malfunction and wouldn't boot past the bios at all | 15:45 |
| cmorpheus | but that went away | 15:45 |
| cmorpheus | but it is making me realize this thing is pretty old | 15:45 |
| lbragstad | mmm | 15:46 |
| kmalloc | i had a lemon of a x1c3 but lenovo just kept repairing it under warranty. they should have replace it | 15:49 |
| *** markvoelker has quit IRC | 15:49 | |
| kmalloc | this one has been ok, but the low screen res and some other stuff (noably the battery being drained to zero over and over) has made the battery less happy. things I learned about tuning this hardware *after* the battery was already unhappy with me | 15:49 |
| kmalloc | so my thought is new x1c6 setup the way I want and tune for power savings when sleeping out the gate. | 15:50 |
| kmalloc | should make the battery last a lot longer | 15:50 |
| *** gyee has joined #openstack-keystone | 15:51 | |
| *** lbragstad is now known as lbragstad_runnin | 16:06 | |
| *** xek has quit IRC | 16:11 | |
| gagehugo | kmalloc: I'm waiting to see what the x1c7 looks like | 16:16 |
| kmalloc | gagehugo: seeing as the x1c7 is coming out... like next week or so | 16:17 |
| kmalloc | i think i am waiting too | 16:17 |
| *** emine__ has quit IRC | 16:19 | |
| cmorpheus | ugh guys stop, i have too many computers already /o\ | 16:20 |
| gagehugo | next week would be nice | 16:22 |
| gagehugo | e3 is next week too | 16:22 |
| kmalloc | cmorpheus: BUY MOAR | 16:25 |
| *** tesseract has quit IRC | 16:40 | |
| *** jaosorior has quit IRC | 16:42 | |
| *** ksavich has quit IRC | 16:44 | |
| notq | cmorpherus: https://bugs.launchpad.net/keystone/+bug/1831918 added comment | 16:44 |
| openstack | Launchpad bug 1831918 in OpenStack Identity (keystone) "ec2 credentials do not create audit notifications" [Undecided,Incomplete] | 16:44 |
| *** markvoelker has joined #openstack-keystone | 16:50 | |
| cmorpheus | thanks notq | 16:52 |
| *** lbragstad_runnin is now known as lbragstad | 16:53 | |
| notq | thank you for finding details, i spent way too much of yesterday trying to sort out what you seemed to do quite quickly :) | 16:56 |
| cmorpheus | i've been working on this code for too long @.@ | 16:57 |
| notq | What I don't understand is it works for credential, and not ec2 credential. So I tried to sort out how it was working for credential, and I couldn't see that, or understand the differences between them | 16:57 |
| notq | for example, if the proper code is added to the first place, does credential then send 2? or are they using different forms? | 16:59 |
| cmorpheus | hmm i'm not sure why credential would work but ec2 would not | 17:00 |
| notq | yeah, that's where i was totally stuck. I couldn't find how credential did them. Unless I have a bad assumption and credential doesn't work, but I mean, clearly it does cause I've seen them. Let me load a massive region and look at all keystone notifications | 17:01 |
| notq | i have, authenticate (failures), create/delete user, create/delete application credential, create/delete role assignment, create project (we don't do deletes) | 17:10 |
| notq | and create domain, create/delete service, create endpoint, create OS-OAUTH1:consumer, create OS-OAUTH1:request_token , | 17:15 |
| notq | and that's it for the last 3 months in a region | 17:15 |
| notq | is that helopful cmorpheus? | 17:16 |
| cmorpheus | notq: hmm possibly there's a terminology issue, we have "application credential" which should be doing notifications correctly, and just "credential" which is what ec2/s3 credentials are based on which is where i don't see notifications happening | 17:23 |
| notq | Ah, then that's what I misunderstood. I thought credential was doing more. My mistake, and clears up so much. | 17:23 |
| cmorpheus | we're great at naming things >.> | 17:24 |
| notq | Then your comment matches perfectly what needs to be done. | 17:24 |
| *** markvoelker has quit IRC | 17:25 | |
| cmorpheus | great :D | 17:25 |
| openstackgerrit | Merged openstack/keystoneauth master: add a handler for unknown HTTP errors https://review.opendev.org/663132 | 17:27 |
| notq | add import notifications, credential[id] seems to hit, initiator doesn't. sorting | 17:29 |
| notq | changes the function signature | 17:30 |
| notq | with an initiator=none | 17:30 |
| notq | there's no delete in credential/core ? | 17:32 |
| cmorpheus | notq: if it doesn't exist it's because it automagically calls the delete in the driver (keystone/credentials/backends/sql.py), best to add the delete function to the manager in core.py so the notification can happen from there | 17:34 |
| *** jamesmcarthur has quit IRC | 17:54 | |
| openstackgerrit | Merged openstack/keystone master: Exclude constants from autodoc https://review.opendev.org/663373 | 18:15 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add user_id, external_id to access rules table https://review.opendev.org/663440 | 18:20 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add manager support for app cred access rules https://review.opendev.org/663462 | 18:20 |
| *** markvoelker has joined #openstack-keystone | 18:22 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Ignore boilerplate constants in autodoc https://review.opendev.org/664029 | 18:37 |
| *** raildo has joined #openstack-keystone | 18:43 | |
| *** markvoelker has quit IRC | 18:55 | |
| *** emine__ has joined #openstack-keystone | 19:28 | |
| notq | cmorpheus: added the notification code to create in my branch, added the notes to the bug from you so they aren't lost, thanks. Not sure what to do after the delete method is added, it will need to be called as well instead. Perhaps on Monday I can look more into it. | 19:34 |
| cmorpheus | notq: it will automatically be called, no need to worry about adding a new call | 19:37 |
| notq | really? huh.. | 19:37 |
| cmorpheus | yeah there is some unintuitive magic that links up the manager and the driver, so the controller calls delete_credential and it will either go to the manager or the driver depending on whether the manager has that method | 19:38 |
| notq | oh, so then i just move them. this is much more simple than i thought | 19:39 |
| notq | in app credentials, delete_credentials_for_project and for user have underscores in front of them. not in the driver, should they? Not sure what that's signifying in python, i'm guessing the ability to call outside of the package? | 19:42 |
| cmorpheus | notq: it's supposed to indicate that it's a private method and not intended to be called from outside the class | 19:44 |
| notq | so i assume those should have underscores and don't, got it | 19:45 |
| cmorpheus | not necessarily | 19:46 |
| notq | hrm | 19:47 |
| cmorpheus | i don't think you should need to change any method names | 19:48 |
| notq | fair. there are some changes still required as the methods are referencing parts still in the driver code. | 19:49 |
| notq | maybe i don't need to move the other methods, jsut the delete | 19:49 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add user_id, external_id to access rules table https://review.opendev.org/663440 | 19:51 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add manager support for app cred access rules https://review.opendev.org/663462 | 19:51 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone master: Add API changes for app cred access rules https://review.opendev.org/628168 | 19:51 |
| notq | https://github.com/sapcc/keystone/pull/4 look remotely sane? | 19:51 |
| *** markvoelker has joined #openstack-keystone | 19:52 | |
| cmorpheus | notq: almost, you don't need to move any methods, you just need to add the new one to core.py - take the example here https://opendev.org/openstack/keystone/src/branch/master/keystone/application_credential/core.py#L181 https://opendev.org/openstack/keystone/src/branch/master/keystone/application_credential/backends/sql.py#L184 | 19:54 |
| notq | oic | 19:55 |
| *** emine has joined #openstack-keystone | 19:56 | |
| cmorpheus | also, we don't use github pull requests - check out https://docs.openstack.org/contributors/common/setup-gerrit.html when you're ready to submit the change | 19:57 |
| *** emine__ has quit IRC | 19:59 | |
| notq | yes, I'm doing it against our version first, then I will walk through the process as a change. https://github.com/sapcc/keystone/pull/4 better now? | 20:00 |
| notq | I haven't done an actual openstack change in 2 years that someone hasn't just done for me, so I'll just walk through it once it's set. | 20:01 |
| *** emine has quit IRC | 20:04 | |
| *** emine has joined #openstack-keystone | 20:05 | |
| *** raildo has quit IRC | 20:06 | |
| *** jamesmcarthur has joined #openstack-keystone | 20:07 | |
| *** emine__ has joined #openstack-keystone | 20:11 | |
| *** jamesmcarthur has quit IRC | 20:12 | |
| *** emine has quit IRC | 20:13 | |
| cmorpheus | notq: that one looks good, you'll need to fix the docstring though | 20:14 |
| notq | oops, k. having issues getting git review to ssh properly, working through it | 20:14 |
| *** emine has joined #openstack-keystone | 20:15 | |
| *** emine__ has quit IRC | 20:16 | |
| *** markvoelker has quit IRC | 20:20 | |
| *** emine has quit IRC | 20:53 | |
| *** jdwidari has joined #openstack-keystone | 21:12 | |
| *** markvoelker has joined #openstack-keystone | 21:16 | |
| *** markvoelker has quit IRC | 21:21 | |
| *** whoami-rajat has quit IRC | 21:34 | |
| *** pcaruana has quit IRC | 21:51 | |
| *** notq has quit IRC | 22:17 | |
| *** gyee has quit IRC | 23:12 | |
| *** markvoelker has joined #openstack-keystone | 23:17 | |
| kmalloc | cmorpheus: I'll likely miss the retro | 23:28 |
| kmalloc | I think I am on a plane at that time. Will see if I can wifi it up while flying. | 23:29 |
| *** hoonetorg has quit IRC | 23:35 | |
| *** markvoelker has quit IRC | 23:38 | |
| cmorpheus | kmalloc: :( okay | 23:46 |
| *** hoonetorg has joined #openstack-keystone | 23:49 | |
| *** lbragstad has quit IRC | 23:53 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!