*** rcernin has quit IRC | 00:18 | |
*** rcernin has joined #openstack-keystone | 00:19 | |
kmalloc | adriant: the spec i linked is really just for the Resource options. | 00:19 |
---|---|---|
kmalloc | adriant: the bug RFE should be where additional comments are made | 00:20 |
*** markvoelker has quit IRC | 00:20 | |
*** aojea has quit IRC | 00:31 | |
*** dklyle has quit IRC | 00:32 | |
adriant | kmalloc: that's what I was planning :) | 00:36 |
adriant | ah, it's a bug not a blueprint, missed that | 00:37 |
openstackgerrit | Sergey Vilgelm proposed openstack/keystone master: Fix list projects for federated user https://review.openstack.org/632565 | 00:41 |
lbragstad | adriant nice job on the mfa docs btw | 00:41 |
adriant | lbragstad: thanks! And I saw your notes for followup | 00:42 |
*** dklyle has joined #openstack-keystone | 00:48 | |
*** whoami-rajat has joined #openstack-keystone | 01:06 | |
*** gyee has quit IRC | 01:10 | |
*** dklyle has quit IRC | 01:10 | |
*** awalende has joined #openstack-keystone | 01:15 | |
*** awalende has quit IRC | 01:19 | |
adriant | hah, kmalloc, yes, your spec already included a point about per project auth rule requirements | 01:24 |
* adriant tips hat | 01:24 | |
adriant | I'll throw up a source_ip (or whatever name we decide on) auth-method spec, and I guess we should think about how we could do auto-promotion of auth methods. | 01:27 |
adriant | but really I need to find time to sit down and just make keystoneauth work with auth-receipts and multiple methods. | 01:28 |
*** aojea has joined #openstack-keystone | 01:41 | |
*** aojea has quit IRC | 01:45 | |
*** ileixe has joined #openstack-keystone | 01:51 | |
*** lbragstad has quit IRC | 01:52 | |
*** markvoelker has joined #openstack-keystone | 02:25 | |
*** lbragstad has joined #openstack-keystone | 02:35 | |
*** ChanServ sets mode: +o lbragstad | 02:35 | |
*** Dinesh_Bhor has joined #openstack-keystone | 02:40 | |
openstackgerrit | Merged openstack/pycadf master: Add release note for MD5 hash removal https://review.openstack.org/633037 | 02:52 |
*** markvoelker has quit IRC | 02:55 | |
*** whoami-rajat has quit IRC | 03:15 | |
*** dklyle has joined #openstack-keystone | 03:40 | |
*** erus_ has joined #openstack-keystone | 03:44 | |
*** whoami-rajat has joined #openstack-keystone | 03:45 | |
*** itlinux has joined #openstack-keystone | 03:47 | |
*** markvoelker has joined #openstack-keystone | 03:52 | |
*** dklyle has quit IRC | 04:02 | |
*** markvoelker has quit IRC | 04:25 | |
*** ileixe has quit IRC | 04:26 | |
*** shyamb has joined #openstack-keystone | 04:38 | |
*** imacdonn has joined #openstack-keystone | 04:57 | |
openstackgerrit | Merged openstack/keystone master: Add documentation for Auth Receipts and MFA https://review.openstack.org/580535 | 05:04 |
*** shyamb has quit IRC | 05:07 | |
*** shyamb has joined #openstack-keystone | 05:07 | |
*** ileixe has joined #openstack-keystone | 05:08 | |
*** erus_ has quit IRC | 05:11 | |
*** shyamb has quit IRC | 05:12 | |
*** shyamb has joined #openstack-keystone | 05:13 | |
*** markvoelker has joined #openstack-keystone | 05:22 | |
*** shyamb has quit IRC | 05:32 | |
*** shyamb has joined #openstack-keystone | 05:32 | |
*** vishakha has joined #openstack-keystone | 05:40 | |
*** spsurya has joined #openstack-keystone | 05:40 | |
*** markvoelker has quit IRC | 05:54 | |
*** shyamb has quit IRC | 05:55 | |
*** shyamb has joined #openstack-keystone | 05:56 | |
*** shyamb has quit IRC | 06:17 | |
*** shyamb has joined #openstack-keystone | 06:21 | |
*** shyamb has quit IRC | 06:34 | |
*** shyamb has joined #openstack-keystone | 06:35 | |
*** shyam89 has joined #openstack-keystone | 06:38 | |
*** shyamb has quit IRC | 06:41 | |
*** shyam89 has quit IRC | 06:42 | |
*** shyamb has joined #openstack-keystone | 06:43 | |
*** shyam89 has joined #openstack-keystone | 06:48 | |
*** shyamb has quit IRC | 06:49 | |
*** lbragstad has quit IRC | 07:45 | |
*** shyam89 has quit IRC | 07:48 | |
*** shyam89 has joined #openstack-keystone | 07:48 | |
*** markvoelker has joined #openstack-keystone | 07:52 | |
*** awalende has joined #openstack-keystone | 08:07 | |
*** tkajinam has quit IRC | 08:15 | |
*** shyam89 has quit IRC | 08:20 | |
*** yan0s has joined #openstack-keystone | 08:23 | |
*** markvoelker has quit IRC | 08:25 | |
*** dklyle has joined #openstack-keystone | 08:50 | |
*** shyamb has joined #openstack-keystone | 08:59 | |
*** shyamb has quit IRC | 09:16 | |
*** shyamb has joined #openstack-keystone | 09:16 | |
*** shyamb has quit IRC | 09:20 | |
*** shyamb has joined #openstack-keystone | 09:20 | |
*** markvoelker has joined #openstack-keystone | 09:22 | |
*** aojea has joined #openstack-keystone | 09:49 | |
*** aojea has quit IRC | 09:54 | |
*** markvoelker has quit IRC | 09:55 | |
*** shyamb has quit IRC | 10:08 | |
*** Dinesh_Bhor has quit IRC | 10:19 | |
*** shyamb has joined #openstack-keystone | 10:21 | |
*** shyamb has quit IRC | 10:28 | |
*** shyamb has joined #openstack-keystone | 10:31 | |
*** shyamb has quit IRC | 10:36 | |
*** markvoelker has joined #openstack-keystone | 10:52 | |
*** shyamb has joined #openstack-keystone | 10:55 | |
*** jaosorior has quit IRC | 11:07 | |
*** ileixe has quit IRC | 11:19 | |
*** shyam89 has joined #openstack-keystone | 11:23 | |
*** markvoelker has quit IRC | 11:25 | |
*** shyamb has quit IRC | 11:26 | |
*** shyam89 has quit IRC | 11:34 | |
openstackgerrit | Merged openstack/keystone-specs master: Update inaccurate details in JWS specification https://review.openstack.org/631887 | 11:37 |
*** shyamb has joined #openstack-keystone | 11:47 | |
*** erus_ has joined #openstack-keystone | 11:50 | |
*** vishakha has quit IRC | 12:00 | |
*** shyamb has quit IRC | 12:16 | |
*** erus_ has quit IRC | 12:19 | |
*** erus_ has joined #openstack-keystone | 12:20 | |
*** erus_ has quit IRC | 12:39 | |
*** erus_ has joined #openstack-keystone | 12:45 | |
*** whoami-rajat has quit IRC | 12:55 | |
*** awalende has quit IRC | 13:26 | |
*** awalende has joined #openstack-keystone | 13:27 | |
*** rcernin has quit IRC | 13:30 | |
*** awalende has quit IRC | 13:31 | |
*** imus has joined #openstack-keystone | 13:37 | |
knikolla | o/ | 14:05 |
*** aojea has joined #openstack-keystone | 14:20 | |
*** whoami-rajat has joined #openstack-keystone | 14:46 | |
*** dave-mccowan has joined #openstack-keystone | 14:46 | |
*** lbragstad has joined #openstack-keystone | 14:49 | |
*** ChanServ sets mode: +o lbragstad | 14:49 | |
*** dave-mccowan has quit IRC | 14:51 | |
openstackgerrit | Merged openstack/keystone-tempest-plugin master: Update hacking version to latest https://review.openstack.org/629348 | 14:53 |
*** spsurya has quit IRC | 15:07 | |
*** ayoung has quit IRC | 15:19 | |
*** dklyle has quit IRC | 15:22 | |
kmalloc | O/ | 15:27 |
kmalloc | adriant: auto-promote (as you call it) should just be a keystone server side "always run" auth method. | 15:28 |
lbragstad | o/ | 15:30 |
*** spsurya has joined #openstack-keystone | 15:30 | |
lbragstad | so - i was finally able to get a scoped token using an x509 certificate | 15:32 |
cmurphy | oh good | 15:32 |
lbragstad | i was getting things really confused | 15:32 |
lbragstad | but - think it might be broken, too? | 15:34 |
*** erus_ has quit IRC | 15:34 | |
*** erus_ has joined #openstack-keystone | 15:34 | |
*** jmlowe has joined #openstack-keystone | 15:34 | |
cmurphy | not possible | 15:35 |
lbragstad | check this out https://pasted.tech/pastes/44d9393b0b01f40257fc216fec914ebb9bce07a6.raw | 15:37 |
lbragstad | i put scope in the request | 15:37 |
lbragstad | but i also had to define it in the header | 15:37 |
lbragstad | and both have to match | 15:37 |
lbragstad | if you don't define it in the header, it apparently short-circuits the request with a 400 validation error | 15:38 |
lbragstad | but if you don't define it in the request body, it doesn't actually pick it up, essentially ignoring the scope | 15:38 |
lbragstad | because the AutoInfo object we use only looks for it in the request body (it knows nothing of headers) | 15:39 |
lbragstad | i assume that is broken behavior | 15:40 |
lbragstad | it's like the approach for tokenless authentication was smashed with the external authentication path... | 15:41 |
lbragstad | that said, i'm not sure if anyone is actually able to use this with having a firm understanding of the code... that's the only way i could piece this together, even with a fair amount of guess work | 15:42 |
lbragstad | without having a firm understanding* | 15:43 |
*** bnemec has quit IRC | 15:43 | |
*** lbragstad is now known as elbragstad | 15:43 | |
cmurphy | oh interesting | 15:49 |
cmurphy | i could believe that we forgot about this feature and introduced some weirdness in the scoping logic | 15:50 |
elbragstad | we apparently had an x509 authentication plugin at one point (for tokenless auth), but that was renamed to external? | 15:50 |
elbragstad | so i'm wondering if something went side ways in that refactor | 15:50 |
cmurphy | no x509 maps to mapped just like all the other federation protocols | 15:51 |
elbragstad | oh? | 15:51 |
cmurphy | http://git.openstack.org/cgit/openstack/keystone/tree/setup.cfg#n106 | 15:51 |
*** cmurphy is now known as cmorpheus | 15:51 | |
elbragstad | yep - nevermind... | 15:51 |
elbragstad | you're right | 15:51 |
elbragstad | i glazed over everything but the name on slide 8 https://docs.google.com/presentation/d/1cBgiKb0ZgdKaBRfj77N7vEu4OwSma0FK57nKg4u5D-k/edit#slide=id.p11 | 15:52 |
*** imus has quit IRC | 15:55 | |
elbragstad | i don't have x509 in my configured authentication methods | 15:55 |
elbragstad | just token, password, and external | 15:55 |
elbragstad | so i'm still a little confused as to how the mapping is getting invoked | 15:56 |
cmorpheus | elbragstad: oh! i think you have a local user already created? | 15:57 |
cmorpheus | at least i think I did when I was doing this | 15:57 |
elbragstad | yep - i do | 15:57 |
cmorpheus | because the example mapping had "local" in it | 15:58 |
cmorpheus | does that user already have persistent role assignments? | 15:58 |
elbragstad | they do | 15:58 |
elbragstad | https://pasted.tech/pastes/6a5fa3e70b0e529cddc54cf7082e9ee119067254.raw | 15:58 |
elbragstad | so - that explains why there is mapping logging in there? | 15:59 |
cmorpheus | hmm well not really | 15:59 |
* cmorpheus unsure | 16:00 | |
elbragstad | all that mapping stuff is logged before it even really hits the authentication controller | 16:02 |
elbragstad | i bet middleware is doing something | 16:02 |
*** dklyle has joined #openstack-keystone | 16:03 | |
elbragstad | huh | 16:05 |
elbragstad | http://git.openstack.org/cgit/openstack/keystone/tree/keystone/server/flask/request_processing/middleware/auth_context.py#n360 | 16:05 |
elbragstad | -> http://git.openstack.org/cgit/openstack/keystone/tree/keystone/server/flask/request_processing/middleware/auth_context.py#n436 | 16:06 |
*** elbragstad has quit IRC | 16:06 | |
*** lbragstad has joined #openstack-keystone | 16:07 | |
*** ChanServ sets mode: +o lbragstad | 16:07 | |
*** lbragstad is now known as elbragstad | 16:07 | |
elbragstad | -> http://git.openstack.org/cgit/openstack/keystone/tree/keystone/server/flask/request_processing/middleware/auth_context.py#n319 | 16:07 |
elbragstad | which means we hit this method - http://git.openstack.org/cgit/openstack/keystone/tree/keystone/server/flask/request_processing/middleware/auth_context.py#n248 | 16:08 |
elbragstad | and boom -> http://git.openstack.org/cgit/openstack/keystone/tree/keystone/server/flask/request_processing/middleware/auth_context.py#n258 | 16:11 |
elbragstad | i think that path gets called when doing both tokenless authentication and authenticating for tokens with an x509 certificate because they share similar configuration for trusted issuers | 16:14 |
*** yan0s has quit IRC | 16:17 | |
elbragstad | that also explains why using an auto-provisioned mapping doesn't work for x509 protocols | 16:20 |
*** shyamb has joined #openstack-keystone | 16:20 | |
elbragstad | the mapping implementation for tokenless auth isn't using the mapped plugin | 16:21 |
elbragstad | instead - it does its own thing by getting the mapped properties from the federation api directly | 16:21 |
elbragstad | i had no idea this existed... or worked this way, which kinda sucks because i'm sure i made the delta between the two worse when i did the autoprovisioning enhancements to the mapping API | 16:23 |
openstackgerrit | Merged openstack/keystone master: Update service provider policies for system admin https://review.openstack.org/620158 | 16:26 |
openstackgerrit | Merged openstack/keystone master: Add tests for domain users interacting with sps https://review.openstack.org/620159 | 16:26 |
openstackgerrit | Merged openstack/keystone master: Add tests for project users interacting with sps https://review.openstack.org/620160 | 16:26 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove service provider policies from v3cloudsample.json https://review.openstack.org/620161 | 16:31 |
cmorpheus | elbragstad: just means we need better test coverage for it | 16:44 |
cmorpheus | tribal knowledge passed down by word of unit test | 16:44 |
elbragstad | yeah - exactly | 16:51 |
elbragstad | i'm really surprised this broke and nothing failed... | 16:51 |
elbragstad | this is also one of the first times i've taken this hard of a look at the feature | 16:54 |
elbragstad | but some of the approaches in the x509 external auth code path might not be necessary anymore | 16:55 |
elbragstad | for example, we set the REMOTE_DOMAIN using an apache configuration value | 16:55 |
elbragstad | but we also auto-create domains for identity providers | 16:55 |
elbragstad | (which you need to do when you setup x509 authentication) | 16:55 |
elbragstad | i think if we want to be consistent with other federated approaches, we might consider using the domain for the x509 protocol/idp | 16:56 |
*** erus_ has quit IRC | 16:56 | |
elbragstad | instead of having operators define it in apache | 16:56 |
*** erus_ has joined #openstack-keystone | 16:57 | |
*** dklyle has quit IRC | 17:00 | |
cmorpheus | REMOTE_DOMAIN really confused me, i could barely find any reference to it online | 17:07 |
*** dklyle has joined #openstack-keystone | 17:07 | |
*** shyamb has quit IRC | 17:07 | |
*** gyee has joined #openstack-keystone | 17:11 | |
*** aojea has quit IRC | 17:14 | |
*** dklyle has quit IRC | 17:19 | |
elbragstad | gyee's here | 17:19 |
elbragstad | i have so many questions | 17:19 |
gyee | elbragstad, yes sir | 17:23 |
elbragstad | we're working through https://bugs.launchpad.net/keystone/+bugs?field.tag=x509 | 17:28 |
elbragstad | turns out - the x509/tokenless authentication path doesn't use the Mapped plugin for mapping stuff (which is why we can't use auto-provisioning) | 17:29 |
gyee | elbragstad, right, for the second case, it doesn't use mapping | 17:29 |
gyee | the first case is federation, which should be using mapping | 17:30 |
elbragstad | first case == x509? | 17:30 |
elbragstad | second case == tokenless authentication? | 17:30 |
gyee | right | 17:31 |
gyee | we are talking about the second case right? | 17:31 |
elbragstad | well - i was trying to do the first case | 17:32 |
elbragstad | where i have an auto-provisioned mapping | 17:33 |
elbragstad | and i'm using an x509 certificate to authenticate | 17:33 |
elbragstad | the mapping gets processed, but it doesn't actually provision anything | 17:34 |
gyee | oh | 17:35 |
elbragstad | because the tokenless helper has it's own mapping logic | 17:35 |
elbragstad | versus the mapped plugin | 17:35 |
elbragstad | which is where that feature lives | 17:35 |
gyee | here? https://github.com/openstack/keystone/blob/master/keystone/common/tokenless_auth.py#L113 | 17:36 |
elbragstad | yeah - exactly | 17:37 |
gyee | damn | 17:37 |
gyee | time to refactor to code I guess | 17:37 |
elbragstad | https://git.openstack.org/cgit/openstack/keystone/tree/keystone/auth/plugins/mapped.py#n112 | 17:37 |
elbragstad | i'll be honest, i haven't looked at this long enough to know where to start with the refactor, but i'll help out if i can | 17:38 |
elbragstad | or if we come up with a plan for how we want this to look when everything is said and done | 17:39 |
elbragstad | ideally - it would be nice to have x509 federated authentication exercise the same code path as SAML or OIDC | 17:39 |
elbragstad | but it seems to get mixed up with tokenless auth | 17:39 |
gyee | elbragstad, I need to refresh my memories on some of these things | 17:40 |
gyee | I completely agreed, we need to have the same code path | 17:40 |
elbragstad | i do think it'll be sweet to get this working again though | 17:41 |
gyee | ++ | 17:41 |
gyee | I thought the first case was using the saml code path | 17:41 |
elbragstad | for x509 federation (not tokenless authentication) i should be able to specify scope in the request body though, right? | 17:42 |
elbragstad | x509 federation doesn't require X-Project-Id or scope to be in headers, should it? that's only for x509 tokenless authentication | 17:42 |
*** erus_ has quit IRC | 17:42 | |
gyee | elbragstad, when federation was first design, it wasn't allowing scoped token directly | 17:42 |
gyee | maybe I got mixed up with K2K | 17:43 |
*** erus_ has joined #openstack-keystone | 17:43 | |
elbragstad | well - we used group membership | 17:43 |
elbragstad | to map ephemeral users into groups in keystone for assignments | 17:44 |
gyee | yeah you're right | 17:44 |
elbragstad | but now we also have the shadow users stuff | 17:44 |
elbragstad | it would be nice to get that working with x509 federation, too | 17:45 |
gyee | yes, that part I need to catch up on | 17:45 |
*** aojea has joined #openstack-keystone | 17:46 | |
gyee | elbragstad, maybe getting it working with devstack plugin and tempest plugin would be awesomer too | 17:48 |
elbragstad | yeah - it would be nice to use that for some functional testing | 17:48 |
gyee | stretch goal, as they said in corporate lango :-) | 17:48 |
elbragstad | i mean... the "identity provider" is a cert | 17:48 |
elbragstad | we don't actually have to setup an external identity provider system, we just need a self-signed CA | 17:49 |
gyee | right, generating a self-signed CA is pretty easy | 17:49 |
elbragstad | yeah | 17:49 |
elbragstad | if all the federated implementation use the same code path, this might be a relatively low bar way to test federateion | 17:50 |
gyee | oh yeah | 17:50 |
elbragstad | without having to stand up keystone as an idp, or some other thing that acts as the idp | 17:50 |
elbragstad | (even though we should) | 17:50 |
gyee | that's how we test K2K today right? single instance acting both as IdP and SP | 17:51 |
*** erus_ has quit IRC | 17:51 | |
elbragstad | i'm not sure | 17:51 |
*** erus_ has joined #openstack-keystone | 17:51 | |
elbragstad | but - to be on the same page, a request for a scoped token using x509 federation _shouldn't_ include scope in the headers, right? | 17:54 |
elbragstad | that should only be for tokenless authentication | 17:54 |
gyee | right | 17:54 |
gyee | federation should strictly going through mapping | 17:54 |
elbragstad | ok - just wonder what way i should start with https://bugs.launchpad.net/keystone/+bug/1813336 | 17:54 |
openstack | Launchpad bug 1813336 in OpenStack Identity (keystone) "Requesting a scoped token when using x509 authentication is redundant" [Medium,Triaged] | 17:54 |
gyee | wow, I didn't realized we did that | 17:55 |
elbragstad | yeah... me either | 17:56 |
elbragstad | i was trying to just use the docs to get a scoped token | 17:56 |
elbragstad | but it wasn't really working so i started reading the code, which is when cmorpheus and i start picking through all of these things | 17:56 |
elbragstad | (e.g., finding out the gap with auto-provisioning, scoping redundancy, domain generation redundancy with x509 federation) | 17:57 |
* elbragstad grabs lunch quick | 17:59 | |
*** dklyle has joined #openstack-keystone | 18:00 | |
*** aojea has quit IRC | 18:20 | |
*** whoami-rajat has quit IRC | 18:34 | |
*** sapd1_ has quit IRC | 18:47 | |
*** sapd1_ has joined #openstack-keystone | 18:47 | |
*** aojea has joined #openstack-keystone | 18:51 | |
*** bnemec has joined #openstack-keystone | 19:02 | |
*** bnemec is now known as beekneemech | 19:11 | |
*** aojea has quit IRC | 19:24 | |
*** erus_ has quit IRC | 19:24 | |
*** erus_ has joined #openstack-keystone | 19:24 | |
*** beekneemech has quit IRC | 19:42 | |
*** dklyle has quit IRC | 19:51 | |
*** aojea has joined #openstack-keystone | 19:57 | |
*** dklyle has joined #openstack-keystone | 20:13 | |
*** spsurya has quit IRC | 20:37 | |
*** dklyle has quit IRC | 20:55 | |
*** dklyle has joined #openstack-keystone | 20:59 | |
*** dklyle has quit IRC | 21:13 | |
*** ayoung has joined #openstack-keystone | 21:51 | |
ayoung | knikolla, you still on Furlough? | 21:51 |
knikolla | ayoung: no, H1 got surprisingly approved as of yesterday. | 21:52 |
*** awalende has joined #openstack-keystone | 21:58 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Expose py3 bug in how non-uuid domain IDs are handled https://review.openstack.org/633287 | 22:10 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Handle special cases with msgpack and python3 https://review.openstack.org/633288 | 22:10 |
elbragstad | weird little corner case with py3 + msgpack | 22:11 |
elbragstad | apparently msgpack doesn't really care about types as much on python3? | 22:11 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Handle special cases with msgpack and python3 https://review.openstack.org/633288 | 22:21 |
*** awalende has quit IRC | 22:31 | |
*** awalende has joined #openstack-keystone | 22:31 | |
*** awalende has quit IRC | 22:35 | |
*** jmlowe has quit IRC | 22:41 | |
*** bnemec has joined #openstack-keystone | 23:12 | |
*** dklyle has joined #openstack-keystone | 23:13 | |
*** dklyle has quit IRC | 23:20 | |
*** xek has quit IRC | 23:30 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Handle special cases with msgpack and python3 https://review.openstack.org/633288 | 23:33 |
*** bnemec has quit IRC | 23:43 | |
*** bnemec has joined #openstack-keystone | 23:44 | |
*** elbragstad has quit IRC | 23:54 | |
*** bnemec has quit IRC | 23:59 | |
*** bnemec has joined #openstack-keystone | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!