*** gongysh has quit IRC | 00:02 | |
*** dklyle has quit IRC | 00:02 | |
*** felipemonteiro has joined #openstack-keystone | 00:17 | |
*** itlinux_ has joined #openstack-keystone | 00:22 | |
*** itlinux has quit IRC | 00:23 | |
*** felipemonteiro has quit IRC | 00:24 | |
*** markvoelker has quit IRC | 00:25 | |
*** r-daneel has quit IRC | 00:32 | |
*** felipemonteiro has joined #openstack-keystone | 00:36 | |
*** Anticimex has quit IRC | 00:41 | |
*** Anticimex has joined #openstack-keystone | 00:46 | |
*** itlinux_ has quit IRC | 00:49 | |
*** alex_xu has quit IRC | 00:57 | |
*** felipemonteiro has quit IRC | 00:57 | |
openstackgerrit | Merged openstack/oslo.policy master: Avoid redundant policy syntax checks https://review.openstack.org/511426 | 01:02 |
---|---|---|
*** alex_xu has joined #openstack-keystone | 01:02 | |
*** harlowja has quit IRC | 01:09 | |
*** jmlowe has quit IRC | 01:16 | |
*** itlinux has joined #openstack-keystone | 01:17 | |
*** Dinesh_Bhor has joined #openstack-keystone | 01:17 | |
*** jmlowe has joined #openstack-keystone | 01:24 | |
*** evrardjp has quit IRC | 01:44 | |
*** alex_xu has quit IRC | 01:47 | |
*** alex_xu has joined #openstack-keystone | 01:48 | |
*** evrardjp has joined #openstack-keystone | 01:49 | |
openstackgerrit | wangxiyuan proposed openstack/keystoneauth master: Add netloc and version check for version discovery https://review.openstack.org/583215 | 01:55 |
*** jmlowe has quit IRC | 01:58 | |
*** evrardjp has quit IRC | 02:02 | |
*** jmlowe has joined #openstack-keystone | 02:06 | |
*** evrardjp has joined #openstack-keystone | 02:07 | |
*** annp has joined #openstack-keystone | 02:16 | |
openstackgerrit | wangxiyuan proposed openstack/keystoneauth master: Add netloc and version check for version discovery https://review.openstack.org/583215 | 02:19 |
*** itlinux has quit IRC | 02:19 | |
*** markvoelker has joined #openstack-keystone | 02:26 | |
*** felipemonteiro has joined #openstack-keystone | 02:40 | |
*** dave-mcc_ has quit IRC | 02:45 | |
*** felipemonteiro has quit IRC | 02:59 | |
*** markvoelker has quit IRC | 03:00 | |
*** vrv_ has joined #openstack-keystone | 03:09 | |
*** gongysh has joined #openstack-keystone | 03:10 | |
imacdonn | kmalloc lbragstad https://review.openstack.org/#/c/583835/ - review when you have a chance. thanks. | 03:36 |
*** gongysh has quit IRC | 03:43 | |
*** zhongjun__ has quit IRC | 03:44 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Add include_limits filter https://review.openstack.org/579331 | 03:46 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Update project depth check https://review.openstack.org/580258 | 03:46 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Add project hierarchical tree check when Keystone start https://review.openstack.org/580331 | 03:46 |
*** felipemonteiro has joined #openstack-keystone | 03:47 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Delete project limits when deleting project https://review.openstack.org/538371 | 03:49 |
*** harlowja has joined #openstack-keystone | 03:51 | |
*** markvoelker has joined #openstack-keystone | 03:58 | |
*** links has joined #openstack-keystone | 04:08 | |
*** harlowja has quit IRC | 04:22 | |
*** pcaruana has joined #openstack-keystone | 04:23 | |
*** markvoelker has quit IRC | 04:31 | |
*** pcaruana has quit IRC | 04:34 | |
*** felipemonteiro has quit IRC | 04:37 | |
*** felipemonteiro has joined #openstack-keystone | 04:44 | |
*** flwang1 has quit IRC | 04:52 | |
*** felipemonteiro has quit IRC | 04:55 | |
*** AlexeyAbashkin has joined #openstack-keystone | 04:57 | |
*** felipemonteiro has joined #openstack-keystone | 05:01 | |
*** neha_alhat has joined #openstack-keystone | 05:02 | |
neha_alhat | lbragstad: Hi, want to discuss on this patch: https://review.openstack.org/#/c/578008/ | 05:08 |
neha_alhat | lbragstad: should I add releasenote for this patch or should modify the help text? | 05:10 |
*** pcichy has joined #openstack-keystone | 05:13 | |
*** vrv_ has quit IRC | 05:18 | |
*** hoonetorg has quit IRC | 05:20 | |
*** markvoelker has joined #openstack-keystone | 05:27 | |
*** wlmbasson_ has joined #openstack-keystone | 05:28 | |
*** wxy_ has joined #openstack-keystone | 05:28 | |
*** robcresswell has quit IRC | 05:29 | |
*** pas-ha has quit IRC | 05:29 | |
*** jamespage has quit IRC | 05:29 | |
*** wlmbasson has quit IRC | 05:29 | |
*** wlmbasson_ is now known as wlmbasson | 05:29 | |
*** robcresswell has joined #openstack-keystone | 05:29 | |
*** wxy has quit IRC | 05:29 | |
*** NobodyCam has quit IRC | 05:29 | |
*** wxy_ is now known as wxy | 05:29 | |
*** NobodyCam has joined #openstack-keystone | 05:29 | |
*** jamespage has joined #openstack-keystone | 05:29 | |
*** pas-ha has joined #openstack-keystone | 05:30 | |
*** mwhahaha_ has joined #openstack-keystone | 05:30 | |
*** mwhahaha has quit IRC | 05:30 | |
*** portdirect has quit IRC | 05:30 | |
*** mwhahaha_ is now known as mwhahaha | 05:30 | |
*** portdirect has joined #openstack-keystone | 05:30 | |
*** elibrokeit has quit IRC | 05:31 | |
*** jmccrory has quit IRC | 05:31 | |
*** jamielennox has quit IRC | 05:31 | |
*** portdirect is now known as Guest72952 | 05:32 | |
*** ztrawhcse has joined #openstack-keystone | 05:34 | |
*** jmccrory has joined #openstack-keystone | 05:35 | |
*** hoonetorg has joined #openstack-keystone | 05:37 | |
*** AlexeyAbashkin has quit IRC | 05:41 | |
*** threestrands has quit IRC | 05:49 | |
*** pcichy has quit IRC | 05:50 | |
*** felipemonteiro has quit IRC | 05:56 | |
*** markvoelker has quit IRC | 06:01 | |
*** threestrands has joined #openstack-keystone | 06:09 | |
*** threestrands has quit IRC | 06:09 | |
*** threestrands has joined #openstack-keystone | 06:09 | |
*** jamielennox has joined #openstack-keystone | 06:11 | |
*** ztrawhcse is now known as elibrokeit | 06:13 | |
*** elibrokeit has quit IRC | 06:13 | |
*** ztrawhcse has joined #openstack-keystone | 06:15 | |
*** ztrawhcse is now known as elibrokeit | 06:16 | |
*** annp has quit IRC | 06:17 | |
*** threestrands has quit IRC | 06:36 | |
*** pcaruana has joined #openstack-keystone | 06:37 | |
*** martinus__ has joined #openstack-keystone | 06:57 | |
*** markvoelker has joined #openstack-keystone | 06:58 | |
*** ispp has joined #openstack-keystone | 07:00 | |
*** peereb has joined #openstack-keystone | 07:02 | |
*** openstackgerrit has quit IRC | 07:04 | |
*** ispp has quit IRC | 07:04 | |
*** ispp has joined #openstack-keystone | 07:23 | |
*** vrv_ has joined #openstack-keystone | 07:23 | |
*** flwang1 has joined #openstack-keystone | 07:25 | |
*** flwang1 has quit IRC | 07:28 | |
*** rcernin has quit IRC | 07:29 | |
*** markvoelker has quit IRC | 07:32 | |
*** tosky has joined #openstack-keystone | 07:37 | |
*** annp has joined #openstack-keystone | 07:40 | |
*** AlexeyAbashkin has joined #openstack-keystone | 07:56 | |
*** markvoelker has joined #openstack-keystone | 08:29 | |
*** aloga has quit IRC | 08:30 | |
*** aloga has joined #openstack-keystone | 08:31 | |
*** flwang1 has joined #openstack-keystone | 08:37 | |
*** tesseract has joined #openstack-keystone | 08:41 | |
*** viks_ has joined #openstack-keystone | 08:50 | |
*** dikonoor has joined #openstack-keystone | 08:55 | |
*** neha_alhat has quit IRC | 08:59 | |
*** markvoelker has quit IRC | 09:01 | |
*** bhagyashris has quit IRC | 09:21 | |
*** bhagyashris has joined #openstack-keystone | 09:22 | |
*** vrv_ has quit IRC | 09:32 | |
*** Dinesh_Bhor has quit IRC | 09:34 | |
*** afazekas|pto is now known as afazekas | 09:39 | |
*** neha___ has joined #openstack-keystone | 09:54 | |
neha___ | wxy: Hi | 09:57 |
*** neha___ has quit IRC | 09:58 | |
*** markvoelker has joined #openstack-keystone | 09:59 | |
*** nehaalhat has joined #openstack-keystone | 09:59 | |
nehaalhat | wxy: Hi, want to discuss about this patch: https://review.openstack.org/#/c/578008/ | 10:00 |
nehaalhat | wxy: Actually for cinder to keystoneclient interaction If I want to enable split logging then I need to set split_loggers=True in cinder.conf under keystone_authtoken section. For this I am registering this option in keystonemiddleware. | 10:02 |
*** alex_xu has quit IRC | 10:03 | |
nehaalhat | wxy: In cinder I will pass this option like: https://review.openstack.org/#/c/579765/ | 10:03 |
nehaalhat | wxy: Thanks for pointing this: https://github.com/openstack/mistral/blob/master/mistral/utils/openstack/keystone.py#L33 | 10:05 |
*** peereb has quit IRC | 10:06 | |
*** alex_xu has joined #openstack-keystone | 10:08 | |
*** ispp has quit IRC | 10:12 | |
*** markvoelker has quit IRC | 10:32 | |
wxy | nehaalhat: looking cinder code. | 10:46 |
*** links has quit IRC | 10:49 | |
*** sapd has quit IRC | 10:53 | |
*** dikonoo has joined #openstack-keystone | 10:54 | |
*** dikonoor has quit IRC | 10:55 | |
wxy | nehaalhat: so you want so use split_loggers to init keystone session in cinder, right? | 10:56 |
wxy | https://github.com/openstack/cinder/blob/master/cinder/service_auth.py#L45 I find cinder registers the keystoneauth options in [service_user] group | 10:57 |
wxy | nehaalhat: so for your cinder patch, how about using "split_loggers=CONF.service_user.split_loggers"? | 10:58 |
*** ispp has joined #openstack-keystone | 11:01 | |
*** dikonoo has quit IRC | 11:04 | |
*** sapd has joined #openstack-keystone | 11:04 | |
*** links has joined #openstack-keystone | 11:12 | |
*** markvoelker has joined #openstack-keystone | 11:30 | |
*** openstackgerrit has joined #openstack-keystone | 11:35 | |
openstackgerrit | Merged openstack/keystone master: Don't allow legacy and native flask to share paths https://review.openstack.org/582449 | 11:35 |
*** pcichy has joined #openstack-keystone | 11:46 | |
*** dave-mccowan has joined #openstack-keystone | 11:59 | |
*** markvoelker has quit IRC | 12:02 | |
*** markvoelker has joined #openstack-keystone | 12:02 | |
*** raildo has joined #openstack-keystone | 12:24 | |
*** ispp has quit IRC | 12:26 | |
*** ispp has joined #openstack-keystone | 12:28 | |
*** Guest72952 is now known as portdirect | 12:41 | |
*** edmondsw has joined #openstack-keystone | 12:41 | |
-openstackstatus- NOTICE: logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown. | 12:56 | |
*** ChanServ changes topic to "logs.openstack.org is offline, causing POST_FAILURE results from Zuul. Cause and resolution timeframe currently unknown." | 12:56 | |
*** pcichy has quit IRC | 13:14 | |
*** pcichy has joined #openstack-keystone | 13:15 | |
*** pcichy has quit IRC | 13:17 | |
*** felipemonteiro has joined #openstack-keystone | 13:26 | |
*** felipemonteiro has quit IRC | 13:35 | |
*** ChanServ changes topic to "Rocky release schedule: https://releases.openstack.org/rocky/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h | Trello: https://trello.com/b/wmyzbFq5/keystone-rocky-roadmap !!NOTE!! This Channel is Logged ( https://tinyurl.com/OpenStackKeystone )" | 13:39 | |
-openstackstatus- NOTICE: logs.openstack.org is back on-line. Changes with "POST_FAILURE" job results should be rechecked. | 13:39 | |
*** ispp has quit IRC | 13:39 | |
*** ispp has joined #openstack-keystone | 13:41 | |
*** r-daneel has joined #openstack-keystone | 13:47 | |
*** pcichy has joined #openstack-keystone | 13:50 | |
knikolla | o/ | 13:50 |
*** ispp has quit IRC | 13:53 | |
*** raildo has quit IRC | 13:53 | |
*** raildo has joined #openstack-keystone | 13:54 | |
*** felipemonteiro has joined #openstack-keystone | 13:58 | |
*** r-daneel_ has joined #openstack-keystone | 14:03 | |
*** r-daneel has quit IRC | 14:05 | |
*** r-daneel_ is now known as r-daneel | 14:05 | |
*** felipemonteiro__ has joined #openstack-keystone | 14:15 | |
*** felipemonteiro has quit IRC | 14:16 | |
*** felipemonteiro_ has joined #openstack-keystone | 14:16 | |
*** felipemonteiro__ has quit IRC | 14:20 | |
gagehugo | o/ | 14:44 |
cmurphy | \o | 14:45 |
*** r-daneel has quit IRC | 14:47 | |
*** zhongjun__ has joined #openstack-keystone | 14:49 | |
*** r-daneel has joined #openstack-keystone | 14:55 | |
*** lbragstad has joined #openstack-keystone | 15:03 | |
*** ChanServ sets mode: +o lbragstad | 15:03 | |
lbragstad | looks like we just need https://review.openstack.org/#/q/starredby:lbragstad%2540gmail.com+status:open to finish merged and get another review on kmalloc's patch and we can cut ksm/ksa/ldappool | 15:09 |
kmalloc | Cool | 15:11 |
kmalloc | Post food I'll check them, obv won't +2 my patch :P | 15:11 |
*** pcaruana has quit IRC | 15:12 | |
*** dklyle has joined #openstack-keystone | 15:23 | |
imacdonn | so it looks like CI for stable releases of ksm is broken ... looks like the pip 10 thing, where it fails when there are no packages to install: ERROR: You must give at least one requirement to install (see "pip help install") | 15:27 |
*** r-daneel has quit IRC | 15:31 | |
imacdonn | Need to backport this, I think ... https://github.com/openstack/keystonemiddleware/commit/ad10c32a89b770c08e8c21f65d2ddc961e1e6d48#diff-ce3c1b6e426afcb2e749638c629c0a2e | 15:33 |
lbragstad | that looks familiar | 15:36 |
*** AlexeyAbashkin has quit IRC | 15:40 | |
imacdonn | if there are no objections, I'm going to attempt to cherrypick from https://review.openstack.org/#/c/562994/ | 15:40 |
lbragstad | sure - let's see if it fixes the problem | 15:41 |
imacdonn | k | 15:41 |
lbragstad | does anyone else want to take a peak at https://review.openstack.org/#/c/583695/ (knikolla?) | 15:42 |
*** alex_xu has quit IRC | 15:42 | |
knikolla | lbragstad: was just going out for lunch. will review when i'm back. | 15:43 |
lbragstad | ok - thanks | 15:43 |
*** alex_xu has joined #openstack-keystone | 15:47 | |
*** felipemonteiro_ has quit IRC | 15:57 | |
*** felipemonteiro_ has joined #openstack-keystone | 15:58 | |
gagehugo | lbragstad: done | 16:01 |
*** r-daneel has joined #openstack-keystone | 16:07 | |
lbragstad | ok cool - thanks gagehugo | 16:10 |
lbragstad | i have https://review.openstack.org/#/c/584003/ and https://review.openstack.org/#/c/584005/ proposed for review and they are dependent on the ksa and ksm patches | 16:11 |
lbragstad | so - worst case, they just need to be rechecked | 16:11 |
lbragstad | so the release team can review them | 16:11 |
*** felipemonteiro_ has quit IRC | 16:13 | |
lbragstad | i gotta step away for a bit - but i'll check in before EOD | 16:15 |
imacdonn | lbragstad: you gone already ? | 16:17 |
lbragstad | imacdonn: not yet | 16:18 |
imacdonn | lbragstad: k. Was just going to say that I think we'll need your approval on https://review.openstack.org/#/c/584011/ and .. the other one | 16:19 |
lbragstad | https://review.openstack.org/#/c/584002/ | 16:19 |
*** r-daneel_ has joined #openstack-keystone | 16:19 | |
imacdonn | which is required to get CI working, so we can get the other backports through ... but I just realised that that's not required for the rocky release, so not so urgent | 16:20 |
*** r-daneel has quit IRC | 16:20 | |
*** r-daneel_ is now known as r-daneel | 16:20 | |
kmalloc | imacdonn: yeah we can land the backports at anypoint | 16:21 |
lbragstad | and it's already fixed in rocky, which is good | 16:21 |
imacdonn | FWIW, it looks like the pip fix is going to work ... 584002 passed the sphinx-docs part ... it'll take a while for tempest | 16:21 |
imacdonn | yes | 16:21 |
kmalloc | ++ | 16:21 |
lbragstad | imacdonn: you need https://review.openstack.org/#/c/584003/ to fix rocky i think? | 16:21 |
openstackgerrit | Colleen Murphy proposed openstack/ldappool master: Add author email to setup.cfg https://review.openstack.org/584017 | 16:22 |
imacdonn | 584003 is your 5.2.0 release | 16:22 |
cmurphy | lbragstad: i think that might fix the release linter error ^ | 16:22 |
lbragstad | oh - thanks cmurphy@! | 16:22 |
kmalloc | lbragstad: +2/+A on that one | 16:23 |
kmalloc | since it was trivial | 16:23 |
cmurphy | tyty | 16:23 |
kmalloc | lbragstad: going to fix trusts, get /auth/ moved to flask, catalog, policy, endpoint_policy should all be today | 16:24 |
kmalloc | geting the easy ones wound down | 16:24 |
kmalloc | hopefully i can tackle the bigger ones tomorrow. | 16:25 |
lbragstad | ok - i can't promise a review today or tomorrow, but hopefully over the weekend | 16:25 |
lbragstad | updated https://review.openstack.org/#/c/583988/2 | 16:25 |
kmalloc | yeah no worries. | 16:25 |
kmalloc | just letting you know they'll be posted | 16:25 |
lbragstad | awesome - i'll be sure to check for them | 16:25 |
kmalloc | auth is going to be a bit more special, just because of how it works. | 16:25 |
kmalloc | so expect it to be less like credential or trust. | 16:25 |
lbragstad | sure - makes sense | 16:26 |
kmalloc | the reason trusts is failing is a minor issue with the JSON_HOME document | 16:31 |
kmalloc | btw. | 16:31 |
kmalloc | does anything actually use json home at this point? | 16:31 |
kmalloc | or is it just something we standardized on and ... well carry due to contract? | 16:31 |
*** ayoung has quit IRC | 16:34 | |
openstackgerrit | Merged openstack/keystoneauth master: Add netloc and version check for version discovery https://review.openstack.org/583215 | 16:52 |
*** tesseract has quit IRC | 16:56 | |
imacdonn | urgh, now pike CI is failing with: | 17:02 |
imacdonn | 2018-07-19 16:57:09.030075 | ubuntu-xenial | File "/home/zuul/src/git.openstack.org/openstack/keystonemiddleware/keystonemiddleware/tests/unit/audit/base.py", line 15, in <module> | 17:02 |
imacdonn | 2018-07-19 16:57:09.030269 | ubuntu-xenial | from oslo_messaging import conffixture as msg_fixture | 17:02 |
imacdonn | 2018-07-19 16:57:09.030412 | ubuntu-xenial | ImportError: No module named oslo_messaging | 17:02 |
*** links has quit IRC | 17:03 | |
*** edmondsw has quit IRC | 17:13 | |
imacdonn | cmurphy: you around ? | 17:16 |
*** edmondsw has joined #openstack-keystone | 17:18 | |
cmurphy | imacdonn: mostly, what's up? | 17:20 |
imacdonn | re above failure .... seems you may have addressed it post-Pike | 17:20 |
imacdonn | https://github.com/openstack/keystonemiddleware/commit/ba9c1a3bec7b7c06dfbb3392b56f789752696a66#diff-46507bcc13aee955f6fe861c30ea5444 | 17:21 |
imacdonn | maybe indirectly addressed it | 17:21 |
cmurphy | oh good, i like when i've already fixed something | 17:21 |
imacdonn | heh, well, I'm wondering if it can be retro-applied to Pike | 17:22 |
cmurphy | imacdonn: this is the patch for pike https://review.openstack.org/#/c/546643/ | 17:22 |
cmurphy | kmalloc: can you ^ | 17:22 |
imacdonn | ohh, it never got +A'ed .. OK | 17:23 |
imacdonn | not sure how it gets handled when there are two different commits required to make CI work :/ | 17:23 |
kmalloc | sec | 17:24 |
kmalloc | was on the phone | 17:24 |
kmalloc | cmurphy: done | 17:25 |
imacdonn | kmalloc: I think that will fail to build due to the pip issue | 17:26 |
imacdonn | i.e. https://review.openstack.org/#/c/584011/ | 17:26 |
cmurphy | fun :/ | 17:28 |
imacdonn | yeah | 17:28 |
openstackgerrit | Merged openstack/ldappool master: Add author email to setup.cfg https://review.openstack.org/584017 | 17:29 |
imacdonn | actually ... I wonder if having the proper requirements stuff in place will obviate the pip issue | 17:30 |
kmalloc | hopefully? | 17:32 |
imacdonn | it didn't :( | 17:33 |
kmalloc | boo | 17:33 |
imacdonn | 2018-07-19 17:32:44.660553 | ubuntu-xenial | ERROR: You must give at least one requirement to install (see "pip help install") | 17:33 |
*** felipemonteiro has joined #openstack-keystone | 17:35 | |
*** r-daneel has quit IRC | 17:35 | |
imacdonn | well the queens pip fix passed CI, at least .. this one needs +2 now ... https://review.openstack.org/#/c/584002/1 | 17:41 |
*** s10 has joined #openstack-keystone | 17:45 | |
s10 | Hello. I'm happy that fix for https://bugs.launchpad.net/keystoneauth/+bug/1733052 is in master now. Will this fix be backported to Queens? | 17:45 |
openstack | Launchpad bug 1733052 in keystoneauth "Usage of internal URL in clouds.yaml causes a 404" [High,Fix released] - Assigned to wangxiyuan (wangxiyuan) | 17:45 |
*** felipemo_ has joined #openstack-keystone | 17:46 | |
kmalloc | s10: it probably can be backported | 17:49 |
kmalloc | s10: if you want to propose it to the queens branch, we can see what CI says. | 17:49 |
kmalloc | s10: if not, i'll get around to it not too far out | 17:50 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Move trusts to flask native dispatching https://review.openstack.org/583278 | 17:50 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Mirror self-link trust check from tempest https://review.openstack.org/584041 | 17:50 |
*** felipemo_ has quit IRC | 18:01 | |
*** edmondsw has quit IRC | 18:03 | |
*** r-daneel has joined #openstack-keystone | 18:13 | |
cmurphy | imacdonn: kmalloc lbragstad so our options are to temporarily disable the docs job for the pike branch or to squash the two fixes into one, the first option will take a little longer because we'll have to wait for the zuul change to land, the second one will make the git history unclean | 18:27 |
kmalloc | i'm fine with squashing | 18:28 |
kmalloc | git history cleanliness is mostly outweighed by "it's broken, fix" | 18:28 |
kmalloc | imo | 18:28 |
kmalloc | as long as we clearly deliniate the squash and what is included, iirc we have history of doing just that | 18:29 |
cmurphy | sounds good to me | 18:29 |
kmalloc | disabling a job is a lot more work [even with nice zuul changes] | 18:29 |
cmurphy | the results haven't actually come back on https://review.openstack.org/#/c/546643/ , zuul shows it hit retry_limit, i guess we presume it's not going to pass? | 18:29 |
kmalloc | wow, i hit the first case of "must change tests" to convert to flask. those cases of directly calling controller methods... *eyeroll* | 18:30 |
kmalloc | cmurphy: it probably wont pass then. | 18:30 |
* kmalloc kicks his badly written bootstrap cli tests =/ | 18:30 | |
imacdonn | cmurphy: I did see the pip error in the console output from the sphinx job (pasted earlier at 1733Z) | 18:30 |
cmurphy | imacdonn: okay | 18:31 |
*** edmondsw has joined #openstack-keystone | 18:31 | |
*** s10 has quit IRC | 18:33 | |
cmurphy | squashed in https://review.openstack.org/546643 | 18:40 |
imacdonn | thanks, cmurphy! | 18:40 |
kmalloc | cmurphy: +1 until zuul weighs in, i'll +2/+A once that clears check | 18:41 |
*** pcichy has quit IRC | 18:52 | |
*** pcichy has joined #openstack-keystone | 18:54 | |
*** itlinux has joined #openstack-keystone | 19:06 | |
*** tosky has quit IRC | 19:16 | |
*** cwright_ is now known as cwright | 19:26 | |
*** flwang1 has quit IRC | 19:34 | |
kmalloc | lbragstad: token_bind is 100% dead now, right? | 19:39 |
*** fiddletwix has quit IRC | 19:47 | |
*** fiddletwix has joined #openstack-keystone | 19:47 | |
*** ayoung has joined #openstack-keystone | 19:54 | |
*** s10 has joined #openstack-keystone | 19:59 | |
*** s10 has quit IRC | 20:09 | |
*** s10 has joined #openstack-keystone | 20:09 | |
*** s10 has quit IRC | 20:10 | |
*** s10 has joined #openstack-keystone | 20:10 | |
*** s10 has quit IRC | 20:11 | |
*** s10 has joined #openstack-keystone | 20:11 | |
*** s10 has quit IRC | 20:11 | |
*** s10 has joined #openstack-keystone | 20:12 | |
*** s10 has quit IRC | 20:12 | |
*** s10 has joined #openstack-keystone | 20:12 | |
*** s10 has quit IRC | 20:13 | |
*** s10 has joined #openstack-keystone | 20:13 | |
*** s10 has quit IRC | 20:14 | |
*** s10 has joined #openstack-keystone | 20:14 | |
*** s10 has quit IRC | 20:14 | |
*** s10 has joined #openstack-keystone | 20:15 | |
*** s10 has quit IRC | 20:15 | |
*** s10 has joined #openstack-keystone | 20:16 | |
*** s10 has quit IRC | 20:16 | |
*** s10 has joined #openstack-keystone | 20:16 | |
*** s10 has quit IRC | 20:17 | |
*** s10 has joined #openstack-keystone | 20:17 | |
*** martinus__ has quit IRC | 20:39 | |
*** s10 has quit IRC | 20:46 | |
*** raildo has quit IRC | 20:58 | |
*** raildo has joined #openstack-keystone | 20:58 | |
*** dave-mccowan has quit IRC | 21:00 | |
*** dave-mcc_ has joined #openstack-keystone | 21:00 | |
*** lifeless has quit IRC | 21:01 | |
*** dave-mccowan has joined #openstack-keystone | 21:02 | |
*** flwang1 has joined #openstack-keystone | 21:03 | |
*** dave-mcc_ has quit IRC | 21:04 | |
*** lifeless has joined #openstack-keystone | 21:06 | |
*** raildo has quit IRC | 21:06 | |
cmurphy | kmalloc: lbragstad https://review.openstack.org/#/c/546643/ passes | 21:08 |
imacdonn | yay, cmurphy's squash passed Zuul check - kmalloc, pls review https://review.openstack.org/#/c/546643/ and https://review.openstack.org/#/c/584002/ when you have a chance | 21:09 |
imacdonn | yeah, that :) | 21:09 |
imacdonn | thanks! | 21:10 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Move trusts to flask native dispatching https://review.openstack.org/583278 | 21:42 |
*** spilla has quit IRC | 21:50 | |
*** rcernin has joined #openstack-keystone | 21:58 | |
openstackgerrit | Merged openstack/keystonemiddleware master: Fix KeystoneMiddleware memcachepool abstraction https://review.openstack.org/583695 | 22:12 |
*** dklyle has quit IRC | 22:18 | |
*** harlowja has joined #openstack-keystone | 22:21 | |
*** itlinux has quit IRC | 22:22 | |
*** edmondsw has quit IRC | 22:30 | |
*** edmondsw has joined #openstack-keystone | 22:31 | |
lbragstad | thanks cmurphy | 22:35 |
lbragstad | looks like everything in https://review.openstack.org/#/q/starredby:lbragstad%2540gmail.com+status:open went though, too :) | 22:35 |
*** edmondsw has quit IRC | 22:35 | |
*** itlinux has joined #openstack-keystone | 22:42 | |
*** imacdonn has quit IRC | 22:45 | |
*** imacdonn has joined #openstack-keystone | 22:45 | |
*** rcernin_ has joined #openstack-keystone | 22:47 | |
*** rcernin has quit IRC | 22:49 | |
imacdonn | sigh .. think I see another requirements issue, for ksm/pike - requirements.txt is missing oslo.cache | 22:58 |
*** dklyle has joined #openstack-keystone | 23:00 | |
*** felipemonteiro has quit IRC | 23:00 | |
imacdonn | actually kmalloc, I think this may be a new requirement for your unit test in https://review.openstack.org/#/c/583699/1/keystonemiddleware/tests/unit/auth_token/test_cache.py | 23:01 |
imacdonn | yeah, that (test_abstraction_layer_reserve_places_connection_back_in_pool) is the test that's failing, with "ImportError: No module named oslo_cache" | 23:04 |
imacdonn | also, 583698 has a -1 asking if a release note is needed - I guess the same would apply to 583699 | 23:12 |
*** felipemonteiro has joined #openstack-keystone | 23:15 | |
*** mguz has joined #openstack-keystone | 23:17 | |
*** dklyle has quit IRC | 23:17 | |
*** felipemonteiro has quit IRC | 23:20 | |
openstackgerrit | Merged openstack/keystone master: Bump lower constraint for pysaml2 to 4.5.0 https://review.openstack.org/583678 | 23:23 |
*** felipemonteiro has joined #openstack-keystone | 23:24 | |
*** felipemonteiro has quit IRC | 23:30 | |
*** felipemonteiro has joined #openstack-keystone | 23:31 | |
kmalloc | oh ha. yeah | 23:33 |
kmalloc | right pike doesn't have oslo_cache | 23:33 |
kmalloc | we need to re-write it for the local memcache pool | 23:33 |
kmalloc | easy enough to do. | 23:33 |
*** felipemonteiro has quit IRC | 23:36 | |
*** dklyle has joined #openstack-keystone | 23:50 | |
*** fiddletwix has quit IRC | 23:58 | |
*** fiddletwix has joined #openstack-keystone | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!