*** tonytan4ever has joined #openstack-keystone | 00:03 | |
*** tonytan4ever has quit IRC | 00:07 | |
*** felipemonteiro_ has joined #openstack-keystone | 00:11 | |
kmalloc | ayoung: cool | 00:14 |
---|---|---|
*** tosky has quit IRC | 00:24 | |
*** gyee has quit IRC | 00:52 | |
*** david-lyle has joined #openstack-keystone | 01:04 | |
*** dklyle has quit IRC | 01:06 | |
*** spotz has quit IRC | 01:26 | |
*** spotz has joined #openstack-keystone | 01:26 | |
*** felipemonteiro_ has quit IRC | 02:06 | |
*** felipemonteiro_ has joined #openstack-keystone | 02:07 | |
*** felipemonteiro_ has quit IRC | 02:17 | |
openstackgerrit | wangxiyuan proposed openstack/keystone master: Add auto increase primary key for unified limit https://review.openstack.org/576025 | 02:37 |
*** pooja_jadhav has quit IRC | 02:40 | |
*** edmondsw has quit IRC | 02:41 | |
*** neha_alhat has quit IRC | 02:44 | |
*** fried_rice is now known as efried | 03:24 | |
*** alex_xu has quit IRC | 03:45 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: WIP Add docs for case-insensitivity in keystone https://review.openstack.org/576640 | 03:56 |
*** alex_xu has joined #openstack-keystone | 04:01 | |
*** edmondsw has joined #openstack-keystone | 04:20 | |
*** alex_xu has quit IRC | 04:25 | |
*** edmondsw has quit IRC | 04:25 | |
*** alex_xu has joined #openstack-keystone | 04:27 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Refactor - remove extra for loop https://review.openstack.org/579319 | 04:44 |
*** sapd__ has joined #openstack-keystone | 04:48 | |
*** sapd_ has quit IRC | 04:48 | |
*** david-lyle has quit IRC | 04:56 | |
*** dklyle has joined #openstack-keystone | 04:59 | |
*** peereb has joined #openstack-keystone | 06:01 | |
*** edmondsw has joined #openstack-keystone | 06:09 | |
*** edmondsw has quit IRC | 06:14 | |
*** lbragstad[m] has quit IRC | 06:23 | |
*** knikolla[m] has quit IRC | 06:24 | |
*** adriant has quit IRC | 06:40 | |
*** adriant has joined #openstack-keystone | 06:41 | |
*** AlexeyAbashkin has joined #openstack-keystone | 06:54 | |
*** Alexey_Abashkin has joined #openstack-keystone | 07:04 | |
*** Alexey_Abashkin has quit IRC | 07:05 | |
*** AlexeyAbashkin has quit IRC | 07:05 | |
*** AlexeyAbashkin has joined #openstack-keystone | 07:23 | |
*** lbragstad[m] has joined #openstack-keystone | 07:33 | |
*** raopajay has joined #openstack-keystone | 07:34 | |
*** Alexey_Abashkin has joined #openstack-keystone | 07:38 | |
*** AlexeyAbashkin has quit IRC | 07:39 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 07:39 | |
*** knikolla[m] has joined #openstack-keystone | 07:44 | |
*** AlexeyAbashkin has quit IRC | 07:48 | |
*** edmondsw has joined #openstack-keystone | 07:57 | |
*** edmondsw has quit IRC | 08:02 | |
*** dklyle has quit IRC | 09:24 | |
*** dklyle has joined #openstack-keystone | 09:25 | |
openstackgerrit | Brin Zhang proposed openstack/oslo.policy master: Add blueprints and releasenotes link to README https://review.openstack.org/579329 | 09:28 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP] Add project_id filter for listing limit https://review.openstack.org/579330 | 09:35 |
openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP] Add show hierarchy filter https://review.openstack.org/579331 | 09:35 |
*** edmondsw has joined #openstack-keystone | 09:45 | |
*** brad[] has quit IRC | 09:49 | |
*** edmondsw has quit IRC | 09:50 | |
*** raopajay has quit IRC | 11:23 | |
*** edmondsw has joined #openstack-keystone | 11:34 | |
*** edmondsw has quit IRC | 11:39 | |
*** martinus__ has joined #openstack-keystone | 12:14 | |
*** edmondsw has joined #openstack-keystone | 13:22 | |
*** edmondsw has quit IRC | 13:27 | |
*** tobberydberg has quit IRC | 14:01 | |
*** tobberydberg has joined #openstack-keystone | 14:05 | |
*** edmondsw has joined #openstack-keystone | 15:10 | |
*** edmondsw has quit IRC | 15:15 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Address minor comments from initial implementation https://review.openstack.org/579342 | 15:19 |
*** tobberydberg has quit IRC | 15:19 | |
kmalloc | knikolla: ^ plus answered comments. a system-scope enforcement should be added. I'd like to do that as a separate patch. | 15:20 |
*** tobberydberg has joined #openstack-keystone | 15:20 | |
knikolla | kmalloc: i'm still not sold on the 40x, but i defer to you | 15:24 |
*** dklyle has quit IRC | 15:27 | |
*** dklyle has joined #openstack-keystone | 15:27 | |
knikolla | kmalloc: since having po policy rule assigned to a router does mean we screwed up. and to fix it we need to change a 40x to a 20x (which api guidelines don't like that much) | 15:28 |
knikolla | route* | 15:28 |
kmalloc | you should never be avle to land there | 15:29 |
kmalloc | because we check that enforce_call was made with asserts | 15:29 |
kmalloc | in flask, this is suspenders and a belt to throw an error early | 15:29 |
kmalloc | it's mostly for development purposes. if we ever end up with an API that throws that, we're in a worse place than expected. | 15:30 |
kmalloc | look at the next patch to see how we're doing enforcement checks with the before/after methods. | 15:30 |
kmalloc | if you really feel strongly, i'm happy to make it a straight valueerror which will 50 | 15:31 |
kmalloc | 500 | 15:31 |
kmalloc | i just feel like explicitly writing a 500 error in enforcement code is the wrong approach | 15:31 |
kmalloc | [and without that check, it would be a 403 anyway via the policy enforcer (oslo_policy) | 15:31 |
kmalloc | if you enforce on a non-existant rule it turns into a 403 | 15:32 |
knikolla | kmalloc: hmm... | 15:32 |
kmalloc | so i'm just catching the error case and short circuiting before we do lots of processing | 15:32 |
knikolla | kmalloc: i don't feel strongly, so take my +2/+A | 15:33 |
kmalloc | :) | 15:33 |
kmalloc | wfm. | 15:33 |
*** fiddletwix has quit IRC | 16:17 | |
*** sonuk_ has joined #openstack-keystone | 16:29 | |
*** sonuk has quit IRC | 16:32 | |
*** sonuk has joined #openstack-keystone | 16:45 | |
*** sonuk_ has quit IRC | 16:47 | |
*** edmondsw has joined #openstack-keystone | 16:59 | |
*** edmondsw has quit IRC | 17:03 | |
*** eEbx has quit IRC | 17:30 | |
*** eEbx has joined #openstack-keystone | 17:31 | |
*** peereb has quit IRC | 17:59 | |
*** edmondsw has joined #openstack-keystone | 18:47 | |
*** edmondsw has quit IRC | 18:52 | |
*** efried has quit IRC | 19:51 | |
*** edmondsw has joined #openstack-keystone | 20:35 | |
*** edmondsw has quit IRC | 20:40 | |
*** dklyle has quit IRC | 21:24 | |
*** dklyle has joined #openstack-keystone | 21:25 | |
*** martinus__ has quit IRC | 21:33 | |
*** edmondsw has joined #openstack-keystone | 22:23 | |
*** edmondsw has quit IRC | 22:28 | |
openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Address minor comments from initial implementation https://review.openstack.org/579342 | 23:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!