| *** lifeless has quit IRC | 00:09 | |
| *** r-daneel has joined #openstack-keystone | 00:23 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 00:31 | |
| *** jmlowe has joined #openstack-keystone | 00:41 | |
| *** devx has quit IRC | 00:59 | |
| *** devx has joined #openstack-keystone | 01:00 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Implement scaffolding for Flask-RESTful use https://review.openstack.org/574415 | 01:06 |
|---|---|---|
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Keystone adheres to public_endpoint opt only https://review.openstack.org/574502 | 01:06 |
| *** gyee has quit IRC | 01:07 | |
| *** dave-mccowan has quit IRC | 01:30 | |
| *** sapd has quit IRC | 01:40 | |
| *** lifeless has joined #openstack-keystone | 01:41 | |
| *** sapd has joined #openstack-keystone | 01:44 | |
| *** annp has joined #openstack-keystone | 01:47 | |
| *** felipemonteiro has joined #openstack-keystone | 02:17 | |
| *** lifeless has quit IRC | 02:32 | |
| *** lifeless has joined #openstack-keystone | 02:33 | |
| *** rcernin is now known as rcernin|lunch | 02:35 | |
| *** dave-mccowan has joined #openstack-keystone | 02:52 | |
| *** agrebennikov has quit IRC | 03:02 | |
| *** sheel has joined #openstack-keystone | 03:07 | |
| *** itlinux has joined #openstack-keystone | 03:15 | |
| *** felipemonteiro has quit IRC | 03:44 | |
| *** dave-mccowan has quit IRC | 04:05 | |
| *** jmlowe has quit IRC | 04:10 | |
| *** germs has quit IRC | 04:13 | |
| *** itlinux has quit IRC | 04:19 | |
| *** felipemonteiro has joined #openstack-keystone | 04:27 | |
| *** germs has joined #openstack-keystone | 04:34 | |
| *** germs has quit IRC | 04:34 | |
| *** germs has joined #openstack-keystone | 04:34 | |
| *** germs has quit IRC | 04:37 | |
| *** Dinesh_Bhor has quit IRC | 05:01 | |
| *** mvk has joined #openstack-keystone | 05:03 | |
| *** Dinesh_Bhor has joined #openstack-keystone | 05:04 | |
| *** pcaruana has quit IRC | 05:24 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 05:39 | |
| *** Alexey_Abashkin has joined #openstack-keystone | 05:42 | |
| *** Alexey_Abashkin has quit IRC | 05:42 | |
| *** Alexey_Abashkin has joined #openstack-keystone | 05:42 | |
| *** AlexeyAbashkin has quit IRC | 05:43 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 05:43 | |
| *** AlexeyAbashkin has quit IRC | 05:45 | |
| *** zzzeek has quit IRC | 05:54 | |
| *** zzzeek has joined #openstack-keystone | 05:58 | |
| *** mvk has quit IRC | 06:05 | |
| *** felipemonteiro has quit IRC | 06:06 | |
| *** Dinesh__Bhor has joined #openstack-keystone | 06:10 | |
| *** Dinesh_Bhor has quit IRC | 06:11 | |
| *** dklyle has quit IRC | 06:18 | |
| *** dklyle has joined #openstack-keystone | 06:18 | |
| *** david-lyle has joined #openstack-keystone | 06:20 | |
| *** dklyle has quit IRC | 06:23 | |
| *** pcaruana has joined #openstack-keystone | 06:27 | |
| *** liuzz has joined #openstack-keystone | 06:29 | |
| *** david-lyle has quit IRC | 06:32 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 06:42 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: [WIP] Strict two level hierarchical limit https://review.openstack.org/557696 | 06:53 |
| *** martinus__ has joined #openstack-keystone | 06:56 | |
| *** hoonetorg has quit IRC | 07:01 | |
| *** AlexeyAbashkin has quit IRC | 07:04 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 07:10 | |
| *** rcernin|lunch has quit IRC | 07:13 | |
| *** ykarel has joined #openstack-keystone | 07:15 | |
| *** dklyle has joined #openstack-keystone | 07:28 | |
| openstackgerrit | zhongshengping proposed openstack/keystone master: Add release notes link to README https://review.openstack.org/574612 | 07:31 |
| *** redrobot has quit IRC | 07:33 | |
| *** pcaruana has quit IRC | 07:34 | |
| openstackgerrit | Merged openstack/keystone-specs master: Address follow-on comments in strict-two-level spec https://review.openstack.org/573292 | 07:36 |
| *** lifeless has quit IRC | 07:39 | |
| *** lifeless has joined #openstack-keystone | 07:39 | |
| *** redrobot has joined #openstack-keystone | 07:39 | |
| *** hoonetorg has joined #openstack-keystone | 07:40 | |
| *** pcaruana has joined #openstack-keystone | 07:49 | |
| *** pcaruana has quit IRC | 07:59 | |
| *** pcaruana has joined #openstack-keystone | 08:15 | |
| *** ykarel_ has joined #openstack-keystone | 08:21 | |
| *** ykarel has quit IRC | 08:23 | |
| openstackgerrit | XiaojueGuan proposed openstack/keystone-specs master: Update links in README https://review.openstack.org/574637 | 08:25 |
| *** ykarel_ is now known as ykarel | 08:28 | |
| *** gagehugo_ has joined #openstack-keystone | 08:31 | |
| *** gagehugo has quit IRC | 08:32 | |
| ykarel | Hi, anyone can guide with the flaskification change in keystone:- https://review.openstack.org/#/c/572827/4/releasenotes/notes/convert-keystone-to-flask-80d980e239b662b0.yaml | 08:36 |
| ykarel | i am seeing that latest_app is None(should be updated with load_app) after changing to flask:- https://github.com/openstack/keystone/blob/master/keystone/version/controllers.py#L29-L35 | 08:39 |
| *** xinran__ has joined #openstack-keystone | 08:41 | |
| *** AlexeyAbashkin has quit IRC | 08:54 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 08:58 | |
| *** nicolasbock has joined #openstack-keystone | 09:18 | |
| *** m3m0 has joined #openstack-keystone | 09:27 | |
| m3m0 | hello everyone, is it possible to define my projects and roles in openldap and be read by keystone? without creating them manually in openstack? | 09:27 |
| *** nicolasbock has quit IRC | 09:37 | |
| *** Alexey_Abashkin has joined #openstack-keystone | 09:40 | |
| *** AlexeyAbashkin has quit IRC | 09:40 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 09:40 | |
| *** Haradani has joined #openstack-keystone | 09:41 | |
| *** Haradani has left #openstack-keystone | 09:41 | |
| *** Dinesh__Bhor has quit IRC | 09:53 | |
| *** lifeless has quit IRC | 09:59 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Strict two level hierarchical limit https://review.openstack.org/557696 | 10:01 |
| ykarel | so my quenstion for flask keystone, it looks like it's not working with unversioned keystone url | 10:12 |
| ykarel | can someone please check | 10:12 |
| *** annp has quit IRC | 10:22 | |
| *** AlexeyAbashkin has quit IRC | 10:28 | |
| *** xinran__ has quit IRC | 10:48 | |
| *** lifeless has joined #openstack-keystone | 11:03 | |
| *** lifeless has quit IRC | 11:13 | |
| *** lifeless has joined #openstack-keystone | 11:13 | |
| *** nicolasbock has joined #openstack-keystone | 11:33 | |
| openstackgerrit | chenxiangui proposed openstack/keystone master: Add release notes link to README https://review.openstack.org/574700 | 11:39 |
| *** AlexeyAbashkin has joined #openstack-keystone | 11:45 | |
| *** Alexey_Abashkin has joined #openstack-keystone | 11:48 | |
| *** AlexeyAbashkin has quit IRC | 11:50 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 11:50 | |
| *** AlexeyAbashkin has quit IRC | 11:52 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 11:53 | |
| *** raildo has joined #openstack-keystone | 11:54 | |
| *** anurag has joined #openstack-keystone | 11:56 | |
| anurag | hi | 12:00 |
| *** dave-mccowan has joined #openstack-keystone | 12:03 | |
| *** edmondsw has joined #openstack-keystone | 12:03 | |
| *** anurag has quit IRC | 12:07 | |
| *** cristicalin has joined #openstack-keystone | 12:09 | |
| openstackgerrit | wangxiyuan proposed openstack/keystone master: Strict two level hierarchical limit https://review.openstack.org/557696 | 12:17 |
| *** ykarel_ has joined #openstack-keystone | 12:21 | |
| *** ykarel has quit IRC | 12:24 | |
| *** r-daneel has quit IRC | 12:25 | |
| *** ykarel_ is now known as ykarel | 12:26 | |
| *** r-daneel has joined #openstack-keystone | 12:40 | |
| knikolla[m] | Bah, subway is broken today | 12:53 |
| *** raildo has quit IRC | 12:53 | |
| *** raildo has joined #openstack-keystone | 12:55 | |
| *** pcaruana has quit IRC | 13:00 | |
| *** kman has joined #openstack-keystone | 13:16 | |
| *** cristicalin has quit IRC | 13:19 | |
| *** felipemonteiro_ has joined #openstack-keystone | 13:23 | |
| *** AlexeyAbashkin has quit IRC | 13:24 | |
| *** felipemonteiro has joined #openstack-keystone | 13:25 | |
| *** felipemonteiro has quit IRC | 13:27 | |
| *** felipemonteiro_ has quit IRC | 13:29 | |
| jaosorior | lbragstad: could I get a review for this if you have time https://review.openstack.org/#/c/572243/ ? | 13:32 |
| *** AlexeyAbashkin has joined #openstack-keystone | 13:32 | |
| *** r-daneel has quit IRC | 13:41 | |
| *** pcaruana has joined #openstack-keystone | 13:46 | |
| *** sheel has quit IRC | 13:47 | |
| lbragstad | jaosorior: sure | 13:48 |
| lbragstad | ykarel: do you have steps to reproduce the issue? | 13:53 |
| ykarel | lbragstad, facing it in tripleo jobs, may be devstack is also affected:- python -c "import requests,json;r=requests.get('http://<ip>:5000',verify=False,headers={'Accept': 'application/json-home'});print(r.content)" | 13:56 |
| ykarel | lbragstad, ^^ fails | 13:56 |
| ykarel | and this pass:- python -c "import requests,json;r=requests.get('http://<ip>:5000/v3',verify=False,headers={'Accept': 'application/json-home'});print(r.content)" | 13:56 |
| lbragstad | ok - let me try that quick and see if it fails for me | 13:57 |
| ykarel | in devstack keystone logs also i can see // is appended in the keystone service url, so may be issue can be reproduced there as well | 13:57 |
| ykarel | lbragstad, okk let me know | 13:58 |
| kmalloc | lbragstad: ugh, '//' issue, that might be my fault | 13:58 |
| ykarel | kmalloc, ahh i was looking for you with other nicks :) | 13:59 |
| lbragstad | is this the error you're seeing? | 14:00 |
| lbragstad | http://paste.openstack.org/show/723311/ | 14:00 |
| ykarel | lbragstad, no | 14:01 |
| ykarel | may be u are running behind apache | 14:01 |
| lbragstad | i am | 14:01 |
| lbragstad | it's a devstack deploy | 14:01 |
| ykarel | so try: http://192.168.1.5/identity | 14:01 |
| lbragstad | http://paste.openstack.org/show/723312/ | 14:02 |
| ykarel | so it's working in devstack | 14:03 |
| ykarel | lbragstad, can you check keystone log | 14:03 |
| lbragstad | sure | 14:04 |
| *** r-daneel has joined #openstack-keystone | 14:04 | |
| lbragstad | http://paste.openstack.org/show/723313/ | 14:05 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Implement scaffolding for Flask-RESTful use https://review.openstack.org/574415 | 14:05 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Keystone adheres to public_endpoint opt only https://review.openstack.org/574502 | 14:05 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Store JSON Home Resources off the composing router https://review.openstack.org/574735 | 14:05 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: [WIP] Convert json_home and version discovery to Flask https://review.openstack.org/574736 | 14:05 |
| kmalloc | ykarel: is that an old devstack or a clean run? | 14:07 |
| * lbragstad just ran devstack yesterday on a clean run | 14:08 | |
| kmalloc | ok | 14:08 |
| *** r-daneel_ has joined #openstack-keystone | 14:08 | |
| ykarel | kmalloc, lbragstad i am seeing http://paste.openstack.org/show/723314/ in a clean tripleo deployment | 14:08 |
| kmalloc | hm. | 14:08 |
| *** r-daneel has quit IRC | 14:08 | |
| *** r-daneel_ is now known as r-daneel | 14:08 | |
| kmalloc | what is the exception that is causing the 500? | 14:09 |
| kmalloc | we should never issue a 500 without a corresponding exception being raised. | 14:09 |
| ykarel | kmalloc, https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-ci-centos-7-multinode-1ctlr-featureset030-master/fbc106b/subnode-2/var/log/containers/keystone/keystone.log.txt.gz#_2018-06-11_20_16_29_824 | 14:10 |
| lbragstad | looks like a couple of // are on the end of the url | 14:11 |
| kmalloc | yeah. | 14:11 |
| kmalloc | and that might be the dispatching middleware doing something wonky | 14:11 |
| lbragstad | does apache do something different with that? | 14:11 |
| kmalloc | well, not really, what is happening is that keystone does a stupid thing | 14:11 |
| kmalloc | when you get the root / JSON HOME page, what it is actually doing is internally making a sub request to /v3 for the JSON Home page then re-writing the document | 14:12 |
| kmalloc | after deserializing the internal sub-request and then reserializing it. | 14:12 |
| kmalloc | lbragstad: https://github.com/openstack/keystone/blob/master/keystone/version/controllers.py#L38-L49 | 14:13 |
| kmalloc | so... if we're getting an extra "/" passed through in that method, we are probably not getting real json_home data back | 14:14 |
| kmalloc | which then fails when we try to loads/other stuff | 14:14 |
| kmalloc | it's a VERY dumb way of doing things, but it "works" most of the time. | 14:14 |
| ykarel | kmalloc, also i noted that ^^ , latest_app=None | 14:14 |
| lbragstad | hmm | 14:14 |
| kmalloc | ykarel: latest_app=None should be fine. | 14:14 |
| kmalloc | that is magic for unit tests. | 14:14 |
| ykarel | kmalloc, ack | 14:15 |
| ykarel | kmalloc, in reno you mentioned deployments will need new wsgi scripts, what that mean | 14:15 |
| kmalloc | you'll need to re-generate the WSGI scripts to startup the keystone service | 14:15 |
| kmalloc | since we changes how we load things | 14:15 |
| kmalloc | we don't use paste-ini | 14:15 |
| kmalloc | if keystone is starting, you have nothing to worry about | 14:16 |
| kmalloc | but it is intended to warn people who may have crafted their own wsgi scripts | 14:16 |
| kmalloc | basically, sdist install will generate the right things, but if you don't use the new things it might be broken-ish. | 14:16 |
| kmalloc | ykarel: i'm guessing that i will have this 100% fixed by https://review.openstack.org/#/c/574736/ this point | 14:17 |
| ykarel | kmalloc, we use from sdist, and currently have this:- http://paste.openstack.org/show/723316/ | 14:17 |
| kmalloc | yep | 14:17 |
| kmalloc | you're good | 14:17 |
| kmalloc | really, if you are using from sdist and make sure to grab the most current one, you'll not be broken :) | 14:18 |
| kmalloc | [basically, if keystone starts and runs, you're fine) | 14:18 |
| kmalloc | lbragstad: so. i know exactly what the issue is. do you want me to spin an explicit fix or should i push on the move discovery to keystone.api | 14:18 |
| kmalloc | i am maybe ~20lines of code away from that working. | 14:19 |
| lbragstad | if we're close with the rest of the keystone.api bits | 14:19 |
| ykarel | kmalloc, we are using latest commit from keystone | 14:19 |
| kmalloc | lbragstad: see https://review.openstack.org/#/c/574736/ | 14:20 |
| lbragstad | otherwise i feel compelled to pull it into a new patch we can fast track since people are broken | 14:20 |
| kmalloc | really, i just need to make that load and rip out some dispatcher code. | 14:20 |
| kmalloc | lbragstad: it's under a chain though | 14:20 |
| kmalloc | realistically i could make https://review.openstack.org/#/c/574735/1 do the work for me. | 14:21 |
| ykarel | kmalloc, ok trying your patch:- https://review.openstack.org/#/c/574736/ | 14:21 |
| kmalloc | ykarel: it wont work yet ;) | 14:21 |
| ykarel | ohhk | 14:21 |
| kmalloc | ykarel: needs to actually use the new mechanism, hence the [WIP]. | 14:21 |
| kmalloc | :) the discovery move was a lot more work because JSON Home is ... magical | 14:21 |
| ykarel | :) have fun | 14:21 |
| ykarel | kmalloc, lbragstad what's the recommended way: use unversioned of versioned url for keystone? | 14:22 |
| kmalloc | pref. unversioned | 14:22 |
| ykarel | of/or | 14:22 |
| kmalloc | but that sometimes gets wonky | 14:22 |
| ykarel | okk, hmm as in our case versioned work is working fine | 14:23 |
| ykarel | but unversioned one has issues | 14:23 |
| kmalloc | right, that is a bug, but unversioned should just work | 14:23 |
| kmalloc | in your case as well | 14:23 |
| kmalloc | let me try and fix this quickly so you can try. | 14:23 |
| ykarel | okk | 14:23 |
| ykarel | hmm would be good as otherwise we have to go with the versioned workaround | 14:24 |
| kmalloc | really, this should be fixed pretty quickly. | 14:25 |
| kmalloc | :) | 14:25 |
| kmalloc | i happen to already be working in this part of keystone | 14:26 |
| kmalloc | lbragstad: ugh, the test output is terrible on test_versions | 14:32 |
| *** dave-mccowan has quit IRC | 14:35 | |
| *** kman has quit IRC | 14:45 | |
| knikolla | anything i should be looking at / reviewing? | 14:46 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Store JSON Home Resources off the composing router https://review.openstack.org/574735 | 14:46 |
| kmalloc | ykarel: ^ try that one. | 14:46 |
| kmalloc | lbragstad: ^ | 14:46 |
| ykarel | kmalloc, trying | 14:46 |
| *** codebot_ has joined #openstack-keystone | 14:47 | |
| kmalloc | You prob need the preceesing patches as well. | 14:48 |
| kmalloc | But those are low impact. Not sure how clean a cherry pick that is in isolation. | 14:48 |
| codebot_ | Hi I am new to openstack, I have setup a devstack pike environment | 14:48 |
| codebot_ | Going through keystone | 14:48 |
| kmalloc | lbragstad: ^ cc | 14:49 |
| codebot_ | but in my system /var/log doesn`t contains keystone.log file | 14:49 |
| codebot_ | any help is appreciated | 14:49 |
| kmalloc | ykarel: it doesn't solve the root issue, it just makes the bug go away, since we aren't doing the dumb internal request. | 14:50 |
| codebot_ | keystone.log file is not generating, how to do that ? HELP | 14:51 |
| codebot_ | Hello there? | 14:54 |
| *** mordred has quit IRC | 14:55 | |
| lbragstad | codebot_: how are you running keystone? | 14:56 |
| ykarel | kmalloc, the patch is working, i just tried:- python -c "import requests,json;r=requests.get('http://192.168.24.1:5000',verify=False,headers={'Accept': 'application/json-home'});print(r.content)" | 14:56 |
| ykarel | kmalloc, ack for not fixing the root cause. so your WIP would bring the real fix? | 14:57 |
| *** jmlowe has joined #openstack-keystone | 14:57 | |
| *** spilla has joined #openstack-keystone | 15:00 | |
| *** m3m0 has quit IRC | 15:02 | |
| *** dave-mccowan has joined #openstack-keystone | 15:03 | |
| kmalloc | Yes | 15:03 |
| kmalloc | Because I am then removing the router dispatching middleware causing the issue for the / and /v3 Json home. | 15:04 |
| codebot_ | @lbragstad it a devstack environment | 15:06 |
| hrybacki | kmalloc: o/ https://bluejeans.com/u/hrybacki/ | 15:06 |
| *** wxy| has joined #openstack-keystone | 15:07 | |
| *** codebot_ has quit IRC | 15:07 | |
| *** mordred has joined #openstack-keystone | 15:08 | |
| lbragstad | codebot_ https://docs.openstack.org/devstack/latest/systemd.html#querying-logs | 15:08 |
| ykarel | kmalloc, Ok Thanks | 15:11 |
| kmalloc | ykarel: the fix i provided is part of the chain in either case | 15:13 |
| kmalloc | i just accelerated it for getting you unblocked | 15:13 |
| ykarel | kmalloc, Thanks waiting it to get merged | 15:13 |
| kmalloc | knikolla: https://review.openstack.org/#/c/574735/ | 15:14 |
| kmalloc | knikolla: since that and the preceeding patches unblock ykarel | 15:15 |
| knikolla | kmalloc: looking | 15:16 |
| kmalloc | knikolla: it probably needs some extra testing. but please let me know what is needed so i can get it landed. | 15:18 |
| *** ykarel is now known as ykarel|away | 15:22 | |
| ildikov | knikolla: kmalloc: lbragstad: hi :) | 15:26 |
| kmalloc | ildikov: allo therE! :) | 15:26 |
| ildikov | And cmurphy :) | 15:26 |
| knikolla | o/ | 15:26 |
| kmalloc | ildikov: meeting? | 15:26 |
| ildikov | Tomorrow at 1300UTC there's an OPNFV Edge Cloud call where they would like to chat about test scenarios for Keystone among other topics | 15:27 |
| ildikov | Would either of you be available to dial in? | 15:28 |
| knikolla | i can't make it. | 15:28 |
| kmalloc | i don't think i can make it. but i'll 2x check when done with this meeting | 15:29 |
| *** fiddletwix has quit IRC | 15:29 | |
| ildikov | Sorry for the last minute heads up :( | 15:29 |
| kmalloc | i'll see if i can make it. | 15:29 |
| ildikov | I will send out a Doodle poll if no one is able to make it to have a separate meeting | 15:30 |
| kmalloc | is this going to be on zoom.us or some other system? | 15:30 |
| ildikov | Plz lemme know :) | 15:30 |
| kmalloc | i had issues dialing into the zoom thing last time. | 15:30 |
| ildikov | kmalloc: Zoom | 15:31 |
| kmalloc | =/ | 15:31 |
| * kmalloc really hates having to install a separate client to make it work. | 15:31 | |
| *** fiddletwix has joined #openstack-keystone | 15:31 | |
| ildikov | kmalloc: there should be dial-in numbers if you don't want to install new stuff on your laptop | 15:31 |
| lbragstad | hrybacki: do you have a link to the default roles reviews? | 15:31 |
| hrybacki | lbragstad: https://review.openstack.org/#/c/572243/ main review | 15:32 |
| hrybacki | all reviews: https://trello.com/c/sTBxkSDs/40-implement-default-roles | 15:32 |
| ildikov | kmalloc: I hear ya... | 15:32 |
| lbragstad | sweet | 15:33 |
| cmurphy | ildikov: i think i can make it | 15:35 |
| ildikov | cmurphy: great, thanks! | 15:36 |
| ildikov | cmurphy: I will look up the wiki with the meeting details | 15:36 |
| ildikov | cmurphy: do you need a meeting invite too? | 15:36 |
| cmurphy | ildikov: that would help me remember | 15:37 |
| cmurphy | ildikov: colleen@gazlene.net | 15:37 |
| ildikov | cmurphy: will send it once I'm back to my laptop! | 15:37 |
| cmurphy | ildikov: tyty | 15:38 |
| ildikov | cmurphy: me thanks :) | 15:38 |
| *** liuzz_ has joined #openstack-keystone | 15:39 | |
| *** liuzz has quit IRC | 15:42 | |
| *** gyee has joined #openstack-keystone | 15:47 | |
| *** mordred has quit IRC | 15:48 | |
| *** itlinux has joined #openstack-keystone | 15:48 | |
| *** mordred has joined #openstack-keystone | 15:52 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Add Flask-RESTful as a requirement https://review.openstack.org/574414 | 15:52 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Implement scaffolding for Flask-RESTful use https://review.openstack.org/574415 | 15:52 |
| openstackgerrit | Eric Fried proposed openstack/keystoneauth master: raise_exc default in Adapter https://review.openstack.org/574784 | 15:52 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Keystone adheres to public_endpoint opt only https://review.openstack.org/574502 | 15:52 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Store JSON Home Resources off the composing router https://review.openstack.org/574735 | 15:53 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: [WIP] Convert json_home and version discovery to Flask https://review.openstack.org/574736 | 15:54 |
| *** AlexeyAbashkin has quit IRC | 15:57 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Store JSON Home Resources off the composing router https://review.openstack.org/574735 | 15:57 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Store JSON Home Resources off the composing router https://review.openstack.org/574735 | 16:00 |
| *** AlexeyAbashkin has joined #openstack-keystone | 16:01 | |
| *** hoonetorg has quit IRC | 16:02 | |
| kmalloc | ykarel|away: https://bugs.launchpad.net/keystone/+bug/1776506 | 16:06 |
| openstack | Launchpad bug 1776506 in OpenStack Identity (keystone) "Keystone JSON HOME on / fails" [High,In progress] - Assigned to Morgan Fainberg (mdrnstm) | 16:06 |
| *** knikolla[m] has quit IRC | 16:08 | |
| *** lbragstad[m] has quit IRC | 16:08 | |
| *** gagehugo_ is now known as gagehugo | 16:09 | |
| *** trident has quit IRC | 16:11 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: [WIP] Convert json_home and version discovery to Flask https://review.openstack.org/574736 | 16:13 |
| *** jmlowe has quit IRC | 16:13 | |
| *** trident has joined #openstack-keystone | 16:13 | |
| *** Kumar has joined #openstack-keystone | 16:14 | |
| *** ykarel_ has joined #openstack-keystone | 16:22 | |
| *** hoonetorg has joined #openstack-keystone | 16:23 | |
| *** dave-mccowan has quit IRC | 16:23 | |
| *** ykarel|away has quit IRC | 16:24 | |
| *** lbragstad[m] has joined #openstack-keystone | 16:33 | |
| *** Alexey_Abashkin has joined #openstack-keystone | 16:33 | |
| *** Alexey_Abashkin has quit IRC | 16:35 | |
| *** AlexeyAbashkin has quit IRC | 16:35 | |
| *** Sundar has joined #openstack-keystone | 16:37 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Keystone adheres to public_endpoint opt only https://review.openstack.org/574502 | 16:39 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Store JSON Home Resources off the composing router https://review.openstack.org/574735 | 16:39 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: [WIP] Convert json_home and version discovery to Flask https://review.openstack.org/574736 | 16:40 |
| Sundar | Hello, I am hitting an 'Internal Server Error" in keystone in response to "GET http://172.25.112.34/identity/v3/auth/tokens", when deploying with devstack. This same deployment was working until 2 days ago, but is failing after a unstack and running stack.sh again. | 16:42 |
| Sundar | Would anybody here have any tips? | 16:42 |
| lbragstad | Sundar: do you have logs? | 16:42 |
| lbragstad | Sundar: or a trace? | 16:43 |
| kmalloc | unstack/restack is not really that reliable | 16:45 |
| *** knikolla[m] has joined #openstack-keystone | 16:46 | |
| kmalloc | it's a best effort and may sometimes result in an unusable system | 16:46 |
| knikolla | sometimes clean helps | 16:46 |
| kmalloc | that said, a trace/logs may help us identify | 16:46 |
| kmalloc | I always recommend a clean devstack if possible. | 16:46 |
| kmalloc | knikolla: sorry you had to look at the composible router things | 16:47 |
| kmalloc | knikolla: it... makes my head hurt, and i'm working in that section of keystone a lot right now | 16:47 |
| *** germs has joined #openstack-keystone | 16:47 | |
| *** germs has quit IRC | 16:47 | |
| *** germs has joined #openstack-keystone | 16:47 | |
| Sundar | kmalloc: yes, I have done many clean.sh runs, reboots and such | 16:47 |
| Sundar | lbragstad: yes, I do have logs. It came down to a single failure: | 16:47 |
| Sundar | "openstack project show admin -f value -c id" triggers the error every time | 16:48 |
| ykarel_ | kmalloc, ack | 16:48 |
| kmalloc | Sundar: and in the keystone log, what is the traceback? | 16:48 |
| lbragstad | Sundar: check the keystone logs - that command is trying to use keystone and probably isn't the actual cause of the failure | 16:48 |
| lbragstad | `sudo journalctl -f -a --unit devstack@keystone.service` | 16:49 |
| knikolla | kmalloc: i've seen worse. i'm usually guilty myself of overengineering. | 16:49 |
| kmalloc | lbragstad: hehe, journalctl *sigh* | 16:49 |
| *** wxy| has quit IRC | 16:49 | |
| kmalloc | knikolla: there is a lot of history of "oh we'll just add X on top of this" going on in this code | 16:49 |
| kmalloc | i don't think it really was "engineered" | 16:49 |
| kmalloc | ;) | 16:50 |
| * kmalloc gets the machete out and starts hacking away at the jungle that has "grown" out of keystone's WSGI layer | 16:50 | |
| Sundar | lbragstad: Thanks. Here's the keystone log: | 16:50 |
| Sundar | Jun 12 21:41:49 otcfpga1.sc.intel.com devstack@keystone.service[12443]: ERROR keystone.common.wsgi request.set_user_headers(request.token_auth.user) Jun 12 21:41:49 otcfpga1.sc.intel.com devstack@keystone.service[12443]: ERROR keystone.common.wsgi File "/usr/lib/python2.7/site-packages/keystonemiddleware/auth_token/_request.py", line 176, in set_user_headers Jun 12 21:41:49 otcfpga1.sc.intel.com devstack@keystone.serv | 16:50 |
| knikolla | kmalloc: ha! actually that makes sense. I'm not sure you'd end up with three classes called Router if they were written in the same week/month. | 16:51 |
| kmalloc | Sundar: i recomment using paste.openstack.org, that looks truncated. | 16:51 |
| lbragstad | Sundar: you can use http://paste.openstack.org/ and that'll be easier than pasting into irc | 16:51 |
| kmalloc | lbragstad: :) | 16:51 |
| * knikolla grabbing lunch. I'll be here for office hours since Tuesday is my keystone day. | 16:52 | |
| kmalloc | knikolla: and Router, RouterBase, ComposingRouter, ComposibleRouter... | 16:52 |
| knikolla | kmalloc: brings back my Java days. | 16:52 |
| kmalloc | knikolla: you have no idea how many times ComposingRouter and ComposibleRouter has bitten me in this refactor | 16:53 |
| Sundar | lbragstad: Sure. Please see http://paste.openstack.org/show/723329/ | 16:53 |
| lbragstad | Sundar: you need to update keystonemiddleware | 16:54 |
| lbragstad | actually - you need to update keystoneauth | 16:54 |
| Sundar | lbragstad: Basic question: shouldn't devstack do that automatically? | 16:54 |
| lbragstad | it depends on how you have it configured | 16:55 |
| lbragstad | devstack can reclone repositories for you if you tell it to | 16:55 |
| lbragstad | but by default it doesn't | 16:55 |
| Sundar | Apart from PIP_UPGRADE=true, do I need to set anything else? | 16:55 |
| *** ykarel_ is now known as ykarel|away | 16:56 | |
| lbragstad | it depends on how you manage those repositories, if you're using devstack to do it, then you can set RECLONE=true | 16:56 |
| lbragstad | or you can do it manually | 16:56 |
| lbragstad | #startmeeting keystone-office-hours | 16:58 |
| openstack | Meeting started Tue Jun 12 16:58:19 2018 UTC and is due to finish in 60 minutes. The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:58 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:58 |
| openstack | The meeting name has been set to 'keystone_office_hours' | 16:58 |
| kmalloc | Sundar: this is why i recommend a totally fresh devstack when possible (not just clean.sh) - this is one of those cases where devstack's cleanup is just not 100% and causes odd errors. | 16:58 |
| kmalloc | the best bet when you're struggling is RECLONE=true or start fresh and see if it continues, especially if you've done a number of stack/unstack/stack cycles | 16:59 |
| kmalloc | lbragstad: omg MORE COFFEE. | 16:59 |
| *** hoonetorg has quit IRC | 17:03 | |
| Sundar | lbragstad: Thank you very much. I will re-install devstack with RECLONE=true. | 17:04 |
| *** ykarel|away has quit IRC | 17:05 | |
| *** r-daneel_ has joined #openstack-keystone | 17:05 | |
| *** r-daneel has quit IRC | 17:06 | |
| *** r-daneel_ is now known as r-daneel | 17:06 | |
| kmalloc | Sundar: good luck, let us know if you're still having issues after that | 17:09 |
| *** hoonetorg has joined #openstack-keystone | 17:10 | |
| *** lifeless_ has joined #openstack-keystone | 17:15 | |
| *** lifeless has quit IRC | 17:16 | |
| kmalloc | lbragstad: did the KSA release happen yet? | 17:17 |
| kmalloc | lbragstad: if not, we should include https://review.openstack.org/#/c/574784/ | 17:17 |
| lbragstad | kmalloc: https://review.openstack.org/#/c/574337/ | 17:18 |
| lbragstad | it did | 17:18 |
| kmalloc | lbragstad: if it did, we should release with that once it lands | 17:18 |
| lbragstad | sure - i can keep tabs on it | 17:18 |
| kmalloc | cool. | 17:18 |
| kmalloc | ok let me get back to this flaskification stuff. | 17:18 |
| *** hoonetorg has quit IRC | 17:19 | |
| kmalloc | so i can get the root stuff moved to Flask Native and drop some of the icky dispatch code. | 17:19 |
| Sundar | kmalloc: Thanks very much! I will ping back if needed -- hopefully there won't be a need. :) | 17:20 |
| *** hoonetorg has joined #openstack-keystone | 17:28 | |
| *** felipemonteiro has joined #openstack-keystone | 17:30 | |
| kmalloc | lbragstad: omg, about to post first actual move to flask api bit | 17:41 |
| kmalloc | woooooooo | 17:41 |
| *** bhagyashri_s has joined #openstack-keystone | 17:45 | |
| *** hoonetorg has quit IRC | 17:47 | |
| *** hoonetorg has joined #openstack-keystone | 17:48 | |
| *** bhagyashris_ has quit IRC | 17:48 | |
| *** hoonetorg has quit IRC | 17:58 | |
| Sundar | Hi, A cleandevstack install failed too. But not sure if this is Cinder or Keystone. Please see https://drive.google.com/file/d/19EncNpjzW_RflRn1zj_iu6hqDvoyuQ9m/view?usp=sharing | 17:59 |
| *** felipemonteiro has quit IRC | 17:59 | |
| *** spilla has quit IRC | 18:00 | |
| lbragstad | that looks like a cinder-specific issue | 18:09 |
| lbragstad | cinder providers an option that allows you to deploy it with and without a dependency on keystone | 18:09 |
| lbragstad | are you able to dig into the logs and see why it failed? | 18:10 |
| *** hoonetorg has joined #openstack-keystone | 18:16 | |
| *** r-daneel has quit IRC | 18:16 | |
| *** hoonetorg has quit IRC | 18:21 | |
| *** spzala has joined #openstack-keystone | 18:22 | |
| *** spzala has quit IRC | 18:22 | |
| *** Kumar has quit IRC | 18:26 | |
| *** felipemonteiro has joined #openstack-keystone | 18:28 | |
| *** dave-mccowan has joined #openstack-keystone | 18:30 | |
| *** hoonetorg has joined #openstack-keystone | 18:38 | |
| *** hoonetorg has quit IRC | 18:45 | |
| *** dave-mccowan has quit IRC | 18:47 | |
| *** hoonetorg has joined #openstack-keystone | 18:52 | |
| *** itlinux has quit IRC | 18:54 | |
| openstackgerrit | Lance Bragstad proposed openstack/python-keystoneclient master: Add support for registered limits https://review.openstack.org/537668 | 18:57 |
| openstackgerrit | Lance Bragstad proposed openstack/python-keystoneclient master: Add support for project-specific limits https://review.openstack.org/574391 | 18:57 |
| *** hoonetorg has quit IRC | 18:58 | |
| *** felipemonteiro has quit IRC | 19:02 | |
| lbragstad | knikolla: thanks for the review on the unified limit client patches | 19:06 |
| lbragstad | posted some newer versions | 19:06 |
| knikolla | lbragstad: was just looking at the new ones now :) | 19:06 |
| lbragstad | you're the man knikolla | 19:07 |
| *** hoonetorg has joined #openstack-keystone | 19:10 | |
| lbragstad | kmalloc: i'll crack open the flask stuff in a minute here | 19:11 |
| lbragstad | i assume you still need it reviewed? | 19:11 |
| *** hoonetorg has quit IRC | 19:15 | |
| *** hoonetorg has joined #openstack-keystone | 19:16 | |
| *** fiddletwix has quit IRC | 19:20 | |
| kmalloc | yeah | 19:24 |
| kmalloc | working on the WIP one at the end for discovery | 19:24 |
| kmalloc | almost done. | 19:25 |
| kmalloc | but the stuff up to the flask WIP one needs review | 19:25 |
| *** hoonetorg has quit IRC | 19:30 | |
| *** lifeless_ has quit IRC | 19:31 | |
| hrybacki | lbragstad: question for you -- I'm not seeing where this is ever actually set:https://github.com/openstack/keystone/blob/master/keystone/cmd/bootstrap.py#L40 | 19:31 |
| hrybacki | the attempt to create the role is here: https://github.com/openstack/keystone/blob/master/keystone/cmd/bootstrap.py#L163-L165 but I'm not seeing where the `None` is being replaced by an actual string | 19:32 |
| lbragstad | hrybacki: https://github.com/openstack/keystone/blob/master/keystone/cmd/cli.py#L161 | 19:33 |
| lbragstad | which is using https://github.com/openstack/keystone/blob/master/keystone/cmd/cli.py#L131 | 19:33 |
| lbragstad | which uses the default here - https://github.com/openstack/keystone/blob/master/keystone/cmd/cli.py#L84 | 19:33 |
| hrybacki | lbragstad: ah ack. Do you think I should port the `reader` and `admin` role names to a config and have them consumed like ^^ or keep them as is directly in the bootstrap code | 19:34 |
| lbragstad | umm | 19:36 |
| lbragstad | good question | 19:36 |
| lbragstad | since it's really just used one, i'd lean towards using it as another option to bootstrap | 19:36 |
| lbragstad | instead of config options | 19:36 |
| lbragstad | or - just create those roles and don't expose them via config or options? | 19:37 |
| hrybacki | oh no, I don't mean necessarily a 'default roles or no default roles' option. But the names themselves e.g. do we want people to be able to replace 'reader' with 'readonly' by overriding default config | 19:37 |
| lbragstad | hmmm | 19:37 |
| lbragstad | i'm not sure if allowing them override is going to be that important? | 19:38 |
| hrybacki | can always be added after the face | 19:38 |
| hrybacki | fact | 19:38 |
| lbragstad | but i'm willing to be convinced otherwise | 19:38 |
| hrybacki | see line 39 https://review.openstack.org/#/c/572243/7/keystone/cmd/bootstrap.py | 19:38 |
| lbragstad | we've already committed to using 'admin', 'member', and 'reader' | 19:39 |
| hrybacki | rather line 41 and 45 | 19:39 |
| * hrybacki nods | 19:39 | |
| *** Sundar has quit IRC | 19:39 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: [WIP] Convert json_home and version discovery to Flask https://review.openstack.org/574736 | 19:39 |
| knikolla | lbragstad: do we have any docs on implied roles? | 19:39 |
| lbragstad | if a deployment is going to use something else, they already need to roll their own custom policy | 19:39 |
| knikolla | i'm writing the release note for the infer_roles deprecation and coming up blank with links to docs. | 19:40 |
| lbragstad | knikolla: not that i am aware of - i did have a bug open for that though | 19:40 |
| kmalloc | lbragstad: ^ and we have flaskified discovery/json_home | 19:40 |
| hrybacki | ack. I'll leave it as is and pull out the TODOs lbragstad | 19:40 |
| lbragstad | kmalloc: awesome | 19:40 |
| lbragstad | kmalloc: what's your opinion on hrybacki's question? | 19:40 |
| kmalloc | discovery is *not* representative of anything else, but that is because discovery is super special | 19:40 |
| kmalloc | uhm reading up | 19:40 |
| lbragstad | should an operator be able to override the member and reader role names? | 19:40 |
| lbragstad | in the bootstrap option? | 19:40 |
| kmalloc | in bootstrap? | 19:41 |
| kmalloc | no | 19:41 |
| kmalloc | bootstrap is explicitly opinonated | 19:41 |
| kmalloc | it setups the system to a common "known" state | 19:41 |
| lbragstad | yeah- i just doesn't seem to get you much mileage | 19:41 |
| kmalloc | it is up to the operator to move from there, but they know the state is consistent | 19:41 |
| hrybacki | ack | 19:41 |
| kmalloc | so they can automate from that point | 19:41 |
| lbragstad | since we're going to be rewriting all of our policie to those default | 19:42 |
| lbragstad | defaults* | 19:42 |
| kmalloc | yep, go for opinionated and consistent | 19:42 |
| *** raildo has quit IRC | 19:42 | |
| openstackgerrit | Harry Rybacki proposed openstack/keystone master: Ensure default roles created during bootstrap https://review.openstack.org/572243 | 19:42 |
| kmalloc | the whole idea is bootstrap gets keystone running to the point you can use the API to setup the rest | 19:42 |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone master: Deprecate [token] infer_roles https://review.openstack.org/574869 | 19:42 |
| hrybacki | cool, ^^ should be g2g then | 19:42 |
| lbragstad | hrybacki: you can just create them and then set the role IDs on the bootstrap object | 19:42 |
| hrybacki | I'm wondering if there isn't a way to rename 'admin' as things are right now | 19:43 |
| lbragstad | then we can reuse those roles in tests | 19:43 |
| hrybacki | already setting them on the object so we should be good to go | 19:44 |
| lbragstad | sweet | 19:44 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert json_home and version discovery to Flask https://review.openstack.org/574736 | 19:45 |
| openstackgerrit | Merged openstack/keystoneauth master: raise_exc default in Adapter https://review.openstack.org/574784 | 19:45 |
| kmalloc | lbragstad: i have a good feeling that we're going to see a faster keystone just by leaning 100% on flask instead of having all these mappers we pass requests through | 19:47 |
| kmalloc | a single dispatch layer is going to be good | 19:48 |
| lbragstad | i hope you're right | 19:48 |
| kmalloc | we already saw somewhat of that by dropping paste.deploy | 19:48 |
| kmalloc | it wasn't huge, but it was a bit on our unit tests. | 19:48 |
| *** lifeless has joined #openstack-keystone | 19:49 | |
| kmalloc | lbragstad: answered in-line questions (cc gagehugo) on the flask reviews | 19:57 |
| *** dave-mccowan has joined #openstack-keystone | 20:01 | |
| gagehugo | kmalloc \o/ | 20:04 |
| *** AlexeyAbashkin has joined #openstack-keystone | 20:05 | |
| *** Alexey_Abashkin has joined #openstack-keystone | 20:08 | |
| *** AlexeyAbashkin has quit IRC | 20:09 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 20:09 | |
| *** dave-mccowan has quit IRC | 20:10 | |
| *** Alexey_Abashkin has joined #openstack-keystone | 20:15 | |
| *** AlexeyAbashkin has quit IRC | 20:16 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 20:16 | |
| *** itlinux has joined #openstack-keystone | 20:24 | |
| *** itlinux has quit IRC | 20:28 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Expose endpoint to return enforcement model https://review.openstack.org/562716 | 20:46 |
| *** boris_42_ has joined #openstack-keystone | 20:47 | |
| *** lbragstad[m] has quit IRC | 20:49 | |
| *** knikolla[m] has quit IRC | 20:49 | |
| *** AlexeyAbashkin has quit IRC | 20:52 | |
| *** felipemonteiro has joined #openstack-keystone | 20:56 | |
| *** linkmark has joined #openstack-keystone | 20:58 | |
| hrybacki | lbragstad: o/ tbh I don't understand how the blueprints work in LP :P | 21:00 |
| hrybacki | I think you added that link to commit msg and I assumed it worked lol | 21:00 |
| lbragstad | blueprint in lp or how we link to them? | 21:00 |
| hrybacki | how we link them | 21:00 |
| hrybacki | I see https://blueprints.launchpad.net/keystone/+spec/basic-default-roles | 21:01 |
| lbragstad | yeah | 21:01 |
| lbragstad | so gerrit has a parser that will parse commit messages for special strings, and format them to links | 21:01 |
| kmalloc | lbragstad: responded to comments on the discovery-flaskification bit | 21:01 |
| lbragstad | so if it sees something like `bp blah` it will replace that with a link to launchpad for a blueprint named 'blah' | 21:02 |
| hrybacki | ah, so 'basic-default-roles' rather than 'define-default-roles' | 21:03 |
| hrybacki | makes sense | 21:03 |
| * hrybacki updates | 21:03 | |
| lbragstad | yep | 21:03 |
| kmalloc | yeah | 21:03 |
| *** efried has joined #openstack-keystone | 21:03 | |
| *** pcaruana has quit IRC | 21:04 | |
| efried | Hey folks, did you want me to propose a release to pick up https://review.openstack.org/#/c/574784/ ? | 21:04 |
| efried | It's not an urgent thing, so no biggie if you're waiting to collect moar stuffs. | 21:04 |
| lbragstad | would a week or two be too much time? | 21:05 |
| efried | Not at all. | 21:05 |
| efried | Thanks Lance. | 21:05 |
| lbragstad | awesome - i'll keep an eye on ksa stuff and see what else we can roll in the next release | 21:05 |
| efried | rgr | 21:05 |
| lbragstad | if i come up dry after a week or two, we'll happily do another release | 21:05 |
| efried | sounds good | 21:05 |
| lbragstad | thanks efried | 21:05 |
| efried | My pleasure. | 21:05 |
| *** lbragstad[m] has joined #openstack-keystone | 21:07 | |
| *** aojea has joined #openstack-keystone | 21:14 | |
| *** knikolla[m] has joined #openstack-keystone | 21:21 | |
| *** lifeless has quit IRC | 21:21 | |
| openstackgerrit | Harry Rybacki proposed openstack/keystone master: Ensure default roles created during bootstrap https://review.openstack.org/572243 | 21:22 |
| hrybacki | thanks for the comments lbragstad | 21:23 |
| lbragstad | thanks for being on the ball | 21:23 |
| *** sapd has quit IRC | 21:26 | |
| *** sapd has joined #openstack-keystone | 21:27 | |
| *** sapd has quit IRC | 21:27 | |
| *** sapd has joined #openstack-keystone | 21:27 | |
| *** lifeless has joined #openstack-keystone | 21:29 | |
| *** dtruong has quit IRC | 21:41 | |
| *** evrardjp_ has joined #openstack-keystone | 21:41 | |
| *** evrardjp has quit IRC | 21:43 | |
| *** dtruong has joined #openstack-keystone | 21:47 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert json_home and version discovery to Flask https://review.openstack.org/574736 | 21:48 |
| *** nicolasbock has quit IRC | 21:51 | |
| knikolla | adriant: o/ | 21:54 |
| knikolla | have some adjutant questions | 21:54 |
| *** felipemonteiro has quit IRC | 21:54 | |
| *** r-daneel has joined #openstack-keystone | 21:58 | |
| lbragstad | #endmeeting | 21:59 |
| openstack | Meeting ended Tue Jun 12 21:59:36 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 21:59 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-06-12-16.58.html | 21:59 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-06-12-16.58.txt | 21:59 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-06-12-16.58.log.html | 21:59 |
| *** dave-mccowan has joined #openstack-keystone | 22:00 | |
| *** r-daneel_ has joined #openstack-keystone | 22:01 | |
| *** r-daneel has quit IRC | 22:03 | |
| *** r-daneel_ is now known as r-daneel | 22:03 | |
| *** felipemonteiro has joined #openstack-keystone | 22:10 | |
| lbragstad | wxy: knikolla thoughts on https://review.openstack.org/#/c/574391/2/keystoneclient/v3/limits.py ? | 22:14 |
| lbragstad | it'll require more cleanup changes to the server implementation | 22:14 |
| lbragstad | and we'll have to update the spec, but i'm wondering if there is a case to not do that? | 22:14 |
| lbragstad | we can talk about it tomorrow or later this evening too | 22:14 |
| knikolla | lbragstad: you could have them share a base class and the only difference being resource_class | 22:15 |
| lbragstad | sure | 22:15 |
| lbragstad | i guess i'm talking about the overall usability of the registered limit api and limit api? | 22:15 |
| knikolla | well, to the user only the url path will look different | 22:16 |
| knikolla | if they accept the same things | 22:16 |
| lbragstad | accept what things? | 22:16 |
| knikolla | let me gather my thoughts. being coherent at 6.20pm is hard | 22:17 |
| knikolla | with the current implementation | 22:17 |
| lbragstad | agreed - i'm hitting that piont too | 22:17 |
| knikolla | registered_limits API and limit API are the same, right? | 22:18 |
| knikolla | with limit taking a project also | 22:18 |
| lbragstad | https://developer.openstack.org/api-ref/identity/v3/index.html#unified-limits | 22:18 |
| lbragstad | this is what an example create request looks like https://developer.openstack.org/api-ref/identity/v3/index.html#create-registered-limits | 22:18 |
| lbragstad | for registered limits ^ | 22:19 |
| lbragstad | for limits -> https://developer.openstack.org/api-ref/identity/v3/index.html#create-limits | 22:19 |
| lbragstad | notice that the only big difference is the addition of a project_id attribute and default_limit doesn't exist and is replaced with resource_limit | 22:19 |
| knikolla | which ironically enough is missing from the table of parameters | 22:20 |
| lbragstad | but the user of the API still needs to specify service_id, region_id, and resource_name | 22:20 |
| knikolla | lbragstad: not necessarily. they can specify names | 22:21 |
| knikolla | if using the client | 22:21 |
| lbragstad | sure - but that's a client thing | 22:21 |
| lbragstad | writing up a paste to see if that helps me get my thoughts out | 22:21 |
| knikolla | lbragstad: in the case of specifying a registered_limit override they need to specify a limit to override | 22:22 |
| knikolla | to uniquely qualify one they need either a reigstered limit ID | 22:22 |
| knikolla | or service, region and resource | 22:22 |
| knikolla | if they don't know the ID already | 22:22 |
| knikolla | or they can get a full list | 22:23 |
| knikolla | hmmm... | 22:23 |
| knikolla | I guess both flows make sense in a way | 22:23 |
| *** aojea has quit IRC | 22:23 | |
| lbragstad | http://paste.openstack.org/raw/723353/ | 22:25 |
| *** edmondsw has quit IRC | 22:26 | |
| *** edmondsw has joined #openstack-keystone | 22:26 | |
| lbragstad | see how the very last example is duplicating information already associated to the registered limit? | 22:26 |
| lbragstad | but that's how it works today | 22:27 |
| lbragstad | i'm just wondering if we care about that duplication? | 22:27 |
| lbragstad | if we want to leave it the way it is or change it since it is still experimental | 22:28 |
| knikolla | my feeling is that for people using clients. the current behavior is better. | 22:28 |
| lbragstad | so `openstack registered limit create nova cores 10` | 22:29 |
| knikolla | as a user that wants to override a limit on a project. i know what that limit represents. nova/RegionOne/vcpu/projectX/20 | 22:29 |
| lbragstad | and then `openstack limit create project_foo nova cores 10` | 22:29 |
| knikolla | But I don't know the limits ID, until I query for it. | 22:29 |
| knikolla | yes | 22:30 |
| knikolla | if u need to specify an override | 22:30 |
| knikolla | it would be `openstack reigstered limit show nova cores 10` | 22:30 |
| knikolla | copy paste id | 22:30 |
| knikolla | `openstack limi create project_foo <paste ID> 20` | 22:30 |
| lbragstad | yeah - or `openstack registered limit list` | 22:30 |
| lbragstad | right | 22:30 |
| *** edmondsw has quit IRC | 22:31 | |
| knikolla | I feel the first works better as a user flow | 22:31 |
| knikolla | as it avoids copy pasting | 22:31 |
| knikolla | or exposure to IDs | 22:31 |
| lbragstad | i can see that | 22:31 |
| lbragstad | ok | 22:31 |
| lbragstad | i'll mull on it | 22:31 |
| *** martinus__ has quit IRC | 22:32 | |
| lbragstad | cc kmalloc wxy ^ | 22:33 |
| lbragstad | thanks knikolla | 22:33 |
| kmalloc | sec | 22:33 |
| kmalloc | reading up | 22:33 |
| lbragstad | no worries - i'm about to step away for a minute, but wanted to get opinions | 22:33 |
| kmalloc | hm | 22:34 |
| kmalloc | i don't care about the duplication really. | 22:36 |
| kmalloc | i'm happy if you want to change it | 22:36 |
| lbragstad | so you're in the same boat as knikolla? | 22:36 |
| kmalloc | i'm in the boat of "both look oke" | 22:37 |
| lbragstad | ok | 22:37 |
| kmalloc | but in general... i don't like IDs for automation | 22:37 |
| lbragstad | that fair | 22:39 |
| knikolla | i should start heading back, but the office is empty and i'm really enjoying the quiet | 22:39 |
| *** rcernin has joined #openstack-keystone | 22:44 | |
| *** jmlowe has joined #openstack-keystone | 22:55 | |
| *** dklyle has quit IRC | 22:55 | |
| *** dklyle has joined #openstack-keystone | 22:56 | |
| *** felipemonteiro has quit IRC | 23:07 | |
| *** lbragstad[m] has quit IRC | 23:16 | |
| *** knikolla[m] has quit IRC | 23:16 | |
| *** jmlowe has quit IRC | 23:17 | |
| *** jmlowe has joined #openstack-keystone | 23:19 | |
| *** felipemonteiro has joined #openstack-keystone | 23:23 | |
| *** jmlowe has quit IRC | 23:31 | |
| *** lbragstad[m] has joined #openstack-keystone | 23:33 | |
| *** jmlowe has joined #openstack-keystone | 23:35 | |
| *** threestrands has joined #openstack-keystone | 23:36 | |
| *** knikolla[m] has joined #openstack-keystone | 23:46 | |
| *** mchlumsky has quit IRC | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!