| *** itlinux has quit IRC | 00:03 | |
| *** itlinux has joined #openstack-keystone | 00:06 | |
| *** gyee has quit IRC | 00:10 | |
| *** r-daneel has quit IRC | 00:21 | |
| *** felipemonteiro_ has quit IRC | 00:38 | |
| *** itlinux has quit IRC | 00:41 | |
| *** itlinux has joined #openstack-keystone | 00:46 | |
| *** harlowja has quit IRC | 00:52 | |
| *** chenyb4 has joined #openstack-keystone | 00:54 | |
| *** itlinux has quit IRC | 00:58 | |
| *** itlinux has joined #openstack-keystone | 01:08 | |
| *** itlinux has quit IRC | 01:10 | |
| *** itlinux has joined #openstack-keystone | 01:20 | |
| *** chenyb4 has quit IRC | 01:25 | |
| *** chenyb4 has joined #openstack-keystone | 01:28 | |
| *** r-daneel has joined #openstack-keystone | 01:29 | |
| Xinran | wxy, thanks and sorry for the delay reply :) | 01:30 |
|---|---|---|
| *** itlinux has quit IRC | 01:35 | |
| *** Pete_ has joined #openstack-keystone | 01:37 | |
| *** gongysh has joined #openstack-keystone | 02:30 | |
| *** germs has quit IRC | 02:34 | |
| *** germs has joined #openstack-keystone | 02:35 | |
| *** germs has quit IRC | 02:35 | |
| *** germs has joined #openstack-keystone | 02:35 | |
| *** Xinran has quit IRC | 02:40 | |
| *** d0ugal has quit IRC | 02:43 | |
| *** nicolasbock has quit IRC | 02:47 | |
| *** d0ugal has joined #openstack-keystone | 02:49 | |
| *** dave-mccowan has quit IRC | 03:05 | |
| *** sonuk has joined #openstack-keystone | 03:20 | |
| *** annp has joined #openstack-keystone | 03:21 | |
| *** cusconi has joined #openstack-keystone | 03:24 | |
| *** cusconi has quit IRC | 03:25 | |
| *** weez17246 has joined #openstack-keystone | 03:37 | |
| *** weez17246 has quit IRC | 03:39 | |
| *** itlinux has joined #openstack-keystone | 03:49 | |
| *** iuksvq has joined #openstack-keystone | 03:52 | |
| *** iuksvq has quit IRC | 03:54 | |
| *** itlinux has quit IRC | 04:23 | |
| *** namnh has joined #openstack-keystone | 04:24 | |
| *** lbragstad has joined #openstack-keystone | 04:26 | |
| *** ChanServ sets mode: +o lbragstad | 04:26 | |
| *** lbragstad has quit IRC | 04:28 | |
| *** gongysh has quit IRC | 04:30 | |
| *** gongysh has joined #openstack-keystone | 04:37 | |
| *** gongysh has quit IRC | 04:42 | |
| *** harlowja has joined #openstack-keystone | 04:44 | |
| *** pcichy has joined #openstack-keystone | 05:09 | |
| *** links has joined #openstack-keystone | 05:12 | |
| *** gongysh has joined #openstack-keystone | 05:26 | |
| *** mordred has quit IRC | 05:29 | |
| *** harlowja has quit IRC | 05:39 | |
| *** mordred has joined #openstack-keystone | 05:41 | |
| *** gongysh has quit IRC | 06:14 | |
| *** jaosorior has joined #openstack-keystone | 06:21 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 06:37 | |
| *** gongysh has joined #openstack-keystone | 06:43 | |
| *** martinus__ has joined #openstack-keystone | 06:49 | |
| *** Supun has joined #openstack-keystone | 06:51 | |
| *** AlexeyAbashkin has quit IRC | 06:58 | |
| *** Horrorcat has quit IRC | 07:01 | |
| *** Horrorcat has joined #openstack-keystone | 07:01 | |
| *** Horrorcat has joined #openstack-keystone | 07:01 | |
| *** tesseract has joined #openstack-keystone | 07:17 | |
| *** Supun has quit IRC | 07:23 | |
| *** rcernin has quit IRC | 07:33 | |
| *** namnh_ has joined #openstack-keystone | 07:33 | |
| *** namnh has quit IRC | 07:35 | |
| *** Supun has joined #openstack-keystone | 07:41 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 07:41 | |
| *** AlexeyAbashkin has quit IRC | 07:46 | |
| *** namnh_ has quit IRC | 07:53 | |
| *** Supun has quit IRC | 08:18 | |
| *** pcaruana has joined #openstack-keystone | 09:12 | |
| *** gongysh has quit IRC | 10:23 | |
| *** annp has quit IRC | 10:29 | |
| *** panbalag has joined #openstack-keystone | 10:30 | |
| *** nicolasbock has joined #openstack-keystone | 10:31 | |
| *** dangtrinhnt has quit IRC | 10:32 | |
| *** chenyb4 has quit IRC | 10:36 | |
| *** sonuk has quit IRC | 10:37 | |
| *** pooja_jadhav has quit IRC | 11:05 | |
| *** pooja_jadhav has joined #openstack-keystone | 11:06 | |
| *** panbalag has quit IRC | 11:15 | |
| *** dave-mccowan has joined #openstack-keystone | 11:17 | |
| *** Horrorcat has quit IRC | 11:21 | |
| *** sonuk has joined #openstack-keystone | 11:32 | |
| *** Horrorcat has joined #openstack-keystone | 11:33 | |
| *** Horrorcat has joined #openstack-keystone | 11:33 | |
| *** aloga has quit IRC | 11:49 | |
| *** aloga has joined #openstack-keystone | 11:50 | |
| *** h3yduck has quit IRC | 12:02 | |
| *** spilla has joined #openstack-keystone | 12:26 | |
| *** raildo has joined #openstack-keystone | 12:27 | |
| *** panbalag has joined #openstack-keystone | 12:41 | |
| *** panbalag has left #openstack-keystone | 12:46 | |
| *** edmondsw_ has joined #openstack-keystone | 12:46 | |
| *** edmonds__ has joined #openstack-keystone | 12:47 | |
| *** edmondsw has quit IRC | 12:50 | |
| *** edmondsw_ has quit IRC | 12:51 | |
| *** chenyb4 has joined #openstack-keystone | 12:51 | |
| *** edmondsw has joined #openstack-keystone | 12:54 | |
| *** efried is now known as fried_rice | 12:55 | |
| *** jmlowe has joined #openstack-keystone | 12:55 | |
| *** edmondsw_ has joined #openstack-keystone | 12:56 | |
| *** edmonds__ has quit IRC | 12:56 | |
| *** mchlumsky has joined #openstack-keystone | 12:57 | |
| *** jmlowe_ has quit IRC | 12:58 | |
| *** edmondsw has quit IRC | 12:59 | |
| *** ayoung has quit IRC | 13:08 | |
| *** r-daneel has quit IRC | 13:09 | |
| *** ayoung has joined #openstack-keystone | 13:14 | |
| *** chenyb4 has quit IRC | 13:18 | |
| *** jaosorior has quit IRC | 13:27 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154 | 13:27 |
| *** felipemonteiro_ has joined #openstack-keystone | 13:28 | |
| *** ayoung has quit IRC | 13:29 | |
| *** r-daneel has joined #openstack-keystone | 13:30 | |
| *** sonuk has quit IRC | 13:31 | |
| *** dansmith is now known as superdan | 13:31 | |
| *** mchlumsky has quit IRC | 13:33 | |
| *** mchlumsky has joined #openstack-keystone | 13:35 | |
| *** lbragstad has joined #openstack-keystone | 13:36 | |
| *** ChanServ sets mode: +o lbragstad | 13:36 | |
| *** edmondsw_ is now known as edmondsw | 13:39 | |
| *** sonuk has joined #openstack-keystone | 13:43 | |
| *** hoonetorg has quit IRC | 13:48 | |
| knikolla | o/ | 14:06 |
| *** felipemonteiro__ has joined #openstack-keystone | 14:16 | |
| *** felipemonteiro_ has quit IRC | 14:19 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218 | 14:21 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154 | 14:21 |
| mordred | fried_rice, cmurphy, kmalloc, lbragstad: ^^ almost a full year later, the service_type alias patch is back | 14:22 |
| mordred | it's much smaller this time, seeing as how we have a library and whatnot | 14:22 |
| lbragstad | oh - nice | 14:22 |
| lbragstad | i can take a look | 14:23 |
| mordred | cmurphy: I also rebased the version data patch on the discovery patch so that adding the os-service-types depend makes more sense | 14:23 |
| mordred | lbragstad: awesome -thanks! | 14:23 |
| kmalloc | Oh wow! | 14:23 |
| mordred | kmalloc: ikr? | 14:24 |
| kmalloc | I'll take a look as well shortly (post dog walk) | 14:24 |
| mordred | kmalloc: I got to reply to a review comment from you from may 3 of last year with "done" :) | 14:24 |
| kmalloc | Haha. | 14:25 |
| mordred | fried_rice: if we've done this right, we SHOULD be able to remove some code from nova | 14:25 |
| *** felipemonteiro__ has quit IRC | 14:25 | |
| fried_rice | mordred: That would be neato. | 14:25 |
| *** felipemonteiro__ has joined #openstack-keystone | 14:26 | |
| fried_rice | I'm having some trouble understanding the PS1-2 diff. But I'll get there... | 14:26 |
| mordred | fried_rice: oh - you might want to just look at ps2 from scratch - there's a rebase in there | 14:31 |
| *** germs has quit IRC | 14:35 | |
| *** germs has joined #openstack-keystone | 14:35 | |
| *** germs has quit IRC | 14:35 | |
| *** germs has joined #openstack-keystone | 14:35 | |
| fried_rice | yuh | 14:36 |
| *** idlemind has joined #openstack-keystone | 14:44 | |
| *** AlexeyAbashkin has joined #openstack-keystone | 14:45 | |
| *** AlexeyAbashkin has quit IRC | 14:49 | |
| *** openstackgerrit has quit IRC | 14:50 | |
| *** melwitt is now known as jgwentworth | 14:53 | |
| *** germs has quit IRC | 14:53 | |
| *** germs has joined #openstack-keystone | 14:54 | |
| *** links has quit IRC | 14:58 | |
| *** germs has quit IRC | 14:58 | |
| *** germs has joined #openstack-keystone | 14:59 | |
| *** germs has quit IRC | 14:59 | |
| *** germs has joined #openstack-keystone | 14:59 | |
| *** germs has quit IRC | 15:04 | |
| *** felipemonteiro_ has joined #openstack-keystone | 15:05 | |
| *** felipemonteiro__ has quit IRC | 15:09 | |
| *** Horrorcat has left #openstack-keystone | 15:10 | |
| *** pcaruana has quit IRC | 15:12 | |
| *** Horrorcat has joined #openstack-keystone | 15:15 | |
| kmalloc | mordred: we need to adjust the split loggers | 15:16 |
| kmalloc | mordred: if you dind't see the convo from yesterday | 15:16 |
| kmalloc | mordred: basically, we need to be able to override a passed in logger, which looks like we can't atm | 15:17 |
| kmalloc | still opt-in, but, actually overridable | 15:17 |
| kmalloc | lbragstad: ping o/ need quick sanity check | 15:20 |
| *** pcichy has quit IRC | 15:20 | |
| kmalloc | lbragstad: "Disable_X: True" or... something else (need to knwo if that kind of flag makes sense) | 15:21 |
| kmalloc | or if it sounds logically wierd. | 15:21 |
| *** openstackgerrit has joined #openstack-keystone | 15:24 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Handle LDAP Server Down in Pool https://review.openstack.org/560724 | 15:24 |
| kmalloc | forget it. i have a solution | 15:25 |
| mordred | kmalloc: nod, I saw a little bit of that but not the whole thing | 15:26 |
| kmalloc | i think we just need a kwarg to set split_loggers: truew | 15:26 |
| kmalloc | i'll ponder on it. | 15:26 |
| mordred | kmalloc: when you say "override a passed in logger" ... | 15:26 |
| kmalloc | someone has a wsessiion with a logger | 15:26 |
| mordred | kmalloc: you mean there are times when someone wants to pass in a logger AND have split loggers? | 15:26 |
| kmalloc | and they want to use split loggers for requests even thoughnthey have a previous session | 15:26 |
| mordred | ah | 15:26 |
| mordred | gotcha | 15:27 |
| kmalloc | it toally makes sense | 15:27 |
| mordred | yeah - I tink just a kwarg would likely solve that - but also yeah, pondering for a few is also likely good | 15:27 |
| gagehugo | kmalloc: dumb question when you have a moment. Does ldappool handle removing a server from a connection pool if it goes down? | 15:37 |
| kmalloc | lbragstad: nvm, figured it out | 15:37 |
| kmalloc | gagehugo: no idea, but if it doesn't, we own ldappool so we can change it | 15:38 |
| lbragstad | kmalloc: sorry | 15:38 |
| lbragstad | just saw this | 15:38 |
| gagehugo | kmalloc we're seeing issues where keystone goes down if one of the servers in a pool dies | 15:39 |
| kmalloc | gagehugo: i could see that | 15:40 |
| kmalloc | we can fix ldappool if it doesn't, since ... i think cmurphy and I are core on it | 15:40 |
| kmalloc | ;) | 15:40 |
| gagehugo | yeah I'm looking at that now and saw your name heh | 15:40 |
| *** ayoung has joined #openstack-keystone | 15:44 | |
| kmalloc | :) | 15:45 |
| mordred | fried_rice: thanks - great review feedback | 15:45 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Expose version status in EndpointData https://review.openstack.org/559125 | 15:46 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218 | 15:46 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154 | 15:46 |
| *** Supun has joined #openstack-keystone | 15:47 | |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Expose version status in EndpointData https://review.openstack.org/559125 | 15:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Implement service_type alias lookups https://review.openstack.org/462218 | 15:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Add methods to get all of the version data https://review.openstack.org/559154 | 15:47 |
| openstackgerrit | Monty Taylor proposed openstack/keystoneauth master: Fix W503 line-break-before-binary-operator https://review.openstack.org/561259 | 15:47 |
| mordred | kmalloc, lbragstad: ^^ that last patch fixes a thing that JUST started failing in the gate - I'm guessing a new pyparsing came out or something? | 15:48 |
| *** itlinux has joined #openstack-keystone | 15:48 | |
| mordred | s/pyparsing/pycodestyle/ | 15:48 |
| kmalloc | mordred: oh fun. | 15:48 |
| mordred | yah | 15:48 |
| lbragstad | bah - thanks mordred | 15:52 |
| *** r-daneel has quit IRC | 16:06 | |
| *** Supun has quit IRC | 16:10 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Allow blocking users from self-service password change https://review.openstack.org/559438 | 16:14 |
| *** pcaruana has joined #openstack-keystone | 16:15 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Allow blocking users from self-service password change https://review.openstack.org/559438 | 16:18 |
| kmalloc | lbragstad: ^ updated, and should be 100% fixed now. | 16:19 |
| lbragstad | kmalloc: sweet! | 16:19 |
| lbragstad | i'll review that today | 16:19 |
| lbragstad | i'll even test it manually ;) | 16:19 |
| kmalloc | lbragstad: moved away from overriding min_password_age to just having lock_password | 16:19 |
| lbragstad | kmalloc: i'm totally on board with that | 16:19 |
| kmalloc | we should offer overrides too | 16:20 |
| kmalloc | but ... different change | 16:20 |
| lbragstad | i like the ergonomics of that a little better to | 16:20 |
| lbragstad | and it's less overloading of something we already use | 16:20 |
| *** r-daneel has joined #openstack-keystone | 16:24 | |
| kmalloc | yeah | 16:31 |
| kmalloc | since i had to move the logic, figured lock_password made more sense | 16:31 |
| kmalloc | if i could handle it all in the same place, why bother adding more options. | 16:32 |
| kmalloc | but... | 16:32 |
| kmalloc | eh, whatever | 16:32 |
| *** fried_rice is now known as fried_rolls | 16:41 | |
| *** pcichy has joined #openstack-keystone | 16:42 | |
| lbragstad | i'm going to step away for lunch | 16:44 |
| lbragstad | i'm actually leaving the office for lunch for the first time in about 18 months, so i'll be back in about an hour or so | 16:44 |
| *** gyee has joined #openstack-keystone | 16:51 | |
| *** sonuk has quit IRC | 16:52 | |
| *** links has joined #openstack-keystone | 16:53 | |
| *** germs has joined #openstack-keystone | 17:00 | |
| *** germs has quit IRC | 17:00 | |
| *** germs has joined #openstack-keystone | 17:00 | |
| *** pcichy has quit IRC | 17:01 | |
| *** germs has quit IRC | 17:05 | |
| *** Pete_ has quit IRC | 17:26 | |
| *** felipemonteiro_ has quit IRC | 17:27 | |
| *** felipemonteiro_ has joined #openstack-keystone | 17:27 | |
| openstackgerrit | ayoung proposed openstack/keystone master: Shift to check_policy for resource creation https://review.openstack.org/462670 | 17:39 |
| *** felipemonteiro_ has quit IRC | 17:39 | |
| ayoung | lbragstad, while I am abandoning all the is_admin_project changes, I am going to drive on with ^^ as I think we need it | 17:39 |
| ayoung | If I remember correctly, there are places where we had hard coded admin checks, and this allows us a way to get rid of them | 17:41 |
| ayoung | It can be tagged as a bug fix, separate from 968696, as it now allows domain-id as well as domain_id in user creation | 17:45 |
| *** tesseract has quit IRC | 17:53 | |
| *** links has quit IRC | 18:02 | |
| *** links has joined #openstack-keystone | 18:15 | |
| *** links has quit IRC | 18:31 | |
| *** jdennis has quit IRC | 18:36 | |
| *** jdennis has joined #openstack-keystone | 18:39 | |
| lbragstad | ayoung: i can review it | 18:40 |
| ayoung | lbragstad, thanks. Its been so long, I know one like that is hard to bring back into memory | 18:41 |
| ayoung | there was a push to get all of our policy out of the decorators and into code. I am not sure now how essential that is, or why it was such a bad idea. | 18:42 |
| ayoung | I'm sure it will pop-full-blown back into my head in a moment, but I think it has to do with the scope check | 18:42 |
| ayoung | We ended up querying the database twice, and were ok with it based on the assumption that the second one would hit the caching layer | 18:42 |
| lbragstad | yeah - i think we still want to remove the @protected decorator | 18:42 |
| lbragstad | in favor of clear policy enforcement in code | 18:44 |
| kmalloc | ++ | 18:53 |
| kmalloc | please remove @protected | 18:53 |
| kmalloc | pleeeeeeaaaseeeee | 18:53 |
| kmalloc | ayoung: the decorators are bad because they are damn near impossible to debug/adjust/change and we duplicate code due to the callbacks | 18:53 |
| kmalloc | ayoung: when we need to "inspect" the response for ownership, etc | 18:53 |
| ayoung | kmalloc, so I thought I had a whole series of patches that removed them, but all I can find is https://review.openstack.org/462670 | 18:54 |
| ayoung | the prep thing is still hideous, but minimally intrusive code removal-wise | 18:54 |
| kmalloc | ayoung: yeah i don't remember a series outside of that. | 18:54 |
| kmalloc | might have been something local | 18:54 |
| kmalloc | i did some work, it's not easy to move away from the decorators | 18:55 |
| ayoung | let me see. With that patch in there, how many are left... | 18:55 |
| kmalloc | the really hard part is the callback ones | 18:56 |
| *** dklyle has quit IRC | 18:56 | |
| ayoung | I think that might be the last of it | 18:56 |
| ayoung | Ah...no | 18:57 |
| ayoung | grep -rn @controller . | wc -l | 18:57 |
| ayoung | 189 | 18:57 |
| *** dklyle has joined #openstack-keystone | 18:57 | |
| ayoung | that covers @controller.protected() and | 18:57 |
| ayoung | oh wait...too many | 18:57 |
| ayoung | grep -rn @controller . | grep protect | wc -l | 18:58 |
| ayoung | 184 | 18:58 |
| kmalloc | yeah | 18:58 |
| ayoung | onlyh 5 fewer. | 18:58 |
| kmalloc | there are a ton of them. | 18:58 |
| kmalloc | it touches so many things | 18:58 |
| *** jdennis has quit IRC | 18:59 | |
| ayoung | I wonder if I can do better than the prep thing now | 18:59 |
| *** germs has joined #openstack-keystone | 19:01 | |
| *** germs has quit IRC | 19:01 | |
| *** germs has joined #openstack-keystone | 19:01 | |
| lbragstad | that's another *massive* refactor... | 19:02 |
| *** germs has quit IRC | 19:06 | |
| *** harlowja has joined #openstack-keystone | 19:10 | |
| *** idlemind has quit IRC | 19:15 | |
| *** pcichy has joined #openstack-keystone | 19:15 | |
| *** idlemind has joined #openstack-keystone | 19:16 | |
| *** pcichy has quit IRC | 19:21 | |
| *** pcichy has joined #openstack-keystone | 19:22 | |
| *** jdennis has joined #openstack-keystone | 19:24 | |
| *** fried_rolls is now known as fried_rice | 19:26 | |
| kmalloc | lbragstad: your major concern(the inabnility to pass None) is a core bug in resource options code if anything | 19:29 |
| lbragstad | oh - really? | 19:29 |
| lbragstad | so - one that option is set, we can never unset it? | 19:30 |
| *** pcichy has quit IRC | 19:30 | |
| kmalloc | lbragstad: it should work | 19:31 |
| kmalloc | i use: schema['properties'][opt.option_name] = validation.nullable( | 19:31 |
| kmalloc | opt.json_schema) | 19:31 |
| kmalloc | so, it should be nullable | 19:31 |
| kmalloc | wait... Null maybe? | 19:31 |
| kmalloc | what is the right json "form" of python's None | 19:32 |
| lbragstad | https://review.openstack.org/#/c/559438/8/keystone/identity/backends/resource_options.py@83 | 19:32 |
| kmalloc | yep | 19:32 |
| lbragstad | i used `null` to recreate the issue | 19:32 |
| kmalloc | >>> json.dumps({'t': None}) | 19:32 |
| kmalloc | '{"t": null}' | 19:32 |
| lbragstad | i think we might need to wrap that with nullable? | 19:32 |
| kmalloc | no | 19:33 |
| kmalloc | the core of resource options explicitly wraps that | 19:33 |
| kmalloc | https://github.com/openstack/keystone/blob/master/keystone/common/resource_options.py#L141 | 19:33 |
| lbragstad | weird | 19:33 |
| lbragstad | http://paste.openstack.org/raw/719190/ | 19:34 |
| kmalloc | so, that is a bug in the resource-options code | 19:34 |
| kmalloc | not in that patch | 19:34 |
| kmalloc | and afaict that should work. | 19:34 |
| kmalloc | lbragstad: | 19:38 |
| kmalloc | https://www.irccloud.com/pastebin/gDiPRaC4/ | 19:38 |
| kmalloc | this is looking like an issue with json_schema | 19:38 |
| kmalloc | nullable isn't adding null to the enum | 19:39 |
| kmalloc | but the types are properly showing boolean/null | 19:40 |
| kmalloc | so whatever is happening, the null isn't working from types if it doesn't match the enum | 19:40 |
| lbragstad | huh | 19:41 |
| lbragstad | intersting | 19:41 |
| kmalloc | looks like type can be used in lieu of enum | 19:42 |
| kmalloc | enum only when we want to test specifics | 19:42 |
| kmalloc | or we need to add null to each enum | 19:42 |
| *** jdennis has quit IRC | 19:42 | |
| *** jdennis has joined #openstack-keystone | 19:44 | |
| kmalloc | yep | 19:44 |
| kmalloc | nullable() doesn't add to the enum | 19:44 |
| lbragstad | hmm | 19:44 |
| lbragstad | weird | 19:44 |
| kmalloc | this is a bug in our validator code | 19:44 |
| lbragstad | so this would only be applicable for boolean useage of nullable? | 19:45 |
| kmalloc | no, anything we set ENUM and wrap in nullable we are going to fail on null | 19:45 |
| lbragstad | ah | 19:45 |
| lbragstad | damn | 19:45 |
| kmalloc | nullable needs to be smarter | 19:45 |
| lbragstad | ++ | 19:45 |
| kmalloc | and if there is an enum set, it must set null in the enum as well | 19:46 |
| kmalloc | if we only have types, it is doing the right thing | 19:46 |
| lbragstad | right, it looks like it sets it properly when using types | 19:46 |
| kmalloc | yep. so can we accept the code here and open a bug against our validator.nullable? | 19:46 |
| lbragstad | yeah | 19:46 |
| kmalloc | i'd rather not roll the fixes together | 19:46 |
| lbragstad | i think that's the right move | 19:46 |
| kmalloc | cool | 19:47 |
| *** dklyle has quit IRC | 19:47 | |
| kmalloc | i'll open the bug | 19:47 |
| lbragstad | thanks | 19:47 |
| lbragstad | i would like to keep the functionality you designed for though | 19:47 |
| lbragstad | where we can remove the option entirely by passing null | 19:47 |
| kmalloc | yes | 19:47 |
| kmalloc | that is the plan | 19:47 |
| kmalloc | once i fix nullable, it'll work just like that | 19:47 |
| lbragstad | ok - cool | 19:48 |
| kmalloc | no changes to the lock_password code | 19:48 |
| lbragstad | right | 19:48 |
| lbragstad | would you be opposed to rebasing your change on the other fix? | 19:48 |
| kmalloc | let me finish the bug | 19:48 |
| *** dklyle has joined #openstack-keystone | 19:50 | |
| kmalloc | lbragstad: targeting to pike and queens as well | 19:51 |
| kmalloc | as this impacts the DSS resource options unsetting | 19:51 |
| kmalloc | pci-dss* | 19:51 |
| lbragstad | ack | 19:52 |
| lbragstad | good deal | 19:52 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.policy master: set default python to python3 https://review.openstack.org/561324 | 20:03 |
| *** panbalag has joined #openstack-keystone | 20:06 | |
| *** panbalag has quit IRC | 20:08 | |
| *** felipemonteiro_ has joined #openstack-keystone | 20:09 | |
| *** felipemonteiro__ has joined #openstack-keystone | 20:13 | |
| *** felipemonteiro_ has quit IRC | 20:16 | |
| *** panbalag has joined #openstack-keystone | 20:16 | |
| *** felipemonteiro_ has joined #openstack-keystone | 20:18 | |
| *** felipemonteiro__ has quit IRC | 20:18 | |
| *** jmlowe_ has joined #openstack-keystone | 20:22 | |
| *** jmlowe has quit IRC | 20:23 | |
| kmalloc | lbragstad: almost done with the patch. | 20:30 |
| lbragstad | awesome | 20:30 |
| *** panbalag has quit IRC | 20:32 | |
| *** panbalag has joined #openstack-keystone | 20:38 | |
| *** martinus__ has quit IRC | 20:38 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Fix json schema nullable to add None to ENUM https://review.openstack.org/561348 | 20:38 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Allow blocking users from self-service password change https://review.openstack.org/559438 | 20:39 |
| kmalloc | lbragstad: ^ rebased | 20:39 |
| lbragstad | cool - i'll review | 20:39 |
| lbragstad | thanks kmalloc | 20:39 |
| kmalloc | lbragstad: bugs you find... clearly no one EVER tried to set a null for a boolean in keystone that is validated via json schema(yeah null is weird for a bool...but...) | 20:44 |
| lbragstad | yeah... i hit that and I was like "no.... really?!" | 20:45 |
| *** r-daneel has quit IRC | 20:49 | |
| kmalloc | lbragstad: bah, the cherry-pick button doesnt add the cherry-picked from line | 20:49 |
| lbragstad | no it doesn't :( | 20:49 |
| lbragstad | that's bitten me before | 20:49 |
| kmalloc | shrug. whatever, i'll revisit once it lands in master | 20:50 |
| kmalloc | as it stands.. i'm the only stable core =/ | 20:50 |
| kmalloc | and i proposed the backports. | 20:50 |
| lbragstad | i can propose it if you want me to | 20:50 |
| kmalloc | already clicked cherry-pick | 20:53 |
| kmalloc | sooo, whatever | 20:53 |
| kmalloc | we'll bug stab-core folks | 20:53 |
| kmalloc | and get one of the stable maintainers (not keystone specific) to +2. | 20:53 |
| *** d0ugal has quit IRC | 20:59 | |
| *** germs has joined #openstack-keystone | 21:01 | |
| *** germs has quit IRC | 21:01 | |
| *** germs has joined #openstack-keystone | 21:01 | |
| *** germs has quit IRC | 21:06 | |
| *** spilla has quit IRC | 21:17 | |
| *** felipemonteiro_ has quit IRC | 21:22 | |
| *** d0ugal has joined #openstack-keystone | 21:26 | |
| *** raildo has quit IRC | 21:33 | |
| *** dave-mccowan has quit IRC | 21:36 | |
| *** evrardjp has quit IRC | 21:40 | |
| *** ibxbnvc has joined #openstack-keystone | 21:41 | |
| lbragstad | huh - i got one failure locally running the tests | 21:42 |
| lbragstad | https://github.com/openstack/keystone/blob/56237b709ef901fabfd9e8ba744bbcc4cebf8b9b/keystone/tests/unit/test_validation.py#L1941 | 21:43 |
| *** eschwartz is now known as fingernail | 21:45 | |
| *** fingernail is now known as eschwartz | 21:45 | |
| *** r-daneel has joined #openstack-keystone | 21:46 | |
| *** ibxbnvc has quit IRC | 21:48 | |
| *** mchlumsky has quit IRC | 21:53 | |
| *** r-daneel has quit IRC | 22:05 | |
| *** r-daneel has joined #openstack-keystone | 22:09 | |
| *** linkmark has quit IRC | 22:12 | |
| *** itlinux has quit IRC | 22:27 | |
| *** panbalag has quit IRC | 22:47 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Modify the lock password test https://review.openstack.org/561366 | 22:49 |
| lbragstad | cc kmalloc the tests should be passing ^ | 22:53 |
| kmalloc | lbragstad: nice | 22:54 |
| lbragstad | feel free to roll that into your patch | 22:54 |
| lbragstad | i didn't want to step on anything you had locally | 22:55 |
| kmalloc | lbragstad: feel free to as well if ya want | 22:55 |
| kmalloc | nothing local | 22:55 |
| lbragstad | ok | 22:55 |
| kmalloc | basically was just waiting for zuul to weigh in and get comments. | 22:55 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Fix json schema nullable to add None to ENUM https://review.openstack.org/561348 | 22:58 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone master: Allow blocking users from self-service password change https://review.openstack.org/559438 | 22:58 |
| lbragstad | done^ | 22:58 |
| *** germs has joined #openstack-keystone | 23:02 | |
| *** germs has quit IRC | 23:02 | |
| *** germs has joined #openstack-keystone | 23:02 | |
| *** germs has quit IRC | 23:06 | |
| *** jgwentworth is now known as melwitt | 23:22 | |
| *** hoonetorg has joined #openstack-keystone | 23:45 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!