Tuesday, 2018-01-02

*** jmlowe_ has quit IRC00:00
*** jmlowe has joined #openstack-keystone00:00
*** markvoelker has joined #openstack-keystone00:27
*** markvoelker has quit IRC00:31
*** zhurong has joined #openstack-keystone00:42
*** namnh has joined #openstack-keystone01:03
*** daidv has joined #openstack-keystone01:13
*** panbalag has joined #openstack-keystone01:14
*** panbalag has quit IRC01:23
*** openstackgerrit has joined #openstack-keystone01:23
openstackgerritwangxiyuan proposed openstack/keystone master: Add schema check for authorize request token  https://review.openstack.org/52629601:23
*** markvoelker has joined #openstack-keystone01:28
*** markvoelker has quit IRC01:32
*** edmondsw has joined #openstack-keystone02:45
*** edmondsw has quit IRC03:03
*** edmondsw has joined #openstack-keystone03:05
*** edmondsw has quit IRC03:06
*** annp has joined #openstack-keystone03:14
*** markvoelker has joined #openstack-keystone03:29
*** links has joined #openstack-keystone03:34
*** markvoelker has quit IRC03:34
*** dave-mccowan has quit IRC03:51
*** markvoelker has joined #openstack-keystone04:30
*** markvoelker has quit IRC04:35
*** edmondsw has joined #openstack-keystone04:35
*** nicolasbock has quit IRC04:38
*** edmondsw has quit IRC04:40
*** bhagyashris has joined #openstack-keystone04:45
*** zhurong has quit IRC05:23
*** edmondsw has joined #openstack-keystone06:23
*** edmondsw has quit IRC06:28
*** gmann__ has joined #openstack-keystone07:00
*** jaosorior has joined #openstack-keystone07:07
*** Chealion has quit IRC07:13
*** magicboiz has joined #openstack-keystone07:15
*** magicboiz has quit IRC07:20
*** Chealion has joined #openstack-keystone07:21
*** gmann__ is now known as gmann07:23
*** pcaruana has joined #openstack-keystone07:24
*** pcaruana has quit IRC07:25
*** pcaruana has joined #openstack-keystone07:26
*** rajalokan has joined #openstack-keystone07:27
*** pcaruana has quit IRC07:29
*** pcaruana has joined #openstack-keystone07:29
*** markvoelker has joined #openstack-keystone07:32
*** magicboiz has joined #openstack-keystone07:32
*** rajalokan has quit IRC07:33
*** jaosorior has quit IRC07:58
*** jaosorior has joined #openstack-keystone08:00
*** edmondsw has joined #openstack-keystone08:12
*** edmondsw has quit IRC08:16
*** tesseract has joined #openstack-keystone08:20
*** linpopilan has joined #openstack-keystone09:18
*** mvk has joined #openstack-keystone09:18
*** aojea has joined #openstack-keystone09:42
*** aojea_ has joined #openstack-keystone09:47
*** aojea has quit IRC09:51
*** aojea has joined #openstack-keystone09:52
*** aojea_ has quit IRC09:55
*** aojea_ has joined #openstack-keystone09:58
*** edmondsw has joined #openstack-keystone10:00
*** aojea has quit IRC10:00
*** aojea has joined #openstack-keystone10:02
*** edmondsw has quit IRC10:04
*** aojea_ has quit IRC10:05
*** aojea_ has joined #openstack-keystone10:08
*** aojea has quit IRC10:11
*** aojea has joined #openstack-keystone10:12
*** namnh has quit IRC10:14
*** aojea_ has quit IRC10:15
*** aojea_ has joined #openstack-keystone10:17
*** gmann has quit IRC10:19
*** aojea has quit IRC10:20
*** aojea has joined #openstack-keystone10:23
*** aojea_ has quit IRC10:26
*** aojea_ has joined #openstack-keystone10:28
*** aojea_ has quit IRC10:29
*** aojea has quit IRC10:30
*** markvoelker has quit IRC10:32
*** aojea has joined #openstack-keystone10:44
*** aojea_ has joined #openstack-keystone10:47
*** aojea has quit IRC10:50
*** markvoelker has joined #openstack-keystone11:32
*** markvoelker has quit IRC11:37
*** nicolasbock has joined #openstack-keystone11:58
*** annp has quit IRC12:01
*** links has quit IRC12:13
*** edmondsw has joined #openstack-keystone12:19
*** edmondsw has quit IRC12:20
*** markvoelker has joined #openstack-keystone12:34
*** dave-mccowan has joined #openstack-keystone12:35
*** markvoelker has quit IRC12:38
*** aojea_ has quit IRC12:59
*** magicboiz has quit IRC13:06
*** tlam__ has joined #openstack-keystone13:06
*** gmann has joined #openstack-keystone13:18
*** dave-mccowan has quit IRC13:21
*** markvoelker has joined #openstack-keystone13:28
*** edmondsw has joined #openstack-keystone13:39
*** edmondsw has quit IRC13:44
*** efried has joined #openstack-keystone13:46
*** tlam__ has quit IRC13:50
*** raildo has joined #openstack-keystone14:10
*** edmondsw has joined #openstack-keystone14:14
lbragstado/14:27
lbragstadmnaser: thanks for the assist14:50
mnaserlbragstad: np :)14:50
*** nkinder has joined #openstack-keystone14:58
*** aojea has joined #openstack-keystone14:58
*** efried has quit IRC15:02
*** dave-mccowan has joined #openstack-keystone15:02
*** efried has joined #openstack-keystone15:13
openstackgerritLance Bragstad proposed openstack/oslo.policy master: Add a release note for enforce_scope  https://review.openstack.org/53075615:23
openstackgerritLance Bragstad proposed openstack/keystone master: Use keystone.common.provider_api for resource APIs  https://review.openstack.org/53024315:32
*** spilla has joined #openstack-keystone15:35
*** gmann has quit IRC15:37
*** david-lyle has joined #openstack-keystone15:47
*** panbalag has joined #openstack-keystone15:50
*** panbalag has quit IRC15:56
*** panbalag has joined #openstack-keystone16:06
*** kmalloc has joined #openstack-keystone16:09
*** panbalag has left #openstack-keystone16:10
*** rob_d has joined #openstack-keystone16:12
*** rob_d has quit IRC16:15
*** panbalag has joined #openstack-keystone16:18
*** panbalag has left #openstack-keystone16:19
*** gagehugo_web has joined #openstack-keystone16:39
*** gagehugo_web has quit IRC16:40
*** pcaruana has quit IRC16:41
*** aojea has quit IRC16:56
*** gyee has joined #openstack-keystone17:01
*** rmascena has joined #openstack-keystone17:16
*** raildo has quit IRC17:18
*** d0ugal has quit IRC17:19
*** d0ugal has joined #openstack-keystone17:20
gagehugoo/17:37
openstackgerritLance Bragstad proposed openstack/oslo.policy master: Add a release note for enforce_scope  https://review.openstack.org/53075617:37
*** mvk has quit IRC17:49
*** catintheroof has joined #openstack-keystone17:51
kmalloci need more coffee.17:55
kmallocyep, more coffee needed. =/17:56
lbragstad++17:56
kmallocgonna grab coffee before meeting.17:57
kmalloc..........17:57
*** harlowja has joined #openstack-keystone18:12
gagehugoo/ gonna grab lunch then will be back18:31
lbragstadcmurphy: https://review.openstack.org/#/c/530501/1 seems to be in merge conflict18:37
lbragstadotherwise it looks great18:37
cmurphyoh woops18:40
openstackgerritColleen Murphy proposed openstack/keystone master: Deprecate [trust]/enabled option  https://review.openstack.org/53050118:42
kmalloc+2/+A on that.18:43
cmurphytyty18:44
*** aojea has joined #openstack-keystone18:52
*** aojea_ has joined #openstack-keystone18:58
*** tesseract has quit IRC18:59
lbragstad#startmeeting keystone-office-hours19:00
openstackMeeting started Tue Jan  2 19:00:51 2018 UTC and is due to finish in 60 minutes.  The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot.19:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.19:00
*** openstack changes topic to " (Meeting topic: keystone-office-hours)"19:00
*** ChanServ changes topic to "Queens release schedule: https://releases.openstack.org/queens/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h | Trello: https://trello.com/b/5F0h9Hoe/keystone"19:00
openstackThe meeting name has been set to 'keystone_office_hours'19:00
lbragstadalrighty19:00
*** aojea has quit IRC19:01
*** aojea has joined #openstack-keystone19:03
*** aojea_ has quit IRC19:05
lbragstada bunch of the api-ref patches are looking good if anyone is interested in reviewing https://review.openstack.org/#/q/topic:api-ref-reorganization+(status:open+OR+status:merged)19:11
*** aojea has quit IRC19:11
lbragstadcmurphy: do you have follow up thoughts on https://review.openstack.org/#/c/529914/9 ?19:14
cmurphylbragstad: I still don't understand why it needs a new method and why the ldap driver needed to be modified but i'd have to play with it to be able to give solid feedback19:22
lbragstadyeah - same here...19:23
cmurphyunfortunately not in a position to do that atm19:26
gagehugoo/19:29
gagehugoI'll take a look at those api pages19:30
*** ayoung has joined #openstack-keystone19:42
ayoungkmalloc, what a wonderful naming convention.19:43
ayoung"common" for what is explicitly supposed to be for a specific API.19:44
kmallocayoung: ?19:44
ayoungConvert use of self.<provider_api> to keystone.common.provider_api.ProviderAPIs.<provider_api> for manager calls19:44
ayoungeverything is now "common"19:44
kmallocbecause the storage location is common code.19:45
kmallocmove it from common to keystone.provider_apis then19:45
kmalloci'd +2 it.19:45
ayoungOh, I get it....just that there is no need for the uncommon anymore...19:45
kmallocnot sure if you're unhappy with it or not.19:45
kmallocfwiw.19:45
ayoungJust laughing19:46
kmallocok.19:46
kmalloc*shrug*19:46
ayoungI was the one that origianlly organizaed the codebase with a subdir for each section19:46
ayoungI do like the idea that the interfaces are defined one place and the implementation separate, so no real complaints19:47
kmallocah19:48
kmallocsorry context switching pretty hard atm, couldn't read tone of your typing ;)19:48
kmallocyeah, i am very happy that the "dependency" injection part is gone and centrally referenced.19:48
kmallocit'll be easier to understand (long term), less "magic"19:48
ayoungBut I think there was an assumption back when we wrote this that the APIs would be publically accessable, due to things like keystone-manage type behavior, and I am pretty sure that I don't want that anymore, either.  Kindof of the mind that everything should have to come through the web these days19:49
kmallocthats fair, i think keystone-manage is the only real exception - otherwise everything is "private" in code. we do kindof need the implementations centralized somehow.19:51
kmallocsimply centralizing the instantiation (and locking that) is sufficent imo. i don't think we're really encouraging people to make more keystone-manage like applications.19:51
ayoungOr third party drivers...19:51
kmallocthose are rare.19:52
kmalloci would be happy to nuke 3rd party driver support (and the whole entry-point loaders) but that is a bigger conversation19:52
ayoungI need to complete my "Running Keystone in OpenShift" implementation to figure out what I want to do about configuration19:52
ayoungkmalloc, actually the reason I was checking in was that I was thinking about how long it takes to get patches merged.  I think it is hurting the project.19:56
*** spilla has quit IRC19:56
ayoungkmalloc, I was wondering if there was a subset of patches that we could reduce to requiring a single +2 on.19:56
lbragstadkmalloc: i your patch for that19:57
lbragstadkmalloc: i proposed a bunch of other patches replicating it for each subsystem19:57
kmallocya, i saw\19:58
ayounglbragstad, what if we said "for a patch that only affects a single line of production code, a single +2 is sufficient for +A?"19:58
ayoungjust to start at the absolute minimum.19:58
ayoungOr...a patch that only adds tests19:58
ayoungor some other set of low-overhead changes...19:58
kmallocayoung: honestly, i usually use best judgement on what to single-core-approve, official policy or not19:58
kmallocthere are a number i simply push through (like simple string fixes, e.g. comments) etc.19:59
kmalloci always figure i can apologize if it messes up and we can revert if needed.19:59
kmallocjust FYI.19:59
*** d0ugal has quit IRC20:00
ayoungkmalloc, I was just trying to think of ways we could safely reduce the backlog20:00
kmallocayoung: delete it.20:00
kmalloccompletely.20:01
kmalloc:P20:01
ayoungUm...that is pretty much exactly the opposite of what I want to do, though.20:01
ayoungI want to just blindly approve it all and let it merge20:01
kmalloci honestly don't think the backlog is providing much of any benefit.20:02
kmallocand not because it's moving slow20:02
ayoungkmalloc, I stopped adding new patches due to the length of time it took to get things through20:04
ayoungThat is not healthy for a project20:05
lbragstadi think we just have an overall deficit in reviewers20:10
*** d0ugal has joined #openstack-keystone20:18
*** aojea has joined #openstack-keystone20:27
*** aojea_ has joined #openstack-keystone20:32
openstackgerritGage Hugo proposed openstack/keystone master: Reorganize api-ref: v3 authenticate-v3  https://review.openstack.org/53036520:32
*** aojea has quit IRC20:35
*** aojea has joined #openstack-keystone20:37
*** aojea_ has quit IRC20:41
ayounglbragstad, why do you think that is?20:42
ayoungI'd argue because there is not enough payoff for reviewing20:42
*** aojea_ has joined #openstack-keystone20:42
lbragstadi'm not sure - that's a good question20:44
*** aojea has quit IRC20:46
*** catintheroof has quit IRC20:46
ayounglbragstad, I know one thing I wish I had was a queue of reviews that I was responsibile for clearing20:46
*** catintheroof has joined #openstack-keystone20:46
lbragstadclearing?20:46
ayoungkinda like how dolph used to use nextreview20:46
ayounglike: I commit to reviwing them20:46
lbragstadoh20:47
ayoungnot every last one that is in the pipeline20:47
ayoungbut like, a queue, and I can come in, grab the highest priority, review it, and move on20:47
lbragstadnextreview had some logic built into it that handled stuff like that20:47
*** aojea has joined #openstack-keystone20:48
lbragstadiirc it tried to prioritize reviews based on the time it was in review20:48
ayounglbragstad, published stats would help20:49
ayoungtotal reviewed, number of +2As etc20:49
lbragstadi have review dashboards set up that help with that20:50
ayoungbut I think making it so a core could approve a wider array of patches is the primary thing20:50
ayoungif I could approve something in, say LDAP, that I feel comfortable signing off on, I'd love to move those kind of things along20:50
ayoungas opposed to +2 and it sits until it needs a rebase20:50
*** aojea_ has quit IRC20:50
*** catintheroof has quit IRC20:51
*** aojea_ has joined #openstack-keystone20:52
openstackgerritGage Hugo proposed openstack/keystone master: Reorganize api-ref: v3 project-tags  https://review.openstack.org/53053320:53
*** aojea has quit IRC20:55
gagehugolbragstad the api-ref changes should be good now, fixed the two that had minor issues, the rest look good20:57
*** aojea has joined #openstack-keystone20:58
*** aojea has quit IRC20:58
*** aojea_ has quit IRC21:01
lbragstadkmalloc: do you want to follow up on https://bugs.launchpad.net/keystone/+bug/1729933 ?21:02
openstackLaunchpad bug 1729933 in OpenStack Identity (keystone) "region update doesn't update extras" [Undecided,In progress] - Assigned to David Lyle (david-lyle)21:02
lbragstadgagehugo: awesome, thanks21:02
lbragstadgagehugo: i should get around to reviewing https://review.openstack.org/#/c/481284/ this week too21:13
gagehugolbragstad I think that needs some fine tuning still, but it should be close21:17
*** aojea has joined #openstack-keystone21:18
*** aojea_ has joined #openstack-keystone21:18
openstackgerritMerged openstack/oslo.policy master: Add a release note for enforce_scope  https://review.openstack.org/53075621:21
*** aojea has quit IRC21:22
*** jose-phillips has joined #openstack-keystone21:23
*** aojea has joined #openstack-keystone21:24
*** aojea_ has quit IRC21:27
*** aojea has quit IRC21:31
*** rcernin has joined #openstack-keystone21:45
*** aojea has joined #openstack-keystone21:45
*** dave-mccowan has quit IRC21:47
*** aojea_ has joined #openstack-keystone21:51
*** logan- has joined #openstack-keystone21:53
*** aojea has quit IRC21:53
*** mvk has joined #openstack-keystone21:56
*** aojea has joined #openstack-keystone21:56
*** aojea_ has quit IRC21:59
logan-hello. I'm trying to use oslopolicy-policy-generator to dump the base RBAC so it can be combined with my policy overrides and provided to horizon. with nova i'm able to dump RBAC using "/path/to/nova/venv/bin/oslopolicy-policy-generator --namespace nova", but the doing the same with keystone using "keystone" or "identity" as the namespace does not work.22:00
*** aojea_ has joined #openstack-keystone22:01
lbragstadlogan-: do you have keystone installed?22:01
lbragstadlet me see if i can recreate22:01
logan-o/ lbragstad. yep keystone's installed. here's the venv and output for the oslopolicy command at the bottom: http://paste.openstack.org/raw/636624/22:03
lbragstadhuh - weird22:03
lbragstadi can recreate22:03
*** aojea has quit IRC22:04
ayounglbragstad, logan- I bet it is a dependency issue22:04
ayoungtrying to load Keystone fails cuz some other library is missing, and I bet  that is pulled in from oslopolicy polgen22:05
*** aojea has joined #openstack-keystone22:06
ayoungoslo.policy.policies =22:07
ayoung    # With the move of default policy in code list_rules returns a list of22:07
ayoung    # the default defined polices.22:07
ayoung    keystone = keystone.common.policies:list_rules22:07
ayoungthat is from setup.cfg22:07
ayoungis that what iti is trying to load?22:07
lbragstadwell - it's should be an entrypoint in oslo.policy22:07
lbragstadkeystone is just responsible for exposing the namespace22:07
lbragstadhttps://github.com/openstack/keystone/blob/master/config-generator/keystone-policy-generator.conf22:07
lbragstadwhich is the same as what nova defines22:08
lbragstadhttps://github.com/openstack/nova/blob/master/etc/nova/nova-policy-generator.conf22:08
*** aojea_ has quit IRC22:09
ayoungseems like it is not registered22:09
*** aojea_ has joined #openstack-keystone22:11
ayoungyep, reproduced it here, too22:12
*** aojea has quit IRC22:14
lbragstadi think we're missing this entrypoint22:15
lbragstadhttps://docs.openstack.org/oslo.policy/latest/user/usage.html#merged-file-generation22:15
lbragstadwhich just needs something to return the _ENFORCER22:15
lbragstadso keystone.common.policy:get_enforcer22:15
lbragstador something like that22:15
lbragstad#endmeeting22:16
*** openstack changes topic to "Queens release schedule: https://releases.openstack.org/queens/schedule.html | Meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | Bugs that need triaging: http://bit.ly/2iJuN1h | Trello: https://trello.com/b/5F0h9Hoe/keystone"22:16
openstackMeeting ended Tue Jan  2 22:16:12 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)22:16
openstackMinutes:        http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-01-02-19.00.html22:16
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-01-02-19.00.txt22:16
openstackLog:            http://eavesdrop.openstack.org/meetings/keystone_office_hours/2018/keystone_office_hours.2018-01-02-19.00.log.html22:16
lbragstadlogan-: certainly a bug22:16
lbragstadlogan-: would you be able to open up something in launchpad?22:16
lbragstadwe can get a patch up shortly, i think we're missing something with how we wire up the entry poionts22:16
lbragstadpoints*22:16
*** aojea has joined #openstack-keystone22:17
*** aojea has quit IRC22:19
* lbragstad has to run22:19
lbragstadi'll be on later though22:19
*** aojea_ has quit IRC22:20
logan-sorry was afk a minute. yup will get a bug opened. thanks for confirming it22:20
logan-filed @ https://bugs.launchpad.net/keystone/+bug/174095122:25
openstackLaunchpad bug 1740951 in OpenStack Identity (keystone) "Unable to dump policy" [Undecided,New]22:25
*** rmascena has quit IRC22:34
*** catintheroof has joined #openstack-keystone22:46
*** edmondsw has quit IRC23:19
*** edmondsw has joined #openstack-keystone23:19
*** edmondsw has quit IRC23:24

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!