*** dstepanenko has joined #openstack-keystone | 00:00 | |
*** thorst has joined #openstack-keystone | 00:04 | |
*** dstepanenko has quit IRC | 00:05 | |
*** aojea has joined #openstack-keystone | 00:17 | |
*** aojea has quit IRC | 00:22 | |
*** kornicameister has quit IRC | 00:25 | |
*** kornicameister has joined #openstack-keystone | 00:26 | |
*** mjax has joined #openstack-keystone | 00:26 | |
*** mjax has quit IRC | 00:27 | |
*** edmondsw has joined #openstack-keystone | 00:30 | |
*** aojea has joined #openstack-keystone | 00:31 | |
*** thorst has quit IRC | 00:31 | |
*** edmondsw has quit IRC | 00:34 | |
*** aojea has quit IRC | 00:35 | |
*** kornicameister has quit IRC | 00:40 | |
*** sbezverk has quit IRC | 00:44 | |
*** kornicameister has joined #openstack-keystone | 00:45 | |
*** markvoelker has joined #openstack-keystone | 00:45 | |
*** dave-mccowan has joined #openstack-keystone | 01:07 | |
*** Shunli has joined #openstack-keystone | 01:08 | |
*** thorst has joined #openstack-keystone | 01:08 | |
*** thorst has quit IRC | 01:08 | |
*** thorst has joined #openstack-keystone | 01:09 | |
*** ioggstream has quit IRC | 01:10 | |
*** thorst has quit IRC | 01:13 | |
*** thorst has joined #openstack-keystone | 01:25 | |
*** thorst has quit IRC | 01:27 | |
*** kornicameister has quit IRC | 01:30 | |
*** kornicameister has joined #openstack-keystone | 01:35 | |
*** gongysh has joined #openstack-keystone | 01:47 | |
*** dstepanenko has joined #openstack-keystone | 01:48 | |
*** dstepanenko has quit IRC | 01:53 | |
*** otleimat has quit IRC | 01:54 | |
*** ducttape_ has joined #openstack-keystone | 02:03 | |
*** aselius has quit IRC | 02:04 | |
*** ducttap__ has joined #openstack-keystone | 02:06 | |
*** ducttape_ has quit IRC | 02:09 | |
*** ducttape_ has joined #openstack-keystone | 02:10 | |
*** ducttap__ has quit IRC | 02:13 | |
*** dave-mccowan has quit IRC | 02:27 | |
*** thorst has joined #openstack-keystone | 02:28 | |
openstackgerrit | Merged openstack/keystone master: Remove unused hints from assignment APIs https://review.openstack.org/491921 | 02:28 |
---|---|---|
*** thorst has quit IRC | 02:29 | |
*** kornicameister has quit IRC | 02:29 | |
*** kornicameister has joined #openstack-keystone | 02:35 | |
*** dstepanenko has joined #openstack-keystone | 02:43 | |
*** kbaegis has quit IRC | 02:45 | |
*** dstepanenko has quit IRC | 02:47 | |
*** dklyle has quit IRC | 02:49 | |
*** ducttap__ has joined #openstack-keystone | 02:50 | |
*** zhurong has joined #openstack-keystone | 02:52 | |
*** ducttape_ has quit IRC | 02:53 | |
*** dave-mccowan has joined #openstack-keystone | 02:54 | |
*** kbaegis has joined #openstack-keystone | 02:55 | |
*** markvoelker has quit IRC | 03:02 | |
*** markvoelker has joined #openstack-keystone | 03:03 | |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone master: WIP: Reproduce 1703917 https://review.openstack.org/492362 | 03:15 |
samueldmq | lbragstad: gagehugo: ^ tried this to see if the bug would happen within keystone tests. I ran that 1000x and it worked as expected | 03:16 |
samueldmq | something very specific to tempest/that keystone setup is making it to fail | 03:16 |
samueldmq | I will give a try with tempest tomorrow. we hit it in https://review.openstack.org/#/c/487143/ | 03:16 |
*** ducttap__ has quit IRC | 03:18 | |
*** david-lyle has joined #openstack-keystone | 03:22 | |
*** Shunli has quit IRC | 03:25 | |
*** kbaegis1 has joined #openstack-keystone | 03:26 | |
*** nicolasbock has joined #openstack-keystone | 03:29 | |
*** kbaegis has quit IRC | 03:29 | |
*** dave-mccowan has quit IRC | 03:48 | |
*** kornicameister has quit IRC | 03:53 | |
*** kornicameister has joined #openstack-keystone | 03:54 | |
*** markvoelker has quit IRC | 04:01 | |
*** markvoelker has joined #openstack-keystone | 04:01 | |
*** thorst has joined #openstack-keystone | 04:04 | |
*** rmcall has quit IRC | 04:07 | |
*** thorst has quit IRC | 04:09 | |
*** ducttape_ has joined #openstack-keystone | 04:18 | |
*** ducttape_ has quit IRC | 04:23 | |
*** thorst has joined #openstack-keystone | 04:26 | |
*** gongysh has quit IRC | 04:30 | |
*** thorst has quit IRC | 04:30 | |
*** dstepanenko has joined #openstack-keystone | 04:31 | |
*** dstepanenko has quit IRC | 04:35 | |
*** sbezverk has joined #openstack-keystone | 04:36 | |
*** sbezverk has quit IRC | 04:40 | |
*** rmcall has joined #openstack-keystone | 04:40 | |
*** david-lyle has quit IRC | 04:44 | |
*** rmcall has quit IRC | 04:45 | |
*** dklyle has joined #openstack-keystone | 04:45 | |
*** gyee has joined #openstack-keystone | 04:48 | |
*** prashkre__ has joined #openstack-keystone | 04:54 | |
*** gongysh has joined #openstack-keystone | 05:09 | |
*** prashkre__ has quit IRC | 05:16 | |
*** dstepanenko has joined #openstack-keystone | 05:27 | |
*** dstepanenko has quit IRC | 05:31 | |
*** dstepanenko has joined #openstack-keystone | 05:45 | |
*** mvk has joined #openstack-keystone | 05:49 | |
*** rcernin has joined #openstack-keystone | 06:05 | |
*** dstepanenko has quit IRC | 06:05 | |
*** rajalokan has joined #openstack-keystone | 06:06 | |
*** junbo has quit IRC | 06:12 | |
*** junbo has joined #openstack-keystone | 06:15 | |
*** ducttape_ has joined #openstack-keystone | 06:20 | |
*** ducttape_ has quit IRC | 06:25 | |
*** thorst has joined #openstack-keystone | 06:26 | |
*** prashkre has joined #openstack-keystone | 06:28 | |
*** thorst has quit IRC | 06:31 | |
*** kukacz has joined #openstack-keystone | 06:43 | |
*** kukacz_ has joined #openstack-keystone | 06:44 | |
*** rajalokan has quit IRC | 06:47 | |
*** kukacz has quit IRC | 06:47 | |
*** dstepanenko has joined #openstack-keystone | 06:52 | |
*** dstepanenko has quit IRC | 06:56 | |
*** tobberydberg has joined #openstack-keystone | 07:00 | |
*** mjax has joined #openstack-keystone | 07:00 | |
*** mjax has quit IRC | 07:01 | |
*** kukacz_ has quit IRC | 07:10 | |
*** kukacz has joined #openstack-keystone | 07:10 | |
*** tesseract has joined #openstack-keystone | 07:13 | |
*** prashkre has quit IRC | 07:59 | |
*** dstepanenko has joined #openstack-keystone | 08:01 | |
*** Drankis has joined #openstack-keystone | 08:17 | |
*** ducttape_ has joined #openstack-keystone | 08:22 | |
Drankis | Hello! Can someone point me how I can do upstream changes to stable branches? I find a bug and want to solve it in Newton release. | 08:25 |
Drankis | Code in master release are already revorked, so no need to change something in master, but small change in Newton are necessary. | 08:26 |
*** ducttape_ has quit IRC | 08:26 | |
*** thorst has joined #openstack-keystone | 08:27 | |
*** dstepanenko has quit IRC | 08:30 | |
*** hoonetorg has quit IRC | 08:32 | |
*** thorst has quit IRC | 08:32 | |
*** jaosorior has quit IRC | 08:37 | |
*** prashkre has joined #openstack-keystone | 08:37 | |
*** jaosorior has joined #openstack-keystone | 08:41 | |
openstackgerrit | Aleksey Nakoryakov proposed openstack/python-keystoneclient master: Closes-Bug: 1498693. Raise ClientError if url parameter is None. Added test for this. https://review.openstack.org/492435 | 08:46 |
openstack | bug 1498693 in python-keystoneclient "unfriendly error when keystone tries to parse a URL" [Medium,Triaged] https://launchpad.net/bugs/1498693 - Assigned to Aleksey Nakoryakov (alfnak) | 08:46 |
*** hoonetorg has joined #openstack-keystone | 08:49 | |
*** jaosorior has quit IRC | 08:54 | |
*** dstepanenko has joined #openstack-keystone | 08:58 | |
*** gongysh has quit IRC | 09:19 | |
*** gongysh has joined #openstack-keystone | 09:37 | |
*** kukacz has quit IRC | 09:39 | |
*** markvoelker has quit IRC | 09:42 | |
*** kukacz has joined #openstack-keystone | 09:47 | |
*** jaosorior has joined #openstack-keystone | 09:54 | |
*** mvk_ has joined #openstack-keystone | 10:02 | |
*** mvk has quit IRC | 10:05 | |
*** kukacz_ has joined #openstack-keystone | 10:11 | |
*** kukacz has quit IRC | 10:12 | |
*** kukacz_ has quit IRC | 10:13 | |
*** kukacz has joined #openstack-keystone | 10:22 | |
*** kukacz has quit IRC | 10:22 | |
*** kukacz has joined #openstack-keystone | 10:26 | |
*** kukacz has quit IRC | 10:26 | |
*** thorst has joined #openstack-keystone | 10:28 | |
*** thorst has quit IRC | 10:33 | |
*** zhurong has quit IRC | 10:39 | |
*** dstepanenko has quit IRC | 10:48 | |
*** dstepanenko has joined #openstack-keystone | 10:48 | |
openstackgerrit | Merged openstack/keystone master: Add description for relationship links in api-ref https://review.openstack.org/491934 | 10:49 |
*** gongysh has quit IRC | 11:01 | |
*** mkrcmari__ has joined #openstack-keystone | 11:01 | |
*** mvk_ has quit IRC | 11:04 | |
samueldmq | cmurphy: I wonder if returning v2.0 when you ask for v3 is a bug | 11:12 |
samueldmq | or the default behavior could be return the latest with there is no version matching what's requested | 11:13 |
samueldmq | re: bug 1709658 | 11:13 |
openstack | bug 1709658 in keystoneauth ""Could not find requested endpoint in Service Catalog" when requesting unavailable identity endpoint" [Undecided,New] https://launchpad.net/bugs/1709658 | 11:13 |
samueldmq | cc mordred ^ | 11:13 |
*** mkrcmari__ has quit IRC | 11:28 | |
*** mkrcmari__ has joined #openstack-keystone | 11:29 | |
cmurphy | samueldmq: i don't follow - the bug isn't that it's returning v2.0, it's that it's returning nothing | 11:32 |
*** kbaegis1 has quit IRC | 11:34 | |
*** kbaegis has joined #openstack-keystone | 11:34 | |
*** dstepanenko has quit IRC | 11:36 | |
samueldmq | cmurphy: but it should be returning v2.0, correct? | 11:40 |
samueldmq | what I mean is, the fact it was returning v2.0 when you were asking for v3 could be seen in 2 ways | 11:41 |
samueldmq | 1) it was a bug | 11:41 |
samueldmq | 2) working as designed, where when you ask for a version (v2 in that case) and it doesn't exist, return the latest available (v2.0 in that case) | 11:41 |
*** dave-mccowan has joined #openstack-keystone | 11:43 | |
cmurphy | samueldmq: it wasn't returning v2 when asked for v3, it was returning v3 despite what was in the catalog, which is weird but working as designed i think | 11:44 |
cmurphy | also - | 11:44 |
openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Allow discovery URLs to have trailing slashes https://review.openstack.org/492484 | 11:45 |
cmurphy | found it ^ | 11:45 |
*** kbaegis has quit IRC | 11:49 | |
*** kbaegis has joined #openstack-keystone | 11:49 | |
*** kbaegis has quit IRC | 11:53 | |
*** kbaegis has joined #openstack-keystone | 11:54 | |
*** raildo has joined #openstack-keystone | 12:01 | |
*** thorst has joined #openstack-keystone | 12:02 | |
*** kbaegis has quit IRC | 12:06 | |
*** kbaegis has joined #openstack-keystone | 12:06 | |
cmurphy | jeez ksa has so many unit tests now | 12:11 |
*** kbaegis1 has joined #openstack-keystone | 12:12 | |
*** kbaegis has quit IRC | 12:12 | |
samueldmq | cmurphy: is that fix related to the bug? | 12:15 |
samueldmq | cmurphy: I assume you're adding some tests now? | 12:15 |
cmurphy | samueldmq: it fixes the bug | 12:15 |
cmurphy | going to write a better commit message and add a test | 12:15 |
samueldmq | cmurphy: how was it failing because of the discovery url having a slash? | 12:16 |
samueldmq | if you don't mind detailing it a bit :-) | 12:17 |
*** kbaegis1 has quit IRC | 12:17 | |
*** kbaegis has joined #openstack-keystone | 12:17 | |
cmurphy | samueldmq: the url split on '/' which left an empty string at the end of url_parts, which is meaningless | 12:18 |
cmurphy | normally it sees the version at the end, finds it doesn't match, discards it, and tries again with the unversioned endpoint | 12:18 |
cmurphy | but it was just discarding the empty string and failing again to find a match with the versioned endpoint | 12:19 |
samueldmq | cmurphy: aha! because it do parts and reverse it | 12:19 |
samueldmq | the a discovery url of something like http://identity-server:5000/v3/ would fail | 12:20 |
mordred | cmurphy: good find! | 12:22 |
*** dstepanenko has joined #openstack-keystone | 12:22 | |
*** edmondsw has joined #openstack-keystone | 12:27 | |
*** dstepanenko has quit IRC | 12:28 | |
*** ioggstream has joined #openstack-keystone | 12:31 | |
*** catintheroof has joined #openstack-keystone | 12:45 | |
*** mkrcmari__ has quit IRC | 12:46 | |
*** sbezverk has joined #openstack-keystone | 12:48 | |
efried | cmurphy Ah, cool. I left my review before I caught up with this. | 12:53 |
cmurphy | efried: yeah i'm definitely not done | 12:54 |
efried | :) | 12:54 |
*** mvk has joined #openstack-keystone | 12:54 | |
prashkre | lbragstad: Hi. Gud morning! | 12:54 |
prashkre | lbragstad: could you please take a look at latest comment from Matthew on https://review.openstack.org/#/c/490138/ | 12:54 |
efried | Drankis Want to join me in #openstack-dev to talk about stable branch changes? | 12:55 |
*** jrist has joined #openstack-keystone | 12:58 | |
*** lucasxu has joined #openstack-keystone | 13:09 | |
lbragstad | prashkre: good morning, i've already reviewed it - it needs folks from stable to look at it | 13:12 |
prashkre | lbragstad: ok. Thank you!. could you please help me who can review from stable team?. | 13:14 |
prashkre | lbragstad: so that i can add to review list. | 13:15 |
lbragstad | prashkre: you can look up any of the team members using gerrit - like this | 13:15 |
lbragstad | https://review.openstack.org/#/admin/groups/538,members | 13:15 |
openstackgerrit | Colleen Murphy proposed openstack/keystoneauth master: Allow discovery URLs to have trailing slashes https://review.openstack.org/492484 | 13:19 |
prashkre | lbragstad: Thank you! | 13:21 |
*** kbaegis1 has joined #openstack-keystone | 13:27 | |
*** kbaegis has quit IRC | 13:29 | |
*** kbaegis has joined #openstack-keystone | 13:31 | |
*** kbaegis1 has quit IRC | 13:31 | |
*** kbaegis has quit IRC | 13:33 | |
*** kbaegis has joined #openstack-keystone | 13:34 | |
*** kbaegis has joined #openstack-keystone | 13:34 | |
*** kbaegis1 has joined #openstack-keystone | 13:36 | |
*** kbaegis2 has joined #openstack-keystone | 13:36 | |
*** kbaegis has quit IRC | 13:36 | |
Drankis | Hello all! Please, check my commit to Newton code, which solve issue with endpoint_filter catalog driver: https://review.openstack.org/#/c/492527/ | 13:37 |
*** kbaegis has joined #openstack-keystone | 13:38 | |
*** kbaegis has quit IRC | 13:40 | |
*** kbaegis3 has joined #openstack-keystone | 13:40 | |
*** kbaegis2 has quit IRC | 13:40 | |
*** kbaegis3 has quit IRC | 13:40 | |
*** kbaegis1 has quit IRC | 13:40 | |
*** ppiela has quit IRC | 13:42 | |
*** sjain has joined #openstack-keystone | 13:48 | |
*** sasaniak has joined #openstack-keystone | 13:51 | |
sasaniak | hi there | 13:51 |
sasaniak | i'm trying to better understand policy.rules, and i came across an issue that i'm unable to work out | 13:52 |
sasaniak | i have a user setup, https://safar.sk/openstack.txt | 13:52 |
sasaniak | with a policy file (only slightly modified): https://safar.sk/policy.json | 13:52 |
sasaniak | but i'm unable to list users when i try to do that as the user1 | 13:53 |
sasaniak | can anyone point me to what i'm doing wrong? | 13:53 |
kmalloc | lbragstad: the code from Drankis is Newton only? | 13:58 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Unset project ids for all identity backends https://review.openstack.org/491916 | 13:58 |
Drankis | kmalloc, yes, in ocata and master it is rewriten. | 13:58 |
lbragstad | cmurphy: kmalloc ^ added a unit test | 13:58 |
kmalloc | Drankis: well two things, Newton is in Phase 2 support status, meaning only critical bugs and security fixes. Not sure if this is a critical fix | 14:01 |
lbragstad | Drankis: do you know if there is a test case for this in master? | 14:02 |
kmalloc | The second thing, the endpoint filtering is something that shouldnt really be used. | 14:02 |
*** gongysh has joined #openstack-keystone | 14:03 | |
Drankis | kmalloc, for someone maybe it is :) Without this fix, if user use endpoint_filter he won't get running, for example, heat service or any other which use separate domain for administration purposes. | 14:03 |
*** gongysh has quit IRC | 14:03 | |
kmalloc | It is only maintained because we can't really remove the functionality. I highly recommend not using it, different catalogs based upon your scope is bad news. | 14:03 |
lbragstad | Drankis: you weren't able to recreate this in master? | 14:04 |
lbragstad | or stable/ocata? | 14:04 |
Drankis | lbragstad, again, there is not such code anymore. File in which I made changes did not exist anymore and functionality are compleatly rewriten. | 14:05 |
kmalloc | It provides zero extra security. It simply makes the catalog different depending on scope. If we could ditch endpoint filtering, I would have made that case before. | 14:05 |
Drankis | kmalloc, hmm, for me endpoint filters work great. Maybe you can suggest other method how is possible to hide internal/admin endpoints from end users? | 14:05 |
kmalloc | Don't hide them. | 14:06 |
Drankis | =] | 14:06 |
kmalloc | Changing the catalog based on scope is silly. | 14:06 |
kmalloc | It adds zero security. Anyone can use any endpoint, the catalog is just convenience for looking up. | 14:07 |
kmalloc | Use firewalls/etc to prevent access to endpoints you don't want users to access | 14:07 |
lbragstad | Drankis: https://github.com/openstack/keystone/commit/dafbf5b8b2ef93ef0e785432fd34629a9d76b248 | 14:09 |
* kmalloc strongly believes the catalog should be effective ly static regardless of who logs in (you can add or remove endpoints, but the catalog shouldnt change based upon soft differences such as auth scope) | 14:09 | |
*** spzala has joined #openstack-keystone | 14:10 | |
Drankis | kmalloc, exactly just don't want that regular users can list it. Internal/admin endpoints are well secured. More like cosmetic wish. | 14:11 |
*** dstepanenko has joined #openstack-keystone | 14:11 | |
kmalloc | Endpoint filtering should be deprecated (not slated for removal). I'll re-propose that with a follow up to the yaml catalog | 14:12 |
kmalloc | lbragstad: ^ | 14:12 |
Drankis | lbragstad, yeah, and completely https://github.com/openstack/keystone/commit/d35f36916e109f0d2557bb778424e7aee3bc6b31 | 14:14 |
lbragstad | kmalloc: i'd really like to find a way to do some sort of versioning so we can make it easier to do rewrites | 14:14 |
*** dstepanenko has quit IRC | 14:16 | |
*** prashkre has quit IRC | 14:16 | |
kmalloc | V4 | 14:16 |
kmalloc | Seriously | 14:16 |
lbragstad | kmalloc: adopting takes forever | 14:16 |
kmalloc | Just no requirement to change auth too | 14:16 |
kmalloc | That was the hard part | 14:16 |
lbragstad | auth also has to be discoverable though | 14:17 |
lbragstad | like you said before | 14:17 |
kmalloc | If v3 received no.features at all | 14:17 |
kmalloc | Stable. | 14:17 |
kmalloc | V4 was development (and well defined targets) | 14:17 |
kmalloc | It would work | 14:18 |
kmalloc | Sadly, we never seemed able to.do that last part. | 14:18 |
kmalloc | I won't block microversion impl, I simply don't support it. | 14:19 |
kmalloc | (I won't even -1 it unless code is bad) | 14:19 |
kmalloc | Just don't expect a +2 from me. | 14:19 |
lbragstad | kmalloc: well - i don't disagree with your reasoning for microversions | 14:20 |
kmalloc | I know, and my compromise is I promise not to block it | 14:20 |
kmalloc | If it is the way we have to move forward... It is the way. | 14:20 |
kmalloc | I'll concede that. I just can't approve/sign off on it personally | 14:21 |
lbragstad | but if it isn't - then finding a way to improve api without it taking forever would be nice | 14:21 |
kmalloc | I would much prefer a non-microversion option. | 14:21 |
*** Elangovan has joined #openstack-keystone | 14:21 | |
kmalloc | Unfortunately, my only thought/offer on that is major api versions. | 14:22 |
kmalloc | ATM. | 14:22 |
*** Elangovan has quit IRC | 14:22 | |
*** Elangovan has joined #openstack-keystone | 14:22 | |
*** nkinder has joined #openstack-keystone | 14:26 | |
lbragstad | hmm | 14:26 |
*** lbragstad has quit IRC | 14:28 | |
*** jamespage has joined #openstack-keystone | 14:28 | |
jamespage | hi | 14:29 |
jamespage | (hopefully) quick question about token revocation lists - do/did they only apply for PKI tokens? or do they also apply for UUID and Fernet formats as well? | 14:29 |
jamespage | we're dropping PKI support in the keystone charms they cycle - just figuring out what we do with regards to certs and ca files related to signing of revocation requests.. | 14:30 |
*** tobberyd_ has joined #openstack-keystone | 14:32 | |
*** sjain has quit IRC | 14:34 | |
*** tobberydberg has quit IRC | 14:36 | |
*** spzala has quit IRC | 14:37 | |
*** tobberyd_ has quit IRC | 14:37 | |
*** sjain has joined #openstack-keystone | 14:37 | |
*** ducttape_ has joined #openstack-keystone | 14:38 | |
*** ducttape_ has quit IRC | 14:39 | |
*** ducttape_ has joined #openstack-keystone | 14:42 | |
*** ducttap__ has joined #openstack-keystone | 14:43 | |
*** ducttape_ has quit IRC | 14:46 | |
*** PsionTheory has joined #openstack-keystone | 14:50 | |
*** sbezverk has quit IRC | 14:55 | |
kmalloc | jamespage: recommend not using them at all | 14:58 |
jamespage | kmalloc: that was what I thought | 14:59 |
jamespage | thanks for confirming | 14:59 |
* jamespage does not have to throw away the last hours work now :-) | 14:59 | |
*** lbragstad has joined #openstack-keystone | 14:59 | |
*** ChanServ sets mode: +o lbragstad | 14:59 | |
kmalloc | jamespage: use fernet tokens, do not use the revocation list (even with uuid tokens). Largely it was for pki tokens, but easiest bet turn off "revoke by id" and ignore the rev list | 14:59 |
kmalloc | :) | 14:59 |
kmalloc | jamespage: happy to make your life easier | 15:00 |
jamespage | :) | 15:00 |
knikolla | o/ | 15:03 |
*** otleimat has joined #openstack-keystone | 15:22 | |
*** spzala has joined #openstack-keystone | 15:23 | |
openstackgerrit | Samriddhi proposed openstack/keystone master: Update docs: fernet is the default provider https://review.openstack.org/486608 | 15:32 |
*** ppiela has joined #openstack-keystone | 15:43 | |
*** aselius has joined #openstack-keystone | 15:50 | |
*** dstepanenko has joined #openstack-keystone | 15:59 | |
efried | Where do keystone* logs go when they're not in a journalctl unit? | 15:59 |
efried | (Like, I think I'm using the wrong wsgi) | 15:59 |
efried | (This is devstack btw) | 16:00 |
*** dklyle is now known as david-lyle | 16:02 | |
*** dstepanenko has quit IRC | 16:03 | |
*** Elangovan has quit IRC | 16:14 | |
*** sjain has quit IRC | 16:15 | |
*** Drankis has quit IRC | 16:15 | |
*** Elangovan has joined #openstack-keystone | 16:16 | |
*** tobberydberg has joined #openstack-keystone | 16:22 | |
*** pcaruana has quit IRC | 16:25 | |
*** tobberydberg has quit IRC | 16:26 | |
*** lucasxu has quit IRC | 16:27 | |
*** rcernin has quit IRC | 16:33 | |
knikolla | efried: screen -r? | 16:45 |
efried | knikolla Thanks - turns out it was in /var/log/apache2 | 16:46 |
knikolla | efried: or actually in /var/log | 16:46 |
knikolla | yeah | 16:46 |
efried | :) | 16:46 |
knikolla | was gonna type that. | 16:46 |
knikolla | the keystone screen is basically a tailf on /var/log/apache/ | 16:46 |
samueldmq | lbragstad: I ran test_password_history_not_enforced_in_admin_reset 110 times | 16:49 |
kmalloc | samueldmq: any luck? | 16:49 |
samueldmq | I was able to get 1 failure, at least was able to reproduce | 16:49 |
lbragstad | nice | 16:49 |
samueldmq | I will do further debugging to see what I get | 16:50 |
knikolla | samueldmq: wanna share the logs? | 16:50 |
lbragstad | kmalloc: you like meta programming don't you? | 16:50 |
samueldmq | knikolla: no they're just mine | 16:50 |
samueldmq | muahaha | 16:50 |
samueldmq | knikolla: give me a sec | 16:50 |
knikolla | samueldmq: evil, haha | 16:51 |
samueldmq | do I get the keystone logs in /var/logs/apache2/error.log ? | 16:51 |
samueldmq | or would that be access.log? it's been a while ... :( | 16:52 |
kmalloc | lbragstad: sigh. i can meta program | 16:53 |
kmalloc | lbragstad: why? | 16:53 |
lbragstad | kmalloc: how come the last two assertions here fail? | 16:53 |
lbragstad | v | 16:53 |
lbragstad | https://gist.github.com/lbragstad/e0558a167e8abfe5f5d6ac1c181972fd | 16:53 |
*** dstepanenko has joined #openstack-keystone | 16:53 | |
*** mjax has joined #openstack-keystone | 16:54 | |
kmalloc | sec let me open that in an actual browser | 16:54 |
lbragstad | kmalloc: when the registry is built, it appears that the values in the registry aren't actual objects | 16:54 |
lbragstad | but they are types of the class | 16:54 |
*** aojea has joined #openstack-keystone | 16:55 | |
kmalloc | ok so you're trying to use metaclasses to adjust the isinstance? | 16:55 |
lbragstad | kmalloc: i want to use a meta class to build the dependency registry | 16:56 |
lbragstad | kmalloc: i was shuffling through old reviews and found this https://review.openstack.org/#/c/163029/4/keystone/common/dependency.py | 16:56 |
lbragstad | i want to use it as a way to get around the following pattern | 16:57 |
lbragstad | something = SomeAPI() | 16:57 |
lbragstad | set_provider('some_api', something) | 16:57 |
lbragstad | where you have to handle registration of things manually | 16:57 |
*** dstepanenko has quit IRC | 16:58 | |
lbragstad | my thought process was that using a metaclass would enforce that on manager automatically | 16:58 |
kmalloc | so metaclasses are handled at exactly one point, they are at import time | 16:58 |
lbragstad | managers* | 16:58 |
kmalloc | also don't use __metaclass__ =, use @six.add_metaclass() | 16:59 |
kmalloc | but that aside | 16:59 |
lbragstad | right - that's what i'm doing locally | 16:59 |
lbragstad | with the keystone code | 16:59 |
lbragstad | this was just a test | 16:59 |
lbragstad | let me push what i have so you can have a look | 16:59 |
kmalloc | i have your local example here | 16:59 |
kmalloc | and seeing the assertion error | 16:59 |
kmalloc | let me poke for a sec | 16:59 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: WIP: Remove dependency.provider https://review.openstack.org/492621 | 17:00 |
lbragstad | kmalloc: ^ | 17:00 |
*** ppiela_ has joined #openstack-keystone | 17:01 | |
kmalloc | your isinstance in your gist is backwards | 17:02 |
kmalloc | isinstance(obj, class_or_tuple, /) | 17:02 |
kmalloc | oh wait no | 17:02 |
kmalloc | i am mis-reading | 17:03 |
kmalloc | (sorry catching up on coffee) | 17:03 |
kmalloc | oh | 17:03 |
kmalloc | lbragstad: wait, ok | 17:03 |
kmalloc | --- | 17:03 |
kmalloc | assert isinstance(registry['identity_api'], IdentityApi) | 17:03 |
kmalloc | that is not asserting identity_api is an instance | 17:04 |
*** spilla has joined #openstack-keystone | 17:04 | |
kmalloc | your registry has the non-instanced versions in it | 17:04 |
*** ppiela has quit IRC | 17:04 | |
kmalloc | lbragstad: __new__ is done at import time, so what you've done is you've created a registry of the non-instance classes (prior to calling IdentityApi()) | 17:05 |
kmalloc | assert isinstance(registry['identity_api'], IdentityApi) | 17:05 |
kmalloc | wont work | 17:05 |
kmalloc | assert isinstance(registry['identity_api'], identity) | 17:05 |
kmalloc | does work | 17:05 |
*** tobberydberg has joined #openstack-keystone | 17:05 | |
lbragstad | ah | 17:05 |
kmalloc | as would assert isinstance(IdentityApi, identity) | 17:05 |
lbragstad | sure - that bit makes sense | 17:06 |
kmalloc | so, if you want to use a metaclass to change *how* a class is instanced, you cna replace __init__ within the __new__ and wrap the explicit __init__ passed [if it is] | 17:06 |
*** aojea has quit IRC | 17:07 | |
kmalloc | this is again because __new__ is called at import time (it's what builds the class object) | 17:07 |
*** aojea has joined #openstack-keystone | 17:07 | |
lbragstad | __new__ seemed like the right place for registry code to run | 17:07 |
* lbragstad shrugs | 17:07 | |
kmalloc | yeah it would need to be a new __init__ that is replaced in the class_dict that is passed into new | 17:07 |
kmalloc | so, look in class_dict, and determine if __init__ is in there, if it is, wrap the init and add your registry code, if it isn't supply an __init__ that does registry *and* calls super() | 17:08 |
kmalloc | the super() call is going to be wonky, since you'll need to supply info from cls not from Meta itself | 17:09 |
*** Elangovan has quit IRC | 17:09 | |
kmalloc | i can draft up a quick example. | 17:09 |
lbragstad | kmalloc: ack | 17:09 |
lbragstad | fixing what i have locally and i'll push another ps | 17:09 |
*** tobberydberg has quit IRC | 17:10 | |
*** mjax has quit IRC | 17:12 | |
*** aojea has quit IRC | 17:12 | |
*** mvk has quit IRC | 17:14 | |
*** mjax has joined #openstack-keystone | 17:19 | |
*** mjax has quit IRC | 17:20 | |
kmalloc | lbragstad: https://gist.github.com/morganfainberg/dceb6be7c861febbc0e0ef40cfc18016 | 17:26 |
*** ducttap__ has quit IRC | 17:27 | |
otleimat | lbragstad: working on https://review.openstack.org/#/c/408304/ I made some changes locally which clean part of the code up and made some adjustments to make it clear that all the options are not optional, I'm not sure if I what I implemented is acceptable. Should I push up to Gerrit to receive feedback? | 17:28 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove dependency.provider https://review.openstack.org/492621 | 17:29 |
*** ducttape_ has joined #openstack-keystone | 17:30 | |
lbragstad | otleimat: yes - please | 17:30 |
kmalloc | lbragstad: going to need another level of some stuff to inspect the __init__ args. | 17:30 |
lbragstad | kmalloc: interesting | 17:30 |
lbragstad | otleimat: when in doubt, push early and often | 17:31 |
kmalloc | but... that gist is pretty close | 17:31 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove dependency.provider https://review.openstack.org/492621 | 17:32 |
lbragstad | kmalloc: ack - ^ made all the name changes so that we can resolve the name from the class itself | 17:32 |
kmalloc | anywya... | 17:33 |
kmalloc | metaclasses make for pain | 17:33 |
kmalloc | just as an FYI | 17:33 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove dependency.provider https://review.openstack.org/492621 | 17:34 |
kmalloc | lbragstad: i don't see how that is going to work | 17:38 |
kmalloc | you're registering the class? | 17:38 |
kmalloc | and then... how do you call the instanced version of the clasS? | 17:38 |
lbragstad | kmalloc: it's still broken - i'm working through it | 17:38 |
otleimat | lbragstad: will do shortly, it seems though that it isn't possible without logic added in main(), I reformatted the logic, and adjusted the parser slightly. The unit tests will fail rn because they don't hit main from test_cli.py, wondering if there is way to write unit tests that will go through and actually hit the logic? | 17:38 |
lbragstad | kmalloc: my patch is still missing these bits https://review.openstack.org/#/c/163029/4/keystone/backends.py | 17:39 |
kmalloc | lbragstad: yeah you need to do it in __init__. | 17:39 |
kmalloc | you can't set_provider on the non-instance | 17:39 |
lbragstad | kmalloc: only you don't need the dependency.set_provider() pattern there | 17:40 |
kmalloc | except the registry the way you have it is the non-instanced classes | 17:40 |
lbragstad | right - i need to change that | 17:40 |
kmalloc | yeah, you're going to also need to do some inspect work to pull out the signature of the __init__ that is in the super *or* in the class_dict to make sure you're passing the right stuff to it (notably if it takes no args, except self) | 17:41 |
*** ioggstream has quit IRC | 17:42 | |
*** prashkre has joined #openstack-keystone | 17:44 | |
*** aselius has quit IRC | 17:52 | |
*** prashkre_ has joined #openstack-keystone | 17:52 | |
*** prashkre has quit IRC | 17:52 | |
*** spzala has quit IRC | 17:55 | |
*** tobberydberg has joined #openstack-keystone | 18:01 | |
*** aselius has joined #openstack-keystone | 18:03 | |
*** ducttape_ has quit IRC | 18:04 | |
*** spilla has quit IRC | 18:09 | |
*** tobberydberg has quit IRC | 18:12 | |
*** sjain has joined #openstack-keystone | 18:20 | |
lbragstad | https://review.openstack.org/#/c/491916/ is ready for some reviews | 18:28 |
lbragstad | ^ we should try and get that merged by EOD | 18:28 |
*** ducttape_ has joined #openstack-keystone | 18:32 | |
*** rcernin has joined #openstack-keystone | 18:35 | |
*** sjain has quit IRC | 18:39 | |
*** dstepanenko has joined #openstack-keystone | 18:41 | |
*** spzala has joined #openstack-keystone | 18:42 | |
*** spzala has quit IRC | 18:43 | |
*** spzala has joined #openstack-keystone | 18:44 | |
*** alexz__ has joined #openstack-keystone | 18:44 | |
*** dstepanenko has quit IRC | 18:46 | |
*** alexz__ has quit IRC | 18:52 | |
*** alexz__ has joined #openstack-keystone | 18:52 | |
kmalloc | lbragstad: lgtm +2 | 18:56 |
alexz__ | hi everyone. any ideas how to deal with 401 errors http://paste.openstack.org/show/618091/ which appear during vm related tempest tests run? I have Ocata ha setup with fernet keys on shared glusterfs volumes. More info: http://paste.openstack.org/show/618089/ | 18:58 |
*** rcernin has quit IRC | 18:59 | |
lbragstad | alexz__: the InvalidFernet key error is only used in one place within keystone | 19:00 |
lbragstad | and that's if the fernet tokens can't be decrypted from by the cryptography library | 19:01 |
lbragstad | alexz__: are you sure each keystone nodes is reading the same key repository? | 19:01 |
alexz__ | yes | 19:02 |
*** portdirect is now known as eteppete | 19:02 | |
*** efried is now known as efried_afk | 19:02 | |
*** openstackgerrit has quit IRC | 19:03 | |
alexz__ | sometimes tests pass. also restarting of apache2 on all nodes or rebooting nodes helps | 19:03 |
*** eteppete is now known as portdirect | 19:03 | |
alexz__ | so it is not 100% broken. some primitive operations are fine (e.g cli commands), meanwhile tempest tests may fail | 19:04 |
lbragstad | hmm | 19:05 |
kmalloc | lbragstad: https://review.openstack.org/#/c/492529/1 | 19:12 |
kmalloc | see my comment | 19:12 |
*** portdirect has quit IRC | 19:17 | |
*** portdirect has joined #openstack-keystone | 19:17 | |
*** itlinux has joined #openstack-keystone | 19:19 | |
itlinux | good morning all.. | 19:20 |
lbragstad | kmalloc: isn't there a string freeze on libraries, too? | 19:20 |
kmalloc | *shrug* | 19:21 |
kmalloc | dunno | 19:21 |
itlinux | quick question on LDAP.. I have configured it and I can openstack user list --domain xxxxx but when I go to horizon I do not see them.. is there anything else I need to do to have them show up in the options since I cannot add them to any project ..thanks | 19:21 |
*** nicolasbock has quit IRC | 19:21 | |
lbragstad | kmalloc: yeah - https://releases.openstack.org/pike/schedule.html#p-final-clientlib | 19:21 |
*** ducttap__ has joined #openstack-keystone | 19:26 | |
*** efried_afk is now known as efried | 19:27 | |
*** ducttape_ has quit IRC | 19:29 | |
*** openstackgerrit has joined #openstack-keystone | 19:35 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Unset project ids for all identity backends https://review.openstack.org/491916 | 19:35 |
lbragstad | kmalloc: fixed ^ | 19:36 |
lbragstad | =/ | 19:36 |
*** tobberydberg has joined #openstack-keystone | 19:38 | |
lbragstad | knikolla: samueldmq any luck on bug 1702211 | 19:38 |
openstack | bug 1702211 in OpenStack Identity (keystone) "test_password_history_not_enforced_in_admin_reset failed in tempest test" [Medium,Confirmed] https://launchpad.net/bugs/1702211 | 19:38 |
*** sbezverk has joined #openstack-keystone | 19:39 | |
*** tobberydberg has quit IRC | 19:42 | |
*** ducttap__ has quit IRC | 19:45 | |
*** prashkre_ has quit IRC | 19:47 | |
*** prashkre_ has joined #openstack-keystone | 19:47 | |
*** tobberydberg has joined #openstack-keystone | 19:47 | |
*** jrist has quit IRC | 19:48 | |
*** tobberydberg has quit IRC | 19:52 | |
*** ppiela has joined #openstack-keystone | 19:55 | |
*** tobberydberg has joined #openstack-keystone | 19:57 | |
*** ppiela_ has quit IRC | 19:58 | |
*** ducttape_ has joined #openstack-keystone | 20:01 | |
*** tobberydberg has quit IRC | 20:09 | |
knikolla | lbragstad: found some suspicious stuff (which may be nothing). Will patch keystone for more logging and try to reproduce. | 20:16 |
*** appletree has joined #openstack-keystone | 20:17 | |
*** tobberydberg has joined #openstack-keystone | 20:18 | |
appletree | hi | 20:23 |
appletree | is it possible to have a cloud admin inherit roles from all domains and projects? | 20:23 |
*** appletree has quit IRC | 20:25 | |
*** dstepanenko has joined #openstack-keystone | 20:29 | |
openstackgerrit | Gage Hugo proposed openstack/keystone master: Have project get domain_id from parent https://review.openstack.org/489655 | 20:31 |
*** dstepanenko has quit IRC | 20:34 | |
lbragstad | knikolla: samueldmq what's the concurrency level of the tests when you recreate? | 20:38 |
lbragstad | knikolla: samueldmq are the tests running parallel or serial? | 20:38 |
knikolla | lbragstad: serial | 20:38 |
lbragstad | interesting | 20:39 |
lbragstad | i was curious if running the tests in parallel was causing an issue where one tests was locking the account at exactly the right moment where another test was expecting it to be unlocked | 20:40 |
lbragstad | but if it's recreateable when running the tests serially, then that wouldn't be the case | 20:41 |
*** appletree has joined #openstack-keystone | 20:42 | |
*** appletree is now known as _apple_tree | 20:42 | |
_apple_tree | hi | 20:42 |
_apple_tree | is it possible for a cloud admin to inherit roles from all domains and projects? | 20:42 |
knikolla | lbragstad: viewing the logs. There seemed to be a case where the auth request comes in before update_password has fully responded. Which is crazy. | 20:43 |
lbragstad | knikolla: that should be unpossible | 20:43 |
knikolla | lbragstad: exactly. | 20:44 |
lbragstad | _apple_tree: it should be possible for you to create implied roles from the admin role | 20:44 |
lbragstad | then the admin role can be given to the cloud admin | 20:44 |
_apple_tree | @lbragstad: i see, i thought implied roles only worked on one level (eg. project) | 20:45 |
knikolla | lbragstad: i'd share the logs but i'm on my ipad in a meeting and don't have the links handy :/ | 20:45 |
lbragstad | _apple_tree: can you elaborate on one level? | 20:46 |
lbragstad | knikolla: you dev on an iPad?! | 20:46 |
*** prashkre_ has quit IRC | 20:47 | |
_apple_tree | @lbragstad: i thought you can only create implied roles from one project role to another project role | 20:47 |
*** prashkre_ has joined #openstack-keystone | 20:47 | |
*** ducttap__ has joined #openstack-keystone | 20:47 | |
knikolla | lbragstad: i carry one to meetings. | 20:48 |
lbragstad | roles can be implied globally - i think | 20:48 |
_apple_tree | wow, that's great | 20:48 |
knikolla | Developing in one is annoying, but possible. Have done a few patches from it actually. | 20:48 |
_apple_tree | ok i'll look into this more | 20:48 |
_apple_tree | thx @lbragstad | 20:48 |
lbragstad | _apple_tree: https://developer.openstack.org/api-ref/identity/v3/#os-inherit-api | 20:49 |
_apple_tree | thanks! for some reason i couldn't find this | 20:49 |
lbragstad | _apple_tree: our docs have changed a lot this release | 20:50 |
lbragstad | _apple_tree: but you should be able to find everything from https://docs.openstack.org/keystone/latest/ | 20:50 |
_apple_tree | ok will bookmark that | 20:50 |
*** ducttape_ has quit IRC | 20:50 | |
*** prashkre_ has quit IRC | 20:56 | |
*** prashkre_ has joined #openstack-keystone | 20:56 | |
openstackgerrit | Merged openstack/keystone master: Cache list projects and domains for user https://review.openstack.org/487143 | 21:01 |
*** tobberydberg has quit IRC | 21:02 | |
*** tobberydberg has joined #openstack-keystone | 21:02 | |
*** tobberydberg has quit IRC | 21:07 | |
*** prashkre_ has quit IRC | 21:07 | |
*** aojea has joined #openstack-keystone | 21:16 | |
*** aojea has quit IRC | 21:21 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Removed dependency.provider https://review.openstack.org/163029 | 21:21 |
openstackgerrit | Lance Bragstad proposed openstack/keystone master: Remove deprecation of domain_config_upload https://review.openstack.org/492694 | 21:23 |
*** thorst has quit IRC | 21:24 | |
*** aojea has joined #openstack-keystone | 21:24 | |
*** dstepanenko has joined #openstack-keystone | 21:24 | |
*** thorst has joined #openstack-keystone | 21:27 | |
*** dstepanenko has quit IRC | 21:29 | |
*** aojea has quit IRC | 21:30 | |
*** thorst has quit IRC | 21:31 | |
*** spzala has quit IRC | 21:37 | |
*** spzala has joined #openstack-keystone | 21:38 | |
*** spzala has quit IRC | 21:38 | |
*** spzala has joined #openstack-keystone | 21:39 | |
*** spzala has quit IRC | 21:44 | |
*** thorst has joined #openstack-keystone | 21:49 | |
*** raildo has quit IRC | 21:50 | |
*** thorst has quit IRC | 21:54 | |
lbragstad | samueldmq: cmurphy want to kick this one through for RC? https://review.openstack.org/#/c/491916/ | 21:55 |
gyee | lbragstad, have a question on https://review.openstack.org/#/c/487143/ | 21:56 |
gyee | breton, sorry I missed your ping yesterday | 21:56 |
lbragstad | gyee: responded | 21:59 |
lbragstad | gyee: the resource cache region is computed in the assignment api and invalidated based on things we do there | 22:00 |
gyee | lbragstad, excellent, that's a good one | 22:01 |
lbragstad | gyee: yeah - i didn't realize how slow the assignment api is | 22:01 |
lbragstad | especially with effective role assignments | 22:01 |
lbragstad | =/ | 22:01 |
lbragstad | at least caching will help stop the bleeding | 22:01 |
gyee | oh yeah, especially with thousands of users in LDAP | 22:02 |
lbragstad | but i'm sure there are things we're doing in that code that could be improved | 22:02 |
*** tesseract has quit IRC | 22:02 | |
gyee | need to retest, but I think that patch helps a lot | 22:02 |
lbragstad | gyee: let me know if you can post those results publicly | 22:02 |
lbragstad | i'd like to see the results! | 22:03 |
gyee | lbragstad, sure | 22:03 |
lbragstad | stevemar: last one for RC if you want to do a review - https://review.openstack.org/#/c/491916/ | 22:05 |
*** ioggstream has joined #openstack-keystone | 22:06 | |
*** openstackgerrit has quit IRC | 22:18 | |
*** aojea has joined #openstack-keystone | 22:20 | |
*** aojea has quit IRC | 22:43 | |
*** aojea_ has joined #openstack-keystone | 22:44 | |
*** catintheroof has quit IRC | 22:45 | |
*** catintheroof has joined #openstack-keystone | 22:45 | |
*** catintheroof has quit IRC | 22:49 | |
*** edmondsw has quit IRC | 22:53 | |
*** openstackgerrit has joined #openstack-keystone | 22:54 | |
openstackgerrit | Omar Tleimat proposed openstack/keystone master: Fix mapping_purge failure https://review.openstack.org/408304 | 22:54 |
*** aojea_ has quit IRC | 22:55 | |
*** spzala has joined #openstack-keystone | 22:55 | |
*** spzala has quit IRC | 22:55 | |
*** spzala has joined #openstack-keystone | 22:55 | |
*** spzala has quit IRC | 22:55 | |
*** spzala has joined #openstack-keystone | 22:56 | |
*** spzala has quit IRC | 22:56 | |
*** spzala has joined #openstack-keystone | 22:56 | |
*** spzala has quit IRC | 22:56 | |
*** spzala has joined #openstack-keystone | 22:57 | |
*** spzala has quit IRC | 22:57 | |
*** spzala has joined #openstack-keystone | 22:57 | |
*** spzala has quit IRC | 22:58 | |
*** ducttap__ has quit IRC | 23:10 | |
*** dstepanenko has joined #openstack-keystone | 23:12 | |
*** dstepanenko has quit IRC | 23:16 | |
*** ioggstream has quit IRC | 23:31 | |
*** gyee has quit IRC | 23:36 | |
*** gyee has joined #openstack-keystone | 23:37 | |
*** thorst has joined #openstack-keystone | 23:38 | |
*** alexz__ has quit IRC | 23:49 | |
*** ducttape_ has joined #openstack-keystone | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!