| morgan | ugh. | 00:00 |
|---|---|---|
| morgan | UGH. | 00:00 |
| knikolla | morgan: i gave it a few tries but came up short. | 00:00 |
| gagehugo | morgan: https://review.openstack.org/#/c/374482/ | 00:00 |
| gagehugo | yeah it's messy | 00:00 |
| morgan | I'm thinking maybe we just patch in a "temp" thing. | 00:00 |
| morgan | that is test-only | 00:00 |
| knikolla | morgan: we can subclass the driver | 00:01 |
| morgan | basically we make the driver itself simply fail | 00:01 |
| morgan | and then subclass for tests (for now) | 00:01 |
| morgan | long term we should stop doing "unit" tests on functional backends | 00:01 |
| knikolla | morgan: i was going to add that approach to the meeting on tuesday | 00:01 |
| morgan | and we should use a real LDAP server really populated with real useful data | 00:01 |
| knikolla | since ocata is coming near | 00:01 |
| morgan | i just need to solve one last issue and my patch should be good to go | 00:02 |
| morgan | with testing to come next | 00:02 |
| openstackgerrit | Eric Brown proposed openstack/keystone: Add warning about using `external` with federation https://review.openstack.org/423561 | 00:05 |
| morgan | ok... wtf. | 00:05 |
| morgan | why is this telling me the value exists? | 00:05 |
| morgan | oooh so, looks like we can't use the MFA code with normal identity backends, it needs to be done as a properly mapped user with a local shadow | 00:08 |
| * morgan grumbles | 00:15 | |
| morgan | knikolla: this is really ugly | 00:15 |
| morgan | knikolla: this ldap backend is just a trainwreck :( | 00:15 |
| morgan | still | 00:15 |
| knikolla | morgan: i'm subclassing a rw ldap from a ro ldap just for the tests, for now. | 00:17 |
| knikolla | morgan: for the next release we should have functional tests for this stuff. | 00:17 |
| morgan | hmm | 00:18 |
| morgan | so should i add mfa_rules_attribute and mfa_rules_attribute_enabled here? | 00:19 |
| morgan | i'm thinking no.... | 00:19 |
| morgan | and just make ldap not support it. | 00:19 |
| morgan | the whole shadow user thing should be the use-model for the mfa stuff | 00:19 |
| knikolla | morgan: so basically ldap would not support mfa? | 00:20 |
| morgan | yep | 00:20 |
| *** thorst_ has joined #openstack-keystone | 00:20 | |
| morgan | unless you did it with the local shadow user bits | 00:20 |
| morgan | which, IIRC is supposed to be how it works | 00:21 |
| morgan | but i need rderose to confirm | 00:21 |
| knikolla | morgan: that would be my guess to. | 00:21 |
| morgan | it is literally a single unit test failing | 00:22 |
| morgan | and it's the LDAP password update one | 00:22 |
| morgan | this tells me this unit test is bad. | 00:22 |
| knikolla | morgan: AFAIK ldap doesn't have password update in the driver. | 00:23 |
| morgan | it does. | 00:23 |
| morgan | i am also inclined to just say "#nope" and make the backend fail the password update. | 00:23 |
| morgan | and make the test expect it | 00:23 |
| knikolla | def change_password(self, user_id, new_password): | 00:24 |
| knikolla | raise exception.NotImplemented( | 00:24 |
| knikolla | _('Self-service user password changes are not implemented for ' | 00:24 |
| knikolla | 'LDAP.')) | 00:24 |
| knikolla | ^^ ? | 00:24 |
| morgan | https://www.irccloud.com/pastebin/MR6u9g0X/ | 00:24 |
| morgan | i guess i could just dump that test | 00:25 |
| browne | lbragstad: dstanek: on bug 1657978, it looks like we already have jsonschema to require domain for group_by_name which is what i did | 00:25 |
| openstack | bug 1657978 in OpenStack Identity (keystone) "Internal Server Error: KeyError: 'domain'" [Medium,New] https://launchpad.net/bugs/1657978 - Assigned to Eric Brown (ericwb) | 00:25 |
| morgan | knikolla: make sure that the RW driver you make for ldap for tests is basically only used during setUp | 00:25 |
| *** thorst_ has quit IRC | 00:25 | |
| morgan | knikolla: not actually used during real testing | 00:25 |
| browne | https://github.com/openstack/keystone/blob/bc8a145de14e455a2a73824e8a84d92ac27aae1c/keystone/federation/utils.py#L221 | 00:26 |
| knikolla | morgan: yeah, i'll look into that. | 00:26 |
| browne | oh nevermind, looks like mitaka didn't have the required props | 00:27 |
| *** nicolasbock has quit IRC | 00:27 | |
| morgan | ok i just hacked a little code into the LDAP driver to handle this edge-case | 00:39 |
| morgan | and it will 100% go away once this test is removed. | 00:39 |
| knikolla | morgan: since we are removing write support anyway, the test shouldn't really matter. | 00:40 |
| morgan | exactly | 00:40 |
| morgan | but i'm not toasting the test until we drop write support so i tacked in a work-around | 00:41 |
| *** adrian_otto has quit IRC | 00:51 | |
| *** adrian_otto has joined #openstack-keystone | 00:52 | |
| knikolla | morgan: damn. writes are all over the place, not just in setUp. | 01:00 |
| *** nkinder has quit IRC | 01:02 | |
| knikolla | but i think i can resolve that by wrapping the create calls between switching backends. | 01:03 |
| *** jose-phillips has quit IRC | 01:04 | |
| *** browne has quit IRC | 01:05 | |
| morgan | so | 01:08 |
| morgan | i think the simplest solution is make it so the allow writes is no longer config option | 01:08 |
| *** ravelar has quit IRC | 01:08 | |
| morgan | and hold the "LDAP write is ok" in a central global place | 01:08 |
| morgan | then setup sets it, and then unsets it before tests are run | 01:08 |
| morgan | any test doing a write to ldap, needs to be fixed or skipped or something | 01:09 |
| morgan | then we can work on a better way of testing | 01:09 |
| knikolla | morgan: that would be *most* of them | 01:09 |
| morgan | if it is testing something that is a write and the backend is ldap, it is skipped | 01:09 |
| morgan | simple. | 01:09 |
| morgan | or not applied to the LDAP backend | 01:09 |
| morgan | you don't have to run *every* test for a read-only backend | 01:10 |
| morgan | in fact, you shouldn't be. | 01:10 |
| knikolla | morgan: even tests that don't test writing functionality, write during the test to setup the scenarion. for example a test that tests simple bind, creates the user during the tests, not during setup. | 01:10 |
| morgan | then that needs to be moved to setup | 01:11 |
| morgan | or we use a fixture | 01:11 |
| morgan | fixture.EnableLdapWrite | 01:11 |
| morgan | and use it as a context manager when doing the write | 01:11 |
| morgan | but we should fix the test(s) | 01:11 |
| knikolla | morgan: hmm… i like that | 01:11 |
| morgan | if you do a fixture, make sure that every place you insert it add a #TODO(Fix this test to not write to LDAP) | 01:11 |
| morgan | so steps to not supporting ldap write: 1) make the option go away in conf. | 01:12 |
| morgan | 2) make a global/central toggle that can be referenced | 01:12 |
| morgan | 3) fixture to enable while in a context (only used as a context manager) in tests | 01:12 |
| morgan | any test testing "writes" is skipped, any test doing setup *in* the test gets the context manager and a TOD | 01:13 |
| morgan | O | 01:13 |
| morgan | to fix | 01:13 |
| knikolla | morgan: sounds good. i like the toggle/fixture method. | 01:14 |
| morgan | and in ocata ldap write is gone from production keystone(s) | 01:15 |
| morgan | as planned | 01:15 |
| * morgan glares at the tests... please pass... | 01:15 | |
| morgan | ... please .... | 01:15 |
| *** thorst_ has joined #openstack-keystone | 01:21 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone: Process and validate auth methods against MFA rules https://review.openstack.org/423548 | 01:22 |
| morgan | knikolla: ^ phew | 01:22 |
| knikolla | morgan: passed? | 01:23 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone: Process and validate auth methods against MFA rules https://review.openstack.org/423548 | 01:24 |
| morgan | knikolla: locally | 01:25 |
| openstackgerrit | Merged openstack/keystone: Improvements to external auth documentation page https://review.openstack.org/423356 | 01:25 |
| *** thorst_ has quit IRC | 01:26 | |
| knikolla | almost 7 hours to gate ^^ wow… | 01:27 |
| lbragstad | must be getting close to feature freeze | 01:27 |
| knikolla | true | 01:28 |
| *** adrian_otto has quit IRC | 01:34 | |
| *** v1k0d3n has joined #openstack-keystone | 01:35 | |
| *** v1k0d3n has quit IRC | 01:36 | |
| *** christophler has quit IRC | 01:45 | |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: WIP: Remove LDAP Support https://review.openstack.org/423572 | 01:49 |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: WIP: Remove LDAP Write Support https://review.openstack.org/423572 | 01:49 |
| knikolla | argh, typo. lol | 01:49 |
| knikolla | morgan ^^ quick first draft. | 01:49 |
| knikolla | gagehugo: cc | 01:51 |
| openstackgerrit | Merged openstack/keystone: Fix warnings generated by os-api-ref 1.2.0 https://review.openstack.org/423387 | 02:04 |
| openstackgerrit | Merged openstack/keystone: Allow user to change own expired password https://review.openstack.org/404022 | 02:04 |
| *** yarkot has quit IRC | 02:06 | |
| *** ayoung has quit IRC | 02:09 | |
| *** yarkot has joined #openstack-keystone | 02:09 | |
| *** jerrygb has quit IRC | 02:10 | |
| *** browne has joined #openstack-keystone | 02:15 | |
| *** yarkot has quit IRC | 02:21 | |
| *** browne has quit IRC | 02:22 | |
| *** woodster_ has quit IRC | 02:25 | |
| *** pramodrj07 has quit IRC | 02:33 | |
| *** MasterOfBugs has quit IRC | 02:34 | |
| *** stingaci has joined #openstack-keystone | 02:34 | |
| *** stingaci has quit IRC | 02:38 | |
| *** thorst_ has joined #openstack-keystone | 02:39 | |
| *** thorst_ has quit IRC | 02:44 | |
| *** pramodrj07 has joined #openstack-keystone | 02:52 | |
| *** MasterOfBugs has joined #openstack-keystone | 02:52 | |
| *** yarkot has joined #openstack-keystone | 03:05 | |
| *** nkinder has joined #openstack-keystone | 03:17 | |
| *** nkinder has quit IRC | 03:24 | |
| *** nkinder has joined #openstack-keystone | 03:36 | |
| *** jerrygb has joined #openstack-keystone | 03:41 | |
| *** jerrygb has quit IRC | 03:47 | |
| *** stingaci has joined #openstack-keystone | 04:03 | |
| *** adrian_otto has joined #openstack-keystone | 04:07 | |
| *** stingaci has quit IRC | 04:07 | |
| *** adrian_otto has quit IRC | 04:14 | |
| stevemar | ugh, sorry morgan and knikolla - i was gone for most of the evening :( | 04:30 |
| morgan | stevemar: sure sure, excuses... ;) | 04:32 |
| morgan | stevemar: all the code for handling MFA rules in the auth path is done (needs some limited added tests) | 04:34 |
| morgan | stevemar: beyond the tests, API changes are needed to allow setting of the values. | 04:35 |
| morgan | pretty straight forward stuff, should be pretty easy to get done. | 04:35 |
| stevemar | nice | 04:37 |
| *** thorst_ has joined #openstack-keystone | 04:41 | |
| morgan | stevemar: don't know how fast i should work on the API stuff. adriant said he was going to work on it, but i haven't seen him in days | 04:42 |
| morgan | stevemar: i could probably finish it all tonight/tomorrow at this point. | 04:42 |
| *** thorst_ has quit IRC | 04:45 | |
| stevemar | morgan: given the deadline is thursdayish i wouldn't wait :) | 04:48 |
| morgan | ok i'll hammer out the last bits | 04:49 |
| morgan | stevemar: i think the tests for the new auth code paths is going in a followup | 04:50 |
| *** adrian_otto has joined #openstack-keystone | 04:54 | |
| *** jefrite has quit IRC | 05:02 | |
| *** pnavarro has quit IRC | 05:10 | |
| *** adrian_otto has quit IRC | 05:18 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: PCI-DSS Force users to change password upon first use https://review.openstack.org/403916 | 05:21 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: PCI-DSS Force users to change password upon first use https://review.openstack.org/403916 | 05:23 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: PCI-DSS Force users to change password upon first use https://review.openstack.org/403916 | 05:24 |
| *** itisha has joined #openstack-keystone | 05:47 | |
| stevemar | reviewed all ocata-3 critical patches \o/ | 06:03 |
| stevemar | morgan: i'll review yours in the AM | 06:03 |
| *** lamt has joined #openstack-keystone | 06:09 | |
| *** edmondsw has joined #openstack-keystone | 06:17 | |
| *** edmondsw has quit IRC | 06:22 | |
| *** eglute has quit IRC | 06:40 | |
| *** evrardjp has quit IRC | 06:40 | |
| *** eglute has joined #openstack-keystone | 06:40 | |
| *** evrardjp has joined #openstack-keystone | 06:40 | |
| *** thorst_ has joined #openstack-keystone | 06:41 | |
| *** sigmavirus has quit IRC | 06:41 | |
| *** richm has quit IRC | 06:42 | |
| *** _sigmavirus24 has joined #openstack-keystone | 06:43 | |
| *** thorst_ has quit IRC | 06:46 | |
| morgan | stevemar: sorry, -1 on that ^ | 07:03 |
| morgan | stevemar: we need to STOP designing configuration options that are encoding uuids or other randomly generated ids in the config | 07:04 |
| *** voelzmo has joined #openstack-keystone | 07:12 | |
| *** eglute has quit IRC | 07:32 | |
| *** odyssey4me has quit IRC | 07:32 | |
| *** eglute has joined #openstack-keystone | 07:32 | |
| *** dolphm has quit IRC | 07:33 | |
| *** fungi has quit IRC | 07:33 | |
| *** dolphm has joined #openstack-keystone | 07:38 | |
| *** ChanServ sets mode: +o dolphm | 07:38 | |
| *** odyssey4me has joined #openstack-keystone | 07:41 | |
| *** fungi has joined #openstack-keystone | 07:43 | |
| *** stingaci has joined #openstack-keystone | 07:49 | |
| *** pramodrj07 has quit IRC | 07:58 | |
| *** MasterOfBugs has quit IRC | 08:00 | |
| *** chrisplo_ has quit IRC | 08:02 | |
| *** stingaci has quit IRC | 08:07 | |
| *** thorst_ has joined #openstack-keystone | 08:42 | |
| *** thorst_ has quit IRC | 08:49 | |
| *** zzzeek has quit IRC | 09:00 | |
| *** zzzeek has joined #openstack-keystone | 09:00 | |
| *** voelzmo has joined #openstack-keystone | 09:19 | |
| *** voelzmo has quit IRC | 09:28 | |
| *** pnavarro has joined #openstack-keystone | 09:37 | |
| *** chrisplo_ has joined #openstack-keystone | 10:04 | |
| *** chrisplo_ has quit IRC | 10:09 | |
| *** jerrygb has joined #openstack-keystone | 10:12 | |
| *** jerrygb has quit IRC | 10:17 | |
| mordred | morgan: ++ | 10:28 |
| mordred | UUIDs should really never got into a config file | 10:28 |
| *** voelzmo has joined #openstack-keystone | 10:29 | |
| *** voelzmo has quit IRC | 10:36 | |
| *** thorst_ has joined #openstack-keystone | 10:45 | |
| *** dikonoor has joined #openstack-keystone | 10:50 | |
| *** thorst_ has quit IRC | 10:50 | |
| *** iurygregory has quit IRC | 11:03 | |
| *** clenimar has quit IRC | 11:03 | |
| *** richm has joined #openstack-keystone | 11:13 | |
| *** stingaci has joined #openstack-keystone | 11:28 | |
| *** stingaci has quit IRC | 11:33 | |
| *** nicolasbock has joined #openstack-keystone | 11:39 | |
| *** edmondsw has joined #openstack-keystone | 11:42 | |
| *** edmondsw has quit IRC | 11:47 | |
| *** stingaci has joined #openstack-keystone | 11:49 | |
| *** stingaci has quit IRC | 11:54 | |
| *** stingaci has joined #openstack-keystone | 12:06 | |
| *** stingaci has quit IRC | 12:10 | |
| *** stingaci has joined #openstack-keystone | 12:14 | |
| *** thorst_ has joined #openstack-keystone | 12:21 | |
| *** thorst_ has quit IRC | 12:25 | |
| *** dave-mccowan has joined #openstack-keystone | 13:06 | |
| *** chrisplo_ has joined #openstack-keystone | 13:08 | |
| *** pnavarro has quit IRC | 13:09 | |
| *** stingaci has quit IRC | 13:10 | |
| *** chrisplo_ has quit IRC | 13:13 | |
| *** itisha has quit IRC | 13:22 | |
| *** stingaci has joined #openstack-keystone | 13:26 | |
| *** dave-mccowan has quit IRC | 13:30 | |
| *** stingaci has quit IRC | 13:30 | |
| *** david_cu has joined #openstack-keystone | 13:31 | |
| *** dave-mccowan has joined #openstack-keystone | 13:31 | |
| *** jefrite has joined #openstack-keystone | 13:31 | |
| *** pnavarro has joined #openstack-keystone | 13:32 | |
| knikolla | stevemar: no one should really be expected to work on evenings | 13:36 |
| knikolla | (or saturday mornings) | 13:36 |
| knikolla | :) | 13:37 |
| *** dikonoor has quit IRC | 13:37 | |
| *** voelzmo has joined #openstack-keystone | 13:48 | |
| *** pnavarro has quit IRC | 13:53 | |
| *** voelzmo has quit IRC | 13:53 | |
| *** thorst_ has joined #openstack-keystone | 14:01 | |
| *** stingaci has joined #openstack-keystone | 14:12 | |
| *** jerrygb has joined #openstack-keystone | 14:13 | |
| *** stingaci has quit IRC | 14:16 | |
| *** jerrygb has quit IRC | 14:17 | |
| stevemar | knikolla: thats what they all say :) | 14:24 |
| stevemar | morgan: doh | 14:26 |
| stevemar | rderose: there is another uuid based option ... another user ignore list for not having to change passwords every X days | 14:27 |
| stevemar | morgan: ^ | 14:27 |
| knikolla | stevemar: i have only been active during your ptl reign, so i may have unreasonable expectations of the successor. haha | 14:30 |
| stevemar | knikolla: i had to catch up to the previous PTLs :P | 14:35 |
| knikolla | stevemar: we need some lazy ptl to break the vicious cycle :P | 14:37 |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: WIP: Remove LDAP Write Support https://review.openstack.org/423572 | 14:40 |
| *** chrisplo_ has joined #openstack-keystone | 14:41 | |
| *** chrisplo_ has quit IRC | 14:45 | |
| *** richm has quit IRC | 14:48 | |
| *** clenimar has joined #openstack-keystone | 14:52 | |
| *** iurygregory has joined #openstack-keystone | 14:52 | |
| *** g2 is now known as BrAsS_mOnKeY | 15:02 | |
| *** v1k0d3n has joined #openstack-keystone | 15:14 | |
| openstackgerrit | zhongshengping proposed openstack/keystone: Remove releated role_tree_dn test https://review.openstack.org/423660 | 15:16 |
| *** erlon has quit IRC | 15:30 | |
| *** thorst_ has quit IRC | 15:44 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/423668 | 15:49 |
| knikolla | one ldap test is failing after i hardcode the default dumb_member option :/ | 15:49 |
| *** nicolasbock has quit IRC | 15:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/423682 | 15:56 |
| *** pnavarro has joined #openstack-keystone | 16:05 | |
| *** edmondsw has joined #openstack-keystone | 16:13 | |
| *** dave-mccowan has quit IRC | 16:19 | |
| *** adrian_otto has joined #openstack-keystone | 16:31 | |
| *** stingaci has joined #openstack-keystone | 16:43 | |
| *** chrisplo_ has joined #openstack-keystone | 16:44 | |
| *** stingaci has quit IRC | 16:47 | |
| *** chrisplo_ has quit IRC | 16:48 | |
| *** edmondsw has quit IRC | 16:52 | |
| *** edmondsw has joined #openstack-keystone | 16:53 | |
| *** edmondsw has quit IRC | 16:53 | |
| *** edmondsw has joined #openstack-keystone | 16:53 | |
| *** edmondsw has quit IRC | 16:59 | |
| *** chrisplo_ has joined #openstack-keystone | 17:01 | |
| *** adrian_otto1 has joined #openstack-keystone | 17:11 | |
| *** adrian_otto has quit IRC | 17:14 | |
| *** stingaci has joined #openstack-keystone | 17:15 | |
| *** thorst_ has joined #openstack-keystone | 17:15 | |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: Remove LDAP write support https://review.openstack.org/423572 | 17:16 |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: Remove LDAP write support https://review.openstack.org/423572 | 17:17 |
| *** stingaci has quit IRC | 17:19 | |
| *** thorst_ has quit IRC | 17:19 | |
| knikolla | \o/ | 17:21 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Set the domain for federated users https://review.openstack.org/408332 | 17:36 |
| *** henrynash has joined #openstack-keystone | 17:46 | |
| *** ChanServ sets mode: +v henrynash | 17:46 | |
| *** stingaci has joined #openstack-keystone | 17:47 | |
| *** spzala has joined #openstack-keystone | 17:48 | |
| *** adrian_otto1 has quit IRC | 17:49 | |
| *** voelzmo has joined #openstack-keystone | 17:50 | |
| *** gagehugo has quit IRC | 17:51 | |
| *** stingaci has quit IRC | 17:52 | |
| *** voelzmo has quit IRC | 17:54 | |
| *** adrian_otto has joined #openstack-keystone | 17:56 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Set the domain for federated users https://review.openstack.org/408332 | 17:59 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Set the domain for federated users https://review.openstack.org/408332 | 17:59 |
| *** adrian_otto has quit IRC | 18:09 | |
| *** adrian_otto has joined #openstack-keystone | 18:10 | |
| *** voelzmo has joined #openstack-keystone | 18:11 | |
| openstackgerrit | Merged openstack/keystonemiddleware: Updated from global requirements https://review.openstack.org/423668 | 18:18 |
| *** voelzmo has quit IRC | 18:18 | |
| *** spzala has quit IRC | 18:18 | |
| *** stingaci has joined #openstack-keystone | 18:19 | |
| *** henrynash has quit IRC | 18:19 | |
| *** stingaci has quit IRC | 18:24 | |
| *** spzala has joined #openstack-keystone | 18:26 | |
| *** spzala has quit IRC | 18:26 | |
| morgan | knikolla: yay | 18:27 |
| openstackgerrit | Merged openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/423682 | 18:34 |
| openstackgerrit | Merged openstack/keystone: Remove releated role_tree_dn test https://review.openstack.org/423660 | 18:35 |
| *** stingaci has joined #openstack-keystone | 18:36 | |
| *** stingaci has quit IRC | 18:41 | |
| knikolla | morgan: made the ldapdb fixture switch the toggle to writeable. just need to see if everything passes and i'll do the final push. | 18:43 |
| knikolla | hopefully before my laptop battery dies. | 18:43 |
| morgan | cool. I'll review it today then. | 18:44 |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: Remove LDAP write support https://review.openstack.org/423572 | 18:46 |
| knikolla | morgan: ^^ | 18:46 |
| knikolla | 12 core vms are awesome at running unit tests | 18:47 |
| morgan | I have a bunch of comments for this, but for now, it is sufficient. depending on how much time we have might make it even better. | 18:50 |
| *** adrian_otto has quit IRC | 18:50 | |
| *** stingaci has joined #openstack-keystone | 18:52 | |
| *** stingaci has quit IRC | 18:56 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Set domain_id for federated users (refactored tests) https://review.openstack.org/423703 | 19:05 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: WIP - Set domain_id for federated users (refactor tests) https://review.openstack.org/423703 | 19:11 |
| *** maestropandy has joined #openstack-keystone | 19:17 | |
| *** maestropandy has left #openstack-keystone | 19:17 | |
| *** thorst_ has joined #openstack-keystone | 19:20 | |
| *** thorst_ has quit IRC | 19:21 | |
| *** stingaci has joined #openstack-keystone | 19:24 | |
| *** stingaci has quit IRC | 19:28 | |
| *** stingaci has joined #openstack-keystone | 19:41 | |
| *** stingaci has quit IRC | 19:45 | |
| *** d0ugal has quit IRC | 19:46 | |
| *** d0ugal has joined #openstack-keystone | 19:47 | |
| *** adrian_otto has joined #openstack-keystone | 19:53 | |
| *** dave-mccowan has joined #openstack-keystone | 20:08 | |
| *** stingaci has joined #openstack-keystone | 20:13 | |
| *** d0ugal has quit IRC | 20:14 | |
| *** stingaci has quit IRC | 20:17 | |
| *** mvk has joined #openstack-keystone | 20:19 | |
| *** pnavarro has quit IRC | 20:21 | |
| *** stingaci has joined #openstack-keystone | 20:29 | |
| *** d0ugal has joined #openstack-keystone | 20:29 | |
| *** adrian_otto has quit IRC | 20:31 | |
| *** stingaci has quit IRC | 20:33 | |
| *** pnavarro has joined #openstack-keystone | 20:33 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Refactor shadow users tests https://review.openstack.org/423705 | 20:48 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Refactor shadow users tests https://review.openstack.org/423705 | 20:55 |
| *** gagehugo has joined #openstack-keystone | 20:58 | |
| *** stingaci has joined #openstack-keystone | 21:01 | |
| *** stingaci has quit IRC | 21:05 | |
| *** jerrygb has joined #openstack-keystone | 21:07 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Set the domain for federated users https://review.openstack.org/423708 | 21:11 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Set the domain for federated users https://review.openstack.org/423708 | 21:12 |
| *** adrian_otto has joined #openstack-keystone | 21:15 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Set the domain for federated users https://review.openstack.org/423708 | 21:17 |
| *** stingaci has joined #openstack-keystone | 21:18 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Refactor shadow users tests https://review.openstack.org/423705 | 21:22 |
| *** stingaci has quit IRC | 21:22 | |
| *** thorst_ has joined #openstack-keystone | 21:22 | |
| *** thorst_ has quit IRC | 21:27 | |
| *** stingaci has joined #openstack-keystone | 21:50 | |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: Remove LDAP write support https://review.openstack.org/423572 | 21:51 |
| *** stingaci has quit IRC | 21:54 | |
| *** yarkot has quit IRC | 22:00 | |
| *** yarkot has joined #openstack-keystone | 22:01 | |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: Remove LDAP write support https://review.openstack.org/423572 | 22:04 |
| knikolla | stevemar: sorry for pushing again, some code had weird indentation | 22:04 |
| knikolla | stevemar: and i'll add the implements too | 22:05 |
| *** stingaci has joined #openstack-keystone | 22:06 | |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: Remove LDAP write support https://review.openstack.org/423572 | 22:06 |
| knikolla | stevemar: final one (i hope) | 22:07 |
| knikolla | ^^ | 22:07 |
| *** stingaci has quit IRC | 22:10 | |
| openstackgerrit | Kristi Nikolla proposed openstack/keystone: Remove LDAP write support https://review.openstack.org/423572 | 22:11 |
| knikolla | spoke too soon | 22:12 |
| *** nicolasbock has joined #openstack-keystone | 22:12 | |
| *** diazjf has joined #openstack-keystone | 22:35 | |
| *** stingaci has joined #openstack-keystone | 22:38 | |
| *** thorst_ has joined #openstack-keystone | 22:38 | |
| *** stingaci has quit IRC | 22:43 | |
| *** thorst_ has quit IRC | 22:43 | |
| *** richm has joined #openstack-keystone | 22:53 | |
| *** dave-mccowan has quit IRC | 23:04 | |
| *** adrian_otto has quit IRC | 23:05 | |
| *** stingaci has joined #openstack-keystone | 23:10 | |
| *** stingaci has quit IRC | 23:15 | |
| *** thorst_ has joined #openstack-keystone | 23:19 | |
| *** thorst_ has quit IRC | 23:20 | |
| *** jerrygb has quit IRC | 23:23 | |
| *** jamielennox|away is now known as jamielennox | 23:28 | |
| *** jistr has quit IRC | 23:41 | |
| *** stingaci has joined #openstack-keystone | 23:42 | |
| *** stingaci has quit IRC | 23:46 | |
| *** jistr has joined #openstack-keystone | 23:49 | |
| *** dims has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!