| *** itsuugo has quit IRC | 00:02 | |
| *** itsuugo has joined #openstack-keystone | 00:03 | |
| *** browne has quit IRC | 00:04 | |
| stevemar | jamielennox: "i have to change around the model i just finished making public" -- elaborate? | 00:08 |
|---|---|---|
| jamielennox | stevemar: well i just finished making a baseclass that had a get_token(token) function | 00:09 |
| jamielennox | stevemar: i now have to figure out some way of making it take (user_token, service_token) without breaking keystone | 00:09 |
| jamielennox | which is mostly just annoying | 00:09 |
| *** itsuugo has quit IRC | 00:09 | |
| *** itsuugo has joined #openstack-keystone | 00:10 | |
| *** ngupta has quit IRC | 00:14 | |
| *** spzala has joined #openstack-keystone | 00:14 | |
| *** ngupta_ has joined #openstack-keystone | 00:15 | |
| stevemar | jamielennox: hmm, i figured the fix would mostly land on the server side | 00:16 |
| *** guoshan has joined #openstack-keystone | 00:18 | |
| *** spzala has quit IRC | 00:19 | |
| *** browne has joined #openstack-keystone | 00:20 | |
| *** spzala has joined #openstack-keystone | 00:23 | |
| *** ngupta_ has quit IRC | 00:30 | |
| *** itsuugo has quit IRC | 00:30 | |
| *** ngupta has joined #openstack-keystone | 00:31 | |
| *** itsuugo has joined #openstack-keystone | 00:31 | |
| *** ngupta has quit IRC | 00:35 | |
| *** itsuugo has quit IRC | 00:43 | |
| *** itsuugo has joined #openstack-keystone | 00:45 | |
| *** ngupta has joined #openstack-keystone | 00:51 | |
| *** itsuugo has quit IRC | 00:52 | |
| *** itsuugo has joined #openstack-keystone | 00:54 | |
| *** markvoelker has joined #openstack-keystone | 00:55 | |
| *** itsuugo has quit IRC | 00:59 | |
| *** itsuugo has joined #openstack-keystone | 00:59 | |
| *** gyee has quit IRC | 01:01 | |
| *** esp has quit IRC | 01:02 | |
| *** jamielennox is now known as jamielennox|away | 01:03 | |
| *** davechen has joined #openstack-keystone | 01:03 | |
| *** ddieterly has joined #openstack-keystone | 01:07 | |
| *** namnh has joined #openstack-keystone | 01:07 | |
| *** guoshan has quit IRC | 01:09 | |
| *** itsuugo has quit IRC | 01:11 | |
| *** spzala has quit IRC | 01:12 | |
| *** itsuugo has joined #openstack-keystone | 01:12 | |
| *** ddieterly has quit IRC | 01:13 | |
| *** ngupta has quit IRC | 01:15 | |
| *** ngupta has joined #openstack-keystone | 01:16 | |
| *** ngupta has quit IRC | 01:20 | |
| *** jamielennox|away is now known as jamielennox | 01:22 | |
| *** roxanaghe has joined #openstack-keystone | 01:24 | |
| *** itsuugo has quit IRC | 01:27 | |
| *** itsuugo has joined #openstack-keystone | 01:28 | |
| *** itsuugo has quit IRC | 01:33 | |
| *** guoshan has joined #openstack-keystone | 01:34 | |
| *** tqtran has quit IRC | 01:34 | |
| *** itsuugo has joined #openstack-keystone | 01:35 | |
| *** roxanaghe has quit IRC | 01:35 | |
| *** browne has quit IRC | 01:37 | |
| *** roxanaghe has joined #openstack-keystone | 01:37 | |
| *** itsuugo has quit IRC | 01:39 | |
| *** itsuugo has joined #openstack-keystone | 01:41 | |
| *** ravelar has joined #openstack-keystone | 01:47 | |
| *** itsuugo has quit IRC | 01:48 | |
| *** itsuugo has joined #openstack-keystone | 01:49 | |
| *** EinstCrazy has joined #openstack-keystone | 01:50 | |
| *** ravelar has quit IRC | 01:52 | |
| *** itsuugo has quit IRC | 01:56 | |
| *** itsuugo has joined #openstack-keystone | 01:57 | |
| *** itsuugo has quit IRC | 02:02 | |
| *** itsuugo has joined #openstack-keystone | 02:04 | |
| *** itsuugo has quit IRC | 02:15 | |
| *** itsuugo has joined #openstack-keystone | 02:16 | |
| *** browne has joined #openstack-keystone | 02:22 | |
| *** browne has quit IRC | 02:23 | |
| *** gagehugo has quit IRC | 02:24 | |
| *** itsuugo has quit IRC | 02:24 | |
| *** itsuugo has joined #openstack-keystone | 02:26 | |
| *** pjm6 has quit IRC | 02:29 | |
| *** pjm6 has joined #openstack-keystone | 02:29 | |
| *** itsuugo has quit IRC | 02:31 | |
| *** itsuugo has joined #openstack-keystone | 02:32 | |
| *** mugsie has quit IRC | 02:33 | |
| *** mugsie has joined #openstack-keystone | 02:35 | |
| *** roxanaghe has quit IRC | 02:36 | |
| *** jamielennox is now known as jamielennox|away | 02:37 | |
| *** itsuugo has quit IRC | 02:38 | |
| *** guoshan has quit IRC | 02:38 | |
| *** guoshan has joined #openstack-keystone | 02:39 | |
| *** itsuugo has joined #openstack-keystone | 02:40 | |
| *** iurygregory_ has quit IRC | 02:45 | |
| *** itsuugo has quit IRC | 02:45 | |
| *** itsuugo has joined #openstack-keystone | 02:46 | |
| *** jamielennox|away is now known as jamielennox | 02:51 | |
| *** itsuugo has quit IRC | 02:53 | |
| *** itsuugo has joined #openstack-keystone | 02:54 | |
| *** itsuugo has quit IRC | 02:58 | |
| *** itsuugo has joined #openstack-keystone | 02:59 | |
| flwang | stevemar: you still around? | 03:00 |
| *** andrewbogott has quit IRC | 03:01 | |
| *** andrewbogott has joined #openstack-keystone | 03:01 | |
| *** itsuugo has quit IRC | 03:04 | |
| *** david-lyle has quit IRC | 03:04 | |
| *** itsuugo has joined #openstack-keystone | 03:05 | |
| *** itsuugo has quit IRC | 03:10 | |
| *** itsuugo has joined #openstack-keystone | 03:10 | |
| stevemar | flwang: sort of :) | 03:14 |
| flwang | stevemar: could you pls review this https://review.openstack.org/#/c/348118/5/zaqarclient/auth/keystone.py ? | 03:14 |
| flwang | unfortunately, it has been merged | 03:14 |
| stevemar | flwang: yeah, i noticed :( | 03:14 |
| flwang | but if you can leave your comments, i will be more than happy to propose another patch to fix it | 03:15 |
| stevemar | flwang: i think it's OK, some of the v2 / v3 diffs can be made easier | 03:15 |
| stevemar | sure | 03:15 |
| flwang | stevemar: that basically follows your work in glance client | 03:16 |
| flwang | and i just realized it makes the work to support session is very easy | 03:16 |
| flwang | just need couple of lines | 03:16 |
| flwang | thank you! | 03:16 |
| *** itsuugo has quit IRC | 03:17 | |
| stevemar | flwang: that's the point! :) | 03:18 |
| stevemar | flwang: for glanceclient i did what i could, theres a lot of baggage in that code | 03:19 |
| *** itsuugo has joined #openstack-keystone | 03:19 | |
| flwang | yep, so i totally trust your expertise in this domain :D | 03:20 |
| *** itsuugo has quit IRC | 03:24 | |
| *** itsuugo has joined #openstack-keystone | 03:24 | |
| *** ayoung has joined #openstack-keystone | 03:26 | |
| *** ChanServ sets mode: +v ayoung | 03:26 | |
| *** itsuugo has quit IRC | 03:29 | |
| stevemar | flwang: commented | 03:29 |
| stevemar | flwang: you can remove like 100 lines of code :P | 03:29 |
| *** itsuugo has joined #openstack-keystone | 03:30 | |
| flwang | stevemar: cooooool | 03:30 |
| stevemar | flwang: feel free to add me as a reviewer if you post a follow up patch | 03:31 |
| stevemar | ayoung: what are your thoughts on the pki removal patch so far? | 03:31 |
| flwang | stevemar: sure, will do. thanks again for your help | 03:31 |
| stevemar | flwang: np | 03:31 |
| *** namnh has quit IRC | 03:31 | |
| *** nicolasbock has quit IRC | 03:34 | |
| *** roxanaghe has joined #openstack-keystone | 03:35 | |
| *** itsuugo has quit IRC | 03:37 | |
| *** itsuugo has joined #openstack-keystone | 03:39 | |
| *** bjolo has joined #openstack-keystone | 03:40 | |
| *** itsuugo has quit IRC | 03:44 | |
| *** itsuugo has joined #openstack-keystone | 03:45 | |
| *** dikonoor has joined #openstack-keystone | 03:49 | |
| *** itsuugo has quit IRC | 03:51 | |
| *** guoshan has quit IRC | 03:51 | |
| *** itsuugo has joined #openstack-keystone | 03:52 | |
| *** 7YUAB47E0 has joined #openstack-keystone | 03:55 | |
| *** itsuugo has quit IRC | 03:57 | |
| *** itsuugo has joined #openstack-keystone | 03:58 | |
| *** jrist has joined #openstack-keystone | 03:59 | |
| *** sdake has quit IRC | 04:02 | |
| *** itsuugo has quit IRC | 04:08 | |
| *** itsuugo has joined #openstack-keystone | 04:09 | |
| *** GB21 has joined #openstack-keystone | 04:10 | |
| *** itsuugo has quit IRC | 04:14 | |
| *** itsuugo has joined #openstack-keystone | 04:15 | |
| *** haplo37_ has quit IRC | 04:27 | |
| *** haplo37_ has joined #openstack-keystone | 04:29 | |
| *** itsuugo has quit IRC | 04:30 | |
| *** itsuugo has joined #openstack-keystone | 04:31 | |
| *** tqtran has joined #openstack-keystone | 04:32 | |
| *** tqtran has quit IRC | 04:37 | |
| stevemar | jamielennox: poke? | 04:40 |
| *** itsuugo has quit IRC | 04:41 | |
| jamielennox | stevemar: hmmm | 04:41 |
| stevemar | jamielennox: have a minute to look at https://review.openstack.org/#/c/375224/1/zaqarclient/auth/keystone.py ? i gave flwang some advice, but turns out zaqar uses a dict where i thought they use conf >.< | 04:42 |
| *** itsuugo has joined #openstack-keystone | 04:42 | |
| openstackgerrit | Roman Bogorodskiy proposed openstack/python-keystoneclient: Fix non-ascii attributes https://review.openstack.org/374552 | 04:48 |
| *** guoshan has joined #openstack-keystone | 04:51 | |
| *** itsuugo has quit IRC | 04:54 | |
| *** itsuugo has joined #openstack-keystone | 04:55 | |
| *** roxanaghe has quit IRC | 04:58 | |
| openstackgerrit | Roman Bogorodskiy proposed openstack/python-keystoneclient: Allow send null value in extra properties https://review.openstack.org/375239 | 04:58 |
| *** itsuugo has quit IRC | 05:00 | |
| *** itsuugo has joined #openstack-keystone | 05:01 | |
| *** haplo37_ has quit IRC | 05:05 | |
| *** itsuugo has quit IRC | 05:06 | |
| *** edtubill has joined #openstack-keystone | 05:06 | |
| *** itsuugo has joined #openstack-keystone | 05:07 | |
| *** haplo37_ has joined #openstack-keystone | 05:07 | |
| *** edtubill has quit IRC | 05:07 | |
| *** haplo37_ has quit IRC | 05:07 | |
| *** edtubill has joined #openstack-keystone | 05:08 | |
| *** haplo37_ has joined #openstack-keystone | 05:10 | |
| openstackgerrit | Roman Bogorodskiy proposed openstack/python-keystoneclient: Allow send null value in extra properties https://review.openstack.org/375239 | 05:10 |
| *** jaosorior has joined #openstack-keystone | 05:10 | |
| *** haplo37_ has quit IRC | 05:10 | |
| *** edtubill has quit IRC | 05:12 | |
| *** haplo37_ has joined #openstack-keystone | 05:13 | |
| *** ravelar has joined #openstack-keystone | 05:17 | |
| *** itsuugo has quit IRC | 05:19 | |
| *** edtubill has joined #openstack-keystone | 05:20 | |
| *** itsuugo has joined #openstack-keystone | 05:20 | |
| *** ravelar has quit IRC | 05:21 | |
| *** guoshan has quit IRC | 05:27 | |
| *** guoshan has joined #openstack-keystone | 05:27 | |
| *** itsuugo has quit IRC | 05:28 | |
| *** itsuugo has joined #openstack-keystone | 05:28 | |
| *** itsuugo has quit IRC | 05:34 | |
| *** itsuugo has joined #openstack-keystone | 05:34 | |
| *** adriant has quit IRC | 05:35 | |
| *** richm has quit IRC | 05:40 | |
| *** itsuugo has quit IRC | 05:41 | |
| *** itsuugo has joined #openstack-keystone | 05:42 | |
| openstackgerrit | Boris Bobrov proposed openstack/keystone: WIP: remove support for PKI and PKIz tokens https://review.openstack.org/374479 | 05:46 |
| openstackgerrit | Boris Bobrov proposed openstack/keystone: Simplify tests after PKI removal https://review.openstack.org/375121 | 05:46 |
| *** itsuugo has quit IRC | 05:47 | |
| *** itsuugo has joined #openstack-keystone | 05:47 | |
| *** haplo37_ has quit IRC | 05:48 | |
| *** haplo37_ has joined #openstack-keystone | 05:50 | |
| *** edtubill has quit IRC | 05:52 | |
| *** itsuugo has quit IRC | 05:57 | |
| *** itsuugo has joined #openstack-keystone | 05:58 | |
| *** roxanaghe has joined #openstack-keystone | 05:59 | |
| *** ianw is now known as ianw_pto | 06:02 | |
| *** roxanaghe has quit IRC | 06:04 | |
| *** itsuugo has quit IRC | 06:05 | |
| *** itsuugo has joined #openstack-keystone | 06:07 | |
| *** itsuugo has quit IRC | 06:12 | |
| *** itsuugo has joined #openstack-keystone | 06:12 | |
| *** rcernin has joined #openstack-keystone | 06:15 | |
| *** itsuugo has quit IRC | 06:17 | |
| *** itsuugo has joined #openstack-keystone | 06:18 | |
| *** itsuugo has quit IRC | 06:23 | |
| *** aswadr_ has joined #openstack-keystone | 06:25 | |
| *** itsuugo has joined #openstack-keystone | 06:25 | |
| openstackgerrit | Boris Bobrov proposed openstack/keystone: WIP: remove support for PKI and PKIz tokens https://review.openstack.org/374479 | 06:26 |
| breton | \o | 06:27 |
| *** itsuugo has quit IRC | 06:30 | |
| *** itsuugo has joined #openstack-keystone | 06:31 | |
| *** itsuugo has quit IRC | 06:36 | |
| *** itsuugo has joined #openstack-keystone | 06:36 | |
| *** woodster_ has quit IRC | 06:40 | |
| *** itsuugo has quit IRC | 06:42 | |
| *** itsuugo has joined #openstack-keystone | 06:43 | |
| *** GB21 has quit IRC | 06:45 | |
| *** GB21 has joined #openstack-keystone | 06:57 | |
| *** itsuugo has quit IRC | 07:00 | |
| *** itsuugo has joined #openstack-keystone | 07:01 | |
| *** itsuugo has quit IRC | 07:10 | |
| *** itsuugo has joined #openstack-keystone | 07:11 | |
| openstackgerrit | Boris Bobrov proposed openstack/keystone: WIP: remove support for PKI and PKIz tokens https://review.openstack.org/374479 | 07:15 |
| *** itsuugo has quit IRC | 07:23 | |
| *** itsuugo has joined #openstack-keystone | 07:23 | |
| *** itsuugo has quit IRC | 07:30 | |
| *** itsuugo has joined #openstack-keystone | 07:32 | |
| *** amoralej|off is now known as amoralej | 07:36 | |
| *** itsuugo has quit IRC | 07:36 | |
| *** itsuugo has joined #openstack-keystone | 07:39 | |
| *** itsuugo has quit IRC | 07:43 | |
| *** itsuugo has joined #openstack-keystone | 07:44 | |
| *** itsuugo has quit IRC | 07:49 | |
| *** itsuugo has joined #openstack-keystone | 07:50 | |
| openstackgerrit | Boris Bobrov proposed openstack/keystone: Remove support for PKI and PKIz tokens https://review.openstack.org/374479 | 07:57 |
| *** itsuugo has quit IRC | 07:57 | |
| *** guoshan has quit IRC | 07:57 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** itsuugo has joined #openstack-keystone | 08:00 | |
| *** zzzeek has joined #openstack-keystone | 08:00 | |
| *** tqtran has joined #openstack-keystone | 08:01 | |
| *** asettle has joined #openstack-keystone | 08:02 | |
| *** tqtran has quit IRC | 08:05 | |
| *** asettle has quit IRC | 08:07 | |
| *** asettle has joined #openstack-keystone | 08:09 | |
| *** asettle has quit IRC | 08:09 | |
| *** asettle has joined #openstack-keystone | 08:09 | |
| *** pnavarro has joined #openstack-keystone | 08:22 | |
| *** acoles_ is now known as acoles | 08:35 | |
| *** GB21 has quit IRC | 08:42 | |
| *** GB21 has joined #openstack-keystone | 08:46 | |
| *** asettle has quit IRC | 08:49 | |
| *** code-R has joined #openstack-keystone | 08:51 | |
| *** asettle has joined #openstack-keystone | 08:53 | |
| *** asettle has quit IRC | 08:54 | |
| *** asettle has joined #openstack-keystone | 08:54 | |
| *** aohuanxuan has joined #openstack-keystone | 08:55 | |
| *** code-R_ has joined #openstack-keystone | 08:56 | |
| *** code-R has quit IRC | 08:59 | |
| *** roxanaghe has joined #openstack-keystone | 09:00 | |
| *** davechen has left #openstack-keystone | 09:02 | |
| *** EinstCrazy has quit IRC | 09:03 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** openstackgerrit has joined #openstack-keystone | 09:03 | |
| breton | > Please note: The Horizon login screen for K2K for IBM Blue Box Cloud 3.0.0 is not a standard OpenStack feature | 09:04 |
| breton | stevemar: haven't you thought contibuting this to upstream? | 09:04 |
| *** EinstCrazy has joined #openstack-keystone | 09:04 | |
| *** roxanaghe has quit IRC | 09:05 | |
| *** GB21 has quit IRC | 09:06 | |
| *** EinstCrazy has quit IRC | 09:07 | |
| breton | Google invites me to GSoC mentors summit and it overlaps with openstack summit | 09:19 |
| breton | :( | 09:19 |
| *** itsuugo has quit IRC | 09:19 | |
| *** itsuugo has joined #openstack-keystone | 09:21 | |
| *** itsuugo has quit IRC | 09:26 | |
| *** itsuugo has joined #openstack-keystone | 09:27 | |
| *** martinus__ has quit IRC | 09:32 | |
| *** itsuugo has quit IRC | 09:34 | |
| *** itsuugo has joined #openstack-keystone | 09:35 | |
| *** EinstCrazy has joined #openstack-keystone | 09:36 | |
| *** AlexeyAbashkin has quit IRC | 09:40 | |
| *** GB21 has joined #openstack-keystone | 09:49 | |
| *** itsuugo has quit IRC | 09:51 | |
| *** martinus__ has joined #openstack-keystone | 09:52 | |
| *** itsuugo has joined #openstack-keystone | 09:53 | |
| *** itsuugo has quit IRC | 10:00 | |
| *** itsuugo has joined #openstack-keystone | 10:02 | |
| *** itsuugo has quit IRC | 10:07 | |
| *** itsuugo has joined #openstack-keystone | 10:09 | |
| *** richm has joined #openstack-keystone | 10:11 | |
| *** aohuanxuan has quit IRC | 10:12 | |
| openstackgerrit | Boris Bobrov proposed openstack/keystone: Remove support for PKI and PKIz tokens https://review.openstack.org/374479 | 10:20 |
| *** eandersson has quit IRC | 10:20 | |
| *** itsuugo has quit IRC | 10:23 | |
| *** itsuugo has joined #openstack-keystone | 10:24 | |
| *** itsuugo has quit IRC | 10:29 | |
| *** itsuugo has joined #openstack-keystone | 10:30 | |
| *** EinstCrazy has quit IRC | 10:31 | |
| *** itsuugo has quit IRC | 10:35 | |
| *** itsuugo has joined #openstack-keystone | 10:37 | |
| *** nicolasbock has joined #openstack-keystone | 10:41 | |
| openstackgerrit | Boris Bobrov proposed openstack/keystone: Remove support for PKI and PKIz tokens https://review.openstack.org/374479 | 10:41 |
| breton | ok, ^ should now be good to review | 10:41 |
| *** itsuugo has quit IRC | 10:41 | |
| *** itsuugo has joined #openstack-keystone | 10:42 | |
| *** roxanaghe has joined #openstack-keystone | 10:49 | |
| *** 7YUAB47E0 has quit IRC | 10:53 | |
| *** GB21 has quit IRC | 10:53 | |
| *** roxanaghe has quit IRC | 10:54 | |
| *** itsuugo has quit IRC | 11:02 | |
| *** itsuugo has joined #openstack-keystone | 11:03 | |
| *** vaishali_ has joined #openstack-keystone | 11:06 | |
| *** eandersson has joined #openstack-keystone | 11:10 | |
| *** itsuugo has quit IRC | 11:11 | |
| *** itsuugo has joined #openstack-keystone | 11:12 | |
| *** itsuugo has quit IRC | 11:17 | |
| *** itsuugo has joined #openstack-keystone | 11:19 | |
| *** aswadr_ has quit IRC | 11:22 | |
| *** itsuugo has quit IRC | 11:41 | |
| openstackgerrit | Roman Bogorodskiy proposed openstack/python-keystoneclient: Allow send null value in extra properties https://review.openstack.org/375239 | 11:42 |
| *** itsuugo has joined #openstack-keystone | 11:42 | |
| *** itsuugo has quit IRC | 11:47 | |
| *** itsuugo has joined #openstack-keystone | 11:47 | |
| *** vaishali_ has quit IRC | 11:53 | |
| *** jrist has quit IRC | 11:56 | |
| *** GB21 has joined #openstack-keystone | 12:07 | |
| *** jrist has joined #openstack-keystone | 12:08 | |
| *** catintheroof has quit IRC | 12:08 | |
| *** vaishali_ has joined #openstack-keystone | 12:08 | |
| *** raildo has joined #openstack-keystone | 12:09 | |
| *** asettle has quit IRC | 12:13 | |
| *** sc68cal_ is now known as sc68cal | 12:18 | |
| *** nicolasbock has quit IRC | 12:23 | |
| *** amoralej is now known as amoralej|lunch | 12:33 | |
| *** nicolasbock has joined #openstack-keystone | 12:33 | |
| *** itsuugo has quit IRC | 12:35 | |
| *** itsuugo has joined #openstack-keystone | 12:35 | |
| *** vaishali_ has quit IRC | 12:36 | |
| *** roxanaghe has joined #openstack-keystone | 12:36 | |
| *** rcernin has quit IRC | 12:38 | |
| *** daemontool has joined #openstack-keystone | 12:40 | |
| *** roxanaghe has quit IRC | 12:41 | |
| *** itsuugo has quit IRC | 12:42 | |
| *** nicolasbock has quit IRC | 12:42 | |
| ayoung | breton, I have an idea I'd like to float past you. What if we set up a group in Gerrit called keystone-first-reviewers. This is opt in, and you don't have to be Keystone Core to be in it. It is a group that people can add to a review when they first submit it. The idea is that first-reviewers are people willing to screen changes, and its a place for people that want to learn Keystone can get notified of changes to re | 12:42 |
| ayoung | view? | 12:42 |
| *** asettle has joined #openstack-keystone | 12:43 | |
| *** pcaruana|afk| has joined #openstack-keystone | 12:44 | |
| *** itsuugo has joined #openstack-keystone | 12:44 | |
| stevemar | breton: i believe they pushed the patch but need tests | 12:44 |
| stevemar | breton: https://review.openstack.org/#/c/325901/ | 12:44 |
| breton | ayoung: that would be good. Right now i just grep the logs to see new patches. | 12:47 |
| *** sdake has joined #openstack-keystone | 12:48 | |
| ayoung | stevemar, see my question for breton? Make sense? | 12:48 |
| ayoung | We could make additional groups as necessary: keystone-ldap-reviewers etc, if people have special interests | 12:49 |
| *** nicolasbock has joined #openstack-keystone | 12:50 | |
| stevemar | ayoung: if we could do that without having to give people +2, i'd be OK with that | 12:51 |
| stevemar | ayoung: fwiw "first" reviewers is easy with today, i do that -- just subscribe to all new changes in keystone | 12:51 |
| stevemar | ayoung: but i get your point | 12:52 |
| breton | stevemar: how do you do it? | 12:52 |
| stevemar | breton: http://imgur.com/a/XxkEv | 12:53 |
| *** GB21 has quit IRC | 12:54 | |
| openstackgerrit | Merged openstack/keystoneauth: Test that v3fedkerb plugin loads https://review.openstack.org/368017 | 12:54 |
| *** david-lyle has joined #openstack-keystone | 12:56 | |
| stevemar | fungi: do you know if that is possible? ^ | 12:56 |
| stevemar | fungi: gerrit groups that i can toss people in, but they won't have +2 power | 12:57 |
| *** pcaruana|afk| has quit IRC | 13:00 | |
| *** pcaruana has quit IRC | 13:01 | |
| *** pcaruana has joined #openstack-keystone | 13:02 | |
| *** rcernin has joined #openstack-keystone | 13:06 | |
| *** itsuugo has quit IRC | 13:06 | |
| openstackgerrit | Merged openstack/keystoneauth: Fix parameters for Kerberos Auth Plugin https://review.openstack.org/368288 | 13:07 |
| *** itsuugo has joined #openstack-keystone | 13:07 | |
| breton | i would definitely want a stable-reviewers group btw. | 13:08 |
| *** jaosorior has quit IRC | 13:13 | |
| *** jaosorior has joined #openstack-keystone | 13:14 | |
| amakarov | Hey, keystoners! Is ServiceV3.update_service() used anywhere or we are to delete it? I can't find it neither in routers nor in OS-CLI commands | 13:20 |
| stevemar | amakarov: is there an API that updates service? | 13:21 |
| stevemar | amakarov: looks like there is: http://developer.openstack.org/api-ref/identity/v3/index.html?expanded=update-service-detail#update-service | 13:21 |
| amakarov | stevemar, http://developer.openstack.org/api-ref/identity/v3/?expanded=update-service-detail | 13:22 |
| stevemar | amakarov: add it to os-cli :P | 13:22 |
| amakarov | stevemar, cool :) | 13:22 |
| stevemar | amakarov: umm, see if it works first lol | 13:22 |
| stevemar | with some python script | 13:23 |
| *** rcernin has quit IRC | 13:26 | |
| *** eandersson has quit IRC | 13:29 | |
| *** amoralej|lunch is now known as amoralej | 13:30 | |
| *** acoles has quit IRC | 13:30 | |
| *** ekarlso_ has joined #openstack-keystone | 13:37 | |
| dstanek | amakarov: i was able to get a k2k setup working ok last night, but i had to do most of it by hand. trying to fix the automation now though. is there an easy way for me to replicate that bug? | 13:38 |
| *** ngupta has joined #openstack-keystone | 13:41 | |
| breton | dstanek: there is probably no bug, we figured it out. | 13:46 |
| dstanek | breton: ah ok. what was the isue? | 13:46 |
| amakarov | dstanek, the problem is in WebSSO, which, apperently, isn't supposed to work ) | 13:46 |
| breton | dstanek: i don't know, i came and it was already working | 13:48 |
| *** kragniz has quit IRC | 13:48 | |
| *** kragniz has joined #openstack-keystone | 13:48 | |
| amakarov | stevemar, looks like version issue - there actually IS a command for updating service ) | 13:50 |
| lbragstad | i suppose it's too late to catch jamielennox | 13:52 |
| *** rcernin has joined #openstack-keystone | 13:52 | |
| lbragstad | bknudson did you end up figuring out http://paste.openstack.org/show/582675/ ? | 13:53 |
| dstanek | breton: nice | 13:53 |
| bknudson | lbragstad: I didn't look into it yet. | 13:53 |
| lbragstad | bknudson it's failing because the test setup for TestFernetCredentialProviderWithNullKey doesn't override CONF.credential.key_repository | 13:54 |
| lbragstad | bknudson ravelar was hitting that too | 13:54 |
| *** woodster_ has joined #openstack-keystone | 13:54 | |
| bknudson | lbragstad: ok. I can take a look at it this morning | 13:54 |
| *** spzala has joined #openstack-keystone | 13:56 | |
| *** srobert has joined #openstack-keystone | 13:57 | |
| lbragstad | bknudson no worries - ravelar was wanting to fix it | 13:59 |
| breton | have we dropped v3unscopedsaml as os-auth-type in osc? | 13:59 |
| *** itsuugo has quit IRC | 14:00 | |
| *** itsuugo has joined #openstack-keystone | 14:01 | |
| bknudson | ravelar can work on unit tests for https://review.openstack.org/#/c/359371 | 14:04 |
| *** daemontool has quit IRC | 14:12 | |
| *** daemontool_ has joined #openstack-keystone | 14:12 | |
| *** daemontool__ has joined #openstack-keystone | 14:13 | |
| fungi | stevemar: ayoung: what you describe is simple enough to implement. i can create that group for you but as you observed it will take you or someone managing adding people to it and adding it to reviews. i wonder if just telling them to go to a a dashboard you're curating wouldn't be easier over the long run | 14:13 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove credential key repository for null key tests https://review.openstack.org/375512 | 14:14 |
| lbragstad | bknudson fixed ^ | 14:14 |
| *** daemontool_ has quit IRC | 14:17 | |
| *** itsuugo has quit IRC | 14:23 | |
| *** itsuugo has joined #openstack-keystone | 14:24 | |
| *** edtubill has joined #openstack-keystone | 14:25 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove credential key repository for null key tests https://review.openstack.org/375512 | 14:26 |
| lbragstad | bknudson good point - modified the setup to only use a temp directory instead of the fixture | 14:26 |
| stevemar | breton: ayoung mentioned that bug, or someone did | 14:30 |
| *** ravelar has joined #openstack-keystone | 14:30 | |
| stevemar | breton: what about doing just a project list | 14:30 |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Remove useless method override https://review.openstack.org/375524 | 14:31 |
| stevemar | lbragstad: is the commit message still valid? https://review.openstack.org/#/c/375512/ | 14:37 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Override credential key repository for null key tests https://review.openstack.org/375512 | 14:44 |
| lbragstad | stevemar nope - good catch | 14:44 |
| *** acoles has joined #openstack-keystone | 14:46 | |
| *** ngupta_ has joined #openstack-keystone | 14:46 | |
| *** dikonoor has quit IRC | 14:46 | |
| *** asettle has quit IRC | 14:46 | |
| *** HoloIRCUser4 has joined #openstack-keystone | 14:47 | |
| *** ngupta_ has quit IRC | 14:48 | |
| *** ngupta_ has joined #openstack-keystone | 14:48 | |
| *** HoloIRCUser4 is now known as abshkj | 14:49 | |
| *** ngupta has quit IRC | 14:50 | |
| *** tonytan_brb has joined #openstack-keystone | 14:50 | |
| *** esp has joined #openstack-keystone | 14:51 | |
| *** tonytan4ever has quit IRC | 14:53 | |
| lbragstad | abshkj o/ | 14:55 |
| lbragstad | abshkj looks like you're already assigned to https://bugs.launchpad.net/keystone/+bug/1614154 - did you have a question about the bug? | 14:55 |
| openstack | Launchpad bug 1614154 in OpenStack Identity (keystone) "Hints with values of None seem to be broken" [Medium,Confirmed] - Assigned to Abhishek Kumar Tiwary (aktiwary) | 14:55 |
| * abshkj it's not me. I just started exploring this bug | 14:56 | |
| * abshkj I am confused about the expected behavior of this bug | 14:56 | |
| * abshkj need some help | 14:57 | |
| lbragstad | abshkj ah - keystone's Manager layers have the concept of Hints | 14:58 |
| lbragstad | https://github.com/openstack/keystone/blob/dc9a1d5f7061f2de6b75a79ad3133d9e3c14046a/keystone/identity/core.py#L917 | 14:58 |
| lbragstad | abshkj the idea behind hints is that it allows you the ability to pass a certain criteria to the backed | 14:58 |
| lbragstad | and example would be if you wanted to list all users that have a specific domain id | 14:59 |
| lbragstad | you could create a hints object to model that request and pass it to the identity manager, which would pass it to the identity driver | 15:00 |
| lbragstad | the response with either be an empty list - or a list of users that match the domain id from the hints | 15:00 |
| lbragstad | so - hints is really just a way to filter results from the backend | 15:00 |
| lbragstad | abshkj does that make sense so far? | 15:01 |
| * abshkj yes | 15:01 | |
| lbragstad | abshkj so - what that bug is documenting is the inability for hints to support a query like - give me all credentials where the key_hash attribute of a credential is None | 15:02 |
| *** jistr is now known as jistr|call | 15:03 | |
| openstackgerrit | Samuel Pilla proposed openstack/keystone: Domain included for role in list_role_assignment https://review.openstack.org/373516 | 15:03 |
| * abshkj while going through traceback I found that the wontmatch exception is raised where again exception is raised by check method | 15:03 | |
| *** vaishali_ has joined #openstack-keystone | 15:05 | |
| lbragstad | abshkj it looks like rodrigods also had a comment on that bug | 15:05 |
| * abshkj yes I checked that but I am confused with the actual code implementation. | 15:07 | |
| ayoung | breton, yeah, jamielennox dropped it when redoing the auth plugins in ksa. | 15:07 |
| breton | ayoung: intentionally? | 15:07 |
| ayoung | I think we could pick up support for it again with an new entrypoint | 15:07 |
| ayoung | you'll have to ask him. I don't know if there was a reason not to honor the old name, | 15:08 |
| ayoung | it was a bad name, so I don't really mind, except for the confusion it causes | 15:08 |
| *** vaishali_ has quit IRC | 15:08 | |
| breton | ayoung: and the new name is v3samlpassword? | 15:08 |
| *** vaishali_ has joined #openstack-keystone | 15:09 | |
| lbragstad | abshkj the implementation for hints is here - https://github.com/openstack/keystone/blob/master/keystone/common/driver_hints.py | 15:10 |
| lbragstad | abshkj but we need to make the Hints object support filtering by None - because it is passed to the various backends like so https://github.com/openstack/keystone/blob/dc9a1d5f7061f2de6b75a79ad3133d9e3c14046a/keystone/credential/backends/sql.py#L52 | 15:11 |
| openstackgerrit | Richard Avelar proposed openstack/keystone: Change python code revocation search to sql https://review.openstack.org/359371 | 15:12 |
| ayoung | breton, that sounds right. I had this all in short term memory, but long enouhg back that I don't trust it. | 15:12 |
| * abshkj lbragstad ok, I will do some work with the information you provided. | 15:12 | |
| lbragstad | abshkj so one possible solution would be to modify the implementation of the Hints object in a way that sqlalchemy can understand - https://github.com/openstack/keystone/blob/dc9a1d5f7061f2de6b75a79ad3133d9e3c14046a/keystone/common/sql/core.py#L384 | 15:13 |
| * abshkj ok | 15:13 | |
| lbragstad | abshkj which was what rodrigods was eluding to in his comment | 15:13 |
| abshkj | Ok | 15:13 |
| lbragstad | abshkj does that help? | 15:13 |
| abshkj | Yes surely, that's I think enough of information for now to dig further | 15:14 |
| lbragstad | abshkj cool - good luck and thanks for digging into the bug! | 15:14 |
| abshkj | lbragstad thank you very much | 15:15 |
| lbragstad | abshkj anytime - if you have questions, feel free to drop them here | 15:15 |
| *** wajdi_ has joined #openstack-keystone | 15:15 | |
| *** spedione|AWAY is now known as spedione | 15:15 | |
| abshkj | lbragstad thanks, sure. can I send you mail when required | 15:16 |
| *** rcernin has quit IRC | 15:19 | |
| *** tonytan_brb is now known as tonytan4ever | 15:21 | |
| *** slberger has joined #openstack-keystone | 15:21 | |
| *** srobert has quit IRC | 15:23 | |
| *** dikonoor has joined #openstack-keystone | 15:24 | |
| lbragstad | abshkj it's probably easier to just send a ping in this room | 15:24 |
| openstackgerrit | Richard Avelar proposed openstack/keystone: Change python code revocation search to sql https://review.openstack.org/359371 | 15:24 |
| *** nk2527 has quit IRC | 15:25 | |
| abshkj | lbragstad ok sure. Thank you | 15:26 |
| *** jistr|call is now known as jistr | 15:26 | |
| *** roxanaghe has joined #openstack-keystone | 15:26 | |
| *** jistr is now known as jistr|biab | 15:28 | |
| ayoung | dstanek, should I add py35 to our tox.ini for openstack/python-keystoneclient? | 15:30 |
| ayoung | I had just replaced, but looks like we still need 34 as well | 15:30 |
| *** spedione is now known as spedione|AWAY | 15:34 | |
| *** roxanaghe has quit IRC | 15:34 | |
| lbragstad | stevemar apparently the belongsTo thing is completely broken | 15:35 |
| *** roxanaghe has joined #openstack-keystone | 15:35 | |
| lbragstad | stevemar this test actually asserts that belongsTo is broken - https://github.com/openstack/keystone/blob/dc9a1d5f7061f2de6b75a79ad3133d9e3c14046a/keystone/tests/unit/test_auth.py#L419-L439 | 15:36 |
| *** jistr|biab is now known as jistr | 15:36 | |
| lbragstad | stevemar want me to create a new bug or just modify the one you opened? | 15:36 |
| *** lamt has quit IRC | 15:39 | |
| lbragstad | stevemar https://bugs.launchpad.net/keystone/+bug/1627085 | 15:43 |
| openstack | Launchpad bug 1627085 in OpenStack Identity (keystone) "The belongsTo query parameters for v2.0 is broken" [Undecided,New] | 15:43 |
| *** roxanagh_ has joined #openstack-keystone | 15:43 | |
| dstanek | ayoung: it's not necessary to do that | 15:45 |
| *** roxanaghe has quit IRC | 15:45 | |
| ayoung | dstanek, I can't run test on my workstation | 15:45 |
| dstanek | ayoung: that list is only the default list of things to run. really it should be trimmed down to what most people are using | 15:45 |
| dstanek | ayoung: can't test what? | 15:45 |
| ayoung | does not support python34 | 15:45 |
| stevemar | lbragstad: i question how used it is... | 15:46 |
| dstanek | ayoung: just run 'tox -e py35' | 15:46 |
| ayoung | I need python35 in order to test | 15:46 |
| ayoung | was not supported | 15:46 |
| openstackgerrit | ayoung proposed openstack/python-keystoneclient: Add tox tests for python 35 https://review.openstack.org/368236 | 15:46 |
| lbragstad | stevemar same - regardless, it would always return 401 | 15:46 |
| ayoung | ok...let me try again...maybe I fat fingered | 15:46 |
| dstanek | it's doesn't need to be in the tox.ini to use it | 15:46 |
| stevemar | lbragstad: bah | 15:46 |
| *** edmondsw has quit IRC | 15:46 | |
| stevemar | lbragstad: estimate how much it costs to fix, it looks like a simple comparison | 15:47 |
| dstanek | tox has a list of default targets that it has support for *if* you have the interpreter | 15:47 |
| lbragstad | stevemar that test asserts the implementation is broken | 15:47 |
| stevemar | lbragstad: i'd rather not remove a once-supported query parameter, even if undocumneted | 15:47 |
| ayoung | Well, looks like I lied. Again | 15:47 |
| lbragstad | stevemar i already have a fix locally | 15:47 |
| lbragstad | testing it now | 15:48 |
| stevemar | lbragstad: ++ | 15:48 |
| *** edmondsw has joined #openstack-keystone | 15:49 | |
| ayoung | dstanek, true. It just means that when I run tox I need to explicitly call out the -e py35 now | 15:49 |
| ayoung | but, meh. Abandonded. Can re-enable later if we want | 15:50 |
| lbragstad | stevemar where do you want this documented? | 15:50 |
| lbragstad | api-ref/source/v2/identity-auth.inc ? | 15:50 |
| lbragstad | ^ that makes absolutely no mention of token validation though | 15:51 |
| stevemar | lbragstad: just below https://github.com/openstack/keystone/blob/master/api-ref/source/v2-admin/admin-tokens.inc#L125 | 15:51 |
| stevemar | lbragstad: for validate token -- GET /v2.0/tokens/{tokenId} | 15:52 |
| *** vaishali_ has quit IRC | 15:52 | |
| stevemar | lbragstad: it'll also affect the HEAD /v2.0/tokens/{tokenId} route a few lines down | 15:52 |
| openstackgerrit | ayoung proposed openstack/python-keystoneclient: Update README to include creating a session from a config file. https://review.openstack.org/359434 | 15:53 |
| bknudson | lbragstad: why are we fixing bugs in v2? | 15:56 |
| bknudson | leave it broken. | 15:56 |
| *** code-R_ has quit IRC | 15:59 | |
| stevemar | bknudson: it's a query for an API, the API is broken, we should fix it if it's easy | 16:00 |
| *** spzala has quit IRC | 16:01 | |
| stevemar | lbragstad: so the fix is to change 'id' to 'name' here: https://github.com/openstack/keystone/blob/dc9a1d5f7061f2de6b75a79ad3133d9e3c14046a/keystone/token/provider.py#L364 | 16:03 |
| *** tqtran has joined #openstack-keystone | 16:04 | |
| *** spzala has joined #openstack-keystone | 16:06 | |
| *** tqtran has quit IRC | 16:08 | |
| *** lamt has joined #openstack-keystone | 16:12 | |
| *** spedione|AWAY is now known as spedione | 16:15 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix the belongsTo query parameter https://review.openstack.org/375097 | 16:16 |
| *** jistr is now known as jistr|afk | 16:18 | |
| *** jaosorior has quit IRC | 16:21 | |
| *** spzala has quit IRC | 16:22 | |
| lbragstad | stevemar actually - we have tests that tested project id instead | 16:24 |
| lbragstad | stevemar the project name tests just asserted things didn't work | 16:25 |
| *** code-R has joined #openstack-keystone | 16:26 | |
| *** slberger has quit IRC | 16:28 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove untested path in the v2 token controller https://review.openstack.org/375607 | 16:29 |
| *** slberger has joined #openstack-keystone | 16:29 | |
| *** spzala has joined #openstack-keystone | 16:29 | |
| *** abshkj has quit IRC | 16:33 | |
| *** spzala has quit IRC | 16:34 | |
| *** spzala has joined #openstack-keystone | 16:35 | |
| *** gyee has joined #openstack-keystone | 16:38 | |
| openstackgerrit | Richard Avelar proposed openstack/keystone: Change python code revocation search to sql https://review.openstack.org/359371 | 16:39 |
| *** spzala has quit IRC | 16:39 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix the belongsTo query parameter https://review.openstack.org/375097 | 16:40 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix the belongsTo query parameter https://review.openstack.org/375097 | 16:41 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove untested path in the v2 token controller https://review.openstack.org/375607 | 16:42 |
| *** code-R has quit IRC | 16:42 | |
| *** code-R has joined #openstack-keystone | 16:43 | |
| *** code-R_ has joined #openstack-keystone | 16:47 | |
| *** code-R_ has quit IRC | 16:48 | |
| *** code-R has quit IRC | 16:48 | |
| *** code-R has joined #openstack-keystone | 16:48 | |
| *** ravelar has quit IRC | 16:49 | |
| *** spzala has joined #openstack-keystone | 16:51 | |
| stevemar | ayoung: ah, great you found the opt_out option for https://bugs.launchpad.net/keystone/+bug/1627094 | 16:54 |
| openstack | Launchpad bug 1627094 in OpenStack Identity (keystone) " Keystone overwhelms Ceilometer with Identity Events" [Undecided,New] - Assigned to Adam Young (ayoung) | 16:54 |
| ayoung | stevemar, yep | 16:54 |
| ayoung | stevemar, the question is, what are the right set of events for keystone to emit | 16:55 |
| ayoung | stevemar, I'd argue that token create and validation should not be emitted | 16:55 |
| *** spzala has quit IRC | 16:55 | |
| ayoung | but instead that the services should emit notifications for operations actually performed | 16:55 |
| stevemar | ayoung: is it the token create or auth? i thought it was auth | 16:55 |
| ayoung | stevemar, same thing, no? | 16:56 |
| stevemar | hmm, yeah, i suppose, i was thinking if we could reduce it to just password auth | 16:56 |
| *** spzala has joined #openstack-keystone | 16:56 | |
| *** jistr|afk is now known as jistr | 16:59 | |
| ayoung | My view is, who cares if someone creates a token, so long as they never use it. | 16:59 |
| ayoung | Its only the use that we care about | 16:59 |
| ayoung | and a failed validation attempt, OK. But a successful one (very common) should be audited by the actual operation requested | 16:59 |
| ayoung | stevemar, I'll add it to the etherpad for summit | 17:00 |
| *** spzala has quit IRC | 17:01 | |
| *** markvoelker has quit IRC | 17:02 | |
| *** markvoelker has joined #openstack-keystone | 17:02 | |
| *** spzala has joined #openstack-keystone | 17:02 | |
| *** slberger has quit IRC | 17:03 | |
| *** slberger has joined #openstack-keystone | 17:06 | |
| *** ngupta has joined #openstack-keystone | 17:06 | |
| stevemar | ayoung: we can add opt out of that by default | 17:06 |
| stevemar | ayoung: seems fair to me, i've thought they were too spammy | 17:07 |
| *** spzala has quit IRC | 17:07 | |
| openstackgerrit | Merged openstack/keystone: Override credential key repository for null key tests https://review.openstack.org/375512 | 17:07 |
| *** catintheroof has joined #openstack-keystone | 17:09 | |
| *** ngupta_ has quit IRC | 17:10 | |
| *** adu has joined #openstack-keystone | 17:12 | |
| *** edtubill has quit IRC | 17:12 | |
| knikolla | stevemar: pretty much all ldap tests depend on creating a user :/ | 17:12 |
| *** ngupta has quit IRC | 17:14 | |
| *** ngupta has joined #openstack-keystone | 17:14 | |
| *** spzala has joined #openstack-keystone | 17:20 | |
| *** daemontool__ has quit IRC | 17:21 | |
| *** ravelar has joined #openstack-keystone | 17:22 | |
| *** spzala has quit IRC | 17:24 | |
| *** spzala has joined #openstack-keystone | 17:26 | |
| *** code-R_ has joined #openstack-keystone | 17:28 | |
| *** spzala has quit IRC | 17:30 | |
| *** code-R has quit IRC | 17:31 | |
| *** spzala has joined #openstack-keystone | 17:32 | |
| *** code-R has joined #openstack-keystone | 17:35 | |
| breton | knikolla: if an ldap test depends on _creating_ a user, it should be dropped | 17:35 |
| breton | knikolla: if it depends on the user existing in ldap, it should be created there directly | 17:36 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Add docs for PCI-DSS https://review.openstack.org/374422 | 17:36 |
| breton | knikolla: which is what we shall always expect with write disabled | 17:36 |
| *** spzala has quit IRC | 17:36 | |
| knikolla | breton: test_list_projects_for_user creates a user, i don't think we want to drop that | 17:37 |
| knikolla | so basically the tests need to be rewritten to use a predefined pool of users. this should be fun. | 17:38 |
| *** code-R_ has quit IRC | 17:38 | |
| breton | knikolla: although it creates a user, it doesn't really test the process of creation. It tests things when user is there. | 17:40 |
| breton | knikolla: i think that it's worth creating a method that would put user directly into our ldap | 17:40 |
| breton | knikolla: and replace all identity_api.create() to _create_directly() | 17:41 |
| knikolla | breton: fakeldap has a add_s method, i'll probably use that directly | 17:42 |
| breton | knikolla: there is not only fakeldap unfortunately | 17:42 |
| breton | knikolla: there are live ldap tests. I am not sure they are not broken though. | 17:42 |
| knikolla | breton: i thought we didn't have any functional ldap tests | 17:43 |
| breton | knikolla: they are not really "functional", they run with unit tests | 17:44 |
| *** spzala has joined #openstack-keystone | 17:44 | |
| knikolla | breton: oh, I thought all unit tests ran with fakeldap | 17:45 |
| breton | knikolla: for example, check out things in test_ldap_pool_livetest.py | 17:45 |
| *** artmr has quit IRC | 17:45 | |
| breton | knikolla: or test_ldap_livetest.py | 17:46 |
| breton | knikolla: or other files with word "live" :) | 17:46 |
| knikolla | breton: yep, just saw those. thanks. | 17:47 |
| knikolla | breton: probably best to just move the create methods outside of the ldap driver so we can still use them in the tests | 17:48 |
| breton | knikolla: yep, i'd do that too | 17:49 |
| * knikolla gets back to work | 17:49 | |
| *** tqtran has joined #openstack-keystone | 17:50 | |
| *** gyee has quit IRC | 17:50 | |
| *** spzala has quit IRC | 17:52 | |
| *** amoralej is now known as amoralej|off | 17:52 | |
| *** spzala has joined #openstack-keystone | 17:54 | |
| openstackgerrit | Andrew Laski proposed openstack/oslo.policy: Add optional exception for check_rules https://review.openstack.org/374251 | 17:55 |
| openstackgerrit | Andrew Laski proposed openstack/oslo.policy: Perform basic checks on policy definitions https://review.openstack.org/373491 | 17:55 |
| openstackgerrit | Sean Perry proposed openstack/keystone: Add domain check in domain-specific role implication https://review.openstack.org/374463 | 17:58 |
| *** itsuugo has quit IRC | 18:03 | |
| *** itsuugo has joined #openstack-keystone | 18:04 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Fix 'API Specification for Endpoint Filtering' broken link https://review.openstack.org/375656 | 18:06 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Fix 'API Specification for Endpoint Filtering' broken link https://review.openstack.org/375656 | 18:08 |
| *** acoles is now known as acoles_ | 18:09 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Add docs for PCI-DSS https://review.openstack.org/374422 | 18:16 |
| *** itsuugo has quit IRC | 18:16 | |
| *** itsuugo has joined #openstack-keystone | 18:18 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Add docs for PCI-DSS https://review.openstack.org/374422 | 18:19 |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Add docs for PCI-DSS https://review.openstack.org/374422 | 18:20 |
| *** pnavarro has quit IRC | 18:21 | |
| *** adu has quit IRC | 18:25 | |
| *** adu has joined #openstack-keystone | 18:26 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix the belongsTo query parameter https://review.openstack.org/375097 | 18:26 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove untested path in the v2 token controller https://review.openstack.org/375607 | 18:26 |
| *** itsuugo has quit IRC | 18:31 | |
| *** itsuugo has joined #openstack-keystone | 18:32 | |
| *** itsuugo has quit IRC | 18:37 | |
| *** itsuugo has joined #openstack-keystone | 18:38 | |
| *** slberger1 has joined #openstack-keystone | 18:40 | |
| *** slberger has quit IRC | 18:41 | |
| *** edtubill has joined #openstack-keystone | 18:43 | |
| *** esp has quit IRC | 18:48 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix the belongsTo query parameter https://review.openstack.org/375097 | 18:49 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove unused path in the v2 token controller https://review.openstack.org/375607 | 18:50 |
| *** ngupta has quit IRC | 18:54 | |
| openstackgerrit | Richard Avelar proposed openstack/keystone: Change python code revocation search to sql https://review.openstack.org/359371 | 18:54 |
| *** ngupta has joined #openstack-keystone | 18:55 | |
| *** ngupta_ has joined #openstack-keystone | 18:56 | |
| *** ngupta has quit IRC | 18:59 | |
| *** esp has joined #openstack-keystone | 19:08 | |
| *** artmr has joined #openstack-keystone | 19:08 | |
| artmr | Hello everyone | 19:09 |
| artmr | about the related https://bugs.launchpad.net/python-keystoneclient/+bug/1626640 | 19:09 |
| openstack | Launchpad bug 1626640 in python-keystoneclient "`find` method of keystoneclient doesn't work properly" [Undecided,In progress] - Assigned to Arthur Miranda (artmr) | 19:09 |
| artmr | I have a solution, can you help me? | 19:10 |
| *** david-lyle_ has joined #openstack-keystone | 19:10 | |
| *** ngupta_ has quit IRC | 19:12 | |
| *** ngupta has joined #openstack-keystone | 19:12 | |
| *** david-lyle has quit IRC | 19:13 | |
| openstackgerrit | Richard Avelar proposed openstack/keystone: Change python code revocation search to sql https://review.openstack.org/359371 | 19:13 |
| *** ngupta has quit IRC | 19:17 | |
| *** tonytan4ever has quit IRC | 19:17 | |
| *** catintheroof has quit IRC | 19:17 | |
| breton | artmr: what's the problem? | 19:22 |
| *** ngupta has joined #openstack-keystone | 19:25 | |
| stevemar | rodrigods: if you're looking for a quick patch to continue with your domain specific config work in ksc/osc -- i left comments on https://review.openstack.org/#/c/368498/ | 19:27 |
| artmr | the reported bug includes the usage (e.g.) keystoneclient.projects.find(id=<id>) | 19:29 |
| *** tonytan4ever has joined #openstack-keystone | 19:29 | |
| artmr | but if you have the id, the correct usage is the method get(), not find() | 19:30 |
| artmr | if you pass the ID and another parameter, de function ignores the ID | 19:30 |
| artmr | I have a path to solve this | 19:31 |
| artmr | patch* | 19:31 |
| artmr | But the status is new, breton. Can I change? | 19:32 |
| *** spzala has quit IRC | 19:33 | |
| *** itsuugo has quit IRC | 19:34 | |
| *** itsuugo has joined #openstack-keystone | 19:35 | |
| *** spzala has joined #openstack-keystone | 19:36 | |
| *** itsuugo has quit IRC | 19:39 | |
| *** spzala has quit IRC | 19:40 | |
| breton | artmr: the status will be changed automatically as soon as you propose the patch. | 19:41 |
| *** itsuugo has joined #openstack-keystone | 19:42 | |
| artmr | Ok | 19:43 |
| *** bjolo has quit IRC | 19:43 | |
| *** thiagolib has joined #openstack-keystone | 19:46 | |
| lbragstad | dstanek i'm digging in the keystone tests and we have keystone/tests/unit/test_v2.py and keystone/tests/unit/test_auth.py which has a lot of v2 tests in it | 19:48 |
| lbragstad | cc stevemar ^ | 19:48 |
| lbragstad | it seems like the test_v2.py model actually does things using requests | 19:49 |
| *** itsuugo has quit IRC | 19:49 | |
| lbragstad | where test_auth.py relies on a lot of the backends in the tests... should we just port the tests from test_auth.py to test_v2.py | 19:49 |
| lbragstad | ? | 19:49 |
| *** itsuugo has joined #openstack-keystone | 19:50 | |
| *** itsuugo has quit IRC | 19:55 | |
| *** itsuugo has joined #openstack-keystone | 19:55 | |
| *** code-R has quit IRC | 19:58 | |
| *** sdake has quit IRC | 20:00 | |
| breton | i think that some time ago we decided to drop the tests that actually do requests and move them to functional tests | 20:01 |
| *** itsuugo has quit IRC | 20:02 | |
| *** slberger1 has quit IRC | 20:04 | |
| *** itsuugo has joined #openstack-keystone | 20:04 | |
| *** david-lyle_ is now known as david-lyle | 20:06 | |
| lbragstad | breton what do you mean? | 20:07 |
| *** tonytan4ever has quit IRC | 20:12 | |
| lbragstad | breton we aren't waiting on anything for the functional tests - are we? | 20:13 |
| lbragstad | breton looks like we only test versions | 20:13 |
| *** dikonoor has quit IRC | 20:13 | |
| *** code-R has joined #openstack-keystone | 20:16 | |
| breton | lbragstad: well, we talked that those tests, which are in test_v2 look very like functional. They basically test the whole stack (router, controller, manager, backend etc), while unit-tests should not do it | 20:23 |
| breton | lbragstad: and that they should actually be functional tests to truly test the whole stack | 20:24 |
| *** itsuugo has quit IRC | 20:24 | |
| breton | lbragstad: but no one voluntered to write these actual functional tests | 20:25 |
| *** spzala has joined #openstack-keystone | 20:26 | |
| *** clenimar has quit IRC | 20:26 | |
| *** itsuugo has joined #openstack-keystone | 20:26 | |
| *** mlovell has quit IRC | 20:27 | |
| *** mlovell has joined #openstack-keystone | 20:27 | |
| lbragstad | breton got it | 20:29 |
| lbragstad | breton hmm - it seems the functional tests would just be port of what we already have in keystone/tests/unit/test_v3_auth.py | 20:29 |
| lbragstad | or keystone/tests/unit/test_v2.py | 20:30 |
| *** haplo37_ has quit IRC | 20:30 | |
| *** code-R has quit IRC | 20:31 | |
| *** spzala has quit IRC | 20:31 | |
| *** code-R has joined #openstack-keystone | 20:31 | |
| *** ngupta_ has joined #openstack-keystone | 20:32 | |
| *** haplo37_ has joined #openstack-keystone | 20:32 | |
| lbragstad | breton do we have docs for the existing functional tests anywhere? | 20:33 |
| *** ngupta has quit IRC | 20:35 | |
| *** ravelar has quit IRC | 20:36 | |
| *** adu has quit IRC | 20:36 | |
| *** esp has quit IRC | 20:44 | |
| *** ngupta_ has quit IRC | 20:45 | |
| *** ngupta has joined #openstack-keystone | 20:45 | |
| breton | lbragstad: probably no. We have a couple of specs approved and we have /keystone_tempest_plugin | 20:45 |
| *** esp has joined #openstack-keystone | 20:45 | |
| lbragstad | breton do we run the functional tests as part of the gate? | 20:50 |
| ayoung | tag 8.1.2 is Mitaka stable, right? | 20:51 |
| ayoung | or is it 9.2.0 ? | 20:51 |
| ayoung | ER, I mean, yeah 9.2.0 is mitaka. 8.1.2 is Liberty stable, right? | 20:52 |
| *** artmr has quit IRC | 20:54 | |
| *** woodburn has quit IRC | 20:56 | |
| bknudson | ayoung: mitaka is 9.2.0 | 20:59 |
| bknudson | liberty is 8.1.2 | 20:59 |
| ayoung | bknudson, got this running tox for 8: http://paste.openstack.org/show/582820/ | 20:59 |
| ayoung | something in cryptography is unhappy on my Fedora 24 machine | 20:59 |
| bknudson | y, that's a weird one. | 21:00 |
| bknudson | I assume any pip install cryptography would fail that way. | 21:00 |
| bknudson | version of openssl? | 21:00 |
| *** edtubill has quit IRC | 21:01 | |
| ayoung | bknudson, probably one of the removed functions? | 21:01 |
| ayoung | let me see how versions changed. I might be able to hack my repo to use the newer version, as I want this for LDAP testing ,not crypto | 21:01 |
| bknudson | tried it on my old ubuntu and no errors | 21:02 |
| bknudson | cryptography-1.5.1 | 21:02 |
| ayoung | yeah, this is calling for cryptography>=1.0 # Apache-2.0 | 21:02 |
| bknudson | OpenSSL 1.0.1f 6 Jan 2014 | 21:02 |
| ayoung | let me up that | 21:02 |
| bknudson | cryptography-1.0.2 worked too | 21:03 |
| ayoung | bknudson, my guess is that 1.5.1 works with anything backwards compat, but 1.0 is not forward compat | 21:03 |
| ayoung | OpenSSL 1.0.1f 6 Jan 2014 is old | 21:04 |
| ayoung | same error... | 21:04 |
| bknudson | yes, maybe xenial has newer. | 21:04 |
| ayoung | openssl-1.0.2h-3.fc24.x86_64 | 21:04 |
| ayoung | Build Date : Wed 10 Aug 2016 08:42:57 AM EDT | 21:05 |
| *** wajdi_ has quit IRC | 21:05 | |
| *** ngupta_ has joined #openstack-keystone | 21:05 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Fix the belongsTo query parameter https://review.openstack.org/375097 | 21:05 |
| *** raildo has quit IRC | 21:06 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove unused path in the v2 token controller https://review.openstack.org/375607 | 21:06 |
| *** slberger has joined #openstack-keystone | 21:06 | |
| lbragstad | stevemar have we considered adding keystone/tests/functional to the gate? | 21:07 |
| openstackgerrit | Arthur Miranda proposed openstack/python-keystoneclient: Adjustments in behavior of find method in base.py class https://review.openstack.org/375730 | 21:07 |
| lbragstad | stevemar right now it looks like we run the tests in the tempest plugin directories but not the keystone functional tests | 21:07 |
| *** ngupta has quit IRC | 21:08 | |
| *** ngupta_ has quit IRC | 21:09 | |
| *** spedione is now known as spedione|AWAY | 21:13 | |
| *** woodburn has joined #openstack-keystone | 21:13 | |
| *** ravelar has joined #openstack-keystone | 21:16 | |
| *** itsuugo has quit IRC | 21:20 | |
| *** itsuugo has joined #openstack-keystone | 21:22 | |
| *** itsuugo has quit IRC | 21:30 | |
| *** thumpba has joined #openstack-keystone | 21:31 | |
| *** itsuugo has joined #openstack-keystone | 21:32 | |
| breton | lbragstad: yes, as part of all tempest tests | 21:35 |
| breton | lbragstad: in addition to their suite | 21:35 |
| *** ngupta has joined #openstack-keystone | 21:36 | |
| lbragstad | breton i was digging through some rest results from a patch in review but I didn't see these run anywhere - https://github.com/openstack/keystone/blob/3b24a6fca67ff595b5e37fb020eea37717ab7ce1/keystone/tests/functional/shared/test_running.py | 21:36 |
| lbragstad | I see we run these - https://github.com/openstack/keystone/tree/3b24a6fca67ff595b5e37fb020eea37717ab7ce1/keystone_tempest_plugin/tests/api/identity/v3 | 21:38 |
| *** ngupta has quit IRC | 21:39 | |
| breton | lbragstad: yes. I don't know whether tests from functional/ run on gates now. | 21:39 |
| *** ngupta has joined #openstack-keystone | 21:39 | |
| *** ravelar has quit IRC | 21:40 | |
| jamielennox | breton: the v3unscopedsaml plugin was dropped because it wasn't actually useful for anything and didn't follow the same patterns sa the other plugin | 21:40 |
| rderose | ravelar SpamapS: you guys around? | 21:41 |
| jamielennox | you couldn't scope it so the only thing you could do was use osc to fetch a token and then plug that back into osc to rescope that token | 21:41 |
| jamielennox | instead we just moved to v3saml and like every other plugin if you provide --project{-name,-id} it will scope it and if you don't it's unscoped | 21:41 |
| lbragstad | breton hmmm - strange.... i don't see them run anywhere | 21:41 |
| lbragstad | i'll have to ask stevemar | 21:41 |
| *** tonytan4ever has joined #openstack-keystone | 21:43 | |
| *** code-R has quit IRC | 21:43 | |
| openstackgerrit | Gage Hugo proposed openstack/keystone: Doctor check for LDAP domain specific configs https://review.openstack.org/361435 | 21:45 |
| *** thumpba has quit IRC | 21:46 | |
| *** tonytan4ever has quit IRC | 21:47 | |
| *** slberger has left #openstack-keystone | 21:55 | |
| *** lamt has quit IRC | 22:01 | |
| *** jrist has quit IRC | 22:08 | |
| *** ravelar has joined #openstack-keystone | 22:13 | |
| *** spzala has joined #openstack-keystone | 22:23 | |
| SpamapS | rderose: I"m here, wassup? | 22:24 |
| *** itsuugo has quit IRC | 22:24 | |
| *** itsuugo has joined #openstack-keystone | 22:25 | |
| rderose | SpamapS: was wondering about https://review.openstack.org/#/c/359371? | 22:26 |
| rderose | SpamapS: I left a comment, but basically wondering what indexes would you suggest? | 22:26 |
| *** esp has quit IRC | 22:27 | |
| rderose | as these columns are mostly nullable and can be many different combinations of values | 22:27 |
| *** esp has joined #openstack-keystone | 22:28 | |
| SpamapS | rderose: nullable is fine. THe question is really, how intense are the writes to reads on that table? | 22:29 |
| rderose | SpamapS: hmm... well, I think read is really the issue. but yeah, with adding indexes it will slow down writes... | 22:31 |
| SpamapS | rderose: because what would probably be the best indexes would be several, one for each field that might be OR'd compounded with issued_before | 22:31 |
| SpamapS | The order of the fields matters a lot, because of the range filter, but if you do it right, a user_id+issued_before index would make for very fast queries | 22:32 |
| *** spzala has quit IRC | 22:35 | |
| rderose | SpamapS: yeah, makes sense | 22:35 |
| SpamapS | rderose: but, if you cover all the OR's.. I count 9 | 22:35 |
| SpamapS | so maybe you do the most common ones as a compound, and then also an issued_before | 22:36 |
| rderose | SpamapS: yeah, makes sense | 22:36 |
| SpamapS | All those OR's... are they really necessary? | 22:36 |
| rderose | SpamapS: good question, but I think so | 22:37 |
| rderose | SpamapS: I'll get with ravelar on Monday to add some indexing | 22:38 |
| rderose | SpamapS: thanks | 22:39 |
| *** itsuugo has quit IRC | 22:40 | |
| *** itsuugo has joined #openstack-keystone | 22:42 | |
| SpamapS | rderose: cool. And yeah, if we can look at the frequency of writes to reads for that table, the indexing decision could be easy. My gut feeling is that it's about 10000:1 reads:writes, so indexes should be poured on like warm maple syrup on pancakes. :) | 22:42 |
| rderose | SpamapS: hahaha nice :) | 22:43 |
| *** tonytan4ever has joined #openstack-keystone | 22:44 | |
| *** markvoelker has quit IRC | 22:47 | |
| *** tonytan4ever has quit IRC | 22:48 | |
| *** thiagolib has quit IRC | 22:58 | |
| *** jrist has joined #openstack-keystone | 23:00 | |
| *** itsuugo has quit IRC | 23:01 | |
| *** itsuugo has joined #openstack-keystone | 23:02 | |
| *** jrist has quit IRC | 23:03 | |
| *** jrist has joined #openstack-keystone | 23:04 | |
| *** sdake has joined #openstack-keystone | 23:17 | |
| *** itsuugo has quit IRC | 23:24 | |
| *** itsuugo has joined #openstack-keystone | 23:25 | |
| *** ngupta has quit IRC | 23:29 | |
| *** ngupta has joined #openstack-keystone | 23:30 | |
| *** itsuugo has quit IRC | 23:32 | |
| *** itsuugo has joined #openstack-keystone | 23:33 | |
| *** ngupta has quit IRC | 23:34 | |
| *** itsuugo has quit IRC | 23:39 | |
| *** itsuugo has joined #openstack-keystone | 23:40 | |
| *** ddieterly has joined #openstack-keystone | 23:42 | |
| *** markvoelker has joined #openstack-keystone | 23:48 | |
| *** itsuugo has quit IRC | 23:50 | |
| *** esp has quit IRC | 23:51 | |
| *** itsuugo has joined #openstack-keystone | 23:52 | |
| *** markvoelker has quit IRC | 23:52 | |
| *** itsuugo has quit IRC | 23:56 | |
| *** iurygregory_ has joined #openstack-keystone | 23:57 | |
| *** itsuugo has joined #openstack-keystone | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!