*** tonytan4ever has joined #openstack-keystone | 00:02 | |
*** ddieterly has joined #openstack-keystone | 00:06 | |
*** ddieterly has quit IRC | 00:32 | |
*** ddieterly has joined #openstack-keystone | 00:43 | |
*** aabashkin_ has joined #openstack-keystone | 00:47 | |
*** GB21 has joined #openstack-keystone | 00:47 | |
*** AlexeyAbashkin has quit IRC | 00:48 | |
*** chrisshattuck has joined #openstack-keystone | 00:48 | |
*** chrisshattuck has quit IRC | 00:55 | |
*** chrisshattuck has joined #openstack-keystone | 00:57 | |
*** chrisshattuck has quit IRC | 01:01 | |
jamielennox | ayoung: we went to using a loader object seperate from the plugin itself so that it would be possible to have multiple loaders per plugin | 01:05 |
---|---|---|
jamielennox | ayoung: particularly with token plugin there are times where you would want to provide different things on the command line but still end up using the same actual plugin in practice | 01:06 |
jamielennox | also, hey all | 01:06 |
ayoung | jamielennox, it is entirely possible that what I was seeing was a result of us freezing at an old version or something I did | 01:06 |
ayoung | Hey | 01:06 |
ayoung | jamielennox, what I was running in to was, on a Tripleo deploy, where I had (I think) updated both openstackclient and osc-config, it was using the KC plugins, and not the python-openstackclient ones | 01:07 |
breton | o/ | 01:08 |
jamielennox | yea, so switching from one to the other is something that takes a little bit of work in the migration to ksa, but it shouldn't be difficult and the actual parameters and plugins are identical with one or two small exceptions | 01:08 |
ayoung | and...it made me realize, that, even if I am doing something wrong, if some one is trying to get plugins out of the client, they should get the KSA versions | 01:08 |
ayoung | the options look like they are doing a different mechanism | 01:08 |
ayoung | jamielennox, I did fix the fedkerb plugin based on this, so the effort was worth it | 01:09 |
jamielennox | so OSC 3 goes to completely ksa plugins, but i don't see a way that it could get mixed up and use the wrong ones | 01:09 |
ayoung | did not get to test the straight kerberos one thoght | 01:09 |
jamielennox | and really we would like people to pass the auth plugin into clients, not get it out of clients, but some things do this wrong | 01:09 |
ayoung | jamielennox, heh | 01:10 |
ayoung | all over the place | 01:10 |
ayoung | if we don't want people to do something, we need to remove it. Otherwise, people are going to do it. | 01:10 |
ayoung | but if people were creating the auth plugin use a namespace, they will have the kc namespace | 01:11 |
ayoung | which is, I think, what I was seeing | 01:11 |
jamielennox | yea, the worst part is they end up pulling it out of the ksc client and that one is the most hacked up because we had to provide a lot of compatibility there that other clients didn't | 01:11 |
ayoung | and I just (10 minutes ago) tore down that cluster, damnit | 01:11 |
ayoung | jamielennox, you should have seen what rcrit did to get the novajoin service to install | 01:12 |
ayoung | he has 3 keystone URLs specified on the command line | 01:12 |
ayoung | uri, url and keystone | 01:12 |
ayoung | don't ask me why | 01:12 |
*** chlong_ has joined #openstack-keystone | 01:12 | |
ayoung | but we need to get things down to where people specify one and only one | 01:12 |
*** chlong has joined #openstack-keystone | 01:12 | |
jamielennox | ayoung: reviewed https://review.openstack.org/#/c/368288/ | 01:14 |
ayoung | jamielennox, so I was getting errors that the caller was calling with 2 params and needed 4 or vice versa | 01:15 |
ayoung | dropping *args was not deliberate, and maybe not strictly required | 01:15 |
jamielennox | ayoung: don't suppose you remember what was missing? | 01:17 |
jamielennox | the three required args are auth_url, identity_provider and protocol and all of them are marked as required in the opt | 01:18 |
jamielennox | ayoung: oh on the earlier question, the mechanism is slightly different because we didn't want ksa to have a direct dependency on oslo.config so we don't use the oslo.config Opts directly, but the process is pretty much the same | 01:19 |
*** chrisshattuck has joined #openstack-keystone | 01:20 | |
ayoung | jamielennox, I can test it out here in a moment | 01:22 |
jamielennox | ayoung: sounds good - we knew when we commited the kerberos stuff that we hadn't tested it completely but I failed to create the env a few times and moved on and noone else knew how | 01:24 |
jamielennox | so commited what looked right and figured someone would file a bug if it was wrong | 01:24 |
ayoung | jamielennox, I'm looping back around it it | 01:24 |
*** davechen has joined #openstack-keystone | 01:24 | |
*** chrisshattuck has quit IRC | 01:25 | |
ayoung | it is close, but gets a wrong argument exception when you try to use it. You don't actually need a working environment to test that | 01:25 |
jamielennox | yea, looking at your fix it's obvious now | 01:25 |
ayoung | jamielennox, we might find the same thing on the *args from OSC and Federation | 01:25 |
ayoung | I think it was something about how it was called...let me see if I can retrigger | 01:26 |
ayoung | heh https://bugs.launchpad.net/keystoneauth/+bug/1622079 or we can check the bug tracker | 01:26 |
openstack | Launchpad bug 1622079 in keystoneauth "fedkerb plugin has wrong number of arguments" [Undecided,In progress] - Assigned to Adam Young (ayoung) | 01:26 |
ayoung | TypeError: __init__() takes exactly 4 arguments (2 given) | 01:27 |
ayoung | jamielennox, so this is the test failure http://paste.openstack.org/show/571885/ | 01:30 |
ayoung | and I don't think it is the keystoneauth[kerberos] code that is not installed, but rather the pykerberos dependency | 01:30 |
ayoung | maybe that does not exist for py35? | 01:30 |
ayoung | jamielennox, you have a machine that can run py34? Fedora seems to only do py35 now | 01:32 |
*** ddieterly has quit IRC | 01:34 | |
*** wangqun has joined #openstack-keystone | 01:41 | |
ayoung | jamielennox, is the *args thing a deal breaker? Why does it need to be there? | 01:42 |
jamielennox | ayoung: it's been a while but i think that kerberos plugin is only for py27 | 01:44 |
ayoung | jamielennox, nah, it was a dependency issue | 01:45 |
ayoung | I had to add some deps to test-requirements, but they passed | 01:45 |
jamielennox | ayoung: but then again i thought we fixed that because i wanted to swap it for simo's python gssapi | 01:45 |
jamielennox | oh, which? | 01:45 |
ayoung | yeah, that would be nice, but that would be a fix in requests, wouldn't it? | 01:45 |
ayoung | python-requests-gssapi as a replacement | 01:46 |
jamielennox | yea, python-requests-kerberos | 01:46 |
jamielennox | or i looked at creating a python-requests-gssapi but then they fixed py3 | 01:46 |
jamielennox | :) | 01:46 |
ayoung | so, can I submit without the *args? pretty sure that was part of the problem that cause the error, and I really don't feel like messing with it | 01:46 |
jamielennox | python-kerberos is a C library that is extracted out of some apple calendar service or something and it would be nice to dump it but whatever | 01:47 |
jamielennox | red hat are the main users and they package it all up as rpms so noone there wil lnotice | 01:47 |
jamielennox | can you show me where its coming from? | 01:47 |
jamielennox | or i guess submit what you ahve and let me run it | 01:48 |
ayoung | sure, let me submit the fix | 01:48 |
jamielennox | i don't think i'll hold it up on that but every other plugin allows you to pass at least auth_url as positional | 01:48 |
openstackgerrit | ayoung proposed openstack/keystoneauth: Fix parameters for Kerberos Auth Plugin https://review.openstack.org/368288 | 01:48 |
jamielennox | relocating for coffee quickly, back in like 5 min and i'll run it then | 01:51 |
ayoung | WFM | 01:51 |
ayoung | jamielennox, I | 01:51 |
ayoung | 'll give it another go anyway | 01:51 |
ayoung | now that I know what you want wuith auth_url | 01:51 |
openstackgerrit | Dave Chen proposed openstack/keystone: Add foreign keys to trust table https://review.openstack.org/368422 | 01:56 |
*** EinstCrazy has joined #openstack-keystone | 01:57 | |
openstackgerrit | ayoung proposed openstack/keystoneauth: Fix parameters for Kerberos Auth Plugin https://review.openstack.org/368288 | 01:58 |
*** jamielennox is now known as jamielennox|away | 02:00 | |
openstackgerrit | xianming.mao proposed openstack/keystone: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/368413 | 02:02 |
*** jamielennox|away is now known as jamielennox | 02:04 | |
*** ddieterly has joined #openstack-keystone | 02:05 | |
jamielennox | ayoung: ah, ok, i see why you have problems with the requirements | 02:06 |
ayoung | jamielennox, and those version numbers are pretty random | 02:06 |
ayoung | jamielennox, got the args thing. I was overthinking it | 02:06 |
jamielennox | good, i thought that would be a trivial fix | 02:06 |
jamielennox | ayoung: so tox is installing the kerberos extras as it should: https://github.com/openstack/keystoneauth/blob/master/tox.ini#L15 | 02:07 |
ayoung | yep | 02:07 |
jamielennox | but kerberos is only defined for py2.x | 02:07 |
jamielennox | https://github.com/openstack/keystoneauth/blob/master/setup.cfg#L28 | 02:07 |
ayoung | it all seems to be working . I might need to put a patch into the RPM for the warning message. Telling RPM users to pip install seems wrong | 02:08 |
jamielennox | that would have made sense originally and we just never fixed it after it landed py3 support | 02:08 |
ayoung | test worked for py35 here | 02:08 |
ayoung | want me to take that out? | 02:08 |
ayoung | should probably get that now | 02:08 |
jamielennox | yea, but looking at it that string is defined in global requirements | 02:09 |
*** wangqun_ has joined #openstack-keystone | 02:09 | |
jamielennox | and i actually wrote a bit of this handling so it g-r will always resync it that way | 02:09 |
ayoung | I think the license is wrong there , too | 02:09 |
*** wangqun has quit IRC | 02:09 | |
jamielennox | so requests-kerberos is up to 0.10 https://pypi.python.org/pypi/requests-kerberos | 02:10 |
jamielennox | yea, looks like: https://github.com/requests/requests-kerberos/blob/master/LICENSE | 02:11 |
jamielennox | i don't know what the ISC lisence is | 02:11 |
ayoung | me either | 02:12 |
davechen | ayoung: sorry for chiming in, just replied your comments and take a look at it when you got a chance, thanks! | 02:13 |
openstackgerrit | ayoung proposed openstack/keystoneauth: Fix parameters for Kerberos Auth Plugin https://review.openstack.org/368288 | 02:13 |
ayoung | davechen, I think I originally wrote trusts with those foreign keys and we had to remove them | 02:13 |
ayoung | davechen, not until we can kill the LDAP backend | 02:13 |
davechen | ayoung: i doubled check the migration and haven't found there is any scirpt to update the Fks | 02:14 |
ayoung | davechen, was collapsed, years ago | 02:14 |
*** ddieterly has quit IRC | 02:14 | |
ayoung | trusts went in to Grizzly I think | 02:14 |
davechen | ayoung: does trust support ldap? | 02:14 |
ayoung | actually, no, I did not put them in | 02:14 |
ayoung | yes | 02:14 |
ayoung | trusts would never have had FKs to identity | 02:15 |
ayoung | I did LDAP first, would not have put those in there | 02:15 |
davechen | ayoung: not in the upsteam at least | 02:15 |
ayoung | but I think it had FKs to project etc | 02:15 |
ayoung | does not matter, we are not putting in FKs yet. not until we can do LDAP as a federation setup | 02:15 |
ayoung | jamielennox, I really don't want you as a coauthor on that patch, as I fear then that no one would be able to review it | 02:16 |
jamielennox | ayoung: so it looks like (hard to tell exactly) that 1.2.2 was the first pykerberos to support python 3 | 02:16 |
davechen | ayoung: we have fk enabled for other entities why we don't consider the case of LDAP then? | 02:16 |
jamielennox | ayoung: oh, i don't mind about co-author, this was all you | 02:16 |
ayoung | jamielennox, so, the version should be OK. If you are on a py3 system, it will get >.6 and install, right? | 02:17 |
ayoung | jamielennox, I mean even an edit...just tell me what to fix! | 02:17 |
*** namnh has joined #openstack-keystone | 02:17 | |
jamielennox | ayoung: i was hoping that requests-kerberos had bumped their minimum required version to something that was greater than that and so we could just rely on a newer version of requests-kerberos | 02:18 |
ayoung | yeah | 02:18 |
jamielennox | but it looks like even in master they're still too old: https://github.com/requests/requests-kerberos/blob/master/requirements.txt | 02:18 |
*** lifeless_ has quit IRC | 02:19 | |
jamielennox | ayoung: so i would remove the py2 qualifiers from https://github.com/openstack/requirements/blob/master/global-requirements.txt#L231 | 02:19 |
jamielennox | and hopefully that will auto-sync to us | 02:19 |
jamielennox | and i would make sure that rhel/fedora is supporting pykerberos >= 1.2.2 | 02:20 |
*** chrisshattuck has joined #openstack-keystone | 02:22 | |
davechen | ayoung: maybe notfication can help here, if the user is in the system then delete the trust. | 02:22 |
ayoung | davechen, I would rather build that workflow into the identity driver directly | 02:23 |
ayoung | does not need to be a notification, as LDAP and Federation are not going to notify you anyway | 02:23 |
ayoung | But if someone calls into the SQL front end, we can certainly delete all role assignments and Trusts | 02:24 |
davechen | ayoung: let me reconsider the case of federation user. | 02:25 |
ayoung | ++ | 02:25 |
*** chrisshattuck has quit IRC | 02:26 | |
*** tqtran has joined #openstack-keystone | 02:31 | |
*** lifeless has joined #openstack-keystone | 02:34 | |
*** tqtran has quit IRC | 02:35 | |
jamielennox | ayoung: did you propose the global requirements change? | 03:02 |
*** chrisshattuck has joined #openstack-keystone | 03:02 | |
*** chrisshattuck has quit IRC | 03:07 | |
*** chrisshattuck has joined #openstack-keystone | 03:10 | |
*** chrisshattuck has quit IRC | 03:18 | |
jamielennox | ayoung: done: https://review.openstack.org/368530 | 03:21 |
ayoung | jamielennox, that was a fast -2 | 03:39 |
jamielennox | ayoung: bah | 03:49 |
ayoung | jamielennox, nah, its all good. I should have hit it prior to the deadline | 03:50 |
jamielennox | ayoung: if you want to fight it for the RHEL process i'll leave that up to you but it doesn't matter for me | 03:50 |
ayoung | nah, I can always get things into the RPMs so long as they are submitted upstream. This is all artifacts of Tripleo eating up so much of my time | 03:50 |
*** chrisshattuck has joined #openstack-keystone | 03:54 | |
*** chrisshattuck has quit IRC | 03:59 | |
*** chrisshattuck has joined #openstack-keystone | 04:51 | |
*** chrisshattuck has quit IRC | 04:55 | |
*** jaosorior has joined #openstack-keystone | 05:02 | |
*** chlong_ has quit IRC | 05:03 | |
*** chlong has quit IRC | 05:03 | |
*** GB21 has quit IRC | 05:04 | |
*** chlong_ has joined #openstack-keystone | 05:17 | |
*** joerch has quit IRC | 05:17 | |
*** GB21 has joined #openstack-keystone | 05:18 | |
*** chlong has joined #openstack-keystone | 05:21 | |
*** admin0 has joined #openstack-keystone | 05:23 | |
*** chlong has quit IRC | 05:25 | |
*** admin0 has quit IRC | 05:26 | |
*** wangqun_ has quit IRC | 05:27 | |
openstackgerrit | chen.xing proposed openstack/keystone: Fix the outdated URL https://review.openstack.org/368552 | 05:29 |
*** tqtran has joined #openstack-keystone | 05:33 | |
*** rcernin has joined #openstack-keystone | 05:33 | |
*** tqtran has quit IRC | 05:37 | |
*** admin0 has joined #openstack-keystone | 05:40 | |
*** richm has quit IRC | 05:40 | |
*** admin0 has quit IRC | 05:44 | |
davechen | stevemar: still around? | 05:45 |
davechen | stevemar: do we have this route defined anywhere? PATCH /v3/projects/{project_id}/cascade | 05:46 |
*** chrisshattuck has joined #openstack-keystone | 05:52 | |
*** chrisshattuck has quit IRC | 05:57 | |
*** chlong_ has quit IRC | 06:05 | |
davechen | hmm, this is a pratial implemented feature and the change in the controller has been abandoned here (https://review.openstack.org/#/c/243585/). | 06:18 |
davechen | never see a route is defined anywhere to support the feature, i think there is no need to doc this api in the api-ref. | 06:19 |
*** joerch has joined #openstack-keystone | 06:32 | |
openstackgerrit | Dave Chen proposed openstack/keystone: Remove the APIs from doc that is not supported yet https://review.openstack.org/368570 | 06:33 |
*** murali_ has joined #openstack-keystone | 06:46 | |
murali_ | Hello | 06:46 |
murali_ | can anyone be of any help | 06:46 |
murali_ | https://ask.openstack.org/en/question/96730/unable-to-setup-devstack/ | 06:46 |
murali_ | Issue is coming in case of keystone part | 06:46 |
*** pcaruana has joined #openstack-keystone | 06:49 | |
openstackgerrit | Dave Chen proposed openstack/keystone: Fix the nit on how to deploy keystone with `mod_proxy_uwsgi` https://review.openstack.org/368579 | 06:52 |
*** chrisshattuck has joined #openstack-keystone | 06:53 | |
openstackgerrit | Ha Van Tu proposed openstack/keystone: Fix prameters name and response codes in Keystone API v2 https://review.openstack.org/365947 | 06:59 |
*** tesseract- has joined #openstack-keystone | 07:00 | |
*** admin0 has joined #openstack-keystone | 07:01 | |
*** chrisshattuck has quit IRC | 07:12 | |
*** adriant has quit IRC | 07:30 | |
*** amoralej|pto is now known as amoralej | 07:34 | |
*** tqtran has joined #openstack-keystone | 07:34 | |
*** jpenag is now known as jpena | 07:37 | |
*** tqtran has quit IRC | 07:38 | |
openstackgerrit | Dave Chen proposed openstack/keystone: Remove the APIs from doc that is not supported yet https://review.openstack.org/368570 | 07:52 |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-keystone | 08:00 | |
*** asettle has joined #openstack-keystone | 08:02 | |
namnh | aloga, Hello. Are you around? | 08:05 |
openstackgerrit | Ha Van Tu proposed openstack/keystone: Fix prameters name and response codes in Keystone API v2-ext https://review.openstack.org/368618 | 08:07 |
*** aabashkin_ is now known as AlexeyAbashkin | 08:20 | |
*** AlexeyAbashkin has quit IRC | 08:22 | |
*** amakarov_away is now known as amakarov | 08:34 | |
zigo | Hey, the Debian package for OpenStack is currently building within OpenStack infra! :) | 08:36 |
zigo | (first service to be building there...) | 08:36 |
zigo | telnet 23.253.109.9 19885 | 08:37 |
zigo | :P | 08:37 |
*** AlexeyAbashkin has joined #openstack-keystone | 08:42 | |
openstackgerrit | Merged openstack/keystone: Tweak api-ref doc for projects https://review.openstack.org/367757 | 08:42 |
*** pnavarro has joined #openstack-keystone | 08:44 | |
*** jaosorior is now known as jaosorior_brb | 08:51 | |
*** openstackgerrit has quit IRC | 09:04 | |
*** openstackgerrit has joined #openstack-keystone | 09:04 | |
*** hoonetorg has joined #openstack-keystone | 09:05 | |
*** zhugaoxiao has quit IRC | 09:16 | |
*** zhugaoxiao has joined #openstack-keystone | 09:17 | |
*** tqtran has joined #openstack-keystone | 09:35 | |
*** tqtran has quit IRC | 09:40 | |
openstackgerrit | Merged openstack/keystone: Fix order of arguments in assertIs https://review.openstack.org/367804 | 10:03 |
*** jaosorior_brb is now known as jaosorior | 10:06 | |
*** richm has joined #openstack-keystone | 10:08 | |
openstackgerrit | Nguyen Hung Phuong proposed openstack/keystonemiddleware: Update code to use Newton as the code name https://review.openstack.org/368707 | 10:09 |
*** markvoelker has joined #openstack-keystone | 10:22 | |
*** markvoelker has quit IRC | 10:26 | |
*** GB21 has quit IRC | 10:40 | |
*** EinstCrazy has quit IRC | 10:42 | |
*** code-R has joined #openstack-keystone | 10:45 | |
*** rodrigods has quit IRC | 10:47 | |
*** code-R_ has joined #openstack-keystone | 10:47 | |
*** rodrigods has joined #openstack-keystone | 10:47 | |
*** davechen has left #openstack-keystone | 10:49 | |
*** code-R has quit IRC | 10:50 | |
*** murali_ has quit IRC | 10:50 | |
*** hoonetorg has quit IRC | 11:03 | |
openstackgerrit | Nguyen Hung Phuong proposed openstack/keystone: TrivialFix: Merge imports in code https://review.openstack.org/368743 | 11:03 |
*** GB21 has joined #openstack-keystone | 11:10 | |
*** daemontool has joined #openstack-keystone | 11:19 | |
*** code-R_ has quit IRC | 11:20 | |
*** nicolasbock has joined #openstack-keystone | 11:21 | |
*** code-R has joined #openstack-keystone | 11:25 | |
*** namnh has quit IRC | 11:27 | |
*** tqtran has joined #openstack-keystone | 11:37 | |
*** tqtran has quit IRC | 11:41 | |
openstackgerrit | Mikhail Nikolaenko proposed openstack/keystone: Add manager and base interface for fernet key store https://review.openstack.org/362283 | 11:49 |
*** code-R_ has joined #openstack-keystone | 11:50 | |
*** code-R has quit IRC | 11:53 | |
*** daemontool has quit IRC | 11:56 | |
*** amoralej is now known as amoralej|lunch | 12:01 | |
*** markvoelker has joined #openstack-keystone | 12:02 | |
*** lamt has quit IRC | 12:03 | |
*** daemontool has joined #openstack-keystone | 12:05 | |
*** jpena is now known as jpena|lunch | 12:07 | |
*** raildo has joined #openstack-keystone | 12:17 | |
*** daemontool has quit IRC | 12:27 | |
*** daemontool has joined #openstack-keystone | 12:28 | |
*** ddieterly has joined #openstack-keystone | 12:49 | |
*** pauloewerton has joined #openstack-keystone | 12:54 | |
*** jaosorior has quit IRC | 12:56 | |
*** jaosorior has joined #openstack-keystone | 12:57 | |
*** ddieterly has quit IRC | 12:59 | |
*** joerch has quit IRC | 13:03 | |
dstanek | good morning | 13:04 |
lbragstad | dstanek o/ | 13:05 |
*** admin0 has left #openstack-keystone | 13:09 | |
*** NishaYadav has joined #openstack-keystone | 13:12 | |
NishaYadav | o/ | 13:13 |
*** lamt has joined #openstack-keystone | 13:16 | |
*** openstackgerrit has quit IRC | 13:19 | |
*** openstackgerrit has joined #openstack-keystone | 13:19 | |
*** jpena|lunch is now known as jpena | 13:22 | |
*** joerch has joined #openstack-keystone | 13:26 | |
*** amoralej|lunch is now known as amoralej | 13:29 | |
*** EinstCrazy has joined #openstack-keystone | 13:31 | |
*** SamYaple_ is now known as SamYaple | 13:32 | |
*** lamt has quit IRC | 13:36 | |
*** tqtran has joined #openstack-keystone | 13:38 | |
*** tqtran has quit IRC | 13:43 | |
*** lamt has joined #openstack-keystone | 13:43 | |
*** ametts has joined #openstack-keystone | 13:54 | |
*** woodster_ has joined #openstack-keystone | 13:56 | |
*** tonytan_brb has joined #openstack-keystone | 13:57 | |
*** tonytan4ever has quit IRC | 14:00 | |
*** BjoernT has joined #openstack-keystone | 14:00 | |
*** ddieterly has joined #openstack-keystone | 14:01 | |
*** nisha_ has joined #openstack-keystone | 14:03 | |
*** NishaYadav has quit IRC | 14:06 | |
lbragstad | dstanek ping - curious to see what your opinion is on https://bugs.launchpad.net/keystone/+bug/1622010 | 14:13 |
openstack | Launchpad bug 1622010 in OpenStack Identity (keystone) "MySQL rounds timestamps" [High,In progress] - Assigned to Lance Bragstad (lbragstad) | 14:13 |
*** sc68cal_ is now known as sc68cal | 14:14 | |
*** BjoernT has quit IRC | 14:26 | |
samueldmq | morning keystone | 14:31 |
dstanek | lbragstad: pong...looking | 14:32 |
stevemar | o/ | 14:32 |
dstanek | lbragstad: actually i found something interesting related to this | 14:32 |
*** michauds has joined #openstack-keystone | 14:33 | |
dstanek | lbragstad: rderose: i think you would both be interested in https://julien.danjou.info/blog/2016/python-sqlalchemy-from-decimal-to-timestamp | 14:34 |
lbragstad | dstanek yeah - I just read that last friday | 14:34 |
lbragstad | great post | 14:35 |
*** itsuugo has quit IRC | 14:37 | |
*** ravelar has joined #openstack-keystone | 14:37 | |
*** mvk has quit IRC | 14:37 | |
*** itsuugo has joined #openstack-keystone | 14:38 | |
*** hoonetorg has joined #openstack-keystone | 14:38 | |
*** chrisshattuck has joined #openstack-keystone | 14:39 | |
dstanek | lbragstad: that is very strange behavior. is it sqla or mysql doing the rounding? and is it possible to have a really simple test case for it? | 14:40 |
lbragstad | dstanek that's a good question - i'm not sure which part is doing the actual rounding | 14:41 |
*** woodburn has joined #openstack-keystone | 14:42 | |
dstanek | lbragstad: i'm wondering if it could be sqla - that may be why my corner case test patch sometime fails | 14:42 |
lbragstad | dstanek right | 14:44 |
*** woodburn1 has quit IRC | 14:44 | |
*** BjoernT has joined #openstack-keystone | 14:44 | |
lbragstad | dstanek i thought it was super strange - because I thought I tested it before on mysql and i was sure that it truncated instead of rounded | 14:44 |
*** tonytan_brb is now known as tonytan4ever | 14:45 | |
lbragstad | dstanek this just furthers my thought that we should control all time in the app | 14:56 |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Docs for quota limits in keystone https://review.openstack.org/366202 | 15:01 |
*** itsuugo has quit IRC | 15:01 | |
*** slberger has joined #openstack-keystone | 15:01 | |
*** nisha_ has quit IRC | 15:01 | |
*** nisha_ has joined #openstack-keystone | 15:02 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone-specs: [wip] Quota limits https://review.openstack.org/363765 | 15:02 |
*** itsuugo has joined #openstack-keystone | 15:03 | |
rderose | dstanek: interesting article | 15:03 |
*** daemontool_ has joined #openstack-keystone | 15:07 | |
*** lamt has quit IRC | 15:07 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Docs for quota limits in keystone https://review.openstack.org/366202 | 15:09 |
*** daemontool has quit IRC | 15:10 | |
*** NishaYadav has joined #openstack-keystone | 15:20 | |
*** NishaYadav is now known as Guest63113 | 15:21 | |
*** flaper87 has quit IRC | 15:21 | |
*** nisha_ has quit IRC | 15:21 | |
*** lamt has joined #openstack-keystone | 15:23 | |
*** EinstCrazy has quit IRC | 15:33 | |
*** tqtran has joined #openstack-keystone | 15:40 | |
*** thebloggu has joined #openstack-keystone | 15:41 | |
*** itsuugo has quit IRC | 15:42 | |
*** thebloggu has quit IRC | 15:43 | |
*** code-R_ has quit IRC | 15:43 | |
*** itsuugo has joined #openstack-keystone | 15:44 | |
*** tqtran has quit IRC | 15:45 | |
*** chrisshattuck has quit IRC | 15:49 | |
*** rcernin has quit IRC | 15:53 | |
stevemar | ayoung: want to associate https://bugs.launchpad.net/keystone/+bug/1381961 with tripleo ? and move it back to fix-released for keystone? | 15:55 |
openstack | Launchpad bug 1381961 in OpenStack Identity (keystone) "Keystone API GET 5000/v3 returns wrong endpoint URL in response body" [Low,Confirmed] - Assigned to Steve Martinelli (stevemar) | 15:55 |
ayoung | stevemar, yep | 15:56 |
stevemar | ayoung: ty | 15:56 |
*** pcaruana has quit IRC | 15:56 | |
*** browne has joined #openstack-keystone | 15:56 | |
ayoung | stevemar, hows that? | 15:57 |
stevemar | ayoung: perfect, takes it off my radar :D | 15:57 |
ayoung | Heh | 15:57 |
ayoung | stevemar, have you been tracking the Bug 968696n fixes? jamielennox was driving on with them, but I've lost track | 15:57 |
openstack | bug 968696 in Glance ""admin"-ness not properly scoped" [High,In progress] https://launchpad.net/bugs/968696 - Assigned to Sharat Sharma (sharat-sharma) | 15:57 |
stevemar | ayoung: unfortunately not, no. :( | 15:58 |
ayoung | I know that we needed something in oslo-config which, I think langed | 15:58 |
ayoung | landed | 15:58 |
stevemar | yeah, that sounds familiar | 15:58 |
ayoung | let's get that on the schedule for tomorrow. Would like to have a comprehensive update | 15:58 |
stevemar | i thought it did, and that's when nova got mad at us for breaking their unit tests | 15:58 |
* stevemar pokes jamielennox with a stick as a heads up -- i'm adding it to the agenda | 16:00 | |
ayoung | stevemar, it was more than just that. It was across multiple projects | 16:00 |
ayoung | jamielennox ought to be asleep | 16:05 |
*** thumpba has joined #openstack-keystone | 16:06 | |
*** daemontool_ has quit IRC | 16:09 | |
*** daemontool has joined #openstack-keystone | 16:10 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Remove the APIs from doc that is not supported yet https://review.openstack.org/368570 | 16:10 |
*** browne has quit IRC | 16:11 | |
*** tonytan_brb has joined #openstack-keystone | 16:14 | |
*** tonytan4ever has quit IRC | 16:16 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: WIP: Switch fernet to be the default token provider. https://review.openstack.org/345688 | 16:16 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Consistently round down timestamps https://review.openstack.org/368244 | 16:16 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/368413 | 16:22 |
*** sdake_ has joined #openstack-keystone | 16:30 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove unused method from keystone.common.utils https://review.openstack.org/368954 | 16:32 |
*** gyee has joined #openstack-keystone | 16:37 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Use issued_at in fernet token provider https://review.openstack.org/368963 | 16:42 |
*** ametts has quit IRC | 16:45 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Fixes password created_at errors due to the server_default https://review.openstack.org/367025 | 16:47 |
*** tesseract- has quit IRC | 16:56 | |
*** jaosorior has quit IRC | 16:59 | |
*** roxanagh_ has joined #openstack-keystone | 16:59 | |
*** chrisshattuck has joined #openstack-keystone | 17:00 | |
*** cher75 has joined #openstack-keystone | 17:01 | |
*** LamT_ has quit IRC | 17:01 | |
*** jpena is now known as jpena|off | 17:06 | |
*** sdake has joined #openstack-keystone | 17:06 | |
cher75 | Can anyone point me to the know failures of unit tests? | 17:08 |
*** sdake_ has quit IRC | 17:09 | |
*** code-R has joined #openstack-keystone | 17:09 | |
*** code-R_ has joined #openstack-keystone | 17:11 | |
openstackgerrit | Merged openstack/keystone: TrivialFix: Merge imports in code https://review.openstack.org/368743 | 17:13 |
*** code-R has quit IRC | 17:15 | |
*** browne has joined #openstack-keystone | 17:15 | |
*** roxanagh_ has quit IRC | 17:15 | |
*** roxanagh_ has joined #openstack-keystone | 17:16 | |
openstackgerrit | Merged openstack/keystone: Fix the nit on how to deploy keystone with `mod_proxy_uwsgi` https://review.openstack.org/368579 | 17:17 |
*** amoralej is now known as amoralej|off | 17:18 | |
*** harlowja has joined #openstack-keystone | 17:19 | |
stevemar | cher75: not sure i understand what you're asking | 17:19 |
stevemar | reminder to add to the meeting agenda: https://etherpad.openstack.org/p/keystone-weekly-meeting | 17:19 |
*** cher75 has quit IRC | 17:23 | |
*** itsuugo has quit IRC | 17:24 | |
*** itsuugo has joined #openstack-keystone | 17:25 | |
*** tqtran has joined #openstack-keystone | 17:27 | |
*** cher75 has joined #openstack-keystone | 17:28 | |
cher75 | @stevemar When I run the keystone unit tests I'm getting the following error | 17:28 |
cher75 | _StringException: pythonlogging:'': {{{Adding cache-proxy 'keystone.tests.unit.test_cache.CacheIsolatingProxy' to backend.}}} Traceback (most recent call last): TypeError: execute_assignment_test_plan() takes exactly 2 arguments (1 given) | 17:29 |
*** tonytan_brb has quit IRC | 17:29 | |
cher75 | So I was looking for a stable test lists | 17:30 |
*** ddieterly is now known as ddieterly[away] | 17:30 | |
*** nicolasbock has quit IRC | 17:32 | |
*** asettle has quit IRC | 17:33 | |
stevemar | cher75: you are running the master branch tests, yes? | 17:35 |
stevemar | cher75: maybe you can nuke your old tox environment and re-run them, i think dogpile may be out of date for you | 17:36 |
stevemar | cher75: rm -rf .tox | 17:36 |
stevemar | cher75: from the keystone proejct directory | 17:36 |
stevemar | cher75: and re-run with tox -e py27 | 17:36 |
cher75 | Ok thanks stevemar will try that... | 17:38 |
*** nicolasbock has joined #openstack-keystone | 17:38 | |
*** pnavarro has quit IRC | 17:42 | |
*** harlowja has quit IRC | 17:43 | |
*** harlowja has joined #openstack-keystone | 17:45 | |
*** roxanagh_ has quit IRC | 17:46 | |
*** Guest63113 is now known as nishaYadav | 17:57 | |
*** joerch has quit IRC | 17:57 | |
*** slberger has quit IRC | 17:59 | |
*** slberger has joined #openstack-keystone | 18:01 | |
harlowja | notmorgan breton (i think who was interested also); u still good with mini-keystone-intro and Q&A and such with k8s folks wed (11am PST i think we said) | 18:02 |
harlowja | kfox1111 ^ | 18:02 |
notmorgan | harlowja: oh hi | 18:03 |
notmorgan | yes i am | 18:03 |
*** chrisshattuck has quit IRC | 18:03 | |
harlowja | cool | 18:03 |
harlowja | i gotta check my schedule (got dentist and eye/lasik doctor post-checkup) on wed | 18:04 |
harlowja | but if i'm not around kfox1111 should be ok to i think | 18:04 |
*** GB21 has quit IRC | 18:10 | |
*** tonytan4ever has joined #openstack-keystone | 18:14 | |
*** roxanagh_ has joined #openstack-keystone | 18:16 | |
*** itsuugo has quit IRC | 18:16 | |
*** itsuugo has joined #openstack-keystone | 18:17 | |
*** woodster_ has quit IRC | 18:19 | |
*** tonytan_brb has joined #openstack-keystone | 18:20 | |
*** tonytan4ever has quit IRC | 18:22 | |
*** itsuugo has quit IRC | 18:23 | |
*** itsuugo has joined #openstack-keystone | 18:25 | |
*** ddieterly[away] is now known as ddieterly | 18:28 | |
openstackgerrit | Merged openstack/keystone: Remove the APIs from doc that is not supported yet https://review.openstack.org/368570 | 18:32 |
openstackgerrit | Merged openstack/keystone: Use ConfigParser instead of SafeConfigParser https://review.openstack.org/368413 | 18:36 |
*** itsuugo has quit IRC | 18:37 | |
*** itsuugo has joined #openstack-keystone | 18:38 | |
openstackgerrit | Merged openstack/keystone: Use issued_at in fernet token provider https://review.openstack.org/368963 | 18:41 |
*** ddieterly is now known as ddieterly[away] | 18:43 | |
*** code-R_ has quit IRC | 18:45 | |
*** gagehugo_ has joined #openstack-keystone | 18:49 | |
*** gagehugo has quit IRC | 18:49 | |
*** gagehugo_ has quit IRC | 18:49 | |
*** gagehugo has joined #openstack-keystone | 18:50 | |
*** woodster_ has joined #openstack-keystone | 18:55 | |
*** itsuugo has quit IRC | 18:56 | |
*** itsuugo has joined #openstack-keystone | 18:57 | |
*** spedione|AWAY is now known as spedione | 19:00 | |
*** pcaruana has joined #openstack-keystone | 19:04 | |
*** itsuugo has quit IRC | 19:04 | |
*** itsuugo has joined #openstack-keystone | 19:06 | |
breton | harlowja: yes | 19:09 |
harlowja | k | 19:09 |
breton | what's that in UTC? 6pm? | 19:10 |
breton | harlowja: | 19:10 |
breton | wow, go Samuel! | 19:14 |
*** asettle has joined #openstack-keystone | 19:14 | |
lbragstad | dstanek was this the failure you were talking about earlier? http://logs.openstack.org/44/368244/2/check/keystone-coverage-db-ubuntu-xenial/b67a327/console.html#_2016-09-12_16_29_22_531239 | 19:23 |
*** spedione is now known as spedione|AWAY | 19:26 | |
*** asettle has quit IRC | 19:26 | |
dstanek | lbragstad: no | 19:26 |
dstanek | lbragstad: http://logs.openstack.org/07/356607/2/check/gate-keystone-python27-db-ubuntu-xenial/a88a9d8/console.html.gz#_2016-08-18_02_25_43_650005 | 19:27 |
dstanek | it was passing locally every time, but failed jenkins every time :-( | 19:27 |
lbragstad | dstanek i'm seeing that same pattern with https://review.openstack.org/#/c/368244/2 | 19:28 |
dstanek | i should probably rebase and get it figured out - was just trying to add a test for what i thought was an interesting corner case | 19:28 |
*** asettle has joined #openstack-keystone | 19:28 | |
*** asettle has joined #openstack-keystone | 19:28 | |
lbragstad | dstanek i'm working pretty close to master | 19:29 |
lbragstad | I can't seem to reproduce that failure locally | 19:29 |
lbragstad | it looks racey - be https://review.openstack.org/#/c/345688/19 is based on https://review.openstack.org/#/c/368244/2 and it passed | 19:30 |
dstanek | lbragstad: sounds like the two are related then. once i finish up the commit i'm looking at now i can take a closer look again | 19:30 |
lbragstad | dstanek cool - i'll keep poking at it | 19:30 |
dstanek | it was driving me nuts a week or two ago when i was looking at it | 19:31 |
lbragstad | I can imagine | 19:31 |
*** asettle has quit IRC | 19:33 | |
*** asettle has joined #openstack-keystone | 19:33 | |
lbragstad | dstanek interesting - you're test failure says that its failing because it's not getting back a 403 | 19:35 |
lbragstad | dstanek my patch is failing because it *is* getting back a 403 instead of a 401. | 19:35 |
*** asettle has quit IRC | 19:38 | |
*** ddieterly[away] is now known as ddieterly | 19:41 | |
*** ddieterly is now known as ddieterly[away] | 19:41 | |
*** ddieterly[away] is now known as ddieterly | 19:41 | |
*** julim_ has joined #openstack-keystone | 19:42 | |
harlowja | breton hmmmm | 19:42 |
harlowja | unsure | 19:42 |
*** joerch has joined #openstack-keystone | 19:44 | |
*** julim_ has quit IRC | 19:45 | |
*** lamt has quit IRC | 19:47 | |
openstackgerrit | Richard Avelar proposed openstack/keystone: POC sql query revoked tokens https://review.openstack.org/359371 | 19:55 |
stevemar | cher75: any update? | 19:56 |
stevemar | breton: :) | 19:57 |
*** ddieterly is now known as ddieterly[away] | 19:57 | |
*** daemontool has quit IRC | 19:59 | |
notmorgan | stevemar: should have code for you today | 20:16 |
notmorgan | niw thst i am home and have laptop with power | 20:16 |
*** fangxu has joined #openstack-keystone | 20:16 | |
*** ddieterly[away] is now known as ddieterly | 20:19 | |
*** sdake_ has joined #openstack-keystone | 20:25 | |
*** thumpba has quit IRC | 20:27 | |
*** sdake has quit IRC | 20:28 | |
*** d0ugal has quit IRC | 20:28 | |
*** thumpba has joined #openstack-keystone | 20:29 | |
*** nishaYadav has quit IRC | 20:37 | |
*** sigmavirus is now known as sigmavirus|awa | 20:38 | |
stevemar | notmorgan: oh? what will this code do? | 20:39 |
notmorgan | stevemar: things i promised to write code for a week or so ago | 20:40 |
stevemar | notmorgan: i completely forgot what that was about | 20:41 |
stevemar | i know we spoke about it... | 20:41 |
*** ddieterly is now known as ddieterly[away] | 20:41 | |
notmorgan | stevemar: revocation events i think is the bulk of it | 20:41 |
stevemar | ahhh okay | 20:41 |
*** d0ugal has joined #openstack-keystone | 20:44 | |
*** pcaruana has quit IRC | 20:46 | |
*** fangxu has quit IRC | 20:47 | |
lbragstad | dstanek i think we have another rounding issue | 20:48 |
lbragstad | dstanek actually - it could be something with our time_fixture, too | 20:50 |
*** fangxu has joined #openstack-keystone | 20:51 | |
*** chrisshattuck has joined #openstack-keystone | 20:51 | |
*** itsuugo has quit IRC | 20:52 | |
*** itsuugo has joined #openstack-keystone | 20:53 | |
*** roxanagh_ has quit IRC | 20:53 | |
*** roxanagh_ has joined #openstack-keystone | 20:53 | |
*** roxanagh_ has quit IRC | 20:54 | |
stevemar | lbragstad & dstanek thanks again for being awesome, you guys made this release great, with the null key fix and the cache fix | 20:54 |
lbragstad | stevemar anytime ;) | 20:54 |
lbragstad | happy to help | 20:55 |
*** itsuugo has quit IRC | 20:57 | |
*** itsuugo has joined #openstack-keystone | 21:00 | |
*** nicolasbock has quit IRC | 21:03 | |
*** ddieterly[away] is now known as ddieterly | 21:04 | |
*** raildo has quit IRC | 21:04 | |
lbragstad | dstanek now it passed... https://review.openstack.org/#/c/368244/2 | 21:05 |
lbragstad | it looks to be a race condition for sure | 21:05 |
*** mvk has joined #openstack-keystone | 21:07 | |
*** pauloewerton has quit IRC | 21:09 | |
*** BjoernT has quit IRC | 21:21 | |
*** itsuugo has quit IRC | 21:27 | |
*** itsuugo has joined #openstack-keystone | 21:28 | |
*** itsuugo has quit IRC | 21:35 | |
*** roxanagh_ has joined #openstack-keystone | 21:35 | |
*** itsuugo has joined #openstack-keystone | 21:38 | |
*** sdake_ has quit IRC | 21:38 | |
*** sdake has joined #openstack-keystone | 21:39 | |
*** esp has joined #openstack-keystone | 21:39 | |
*** ddieterly is now known as ddieterly[away] | 21:42 | |
*** chrisshattuck has quit IRC | 21:45 | |
*** chrisshattuck has joined #openstack-keystone | 21:47 | |
*** sdake_ has joined #openstack-keystone | 21:47 | |
*** sdake has quit IRC | 21:49 | |
*** thumpba has quit IRC | 21:49 | |
*** sdake has joined #openstack-keystone | 21:50 | |
*** sdake_ has quit IRC | 21:52 | |
*** ddieterly[away] is now known as ddieterly | 21:53 | |
*** itsuugo has quit IRC | 21:53 | |
*** ddieterly is now known as ddieterly[away] | 21:54 | |
*** itsuugo has joined #openstack-keystone | 21:55 | |
lbragstad | dstanek i figured out what's causing your patch to fail - https://review.openstack.org/#/c/356607/2/keystone/tests/unit/test_auth.py | 21:56 |
*** ddieterly[away] is now known as ddieterly | 21:59 | |
dstanek | lbragstad: really? | 21:59 |
lbragstad | dstanek yeah - left a comment | 21:59 |
lbragstad | not sure why that token is considered not valid according to sql, though | 21:59 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Fixes password created_at errors due to the server_default https://review.openstack.org/367025 | 22:04 |
*** slberger has left #openstack-keystone | 22:05 | |
*** zigo has quit IRC | 22:08 | |
*** michauds has quit IRC | 22:10 | |
*** zigo has joined #openstack-keystone | 22:11 | |
*** zigo is now known as Guest41388 | 22:11 | |
*** Guest41388 is now known as zigo_ | 22:17 | |
*** adriant has joined #openstack-keystone | 22:17 | |
lbragstad | dstanek hah - actually | 22:18 |
lbragstad | dstanek you know whats up? | 22:18 |
lbragstad | it's because we're disabling a user - which kicks off a callback to invalidate all tokens persisted in the backend | 22:19 |
lbragstad | so - that test only really makes sense for fernet | 22:19 |
lbragstad | because when a user is disabled we do this - https://github.com/openstack/keystone/blob/e10305da58cc5160c75f259a10eb6fff92e0d1de/keystone/token/provider.py#L161 | 22:19 |
*** thumpba has joined #openstack-keystone | 22:20 | |
lbragstad | which goes through the database and sets .valid = False for that user's tokens | 22:20 |
lbragstad | that makes total sense | 22:20 |
lbragstad | so - even if you could generate a uuid token in the future, it would probably still be hit by that case | 22:20 |
*** thumpba has quit IRC | 22:24 | |
*** chrisshattuck has quit IRC | 22:35 | |
lbragstad | dstanek `curl http://cdn.pasteraw.com/d7k6ykdpvgklolzjprplp4d56dzx1lj | git apply; tox -e py27` should fix it for you | 22:37 |
*** chrisshattuck has joined #openstack-keystone | 22:37 | |
*** ravelar has quit IRC | 22:41 | |
*** ddieterly is now known as ddieterly[away] | 22:43 | |
*** sdake has quit IRC | 22:48 | |
*** openstackgerrit has quit IRC | 22:48 | |
*** openstackgerrit has joined #openstack-keystone | 22:48 | |
*** browne has quit IRC | 22:56 | |
*** chrisshattuck has quit IRC | 23:01 | |
*** itsuugo has quit IRC | 23:04 | |
*** itsuugo has joined #openstack-keystone | 23:06 | |
*** ddieterly[away] is now known as ddieterly | 23:10 | |
*** ddieterly is now known as ddieterly[away] | 23:18 | |
*** gagehugo has quit IRC | 23:31 | |
*** itsuugo has quit IRC | 23:34 | |
*** itsuugo has joined #openstack-keystone | 23:36 | |
*** itsuugo has quit IRC | 23:41 | |
*** itsuugo has joined #openstack-keystone | 23:42 | |
*** roxanagh_ has quit IRC | 23:45 | |
*** roxanagh_ has joined #openstack-keystone | 23:45 | |
*** itsuugo has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!