*** dan_nguyen has quit IRC | 00:04 | |
*** chlong has quit IRC | 00:05 | |
*** agireud has joined #openstack-keystone | 00:11 | |
*** edtubill has quit IRC | 00:12 | |
*** david-lyle has joined #openstack-keystone | 00:14 | |
breton | shaleh: patch is welcome :) | 00:19 |
---|---|---|
shaleh | breton: I need to understand the why and future. Once I do, I will gladly submit. | 00:20 |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Use request object in policy enforcement https://review.openstack.org/338693 | 00:20 |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Add the oslo_context to the environment and request https://review.openstack.org/338885 | 00:20 |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Add is_admin property to request https://review.openstack.org/338674 | 00:20 |
shaleh | breton: it looks like another case of we want to use oslo.x but the existing Y works better. | 00:21 |
*** agireud has quit IRC | 00:22 | |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Use request object in policy enforcement https://review.openstack.org/338693 | 00:28 |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Use the context's is_admin property https://review.openstack.org/338674 | 00:28 |
*** agireud has joined #openstack-keystone | 00:29 | |
jamielennox | are roles supposed to be case insensitive? | 00:30 |
jamielennox | https://bugs.launchpad.net/glance/+bug/1010519 | 00:31 |
openstack | Launchpad bug 1010519 in Glance "role case sensitivity" [High,Fix released] - Assigned to Alexej Ababilov (aababilov) | 00:31 |
jamielennox | glance insensitive: https://github.com/openstack/glance/blob/master/glance/api/middleware/context.py#L108 | 00:36 |
*** agireud has quit IRC | 00:36 | |
jamielennox | nova sensitive: https://github.com/openstack/nova/blob/master/nova/api/auth.py#L138 | 00:37 |
jamielennox | neutron sensitive: https://github.com/openstack/neutron/blob/master/neutron/auth.py#L42 | 00:39 |
*** agireud has joined #openstack-keystone | 00:40 | |
jamielennox | cinder insensitive - going to assume glance just gets it wrong | 00:41 |
*** david-lyle has quit IRC | 00:46 | |
*** itisha has quit IRC | 00:50 | |
*** gagehugo has joined #openstack-keystone | 00:55 | |
*** iurygregory_ has joined #openstack-keystone | 00:59 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Faster id mapping lookup https://review.openstack.org/339294 | 01:03 |
*** tonytan4ever has joined #openstack-keystone | 01:06 | |
breton | lbragstad: we talked some time ago about performance of fetching users from LDAP. ^ trying to fix it. | 01:07 |
*** david-lyle has joined #openstack-keystone | 01:13 | |
*** code-R has joined #openstack-keystone | 01:17 | |
*** ozialien10 has joined #openstack-keystone | 01:18 | |
*** david-lyle has quit IRC | 01:18 | |
*** dhellmann has quit IRC | 01:19 | |
*** code-R_ has joined #openstack-keystone | 01:19 | |
*** code-R has quit IRC | 01:22 | |
*** zqfan has joined #openstack-keystone | 01:22 | |
*** dhellmann has joined #openstack-keystone | 01:26 | |
*** chlong has joined #openstack-keystone | 01:27 | |
*** bjornar_ has quit IRC | 01:27 | |
*** dhellmann has quit IRC | 01:31 | |
*** dhellmann has joined #openstack-keystone | 01:31 | |
*** ddieterly has joined #openstack-keystone | 01:31 | |
*** zzzeek has quit IRC | 01:34 | |
*** rderose has quit IRC | 01:35 | |
*** dhellmann has quit IRC | 01:39 | |
*** dhellmann has joined #openstack-keystone | 01:39 | |
openstackgerrit | Merged openstack/keystone: Pass request to build_driver_hints https://review.openstack.org/336980 | 01:41 |
*** dhellmann has quit IRC | 01:45 | |
*** dhellmann has joined #openstack-keystone | 01:46 | |
*** aastha has quit IRC | 01:49 | |
*** dhellmann has quit IRC | 01:51 | |
*** dhellmann has joined #openstack-keystone | 01:52 | |
*** BjoernT has joined #openstack-keystone | 01:53 | |
*** dhellmann has quit IRC | 01:59 | |
*** dhellmann has joined #openstack-keystone | 02:00 | |
*** TxGVNN has joined #openstack-keystone | 02:02 | |
*** davechen has joined #openstack-keystone | 02:02 | |
*** roxanaghe has joined #openstack-keystone | 02:02 | |
*** davechen has quit IRC | 02:03 | |
*** dan_nguyen has joined #openstack-keystone | 02:03 | |
*** BjoernT has quit IRC | 02:03 | |
*** simondodsley has joined #openstack-keystone | 02:03 | |
openstackgerrit | Shan Guo proposed openstack/keystone: keystone recommend deprecated memcache backend https://review.openstack.org/339310 | 02:04 |
*** davechen has joined #openstack-keystone | 02:05 | |
*** tqtran has quit IRC | 02:06 | |
*** roxanaghe has quit IRC | 02:07 | |
*** chlong has quit IRC | 02:08 | |
*** wangqun has joined #openstack-keystone | 02:09 | |
*** TxGVNN has quit IRC | 02:13 | |
*** TxGVNN has joined #openstack-keystone | 02:14 | |
*** code-R_ has quit IRC | 02:14 | |
*** code-R has joined #openstack-keystone | 02:14 | |
*** code-R_ has joined #openstack-keystone | 02:20 | |
*** code-R has quit IRC | 02:22 | |
*** dan_nguyen has left #openstack-keystone | 02:29 | |
*** zzzeek has joined #openstack-keystone | 02:30 | |
*** zzzeek has quit IRC | 02:31 | |
*** zzzeek has joined #openstack-keystone | 02:32 | |
*** sheel has joined #openstack-keystone | 02:34 | |
*** gagehugo has quit IRC | 02:37 | |
*** ametts has joined #openstack-keystone | 02:40 | |
*** browne has quit IRC | 02:58 | |
*** ddieterly has quit IRC | 03:02 | |
openstackgerrit | Shan Guo proposed openstack/keystone: keystone recommend deprecated memcache backend https://review.openstack.org/339310 | 03:06 |
*** sdake has joined #openstack-keystone | 03:08 | |
*** gyee has quit IRC | 03:09 | |
*** sdake_ has joined #openstack-keystone | 03:10 | |
*** sdake has quit IRC | 03:14 | |
*** sdake_ has quit IRC | 03:15 | |
*** sdake has joined #openstack-keystone | 03:17 | |
stevemar | breton: looks interesting | 03:19 |
*** rderose has joined #openstack-keystone | 03:20 | |
*** iurygregory_ has quit IRC | 03:27 | |
*** chrisshattuck has joined #openstack-keystone | 03:36 | |
*** richm has quit IRC | 03:43 | |
*** GB21 has joined #openstack-keystone | 03:44 | |
*** code-R_ has quit IRC | 03:55 | |
*** code-R has joined #openstack-keystone | 03:56 | |
*** rderose has quit IRC | 03:57 | |
*** woodster_ has quit IRC | 03:59 | |
*** simondodsley has quit IRC | 04:13 | |
*** chlong has joined #openstack-keystone | 04:20 | |
*** links has joined #openstack-keystone | 04:24 | |
*** ametts has quit IRC | 04:26 | |
*** ametts has joined #openstack-keystone | 04:26 | |
*** sdake has quit IRC | 04:27 | |
*** sdake has joined #openstack-keystone | 04:27 | |
*** davechen has left #openstack-keystone | 04:37 | |
*** sheel has quit IRC | 04:46 | |
*** ametts has quit IRC | 05:01 | |
*** GB21 has quit IRC | 05:19 | |
*** chrisshattuck has quit IRC | 05:23 | |
*** ametts has joined #openstack-keystone | 05:37 | |
*** sdake_ has joined #openstack-keystone | 05:39 | |
*** sdake has quit IRC | 05:42 | |
*** aufi has joined #openstack-keystone | 05:43 | |
*** GB21 has joined #openstack-keystone | 05:58 | |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Require auth_context middleware in the pipeline https://review.openstack.org/339356 | 05:59 |
*** rcernin has joined #openstack-keystone | 06:09 | |
*** danpawlik has joined #openstack-keystone | 06:15 | |
*** jojden has joined #openstack-keystone | 06:16 | |
*** roxanaghe has joined #openstack-keystone | 06:18 | |
*** roxanaghe has quit IRC | 06:23 | |
jojden | hi | 06:27 |
jojden | anybody have idea about how can we use policy.json in the project | 06:27 |
jojden | I am creating new REST API using pecan framework. So I nneed to use policy.json of keystone | 06:27 |
jojden | how to do that | 06:27 |
*** code-R has quit IRC | 06:39 | |
*** chlong has quit IRC | 06:42 | |
*** GB21 has quit IRC | 06:43 | |
*** code-R has joined #openstack-keystone | 06:47 | |
*** pcaruana has joined #openstack-keystone | 06:51 | |
*** GB21 has joined #openstack-keystone | 06:55 | |
*** tesseract- has joined #openstack-keystone | 06:59 | |
*** tonytan4ever has quit IRC | 07:06 | |
*** tonytan4ever has joined #openstack-keystone | 07:26 | |
*** GB21 has quit IRC | 07:33 | |
*** amoralej|off is now known as amoralej | 07:40 | |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Handle more auth information via context https://review.openstack.org/339390 | 07:43 |
*** code-R has quit IRC | 07:53 | |
*** code-R has joined #openstack-keystone | 07:54 | |
*** bjornar_ has joined #openstack-keystone | 07:57 | |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Implement Views and convert credentials https://review.openstack.org/335423 | 07:58 |
openstackgerrit | Jamie Lennox proposed openstack/keystone: Implement a whole bunch of views https://review.openstack.org/336357 | 07:58 |
*** code-R has quit IRC | 07:59 | |
*** zzzeek has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-keystone | 08:00 | |
*** rcernin has quit IRC | 08:02 | |
*** sdake_ has quit IRC | 08:07 | |
*** tqtran has joined #openstack-keystone | 08:07 | |
kean | set xtrace what meaning ? | 08:08 |
*** sdake has joined #openstack-keystone | 08:08 | |
*** sdake has quit IRC | 08:08 | |
*** sdake has joined #openstack-keystone | 08:08 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/keystone: [WIP] Testing latest u-c https://review.openstack.org/318435 | 08:10 |
*** tqtran has quit IRC | 08:12 | |
*** GB21 has joined #openstack-keystone | 08:17 | |
*** rcernin has joined #openstack-keystone | 08:22 | |
*** daemontool has joined #openstack-keystone | 08:22 | |
jojden | hi | 08:25 |
jojden | anybody have idea about how can we use policy.json in the project | 08:25 |
jojden | I am creating new REST API using pecan framework. So I nneed to use policy.json of keystone | 08:25 |
jojden | how to do that | 08:25 |
*** pnavarro has joined #openstack-keystone | 08:26 | |
openstackgerrit | Merged openstack/python-keystoneclient: Improve docs for v3 regions https://review.openstack.org/338063 | 08:48 |
*** bjornar_ has quit IRC | 09:01 | |
*** tonytan4ever has quit IRC | 09:07 | |
*** aswadr_ has joined #openstack-keystone | 09:17 | |
*** nisha has joined #openstack-keystone | 09:18 | |
*** nisha is now known as Guest51994 | 09:19 | |
aswadr_ | Hello, what should "idp_id" be set to for federated keystone setup ? Ref: http://docs.openstack.org/developer/keystone/extensions/openidc.html | 09:19 |
aswadr_ | I am trying to set it up with OAuth client in google api client | 09:20 |
*** sdake has quit IRC | 09:30 | |
*** GB21 has quit IRC | 09:44 | |
*** code-R has joined #openstack-keystone | 09:55 | |
*** GB21 has joined #openstack-keystone | 09:56 | |
*** code-R has quit IRC | 10:00 | |
*** aloga has quit IRC | 10:12 | |
*** aloga has joined #openstack-keystone | 10:13 | |
*** rcernin has quit IRC | 10:15 | |
*** nisha_ has joined #openstack-keystone | 10:17 | |
*** Guest51994 has quit IRC | 10:21 | |
*** zqfan has quit IRC | 10:33 | |
*** nikhil has quit IRC | 10:33 | |
*** nikhil has joined #openstack-keystone | 10:34 | |
*** ebalduf has joined #openstack-keystone | 10:44 | |
*** samueldmq has joined #openstack-keystone | 10:52 | |
*** ChanServ sets mode: +v samueldmq | 10:52 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Faster id mapping lookup https://review.openstack.org/339294 | 10:58 |
*** TxGVNN has quit IRC | 10:59 | |
dstanek | jojden: use olso.policy | 11:00 |
jojden | ok | 11:01 |
jojden | can you please explain little more | 11:01 |
jojden | about it | 11:01 |
jojden | dstanek | 11:01 |
jojden | is it possible to give myown policy.json file? | 11:02 |
jojden | or how the oslo.policy takes the policy.json file ? | 11:03 |
jojden | dstanek | 11:03 |
openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Add region functional tests https://review.openstack.org/339158 | 11:04 |
dstanek | jojden: you can start here http://docs.openstack.org/developer/oslo.policy/usage.html | 11:04 |
openstackgerrit | Nisha Yadav proposed openstack/python-keystoneclient: Improve docs for v3 endpoints https://review.openstack.org/339468 | 11:04 |
jojden | thank yoi dstanek | 11:07 |
nisha_ | samueldmq, morning | 11:07 |
nisha_ | samueldmq, ^^ | 11:07 |
*** rcernin has joined #openstack-keystone | 11:08 | |
*** ebalduf has quit IRC | 11:09 | |
dstanek | jojden: does that make more sense now? | 11:14 |
jojden | dstanek yes, Getting it now | 11:15 |
dstanek | jojden: this is where keystone uses it http://git.openstack.org/cgit/openstack/keystone/tree/keystone/policy/backends/rules.py | 11:16 |
jojden | we can create the policy.json file in our machine and we can edit it | 11:16 |
dstanek | jojden: yes | 11:16 |
jojden | in that we need to define lke this | 11:17 |
jojden | enforcer = policy.Enforcer(policy_file=_POLICY_PATH) | 11:17 |
jojden | right dstanek | 11:18 |
*** bjornar_ has joined #openstack-keystone | 11:27 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Faster id mapping lookup https://review.openstack.org/339294 | 11:27 |
*** ddieterly has joined #openstack-keystone | 11:28 | |
*** wangqun has quit IRC | 11:32 | |
samueldmq | morning keystone | 11:34 |
samueldmq | nisha_: hi | 11:34 |
*** samueldmq has quit IRC | 11:39 | |
dstanek | stevemar: hi | 11:44 |
*** nisha__ has joined #openstack-keystone | 11:46 | |
*** nisha_ has quit IRC | 11:49 | |
*** code-R has joined #openstack-keystone | 11:56 | |
*** code-R has quit IRC | 12:01 | |
*** ddieterly has quit IRC | 12:04 | |
*** raildo-afk is now known as raildo | 12:08 | |
*** tqtran has joined #openstack-keystone | 12:09 | |
*** samueldmq has joined #openstack-keystone | 12:09 | |
*** ChanServ sets mode: +v samueldmq | 12:09 | |
*** nisha__ is now known as nisha | 12:12 | |
*** nisha is now known as nisha_ | 12:12 | |
*** tqtran has quit IRC | 12:13 | |
*** GB21 has quit IRC | 12:16 | |
*** nisha__ has joined #openstack-keystone | 12:17 | |
*** nisha_ has quit IRC | 12:20 | |
*** nisha__ is now known as nisha_ | 12:22 | |
*** ddieterly has joined #openstack-keystone | 12:25 | |
*** rodrigods has quit IRC | 12:27 | |
*** rodrigods has joined #openstack-keystone | 12:27 | |
*** ddieterly has quit IRC | 12:29 | |
*** sheel has joined #openstack-keystone | 12:30 | |
*** pauloewerton has joined #openstack-keystone | 12:35 | |
*** ebalduf has joined #openstack-keystone | 12:37 | |
*** TxGVNN has joined #openstack-keystone | 12:42 | |
*** wangqun has joined #openstack-keystone | 12:43 | |
*** jmlowe has quit IRC | 12:47 | |
*** ebalduf has quit IRC | 12:51 | |
*** amoralej is now known as amoralej|lunch | 12:53 | |
*** nisha_ has quit IRC | 12:53 | |
*** henrynash has joined #openstack-keystone | 12:54 | |
*** ChanServ sets mode: +v henrynash | 12:54 | |
*** ddieterly has joined #openstack-keystone | 12:55 | |
*** henrynash has quit IRC | 13:00 | |
*** ddieterly has quit IRC | 13:02 | |
*** BjoernT has joined #openstack-keystone | 13:04 | |
*** lamt has joined #openstack-keystone | 13:12 | |
*** links has quit IRC | 13:15 | |
*** gagehugo has joined #openstack-keystone | 13:16 | |
dstanek | jojden: i didn't catch that last part. have you gotten it to work? | 13:17 |
openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Doc update on enabled external auth and federation https://review.openstack.org/339165 | 13:27 |
samueldmq | stevemar: morning, please have a look ^ | 13:29 |
samueldmq | dstanek: o/ | 13:29 |
*** henrynash has joined #openstack-keystone | 13:30 | |
*** ChanServ sets mode: +v henrynash | 13:30 | |
dstanek | hi samueldmq | 13:30 |
lbragstad | is the gate having some issues? | 13:32 |
raildo | lbragstad, tempest.lib.exceptions.SSHTimeout: Connection to the 172.24.5.11 via SSH timed out. | 13:35 |
samueldmq | dstanek: I wonder about why auth_token was said to be deprecated in Mitaka, re patch 305287 | 13:37 |
patchbot | samueldmq: https://review.openstack.org/#/c/305287/ - keystone - Deprecate the AdminTokenAuthMiddleware | 13:37 |
*** nisha_ has joined #openstack-keystone | 13:37 | |
*** jmlowe has joined #openstack-keystone | 13:38 | |
dstanek | git has been mightly slow for me | 13:38 |
samueldmq | dstanek: the link jamielennox cited on the review also says it's deprecated in mitaka :/ | 13:38 |
dstanek | samueldmq: oooo, maybe we dont' need my review at all | 13:39 |
samueldmq | dstanek: I am wondering whether it was properly deprecated or not | 13:42 |
samueldmq | dstanek: if it was, yes, perhaps your review is not necessary ? | 13:43 |
openstackgerrit | David Stanek proposed openstack/keystone: Test showing creating implied roles by domain admin https://review.openstack.org/339558 | 13:43 |
samueldmq | dstanek: a warning was thrown at https://github.com/openstack/keystone/blob/d9c6b50a3ae514e640fa13a344e59fe3649ee0ef/keystone/middleware/auth.py#L175 | 13:44 |
samueldmq | dstanek: and there was that comment in the pipeline saying it was deprecated too | 13:44 |
*** richm has joined #openstack-keystone | 13:48 | |
samueldmq | dstanek: I see strong recommendations for not using it, e.g https://github.com/openstack/keystone/blob/1b0a5530f9935a0d7d166b4b92fd6a9cfe85e72f/keystone/conf/default.py#L28 | 13:51 |
samueldmq | dstanek: but looks like it wasn't properly deprecated ? | 13:51 |
openstackgerrit | Richard proposed openstack/keystone: Doc update on enabled external auth and federation https://review.openstack.org/339165 | 13:54 |
*** tonytan4ever has joined #openstack-keystone | 13:54 | |
*** richm has quit IRC | 13:55 | |
*** ddieterly has joined #openstack-keystone | 13:55 | |
*** thumpba has joined #openstack-keystone | 13:56 | |
*** danpawlik has left #openstack-keystone | 13:56 | |
*** code-R has joined #openstack-keystone | 13:57 | |
*** code-R has quit IRC | 13:58 | |
*** code-R_ has joined #openstack-keystone | 13:58 | |
*** jmlowe1 has joined #openstack-keystone | 13:59 | |
*** amoralej|lunch is now known as amoralej | 13:59 | |
*** jmlowe has quit IRC | 13:59 | |
lbragstad | dolphm this (https://bitbucket.org/zzzeek/dogpile.cache/issues/65) looks similar to the errors i'm seeing in https://review.openstack.org/#/c/339234/2 | 14:02 |
patchbot | lbragstad: patch 339234 - keystone - Isolate token caching into its own region | 14:02 |
lbragstad | cc notmorgan ^ | 14:02 |
*** sigmavirus_away is now known as sigmavirus | 14:03 | |
*** henrynash has quit IRC | 14:07 | |
*** code-R has joined #openstack-keystone | 14:08 | |
dstanek | jmlowe1: did you happen to file a bug about your issue? | 14:09 |
*** code-R has quit IRC | 14:09 | |
*** code-R__ has joined #openstack-keystone | 14:09 | |
*** code-R_ has quit IRC | 14:10 | |
amrith | bknudson_, would you ping me when you are back ... | 14:12 |
amrith | re: https://bugs.launchpad.net/bugs/1600109 | 14:13 |
openstack | Launchpad bug 1600109 in python-keystoneclient "Unit tests should not perform logging,but some tests still use" [Undecided,Incomplete] - Assigned to Ji.Wei (jiwei) | 14:13 |
*** richm has joined #openstack-keystone | 14:14 | |
stevemar | amrith: what about that bug? | 14:14 |
stevemar | amrith: i had the same questions you have | 14:15 |
amrith | i'll post a small note here about that in a couple | 14:15 |
amrith | just writing it offline | 14:15 |
lbragstad | dolphm notmorgan i wonder if it is because we didn't add the TOKEN_REGION to https://github.com/openstack/keystone/blob/master/keystone/server/backends.py#L32-L43 | 14:16 |
lbragstad | trying that now | 14:16 |
dolphm | lbragstad: grep ftw :P | 14:16 |
dstanek | amrith: stevemar: i don't think that is a valid bug. we need more information | 14:18 |
amrith | dstanek, I think there's a kernel of truth in that bug but yes; at this point it is not valid. | 14:19 |
dstanek | amrith: what is the bug saying? that our unit tests are actually logging or that our code shouldn't be during test runs? | 14:20 |
amrith | so, the problem we have found in trove is this | 14:20 |
amrith | code being unit tested has logging | 14:20 |
amrith | that's natural | 14:20 |
amrith | unfortunately one of the consequences that I found a while ago is that the test framework | 14:20 |
amrith | doesn't instantiate a root logger | 14:20 |
amrith | therefor emessages that are logged just go to the moral equivalent of /dev/null | 14:20 |
amrith | and once I found that I had a test that was patently bogus and it seemed to pass. | 14:21 |
amrith | a little digging found that what was happening was that the routine being tested was generating an error | 14:21 |
amrith | in the form of a message being logged and quietly ignored | 14:21 |
amrith | so, I created this little piece of code http://git.openstack.org/cgit/openstack/trove/tree/trove/tests/root_logger.py | 14:21 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Isolate token caching into its own region https://review.openstack.org/339234 | 14:22 |
amrith | and when that is around, the unit tests generate errors like https://bugs.launchpad.net/trove/+bug/1599794 | 14:22 |
openstack | Launchpad bug 1599794 in OpenStack DBaaS (Trove) "tests failing to mock logging (again)" [Undecided,New] - Assigned to Amrith (amrith) | 14:22 |
dstanek | amrith: that's not an argument for no logging, but one for raising errors properly | 14:22 |
amrith | if it is the intent of some test to execute code that is going to generate a message log, then it should be up to the unit test to mock logging properly | 14:22 |
dstanek | upon success the keystone logs go to /dev/null. upon failure they get printed | 14:22 |
dstanek | amrith: yes that is true too | 14:23 |
lbragstad | dolphm sweet - that seems to have fixed it! | 14:23 |
amrith | So, while I agree that the literal interpretation of the bug here is that you should do no logging, I'm going to be a bit generous in the issue | 14:23 |
amrith | and treat it as maybe a language issue here. | 14:23 |
amrith | maybe the guy has some point and I'm interested in hearing more about it | 14:23 |
amrith | before dismissing the bug off hand. | 14:23 |
amrith | I hate my solution for trove | 14:23 |
amrith | every now and again, this code generates warnings | 14:23 |
amrith | should I just make it fail outright | 14:23 |
amrith | so that it will never clear the gate? | 14:24 |
amrith | no, I'll get howls from the peanut gallery | 14:24 |
amrith | should I just ignore logged messages and send them to /dev/null? | 14:24 |
amrith | I don't think so either | 14:24 |
amrith | that could mean that the tests are meaningless as I found before. | 14:24 |
amrith | so I want to see what the guy has to say, with the understanding that this is a TOEFL. | 14:24 |
dstanek | i've not dismissed it yet, but i'm pretty close. it feels like one of those "i read this in a book and need to apply everywhere" bugs | 14:25 |
amrith | in the strictest interpretation of TOEFL. | 14:25 |
dstanek | i have marked it as incomplete for keystone | 14:25 |
amrith | yes, I marked it as opinion for trove | 14:25 |
dstanek | generally speaking i think logging should be ignored in most tests | 14:25 |
amrith | but you are right, I'm damn close to throwing this out as one of those "I have a hammer, let's see how many nails I can put" | 14:26 |
samueldmq | dstanek: ++ | 14:26 |
stevemar | it was definitely a 'meh' for me | 14:26 |
amrith | see: https://bugs.launchpad.net/trove/+bug/1491093 | 14:27 |
openstack | Launchpad bug 1491093 in OpenStack DBaaS (Trove) "Fix potentially broken test test_backup_incremental_metadata" [Medium,Fix released] - Assigned to Amrith (amrith) | 14:27 |
amrith | I think you ignore error logging in unit tests at your own peril | 14:27 |
dolphm | amrith: ++ | 14:28 |
*** slberger has joined #openstack-keystone | 14:29 | |
amrith | but it is peril, not <BOLD>PERIL</BOLD> | 14:29 |
dolphm | should mark it incomplete for every project i have authz to | 14:29 |
*** woodster_ has joined #openstack-keystone | 14:29 | |
amrith | dolphm, sounds good. I'll join you on Trove. | 14:29 |
amrith | done | 14:30 |
dstanek | amrith: from an architecture perspective proper operation of software should not rely on logging at all. in keystone there are a few tests to verify log messages, but failure to log would not result in bad user experience. just bad debuggin experience | 14:31 |
amrith | dstanek, agreed 100% | 14:31 |
amrith | the issue is that I can write a totally valid test and then someone changes the unit under test in a way that really fails the test but just generates some boneheaded message in a log. the test will be meaningless and I get a false sense of security. | 14:32 |
amrith | the only way to catch that is to make sure that if there are messages being generated, that we treat them properly | 14:33 |
amrith | and if a test is known to generate messages; fine | 14:33 |
amrith | just mock and keep going | 14:33 |
amrith | but having a catch-all mock for all unit tests and ignoring logging strikes me as an unsafe thing. | 14:33 |
*** code-R__ has quit IRC | 14:34 | |
*** code-R has joined #openstack-keystone | 14:34 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Invalidate token cache on domain disablement https://review.openstack.org/339235 | 14:34 |
*** pauloewerton has quit IRC | 14:35 | |
dolphm | dstanek: any idea what database jmlowe1 was using? | 14:35 |
*** slberger has quit IRC | 14:35 | |
dstanek | dolphm: no idea | 14:35 |
dstanek | i was testing on mysql and that's what i'm planning on using do try a full upgrade | 14:36 |
dstanek | ....but so far i've not had luck generating the issue | 14:36 |
dolphm | you asked jmlowe1 "what is different between what you run and upstream" and jmlowe1 responded "rdo bits and ubuntu 15.10 bits" - does that mean jmlowe1 is using rdo? | 14:36 |
*** pauloewerton has joined #openstack-keystone | 14:37 | |
lbragstad | dolphm dstanek I have https://review.openstack.org/#/c/339235/3 passing for me locally | 14:37 |
patchbot | lbragstad: patch 339235 - keystone - Invalidate token cache on domain disablement | 14:37 |
lbragstad | brb - refilling coffee | 14:37 |
dolphm | ayoung: jdennis1: any crazy RDO bugs reporting all passwords lost on upgrade to mitaka? | 14:37 |
ayoung | dolphm, nope | 14:37 |
dolphm | ayoung: what database does RDO use? | 14:38 |
ayoung | dolphm, None. RDO just writes down passwords on scrap pieces of paper | 14:38 |
ayoung | Maria DB | 14:38 |
dolphm | ayoung: "strong gust of wind causes post it notes to become unstuck, unable to authenticate with RDO" | 14:39 |
dstanek | ayoung: scrap pieces of paper sounds about right | 14:39 |
ayoung | dolphm, yeah, I closed that one "Will not fix:" | 14:40 |
dolphm | mariadb only uses innodb, right? | 14:40 |
dstanek | dolphm: the reason i locked onto 091 as the issue is not only because the password records were not created, but the password column was also dropped | 14:40 |
ayoung | dolphm, I can never remember...which one is the good one? | 14:40 |
dolphm | dstanek: i wonder if that upgrade could have been complicated by an earlier migration step? | 14:40 |
dstanek | innodb is the good one | 14:41 |
dolphm | dstanek: lol it's the only option we need to focus on for reproducing, right? | 14:41 |
ayoung | dolphm, ah, yeah...I think that is in the migrations, though, rigjht? In the table defs? | 14:41 |
ayoung | http://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/sql/migrate_repo/versions/067_kilo.py | 14:42 |
dolphm | ayoung: we used to have to explicitly set the default to innodb on every upgrade, yes | 14:42 |
dolphm | on every table create* | 14:42 |
dstanek | poor isam | 14:42 |
ayoung | dolphm, so the split of the password table was part of that shadow users effort, right? | 14:43 |
dstanek | nobody wants to be her friend | 14:43 |
ayoung | dstanek, isam deserves to be poor | 14:43 |
dstanek | ayoung: yes, it was for shadow user | 14:43 |
ayoung | http://git.openstack.org/cgit/openstack/keystone/tree/keystone/common/sql/migrate_repo/versions/091_migrate_data_to_local_user_and_password_tables.py | 14:43 |
ayoung | we should have done the drop columns in a separate migration | 14:44 |
dstanek | so in the link ayoung just posted i think line 55 doesn't happen and yet the columns are dropped | 14:44 |
jmlowe1 | dolphm: didn't notice the question, banging away recreating my password hashes, I have 2 controllers using the rdo bits, 1 using ubuntu 15.04 bits, shut down all 3, updated one to rdo mitaka, ran keystone-manage dbsync | 14:45 |
*** links has joined #openstack-keystone | 14:45 | |
dolphm | jmlowe1: oh hey, just tweeted you | 14:46 |
jmlowe1 | ayoung: I'm guessing my 3 way galera-mysql with very short connection timeouts factored in | 14:47 |
dolphm | jmlowe1: how old is the deployment? (what was the first release you used in the deploy?) | 14:47 |
*** rderose has joined #openstack-keystone | 14:47 | |
jmlowe1 | Liberty circa Dec '15 | 14:47 |
dolphm | jmlowe1: that narrows it down quite a bit. can you confirm the db engine on all your tables? | 14:48 |
*** henrynash has joined #openstack-keystone | 14:49 | |
*** ChanServ sets mode: +v henrynash | 14:49 | |
jmlowe1 | http://paste.openstack.org/show/528602/ | 14:49 |
dolphm | jmlowe1: http://stackoverflow.com/a/4225613/176741 | 14:49 |
dolphm | jmlowe1: and the other user tables? | 14:50 |
*** ravelar159 has joined #openstack-keystone | 14:50 | |
*** thumpba has quit IRC | 14:50 | |
jmlowe1 | http://paste.openstack.org/show/528609/ | 14:51 |
*** thumpba has joined #openstack-keystone | 14:51 | |
*** edtubill has joined #openstack-keystone | 14:53 | |
*** links has quit IRC | 14:54 | |
*** slberger has joined #openstack-keystone | 14:54 | |
ayoung | dstanek, this upgrade scares me. | 14:57 |
ayoung | dstanek, what if we remove the line that drops the columns from this migration | 14:57 |
ayoung | and then clean it up in Newton? | 14:57 |
dstanek | ayoung: in light of what happened that sounds sane | 14:59 |
dstanek | jmlowe1: dolphm: i'm going to create a bug for this so we have a place to track | 15:00 |
openstackgerrit | Boris Bobrov proposed openstack/keystone-specs: LDAP preprocessing https://review.openstack.org/339600 | 15:00 |
*** KevinE has joined #openstack-keystone | 15:03 | |
*** KevinE has quit IRC | 15:03 | |
*** KevinE has joined #openstack-keystone | 15:04 | |
dolphm | stevemar: dstanek: amrith: i fixed the rest of https://bugs.launchpad.net/tempest/+bug/1600109 | 15:04 |
openstack | Launchpad bug 1600109 in OpenStack DBaaS (Trove) "Unit tests should not perform logging,but some tests still use" [Undecided,Incomplete] - Assigned to haobing1 (haobing1) | 15:04 |
*** david-lyle has joined #openstack-keystone | 15:08 | |
*** slberger has quit IRC | 15:09 | |
*** chrisshattuck has joined #openstack-keystone | 15:10 | |
*** sdake has joined #openstack-keystone | 15:10 | |
*** slberger has joined #openstack-keystone | 15:10 | |
*** sdake_ has joined #openstack-keystone | 15:12 | |
*** timcline has joined #openstack-keystone | 15:12 | |
dstanek | dolphm: nice | 15:12 |
*** spzala has joined #openstack-keystone | 15:13 | |
*** spzala has quit IRC | 15:13 | |
dstanek | dolphm: jmlowe1: i created this for tracking https://bugs.launchpad.net/keystone/+bug/1600268 - please update if i've gotten some of the info wrong or to add more | 15:13 |
openstack | Launchpad bug 1600268 in OpenStack Identity (keystone) "Upgrading from Liberty to Mitaka erased passwords from SQL backend" [Undecided,Incomplete] | 15:13 |
dolphm | dstanek: you already tried a liberty -> mitaka upgrade, right? | 15:13 |
*** pcaruana has quit IRC | 15:13 | |
dstanek | dolphm: no, not a full upgrade. that was my plan for today | 15:13 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Invalidate token cache on domain disablement https://review.openstack.org/339235 | 15:14 |
dolphm | dstanek: okay, i'm going to do the same | 15:14 |
*** wangqun has quit IRC | 15:15 | |
dstanek | dolphm: first i need to call mfisch | 15:15 |
*** sdake has quit IRC | 15:15 | |
dolphm | dstanek: lol ++ | 15:15 |
dolphm | i believe he has donethis upgrade without issue | 15:16 |
stevemar | ayoung: we both +1'ed breton at the same time O_O | 15:16 |
ayoung | stevemar, race condition | 15:16 |
stevemar | hehe | 15:17 |
ayoung | I still need a hotel for the midcycle. | 15:17 |
*** sdake_ has quit IRC | 15:17 | |
ayoung | They changes our travel portal and now I can't log in | 15:17 |
*** sdake has joined #openstack-keystone | 15:18 | |
ayoung | maybe I should just get a rental car and then crash with friends...might be cheaper | 15:20 |
dolphm | jmlowe1: did you run the destructive db_sync from an RDO node or a ubuntu node? | 15:20 |
*** code-R has quit IRC | 15:25 | |
dolphm | jmlowe1: i'd also be curious to know what your sql connection string looks like (extra paramaters, if any?) | 15:25 |
openstackgerrit | Merged openstack/keystone: Refactor: [ldap] suffix should not be an instance attribute https://review.openstack.org/336715 | 15:25 |
*** diazjf has joined #openstack-keystone | 15:26 | |
*** tesseract- has quit IRC | 15:27 | |
*** sdake_ has joined #openstack-keystone | 15:27 | |
openstackgerrit | Merged openstack/keystone: Remove last parts of query_string from context https://review.openstack.org/337014 | 15:29 |
*** sdake has quit IRC | 15:32 | |
dolphm | dstanek: migration 91 was already in place in liberty | 15:32 |
*** sdake_ has quit IRC | 15:35 | |
openstackgerrit | Boris Bobrov proposed openstack/keystone-specs: LDAP preprocessing https://review.openstack.org/339600 | 15:36 |
*** nisha_ has quit IRC | 15:36 | |
dolphm | dstanek: oh, i'm looking at the pyc. | 15:36 |
*** nisha_ has joined #openstack-keystone | 15:37 | |
*** aastha has joined #openstack-keystone | 15:38 | |
ayoung | Does San Jose have Bike Share? | 15:41 |
*** sdake has joined #openstack-keystone | 15:45 | |
jmlowe1 | dolphm: that was on an RDO node, liberty RDO and liberty ubuntu nodes were stopped | 15:45 |
*** pnavarro has quit IRC | 15:45 | |
*** sheel has quit IRC | 15:46 | |
dstanek | dolphm: back :-) | 15:48 |
dolphm | jmlowe1: cool, thanks for all these etails | 15:49 |
dolphm | details* | 15:49 |
dolphm | dstanek: what did mfisch say? | 15:49 |
dstanek | dolphm: i got some more data from him and confirmed that it probably is a bug | 15:50 |
dolphm | dstanek: has he seen a similar behavior? | 15:50 |
*** browne has joined #openstack-keystone | 15:51 | |
jmlowe1 | I added a few more details to the bug, versions and whatnot. | 15:51 |
dstanek | dolphm: oh, no. i was working with him on a different bug | 15:52 |
dolphm | jmlowe1: thanks! | 15:52 |
jmlowe1 | and the migration logs too | 15:54 |
openstackgerrit | Brad Topol proposed openstack/keystone: Mark the domain config via API as stable https://review.openstack.org/339259 | 16:02 |
dstanek | jmlowe1: thanks for adding all of that detail to the bug | 16:03 |
*** ametts has quit IRC | 16:05 | |
mgagne | anyone ever encounter an issue where after assigning a role to a user, user-role-list doesn't show it right away? We use Apache WSGI and memcached. We found that if you have 2 Apache processes, you need list list twice to get the actual list of roles. | 16:07 |
mgagne | with 3 processes, you need to list 3 times before having the role. | 16:07 |
mgagne | with 1 process, role is showing right away | 16:07 |
mgagne | so we suspect some form of in-process cache which I can't find | 16:08 |
dstanek | mgagne: 3 process or 3 nodes? | 16:08 |
mgagne | processes | 16:08 |
*** KevinE has quit IRC | 16:08 | |
mgagne | we only have 1 node in our dev environment | 16:08 |
*** KevinE has joined #openstack-keystone | 16:09 | |
mgagne | in prod, prob is worst, you need to issue a LOT of requests to "bust" the in-process cache (we have a lot of nodes and processes) | 16:09 |
dstanek | i've not heard of that, but it sounds more like you are using an in-memory cache. can you paste your sanitized keystone.conf? | 16:09 |
*** roxanaghe has joined #openstack-keystone | 16:10 | |
mgagne | dstanek: http://paste.openstack.org/show/528619/ | 16:11 |
mgagne | this is for dev, not prod | 16:11 |
dolphm | dstanek: jmlowe1: alright, i've got a script to attempt to reproduce using vanilla keystone, mysql+pymysql, and it migrated without issue. going to start playing with it | 16:14 |
dstanek | mgagne: hmm...that all looks correct. | 16:15 |
mgagne | yea, we have been scratching our heads for some times now | 16:16 |
mgagne | we are running kilo with a backported patch if it matters | 16:16 |
dstanek | mgagne: i'm in the middle of looking at two bugs now, but if you make a new bug for this i'd appreciate it. then i can tackle that next. | 16:16 |
mgagne | I'm sure my bug will be rejected as it is against kilo ;) | 16:16 |
dstanek | errr....three bugs if you include the one dolphm is also working on | 16:16 |
dstanek | mgagne: ah. have you tried it against something more recent? | 16:17 |
*** GB21 has joined #openstack-keystone | 16:17 | |
mgagne | dstanek: we are not geared to run latest code, that's why we are "stuck" with kilo ;) | 16:17 |
stevemar | dstanek: ugh, the passwords were nuked, brutal | 16:17 |
*** rcernin has quit IRC | 16:18 | |
nisha_ | hi stevemar | 16:18 |
mgagne | dstanek: interesting, I restarted memcached and problem isn't showing anymore.... | 16:18 |
dstanek | mgagne: when in doubt use the Windows(tm) way out! reboot, restart or just cross you fingers | 16:19 |
mgagne | I tested multiple times, not like I restarted between calls | 16:19 |
mgagne | now it's showing again, sorcery | 16:20 |
*** pcaruana has joined #openstack-keystone | 16:21 | |
*** TxGVNN has quit IRC | 16:21 | |
*** code-R has joined #openstack-keystone | 16:22 | |
lbragstad | dstanek what are your thoughts on making request validation an inline call in the method versus a decorator? | 16:24 |
nisha_ | henrynash, henrynash_ hi, you around? | 16:24 |
nisha_ | I am writing functional tests for endpoints. But I am getting an error can anyone help please> | 16:25 |
*** code-R_ has joined #openstack-keystone | 16:26 | |
nisha_ | here is the code and error, http://paste.openstack.org/show/528622/ | 16:27 |
dstanek | lbragstad: generally speaking i hate python decorators. validation is one case where i don't feel as strongly about it, but i wouldn't be sad to see them go away | 16:28 |
nisha_ | samueldmq, if you around please have a look ^ | 16:28 |
lbragstad | dstanek removing them might make it easier to get validation things from config before validation (without having to worry about races with configuration registration) | 16:29 |
*** code-R has quit IRC | 16:29 | |
dstanek | lbragstad: you can't do it in another decorator? | 16:29 |
lbragstad | dstanek i could - for that we would just be doing something like @validation.id_string_validated(schema.user_create, 'user') instead of @validation.validated(schema.user_create, 'user') | 16:31 |
*** pcaruana has quit IRC | 16:31 | |
lbragstad | right? | 16:31 |
*** ddieterly is now known as ddieterly[away] | 16:31 | |
dstanek | i think you need a more generic mechanism. | 16:32 |
dstanek | for instance, a @lazy_validated('schema_name', 'user') | 16:32 |
stevemar | nisha_: hey | 16:32 |
lbragstad | dstanek ah - so would we want to use that for all our validations? | 16:32 |
stevemar | jeez our docs are all over the place | 16:33 |
lbragstad | dstanek instead of having two different validation decorators? | 16:33 |
stevemar | especially the "configuration" section | 16:33 |
dstanek | and 'schema_name' is looked up when the first request to validate is called | 16:33 |
nisha_ | stevemar, if you get some time can you have a look at this please, http://paste.openstack.org/show/528622/ | 16:33 |
stevemar | nisha_: sure, what am i looking at? | 16:34 |
dstanek | lbragstad: you could and just make the initial one lazy. i'll have to think about that for a bit | 16:34 |
dstanek | i really hate our propensity to do all the things at import time | 16:34 |
nisha_ | stevemar, yeah, its the functional test for endpoints | 16:35 |
nisha_ | stevemar, just create and check | 16:35 |
lbragstad | dstanek hm - yeah... | 16:35 |
stevemar | nisha_: ah, i remember seeing it fail in jenkins | 16:35 |
lbragstad | dstanek I'd rather have one way to do something that is generic than two specific ways to do the same thing | 16:35 |
*** phalmos has joined #openstack-keystone | 16:35 | |
lbragstad | which is why I started thinking about just moving the validation inline with the method - that would take care of the lazy-ness part (I think) | 16:36 |
nisha_ | stevemar, I haven't pushed it yet. I think you are talking about the docs for endpoints | 16:36 |
stevemar | nisha_: i was thinking about this one: https://review.openstack.org/#/c/339158/3 | 16:37 |
patchbot | stevemar: patch 339158 - python-keystoneclient - Add region functional tests | 16:37 |
stevemar | nisha_: but yeah, i get ya, that is unrelated | 16:37 |
nisha_ | stevemar, ohh, yeah, lot of test failing due to the hierarchy. yeah, :) | 16:38 |
dolphm | jmlowe1: what version of RDO were you upgrading from? | 16:40 |
dolphm | dstanek: i'm testing migrations copied straight from RDO packaging - in case it's a packaging issue (there's pyc's and pyo's in the package) | 16:41 |
*** shaleh_ has joined #openstack-keystone | 16:42 | |
stevemar | nisha_: does it report that same error for random properties, like endpoint.foo ? | 16:42 |
stevemar | nisha_: i think we renamed service to service_id | 16:42 |
*** diazjf has quit IRC | 16:42 | |
nisha_ | stevemar, oh, yeah that might be the casue | 16:43 |
nisha_ | stevemar, thanks I will check for service_id | 16:43 |
samueldmq | stevemar: nice debugging skills | 16:44 |
samueldmq | :-) | 16:44 |
*** diazjf has joined #openstack-keystone | 16:45 | |
*** daemontool has quit IRC | 16:45 | |
nisha_ | stevemar, samueldmq when I use this, endpoint_ref['service_id'] alongwith endpoint.service_id, I get KeyError for the former | 16:51 |
nisha_ | stevemar, samueldmq when I just use, endpoint.service_id I got mismatch error | 16:52 |
samueldmq | nisha_: perhaps endpoint_ref doesn't contain a 'service_id' attribute ? | 16:52 |
nisha_ | reference = <keystoneclient.tests.functional.v3.client_fixtures.Service object at 0x7fb9d89dcd10> | 16:52 |
nisha_ | actual = u'5cf3bf09764144e387dc822d103ef4fb' | 16:52 |
nisha_ | for mismatch ^ | 16:52 |
samueldmq | nisha_: fix the fixtures to contain the 'service_id' attribute instead of 'service' | 16:52 |
*** ddieterly[away] is now known as ddieterly | 16:53 | |
nisha_ | samueldmq, okay thanks | 16:53 |
samueldmq | nisha_: then self.assertEqual(endpoint_ref['service_id'], endpoint.service_id) should work ? | 16:53 |
samueldmq | nisha_: np | 16:53 |
nisha_ | samueldmq, yeah I think | 16:53 |
nisha_ | samueldmq, also, it was mentioned in the doc that we are no longer using service instead service_id. So, Can I edit the function calling too, or is it not adviced as of now? | 16:54 |
samueldmq | nisha_: what function is that ? | 16:55 |
nisha_ | samueldmq, Also, it's written interface is optional attribute, gets None by default, still while creating an endpoint I had to provide it | 16:55 |
nisha_ | function in the keystoneclient/v3/endpoints.py the create function parameters | 16:56 |
nisha_ | its definition | 16:56 |
samueldmq | nisha_: looking | 16:56 |
nisha_ | thanks | 16:56 |
samueldmq | nisha_: hmm I see what you're saying | 16:57 |
samueldmq | nisha_: it accepts 'service' as argument for creating an endpoint | 16:58 |
samueldmq | nisha_: but the endpoint entity contains service_id | 16:58 |
samueldmq | nisha_: you might simply leave things as they are (endpoint fixture with 'service') | 16:59 |
samueldmq | nisha_: and just modify your assertion to be: | 16:59 |
samueldmq | self.assertEqual(endpoint_ref['service'], endpoint.service_id) | 16:59 |
nisha_ | endpoint_ref['service'].id | 16:59 |
nisha_ | samueldmq, above raises mismatch error | 16:59 |
samueldmq | like this: self.assertEqual(endpoint_ref['service'], endpoint.service_id) | 17:00 |
samueldmq | endpoint_ref is a dict | 17:00 |
samueldmq | endpoint is an object | 17:00 |
nisha_ | but that raises mismatch error | 17:01 |
nisha_ | reference = <keystoneclient.tests.functional.v3.client_fixtures.Service object at 0x7fb9d89dcd10> | 17:01 |
nisha_ | <nisha_> actual = u'5cf3bf09764144e387dc822d103ef4fb' | 17:01 |
samueldmq | nisha_: endpoint.service_id returns a service object ? | 17:01 |
nisha_ | I don't think so :/ | 17:02 |
samueldmq | try it again | 17:02 |
samueldmq | and let me see the code for the tests & fixtures | 17:02 |
samueldmq | can I see your fixture code ? | 17:03 |
samueldmq | maybe it's filling in 'service' attribute of the fixture with a service object rather than just an ID | 17:03 |
nisha_ | samueldmq, here is the related code and error, http://paste.openstack.org/show/528627/ | 17:13 |
*** spzala has joined #openstack-keystone | 17:16 | |
*** nisha_ has quit IRC | 17:16 | |
lbragstad | dstanek i'm working on a wip review to move the validation stuff inline with the methods - just so we can see what it looks like | 17:17 |
*** rcernin has joined #openstack-keystone | 17:20 | |
*** rcernin has quit IRC | 17:20 | |
*** browne has quit IRC | 17:20 | |
*** nisha_ has joined #openstack-keystone | 17:23 | |
stevemar | samueldmq: o/ | 17:23 |
*** rcernin has joined #openstack-keystone | 17:24 | |
jmlowe1 | dolphm: I believe the version was openstack-keystone-8.1.2-1.el7 | 17:25 |
dolphm | jmlowe1: perfect, thanks | 17:26 |
samueldmq | stevemar: o/ | 17:27 |
stevemar | samueldmq: pm'ed you! | 17:27 |
*** nisha__ has joined #openstack-keystone | 17:27 | |
*** gyee has joined #openstack-keystone | 17:29 | |
*** ChanServ sets mode: +v gyee | 17:29 | |
*** sdake_ has joined #openstack-keystone | 17:30 | |
*** code-R_ has quit IRC | 17:31 | |
*** code-R has joined #openstack-keystone | 17:31 | |
*** aufi has quit IRC | 17:33 | |
*** sdake has quit IRC | 17:34 | |
*** nisha_ has quit IRC | 17:34 | |
*** nisha__ is now known as nisha_ | 17:34 | |
*** GB21 has quit IRC | 17:38 | |
mgagne | dstanek: running with cache debugging enabled, I found the key is only set/updated after a couple of requests, not right away when assignments are updated. | 17:41 |
*** spzala has quit IRC | 17:41 | |
mgagne | dstanek: restarting apache right after I changed assignment made it so cache is never updated until it expires. So I suspect the update is "queued" in one of the process in Apache. | 17:42 |
stevemar | dolphm: poke | 17:42 |
stevemar | dolphm: do you plan on revisiting the federation spec? | 17:42 |
*** tqtran has joined #openstack-keystone | 17:42 | |
dstanek | mgagne: that is pretty strange behavior. we don't do anything async with memcached that i know of, unless dogpile is doing that for us (cc notmorgan) | 17:43 |
*** tqtran_ has joined #openstack-keystone | 17:43 | |
mgagne | yea I don't think keystone is doing anything of that sort on purpose | 17:44 |
mgagne | I'm trying to search/understand where this behavior happens | 17:44 |
*** tqtran has quit IRC | 17:46 | |
*** ddieterly is now known as ddieterly[away] | 17:49 | |
*** amoralej is now known as amoralej|off | 17:52 | |
*** code-R has quit IRC | 17:56 | |
openstackgerrit | Roxana Gherle proposed openstack/keystone: Fix the username value in federated tokens https://review.openstack.org/335617 | 17:57 |
*** diazjf has quit IRC | 18:00 | |
*** slberger1 has joined #openstack-keystone | 18:02 | |
*** slberger has quit IRC | 18:02 | |
*** chrisshattuck has quit IRC | 18:03 | |
*** rderose has quit IRC | 18:05 | |
*** shaleh has quit IRC | 18:06 | |
*** shaleh_ is now known as shaleh | 18:06 | |
shaleh | samueldmq: when you have a moment, I'd like to discuss the user-agent review | 18:06 |
samueldmq | shaleh: sure, I am here now | 18:07 |
*** kmARC has left #openstack-keystone | 18:07 | |
shaleh | samueldmq: I posted two reviews. The first one tries to use a heuristic to determine the user-agent. Jamie was not keen on it but it went in. Jamie asked that I add the second review to force setting of the user-agent. | 18:08 |
shaleh | samueldmq: that is the history | 18:08 |
*** chrisshattuck has joined #openstack-keystone | 18:09 | |
mgagne | dstanek: found the cause. invalidate in dogpile "does not affect the data in the cache in any way, and is also local to this instance of :class:`.CacheRegion`." | 18:10 |
mgagne | so I will check against master branch of keystone and see if code changed since kilo | 18:11 |
dstanek | mgagne: wow that's terrible | 18:11 |
mgagne | looks to be the same https://github.com/openstack/keystone/blob/master/keystone/assignment/core.py#L216 | 18:11 |
dolphm | jmlowe1: no luck https://bugs.launchpad.net/keystone/+bug/1600268/comments/3 | 18:12 |
openstack | Launchpad bug 1600268 in OpenStack Identity (keystone) "Upgrading from Liberty to Mitaka erased passwords from SQL backend" [Critical,Incomplete] | 18:12 |
dstanek | notmorgan: stevemar: i feel almost like ditching dogpile and just using a native memcached cache implementation | 18:12 |
dolphm | stevemar: do i need to update it today? trying to focus on bugs | 18:12 |
mgagne | I think the issue is that dogpile cannot know all keys in a region and therefore can't delete/invalidate them all. | 18:12 |
stevemar | dolphm: no, i'll allow an FFE for you :P | 18:13 |
dolphm | stevemar: it'd probably be an ocata target if we're going to commit to work on it. either way, i can update the spec | 18:13 |
stevemar | dolphm: oh sadness | 18:13 |
dstanek | mgagne: it should be able to invalidate an entry in the cache. it doesn't make sense that it's only local | 18:13 |
mgagne | so I guess this behavior will only show for people running Keystone in mod_wsgi and not eventlet which could have a shared dogpile instance | 18:13 |
stevemar | dolphm: was looking forward to that one | 18:13 |
dolphm | stevemar: it's a big change though | 18:14 |
stevemar | yeah | 18:14 |
samueldmq | shaleh: what about adding ' in order to make debugging and tracing easier for operators.' to that message ? | 18:14 |
stevemar | i guess early in O is better | 18:14 |
dolphm | stevemar: maybe show up in barcelona with a PoC | 18:14 |
samueldmq | shaleh: 'When creating or using keytoneauth1.Session user_agent must be set in order to make debugging and tracing easier for operators.' | 18:14 |
stevemar | dolphm: we'll be 6 weeks into O at that point | 18:14 |
stevemar | but sure | 18:14 |
dolphm | stevemar: oh true | 18:14 |
samueldmq | shaleh: this way it's (at least) clear why user_agent is requested to be set | 18:14 |
dolphm | stevemar: so, PoC before that | 18:14 |
samueldmq | shaleh: makes sense ? | 18:15 |
stevemar | dolphm: ideally yes, once newton-3 is cut you can start hacking on it | 18:15 |
stevemar | dolphm: alright, then retarget the spec for O once you have a chance | 18:15 |
stevemar | it's become less of a priority now | 18:16 |
shaleh | samueldmq: not sure about adding it to the output message. Although, that was why I had the bikeshed FIXME :-) | 18:17 |
shaleh | samueldmq: Adding it to the comments and function docstring makes sense for sure. | 18:17 |
shaleh | samueldmq: just not sure about the UX of the message itself. | 18:17 |
mgagne | this means the implementation of caching in Keystone is flawed. If you have 10 keystone nodes with 16 processes each, could be a while before you see your now role :-/ | 18:18 |
dstanek | mgagne: yeah, i'm actually looking at other caching bugs right now | 18:18 |
*** ravelar159 has quit IRC | 18:20 | |
stevemar | ayoung: want to +2/+A https://review.openstack.org/#/c/339600/ ? | 18:21 |
patchbot | stevemar: patch 339600 - keystone-specs - LDAP preprocessing | 18:21 |
samueldmq | shaleh: warnings are for operators, so the suggestion makes sense to me | 18:21 |
shaleh | dstanek: I was asking about caching yesterday evening. We currently suggest oslo_cache.memcache_pool and dogpile.cache.memcache (or something close, you get the point). But there is no clarity as to why I would prefer one over the other. | 18:21 |
samueldmq | shaleh: if that was a message to session end-users (raising an exception), I'd agree that'd be bad UX | 18:21 |
openstackgerrit | Boris Bobrov proposed openstack/keystone: Faster id mapping lookup https://review.openstack.org/339294 | 18:21 |
mgagne | I found the other backend to show the same behavior or worst (cache is never invalidated) | 18:21 |
shaleh | samueldmq: hmmm, fair points. I will ponder and update the review. | 18:22 |
*** diazjf has joined #openstack-keystone | 18:22 | |
dstanek | mgagne: it's possible that the bug i'm working on will actually fix this issue too | 18:23 |
mgagne | dstanek: can you share the link if any? | 18:23 |
dstanek | shaleh: caching doesn't need to be this complicated | 18:23 |
*** spzala has joined #openstack-keystone | 18:24 | |
raildo | dstanek, how to make a commit message for a wip patch: https://review.openstack.org/#/c/335906/ :P | 18:25 |
patchbot | raildo: patch 335906 - nova - DO NOT MERGE - ROOAAAAAARRRR ! Testing live migrat... | 18:25 |
dstanek | lol | 18:25 |
*** jaugustine has joined #openstack-keystone | 18:25 | |
shaleh | dstanek: ++++++ | 18:26 |
openstackgerrit | Merged openstack/keystone-specs: LDAP preprocessing https://review.openstack.org/339600 | 18:26 |
*** spzala_ has joined #openstack-keystone | 18:30 | |
*** spzala_ has quit IRC | 18:30 | |
*** spzala_ has joined #openstack-keystone | 18:31 | |
*** spzala_ has quit IRC | 18:31 | |
*** spzala has quit IRC | 18:34 | |
*** ravelar159 has joined #openstack-keystone | 18:34 | |
breton | what | 18:35 |
breton | ldap preprocessing got merged? | 18:35 |
breton | i don't need to ask for exceptions for it at the meeting? | 18:35 |
dstanek | breton: ssshhhh. | 18:37 |
*** pcaruana has joined #openstack-keystone | 18:37 | |
breton | good. | 18:40 |
samueldmq | shaleh: nice, thanks | 18:41 |
breton | stevemar: i will answer the question about 40k users on Monday | 18:41 |
*** spzala has joined #openstack-keystone | 18:47 | |
*** ddieterly[away] has quit IRC | 18:49 | |
*** spzala has quit IRC | 18:51 | |
*** haplo37_ has joined #openstack-keystone | 18:54 | |
*** spzala has joined #openstack-keystone | 18:59 | |
*** nisha_ has quit IRC | 18:59 | |
*** rderose has joined #openstack-keystone | 19:00 | |
*** aswadr_ has quit IRC | 19:01 | |
*** spzala has quit IRC | 19:03 | |
*** ddieterly has joined #openstack-keystone | 19:04 | |
stevemar | breton: it wasn't contentious | 19:08 |
stevemar | breton: it's not a major overhaul of something major like service tokens/users or project naming | 19:08 |
stevemar | to mention a few :) | 19:08 |
*** nkinder has quit IRC | 19:10 | |
*** code-R has joined #openstack-keystone | 19:10 | |
*** spzala has joined #openstack-keystone | 19:11 | |
*** spzala has quit IRC | 19:16 | |
*** spzala has joined #openstack-keystone | 19:19 | |
*** timcline has quit IRC | 19:19 | |
*** timcline has joined #openstack-keystone | 19:20 | |
*** spzala has quit IRC | 19:24 | |
*** timcline has quit IRC | 19:24 | |
*** spzala has joined #openstack-keystone | 19:25 | |
*** spzala has quit IRC | 19:25 | |
*** spzala has joined #openstack-keystone | 19:26 | |
*** code-R_ has joined #openstack-keystone | 19:26 | |
*** code-R has quit IRC | 19:29 | |
*** raildo is now known as raildo-afk | 19:30 | |
*** spzala has quit IRC | 19:45 | |
*** chrisshattuck has quit IRC | 19:46 | |
*** spzala has joined #openstack-keystone | 19:48 | |
*** itisha has joined #openstack-keystone | 19:51 | |
*** sdake_ has quit IRC | 19:51 | |
*** spzala has quit IRC | 19:52 | |
openstackgerrit | Sean Perry proposed openstack/keystoneauth: Show deprecation when a user_agent is not set https://review.openstack.org/289645 | 20:01 |
shaleh | samueldmq: review updated ^^^ | 20:01 |
*** jmlowe1 has quit IRC | 20:05 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Allow id string validation to be configurable https://review.openstack.org/334673 | 20:06 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Move request validation inline https://review.openstack.org/339800 | 20:06 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove validated decorator https://review.openstack.org/339801 | 20:06 |
lbragstad | dstanek ^ | 20:06 |
*** timcline has joined #openstack-keystone | 20:07 | |
*** timcline has quit IRC | 20:11 | |
notmorgan | dstanek: you know, i don't care if we ditch dogpile at this point. | 20:12 |
shaleh | notmorgan: are you still angling for oslo.cache to be the preferred interface? | 20:12 |
notmorgan | i don't really care at this point | 20:13 |
shaleh | notmorgan: oh, we are back to that morgan :-) | 20:13 |
notmorgan | i'm just too tired of debugging/providing reviews on caching | 20:13 |
notmorgan | with invalidtions etc. | 20:13 |
shaleh | yeah, cachine can be complex | 20:13 |
notmorgan | i also wont be at the midcycle, just too much going on with the things i should be working on instead of keystone. | 20:14 |
notmorgan | so... | 20:14 |
notmorgan | i figure having to step back from keystone, i should care less -- and making an effort to do so. | 20:15 |
stevemar | notmorgan: we will drink on your behalf | 20:15 |
notmorgan | i can't be that involved with keystone and focus on the other stuff. | 20:15 |
notmorgan | stevemar: eh, drink to enjoy, not on my behalf. | 20:16 |
dstanek | notmorgan: i'm just struggling to figure out how dogpile is working. invalidations, for instance, seem fundamentally broken | 20:17 |
*** ddieterly is now known as ddieterly[away] | 20:17 | |
notmorgan | dstanek: it depends on how invalidations are done | 20:18 |
notmorgan | the global invalidations require a hack. | 20:18 |
notmorgan | for the whole region that is | 20:18 |
*** markvoelker has joined #openstack-keystone | 20:19 | |
stevemar | notmorgan: we'll miss you anyway :) | 20:20 |
notmorgan | individual invalidations are a bit weird because of the need to pass self etc. | 20:20 |
*** spzala has joined #openstack-keystone | 20:21 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Move request validation inline https://review.openstack.org/339800 | 20:22 |
dstanek | notmorgan: i just want it simple. same key in memcache. delete from memcache to invalidate. | 20:23 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove validated decorator https://review.openstack.org/339801 | 20:23 |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Allow id string validation to be configurable https://review.openstack.org/334673 | 20:23 |
notmorgan | dstanek: you are going to run into issues with "action" needs to invalidate many things | 20:24 |
notmorgan | and you can't know all the keys without tracking them as well | 20:24 |
notmorgan | it's a lot of house keeping. | 20:25 |
notmorgan | its one of the major flaws we had with the token backend | 20:25 |
*** spzala has quit IRC | 20:26 | |
dstanek | notmorgan: yeah, i've have to do this before. you just have to have a plan | 20:28 |
openstackgerrit | Sam Leong proposed openstack/keystone: List role_assignments?include_names boolean parameter should not expect a value https://review.openstack.org/339809 | 20:35 |
*** gagehugo has quit IRC | 20:35 | |
*** haplo37_ has quit IRC | 20:35 | |
*** gagehugo has joined #openstack-keystone | 20:36 | |
openstackgerrit | Sam Leong proposed openstack/keystone-specs: List role_assignments?include_names boolean parameter should not expect a value https://review.openstack.org/339812 | 20:37 |
*** phalmos has quit IRC | 20:39 | |
*** ddieterly[away] is now known as ddieterly | 20:40 | |
dstanek | notmorgan: is a dogpile region anything more than a key namespace? | 20:41 |
*** iurygregory has quit IRC | 20:42 | |
notmorgan | dstanek: it is both a keynamespace and a means to connect to the backend | 20:43 |
notmorgan | technically a new region could connect to a different backend... | 20:43 |
notmorgan | it also can mangle keys / etc differently | 20:44 |
dstanek | notmorgan: cool. thanks. now i just have to figure out how it handles expiration time | 20:48 |
dstanek | it's not clear to me how anything ever expires | 20:49 |
*** timcline has joined #openstack-keystone | 20:49 | |
notmorgan | it encodes expiration in 2 ways | 20:49 |
notmorgan | 1: the item stored has the expiration in it | 20:50 |
notmorgan | so the region is setting (expiry, data) | 20:50 |
notmorgan | expiry is checked against now() basically | 20:50 |
notmorgan | [it's a bit more complex, it's a TTL, and when the key was set] | 20:50 |
notmorgan | then the backend can also set a ttl like a memcache ttl | 20:51 |
notmorgan | so the actual key in the backend itself will expire as well | 20:51 |
*** rcernin has quit IRC | 20:52 | |
*** jmlowe has joined #openstack-keystone | 20:54 | |
*** daemontool has joined #openstack-keystone | 21:01 | |
*** diazjf has quit IRC | 21:01 | |
dstanek | notmorgan: so it doesn't use memcache's expiration mechanism? | 21:03 |
*** roxanaghe has quit IRC | 21:05 | |
*** roxanaghe has joined #openstack-keystone | 21:06 | |
*** pnavarro has joined #openstack-keystone | 21:07 | |
openstackgerrit | Roxana Gherle proposed openstack/keystone: Fix the username value in federated tokens https://review.openstack.org/335617 | 21:10 |
notmorgan | dstanek: it does. it doesn't use that exclusivly | 21:11 |
*** slberger1 has quit IRC | 21:11 | |
notmorgan | it usually relies on the stored TTL | 21:11 |
notmorgan | in the cache data | 21:11 |
notmorgan | usually you want to set the TTL of the cached data a bit shorter than the memcache ttl | 21:13 |
notmorgan | because you can have an async runner refresh the data | 21:14 |
notmorgan | while still serving the old data out | 21:14 |
*** ravelar159 has quit IRC | 21:14 | |
*** pauloewerton has quit IRC | 21:20 | |
openstackgerrit | Brad Topol proposed openstack/keystone: Mark the domain config via API as stable https://review.openstack.org/339259 | 21:22 |
*** diazjf has joined #openstack-keystone | 21:22 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Mark the domain config via API as stable https://review.openstack.org/339259 | 21:24 |
openstackgerrit | Ron De Rose proposed openstack/keystone: Mark the domain config via API as stable https://review.openstack.org/339259 | 21:24 |
*** slberger has joined #openstack-keystone | 21:24 | |
*** pnavarro has quit IRC | 21:27 | |
dstanek | notmorgan: i'm just seeing strange things in the cache/b 29 | 21:28 |
*** edtubill has quit IRC | 21:37 | |
*** daemontool has quit IRC | 21:37 | |
*** basilAB has quit IRC | 21:37 | |
openstackgerrit | Eric Brown proposed openstack/keystone: Replace deprecated function inspect.getargspec() https://review.openstack.org/339828 | 21:37 |
stevemar | lbragstad: so what's your end game with the IDs being customizable? | 21:39 |
*** basilAB has joined #openstack-keystone | 21:39 | |
*** roxanaghe has quit IRC | 21:39 | |
*** edtubill has joined #openstack-keystone | 21:40 | |
*** jaugustine has quit IRC | 21:40 | |
openstackgerrit | Brad Topol proposed openstack/keystone: Mark the domain config via API as stable https://review.openstack.org/339259 | 21:44 |
*** roxanaghe has joined #openstack-keystone | 21:47 | |
*** edtubill has quit IRC | 21:48 | |
*** ayoung has quit IRC | 21:55 | |
*** timcline has quit IRC | 21:56 | |
*** pnavarro has joined #openstack-keystone | 21:59 | |
*** sigmavirus is now known as sigmavirus_away | 22:00 | |
*** stevemar changes topic to "Newton Deadlines: http://releases.openstack.org/newton/schedule.html | API Sprint: https://etherpad.openstack.org/p/keystone-api-sprint | Midcycle (July 20-22, San Jose, CA) https://etherpad.openstack.org/p/keystone-newton-midcycle | Meeting Agenda https://etherpad.openstack.org/p/keystone-weekly-meeting" | 22:05 | |
stevemar | dolphm: bknudson_ dstanek gyee henrynash jamielennox samueldmq topol FYI, if you want something added to the midcycle agenda, add it here: https://etherpad.openstack.org/p/keystone-newton-midcycle | 22:09 |
*** clenimar_ has joined #openstack-keystone | 22:10 | |
*** spzala has joined #openstack-keystone | 22:12 | |
*** slberger has left #openstack-keystone | 22:12 | |
*** pnavarro has quit IRC | 22:16 | |
*** ddieterly is now known as ddieterly[away] | 22:17 | |
notmorgan | dstanek: can you point it out to me and i'll try and take a look | 22:17 |
openstackgerrit | Merged openstack/keystoneauth: Add create_plugin to loader https://review.openstack.org/333119 | 22:19 |
*** sheel has joined #openstack-keystone | 22:37 | |
*** ddieterly[away] is now known as ddieterly | 22:39 | |
*** ddieterly has quit IRC | 22:39 | |
*** markvoelker has quit IRC | 22:40 | |
*** code-R_ has quit IRC | 22:43 | |
*** aastha has quit IRC | 22:49 | |
*** roxanaghe has quit IRC | 22:57 | |
*** ozialien10 has quit IRC | 23:02 | |
*** thumpba has quit IRC | 23:02 | |
*** ozialien10 has joined #openstack-keystone | 23:02 | |
gyee | stevemar, thanks, will do | 23:04 |
*** rderose has quit IRC | 23:05 | |
*** ddieterly has joined #openstack-keystone | 23:06 | |
*** ddieterly has quit IRC | 23:08 | |
*** ebalduf has joined #openstack-keystone | 23:10 | |
openstackgerrit | Jamie Lennox proposed openstack/keystoneauth: Allow registering additional plugin loaders https://review.openstack.org/333126 | 23:16 |
*** BjoernT has quit IRC | 23:35 | |
*** roxanaghe has joined #openstack-keystone | 23:36 | |
*** KevinE has quit IRC | 23:38 | |
*** markvoelker has joined #openstack-keystone | 23:41 | |
*** rderose has joined #openstack-keystone | 23:43 | |
*** roxanaghe has quit IRC | 23:44 | |
*** roxanaghe has joined #openstack-keystone | 23:46 | |
*** markvoelker has quit IRC | 23:47 | |
*** roxanaghe has quit IRC | 23:50 | |
*** spzala has quit IRC | 23:51 | |
openstackgerrit | Merged openstack/keystone: Ensure status code is always passed as int https://review.openstack.org/339214 | 23:52 |
openstackgerrit | Merged openstack/keystone: Move the auth plugins abstract base class out of core https://review.openstack.org/339112 | 23:54 |
openstackgerrit | Merged openstack/keystone: Doc update for moving abstract base classes out of core https://review.openstack.org/339152 | 23:55 |
*** clenimar_ has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!