| *** mylu has quit IRC | 00:02 | |
| *** stevemar has quit IRC | 00:02 | |
| *** mvk_ has quit IRC | 00:03 | |
| *** fawadkhaliq has quit IRC | 00:06 | |
| *** shaleh has quit IRC | 00:06 | |
| *** mylu has joined #openstack-keystone | 00:07 | |
| *** fawadkhaliq has joined #openstack-keystone | 00:07 | |
| *** fawadkhaliq has quit IRC | 00:13 | |
| *** rk4n has quit IRC | 00:14 | |
| *** markvoelker has joined #openstack-keystone | 00:15 | |
| *** fawadkhaliq has joined #openstack-keystone | 00:16 | |
| *** timcline has joined #openstack-keystone | 00:20 | |
| *** timcline_ has joined #openstack-keystone | 00:20 | |
| *** fawadkhaliq has quit IRC | 00:21 | |
| *** markvoelker_ has joined #openstack-keystone | 00:22 | |
| *** timcline has quit IRC | 00:22 | |
| *** fawadkhaliq has joined #openstack-keystone | 00:23 | |
| *** david8hu has quit IRC | 00:24 | |
| *** markvoelker has quit IRC | 00:25 | |
| *** lhcheng has quit IRC | 00:25 | |
| *** timcline_ has quit IRC | 00:25 | |
| *** akanksha_ has joined #openstack-keystone | 00:26 | |
| *** sdake has quit IRC | 00:34 | |
| *** spzala has quit IRC | 00:35 | |
| *** spzala has joined #openstack-keystone | 00:35 | |
| *** sdake has joined #openstack-keystone | 00:36 | |
| *** mvk_ has joined #openstack-keystone | 00:37 | |
| *** mylu has quit IRC | 00:39 | |
| *** spzala has quit IRC | 00:40 | |
| *** mkrcmari__ has quit IRC | 00:40 | |
| *** mylu has joined #openstack-keystone | 00:45 | |
| *** dave-mccowan has quit IRC | 00:53 | |
| *** gyee has quit IRC | 00:57 | |
| *** stevemar has joined #openstack-keystone | 00:58 | |
| *** ChanServ sets mode: +o stevemar | 00:58 | |
| *** dave-mccowan has joined #openstack-keystone | 00:58 | |
| openstackgerrit | Cristian Sava proposed openstack/keystone: Customize config file location when run as wsgi app. https://review.openstack.org/288216 | 01:01 |
|---|---|---|
| *** jamielennox is now known as jamielennox|away | 01:01 | |
| *** spzala has joined #openstack-keystone | 01:02 | |
| *** stevemar has quit IRC | 01:03 | |
| *** mylu has quit IRC | 01:07 | |
| *** mylu has joined #openstack-keystone | 01:08 | |
| *** rmallah has quit IRC | 01:11 | |
| *** fawadkhaliq has quit IRC | 01:14 | |
| *** fawadkhaliq has joined #openstack-keystone | 01:14 | |
| *** lhcheng has joined #openstack-keystone | 01:19 | |
| *** ChanServ sets mode: +v lhcheng | 01:19 | |
| *** fawadkhaliq has quit IRC | 01:20 | |
| *** fawadkhaliq has joined #openstack-keystone | 01:23 | |
| *** fawadkhaliq has quit IRC | 01:24 | |
| *** fawadkhaliq has joined #openstack-keystone | 01:25 | |
| *** lhcheng_ has joined #openstack-keystone | 01:27 | |
| *** fawadkhaliq has quit IRC | 01:27 | |
| *** lhcheng has quit IRC | 01:29 | |
| *** browne has quit IRC | 01:34 | |
| *** stevemar has joined #openstack-keystone | 01:39 | |
| *** ChanServ sets mode: +o stevemar | 01:39 | |
| *** sdake_ has joined #openstack-keystone | 01:49 | |
| *** sdake has quit IRC | 01:50 | |
| *** tqtran has joined #openstack-keystone | 01:53 | |
| *** pushkaru has joined #openstack-keystone | 01:57 | |
| *** tqtran has quit IRC | 01:57 | |
| *** bjornar has joined #openstack-keystone | 01:58 | |
| *** spandhe has quit IRC | 02:03 | |
| *** mylu has quit IRC | 02:11 | |
| *** richm has quit IRC | 02:13 | |
| *** agrebennikov_ has quit IRC | 02:17 | |
| *** rmallah has joined #openstack-keystone | 02:21 | |
| *** rmallah has quit IRC | 02:22 | |
| *** real56 has joined #openstack-keystone | 02:28 | |
| *** browne has joined #openstack-keystone | 02:28 | |
| stevemar | morgan: poke poke | 02:30 |
| morgan | stevemar: sorry been on the phone all day | 02:30 |
| morgan | stevemar: looking at the stuff now, closer prob. another couple hours and it'll be posted | 02:30 |
| stevemar | morgan: np dude, i've been out all day | 02:30 |
| stevemar | morgan: ack, i was just going to pull it up | 02:31 |
| stevemar | let me know if you need help | 02:31 |
| *** markvoelker_ has quit IRC | 02:31 | |
| morgan | it's just fixing tests | 02:31 |
| morgan | i made a couple mistakes on the tests because it was 1am when i wrote them | 02:31 |
| *** markvoelker_ has joined #openstack-keystone | 02:32 | |
| *** markvoel_ has joined #openstack-keystone | 02:36 | |
| *** mylu has joined #openstack-keystone | 02:36 | |
| *** markvoelker_ has quit IRC | 02:40 | |
| *** lhcheng has joined #openstack-keystone | 02:42 | |
| *** ChanServ sets mode: +v lhcheng | 02:42 | |
| *** mylu has quit IRC | 02:44 | |
| *** mylu has joined #openstack-keystone | 02:44 | |
| *** lhcheng_ has quit IRC | 02:45 | |
| *** real56 has quit IRC | 02:48 | |
| *** mylu_ has joined #openstack-keystone | 02:48 | |
| *** real56 has joined #openstack-keystone | 02:48 | |
| *** mylu has quit IRC | 02:49 | |
| *** tqtran has joined #openstack-keystone | 02:54 | |
| *** real56 has quit IRC | 02:55 | |
| *** real56 has joined #openstack-keystone | 02:56 | |
| *** akanksha_ has quit IRC | 02:57 | |
| *** tqtran has quit IRC | 02:58 | |
| *** markvoelker has joined #openstack-keystone | 03:01 | |
| *** ankur has joined #openstack-keystone | 03:02 | |
| *** markvoelker_ has joined #openstack-keystone | 03:04 | |
| *** markvoel_ has quit IRC | 03:04 | |
| *** sdake has joined #openstack-keystone | 03:07 | |
| *** fawadkhaliq has joined #openstack-keystone | 03:08 | |
| *** markvoelker has quit IRC | 03:08 | |
| *** sdake_ has quit IRC | 03:10 | |
| *** pumarani__ has joined #openstack-keystone | 03:10 | |
| *** pushkaru has quit IRC | 03:14 | |
| *** spandhe has joined #openstack-keystone | 03:19 | |
| *** dflorea has joined #openstack-keystone | 03:21 | |
| *** fawadkhaliq has quit IRC | 03:26 | |
| *** Daviey_ has joined #openstack-keystone | 03:26 | |
| *** fawadkhaliq has joined #openstack-keystone | 03:26 | |
| *** jraim_ has joined #openstack-keystone | 03:29 | |
| *** ankur_ has joined #openstack-keystone | 03:29 | |
| *** krotscheck has joined #openstack-keystone | 03:30 | |
| *** fawadkhaliq has quit IRC | 03:32 | |
| *** fawadkhaliq has joined #openstack-keystone | 03:32 | |
| *** Daviey has quit IRC | 03:32 | |
| *** jraim has quit IRC | 03:32 | |
| *** ankur has quit IRC | 03:32 | |
| *** krotscheck_dcm has quit IRC | 03:32 | |
| *** ankur_ is now known as ankur | 03:33 | |
| *** wxy has quit IRC | 03:33 | |
| *** rvba has quit IRC | 03:33 | |
| *** andrewbogott has quit IRC | 03:33 | |
| *** serverascode has quit IRC | 03:33 | |
| *** BlackDex has quit IRC | 03:33 | |
| *** mancdaz has quit IRC | 03:33 | |
| *** mancdaz has joined #openstack-keystone | 03:33 | |
| *** wxy has joined #openstack-keystone | 03:33 | |
| *** rvba has joined #openstack-keystone | 03:34 | |
| *** jraim_ is now known as jraim | 03:34 | |
| *** rvba has quit IRC | 03:34 | |
| *** rvba has joined #openstack-keystone | 03:34 | |
| *** BlackDex has joined #openstack-keystone | 03:38 | |
| *** andrewbogott has joined #openstack-keystone | 03:38 | |
| *** lhcheng has quit IRC | 03:40 | |
| *** real56 has quit IRC | 03:41 | |
| *** pumarani__ has quit IRC | 03:41 | |
| *** real56 has joined #openstack-keystone | 03:41 | |
| *** serverascode has joined #openstack-keystone | 03:41 | |
| *** links has joined #openstack-keystone | 03:44 | |
| *** real56 has quit IRC | 03:50 | |
| *** yarkot_ has joined #openstack-keystone | 03:51 | |
| *** yarkot_ has quit IRC | 03:53 | |
| *** pushkaru has joined #openstack-keystone | 03:57 | |
| *** mylu_ has quit IRC | 03:58 | |
| *** fawadkhaliq has quit IRC | 03:58 | |
| *** fawadkhaliq has joined #openstack-keystone | 03:59 | |
| *** fawadkhaliq has quit IRC | 04:00 | |
| *** fawadkhaliq has joined #openstack-keystone | 04:01 | |
| *** fawadkhaliq has quit IRC | 04:02 | |
| *** fawadkhaliq has joined #openstack-keystone | 04:02 | |
| *** anush_ has joined #openstack-keystone | 04:04 | |
| boris-42 | morgan: hi | 04:14 |
| morgan | boris-42: oh hai | 04:14 |
| boris-42 | morgan: how is going? | 04:14 |
| morgan | boris-42: trying to solve the last RC blocker for mitaka | 04:15 |
| boris-42 | good luck with that | 04:15 |
| morgan | how're you? | 04:15 |
| boris-42 | morgan: good good, just back to community+) | 04:16 |
| boris-42 | morgan: from internal work | 04:16 |
| *** bjornar has quit IRC | 04:16 | |
| boris-42 | morgan: so I have some question, maybe you saw this before | 04:16 |
| boris-42 | morgan: http://logs.openstack.org/62/298462/6/check/gate-rally-dsvm-rally/d881794/console.html#_2016-03-31_02_52_46_821 | 04:16 |
| boris-42 | morgan: sometimes (recently very often) we are getting this error | 04:16 |
| boris-42 | morgan: when there is load on keystone ~30 parallel operations | 04:17 |
| *** dflorea has quit IRC | 04:17 | |
| stevemar | boris-42: thats a huge log file | 04:17 |
| *** mylu has joined #openstack-keystone | 04:17 | |
| morgan | stevemar: yeah it is | 04:17 |
| boris-42 | stevemar: it's rally lol | 04:18 |
| morgan | boris-42: i think this is a case whre you're overloading the apache workers | 04:18 |
| morgan | we've seen a similar thing before | 04:18 |
| stevemar | Unable to establish connection to http://127.0.0.1:5000/v2.0 | 04:18 |
| morgan | you're simply maxing out the connections apache can handle | 04:18 |
| boris-42 | stevemar: yep | 04:18 |
| boris-42 | morgan: but it's just 30 connections | 04:18 |
| boris-42 | it's not 3k | 04:18 |
| morgan | this started happening when rally moved to KSA and did smarter connection handling | 04:18 |
| morgan | s/smarter/faster | 04:19 |
| *** diazjf has joined #openstack-keystone | 04:19 | |
| boris-42 | morgan: ah | 04:19 |
| *** diazjf has quit IRC | 04:19 | |
| morgan | i think last convo i had with someone was to check if the connections were being torn down by rally appropriately | 04:19 |
| morgan | you have limited numbers of workers, and each one handles a single request | 04:19 |
| boris-42 | morgan: so we don't manage connections in rally separately (we just use client) | 04:19 |
| morgan | i bet if you tune up the number of workers it'll work more | 04:20 |
| morgan | no you use ksa.session (or ksc.session) and then hand off to the clients | 04:20 |
| morgan | or OCC which does similar | 04:20 |
| morgan | it was a change identified not too long ago | 04:20 |
| morgan | i just don't remember who i was talking to | 04:20 |
| boris-42 | morgan: so there are 2 ways to address this issue | 04:21 |
| morgan | the simplest is tune up the number of workers. | 04:21 |
| boris-42 | morgan we can just reduce concurrency in gates (so we won't see this) | 04:21 |
| *** pushkaru has quit IRC | 04:21 | |
| *** markvoelker_ has quit IRC | 04:21 | |
| morgan | or reduce concurrency | 04:21 |
| boris-42 | morgan: or tune number of workers | 04:21 |
| boris-42 | yep | 04:21 |
| morgan | there is likely another issue too at play, but not 100% sure on what the cause | 04:21 |
| boris-42 | morgan: which one? | 04:22 |
| morgan | but you're clearly hitting the limit of what apache can serve for keystone | 04:22 |
| morgan | just the change in rally precipitated this, so the sessions might linger longer...or hold the connections open longer than expected | 04:22 |
| boris-42 | morgan: I will take a look at the configuration of gates | 04:22 |
| morgan | where the older non-session based paths didn't | 04:22 |
| morgan | but i know rally got faster at creating connections when the switch happened | 04:23 |
| boris-42 | morgan: so I will check the number of workers that is in gates | 04:23 |
| boris-42 | morgan: in devstack basically* | 04:23 |
| morgan | yeah | 04:23 |
| morgan | it's a low default iirc | 04:24 |
| morgan | that is fine for the actual gate | 04:24 |
| morgan | but rally is pushing those limits | 04:24 |
| boris-42 | morgan: yep | 04:24 |
| boris-42 | morgan: btw during the work on osprofiler | 04:24 |
| boris-42 | morgan: we saw that there are many DB requests to create token (/get_token) | 04:25 |
| morgan | expected | 04:25 |
| morgan | also the DB load should be lower in gate now | 04:25 |
| morgan | with the request local caching | 04:25 |
| boris-42 | morgan: if we redesign DB schema we can remove part of requests and speed up whole openstack | 04:26 |
| morgan | boris-42: remember you can't join across subsystems | 04:26 |
| morgan | no FKs, etc | 04:26 |
| boris-42 | morgan: adding JOINs is bad idea in any case no matter what you are doing | 04:27 |
| boris-42 | morgan: there are rare cases when you can use it and definitely not for online requests | 04:27 |
| morgan | not always | 04:27 |
| morgan | bad that is | 04:28 |
| morgan | but anyway you must always request through the subsystems, so looking up project must always go through resource_api.project | 04:28 |
| morgan | and looking up users must always go through identity_api.user | 04:28 |
| morgan | that is where most of the DB load comes from | 04:28 |
| morgan | look at the load w/ the request_local cache on | 04:28 |
| morgan | it should lower the load significantly | 04:28 |
| *** sdake_ has joined #openstack-keystone | 04:28 | |
| morgan | also remember, default mysql settings are basically barely usable for a developer laptop with no ram | 04:29 |
| morgan | so we might need to tune mysql some in devstack | 04:29 |
| *** fawadkhaliq has quit IRC | 04:29 | |
| *** fawadkhaliq has joined #openstack-keystone | 04:30 | |
| *** sdake has quit IRC | 04:30 | |
| *** EinstCrazy has joined #openstack-keystone | 04:33 | |
| *** mylu has quit IRC | 04:34 | |
| *** rk4n has joined #openstack-keystone | 04:35 | |
| *** rk4n has quit IRC | 04:35 | |
| morgan | boris-42: we also consistently ask for the same objects over and over (hence the request_local caching) | 04:35 |
| boris-42 | morgan: yep | 04:36 |
| boris-42 | morgan: I will test that | 04:36 |
| *** mylu has joined #openstack-keystone | 04:42 | |
| *** EinstCra_ has joined #openstack-keystone | 04:57 | |
| *** rcernin has joined #openstack-keystone | 04:59 | |
| *** agrebennikov_ has joined #openstack-keystone | 04:59 | |
| *** EinstCrazy has quit IRC | 05:01 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: Reorder the specs repo https://review.openstack.org/299132 | 05:04 |
| *** spandhe has quit IRC | 05:12 | |
| *** dave-mccowan has quit IRC | 05:13 | |
| *** sdake_ is now known as sdake | 05:14 | |
| *** jaosorior has joined #openstack-keystone | 05:14 | |
| *** naresht has quit IRC | 05:15 | |
| *** fawadkhaliq has quit IRC | 05:15 | |
| *** fawadkhaliq has joined #openstack-keystone | 05:16 | |
| stevemar | morgan: fixing up your indexes now :) | 05:16 |
| stevemar | well... attempting to, let's see how spectacularly these tests fail | 05:17 |
| *** GB21 has joined #openstack-keystone | 05:22 | |
| stevemar | morgan: silly question, in test_migration_88_drops_unique_constraint ... why are you asserting the index is there after 087... it only gets created with 088 | 05:34 |
| morgan | Uhm. No I am assertion g the old index is there | 05:34 |
| morgan | Not the new | 05:34 |
| *** GB21 has quit IRC | 05:35 | |
| *** spzala has quit IRC | 05:35 | |
| *** spzala has joined #openstack-keystone | 05:36 | |
| morgan | The role_table.c.name.indexes should be role_table.indexes in the test cases I added | 05:36 |
| morgan | That is the first fix. There is one of the fix needed | 05:36 |
| morgan | One other* | 05:36 |
| *** fawadkhaliq has quit IRC | 05:37 | |
| *** mylu has quit IRC | 05:39 | |
| *** fawadkhaliq has joined #openstack-keystone | 05:39 | |
| *** browne has quit IRC | 05:40 | |
| *** spzala has quit IRC | 05:40 | |
| stevemar | morgan: the other one is to use migrate.Unique... instead of sqlalchemy.Unique... | 05:45 |
| morgan | stevemar: yeah | 05:45 |
| morgan | was just typing that | 05:45 |
| morgan | and i have an assertNotIn or AssertIn backwards | 05:45 |
| morgan | testtools.matchers._impl.MismatchError: set([]) not in 'ixu_role_name' | 05:46 |
| morgan | stevemar: keystone.tests.unit.test_sql_upgrade.SqlUpgradeTests.test_migration_88_multiple_constraints_found | 05:46 |
| stevemar | morgan: it's also not picking up the assertionError for multi constraints | 05:48 |
| morgan | let me fix these two really quick | 05:48 |
| morgan | and see | 05:48 |
| stevemar | morgan: i pushed | 05:49 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 05:49 |
| morgan | ah cool good | 05:49 |
| *** pcaruana has quit IRC | 05:49 | |
| morgan | will pull it | 05:49 |
| stevemar | if you want a slightly newer version.. | 05:49 |
| morgan | ah sec. | 05:50 |
| *** e0ne has joined #openstack-keystone | 05:56 | |
| morgan | stevemar: ok, keystone.tests.unit.test_sql_upgrade.SqlUpgradeTests.test_migration_96_constraint_exists is still inverted on the assertIn/notIn | 05:56 |
| morgan | looking at the "duplicate index" issue | 05:56 |
| morgan | oh. | 05:57 |
| morgan | oh snap. | 05:57 |
| morgan | duplicate index can't occur *derp* | 05:57 |
| morgan | ok got a fix for this | 05:57 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: Reorder the specs repo https://review.openstack.org/299132 | 05:57 |
| *** spandhe has joined #openstack-keystone | 05:58 | |
| stevemar | morgan: oh, ha | 05:59 |
| *** fawadkhaliq has quit IRC | 05:59 | |
| stevemar | morgan: i think the asserts are inverted in a few spots | 05:59 |
| morgan | yeah looking at that now | 05:59 |
| *** fawadkhaliq has joined #openstack-keystone | 06:00 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 06:00 |
| morgan | ignore that one i just am doing a quick test | 06:01 |
| *** fawadkhaliq has quit IRC | 06:04 | |
| *** Nirupama has joined #openstack-keystone | 06:05 | |
| stevemar | morgan: i saw the results of your chopped thumb, you had typed in "assertt" | 06:07 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 06:07 |
| morgan | hah damn | 06:07 |
| morgan | so much closer | 06:08 |
| *** fawadkhaliq has joined #openstack-keystone | 06:08 | |
| morgan | constraint_exists doesn't properly work though hmmm | 06:08 |
| *** roxanaghe has joined #openstack-keystone | 06:08 | |
| morgan | stevemar: i think the last issues are that the meta isn't loading a new table? | 06:10 |
| morgan | testtools.matchers._impl.MismatchError: 'ixu_role_name' not in set([]) | 06:10 |
| stevemar | lemme take a looksy | 06:11 |
| morgan | self.assertIn('ixu_role_name', role_table.indexes) | 06:11 |
| morgan | the indexes are empty at line 1049 | 06:11 |
| morgan | on role_table.indexes | 06:11 |
| morgan | it's an empty set :( | 06:11 |
| *** rk4n has joined #openstack-keystone | 06:12 | |
| morgan | line 1120, 1049, 1169 and 1095 | 06:12 |
| morgan | same issue | 06:12 |
| morgan | i'm thinking it's a cached issue in the meta | 06:13 |
| morgan | maybe | 06:13 |
| morgan | ? | 06:13 |
| stevemar | got distracted | 06:18 |
| *** woodster_ has joined #openstack-keystone | 06:18 | |
| morgan | laptop is about to die :( will be back in a few | 06:19 |
| *** fawadkhaliq has quit IRC | 06:19 | |
| *** fawadkhaliq has joined #openstack-keystone | 06:19 | |
| *** roxanaghe has quit IRC | 06:19 | |
| stevemar | morgan: you may need a "self.metadata.clear()" in there | 06:20 |
| morgan | Ahh | 06:20 |
| *** daemontool has joined #openstack-keystone | 06:22 | |
| *** anush_ has quit IRC | 06:22 | |
| *** e0ne has quit IRC | 06:24 | |
| *** spandhe has quit IRC | 06:25 | |
| stevemar | morgan: that still doesn't make sense, you haven't even upgraded yet | 06:26 |
| morgan | what do you mean? | 06:26 |
| morgan | because upgrade(87) should create ixu_role_name index | 06:26 |
| morgan | that is the old index | 06:27 |
| morgan | 88 should drop that and create the new (role.name, role.domain_id) index | 06:27 |
| stevemar | morgan: i mean it's failing at 1049, which is the first upgrade | 06:28 |
| morgan | so: upgrade(87), check old index exists, upgrade(88) check old index doesn't exist | 06:28 |
| morgan | right | 06:28 |
| stevemar | normally you need to clear metadata between multiple upgrades | 06:28 |
| morgan | ? | 06:28 |
| morgan | self.meta.clear? | 06:28 |
| morgan | can you check that rq? my laptop doesn't have the battery for the test run | 06:29 |
| stevemar | rq? | 06:29 |
| morgan | real quick | 06:29 |
| stevemar | i did try and it didn't work :( | 06:29 |
| morgan | it's weird. | 06:29 |
| stevemar | added a "self.metadata.clear()" where you have "meta.clear()" | 06:30 |
| morgan | it somehow isn't creating the unique constraint/index: role_table.indexes is set([]) | 06:30 |
| morgan | which is weird | 06:30 |
| morgan | unless. | 06:30 |
| morgan | oh god. | 06:30 |
| morgan | is mysql, sqlite, and pgsql all have different semantics? | 06:30 |
| morgan | for how constraints are stored? | 06:30 |
| * morgan is gonna be really really unhappy if that is the case | 06:31 | |
| morgan | because i initially tried this with MySQL. | 06:31 |
| morgan | and the constraint was an index. | 06:31 |
| *** GB21 has joined #openstack-keystone | 06:31 | |
| *** spzala has joined #openstack-keystone | 06:37 | |
| *** sdake_ has joined #openstack-keystone | 06:37 | |
| *** sdake has quit IRC | 06:40 | |
| stevemar | morgan: i don't think that is the case... | 06:40 |
| morgan | Hmmm | 06:40 |
| stevemar | i straaight up hate our db migration tests | 06:41 |
| morgan | Well index is empty in the test | 06:41 |
| morgan | Yes. So do I. | 06:41 |
| stevemar | morgan: because sqlite? | 06:41 |
| morgan | Maybe =\ | 06:41 |
| *** spzala has quit IRC | 06:42 | |
| stevemar | morgan: L355 has a conditional check if mysql | 06:42 |
| stevemar | morgan: uh oh, latest revision is failing devstack | 06:43 |
| *** sdake has joined #openstack-keystone | 06:45 | |
| *** rk4n has quit IRC | 06:46 | |
| stevemar | 2016-03-31 06:18:25.543 | File "/home/jenkins/workspace/gate-keystone-python27-db/keystone/common/sql/migrate_repo/versions/088_domain_specific_roles.py", line 45, in upgrade | 06:47 |
| stevemar | 2016-03-31 06:18:25.543 | name=to_drop[0].name).drop() | 06:47 |
| stevemar | 2016-03-31 06:18:25.543 | TypeError: 'Index' object does not support indexing | 06:47 |
| *** sdake_ has quit IRC | 06:48 | |
| stevemar | i think that's supposed to be to_drop.name | 06:48 |
| *** fawadkhaliq has quit IRC | 06:48 | |
| *** fawadkhaliq has joined #openstack-keystone | 06:49 | |
| *** tesseract has joined #openstack-keystone | 06:49 | |
| *** tesseract is now known as Guest11037 | 06:49 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 06:50 |
| *** rk4n has joined #openstack-keystone | 06:52 | |
| morgan | stevemar: ah | 06:55 |
| morgan | stevemar: so i think we need to move to the nova migration test thing | 06:55 |
| morgan | stevemar: basically it steps up the migration and has a pre_number and post_number test | 06:56 |
| morgan | it runs pre_88 before 88, and post_88 after 88 | 06:56 |
| morgan | and you only test each migration step once. | 06:56 |
| *** rk4n has quit IRC | 06:56 | |
| morgan | no more wonky named tests, no more duplicated things | 06:56 |
| morgan | it's a simple 1 method run before to check state, one method run after to check state | 06:56 |
| morgan | stevemar: we're removing backlog? | 06:58 |
| morgan | in ksm | 06:58 |
| morgan | specs? | 06:58 |
| morgan | oh derp nvm | 06:59 |
| *** daemontool has quit IRC | 07:04 | |
| *** rk4n has joined #openstack-keystone | 07:05 | |
| *** rk4n has quit IRC | 07:14 | |
| stevemar | morgan: just moved it into keystone | 07:14 |
| stevemar | morgan: i'm stumped on this bug, now the coverage job is failing | 07:15 |
| morgan | stevemar: huh | 07:15 |
| morgan | w.t.f. | 07:15 |
| stevemar | oslo_db.exception.DBError: (psycopg2.ProgrammingError) relation "ixu_role_name" already exists | 07:15 |
| stevemar | 2016-03-31 07:06:37.985 | [SQL: 'ALTER TABLE role ADD CONSTRAINT ixu_role_name UNIQUE (name)' | 07:15 |
| *** e0ne has joined #openstack-keystone | 07:15 | |
| morgan | wait, why is the coverage job failing on that? | 07:16 |
| morgan | that measn the coverage job is doing something odd with the db? | 07:16 |
| stevemar | morgan: i dunno, i'm less concerned about that and more concerned about the tests | 07:16 |
| stevemar | i'll wake up early and work with brant on this issue | 07:16 |
| morgan | so... how much closer are you? | 07:16 |
| morgan | oh latest push? | 07:17 |
| stevemar | yeah, latest push | 07:17 |
| morgan | i'll take another look now that my computer is powered | 07:17 |
| stevemar | i made devstack happy | 07:17 |
| *** pushkaru has joined #openstack-keystone | 07:17 | |
| morgan | so this cycle lets move to the nova migration test model | 07:17 |
| stevemar | but we know it worked, cause promethean tested it | 07:17 |
| morgan | step up, check post X, check Pre y, upgrade to U | 07:18 |
| morgan | s/U/y | 07:18 |
| morgan | one method pre each migration, one post (at most) | 07:18 |
| *** e0ne has quit IRC | 07:18 | |
| morgan | and we do a single walk through the migration(s) | 07:18 |
| morgan | erm... huh | 07:20 |
| morgan | does sqlite do unique constraints? | 07:21 |
| morgan | because role_table.c.name has no constraints, and role_table has no indexes. | 07:21 |
| stevemar | morgan: it may not, but our CI is still failing and it definitely tests mysql and pg | 07:22 |
| morgan | this is so weird. | 07:22 |
| stevemar | morgan: actually... maybe they are each different | 07:23 |
| stevemar | https://jenkins01.openstack.org/job/gate-keystone-python27-db/29/console | 07:23 |
| morgan | that just makes me mad | 07:24 |
| morgan | esttools.matchers._impl.MismatchError: 'ixu_role_name' not in set([Index('ixu_role_name', Column('name', VARCHAR(length=255), table=<role>, nullable=False), unique=True)]) | 07:24 |
| morgan | i'm so... really?! | 07:24 |
| morgan | ok so wow.. | 07:24 |
| morgan | this is where SQL-A is useless | 07:24 |
| stevemar | morgan: take test_migration_96_constraint_exists for instance | 07:25 |
| morgan | i'm looking. | 07:26 |
| morgan | wow, this is an uuuugly bug | 07:26 |
| stevemar | on PG: relation "ixu_role_name" already exists; on mysql: 'ixu_role_name' not in set(has stuff); in sqlite: 'ixu_role_name' not in empty set | 07:26 |
| morgan | i have a better idea | 07:26 |
| morgan | screw this, i'm re-writing the migration. | 07:26 |
| morgan | i'm goint to just pivot the table. | 07:26 |
| morgan | and it's a crappy set of migrations | 07:26 |
| stevemar | morgan: do a different patch, just in case we want to work on this one | 07:26 |
| morgan | stevemar: uhm | 07:27 |
| morgan | stevemar: it aint happening tonight | 07:27 |
| morgan | :P | 07:27 |
| morgan | it's 0027 | 07:27 |
| morgan | i also want to poke at zzzeek about this | 07:28 |
| morgan | the fact that each db engine is working significantly differently seems to be exposing a bug. | 07:28 |
| stevemar | mmm | 07:28 |
| stevemar | we could override the tests in our Opportunistic tests | 07:29 |
| morgan | doesn't fix that the tests are still not working even w/ SQLite | 07:29 |
| morgan | sooo | 07:29 |
| stevemar | morgan: looks like sqlite doesn't do constraints anyway | 07:30 |
| morgan | i think it'll be easier to just write a "create new table, migrate data, drop table, rename new table" | 07:30 |
| stevemar | it's not picking up any at all | 07:30 |
| morgan | it has to do unique constraints, it just isn't inspectable via the DDL | 07:30 |
| morgan | because otheriwse we souldn't get conflicts on insertg the same domain twice | 07:30 |
| stevemar | i'll look at this tomorrow | 07:31 |
| stevemar | this is silly pants | 07:31 |
| morgan | lets pull zzzeek in tomorrow as well. | 07:31 |
| stevemar | yeah, i'll get bknudson to look at it too, we have a meeting in the morning together anyway | 07:32 |
| stevemar | thats right bknudson, i know you read your scrollback! | 07:32 |
| stevemar | morgan: i'm out for now | 07:32 |
| *** stevemar has quit IRC | 07:33 | |
| *** pushkaru has quit IRC | 07:38 | |
| *** pcaruana has joined #openstack-keystone | 07:41 | |
| *** GB21 has quit IRC | 07:45 | |
| *** permalac has joined #openstack-keystone | 07:48 | |
| *** rk4n has joined #openstack-keystone | 07:49 | |
| *** jistr has joined #openstack-keystone | 07:53 | |
| *** fawadkhaliq has quit IRC | 07:59 | |
| *** ankur has quit IRC | 08:01 | |
| *** fawadkhaliq has joined #openstack-keystone | 08:01 | |
| *** fawadkhaliq has quit IRC | 08:03 | |
| *** fawadkhaliq has joined #openstack-keystone | 08:04 | |
| openstackgerrit | Merged openstack/keystoneauth: Examples for migration from keystoneclient https://review.openstack.org/297764 | 08:05 |
| *** permalac has quit IRC | 08:06 | |
| *** sdake_ has joined #openstack-keystone | 08:17 | |
| *** henrynash has joined #openstack-keystone | 08:17 | |
| *** ChanServ sets mode: +v henrynash | 08:17 | |
| *** sdake has quit IRC | 08:19 | |
| *** sdake has joined #openstack-keystone | 08:22 | |
| *** sdake_ has quit IRC | 08:24 | |
| *** permalac has joined #openstack-keystone | 08:25 | |
| *** woodster_ has quit IRC | 08:27 | |
| *** e0ne has joined #openstack-keystone | 08:28 | |
| *** e0ne has quit IRC | 08:29 | |
| *** GB21 has joined #openstack-keystone | 08:30 | |
| *** stevemar has joined #openstack-keystone | 08:33 | |
| *** ChanServ sets mode: +o stevemar | 08:33 | |
| *** e0ne has joined #openstack-keystone | 08:34 | |
| *** e0ne has quit IRC | 08:35 | |
| *** fawadkhaliq has quit IRC | 08:37 | |
| *** spzala has joined #openstack-keystone | 08:38 | |
| *** stevemar has quit IRC | 08:39 | |
| *** fawadkhaliq has joined #openstack-keystone | 08:40 | |
| *** daemontool has joined #openstack-keystone | 08:41 | |
| *** spzala has quit IRC | 08:44 | |
| *** daemontool has quit IRC | 08:48 | |
| *** josecastroleon has joined #openstack-keystone | 08:51 | |
| *** pece has joined #openstack-keystone | 08:56 | |
| *** daemontool has joined #openstack-keystone | 08:58 | |
| *** agrebennikov_ has quit IRC | 09:02 | |
| *** fawadkhaliq has quit IRC | 09:05 | |
| *** fawadkhaliq has joined #openstack-keystone | 09:09 | |
| *** fawadkhaliq has quit IRC | 09:25 | |
| *** fawadkhaliq has joined #openstack-keystone | 09:26 | |
| *** e0ne has joined #openstack-keystone | 09:30 | |
| *** sdake_ has joined #openstack-keystone | 09:32 | |
| *** sdake has quit IRC | 09:32 | |
| *** sdake has joined #openstack-keystone | 09:33 | |
| *** sdake_ has quit IRC | 09:36 | |
| *** e0ne has quit IRC | 09:37 | |
| *** fawadkhaliq has quit IRC | 09:41 | |
| *** e0ne has joined #openstack-keystone | 09:42 | |
| *** fawadkhaliq has joined #openstack-keystone | 09:42 | |
| *** daemontool has quit IRC | 09:43 | |
| *** ankur has joined #openstack-keystone | 09:43 | |
| *** mkrcmari__ has joined #openstack-keystone | 09:44 | |
| *** daemontool has joined #openstack-keystone | 09:44 | |
| *** fawadkhaliq has quit IRC | 09:44 | |
| *** mvk_ has quit IRC | 09:47 | |
| *** fawadkhaliq has joined #openstack-keystone | 09:50 | |
| *** mvk_ has joined #openstack-keystone | 09:52 | |
| *** mkrcmari__ has quit IRC | 09:55 | |
| *** zqfan has joined #openstack-keystone | 10:03 | |
| *** sdake has quit IRC | 10:03 | |
| *** fawadkhaliq has quit IRC | 10:09 | |
| *** fawadkhaliq has joined #openstack-keystone | 10:10 | |
| *** mkrcmari__ has joined #openstack-keystone | 10:13 | |
| *** e0ne has quit IRC | 10:15 | |
| *** mvk_ has quit IRC | 10:17 | |
| *** e0ne has joined #openstack-keystone | 10:17 | |
| *** fawadkhaliq has quit IRC | 10:18 | |
| *** fawadkhaliq has joined #openstack-keystone | 10:19 | |
| *** e0ne has quit IRC | 10:20 | |
| *** EinstCra_ has quit IRC | 10:21 | |
| *** e0ne has joined #openstack-keystone | 10:21 | |
| *** e0ne has quit IRC | 10:22 | |
| *** e0ne has joined #openstack-keystone | 10:23 | |
| *** e0ne has quit IRC | 10:24 | |
| *** fawadkhaliq has quit IRC | 10:25 | |
| *** mvk_ has joined #openstack-keystone | 10:28 | |
| *** mkrcmari__ has quit IRC | 10:32 | |
| *** stevemar has joined #openstack-keystone | 10:35 | |
| *** ChanServ sets mode: +o stevemar | 10:35 | |
| *** bjornar has joined #openstack-keystone | 10:36 | |
| *** fawadkhaliq has joined #openstack-keystone | 10:39 | |
| *** stevemar has quit IRC | 10:39 | |
| *** GB21 has quit IRC | 10:41 | |
| *** permalac has quit IRC | 10:44 | |
| *** fawadkhaliq has quit IRC | 10:49 | |
| *** doug-fish has joined #openstack-keystone | 10:51 | |
| *** henrynash has quit IRC | 10:57 | |
| *** GB21 has joined #openstack-keystone | 11:00 | |
| *** e0ne has joined #openstack-keystone | 11:17 | |
| *** henrynash has joined #openstack-keystone | 11:18 | |
| *** ChanServ sets mode: +v henrynash | 11:18 | |
| *** e0ne has quit IRC | 11:18 | |
| *** dstanek has quit IRC | 11:22 | |
| *** jlvillal_ has joined #openstack-keystone | 11:22 | |
| *** redrobot has quit IRC | 11:22 | |
| *** jlvillal has quit IRC | 11:22 | |
| *** bigjools has quit IRC | 11:22 | |
| *** dhellmann has quit IRC | 11:22 | |
| *** electrichead has joined #openstack-keystone | 11:22 | |
| *** dhellmann_ has joined #openstack-keystone | 11:22 | |
| *** e0ne has joined #openstack-keystone | 11:23 | |
| *** dstanek has joined #openstack-keystone | 11:23 | |
| *** ChanServ sets mode: +v dstanek | 11:23 | |
| *** jlvillal_ is now known as jlvillal | 11:23 | |
| *** bigjools has joined #openstack-keystone | 11:24 | |
| *** bigjools has quit IRC | 11:24 | |
| *** bigjools has joined #openstack-keystone | 11:24 | |
| *** jlvillal is now known as Guest87578 | 11:24 | |
| *** e0ne has quit IRC | 11:26 | |
| *** dhellmann_ is now known as dhellmann | 11:26 | |
| openstackgerrit | Dina Belova proposed openstack/keystone: Add DB operations tracing https://review.openstack.org/294535 | 11:34 |
| openstackgerrit | Dina Belova proposed openstack/keystone: Integrate OSprofiler in Keystone https://review.openstack.org/103368 | 11:34 |
| *** e0ne has joined #openstack-keystone | 11:35 | |
| *** e0ne has quit IRC | 11:41 | |
| *** gordc has joined #openstack-keystone | 11:43 | |
| *** ankur has quit IRC | 11:51 | |
| *** e0ne has joined #openstack-keystone | 11:59 | |
| *** e0ne has quit IRC | 12:00 | |
| *** GB21 has quit IRC | 12:05 | |
| *** trown|outtypewww is now known as trown | 12:05 | |
| *** ayoung has quit IRC | 12:10 | |
| *** e0ne has joined #openstack-keystone | 12:11 | |
| *** e0ne has quit IRC | 12:13 | |
| *** Nirupama has quit IRC | 12:14 | |
| *** EinstCrazy has joined #openstack-keystone | 12:19 | |
| *** dave-mccowan has joined #openstack-keystone | 12:20 | |
| *** rodrigods has quit IRC | 12:21 | |
| *** rodrigods has joined #openstack-keystone | 12:22 | |
| *** Nirupama has joined #openstack-keystone | 12:29 | |
| *** Nirupama has quit IRC | 12:35 | |
| *** stevemar has joined #openstack-keystone | 12:36 | |
| *** ChanServ sets mode: +o stevemar | 12:36 | |
| *** raildo-afk is now known as raildo | 12:36 | |
| *** daemontool_ has joined #openstack-keystone | 12:39 | |
| *** stevemar has quit IRC | 12:40 | |
| *** daemontool has quit IRC | 12:42 | |
| *** patchbot has quit IRC | 12:48 | |
| *** patchbot has joined #openstack-keystone | 12:48 | |
| *** daemontool__ has joined #openstack-keystone | 12:49 | |
| *** e0ne has joined #openstack-keystone | 12:50 | |
| *** ninag has joined #openstack-keystone | 12:50 | |
| *** Nirupama has joined #openstack-keystone | 12:51 | |
| *** e0ne has quit IRC | 12:51 | |
| *** daemontool_ has quit IRC | 12:52 | |
| *** daemontool__ has quit IRC | 12:55 | |
| *** henrynash has quit IRC | 12:55 | |
| *** pushkaru has joined #openstack-keystone | 12:56 | |
| *** edmondsw has joined #openstack-keystone | 12:57 | |
| *** links has quit IRC | 12:58 | |
| *** jsavak has joined #openstack-keystone | 12:59 | |
| *** daemontool__ has joined #openstack-keystone | 12:59 | |
| *** daemontool__ is now known as daemontool | 13:00 | |
| *** jaosorior has quit IRC | 13:05 | |
| *** jaosorior has joined #openstack-keystone | 13:06 | |
| *** mvk_ has quit IRC | 13:06 | |
| *** spzala has joined #openstack-keystone | 13:12 | |
| *** richm has joined #openstack-keystone | 13:14 | |
| bknudson | stevemar: get a bouncer | 13:14 |
| *** pauloewerton has joined #openstack-keystone | 13:17 | |
| *** anush_ has joined #openstack-keystone | 13:22 | |
| *** Dwarf-Br has joined #openstack-keystone | 13:24 | |
| *** Dwarf-Br has left #openstack-keystone | 13:24 | |
| *** Nirupama has quit IRC | 13:27 | |
| *** knikolla has joined #openstack-keystone | 13:32 | |
| *** e0ne has joined #openstack-keystone | 13:32 | |
| *** tqtran has joined #openstack-keystone | 13:34 | |
| *** stevemar has joined #openstack-keystone | 13:36 | |
| *** ChanServ sets mode: +o stevemar | 13:36 | |
| *** tqtran has quit IRC | 13:39 | |
| openstackgerrit | Tom Cocozzello proposed openstack/keystone: Run federation tests under Python 3 https://review.openstack.org/294797 | 13:39 |
| *** ametts has joined #openstack-keystone | 13:39 | |
| *** mylu has joined #openstack-keystone | 13:40 | |
| *** stevemar has quit IRC | 13:41 | |
| *** pushkaru has quit IRC | 13:44 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: Add users functional tests https://review.openstack.org/289306 | 13:44 |
| *** permalac has joined #openstack-keystone | 13:45 | |
| *** ametts has quit IRC | 13:50 | |
| *** ayoung has joined #openstack-keystone | 13:50 | |
| *** ChanServ sets mode: +v ayoung | 13:50 | |
| bjornar__ | python-memcached in a python3 blocker, any chance you will change that requirement? | 13:50 |
| *** e0ne has quit IRC | 13:52 | |
| *** permalac has quit IRC | 13:53 | |
| *** pushkaru has joined #openstack-keystone | 13:53 | |
| *** e0ne has joined #openstack-keystone | 13:54 | |
| *** henrynash has joined #openstack-keystone | 13:54 | |
| *** ChanServ sets mode: +v henrynash | 13:54 | |
| *** pushkaru has quit IRC | 13:54 | |
| *** ametts has joined #openstack-keystone | 13:54 | |
| *** e0ne has quit IRC | 13:56 | |
| samueldmq | morgan: I am looking at 298402 | 13:59 |
| *** anush_ has quit IRC | 13:59 | |
| *** anush_ has joined #openstack-keystone | 14:02 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:05 | |
| *** rderose has joined #openstack-keystone | 14:05 | |
| *** slberger has joined #openstack-keystone | 14:07 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 14:14 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:15 | |
| morgan | samueldmq: hey | 14:19 |
| *** hogepodge has joined #openstack-keystone | 14:21 | |
| *** links has joined #openstack-keystone | 14:28 | |
| *** e0ne has joined #openstack-keystone | 14:29 | |
| *** e0ne has quit IRC | 14:29 | |
| knikolla | morning! | 14:32 |
| *** anush_ has quit IRC | 14:34 | |
| *** phalmos has joined #openstack-keystone | 14:40 | |
| openstackgerrit | Rodrigo Duarte proposed openstack/keystone: Base for keystone tempest plugin https://review.openstack.org/297292 | 14:41 |
| *** mvk_ has joined #openstack-keystone | 14:42 | |
| *** agrebennikov_ has joined #openstack-keystone | 14:44 | |
| *** e0ne has joined #openstack-keystone | 14:45 | |
| rodrigods | bknudson,^ thanks for the review, check if you agree with some of the replies | 14:45 |
| *** andrewbogott has quit IRC | 14:47 | |
| *** andrewbogott has joined #openstack-keystone | 14:47 | |
| *** links has quit IRC | 14:48 | |
| *** links has joined #openstack-keystone | 14:49 | |
| *** jaosorior_ has joined #openstack-keystone | 14:52 | |
| *** jaosorior has quit IRC | 14:53 | |
| *** jaugustine has joined #openstack-keystone | 14:56 | |
| *** sdake has joined #openstack-keystone | 14:57 | |
| *** jsavak has quit IRC | 14:59 | |
| *** diazjf has joined #openstack-keystone | 14:59 | |
| *** jsavak has joined #openstack-keystone | 15:00 | |
| *** cdcasey has joined #openstack-keystone | 15:01 | |
| *** pece has quit IRC | 15:01 | |
| *** e0ne has quit IRC | 15:01 | |
| *** ametts has quit IRC | 15:02 | |
| *** rderose has quit IRC | 15:02 | |
| *** diazjf has quit IRC | 15:05 | |
| *** arunkant_ has joined #openstack-keystone | 15:06 | |
| *** electrichead is now known as redrobot | 15:06 | |
| *** stevemar has joined #openstack-keystone | 15:06 | |
| *** ChanServ sets mode: +o stevemar | 15:06 | |
| *** jistr has quit IRC | 15:07 | |
| *** ametts has joined #openstack-keystone | 15:07 | |
| *** jistr has joined #openstack-keystone | 15:09 | |
| morgan | zzzeek: ping - re some migration/sql-a issues when you're up | 15:11 |
| samueldmq | morgan: here | 15:14 |
| samueldmq | interesting, I can't 'tox -e py27' | 15:18 |
| samueldmq | ERROR: could not install deps | 15:18 |
| *** rderose has joined #openstack-keystone | 15:19 | |
| *** links has quit IRC | 15:19 | |
| *** rk4n has quit IRC | 15:19 | |
| *** spzala has quit IRC | 15:20 | |
| *** spzala has joined #openstack-keystone | 15:20 | |
| *** rk4n has joined #openstack-keystone | 15:21 | |
| *** david_cu has joined #openstack-keystone | 15:22 | |
| zzzeek | morgan: hey | 15:22 |
| morgan | zzzeek: heyya | 15:22 |
| morgan | zzzeek: so, running into an issue with SQL-A and the migration(s) [not alembic] | 15:22 |
| morgan | zzzeek: it seems SQLite, MySQL, and PGSQL all represent unique constraints in the table introspection differently | 15:22 |
| morgan | zzzeek: SQLite doesn't expose the data, MySQL does, but as an index, and PGSQL ... is something else i haven't been able to chase down | 15:23 |
| morgan | zzzeek: the use is "we need to programatically find a unique constraint [name is inconsistent] and drop it" | 15:23 |
| *** jaosorior_ has quit IRC | 15:24 | |
| morgan | zzzeek: i'm at the point where I'm looking at creating a new table, migrating data, and then doing a rename. - advice is welcome before i do that | 15:24 |
| morgan | (RC blocking bug) | 15:24 |
| morgan | https://review.openstack.org/#/c/298402/ | 15:24 |
| patchbot | morgan: patch 298402 - keystone - Correct `role_name` constraint dropping | 15:24 |
| morgan | zzzeek: also, sorry for the ambush ;) | 15:24 |
| *** ayoung has quit IRC | 15:24 | |
| *** agrebennikov_ has quit IRC | 15:24 | |
| *** spzala has quit IRC | 15:25 | |
| *** ayoung has joined #openstack-keystone | 15:25 | |
| *** ChanServ sets mode: +v ayoung | 15:25 | |
| zzzeek | morgan: well why do SQLite migrations first off | 15:25 |
| *** mugsie has joined #openstack-keystone | 15:25 | |
| morgan | zzzeek: because unit tests [sigh] | 15:27 |
| zzzeek | Also wouldn't the name of this constraint be consistent on each backend at least bc MySQL and PostgreSQL both use a naming convention | 15:27 |
| morgan | zzzeek: no, the name was set differently depending on when the deployment was made | 15:27 |
| zzzeek | morgan: yeah you should move to create_all() for SQLite unit tests | 15:27 |
| morgan | and i found at least 3 different versions: automatic, set specifically one way, set specifically another way | 15:28 |
| *** agrebennikov_ has joined #openstack-keystone | 15:28 | |
| *** jistr has quit IRC | 15:28 | |
| morgan | zzzeek: we do for unit tests, we just baseline do simple migration tests [they are the same] for SQLite and now do opportunistic in the gate as well | 15:28 |
| morgan | but until last week we didn't do opportunistic | 15:28 |
| bknudson | one deployer found that the name was not as expected. it was an old database | 15:28 |
| morgan | and this has to land in stable/mitaka | 15:28 |
| *** jistr has joined #openstack-keystone | 15:28 | |
| morgan | bknudson: the only deployer so far that has moved to mitaka | 15:29 |
| morgan | that i know of. | 15:29 |
| rderose | morgan: question about your adding a wrapper comment: https://review.openstack.org/#/c/296140/ | 15:29 |
| patchbot | rderose: patch 296140 - keystone - Remove backend interface and common code out of id... | 15:29 |
| morgan | but if you ran the DB from ~havana/icehouse you will have different constraint names. | 15:29 |
| rderose | morgan: can't I just remove this line: Driver = manager.create_legacy_driver(IdentityDriverV8)? | 15:29 |
| rderose | morgan: I don't think it's even being used | 15:29 |
| bknudson | the unique constraints show up in constraints, not in indexes for some reason | 15:30 |
| morgan | rderose: uhm. we need to maintain it for a cycle when we move it. | 15:30 |
| morgan | bknudson: in mysql they show up in indexes, in pgsql in constraints i think | 15:30 |
| bknudson | although it looks like on postgres it shows up in indexes for some reason | 15:30 |
| morgan | in sqlite they show up in neither | 15:30 |
| rderose | morgan: sorry, but why if it's not being used | 15:30 |
| morgan | or different versions of mysql show up differently? it's been a lot of very inconsistent behaviors. | 15:30 |
| morgan | rderose: internal to our code it isn't used | 15:30 |
| morgan | rderose: it might be used by someone subclassing | 15:31 |
| morgan | rderose: we don't want to break them in upgrade w/o warning(s) | 15:31 |
| morgan | we support people providing their own drivers. | 15:31 |
| zzzeek | morgan: I'd use the inspector which will give you the unique constraints and compare the columns to locate. If you're using alembic for migrations you'd use batch mode for the change so SQLite is covered | 15:32 |
| morgan | zzzeek: sadly we're using sql-migrate still | 15:33 |
| rderose | morgan: okay, I see. So you just want me to be some deprecation warning around this? Is that what you mean by wrapper? | 15:33 |
| morgan | rderose: yep | 15:33 |
| zzzeek | Ok then that does SQLite tables automatically | 15:33 |
| zzzeek | morgan: migrate should do the drop/ recreate for SQLite | 15:33 |
| morgan | zzzeek: right. | 15:33 |
| morgan | zzzeek: and it does - the issue i'm having is "testing" looking up the constraints programatically | 15:34 |
| morgan | it works fine if we assume the constraint name is correct. | 15:34 |
| zzzeek | morgan: get all the constraints for the table w inspect(engine) and locate it by looking for the pattern of columns | 15:35 |
| *** timcline has joined #openstack-keystone | 15:36 | |
| morgan | zzzeek: ah it doesn't work the same as using sqla.Table(...)? | 15:36 |
| samueldmq | morgan: so they don't show in either constraints or indexes for all dbs ? | 15:36 |
| morgan | ok, i'll re-work this with inspect() | 15:36 |
| morgan | samueldmq: it's inconsistent | 15:36 |
| *** markvoelker has joined #openstack-keystone | 15:37 | |
| morgan | samueldmq: different RDBMS and different versions are represented differently | 15:37 |
| morgan | it appears | 15:37 |
| zzzeek | morgan: yeah it's much more granular give it a try | 15:37 |
| samueldmq | morgan: I was being able to acces them with constraints .. but yes, was trying only with sqlite :( | 15:37 |
| morgan | zzzeek: ok will do. thnx (this has been a bit frustrating) | 15:37 |
| *** diazjf has joined #openstack-keystone | 15:37 | |
| morgan | zzzeek: we've moved to mostly explicitly set constraint names / index names now | 15:37 |
| *** e0ne has joined #openstack-keystone | 15:37 | |
| morgan | zzzeek: but we have a lot of legacy deployments *ugh* | 15:38 |
| morgan | and we weren't as vigilant in the past | 15:38 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 15:38 | |
| *** real56 has joined #openstack-keystone | 15:39 | |
| samueldmq | morgan: in sqlite I was able to see it using inspector | 15:39 |
| samueldmq | morgan: you going to update them to use inspector (to read constraints)? | 15:40 |
| *** e0ne has quit IRC | 15:40 | |
| morgan | samueldmq: thats the plan unless you already have code for it | 15:40 |
| morgan | samueldmq: happy to take contribution on the patch :) | 15:40 |
| *** markvoelker has quit IRC | 15:40 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:40 | |
| *** markvoelker_ has joined #openstack-keystone | 15:41 | |
| samueldmq | morgan: I can try it, as soon as I can run tox locally | 15:41 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 15:41 | |
| samueldmq | I am getting ERROR: could not install deps | 15:41 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:41 | |
| *** trown is now known as trown|lunch | 15:41 | |
| morgan | weird. | 15:41 |
| morgan | rm -rf .tox ? | 15:42 |
| samueldmq | yeah I even tried in a new cloned keystone | 15:42 |
| samueldmq | looks like something is weird while installing psycopg2 | 15:42 |
| morgan | <IT Crowd> "have you tried turning off and on again?" </IT Crowd> | 15:43 |
| openstackgerrit | Merged openstack/keystone: Random project should return positive numbers https://review.openstack.org/298970 | 15:43 |
| *** tobe has joined #openstack-keystone | 15:43 | |
| samueldmq | wait | 15:43 |
| samueldmq | sudo reboot | 15:43 |
| *** e0ne has joined #openstack-keystone | 15:44 | |
| samueldmq | morgan: bknudson: any idea ? http://paste.openstack.org/show/492610/ | 15:44 |
| zzzeek | morgan: well I hadn't made it a priority upstream | 15:44 |
| morgan | zzzeek: no worries :) | 15:44 |
| zzzeek | ultimately it's all my fault :) | 15:44 |
| morgan | zzzeek: haha. I BLAME YOU! :P | 15:44 |
| morgan | zzzeek: anyway nah, it's all good as long as i have a way forward | 15:44 |
| morgan | :) | 15:45 |
| morgan | thnx for the help | 15:45 |
| zzzeek | Yes as long as they PAY me its all good :) | 15:45 |
| morgan | samueldmq: you need libpg-dev [i think it is] | 15:45 |
| morgan | sec | 15:45 |
| morgan | libpq-dev | 15:45 |
| morgan | apt-get that (assuming debian or ubuntu) | 15:45 |
| samueldmq | morgan: that's a new thing right? | 15:46 |
| *** spzala has joined #openstack-keystone | 15:46 | |
| morgan | nope | 15:46 |
| *** e0ne has quit IRC | 15:46 | |
| morgan | always been a thing when pgsql stuff was in requirements | 15:47 |
| *** EinstCrazy has quit IRC | 15:47 | |
| morgan | i think it dropped out of requirements and then was just added for opportunistic testing | 15:47 |
| *** e0ne has joined #openstack-keystone | 15:47 | |
| *** tobe has quit IRC | 15:48 | |
| samueldmq | morgan: interesting is that I was able to run it before, and libpq-dev isn't listed in http://docs.openstack.org/developer/keystone/setup.html#installing-dependencies | 15:49 |
| morgan | samueldmq: yeah opportunistic testing (it's in the oslo.db install] | 15:50 |
| morgan | in setup.cfg i think | 15:50 |
| morgan | or tox.ini | 15:50 |
| *** markvoelker_ has quit IRC | 15:50 | |
| *** markvoelker has joined #openstack-keystone | 15:51 | |
| bknudson | zzzeek: morgan: the table.indexes and table.constraints are different -- http://paste.openstack.org/show/492613/ | 15:51 |
| *** henrynash has quit IRC | 15:51 | |
| bknudson | the previous migrations create a unique index on the name column | 15:51 |
| *** Guest87578 is now known as jlvillal | 15:55 | |
| *** markvoelker has quit IRC | 15:55 | |
| *** markvoelker has joined #openstack-keystone | 15:56 | |
| *** bjornar has quit IRC | 15:56 | |
| *** markvoelker_ has joined #openstack-keystone | 15:57 | |
| *** e0ne has quit IRC | 15:58 | |
| *** jorge_munoz has joined #openstack-keystone | 15:58 | |
| *** rderose has quit IRC | 15:59 | |
| *** shangxdy has joined #openstack-keystone | 15:59 | |
| *** shangxdy_ has joined #openstack-keystone | 15:59 | |
| *** markvoelker has quit IRC | 16:01 | |
| *** rderose has joined #openstack-keystone | 16:01 | |
| *** sdake has quit IRC | 16:01 | |
| *** jsavak has quit IRC | 16:04 | |
| samueldmq | morgan: do we need to update the migration itself ? or just the tests? | 16:06 |
| zzzeek | bknudson: yes both pg and MySQL have some duplicating behaviors, the Inspector includes flags in the results which indicate these duplicating behaviors | 16:07 |
| zzzeek | bknudson: MySQL doesn't actually have a "unique constraint" they come out as indexes | 16:08 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 16:08 |
| *** pcaruana has quit IRC | 16:08 | |
| zzzeek | bknudson: PostgreSQL does something different, it dupes a unique index into a unique constraint or something like that (maybe other way around) | 16:09 |
| *** dan_nguyen has joined #openstack-keystone | 16:10 | |
| bknudson | zzzeek: what is inspector you've mentioned? We always use sql.Table(autoload=True) to figure out what the table looks like. | 16:10 |
| *** e0ne has joined #openstack-keystone | 16:11 | |
| samueldmq | bknudson: I think it is "inspector = reflection.Inspector.from_engine(self.engine)" | 16:11 |
| zzzeek | bknudson samueldmq you can say insp = inspect(engine) now | 16:13 |
| zzzeek | from sqlalchemy import inspect | 16:13 |
| bknudson | found the docs - http://docs.sqlalchemy.org/en/rel_1_0/core/reflection.html#sqlalchemy.engine.reflection.Inspector | 16:15 |
| samueldmq | zzzeek: will use this, thx | 16:15 |
| bknudson | is Inspector better than using Table(autoload=True) ? | 16:15 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 16:17 |
| mylu | Hey guys, I'm working on the resource federation project at Mass Open Cloud, we're want to have functional test for the federated token across two clouds, we noticed that you guys are writing functional tests for create mapping, create protocols and stuff. Would it make sense to include the saml exchange tests too? | 16:17 |
| mylu | Or should I do it via tempest and Ci | 16:17 |
| zzzeek | bknudson: it is more detailed and table reflection uses it to generate the Table constructs in any case | 16:18 |
| bknudson | mylu: there should be tests for federation in tempest. | 16:18 |
| *** fawadkhaliq has joined #openstack-keystone | 16:19 | |
| mylu | bknudson: do you mean that there exists test for federation in tempest right now? or the saml assertion exchange test should be in tempest? | 16:22 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 16:23 |
| bknudson | mylu: I don't know what tests exist in tempest. | 16:23 |
| bknudson | mylu: if there aren't any there should be | 16:23 |
| mylu | bknudson: make sense, I will talk to the tempest folk and CI team thanks! | 16:24 |
| *** sdake has joined #openstack-keystone | 16:24 | |
| samueldmq | morgan: making some progress ... wil post soon :) | 16:26 |
| *** browne has joined #openstack-keystone | 16:28 | |
| *** sdake has quit IRC | 16:28 | |
| *** sdake has joined #openstack-keystone | 16:29 | |
| prometheanfire | stevemar: bunch of revisions :( | 16:29 |
| morgan | samueldmq: migration needs to be updated too. | 16:30 |
| stevemar | prometheanfire: yeah, its all tests! | 16:30 |
| prometheanfire | yep | 16:30 |
| *** sdake has quit IRC | 16:30 | |
| *** jsavak has joined #openstack-keystone | 16:30 | |
| stevemar | prometheanfire: and accounting for mysql vs non-mysql | 16:30 |
| prometheanfire | too bad there's no spec or something for sql that everyone could use | 16:30 |
| stevemar | prometheanfire: a lot of the revisions are me pushing updates so bknudson can see them, we're on the phone | 16:30 |
| prometheanfire | ah | 16:31 |
| prometheanfire | np, just intresting to see them all :P | 16:31 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 16:31 |
| *** e0ne has quit IRC | 16:32 | |
| stevemar | prometheanfire: bknudson morgan samueldmq ^^^^^^^^^^^^^^ | 16:32 |
| stevemar | that should work | 16:32 |
| stevemar | hopefully.... | 16:32 |
| *** slberger1 has joined #openstack-keystone | 16:32 | |
| prometheanfire | we shall see | 16:32 |
| prometheanfire | in the mean time, lunching | 16:32 |
| knikolla | bknudson, i just did a search on tempest and nothing came up for 'federation' | 16:32 |
| stevemar | prometheanfire: you gonna try this patch out manually? | 16:32 |
| stevemar | :) | 16:32 |
| samueldmq | morgan: yes I was updating that too... got 88 working, but stevemar just uploaded a new patchset that should work :D | 16:33 |
| stevemar | samueldmq: hopefully! | 16:33 |
| *** gagehugo has joined #openstack-keystone | 16:33 | |
| samueldmq | morgan: stevemar was doing this in migration 88 now : http://paste.openstack.org/show/492621/ | 16:33 |
| samueldmq | stevemar: o/ | 16:33 |
| stevemar | samueldmq: o/ | 16:33 |
| knikolla | bknudson, also there a keystone spec for having functional tests inside of keystone instead of tempest. | 16:33 |
| *** slberger has quit IRC | 16:34 | |
| knikolla | though i'm not sure on the progress of that spec. | 16:34 |
| *** mylu has quit IRC | 16:34 | |
| bknudson | knikolla: the advantage to having tests in tempest is that they can be part of refcore | 16:35 |
| *** fawadkhaliq has quit IRC | 16:36 | |
| *** diazjf has quit IRC | 16:37 | |
| *** fawadkhaliq has joined #openstack-keystone | 16:37 | |
| knikolla | bknudson, i know of defcore, but what is refcore? | 16:37 |
| *** diazjf has joined #openstack-keystone | 16:38 | |
| *** shangxdy_ has quit IRC | 16:38 | |
| *** shangxdy_ has joined #openstack-keystone | 16:39 | |
| *** trown|lunch is now known as trown | 16:39 | |
| *** diazjf has quit IRC | 16:40 | |
| *** timcline has quit IRC | 16:40 | |
| *** fawadkhaliq has quit IRC | 16:41 | |
| *** timcline has joined #openstack-keystone | 16:41 | |
| *** fawadkhaliq has joined #openstack-keystone | 16:41 | |
| *** timcline has quit IRC | 16:46 | |
| *** agrebennikov_ has quit IRC | 16:46 | |
| *** spzala has quit IRC | 16:46 | |
| *** spzala has joined #openstack-keystone | 16:47 | |
| *** e0ne has joined #openstack-keystone | 16:47 | |
| *** sdake has joined #openstack-keystone | 16:48 | |
| *** e0ne has quit IRC | 16:50 | |
| bknudson | knikolla: I meant defcore | 16:50 |
| *** spzala has quit IRC | 16:51 | |
| *** zqfan has quit IRC | 16:52 | |
| *** spzala has joined #openstack-keystone | 16:52 | |
| *** jorge_munoz has quit IRC | 16:53 | |
| *** dflorea has joined #openstack-keystone | 16:56 | |
| *** agrebennikov_ has joined #openstack-keystone | 16:57 | |
| *** spzala has quit IRC | 16:57 | |
| *** roxanaghe has joined #openstack-keystone | 16:57 | |
| mtreinish | bknudson: there is nothing for federation in tempest right now. I do agree there should be | 16:58 |
| *** shangxdy_ has quit IRC | 16:59 | |
| *** shangxdy has quit IRC | 16:59 | |
| *** mylu has joined #openstack-keystone | 16:59 | |
| stevemar | bknudson: morgan samueldmq y'all went to quiet about the patch? :) | 16:59 |
| stevemar | is https://review.openstack.org/#/c/298402/ that scary? :) | 17:00 |
| patchbot | stevemar: patch 298402 - keystone - Correct `role_name` constraint dropping | 17:00 |
| *** agrebennikov__ has joined #openstack-keystone | 17:00 | |
| morgan | Sorry coffee... | 17:00 |
| stevemar | morgan: hehe | 17:00 |
| *** jistr has quit IRC | 17:00 | |
| stevemar | morgan: turns out mysql was storing constraints in the indexes?! | 17:01 |
| stevemar | but pg and sqlite do not | 17:01 |
| stevemar | jenkins is looking OK, 2 random routing failures (grenade and tempest) | 17:03 |
| rderose | morgan: still there? | 17:03 |
| *** agrebennikov_ has quit IRC | 17:03 | |
| *** real56 has quit IRC | 17:03 | |
| *** real56 has joined #openstack-keystone | 17:04 | |
| *** spzala has joined #openstack-keystone | 17:04 | |
| *** Guest11037 has quit IRC | 17:05 | |
| *** rcernin has quit IRC | 17:06 | |
| *** tqtran has joined #openstack-keystone | 17:06 | |
| *** spzala has quit IRC | 17:09 | |
| samueldmq | stevemar: I will look at it now | 17:09 |
| samueldmq | stevemar: had to go afk for a bit :) | 17:09 |
| *** tqtran has quit IRC | 17:10 | |
| samueldmq | stevemar: the approach I was doing it was using inspection to get the constraint name | 17:10 |
| samueldmq | stevemar: so we shouldn't need to do if statements based on the engine type | 17:10 |
| samueldmq | stevemar: I will post it in a different review to see if it works | 17:11 |
| stevemar | samueldmq: ahh, want to toss up a different patch? | 17:11 |
| stevemar | sure | 17:11 |
| samueldmq | stevemar: thanks, in a bit once I finish it | 17:11 |
| *** woodster_ has joined #openstack-keystone | 17:14 | |
| *** spzala has joined #openstack-keystone | 17:16 | |
| *** bjornar has joined #openstack-keystone | 17:16 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 17:17 | |
| morgan | samueldmq, stevemar: ok will be back in a feew, getting donuts | 17:18 |
| morgan | then will be able to work more on this | 17:18 |
| morgan | samueldmq: thnx for helping | 17:18 |
| *** spzala has quit IRC | 17:20 | |
| samueldmq | morgan: not sure if I am helping yet :p | 17:22 |
| samueldmq | morgan: let's see if it works in other rmdbs | 17:22 |
| samueldmq | stevemar: ^ | 17:22 |
| samueldmq | it's working locally with sqlalchemy, let's see with others, let me upload it in a bit | 17:23 |
| *** dflorea has quit IRC | 17:24 | |
| *** daemontool has quit IRC | 17:25 | |
| *** spandhe has joined #openstack-keystone | 17:27 | |
| *** fawadkhaliq has quit IRC | 17:28 | |
| *** spzala has joined #openstack-keystone | 17:30 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:30 | |
| openstackgerrit | Tim Burke proposed openstack/keystonemiddleware: Allow IPv6 addresses in auth_host config option https://review.openstack.org/300106 | 17:34 |
| *** spzala has quit IRC | 17:34 | |
| *** anush_ has joined #openstack-keystone | 17:35 | |
| *** jsavak has quit IRC | 17:35 | |
| *** jsavak has joined #openstack-keystone | 17:36 | |
| *** diazjf has joined #openstack-keystone | 17:38 | |
| *** anush_ has quit IRC | 17:39 | |
| *** tqtran has joined #openstack-keystone | 17:39 | |
| *** dims_ has quit IRC | 17:39 | |
| *** dims has joined #openstack-keystone | 17:40 | |
| *** timcline has joined #openstack-keystone | 17:42 | |
| *** mylu has quit IRC | 17:42 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 17:44 |
| *** lhcheng has joined #openstack-keystone | 17:44 | |
| *** ChanServ sets mode: +v lhcheng | 17:44 | |
| samueldmq | stevemar: morgan ^ | 17:44 |
| samueldmq | stevemar: I am happy to approve your proposal if it works too, I just saw it got a +2 from bknudson | 17:45 |
| *** fawadkhaliq has quit IRC | 17:46 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:46 | |
| stevemar | samueldmq: just updating the patch with bknudson's comments, it makes things a bit cleaner | 17:46 |
| *** timcline has quit IRC | 17:46 | |
| *** fawadkhaliq has quit IRC | 17:47 | |
| *** jsavak has quit IRC | 17:47 | |
| *** jsavak has joined #openstack-keystone | 17:47 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:47 | |
| *** fawadkhaliq has quit IRC | 17:47 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:48 | |
| openstackgerrit | Tim Burke proposed openstack/keystonemiddleware: Have s3_token accept identity_uri config option https://review.openstack.org/294835 | 17:48 |
| samueldmq | stevemar: sure | 17:48 |
| -openstackstatus- NOTICE: Job failures for missing traceroute packages are in the process of being fixed now, ETA 30 minutes to effectiveness for new jobs | 17:48 | |
| *** fawadkhaliq has quit IRC | 17:48 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:49 | |
| *** spzala has joined #openstack-keystone | 17:49 | |
| *** jaosorior has joined #openstack-keystone | 17:49 | |
| *** fawadkhaliq has quit IRC | 17:50 | |
| *** fawadkhaliq has joined #openstack-keystone | 17:50 | |
| *** gyee has joined #openstack-keystone | 17:53 | |
| *** ChanServ sets mode: +v gyee | 17:53 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 17:53 |
| *** spzala has quit IRC | 17:54 | |
| stevemar | samueldmq: can you put your change in a different patch? :) | 17:54 |
| samueldmq | stevemar: sure, and we can approve it later if it also works and we find it better | 17:56 |
| samueldmq | stevemar: will do in a bit | 17:56 |
| *** spzala has joined #openstack-keystone | 18:01 | |
| *** jaosorior has quit IRC | 18:01 | |
| *** lhcheng has quit IRC | 18:01 | |
| *** lhcheng has joined #openstack-keystone | 18:03 | |
| *** lhcheng has quit IRC | 18:03 | |
| *** lhcheng has joined #openstack-keystone | 18:04 | |
| *** ChanServ sets mode: +v lhcheng | 18:04 | |
| bknudson | we're not going to change the migrations again after this merges. | 18:04 |
| bknudson | unless there's a bug in it | 18:04 |
| *** spzala has quit IRC | 18:06 | |
| *** anush_ has joined #openstack-keystone | 18:06 | |
| *** fawadk has joined #openstack-keystone | 18:06 | |
| *** jsavak has quit IRC | 18:06 | |
| *** fawadkhaliq has quit IRC | 18:07 | |
| *** lhcheng has quit IRC | 18:07 | |
| *** jsavak has joined #openstack-keystone | 18:07 | |
| *** fawadk has quit IRC | 18:09 | |
| *** gyee has quit IRC | 18:10 | |
| prometheanfire | stevemar: don't think I can because it's already been fixed for me | 18:10 |
| *** jasonsb has joined #openstack-keystone | 18:10 | |
| stevemar | samueldmq: yeah, no way we're going through this again, it's one or the other now :) | 18:11 |
| *** spzala has joined #openstack-keystone | 18:12 | |
| *** anush_ has quit IRC | 18:12 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone: Add logging to cli if keystone.conf is not found https://review.openstack.org/300131 | 18:12 |
| *** jasonsb has quit IRC | 18:13 | |
| *** gyee has joined #openstack-keystone | 18:14 | |
| *** ChanServ sets mode: +v gyee | 18:14 | |
| *** topol has joined #openstack-keystone | 18:14 | |
| *** ChanServ sets mode: +v topol | 18:14 | |
| *** tqtran has quit IRC | 18:14 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone: Add logging to cli if keystone.conf is not found https://review.openstack.org/300131 | 18:16 |
| *** dflorea has joined #openstack-keystone | 18:18 | |
| morgan | back now | 18:19 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:20 | |
| *** timcline has joined #openstack-keystone | 18:21 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 18:22 | |
| *** real56 has quit IRC | 18:23 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:24 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/300136 | 18:24 |
| *** dims_ has joined #openstack-keystone | 18:24 | |
| *** dims has quit IRC | 18:24 | |
| samueldmq | morgan: stevemar: bknudson ^ | 18:24 |
| morgan | samueldmq: nice. | 18:24 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/300136 | 18:25 |
| samueldmq | morgan: just added you as co-author, as I am the author (because I am submitting it) | 18:25 |
| morgan | did you keep the change id? | 18:25 |
| morgan | cause that is all that matters | 18:25 |
| morgan | you should just use my review and do --reset-author | 18:26 |
| morgan | and add me and prometheanfire as co-authors | 18:26 |
| samueldmq | morgan: if I keep the change it it will post in the same gerrit review | 18:26 |
| * prometheanfire shrugs | 18:26 | |
| morgan | does.. https://review.openstack.org/#/c/298402/ duplicate what you did? | 18:26 |
| patchbot | morgan: patch 298402 - keystone - Correct `role_name` constraint dropping | 18:26 |
| prometheanfire | morgan: you did most of it | 18:27 |
| morgan | if it's an either/or and yours is better thats fine | 18:27 |
| morgan | but we should just keep it all in one place. | 18:27 |
| samueldmq | morgan: it doesnt' duplicate | 18:27 |
| morgan | hold on.. let me see yours | 18:28 |
| samueldmq | morgan: stevemar got it working, but without using inspection | 18:28 |
| samueldmq | morgan: ok | 18:28 |
| morgan | so. which one do we want to use? | 18:28 |
| morgan | it looks like it's an either/or? | 18:28 |
| * morgan is confused | 18:29 | |
| stevemar | morgan: yep, it's either :) | 18:29 |
| morgan | ok | 18:29 |
| morgan | i don't care which way we go | 18:29 |
| *** fawadkhaliq has joined #openstack-keystone | 18:29 | |
| morgan | but mine has a bknudson +2 already :P | 18:29 |
| morgan | so... | 18:29 |
| morgan | we can land it sooner :P | 18:29 |
| morgan | but... lets just pick one and get RC fixed | 18:29 |
| stevemar | morgan: it'll need another recheck anyway | 18:29 |
| stevemar | cause gate issues | 18:29 |
| samueldmq | morgan: stevemar: me neiher, I am fine with other approach too | 18:30 |
| * morgan supports stevemar's choice. | 18:30 | |
| *** spzala has quit IRC | 18:30 | |
| morgan | stevemar: you're on the spot mr. PTL | 18:30 |
| morgan | ;) | 18:30 |
| samueldmq | morgan: just submitted that as it was what we had discussed with zzzeek earlier | 18:30 |
| morgan | samueldmq: right. good to know how it works. | 18:30 |
| samueldmq | but as stevemar got it working, let's get it :) | 18:30 |
| morgan | ^_^ | 18:30 |
| stevemar | i like samueldmq's cause it's cleaner... but prometheanfire tested morgans | 18:30 |
| morgan | stevemar: so.. which one we going with? | 18:30 |
| morgan | stevemar: we'll abandon the other one and move forward :) | 18:31 |
| * topol pop the popcorn... morgan putting the squeeze on stevemar | 18:31 | |
| stevemar | go with the one that was manually tested and verified by the person it affected | 18:31 |
| * morgan likes working with people who want things fixed first and doesn't care where the code comes from | 18:31 | |
| morgan | stevemar: ok. | 18:31 |
| morgan | topol: haha right?! | 18:31 |
| morgan | topol: PTL has a job to do. | 18:31 |
| morgan | topol: PTLs gonna PTL | 18:31 |
| ayoung | does swift client still not support v3? | 18:31 |
| samueldmq | stevemar: I agree with you | 18:31 |
| topol | :-) | 18:31 |
| morgan | ayoung: swift client does not AND doesn't use session | 18:31 |
| *** spzala has joined #openstack-keystone | 18:31 | |
| samueldmq | stevemar: if we have to merge it quick, and that one's been tested, let's go with it | 18:32 |
| samueldmq | stevemar: has prometheanfire tested your last patch set ? | 18:32 |
| ayoung | morgan, morgan right. Looks like someone started a patch based on keystoneclient instead of keystoneauth | 18:32 |
| morgan | ayoung: sigh | 18:32 |
| stevemar | morgan: unfortunately the gate is a bit wonky | 18:32 |
| stevemar | so its gonna have to wait a bit | 18:33 |
| ayoung | morgan, funny thing is, it works if you passin an auth url with /v3 at the ned, just doesn't do discovery | 18:33 |
| *** gangadhar has quit IRC | 18:33 | |
| timburke | ayoung: you might be interested in https://review.openstack.org/#/c/298968/ | 18:33 |
| patchbot | timburke: patch 298968 - python-swiftclient - Adding keystoneauth sessions support | 18:33 |
| ayoung | timburke, yep | 18:33 |
| ayoung | that is the one | 18:33 |
| ayoung | timburke, need to abandon the other...let me find the link | 18:34 |
| samueldmq | stevemar: morgan: bot is crazily changing the owner of that bug | 18:34 |
| timburke | oh? not https://review.openstack.org/#/c/270045/ ? | 18:34 |
| patchbot | timburke: patch 270045 - python-swiftclient - Adding session to switfclient. | 18:34 |
| samueldmq | hehe | 18:34 |
| prometheanfire | samueldmq: I can't test it anymore because it's been fixed for me :( | 18:36 |
| *** mvk_ has quit IRC | 18:36 | |
| samueldmq | prometheanfire: break it again! | 18:36 |
| samueldmq | prometheanfire: :) | 18:37 |
| prometheanfire | lol | 18:37 |
| prometheanfire | next release :P | 18:37 |
| samueldmq | hehe | 18:37 |
| morgan | samueldmq: actually we could just do havana install, and upgrade | 18:40 |
| morgan | i think thats a safe bet of duplication (but a lot of work) | 18:40 |
| *** dave-mccowan has quit IRC | 18:41 | |
| *** jorge_munoz has joined #openstack-keystone | 18:41 | |
| *** mhickey has joined #openstack-keystone | 18:43 | |
| *** dan_nguyen has quit IRC | 18:44 | |
| samueldmq | morgan: I prefer to merge the other patch then :p | 18:45 |
| samueldmq | morgan: although it should work if the tests are run against other rmdbs too | 18:45 |
| samueldmq | but who knows, let's simply go with what we know works :) | 18:45 |
| morgan | wfm | 18:45 |
| morgan | you should +2 the one then | 18:46 |
| samueldmq | will do now | 18:46 |
| morgan | or i can +2 yours and we can abandon mine. | 18:46 |
| morgan | basically... we double down on the one that we're going with | 18:46 |
| samueldmq | there is comment duplicated there in yours | 18:46 |
| * morgan is happy to see RC out the door (crappy RC bug!) | 18:46 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 18:47 |
| *** dan_nguyen has joined #openstack-keystone | 18:48 | |
| *** dflorea has quit IRC | 18:48 | |
| samueldmq | stevemar: morgan: done | 18:49 |
| samueldmq | bknudson: cc ^ | 18:49 |
| samueldmq | gonna be afk for a bit | 18:49 |
| prometheanfire | woo +w | 18:49 |
| *** rderose has quit IRC | 18:55 | |
| *** tqtran has joined #openstack-keystone | 18:57 | |
| *** nkinder has joined #openstack-keystone | 18:58 | |
| *** openstackgerrit has quit IRC | 19:03 | |
| *** openstackgerrit has joined #openstack-keystone | 19:04 | |
| *** dave-mccowan has joined #openstack-keystone | 19:04 | |
| *** mhickey has quit IRC | 19:08 | |
| *** rderose has joined #openstack-keystone | 19:09 | |
| *** henrynash has joined #openstack-keystone | 19:12 | |
| *** ChanServ sets mode: +v henrynash | 19:12 | |
| *** lhcheng has joined #openstack-keystone | 19:13 | |
| *** ChanServ sets mode: +v lhcheng | 19:13 | |
| *** henrynash has quit IRC | 19:13 | |
| *** nkinder has quit IRC | 19:15 | |
| lbragstad | stevemar for structure changes of the keystone-specs repo - we can approve that with only two cores, right? | 19:26 |
| *** jamielennox|away is now known as jamielennox | 19:26 | |
| lbragstad | stevemar we don't need to have more that two cores for those types of changes do we? | 19:27 |
| lbragstad | than* | 19:27 |
| *** sileht has quit IRC | 19:30 | |
| morgan | stevemar: ppst | 19:34 |
| morgan | stevemar: https://review.openstack.org/#/c/300179/ :P | 19:34 |
| patchbot | morgan: patch 300179 - election - Add Morgan Fainberg as TC Candidate | 19:34 |
| morgan | stevemar: should be interesting. | 19:34 |
| lbragstad | morgan ^^ | 19:35 |
| morgan | lbragstad: yeah | 19:35 |
| lbragstad | morgan do you have an answer for the question i asked stevemar ? | 19:35 |
| stevemar | morgan: yay | 19:35 |
| morgan | i would be fine with 2 cores changing the structure there | 19:35 |
| lbragstad | oh - there's stevemar | 19:35 |
| morgan | it's not approving specs/changing the specs | 19:35 |
| lbragstad | ok - cool.. just checking | 19:35 |
| stevemar | yeah, sorry, was afk for 20 minutes there | 19:35 |
| morgan | just making it more logical | 19:35 |
| lbragstad | stevemar how dare you! | 19:35 |
| morgan | stevemar: so.. counting on you to vote for me! :) | 19:35 |
| stevemar | lbragstad morgan ... two questions i wanted to bring up with that patch | 19:35 |
| stevemar | maybe you all have opinions | 19:35 |
| stevemar | morgan: of course! | 19:36 |
| morgan | stevemar: i am opinionless. :P | 19:36 |
| morgan | j/k | 19:36 |
| morgan | ask away | 19:36 |
| lbragstad | stevemar what's up? | 19:36 |
| stevemar | morgan lbragstad -- should we group ksa/ksm/ksc specs into releases like that? or the numbered releases? | 19:36 |
| knikolla | morgan, good luck! | 19:36 |
| morgan | uhm | 19:36 |
| morgan | hmmm | 19:36 |
| lbragstad | stevemar hmmm they don't follow the keystone release plan | 19:36 |
| stevemar | morgan lbragstad -- secondly, i wanted to create symlinks so any links out there still work! | 19:36 |
| morgan | symlinks are good | 19:37 |
| morgan | or similar | 19:37 |
| stevemar | it is pretty easy to find out what numbered release went into juno/kilo/liberty/etc... | 19:37 |
| morgan | i'd probably bundle this into release targets | 19:37 |
| morgan | tbh same as keystone | 19:37 |
| morgan | because we have stable branches for them | 19:37 |
| morgan | it makes it easier to understand the target window for code inclusion | 19:37 |
| morgan | and feature completion | 19:37 |
| lbragstad | yeah | 19:37 |
| stevemar | okay | 19:38 |
| stevemar | if you guys are fine with it, then fire away | 19:38 |
| stevemar | i can do the symlinks in another patch | 19:38 |
| lbragstad | i think i agree with morgan | 19:38 |
| *** slberger1 has quit IRC | 19:38 | |
| lbragstad | stevemar i'll push this one through and you can do the symlinks whenever? | 19:38 |
| *** slberger has joined #openstack-keystone | 19:39 | |
| *** sdake_ has joined #openstack-keystone | 19:43 | |
| stevemar | lbragstad: yep | 19:43 |
| *** sdake has quit IRC | 19:44 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Define identity interface - easy cases https://review.openstack.org/291950 | 19:44 |
| openstackgerrit | Merged openstack/keystone-specs: Reorder the specs repo https://review.openstack.org/299132 | 19:44 |
| jaugustine | Hi, I've drafted up a blueprint blurb on launchpad for adding metadata endpoints to domans and projects and would like to hear any feedback you may have. Link - https://blueprints.launchpad.net/keystone/+spec/domains-projects-metadata | 19:45 |
| *** dan_nguyen has quit IRC | 19:52 | |
| -openstackstatus- NOTICE: Any jobs which erroneously failed on missing traceroute packages should be safe to recheck now | 19:54 | |
| *** dan_nguyen has joined #openstack-keystone | 19:56 | |
| *** sdake_ has quit IRC | 19:56 | |
| *** diazjf has quit IRC | 19:58 | |
| *** mylu has joined #openstack-keystone | 19:58 | |
| *** rderose has quit IRC | 20:01 | |
| openstackgerrit | Steve Martinelli proposed openstack/keystone: Correct `role_name` constraint dropping https://review.openstack.org/298402 | 20:02 |
| stevemar | morgan: samueldmq i just rebased ^ to bump it from the queue and recheck it | 20:02 |
| morgan | stevemar: sure. | 20:02 |
| morgan | wfm | 20:02 |
| stevemar | cause jenkins is apparently happy again | 20:02 |
| morgan | stevemar: checking the OSProfiler change, i think there is still an issue with it | 20:04 |
| morgan | but it's purely like setup.cfg type issue | 20:04 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone: Add 'links' to implied roles response https://review.openstack.org/300195 | 20:07 |
| stevemar | crinkle: can i officially call you the terminator? | 20:08 |
| stevemar | crinkle: cause if i ever need bugs cleared out, i'm calling you | 20:08 |
| openstackgerrit | Colleen Murphy proposed openstack/keystone: Add 'links' to implied roles response https://review.openstack.org/300195 | 20:08 |
| crinkle | stevemar: two-line bugfixes are my specialty :P | 20:08 |
| *** topol has quit IRC | 20:09 | |
| stevemar | crinkle: quit being modest, 300195 is a 3 liner! :) | 20:09 |
| crinkle | hehe | 20:09 |
| morgan | so much bug cleanup! | 20:13 |
| morgan | DinaBelova: comments for osprofiler, it's ready once we get config generation working. | 20:13 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: Shadow users: work item to relax mapping requirements https://review.openstack.org/299546 | 20:14 |
| morgan | stevemar: ^ cc re osprofiler. | 20:14 |
| stevemar | lbragstad: https://review.openstack.org/#/c/299546/2 | 20:14 |
| patchbot | stevemar: patch 299546 - keystone-specs - Shadow users: work item to relax mapping requirements | 20:14 |
| morgan | stevemar: i'm avoiding fixing it directly since i've done the majority of the review on it and would like to +2 when it's ready | 20:14 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: PCI-DSS v3.1 https://review.openstack.org/272396 | 20:15 |
| lbragstad | stevemar one more comment on wording - https://review.openstack.org/#/c/299546/2 :) | 20:15 |
| patchbot | lbragstad: patch 299546 - keystone-specs - Shadow users: work item to relax mapping requirements | 20:15 |
| *** sileht has joined #openstack-keystone | 20:16 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: Define identity interface - easy cases https://review.openstack.org/291950 | 20:16 |
| bknudson | now tests against live database ^ | 20:16 |
| openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: Shadow users: work item to relax mapping requirements https://review.openstack.org/299546 | 20:17 |
| stevemar | lbragstad: ^ | 20:17 |
| *** spandhe has quit IRC | 20:17 | |
| openstackgerrit | Colleen Murphy proposed openstack/keystone-specs: Use valid json for "List implied roles" example https://review.openstack.org/300197 | 20:17 |
| lbragstad | stevemar ++ thanks! | 20:18 |
| *** browne has quit IRC | 20:19 | |
| morgan | bknudson: woort | 20:20 |
| morgan | crinkle: even fixing our specs! | 20:21 |
| stevemar | lbragstad: morgan bknudson https://review.openstack.org/#/c/272396/ -- if you all are interested in pushing this through, i am happy with the spec for newton | 20:21 |
| patchbot | stevemar: patch 272396 - keystone-specs - PCI-DSS v3.1 | 20:21 |
| *** browne has joined #openstack-keystone | 20:21 | |
| morgan | stevemar: sold | 20:21 |
| morgan | stevemar: +2 | 20:21 |
| stevemar | figure out which specs to land for newton before the summit even gets here | 20:22 |
| stevemar | that would be amazing | 20:22 |
| knikolla | or try even completing before summit :P | 20:22 |
| morgan | stevemar: has someone proposed mving the ldap3 one over (hint knikolla) | 20:22 |
| morgan | cauise i so want to +2 that! | 20:23 |
| morgan | knikolla: i can propose moving it overto newton if you want | 20:23 |
| morgan | because i expect that to land | 20:23 |
| knikolla | morgan, it's already there | 20:23 |
| morgan | early this cycle | 20:23 |
| morgan | ah | 20:23 |
| morgan | nice | 20:23 |
| morgan | damn i missed it | 20:23 |
| knikolla | https://github.com/openstack/keystone-specs/blob/master/specs/keystone/newton/ldap3.rst | 20:23 |
| bknudson | I like how I'm just removed as the assignee. | 20:24 |
| morgan | bknudson: easy to add you in! but if you're not writing the code... might as well let knikolla get theglory, right? | 20:25 |
| morgan | ;) | 20:25 |
| *** fawadkhaliq has quit IRC | 20:27 | |
| stevemar | morgan: i moved it over a day or two ago :) | 20:27 |
| stevemar | morgan: you already proposed a backport? https://review.openstack.org/#/q/Ie0dc3d2449bace57d3e9323b281a2abd2ad0c983,n,z | 20:27 |
| *** fawadkhaliq has joined #openstack-keystone | 20:27 | |
| morgan | stevemar: let me cherry-pick the new version | 20:27 |
| stevemar | alrighty | 20:28 |
| morgan | stevemar: but yes i was keeping the backport in sync with each iteration to ensure it would land quickly once we had it workuing | 20:28 |
| stevemar | very much appreciated | 20:29 |
| *** stevemar has quit IRC | 20:33 | |
| *** stevemar has joined #openstack-keystone | 20:33 | |
| *** ChanServ sets mode: +o stevemar | 20:33 | |
| morgan | stevemar: https://review.openstack.org/298406 | 20:34 |
| morgan | should be a backport now. | 20:34 |
| morgan | it's relatively clean | 20:35 |
| knikolla | global variables in wsgi are persistent across requests? | 20:35 |
| stevemar | morgan: you had a hilarious test in your initial patch this morning, it was test_migration_101, but it just did upgrade(96) | 20:35 |
| morgan | stevemar: yeah... i was kinda sleeeep deprived :P | 20:36 |
| *** spzala has quit IRC | 20:37 | |
| *** fawadkhaliq has quit IRC | 20:42 | |
| *** ayoung has quit IRC | 20:43 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Remove backend interface and common code out of identity.core https://review.openstack.org/296140 | 20:43 |
| *** rderose has joined #openstack-keystone | 20:44 | |
| *** fawadkhaliq has joined #openstack-keystone | 20:45 | |
| *** dave-mccowan has quit IRC | 20:51 | |
| *** browne has quit IRC | 20:51 | |
| openstackgerrit | Ron De Rose proposed openstack/keystone: Concrete role assignments for federated users https://review.openstack.org/284943 | 20:52 |
| *** jsavak has quit IRC | 20:53 | |
| *** browne has joined #openstack-keystone | 20:54 | |
| openstackgerrit | Merged openstack/keystone-specs: PCI-DSS v3.1 https://review.openstack.org/272396 | 20:54 |
| openstackgerrit | Merged openstack/keystone-specs: Shadow users: work item to relax mapping requirements https://review.openstack.org/299546 | 20:54 |
| *** ninag has quit IRC | 20:55 | |
| *** stevemar_ has joined #openstack-keystone | 20:56 | |
| *** knikolla has quit IRC | 20:56 | |
| *** topol_ has joined #openstack-keystone | 20:56 | |
| *** stevemar has quit IRC | 20:56 | |
| *** edmondsw has quit IRC | 21:00 | |
| *** mylu has quit IRC | 21:00 | |
| *** spzala has joined #openstack-keystone | 21:04 | |
| *** trown is now known as trown|outtypewww | 21:07 | |
| *** spzala has quit IRC | 21:09 | |
| *** spandhe has joined #openstack-keystone | 21:10 | |
| *** mylu has joined #openstack-keystone | 21:12 | |
| *** dflorea has joined #openstack-keystone | 21:14 | |
| *** pauloewerton has quit IRC | 21:14 | |
| *** david_cu has quit IRC | 21:15 | |
| *** david_cu has joined #openstack-keystone | 21:16 | |
| *** david_cu has quit IRC | 21:20 | |
| *** mylu has quit IRC | 21:23 | |
| *** gagehugo has left #openstack-keystone | 21:26 | |
| *** mylu has joined #openstack-keystone | 21:27 | |
| *** knikolla has joined #openstack-keystone | 21:28 | |
| *** sdake has joined #openstack-keystone | 21:30 | |
| *** diazjf has joined #openstack-keystone | 21:37 | |
| *** dflorea has quit IRC | 21:38 | |
| *** diazjf has quit IRC | 21:38 | |
| *** fawadkhaliq has quit IRC | 21:38 | |
| *** diazjf has joined #openstack-keystone | 21:39 | |
| *** fawadkhaliq has joined #openstack-keystone | 21:39 | |
| *** fawadkhaliq has quit IRC | 21:40 | |
| *** fawadkhaliq has joined #openstack-keystone | 21:41 | |
| *** dflorea has joined #openstack-keystone | 21:41 | |
| *** gagehugo has joined #openstack-keystone | 21:41 | |
| *** dflorea has quit IRC | 21:42 | |
| stevemar_ | morgan: feel free to recheck that backport until it's in | 21:42 |
| morgan | stevemar_: will do once i'm off the phone | 21:43 |
| morgan | stevemar_: yay almost RC time! | 21:43 |
| *** fawadkhaliq has quit IRC | 21:44 | |
| *** fawadkhaliq has joined #openstack-keystone | 21:44 | |
| *** dflorea has joined #openstack-keystone | 21:45 | |
| *** diazjf has quit IRC | 21:45 | |
| *** slberger has left #openstack-keystone | 21:45 | |
| *** gyee has quit IRC | 21:46 | |
| *** gyee has joined #openstack-keystone | 21:48 | |
| *** ChanServ sets mode: +v gyee | 21:48 | |
| *** gagehugo has quit IRC | 21:52 | |
| *** jaugustine has quit IRC | 21:55 | |
| *** mylu has quit IRC | 21:56 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 21:56 | |
| *** cdcasey has quit IRC | 22:04 | |
| *** ametts has quit IRC | 22:09 | |
| *** akanksha_ has joined #openstack-keystone | 22:10 | |
| *** dflorea has quit IRC | 22:18 | |
| *** dflorea has joined #openstack-keystone | 22:22 | |
| *** timcline has quit IRC | 22:27 | |
| *** timcline has joined #openstack-keystone | 22:28 | |
| *** timcline has quit IRC | 22:32 | |
| *** dflorea has quit IRC | 22:34 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Opportunistic LDAP testing https://review.openstack.org/300237 | 22:37 |
| morgan | bknudson: i think i'm going to propose a rewrite of our sql tests to work more like nova's | 22:37 |
| bknudson | morgan: the migration tests? | 22:37 |
| bknudson | that would be good. | 22:37 |
| morgan | bknudson: yeah | 22:37 |
| morgan | shouldn't be too hard to do. | 22:38 |
| bknudson | should be easier since they're based on oslo_db now. | 22:38 |
| morgan | the whole pre/post method and just step through is nice | 22:38 |
| morgan | yeah | 22:38 |
| bknudson | I looked at nova's tests when I was trying to figure out how to switch | 22:38 |
| morgan | it was a beast before for sure. | 22:38 |
| morgan | hm... the real question is... do i go grab a beer before tyring to code it | 22:38 |
| morgan | :P | 22:38 |
| bknudson | btw , https://review.openstack.org/300237 - works locally | 22:38 |
| morgan | bknudson: NICE | 22:38 |
| morgan | thats really awesome news. | 22:39 |
| bknudson | runs all the driver tests against my devstack openldap | 22:39 |
| bknudson | needs some cleanup of course | 22:39 |
| morgan | always does. | 22:39 |
| morgan | but fantastic news to have opportunistic ldap tests | 22:39 |
| stevemar_ | bknudson: that's amazeballs | 22:39 |
| *** dave-mccowan has joined #openstack-keystone | 22:40 | |
| morgan | yep, gonna go get a beer and a sammich | 22:40 |
| morgan | and i'm going to finally fix the ick that is our migration tests | 22:40 |
| morgan | cause after last night... | 22:40 |
| morgan | i don't want it easier to unwind things. | 22:40 |
| morgan | regardless of werid sql-a issues. | 22:41 |
| bknudson | nova still uses sqlalchemy, I think? | 22:41 |
| morgan | bknudson: yeah | 22:41 |
| bknudson | I didn't look to see if the oslo-db migration stuff works with sqlalchemy | 22:41 |
| morgan | bknudson: it should. | 22:41 |
| morgan | even if it doesn't, we can structure it to be similar | 22:42 |
| morgan | so when we move from sqla-migrate to alembic it's easy | 22:42 |
| bknudson | also, somehow my change to devstack to put keystone on a subpath is pretty much passing -- https://review.openstack.org/#/c/291950/8 | 22:43 |
| patchbot | bknudson: patch 291950 - keystone - Define identity interface - easy cases | 22:43 |
| bknudson | used to fail on grenade... maybe it was a fix for grenade support that did it. | 22:43 |
| bknudson | oops, wrong patch | 22:43 |
| morgan | hehe patchbot to the rescue! | 22:43 |
| bknudson | https://review.openstack.org/#/c/193894/ | 22:44 |
| patchbot | bknudson: patch 193894 - openstack-dev/devstack - Use path-mounted keystone when running in httpd | 22:44 |
| morgan | oh snap. stevemar_ did you see you can "quicklook" urls in os x? :P | 22:44 |
| morgan | bknudson: wow, magic. | 22:45 |
| *** ayoung has joined #openstack-keystone | 22:45 | |
| *** ChanServ sets mode: +v ayoung | 22:45 | |
| morgan | stevemar_: gonna hold this one up unless someone can really show me why we need a test that is python2 only - it seems like we're encoding thr wrong behavior if we're testing and py2 is the only place we use it ... or it does something else in py3 https://bugs.launchpad.net/keystoneauth/+bug/1534363 | 22:46 |
| openstack | Launchpad bug 1534363 in keystoneauth "message doesn't set properly on ClientException" [Medium,In progress] - Assigned to Tin Lam (tl3438) | 22:46 |
| bknudson | morgan: good move. none of that should depend on the python version. | 22:47 |
| morgan | bknudson: exactly | 22:47 |
| bknudson | it was just a mistake to try to assign to .message | 22:47 |
| morgan | bknudson: ++ | 22:47 |
| *** dave-mccowan has quit IRC | 22:50 | |
| *** dflorea has joined #openstack-keystone | 22:52 | |
| *** browne has quit IRC | 22:55 | |
| *** sdake has quit IRC | 22:57 | |
| *** dflorea has quit IRC | 22:57 | |
| *** timcline has joined #openstack-keystone | 22:58 | |
| *** browne has joined #openstack-keystone | 22:59 | |
| *** dflorea has joined #openstack-keystone | 23:04 | |
| *** dflorea has quit IRC | 23:07 | |
| *** timcline has quit IRC | 23:07 | |
| *** kfox1111_ is now known as kfox1111 | 23:08 | |
| stevemar_ | cmonnnnnn jenkins, don't fail me now!!!!!!!!!!!!!!!!!!!!!! | 23:09 |
| *** sdake has joined #openstack-keystone | 23:09 | |
| *** knikolla has quit IRC | 23:10 | |
| *** jorge_munoz has quit IRC | 23:11 | |
| *** sdake_ has joined #openstack-keystone | 23:12 | |
| *** sdake has quit IRC | 23:13 | |
| *** arunkant_ has quit IRC | 23:24 | |
| *** ayoung has quit IRC | 23:26 | |
| *** dflorea has joined #openstack-keystone | 23:28 | |
| *** dflorea has quit IRC | 23:30 | |
| *** gordc has quit IRC | 23:32 | |
| morgan | Jenkins...Jenkins...Jenkins... | 23:34 |
| *** dflorea has joined #openstack-keystone | 23:37 | |
| *** rk4n has quit IRC | 23:39 | |
| *** sdake_ has quit IRC | 23:43 | |
| stevemar_ | morgan: docs failed on the master branch | 23:44 |
| stevemar_ | ffs | 23:44 |
| morgan | w.t.f. | 23:44 |
| stevemar_ | i guess that is fine | 23:44 |
| stevemar_ | timeout | 23:44 |
| morgan | did stable one pass? | 23:44 |
| morgan | and is it gonna merge? | 23:44 |
| stevemar_ | morgan: its passing | 23:44 |
| stevemar_ | heading out for a little | 23:44 |
| morgan | cause we can recheck mastet from here until infiniti | 23:44 |
| stevemar_ | dinner | 23:44 |
| morgan | i don't see that changing | 23:44 |
| *** phalmos has quit IRC | 23:46 | |
| *** knikolla has joined #openstack-keystone | 23:53 | |
| *** rderose has quit IRC | 23:58 | |
| *** lhcheng has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!