| *** fpatwa_ has quit IRC | 00:07 | |
| *** furface has quit IRC | 00:08 | |
| *** furface has joined #openstack-keystone | 00:23 | |
| *** itlinux has joined #openstack-keystone | 00:36 | |
| *** itlinux has quit IRC | 00:39 | |
| *** itlinux has joined #openstack-keystone | 00:44 | |
| *** itlinux has quit IRC | 00:45 | |
| *** spzala has joined #openstack-keystone | 00:48 | |
| *** itlinux has joined #openstack-keystone | 00:49 | |
| *** itlinux has quit IRC | 00:58 | |
| *** itlinux has joined #openstack-keystone | 01:19 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP: Specify resource driver interface https://review.openstack.org/289058 | 01:20 |
|---|---|---|
| *** EinstCrazy has joined #openstack-keystone | 01:21 | |
| *** dims has quit IRC | 01:26 | |
| *** sdake has joined #openstack-keystone | 01:37 | |
| *** itlinux has quit IRC | 01:37 | |
| *** itlinux has joined #openstack-keystone | 01:42 | |
| *** markvoelker has quit IRC | 01:43 | |
| *** sdake_ has joined #openstack-keystone | 01:44 | |
| *** sdake has quit IRC | 01:44 | |
| *** itlinux has quit IRC | 01:44 | |
| *** wxy has joined #openstack-keystone | 01:51 | |
| *** sdake has joined #openstack-keystone | 01:52 | |
| *** sdake_ has quit IRC | 01:55 | |
| *** sdake has quit IRC | 01:57 | |
| *** fpatwa_ has joined #openstack-keystone | 01:59 | |
| *** fpatwa_ has quit IRC | 02:06 | |
| *** spzala_ has joined #openstack-keystone | 02:15 | |
| *** spzala has quit IRC | 02:17 | |
| *** itlinux has joined #openstack-keystone | 02:20 | |
| *** spzala_ has quit IRC | 02:25 | |
| *** spzala has joined #openstack-keystone | 02:25 | |
| *** spzala has quit IRC | 02:30 | |
| *** sdake has joined #openstack-keystone | 02:33 | |
| *** spzala has joined #openstack-keystone | 02:38 | |
| *** sdake has quit IRC | 02:40 | |
| *** spzala has quit IRC | 02:43 | |
| *** chlong has joined #openstack-keystone | 02:45 | |
| *** itlinux has quit IRC | 02:55 | |
| *** sheel has joined #openstack-keystone | 02:56 | |
| openstackgerrit | Jamie Lennox proposed openstack/keystone: Add identity endpoint creation to bootstrap https://review.openstack.org/285102 | 02:59 |
| *** EinstCrazy has quit IRC | 03:00 | |
| *** roxanaghe has joined #openstack-keystone | 03:03 | |
| alex_xu | stevemar: Hi, I just got a message about Dave Chen, he fall down in the room and break his leg. So he won't be available for a while. | 03:04 |
| *** roxanaghe has quit IRC | 03:15 | |
| *** spzala has joined #openstack-keystone | 03:15 | |
| morgan | alex_xu: oh no! Not good. Hope he recovers quickly. | 03:17 |
| *** fpatwa_ has joined #openstack-keystone | 03:46 | |
| *** spandhe has joined #openstack-keystone | 03:50 | |
| *** sdake has joined #openstack-keystone | 03:51 | |
| *** sdake has quit IRC | 03:52 | |
| *** sdake has joined #openstack-keystone | 03:54 | |
| *** ayoung has quit IRC | 03:54 | |
| *** spzala has quit IRC | 04:02 | |
| *** spzala has joined #openstack-keystone | 04:02 | |
| *** spzala has quit IRC | 04:03 | |
| *** nisha has joined #openstack-keystone | 04:10 | |
| *** sdake has quit IRC | 04:11 | |
| *** sdake has joined #openstack-keystone | 04:12 | |
| *** links has joined #openstack-keystone | 04:15 | |
| *** sdake has quit IRC | 04:21 | |
| *** fpatwa_ has quit IRC | 04:22 | |
| *** roxanaghe has joined #openstack-keystone | 04:29 | |
| *** roxanaghe has quit IRC | 04:31 | |
| *** roxanaghe has joined #openstack-keystone | 04:34 | |
| *** roxanaghe has quit IRC | 04:39 | |
| *** Nirupama has joined #openstack-keystone | 04:43 | |
| *** itlinux has joined #openstack-keystone | 04:46 | |
| *** sheel has quit IRC | 04:57 | |
| *** EinstCrazy has joined #openstack-keystone | 04:58 | |
| *** fpatwa_ has joined #openstack-keystone | 05:00 | |
| *** fpatwa_ has quit IRC | 05:03 | |
| *** fangxu has joined #openstack-keystone | 05:07 | |
| *** chlong has quit IRC | 05:12 | |
| *** roxanaghe has joined #openstack-keystone | 05:25 | |
| *** chlong has joined #openstack-keystone | 05:29 | |
| *** itlinux has quit IRC | 05:32 | |
| *** fpatwa_ has joined #openstack-keystone | 05:36 | |
| *** jaosorior has joined #openstack-keystone | 05:43 | |
| *** roxanaghe has quit IRC | 05:43 | |
| *** rcernin has joined #openstack-keystone | 05:47 | |
| *** furface has quit IRC | 05:54 | |
| *** furface has joined #openstack-keystone | 05:56 | |
| *** rcernin has quit IRC | 05:57 | |
| *** spandhe has quit IRC | 06:00 | |
| *** spandhe has joined #openstack-keystone | 06:02 | |
| *** fpatwa_ has quit IRC | 06:03 | |
| *** EinstCrazy has quit IRC | 06:06 | |
| nisha | Hi, anyone around? | 06:08 |
| *** kiran-r has joined #openstack-keystone | 06:11 | |
| *** lhcheng_ has joined #openstack-keystone | 06:12 | |
| *** fangxu has quit IRC | 06:13 | |
| *** lhcheng has quit IRC | 06:14 | |
| *** lhcheng_ has quit IRC | 06:17 | |
| *** lhcheng has joined #openstack-keystone | 06:17 | |
| *** ChanServ sets mode: +v lhcheng | 06:17 | |
| alex_xu | morgan: yea, hope he recovers quickly too | 06:24 |
| *** dave-mccowan has quit IRC | 06:31 | |
| openstackgerrit | Maho Koshiya proposed openstack/python-keystoneclient: Add wrapper classes for return-request-id-to-caller https://review.openstack.org/261188 | 06:52 |
| *** spandhe has quit IRC | 07:06 | |
| -openstackstatus- NOTICE: gerrit is going to be restarted due to bad performance | 07:23 | |
| *** ChanServ changes topic to "gerrit is going to be restarted due to bad performance" | 07:23 | |
| *** ChanServ changes topic to "mitaka-3 done, no more features (you missed your chance) until Newton | Tag bugs as rc-potential - fix more bugs! | https://launchpad.net/keystone/+milestone/mitaka-rc1" | 07:27 | |
| *** chlong has quit IRC | 07:30 | |
| *** sdake has joined #openstack-keystone | 07:33 | |
| *** belmoreira has joined #openstack-keystone | 07:40 | |
| *** pece has joined #openstack-keystone | 07:48 | |
| *** jed56 has joined #openstack-keystone | 07:53 | |
| nisha | Hey, can anyone please help me in solving this bug | 07:56 |
| nisha | https://bugs.launchpad.net/openstack-manuals/+bug/1517737 | 07:56 |
| openstack | Launchpad bug 1517737 in openstack-manuals " Move endpoint filter into keystone core" [Low,Confirmed] - Assigned to Nisha Yadav (ynisha11) | 07:56 |
| nisha | Would be grateful for any pointers to help me get started. | 07:57 |
| *** lhcheng has quit IRC | 08:06 | |
| *** bjornar has quit IRC | 08:07 | |
| *** rk4n has joined #openstack-keystone | 08:14 | |
| *** sdake has quit IRC | 08:21 | |
| *** pcaruana has joined #openstack-keystone | 08:25 | |
| *** daemontool_ has joined #openstack-keystone | 08:43 | |
| *** rk4n has quit IRC | 08:45 | |
| *** daemontool has quit IRC | 08:47 | |
| *** rk4n has joined #openstack-keystone | 08:50 | |
| *** rk4n has joined #openstack-keystone | 08:53 | |
| *** rk4n has quit IRC | 08:56 | |
| *** __zouyee has quit IRC | 08:56 | |
| *** jaosorior has quit IRC | 09:00 | |
| *** jaosorior has joined #openstack-keystone | 09:00 | |
| *** palexster has joined #openstack-keystone | 09:16 | |
| *** __zouyee has joined #openstack-keystone | 09:21 | |
| *** tomoiaga2 has joined #openstack-keystone | 09:26 | |
| *** jistr has joined #openstack-keystone | 09:33 | |
| stevemar | alex_xu: oh no! that's terrible | 09:36 |
| stevemar | alex_xu: i'll email him, please tell him to take his time and heal safely. no need to rush into keystone work. | 09:37 |
| *** mhickey has joined #openstack-keystone | 09:37 | |
| *** rk4n has joined #openstack-keystone | 10:01 | |
| *** fangxu has joined #openstack-keystone | 10:10 | |
| *** fangxu has quit IRC | 10:13 | |
| *** fangxu has joined #openstack-keystone | 10:14 | |
| *** e0ne has joined #openstack-keystone | 10:15 | |
| *** daemontool_ has quit IRC | 10:16 | |
| *** __zouyee has quit IRC | 10:20 | |
| *** mdavidson has quit IRC | 10:20 | |
| *** fangxu has quit IRC | 10:22 | |
| *** daemontool has joined #openstack-keystone | 10:35 | |
| *** dims_ has joined #openstack-keystone | 10:41 | |
| *** chlong has joined #openstack-keystone | 10:46 | |
| *** permalac has joined #openstack-keystone | 10:47 | |
| *** nisha has quit IRC | 10:51 | |
| *** nisha has joined #openstack-keystone | 10:52 | |
| nisha | hi samueldmq stevemar :) | 10:53 |
| nisha | I have been trying to get familiar with this bug during the BugSmash | 10:54 |
| nisha | https://bugs.launchpad.net/openstack-manuals/+bug/1517737 | 10:54 |
| openstack | Launchpad bug 1517737 in openstack-manuals " Move endpoint filter into keystone core" [Low,Confirmed] - Assigned to Nisha Yadav (ynisha11) | 10:54 |
| nisha | Can you please help me a bit? | 10:54 |
| *** mdavidson has joined #openstack-keystone | 10:54 | |
| samueldmq | nisha: hi | 10:56 |
| *** hogepodge has quit IRC | 10:56 | |
| nisha | Does this sentence "DocImpact: Remove the endpoint_filter extension from keystone's paste pipeline" written in the bug description imply editing here http://docs.openstack.org/liberty/config-reference/content/section_keystone-paste.ini.html | 10:57 |
| samueldmq | nisha: that is a documentation bug | 10:57 |
| *** Nirupama has quit IRC | 11:01 | |
| nisha | samueldmq: anything I can read to learn and fix it ? Is it good to work on as of now, or should i prefer anything else over it? | 11:01 |
| samueldmq | nisha: you may fix it | 11:03 |
| samueldmq | nisha: in the bug description there is a comment saying what docs are affected https://bugs.launchpad.net/openstack-manuals/+bug/1517737 | 11:04 |
| openstack | Launchpad bug 1517737 in openstack-manuals " Move endpoint filter into keystone core" [Low,Confirmed] - Assigned to Nisha Yadav (ynisha11) | 11:04 |
| samueldmq | nisha: first comment theere. what you need to know is to see where is the source of those docs, and then fix it | 11:04 |
| nisha | samueldmq: so, I need to ask this as comment and wait for someone to reply there itself? | 11:06 |
| samueldmq | nisha: hmm, actually lots of things are no more extensions, so possibly that bug apply to other thing stoo | 11:06 |
| samueldmq | nisha: no, let me help you to find it | 11:06 |
| *** e0ne has quit IRC | 11:06 | |
| samueldmq | nisha: (asking as a comment may take a long time) | 11:06 |
| *** e0ne has joined #openstack-keystone | 11:06 | |
| nisha | sure, thanks for helping | 11:07 |
| *** dims_ has quit IRC | 11:09 | |
| samueldmq | nisha: okay, so 1) we need to figure out how to fix the bug | 11:10 |
| samueldmq | nisha: then 2) find the right repo from where the docs are built from and fix it | 11:10 |
| samueldmq | nisha: you agree? | 11:11 |
| nisha | yeah, completely :) | 11:11 |
| samueldmq | nisha: for 1 I'd like to check with stevemar and others, I think that documentation isn't just necessary anymore (remove it) | 11:12 |
| samueldmq | nisha: for 2), can you join #openstack-doc ? | 11:13 |
| nisha | samueldmq: sure, joining it | 11:13 |
| *** Nirupama has joined #openstack-keystone | 11:19 | |
| *** dims_ has joined #openstack-keystone | 11:22 | |
| *** chlong has quit IRC | 11:29 | |
| samueldmq | does anyone know where is the source of http://docs.openstack.org/developer/keystone/extensions/endpoint_policy.html ? | 11:33 |
| samueldmq | it is now invalid since endpoint_policy is enabled by default | 11:33 |
| *** hogepodge has joined #openstack-keystone | 11:34 | |
| dims_ | samueldmq : got yanked out i believe - https://review.openstack.org/#/c/247900/ | 11:39 |
| patchbot | dims_: patch 247900 - keystone - Update docs for legacy keystone extensions (MERGED) | 11:39 |
| *** wxy has quit IRC | 11:39 | |
| samueldmq | dims_: yes, you're correct | 11:41 |
| samueldmq | dims_: thanks | 11:41 |
| samueldmq | nisha: so look at this review ^ | 11:41 |
| samueldmq | nisha: the docs have already been removed too :) | 11:41 |
| nisha | samueldmq: does that been they also have been fixed ? | 11:42 |
| samueldmq | nisha: yes, but there is still something you can do | 11:42 |
| nisha | it says merged | 11:43 |
| nisha | oh, yeah please | 11:43 |
| *** chlong has joined #openstack-keystone | 11:43 | |
| samueldmq | nisha: leave as comment in that bug saying both links have been fixed | 11:43 |
| samueldmq | nisha: one gets the source of https://git.openstack.org/cgit/openstack/keystone/plain/etc/keystone-paste.ini which is updated | 11:44 |
| samueldmq | nisha: and the other was invalid and removed in patch https://review.openstack.org/#/c/247900/ | 11:44 |
| patchbot | samueldmq: patch 247900 - keystone - Update docs for legacy keystone extensions (MERGED) | 11:44 |
| nisha | sure, will do that ! | 11:45 |
| samueldmq | nisha: then change the bug status from Confirmed to Fix Commited :) | 11:46 |
| *** dave-mccowan has joined #openstack-keystone | 12:01 | |
| * morgan thinks ayoung should invest in an IRC bouncer | 12:04 | |
| *** fpatwa_ has joined #openstack-keystone | 12:06 | |
| openstackgerrit | Henrique Truta proposed openstack/python-keystoneclient: Adds is_domain field in create project https://review.openstack.org/239832 | 12:07 |
| *** raildo-afk is now known as raildo | 12:10 | |
| *** trown|outtypewww is now known as trown | 12:12 | |
| *** rodrigods has quit IRC | 12:14 | |
| *** rodrigods has joined #openstack-keystone | 12:15 | |
| *** EinstCrazy has joined #openstack-keystone | 12:21 | |
| *** shangxdy has joined #openstack-keystone | 12:22 | |
| *** josecastroleon has joined #openstack-keystone | 12:22 | |
| *** fpatwa_ has quit IRC | 12:25 | |
| nisha | Thanks a lot for help samueldmq ! | 12:26 |
| nisha | samueldmq: So, I wrote out the comment here, just to be sure once again. http://paste.openstack.org/show/489528/ | 12:27 |
| nisha | Can you please have a final look, if you have some time? | 12:27 |
| *** Nirupama has quit IRC | 12:28 | |
| *** gordc has joined #openstack-keystone | 12:32 | |
| *** nisha has quit IRC | 12:38 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: DO NOT REVIEW: WIP: Add users functional tests https://review.openstack.org/289306 | 12:41 |
| samueldmq | nisha, sure | 12:41 |
| *** EinstCrazy has quit IRC | 12:43 | |
| *** EinstCrazy has joined #openstack-keystone | 12:45 | |
| morgan | . | 13:01 |
| openstackgerrit | Srushti Gadadare proposed openstack/keystone: Provide user friendly messages for db_sync https://review.openstack.org/289316 | 13:05 |
| morgan | Zzzzzzzzzz | 13:09 |
| * samueldmq waves at morgan | 13:13 | |
| morgan | Oh hai | 13:14 |
| samueldmq | / | 13:14 |
| samueldmq | o/ | 13:14 |
| *** dims_ has quit IRC | 13:25 | |
| dstanek | morgan: irc bouncers are a gateway drug | 13:25 |
| morgan | dstanek: I know, rite!? | 13:27 |
| *** links has quit IRC | 13:28 | |
| *** EinstCrazy has quit IRC | 13:28 | |
| *** iurygregory has joined #openstack-keystone | 13:28 | |
| *** edmondsw has joined #openstack-keystone | 13:29 | |
| morgan | topol: http://www.firebox.com/product/4346/Blade-Runner-Whiskey-Glass since you're into nostalgic things like video games from pixels... | 13:29 |
| morgan | Also #thisiswhyimbroke | 13:29 |
| *** EinstCrazy has joined #openstack-keystone | 13:31 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/python-keystoneclient: DO NOT REVIEW: WIP: Add users functional tests https://review.openstack.org/289306 | 13:33 |
| *** ninag has joined #openstack-keystone | 13:45 | |
| *** sheel has joined #openstack-keystone | 13:46 | |
| *** EinstCrazy has quit IRC | 13:50 | |
| *** EinstCrazy has joined #openstack-keystone | 13:51 | |
| *** pauloewerton has joined #openstack-keystone | 13:54 | |
| *** sdake has joined #openstack-keystone | 13:57 | |
| *** kiran-r has quit IRC | 13:58 | |
| *** e0ne has quit IRC | 13:58 | |
| *** e0ne has joined #openstack-keystone | 14:00 | |
| *** bjornar has joined #openstack-keystone | 14:03 | |
| *** petertr7_away is now known as petertr7 | 14:09 | |
| *** jaugustine has joined #openstack-keystone | 14:11 | |
| *** boris-42 has joined #openstack-keystone | 14:12 | |
| *** woodster_ has joined #openstack-keystone | 14:12 | |
| *** knikolla has joined #openstack-keystone | 14:17 | |
| *** shangxdy has quit IRC | 14:17 | |
| *** shangxdy has joined #openstack-keystone | 14:17 | |
| *** richm has joined #openstack-keystone | 14:18 | |
| *** anush has joined #openstack-keystone | 14:23 | |
| *** markvoelker has joined #openstack-keystone | 14:28 | |
| *** jaosorior is now known as jaosorior_climbi | 14:32 | |
| *** markvoelker has quit IRC | 14:33 | |
| * stevemar is on UTC+1 TZ this week | 14:33 | |
| *** Ephur has joined #openstack-keystone | 14:33 | |
| *** spzala has joined #openstack-keystone | 14:37 | |
| *** markvoelker has joined #openstack-keystone | 14:37 | |
| *** markvoelker_ has joined #openstack-keystone | 14:44 | |
| *** markvoelker has quit IRC | 14:47 | |
| *** nisha_ has joined #openstack-keystone | 14:49 | |
| morgan | stevemar: lies! :P | 14:52 |
| stevemar | no lies! | 14:52 |
| morgan | Eat lots of French food. | 14:53 |
| *** dims has joined #openstack-keystone | 14:54 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 14:56 | |
| *** bjornar has quit IRC | 15:00 | |
| *** ayoung has joined #openstack-keystone | 15:03 | |
| *** ChanServ sets mode: +v ayoung | 15:03 | |
| *** itlinux has joined #openstack-keystone | 15:09 | |
| *** itlinux has quit IRC | 15:11 | |
| *** markvoelker_ has quit IRC | 15:13 | |
| *** markvoelker has joined #openstack-keystone | 15:13 | |
| *** markvoelker has quit IRC | 15:14 | |
| *** markvoelker has joined #openstack-keystone | 15:14 | |
| *** markvoelker has quit IRC | 15:18 | |
| *** markvoelker has joined #openstack-keystone | 15:19 | |
| *** markvoelker has quit IRC | 15:19 | |
| *** EinstCrazy has quit IRC | 15:25 | |
| *** sdake_ has joined #openstack-keystone | 15:25 | |
| *** sdake has quit IRC | 15:29 | |
| bknudson | french fries, french toast | 15:31 |
| *** shangxdy has quit IRC | 15:32 | |
| *** slberger has joined #openstack-keystone | 15:38 | |
| *** markus_z has joined #openstack-keystone | 15:43 | |
| markus_z | Can anyone have a look at https://review.openstack.org/#/c/288513/1 please? "keystoneauth" uses its own config options (not oslo.config) which prevents the correct generation of the "sample.nova.conf" file. | 15:46 |
| patchbot | markus_z: patch 288513 - nova - Fix config generation for Neutron auth options | 15:46 |
| *** kiran-r has joined #openstack-keystone | 15:49 | |
| *** anush has quit IRC | 15:57 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 15:57 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:57 | |
| *** nisha_ has quit IRC | 15:58 | |
| *** ericksonsantos has joined #openstack-keystone | 15:59 | |
| *** nisha has joined #openstack-keystone | 15:59 | |
| *** anush has joined #openstack-keystone | 16:01 | |
| *** belmoreira has quit IRC | 16:01 | |
| lbragstad | is anyone here participating in the bugmash? | 16:05 |
| *** simondodsley has joined #openstack-keystone | 16:08 | |
| *** phalmos has joined #openstack-keystone | 16:08 | |
| nisha | hey lbragstad | 16:08 |
| nisha | yes, I am participating, in Banglore, India | 16:09 |
| lbragstad | nisha o/ | 16:09 |
| *** slberger1 has joined #openstack-keystone | 16:10 | |
| *** slberger has quit IRC | 16:10 | |
| lbragstad | I have two patches up that close a bug if anyone's itching to do a review - https://review.openstack.org/#/q/topic:bug/1552639 | 16:10 |
| lbragstad | which closes - https://launchpad.net/bugs/1552639 | 16:11 |
| openstack | Launchpad bug 1552639 in OpenStack Identity (keystone) "Keystone doesn't send notification on user/group membership" [Low,In progress] - Assigned to Lance Bragstad (lbragstad) | 16:11 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove unused notification method and class https://review.openstack.org/288799 | 16:12 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Consolidate @notifications.internal into Audit https://review.openstack.org/288798 | 16:12 |
| nisha | lbragstad, I don't have much experience but would have a look :) | 16:12 |
| lbragstad | nisha thanks! | 16:12 |
| lbragstad | nisha all reviews are helpful | 16:13 |
| nisha | :) | 16:14 |
| *** permalac has quit IRC | 16:14 | |
| frickler | mordred: https://review.openstack.org/287754 is a clone of your earlier username vs. user-name patch, maybe you want to take a look at this one, too | 16:18 |
| *** EinstCrazy has joined #openstack-keystone | 16:22 | |
| samueldmq | nisha: cool, that's a great way to help moving (reviewing) | 16:23 |
| nisha | samueldmq, you had encouraged me before also for reviewing, so, working on it :) | 16:24 |
| *** phalmos has quit IRC | 16:27 | |
| *** jaosorior_climbi is now known as jaosorior | 16:29 | |
| *** jasonsb_ has quit IRC | 16:32 | |
| *** sdake_ is now known as sdake | 16:35 | |
| *** clenimar has joined #openstack-keystone | 16:38 | |
| *** roxanaghe has joined #openstack-keystone | 16:39 | |
| *** tomoiaga2 has quit IRC | 16:39 | |
| *** tomoiaga has joined #openstack-keystone | 16:40 | |
| *** tomoiaga has quit IRC | 16:40 | |
| *** nisha has quit IRC | 16:42 | |
| *** nisha has joined #openstack-keystone | 16:45 | |
| *** david_lyle has quit IRC | 16:46 | |
| *** david_lyle has joined #openstack-keystone | 16:46 | |
| mordred | frickler: looks great, thanks | 16:48 |
| *** e0ne has quit IRC | 16:49 | |
| *** mvk has quit IRC | 16:51 | |
| *** EinstCrazy has quit IRC | 16:55 | |
| *** jaosorior has quit IRC | 17:00 | |
| *** jaosorior has joined #openstack-keystone | 17:00 | |
| *** mhickey has quit IRC | 17:04 | |
| *** browne has joined #openstack-keystone | 17:04 | |
| *** anush has quit IRC | 17:05 | |
| *** petertr7 is now known as petertr7_away | 17:05 | |
| *** trown is now known as trown|lunch | 17:05 | |
| dstanek | lbragstad: did you see my comment of your review | 17:06 |
| lbragstad | dstanek checking | 17:06 |
| *** knikolla has quit IRC | 17:09 | |
| *** dan_nguyen has joined #openstack-keystone | 17:10 | |
| lbragstad | dstanek good catch - i'll have to check the code but do we notify on failure and success? | 17:10 |
| lbragstad | and is that true for both "basic" and "cadf" notifications? | 17:10 |
| *** fawadkhaliq has joined #openstack-keystone | 17:11 | |
| dstanek | lbragstad: it looks the the class you deleted in the second review show that a notification is sent if the operation is successful and nothing if it fails | 17:12 |
| *** petertr7_away is now known as petertr7 | 17:12 | |
| *** nisha_ has joined #openstack-keystone | 17:12 | |
| dstanek | lbragstad: so i think that you can just move the new line after 314. and add a comment | 17:13 |
| *** nisha has quit IRC | 17:13 | |
| lbragstad | dstanek makes sense - I'll get a second revision posted. Working on fixing all the issues with https://review.openstack.org/#/c/288643/ | 17:14 |
| patchbot | lbragstad: patch 288643 - keystone - Send notifications with entity name in payload | 17:14 |
| *** pece has quit IRC | 17:18 | |
| *** spandhe has joined #openstack-keystone | 17:23 | |
| *** nisha_ has quit IRC | 17:24 | |
| *** gyee has joined #openstack-keystone | 17:25 | |
| *** ChanServ sets mode: +v gyee | 17:25 | |
| lbragstad | dstanek how does this magic work? https://github.com/openstack/keystone/blob/master/keystone/identity/core.py#L1121-L1133 | 17:27 |
| lbragstad | and example of `user_project` is {'project_id': u'a1a51ff287ad4fe39f6332e792d1c572', 'user_id': u'0efc20ba3d79440e96698a4d2fcc2988'} | 17:27 |
| dstanek | lbragstad: what do you mean? since that method does nothing the only thing that happens is the notification | 17:29 |
| lbragstad | dstanek correct - but the `user_project` variable is a dictionary | 17:31 |
| lbragstad | but it doesn't look like https://github.com/openstack/keystone/blob/master/keystone/notifications.py#L165 does anything with the data inside? | 17:31 |
| *** trown|lunch is now known as trown | 17:33 | |
| dstanek | lbragstad: yeah, it looks odd. it looks like it would use that dictionary as the resource_id | 17:33 |
| dstanek | lbragstad: i'm wondering it that's a bug | 17:33 |
| openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Adding authentication comaptibiliy for OpenStackClient https://review.openstack.org/289472 | 17:34 |
| lbragstad | dstanek the comment makes it seem like it's an overloaded decorator? (which is even more confusing) | 17:35 |
| *** sdake_ has joined #openstack-keystone | 17:35 | |
| lbragstad | dstanek it came from https://github.com/openstack/keystone/commit/2cf743d6de3afcb1a0aa3d4c219b3c4bcea29008 | 17:37 |
| *** jasonsb has joined #openstack-keystone | 17:38 | |
| *** sdake has quit IRC | 17:38 | |
| dstanek | lbragstad: seems like it would be a bug, but amakarov would have to say for sure | 17:39 |
| *** jaosorior has quit IRC | 17:41 | |
| *** jaosorior has joined #openstack-keystone | 17:42 | |
| *** jaosorior has quit IRC | 17:46 | |
| openstackgerrit | Cristian Sava proposed openstack/keystone: Customize config file location when run as wsgi app. https://review.openstack.org/288216 | 17:48 |
| *** jorge_munoz has joined #openstack-keystone | 17:52 | |
| *** EinstCrazy has joined #openstack-keystone | 17:53 | |
| *** jorge_munoz_ has joined #openstack-keystone | 17:57 | |
| *** petertr7 is now known as petertr7_away | 17:57 | |
| *** jorge_munoz has quit IRC | 17:59 | |
| *** jorge_munoz_ is now known as jorge_munoz | 17:59 | |
| *** fawadkhaliq has quit IRC | 17:59 | |
| *** fawadkhaliq has joined #openstack-keystone | 18:00 | |
| *** anush has joined #openstack-keystone | 18:01 | |
| *** EinstCrazy has quit IRC | 18:02 | |
| gyee | stevemar, dhellmann, can we backport this patch to stable\liberty? https://review.openstack.org/#/c/282886 | 18:04 |
| gyee | still getting index out of bound if we happen to stumbled upon a bad version of cliff | 18:04 |
| dhellmann | gyee : that seems reasonable | 18:05 |
| dhellmann | (backporting does, not getting the error :-) | 18:05 |
| *** dave-mccowan has quit IRC | 18:05 | |
| gyee | dhellmann, thanks, let me push a patch | 18:05 |
| *** ayoung has quit IRC | 18:06 | |
| *** doug-fish has quit IRC | 18:07 | |
| dstanek | stevemar: will all of the revocation changes is https://bugs.launchpad.net/keystone/+bug/1291157 still important? the patches are super out of date | 18:07 |
| openstack | Launchpad bug 1291157 in OpenStack Identity (keystone) "idp deletion should trigger token revocation" [Medium,Confirmed] | 18:07 |
| *** kiran-r has quit IRC | 18:08 | |
| *** doug-fish has joined #openstack-keystone | 18:08 | |
| *** david_cu_ has joined #openstack-keystone | 18:08 | |
| lbragstad | morgan around? | 18:08 |
| *** jasonsb has quit IRC | 18:10 | |
| *** markvoelker has joined #openstack-keystone | 18:10 | |
| *** harlowja has joined #openstack-keystone | 18:11 | |
| *** doug-fish has quit IRC | 18:13 | |
| *** markvoelker has quit IRC | 18:13 | |
| *** markvoelker has joined #openstack-keystone | 18:13 | |
| stevemar | dstanek: probably not | 18:14 |
| arunkant | dhellman, gyee: Can backport (s) be added to all client libraries which uses cliff as its going to impact all of them. I saw this error with barbicanclient stable/liberty version as well. | 18:16 |
| *** sdake_ has quit IRC | 18:17 | |
| *** lhcheng has joined #openstack-keystone | 18:17 | |
| *** ChanServ sets mode: +v lhcheng | 18:17 | |
| gyee | arunkant, it will be taken care of by proposal bot I think | 18:17 |
| *** lhcheng has quit IRC | 18:17 | |
| *** lhcheng has joined #openstack-keystone | 18:18 | |
| *** ChanServ sets mode: +v lhcheng | 18:18 | |
| arunkant | gyee: I just saw the patch..so its going to be applied to all client libraries..great | 18:18 |
| stevemar | gyee: propose it! | 18:20 |
| *** lhcheng has quit IRC | 18:21 | |
| *** jorge_munoz has quit IRC | 18:22 | |
| dstanek | stevemar: do you think it would be marked as invalid for now? or keep it around? | 18:22 |
| *** rk4n has quit IRC | 18:23 | |
| *** lhcheng has joined #openstack-keystone | 18:23 | |
| *** ChanServ sets mode: +v lhcheng | 18:23 | |
| stevemar | dstanek: at minimum change it to low | 18:26 |
| *** doug-fish has joined #openstack-keystone | 18:27 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Send notifications with entity name in payload https://review.openstack.org/288643 | 18:28 |
| lbragstad | dstanek giving up on ^ for now - going to address your other comments | 18:28 |
| openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Adding authentication compatibility for OpenStackClient https://review.openstack.org/289472 | 18:29 |
| *** fangxu has joined #openstack-keystone | 18:37 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 18:37 | |
| *** ankita_wagh has joined #openstack-keystone | 18:39 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Consolidate @notifications.internal into Audit https://review.openstack.org/288798 | 18:40 |
| *** jistr has quit IRC | 18:41 | |
| *** anush has quit IRC | 18:47 | |
| *** petertr7_away is now known as petertr7 | 18:48 | |
| dstanek | lbragstad: are you having an issue with that one? | 18:50 |
| *** markvoelker has quit IRC | 18:51 | |
| *** spzala has quit IRC | 18:52 | |
| *** spzala has joined #openstack-keystone | 18:52 | |
| *** bjornar has joined #openstack-keystone | 18:56 | |
| *** spzala has quit IRC | 18:57 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 18:57 | |
| *** spzala has joined #openstack-keystone | 18:58 | |
| *** browne has quit IRC | 18:59 | |
| *** doug-fis_ has joined #openstack-keystone | 19:03 | |
| *** petertr7 is now known as petertr7_away | 19:04 | |
| *** doug-fi__ has joined #openstack-keystone | 19:04 | |
| *** doug-f___ has joined #openstack-keystone | 19:05 | |
| *** doug-fish has quit IRC | 19:06 | |
| *** doug-fish has joined #openstack-keystone | 19:06 | |
| *** doug-fis_ has quit IRC | 19:08 | |
| *** doug-fi__ has quit IRC | 19:09 | |
| *** doug-f___ has quit IRC | 19:10 | |
| *** phalmos has joined #openstack-keystone | 19:15 | |
| *** gordc has quit IRC | 19:16 | |
| openstackgerrit | Raildo Mascena proposed openstack/keystone: [WIP]Make fernet default token provider https://review.openstack.org/258650 | 19:17 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove unused notification method and class https://review.openstack.org/288799 | 19:18 |
| raildo | lbragstad: ^fixes a couple of tests, and new errors due rebase :( I'll keep working on it | 19:19 |
| openstackgerrit | Trevor McCasland proposed openstack/keystone: Change max size validation parameters https://review.openstack.org/285393 | 19:20 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Send notifications with entity name in payload https://review.openstack.org/288643 | 19:24 |
| lbragstad | dstanek yeah - I was trying to figure out that whole invalidate token magic decorator logic | 19:25 |
| *** browne has joined #openstack-keystone | 19:25 | |
| lbragstad | because since I'm changing the payload from a string to a dictionary it requires us to send notifications differently | 19:25 |
| *** sdake has joined #openstack-keystone | 19:31 | |
| *** anush has joined #openstack-keystone | 19:31 | |
| *** shaleh has joined #openstack-keystone | 19:33 | |
| *** browne has quit IRC | 19:37 | |
| *** doug-fish has quit IRC | 19:38 | |
| *** jaugustine has quit IRC | 19:38 | |
| *** browne has joined #openstack-keystone | 19:42 | |
| shaleh | dstanek: thanks for catching that 'fixed release' bug in the review. I looked at a bunch and somehow missed that one. | 19:43 |
| dstanek | shaleh: my pleasure | 19:43 |
| shaleh | dstanek: the joys of many twisty paths that all look alike | 19:44 |
| *** fangxu has quit IRC | 19:44 | |
| shaleh | dstanek: morgan marked it fixed, but the review linked is the one I updated. | 19:45 |
| shaleh | dstanek: I just missed the duplicate part. | 19:46 |
| shaleh | Some days I really dislike launchpad. | 19:46 |
| *** jaugustine has joined #openstack-keystone | 19:47 | |
| shaleh | dstanek: how do I update the review so I can abandon it? Failing that, how do i ask for it to be abandoned? | 19:47 |
| dstanek | shaleh: i can abandon | 19:47 |
| dstanek | shaleh: do you have a link :-) i looked at a bunch today | 19:48 |
| shaleh | dstanek: yeah, one sec | 19:48 |
| shaleh | dstanek: https://review.openstack.org/#/c/137778 | 19:48 |
| *** browne has quit IRC | 19:50 | |
| *** doug-fish has joined #openstack-keystone | 19:53 | |
| dstanek | shaleh: done, thx | 19:53 |
| shaleh | dstanek: take one down, pass it around, 3 more bugs on the wall | 19:54 |
| dstanek | shaleh: getting down to three is a good goal for this week :-) | 19:54 |
| shaleh | :-) | 19:54 |
| dstanek | where is everyone today? so quiet in here | 19:57 |
| *** gchung has joined #openstack-keystone | 19:58 | |
| *** gchung is now known as gordc | 19:58 | |
| *** maxabidi has joined #openstack-keystone | 19:58 | |
| shaleh | dstanek: I was wondering the same. | 20:00 |
| shaleh | I am sitting at the Sunnyvale Mirantis site for the local bug squash. | 20:00 |
| dstanek | shaleh: how's the attendance there? | 20:01 |
| shaleh | about 12. Spread across the projects though. | 20:02 |
| shaleh | guys next to me are neutron hacking. | 20:02 |
| shaleh | mix of Mirantis and VMWare mostly. | 20:02 |
| gyee | shaleh, free or bring-ya-own coffee? | 20:04 |
| shaleh | gyee: lunch is supposed to be here any moment | 20:05 |
| *** doug-fish has quit IRC | 20:05 | |
| gyee | Red Cow? | 20:05 |
| shaleh | there are snack bars on the table too | 20:05 |
| shaleh | gyee: no idea what food. and as you know, i do not care about coffee either | 20:05 |
| *** doug-fish has joined #openstack-keystone | 20:06 | |
| *** browne has joined #openstack-keystone | 20:08 | |
| *** simondodsley has quit IRC | 20:09 | |
| *** doug-fis_ has joined #openstack-keystone | 20:10 | |
| *** doug-fish has quit IRC | 20:11 | |
| *** fangxu has joined #openstack-keystone | 20:11 | |
| *** david-lyle_ has joined #openstack-keystone | 20:12 | |
| navidp | https://review.openstack.org/#/c/289472/ | 20:12 |
| patchbot | navidp: patch 289472 - keystoneauth - Adding authentication compatibility for OpenStackC... | 20:12 |
| *** david_lyle has quit IRC | 20:13 | |
| *** anush has quit IRC | 20:14 | |
| *** fangxu has quit IRC | 20:15 | |
| dstanek | shaleh: are you working on Keystone or other projects? | 20:15 |
| shaleh | dstanek: I work on keystone and bits touching it; | 20:16 |
| dstanek | nice | 20:17 |
| shaleh | dstanek: right now I am trying to get the open reviews I touched resolved | 20:17 |
| *** spandhe has quit IRC | 20:17 | |
| dstanek | shaleh: ping me if you have specific ones i can look at | 20:17 |
| shaleh | dstanek: shall do | 20:17 |
| *** harlowja has quit IRC | 20:18 | |
| *** spandhe has joined #openstack-keystone | 20:19 | |
| openstackgerrit | Sean Perry proposed openstack/keystone: Adding 'domain_id' filter to list_user_projects() https://review.openstack.org/182569 | 20:20 |
| shaleh | dstanek: Raildo complained about my unit test. Would you mind adding your criticism? | 20:20 |
| *** anush has joined #openstack-keystone | 20:20 | |
| shaleh | I addressed part of his concern by explicitly checking returned project id. That was a miss on my part. | 20:21 |
| *** petertr7_away is now known as petertr7 | 20:21 | |
| *** dave-mccowan has joined #openstack-keystone | 20:22 | |
| *** david-lyle_ is now known as david-lyle | 20:26 | |
| dstanek | shaleh: i'm happy with that. we just need the spec updated like bknudson suggested | 20:29 |
| shaleh | dstanek: spec was updated | 20:29 |
| dstanek | shaleh: did it merge? | 20:30 |
| shaleh | dstanek: I thought so, let me go check. | 20:30 |
| dstanek | shaleh: oh, i think it did | 20:32 |
| *** slberger has joined #openstack-keystone | 20:33 | |
| *** slberger1 has quit IRC | 20:34 | |
| openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Adding authentication compatibility for OpenStackClient https://review.openstack.org/289472 | 20:37 |
| dstanek | navidp: i think the bug here is incorrect: https://review.openstack.org/#/c/289472/ | 20:37 |
| patchbot | dstanek: patch 289472 - keystoneauth - Adding authentication compatibility for OpenStackC... | 20:37 |
| rodrigods | shaleh, ^ that was me, not raildo :P | 20:38 |
| rodrigods | shaleh, but its fine like that :) | 20:38 |
| morgan | lbragstad: here now | 20:38 |
| dstanek | rodrigods: you mean you're not the same person? :-P | 20:38 |
| navidp | dstanek, why :) | 20:38 |
| morgan | lbragstad: was stuck on a plane earlier. | 20:38 |
| rodrigods | dstanek, haha | 20:39 |
| lbragstad | morgan i'm trying to understand https://github.com/openstack/keystone/blob/master/keystone/identity/core.py#L1121-L1133 | 20:39 |
| lbragstad | morgan it's making my face hurt | 20:39 |
| rodrigods | i'm the good looking one | 20:39 |
| morgan | Easy | 20:40 |
| dstanek | lbragstad: still having trouble with it? | 20:40 |
| morgan | That method is decorated | 20:40 |
| morgan | Call it and it emits the event | 20:40 |
| lbragstad | morgan dstanek i've hit a few other branches down the fail tree | 20:40 |
| morgan | It means you can control how the event is emitted | 20:40 |
| lbragstad | morgan sure - but it has a differnet "payload" than anything else that uses notifications | 20:40 |
| navidp | dstanek, incorect as it does not make sense or ... | 20:40 |
| morgan | Oh hmm. Sec. | 20:41 |
| dstanek | morgan: what's weird is that the user_project comes in as a dict, but is treated like an id by notifications | 20:41 |
| dstanek | navidp: click the link | 20:41 |
| morgan | Yeah it was used for internal callback only | 20:41 |
| morgan | It has been a while since I've look Ed at that. | 20:42 |
| morgan | I think it needed the whole dict on the callback. | 20:42 |
| morgan | When that was written | 20:42 |
| * morgan shrugs. | 20:42 | |
| morgan | I dunno now :P | 20:42 |
| morgan | This is not pycadf stuff | 20:43 |
| lbragstad | nope - it's not | 20:43 |
| lbragstad | it somehow ends up here - https://github.com/openstack/keystone/blob/master/keystone/token/provider.py#L492 | 20:43 |
| lbragstad | once uuid is gone that is *all* going to go away | 20:44 |
| morgan | lbragstad: yep | 20:44 |
| dstanek | lbragstad: that method is registered by the class | 20:44 |
| morgan | It ends up there via the callback notifications | 20:44 |
| morgan | It's registered by the class | 20:44 |
| dstanek | lbragstad: https://github.com/openstack/keystone/blob/master/keystone/token/provider.py#L146 | 20:45 |
| morgan | What dstanek said | 20:45 |
| lbragstad | ah... | 20:45 |
| dstanek | lbragstad: notification has a list of callbacks that it iterates over | 20:45 |
| lbragstad | that's really hard to put two and two together | 20:45 |
| lbragstad | how can I trace from https://github.com/openstack/keystone/blob/master/keystone/identity/core.py#L1121-L1133 to https://github.com/openstack/keystone/blob/master/keystone/token/provider.py#L146 | 20:46 |
| navidp | dstanek, ouch | 20:46 |
| dstanek | lbragstad: there's really no direct link other than notifications | 20:46 |
| openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Adding authentication compatibility for OpenStackClient https://review.openstack.org/289472 | 20:46 |
| dstanek | lbragstad: that pattern is designed that way so that you can add behaviors to code without having to edit the code itself - helps with the open/closed principle | 20:47 |
| dstanek | navidp: is there any reason you haven't added ksa to that bug? | 20:48 |
| lbragstad | hmm | 20:48 |
| *** belmoreira has joined #openstack-keystone | 20:50 | |
| navidp | dstanek, what should i add ? | 20:50 |
| dstanek | navidp: you can 'Also affects this project', not sure if it matters at this point | 20:51 |
| navidp | dstanek, ok i add it as comments | 20:53 |
| navidp | dstanek added that it will affect keystoneauth https://bugs.launchpad.net/keystoneauth/+bug/1533369 | 20:55 |
| openstack | Launchpad bug 1533369 in python-openstackclient "moving authentication from keystoneclient to keystoneauth" [High,In progress] - Assigned to Navid Pustchi (npustchi) | 20:55 |
| dstanek | navidp: you're patch should close it now | 20:56 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 20:58 | |
| shaleh | rodrigods: dude, sorry for the name mix up. I am horrible with names. | 20:59 |
| *** stevemar has quit IRC | 20:59 | |
| rodrigods | np shaleh, was just kidding :) | 20:59 |
| *** raildo is now known as raildo-afk | 21:00 | |
| shaleh | dstanek: thanks for the +2 | 21:01 |
| shaleh | dstanek: I like simple patches :-) | 21:01 |
| dstanek | shaleh: yw, me too | 21:01 |
| *** stevemar has joined #openstack-keystone | 21:01 | |
| shaleh | samueldmq: you around? | 21:02 |
| *** mhickey has joined #openstack-keystone | 21:02 | |
| openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Adding authentication compatibility for OpenStackClient https://review.openstack.org/289472 | 21:03 |
| navidp | dstanek, i just updated the closes bug sorry realized instantly after your +2 | 21:04 |
| *** belmoreira has quit IRC | 21:04 | |
| morgan | shaleh: hold on let me -2 that for being too simple :P | 21:05 |
| shaleh | morgan: :-) | 21:05 |
| morgan | We'll have none of that in keystone! | 21:05 |
| shaleh | morgan: critiques leading to improvement are always welcomed | 21:05 |
| dstanek | morgan: exactly. if it's not overly complex it doesn't belong in keystone | 21:05 |
| morgan | :P | 21:05 |
| morgan | dstanek: see you get it! | 21:05 |
| morgan | Ugh I need a VPN server that isn't blocked by Netflix (not getting around geoip things getting around crap hotel WiFi doing DPI and breaking things) | 21:06 |
| *** dims has quit IRC | 21:07 | |
| shaleh | DPI? | 21:07 |
| *** sdake has quit IRC | 21:07 | |
| morgan | Deep packet inspectiob | 21:08 |
| morgan | Often times they inject their own code into HTTP requests and break pages too | 21:08 |
| shaleh | morgan: oh fun | 21:08 |
| morgan | Not proxy because it's done in the networking hardware | 21:08 |
| morgan | It's evil | 21:08 |
| rodrigods | this is against the law in brazil | 21:09 |
| *** e0ne has joined #openstack-keystone | 21:10 | |
| morgan | rodrigods: I bet there are ways to skirt the law | 21:16 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 21:16 | |
| rodrigods | morgan, sure... but would not be a great if caught | 21:17 |
| rodrigods | morgan, https://medium.com/@brasilobserver/brazils-civil-mark-is-the-most-advanced-law-in-defence-of-the-free-internet-f9565adf1631#.8fu8dotnw | 21:17 |
| *** ayoung has joined #openstack-keystone | 21:20 | |
| *** ChanServ sets mode: +v ayoung | 21:20 | |
| shaleh | now and then I miss 'let' statements. [s.strip() for s in some_list_of_strings] <-- no good way to prevent empties in the list | 21:27 |
| dstanek | shaleh: yeah, you could filter(None, ...) | 21:30 |
| shaleh | dstanek: yeah, but `filter` gets no love these days | 21:31 |
| dstanek | shaleh: i still love it! | 21:32 |
| dstanek | haters gonna hate | 21:32 |
| shaleh | dstanek: yeah, it combined with in place list comprehensions is nice. `filter(None, (s.strip() for s in some_list_of_strings))` | 21:33 |
| shaleh | dstanek: in this case the hater is Guido sadly. | 21:33 |
| *** e0ne has quit IRC | 21:34 | |
| morgan | shaleh: rewrite keystone in rust! | 21:35 |
| dstanek | morgan: i've been holding off on that x1, waiting on the 4th gen | 21:36 |
| morgan | dstanek: I broke my x1 :( need to replace it. | 21:36 |
| dstanek | morgan: what did you do to it? | 21:37 |
| morgan | Knocked it off the desk this weekend, broke the screen, broke the hinges, was bad | 21:37 |
| *** fangxu has joined #openstack-keystone | 21:37 | |
| breton | [x for x in (s.strip() for s in some_list) if x], no? | 21:37 |
| dstanek | morgan: i wouldn't have expected to to break that bad | 21:37 |
| morgan | It landed hard and "open". It weathered worse when closed or close to closed. | 21:38 |
| dstanek | breton: sure, but filter looks cleaner to me | 21:38 |
| morgan | dstanek: it hit a few things on the way down | 21:38 |
| shaleh | breton: yeah, I just wish I could use a let internally to store the x so I did not need two loops | 21:38 |
| breton | shaleh: that's one loop | 21:38 |
| dstanek | shaleh: in theory with a generator expression it's only 1 loop | 21:38 |
| morgan | dstanek: had a migrane and had just gotten. To sleep, phone alarm went off and trying to get to the phone I knocked the laptop off the desk pretty hard :( | 21:39 |
| shaleh | dstanek: seriously? Isn't there a loop yield`ing values in there? | 21:39 |
| morgan | Didn't see it broken until 5 hrs later when I woke up. | 21:39 |
| dstanek | shaleh: i've found that with smaller datasets looping twice can be more efficient than the generator though | 21:39 |
| dstanek | shaleh: it's in the same loop. the list is only iterated over once | 21:39 |
| shaleh | dstanek: yeah, generators can be expensive | 21:39 |
| shaleh | dstanek: cool, good to know. | 21:40 |
| shaleh | in this code the list is likely very small | 21:40 |
| shaleh | breton: much appreciated. It is always nice to learn something new. | 21:41 |
| * shaleh is a Python dinosaur. 1.5.2 was my first. | 21:41 | |
| shaleh | sometimes these new fangled bits slip off my radar | 21:41 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 21:41 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 21:42 | |
| *** ChanServ sets mode: +o stevemar | 21:43 | |
| *** e0ne has joined #openstack-keystone | 21:43 | |
| dstanek | shaleh: i remember porting from 1.5.1 to 1.5.2 :-) all sorts of stuff broken because 1.5.2 stopped allowing args after kwargs | 21:45 |
| shaleh | dstanek: yeah, those were the days | 21:45 |
| dstanek | shaleh: but 'def f(a, b=None, c)' was stupid to do anyway :-) | 21:45 |
| shaleh | dstanek: yes, it was | 21:46 |
| dstanek | but legal! | 21:46 |
| shaleh | dstanek: '\n'.join(foos) still drives me crazy. | 21:46 |
| openstackgerrit | Cristian Sava proposed openstack/keystone: Customize config file location when run as wsgi app. https://review.openstack.org/288216 | 21:46 |
| rodrigods | dstanek, wow, really old school python :P | 21:46 |
| * shaleh hacked in perl before finding Python. I still despise Perl. | 21:48 | |
| rodrigods | shaleh, heh | 21:48 |
| shaleh | show me how to make a list of hashes of lists and reference one of the members should not require thinking. | 21:48 |
| shaleh | the number of ways that can go wrong when passed to a function as a parameter is mind boggling | 21:49 |
| *** harlowja has joined #openstack-keystone | 21:52 | |
| *** rderose has joined #openstack-keystone | 21:53 | |
| *** trown is now known as trown|outtypewww | 21:57 | |
| *** sheel has quit IRC | 21:57 | |
| *** fangxu has quit IRC | 21:58 | |
| *** dims has joined #openstack-keystone | 21:58 | |
| samueldmq | shaleh: hi, I am now | 21:59 |
| *** dims has quit IRC | 22:01 | |
| shaleh | samueldmq: https://review.openstack.org/#/c/247017/ | 22:01 |
| patchbot | shaleh: patch 247017 - keystone - Removed conflict wrapper on delete_project | 22:01 |
| *** david-lyle has quit IRC | 22:02 | |
| shaleh | samueldmq: the reference in your bug report no longer points at useful code | 22:02 |
| shaleh | samueldmq: if you could update the review with guidance that would be helpful | 22:02 |
| *** david-lyle has joined #openstack-keystone | 22:02 | |
| shaleh | stepping away for a few moments | 22:03 |
| samueldmq | shaleh: sure, will look in a bit | 22:06 |
| *** jaugustine has quit IRC | 22:08 | |
| *** petertr7 is now known as petertr7_away | 22:08 | |
| shaleh | samueldmq: thanks | 22:08 |
| *** mhickey has quit IRC | 22:09 | |
| *** e0ne has quit IRC | 22:11 | |
| *** phalmos has quit IRC | 22:15 | |
| openstackgerrit | Dolph Mathews proposed openstack/keystone: Race condition in keystone domain config https://review.openstack.org/287020 | 22:19 |
| *** doug-fis_ has quit IRC | 22:20 | |
| *** doug-fish has joined #openstack-keystone | 22:20 | |
| *** doug-fish has quit IRC | 22:23 | |
| *** doug-fish has joined #openstack-keystone | 22:24 | |
| *** pauloewerton has quit IRC | 22:24 | |
| *** bjornar has quit IRC | 22:26 | |
| *** doug-fish has quit IRC | 22:26 | |
| *** doug-fish has joined #openstack-keystone | 22:26 | |
| *** spzala has quit IRC | 22:27 | |
| *** spzala has joined #openstack-keystone | 22:27 | |
| dolphm | stevemar: revised this fix to a rc-potential race condition https://review.openstack.org/#/c/287020/ | 22:27 |
| patchbot | dolphm: patch 287020 - keystone - Race condition in keystone domain config | 22:27 |
| dolphm | dstanek: lbragstad: ^ the one i mentioned earlier | 22:28 |
| stevemar | dolphm: coolio, i'll look at it tomorrow | 22:29 |
| stevemar | i haven't slept in 30 hrs | 22:29 |
| *** spzala has quit IRC | 22:32 | |
| *** jamielennox|away is now known as jamielennox | 22:38 | |
| *** spzala has joined #openstack-keystone | 22:39 | |
| *** arunkant has quit IRC | 22:53 | |
| *** doug-fish has quit IRC | 22:53 | |
| *** fawadkhaliq has quit IRC | 22:54 | |
| *** fawadkhaliq has joined #openstack-keystone | 22:56 | |
| *** rk4n has joined #openstack-keystone | 22:57 | |
| SamYaple | that create-service-and-via-bootstrap-command patchset worked like a charm. Kolla now bootstraps without the admin token or any other jankyness | 22:58 |
| *** doug-fish has joined #openstack-keystone | 23:01 | |
| *** slberger has left #openstack-keystone | 23:01 | |
| mordred | stevemar: heya ... so ... that ^^ | 23:08 |
| jamielennox | stevemar: we are apparently not using DocImpact enough | 23:08 |
| mordred | stevemar: was just talking to Sam-I-Am and ... that ^^ | 23:08 |
| jamielennox | stevemar: i had forget it was still around, but it is | 23:08 |
| * mordred lets jamielennox take over | 23:08 | |
| shaleh | stevemar claims to be napping | 23:08 |
| jamielennox | anyway, kyestone doing our own thing and we should do more to integrate with docs | 23:09 |
| mordred | shaleh: NO SLEEP FOR STEVEMAR PTLS NO SLEEP!!!! | 23:09 |
| mordred | :) | 23:09 |
| jamielennox | shaleh: he'll see it when he gets back | 23:09 |
| mordred | jamielennox: ++ | 23:09 |
| jamielennox | he can't help himself | 23:09 |
| mordred | jamielennox: he's got a bouncer now! :) | 23:09 |
| shaleh | mordred: he tried, he claimed 30 hours of uptime | 23:09 |
| dstanek | stevemar: that's not an excuse | 23:09 |
| jamielennox | mordred: i completely understand why he didn't want one | 23:09 |
| jamielennox | stevemar: if we knew this was the behaviour we would get from a PTL... unacceptable | 23:10 |
| *** ninag has quit IRC | 23:11 | |
| *** harlowja has quit IRC | 23:13 | |
| *** mtreinish has quit IRC | 23:13 | |
| *** harlowja has joined #openstack-keystone | 23:14 | |
| *** mtreinish has joined #openstack-keystone | 23:14 | |
| mordred | SamYaple: do you have a kolla patch that implemented moving to create-service-and-via-bootstrap-command ? | 23:15 |
| SamYaple | mordred: as luck would have it, i do | 23:16 |
| SamYaple | with a 10m build+deploy+bootvm gate as well | 23:16 |
| SamYaple | mordred: https://review.openstack.org/#/c/289542/ | 23:16 |
| patchbot | SamYaple: patch 289542 - kolla - Remove openstack client from keystone bootstrap | 23:16 |
| openstackgerrit | Jorge Munoz proposed openstack/keystone: Validate v2 fernet token returns extra attributes https://review.openstack.org/289618 | 23:17 |
| *** palexster has quit IRC | 23:19 | |
| *** markvoelker_ has joined #openstack-keystone | 23:19 | |
| shaleh | jamielennox: since you are around, https://review.openstack.org/288175. I know it is hacky but it made debugging some things nicer. Thoughts? | 23:23 |
| openstackgerrit | Jorge Munoz proposed openstack/keystone: Validate v2 fernet token returns extra attributes https://review.openstack.org/289618 | 23:24 |
| jamielennox | shaleh: whoa | 23:24 |
| shaleh | jamielennox: I know, ugly. But it made my access.log actually usable. | 23:25 |
| jamielennox | shaleh: so can we rely on PBR for this | 23:25 |
| jamielennox | we do that in auth_token | 23:25 |
| jamielennox | https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token/__init__.py#L1022 | 23:26 |
| jamielennox | shaleh: i'm ok with a best effort, but that's super complex | 23:26 |
| shaleh | jamielennox: argv[0] gets a lot. modwsgi forces me to step up the hunt :-) | 23:27 |
| shaleh | jamielennox: I will look at the PBR provided bits though. Although I would almost rather boil my hand than touch PBR. | 23:27 |
| *** tellesnobrega is now known as tellesnobrega_af | 23:28 | |
| *** tellesnobrega_af is now known as tellesnobrega | 23:28 | |
| shaleh | jamielennox: when I tried something like that there was no CONF set consistently. | 23:28 |
| openstackgerrit | Jorge Munoz proposed openstack/keystone: Validate v2 fernet token returns extra attributes https://review.openstack.org/289618 | 23:28 |
| shaleh | jamielennox: I started there with similar code. | 23:29 |
| jamielennox | shaleh: oh, yea, we can't rely on CONF | 23:29 |
| shaleh | jamielennox: lots of comments for the complexity :-) | 23:29 |
| jamielennox | shaleh: i like improving this, but i'd be as happy with just going out to the individual clients and making them set their user_agent correctly | 23:30 |
| *** anush has quit IRC | 23:30 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 23:30 | |
| shaleh | jamielennox: yeah, TBH I would like to see an exception thrown if user_agent is not set by the importer. | 23:30 |
| shaleh | jamielennox: perhaps we can do that in N? :-) | 23:30 |
| *** anush has joined #openstack-keystone | 23:31 | |
| shaleh | jamielennox: I also submitted a patch to monasca agent. No more httplib/1.1 in the access.log. | 23:32 |
| jamielennox | shaleh: we can put up a warning at least | 23:32 |
| *** palexster has joined #openstack-keystone | 23:32 | |
| *** gordc has quit IRC | 23:32 | |
| shaleh | jamielennox: yeah, that should get the ball rolling. | 23:32 |
| shaleh | jamielennox: I will happily submit a scream patch once the N tree exists. | 23:33 |
| jamielennox | shaleh: is that sufficient for this or do you want to do the module walk as well? | 23:33 |
| jamielennox | shaleh: i'm not a fan of magic complexity | 23:34 |
| shaleh | jamielennox: why do you see it as complexity? | 23:34 |
| shaleh | jamielennox: my code can die once most of OpenStack starts setting user_agent | 23:34 |
| jamielennox | shaleh: well we're walking python modules to see what's loaded and callig | 23:34 |
| jamielennox | that can be flaky | 23:34 |
| shaleh | jamielennox: but the code is obvious and well commented | 23:34 |
| jamielennox | it is also really hard to remove functionality | 23:35 |
| shaleh | jamielennox: and worst case is we lie about a user agent | 23:35 |
| shaleh | jamielennox: ah, but we only need this if user_agent is not set | 23:35 |
| shaleh | jamielennox: so if we make it clear it HAS to be set this code will sunset on its own | 23:35 |
| shaleh | jamielennox: the code would be MUCH simpler if I could use `inspect` module. | 23:35 |
| shaleh | jamielennox: but it has too much overhead for this | 23:36 |
| *** palexster has quit IRC | 23:37 | |
| *** doug-fish has quit IRC | 23:37 | |
| *** GB21 has joined #openstack-keystone | 23:38 | |
| openstackgerrit | Navid Pustchi proposed openstack/keystoneauth: Adding authentication compatibility for OpenStackClient https://review.openstack.org/289472 | 23:38 |
| shaleh | jamielennox: ponder it. -1 my review :-) | 23:40 |
| shaleh | jamielennox: but I also ask you to try the patch and see the improvement. | 23:41 |
| *** rk4n has quit IRC | 23:42 | |
| jamielennox | shaleh: sorry, doing about 3 things, also lifeless is in the room so i was consulting | 23:43 |
| jamielennox | there are too many ways i can see the magic going wrong and providing something not useful | 23:44 |
| jamielennox | i'm cool with deprecating not passing a user_agent | 23:44 |
| jamielennox | particularly because people should most be using loading and we can set it for them in some cases | 23:44 |
| shaleh | jamielennox: no worries. I do not expect a quick result on this one. | 23:45 |
| shaleh | jamielennox: it works for me (tm) | 23:45 |
| *** rk4n has joined #openstack-keystone | 23:45 | |
| shaleh | jamielennox: but I appreciate your concern. | 23:45 |
| *** palexster has joined #openstack-keystone | 23:50 | |
| *** arunkant has joined #openstack-keystone | 23:52 | |
| *** pushkaru has joined #openstack-keystone | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!