| *** shoutm has joined #openstack-keystone | 00:01 | |
| *** pushkaru has quit IRC | 00:07 | |
| *** pushkaru has joined #openstack-keystone | 00:07 | |
| *** ayoung has quit IRC | 00:07 | |
| *** pushkaru has quit IRC | 00:08 | |
| *** pushkaru has joined #openstack-keystone | 00:08 | |
| *** sdake has quit IRC | 00:09 | |
| *** pushkaru has quit IRC | 00:11 | |
| *** fpatwa_ has joined #openstack-keystone | 00:14 | |
| *** pushkaru has joined #openstack-keystone | 00:14 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 00:15 | |
| *** slberger1 has left #openstack-keystone | 00:25 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 00:26 |
|---|---|---|
| *** pushkaru has quit IRC | 00:27 | |
| *** lighshadow has joined #openstack-keystone | 00:33 | |
| *** shoutm_ has joined #openstack-keystone | 00:35 | |
| *** shoutm has quit IRC | 00:38 | |
| *** tqtran is now known as tqtran-afk | 00:40 | |
| *** henrynash has quit IRC | 00:49 | |
| *** fpatwa_ has quit IRC | 00:56 | |
| *** shaleh has quit IRC | 01:03 | |
| *** ayoung has joined #openstack-keystone | 01:05 | |
| *** ChanServ sets mode: +v ayoung | 01:05 | |
| *** spandhe has quit IRC | 01:11 | |
| *** blogan is now known as blogan-bot | 01:14 | |
| *** blogan-bot is now known as blogan | 01:14 | |
| *** lhcheng has quit IRC | 01:16 | |
| *** jorge_munoz has quit IRC | 01:18 | |
| morgan | lbragstad: ^ see my response re what in 0 is meant to be in deprecated | 01:24 |
| *** EinstCrazy has joined #openstack-keystone | 01:27 | |
| *** sdake has joined #openstack-keystone | 01:27 | |
| *** dan_nguyen has quit IRC | 01:32 | |
| *** sdake has quit IRC | 01:35 | |
| *** shoutm has joined #openstack-keystone | 01:35 | |
| *** shoutm_ has quit IRC | 01:37 | |
| openstackgerrit | Cristian Sava proposed openstack/keystone: Able to customize config file location when keystone runs as wsgi application. https://review.openstack.org/288216 | 01:41 |
| *** jorge_munoz has joined #openstack-keystone | 01:48 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 01:52 |
| *** jorge_munoz has quit IRC | 01:54 | |
| *** tqtran-afk has quit IRC | 01:54 | |
| *** bjornar has quit IRC | 01:55 | |
| *** lighshadow has quit IRC | 02:02 | |
| *** GB21 has quit IRC | 02:04 | |
| *** gyee has quit IRC | 02:15 | |
| *** fawadkhaliq has quit IRC | 02:20 | |
| *** shoutm has quit IRC | 02:37 | |
| *** shoutm has joined #openstack-keystone | 02:38 | |
| *** sdake has joined #openstack-keystone | 02:39 | |
| *** woodster_ has quit IRC | 02:47 | |
| *** sdake has quit IRC | 02:51 | |
| *** sdake has joined #openstack-keystone | 02:52 | |
| *** sdake has quit IRC | 02:52 | |
| *** links has joined #openstack-keystone | 03:01 | |
| *** fpatwa_ has joined #openstack-keystone | 03:01 | |
| *** GB21 has joined #openstack-keystone | 03:13 | |
| *** GB21 has quit IRC | 03:18 | |
| *** fangxu has quit IRC | 03:30 | |
| *** fawadkhaliq has joined #openstack-keystone | 03:38 | |
| *** dims has quit IRC | 03:40 | |
| *** Ephur has quit IRC | 03:41 | |
| *** dims has joined #openstack-keystone | 03:43 | |
| *** dims has quit IRC | 03:44 | |
| *** links has quit IRC | 03:44 | |
| *** shoutm has quit IRC | 03:46 | |
| *** shoutm has joined #openstack-keystone | 03:55 | |
| *** __zouyee has joined #openstack-keystone | 04:15 | |
| *** __zouyee has quit IRC | 04:20 | |
| *** agireud has quit IRC | 04:27 | |
| *** david_cu has quit IRC | 04:27 | |
| *** links has joined #openstack-keystone | 04:27 | |
| *** shoutm has quit IRC | 04:27 | |
| *** openstack has joined #openstack-keystone | 04:28 | |
| *** shoutm has joined #openstack-keystone | 04:29 | |
| *** richm has quit IRC | 04:29 | |
| *** alex_xu has joined #openstack-keystone | 04:29 | |
| *** openstack has quit IRC | 04:30 | |
| *** openstack has joined #openstack-keystone | 04:31 | |
| *** openstack has quit IRC | 04:34 | |
| *** openstack has joined #openstack-keystone | 04:34 | |
| *** agireud has joined #openstack-keystone | 04:34 | |
| *** openstack has quit IRC | 04:36 | |
| *** openstack has joined #openstack-keystone | 04:36 | |
| *** openstack has quit IRC | 04:39 | |
| *** openstack has joined #openstack-keystone | 14:06 | |
| *** mhu has quit IRC | 14:14 | |
| *** mhu has joined #openstack-keystone | 14:14 | |
| *** anush has joined #openstack-keystone | 14:16 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updated from global requirements https://review.openstack.org/288468 | 14:17 |
| *** knikolla has joined #openstack-keystone | 14:21 | |
| *** fpatwa_ has joined #openstack-keystone | 14:26 | |
| *** dansmith is now known as superdan | 14:29 | |
| *** fpatwa_ has quit IRC | 14:31 | |
| *** twm2016 has joined #openstack-keystone | 14:32 | |
| *** rodrigods has quit IRC | 14:34 | |
| *** rodrigods has joined #openstack-keystone | 14:34 | |
| openstackgerrit | Trevor McCasland proposed openstack/keystone: Change max size validation parameters https://review.openstack.org/285393 | 14:34 |
| *** twm2016 has quit IRC | 14:36 | |
| *** openstackgerrit_ has quit IRC | 14:36 | |
| *** dave-mccowan has joined #openstack-keystone | 14:37 | |
| *** openstackgerrit_ has joined #openstack-keystone | 14:37 | |
| *** links has quit IRC | 14:41 | |
| *** petertr7 is now known as petertr7_away | 14:44 | |
| dstanek | happy bug day! | 14:50 |
| *** spzala has joined #openstack-keystone | 14:50 | |
| *** petertr7_away is now known as petertr7 | 14:51 | |
| bknudson | dstanek: not a bug as reported, but https://review.openstack.org/#/c/285808/ | 14:53 |
| patchbot | bknudson: patch 285808 - python-keystoneclient - Update Client examples to use sessions | 14:53 |
| *** phalmos has joined #openstack-keystone | 14:59 | |
| *** jrist has joined #openstack-keystone | 15:02 | |
| *** rderose has joined #openstack-keystone | 15:02 | |
| ayoung | morgan, they are calling via Puppet, so it should record the original values. Just easier for puppet if they can blindly recall as oppose to query and diff | 15:02 |
| *** woodster_ has joined #openstack-keystone | 15:03 | |
| lbragstad | bug day!! | 15:04 |
| morgan | Eh, pass. I did my part earlier this week :P | 15:04 |
| raildo | lbragstad: \o/ | 15:08 |
| *** markvoelker has quit IRC | 15:10 | |
| *** markvoelker has joined #openstack-keystone | 15:10 | |
| *** jasonsb has joined #openstack-keystone | 15:16 | |
| *** rderose has quit IRC | 15:17 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 15:19 |
| *** nkinder has joined #openstack-keystone | 15:20 | |
| *** slberger has joined #openstack-keystone | 15:21 | |
| *** mvk has joined #openstack-keystone | 15:22 | |
| *** jed56 has quit IRC | 15:23 | |
| *** slberger has quit IRC | 15:26 | |
| *** slberger has joined #openstack-keystone | 15:26 | |
| *** jorge_munoz has joined #openstack-keystone | 15:31 | |
| *** jsavak has quit IRC | 15:34 | |
| *** david_lyle__ has joined #openstack-keystone | 15:34 | |
| *** david-lyle has quit IRC | 15:37 | |
| *** __zouyee has quit IRC | 15:44 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split assignment backend tests https://review.openstack.org/268307 | 15:46 |
| *** kiran-r has quit IRC | 15:51 | |
| *** shangxdy has joined #openstack-keystone | 15:53 | |
| *** dims is now known as dimsum_ | 15:53 | |
| *** kiran-r has joined #openstack-keystone | 15:53 | |
| lbragstad | here are a couple patches that close a bug - https://review.openstack.org/#/q/topic:bug/1552639 | 15:54 |
| lbragstad | stevemar thoughts - https://bugs.launchpad.net/keystone/+bug/1552795 ? | 15:56 |
| openstack | Launchpad bug 1552795 in OpenStack Identity (keystone) "enhance notification for user events with user name" [Undecided,New] | 15:56 |
| stevemar | lbragstad: it'll have to have domain name too, since names are not unique across domains | 15:58 |
| *** jorge_munoz_ has joined #openstack-keystone | 15:59 | |
| *** henrynash has joined #openstack-keystone | 15:59 | |
| *** ChanServ sets mode: +v henrynash | 15:59 | |
| lbragstad | stevemar but that would only ever be the case with users | 16:00 |
| *** jorge_munoz has quit IRC | 16:00 | |
| *** jorge_munoz_ is now known as jorge_munoz | 16:00 | |
| lbragstad | stevemar right? | 16:00 |
| lbragstad | so - the notification framework would have to be smart enough to put that information into events that pertain to users. | 16:01 |
| stevemar | lbragstad: we've had requests to add names to all notification bits | 16:02 |
| stevemar | lbragstad: cause for project delete, they can't look it up again to find the name :( | 16:02 |
| *** jsavak has joined #openstack-keystone | 16:03 | |
| lbragstad | stevemar oh - so that would include domain name, project name, group name etc... | 16:05 |
| lbragstad | not *just* usernames. | 16:06 |
| stevemar | lbragstad: yeah, but you could start with user name first :P | 16:06 |
| *** belmoreira has quit IRC | 16:07 | |
| lbragstad | stevemar would you be fine with the approach that the notification framework just pull the name our of a given entity reference and attempts to send it if it's there? | 16:07 |
| lbragstad | out* | 16:07 |
| stevemar | lbragstad: sure, don't see why not | 16:08 |
| lbragstad | obviously it wouldn't make sense to try and send name for endpoints | 16:08 |
| lbragstad | ok | 16:08 |
| stevemar | you think getting the entitiy reference will slow things down? | 16:08 |
| * lbragstad stevemar at this point we usually already have the reference - https://github.com/openstack/keystone/blob/master/keystone/identity/core.py#L864 | 16:09 | |
| lbragstad | stevemar so instead of passing just user['id'] to the notification module - we could pass the whole reference and make the notification module pull out what it needs. | 16:10 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split assignment backend tests https://review.openstack.org/268307 | 16:10 |
| *** jsavak has quit IRC | 16:12 | |
| *** e0ne has quit IRC | 16:12 | |
| *** jsavak has joined #openstack-keystone | 16:12 | |
| *** david_lyle__ is now known as david_lyle | 16:17 | |
| *** pushkaru has joined #openstack-keystone | 16:19 | |
| *** rderose has joined #openstack-keystone | 16:22 | |
| *** jaosorior has quit IRC | 16:24 | |
| stevemar | lbragstad: ++ | 16:25 |
| stevemar | samueldmq: yay! | 16:25 |
| stevemar | samueldmq: you finally rebased that beast huh? | 16:26 |
| *** anush has quit IRC | 16:27 | |
| *** fpatwa_ has joined #openstack-keystone | 16:27 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 16:29 |
| *** daemontool__ has joined #openstack-keystone | 16:30 | |
| *** mhickey has quit IRC | 16:31 | |
| *** fpatwa_ has quit IRC | 16:32 | |
| samueldmq | stevemar: hey, still in the middle, posting second patch in a bit :) | 16:33 |
| samueldmq | stevemar: should be quicker now that I finished assignment and resource o/ | 16:33 |
| *** anush has joined #openstack-keystone | 16:33 | |
| *** daemontool_ has quit IRC | 16:34 | |
| *** daemontool__ is now known as daemontool | 16:34 | |
| samueldmq | stevemar: actually it's been easier to do the work again than trying to rebase what we had | 16:36 |
| *** anush has quit IRC | 16:36 | |
| *** petertr7 is now known as petertr7_away | 16:37 | |
| *** Ephur has joined #openstack-keystone | 16:38 | |
| *** roxanaghe has joined #openstack-keystone | 16:40 | |
| *** jsavak has quit IRC | 16:40 | |
| *** jsavak has joined #openstack-keystone | 16:41 | |
| *** fhubik has quit IRC | 16:42 | |
| *** spzala has quit IRC | 16:44 | |
| *** spzala has joined #openstack-keystone | 16:44 | |
| *** anush has joined #openstack-keystone | 16:45 | |
| *** pece has quit IRC | 16:50 | |
| *** rcernin has quit IRC | 16:51 | |
| *** timcline has joined #openstack-keystone | 16:52 | |
| *** pece has joined #openstack-keystone | 16:54 | |
| kfox1111 | I'm curious, why aren't the public clouds pushing the k2k dashboard patch? | 16:55 |
| kfox1111 | without it, its not really feasable to federate your private cloud out to public ones... | 16:56 |
| *** timcline has quit IRC | 16:57 | |
| *** _pece has joined #openstack-keystone | 16:58 | |
| *** timcline has joined #openstack-keystone | 16:58 | |
| *** clenimar has quit IRC | 17:00 | |
| *** pece has quit IRC | 17:01 | |
| *** jsavak has quit IRC | 17:02 | |
| *** sdake_ has joined #openstack-keystone | 17:02 | |
| *** timcline has quit IRC | 17:02 | |
| *** sdake has quit IRC | 17:03 | |
| *** jed56 has joined #openstack-keystone | 17:07 | |
| *** sdake_ is now known as sdake | 17:07 | |
| *** kiran-r has quit IRC | 17:08 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split resource backend tests https://review.openstack.org/268702 | 17:08 |
| *** breton has quit IRC | 17:08 | |
| *** dan_nguyen has joined #openstack-keystone | 17:09 | |
| *** breton has joined #openstack-keystone | 17:09 | |
| *** bjornar has joined #openstack-keystone | 17:13 | |
| *** shaleh has joined #openstack-keystone | 17:13 | |
| *** breton has quit IRC | 17:14 | |
| shaleh | samueldmq: I see new rounds of your unit test refactoring. Keep it up! | 17:14 |
| *** breton has joined #openstack-keystone | 17:15 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split token backend tests https://review.openstack.org/269111 | 17:17 |
| samueldmq | shaleh: yes ^ there we go! | 17:17 |
| shaleh | samueldmq: why are you marking them WIP? | 17:17 |
| *** mhickey has joined #openstack-keystone | 17:18 | |
| shaleh | yet another thing I dislike with the new gerrit. It is hard to understand patch depends. | 17:19 |
| shaleh | Do I read that list from top to bottom? | 17:19 |
| *** trown is now known as trown|lunch | 17:20 | |
| samueldmq | shaleh: from bottom to top, starting at assignment | 17:21 |
| samueldmq | shaleh: I made the first worfkflow-1 because I made a bad rebase | 17:22 |
| shaleh | samueldmq: ah | 17:22 |
| shaleh | samueldmq: easy to do | 17:22 |
| samueldmq | shaleh: but it isn't -1ed anymore | 17:22 |
| shaleh | samueldmq: do you feel this is ready to +2/+2? | 17:22 |
| samueldmq | shaleh: maybe you're not looking at the right patch set - which can easily happen with the new interface too | 17:22 |
| samueldmq | shaleh: yes I do; this is all about moving code around | 17:23 |
| shaleh | samueldmq: agreed. It being a bug day, maybe we can get momentum on this. | 17:23 |
| samueldmq | shaleh: ++ I hope so :) | 17:24 |
| samueldmq | shaleh: I am basically re-doing the work with these patches | 17:25 |
| shaleh | samueldmq: how much longer until you have the whole chain updated? | 17:25 |
| samueldmq | shaleh: rebasing would cost more effort | 17:25 |
| samueldmq | shaleh: 30 mins I think; I am already going through the rest | 17:25 |
| shaleh | samueldmq: excellent | 17:26 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split trust backend tests https://review.openstack.org/269115 | 17:26 |
| samueldmq | shaleh: ^ | 17:26 |
| samueldmq | :) | 17:26 |
| *** jasonsb has quit IRC | 17:26 | |
| shaleh | If we can get this pushed we can then focus on updating the merge conflicts that will result. | 17:26 |
| samueldmq | shaleh: yep, however there won't be that much (as it'd have been if we had merged during midcycle) | 17:27 |
| shaleh | I updated a patch this week that will likely be in conflict and need to be rebased. | 17:28 |
| shaleh | agreed, probably a small, manageable number | 17:28 |
| *** phalmos has quit IRC | 17:28 | |
| shaleh | samueldmq: as soon as the gates verify it I will +1 | 17:29 |
| *** rudolfvriend has quit IRC | 17:31 | |
| *** jdennis has quit IRC | 17:31 | |
| *** phalmos has joined #openstack-keystone | 17:33 | |
| samueldmq | shaleh: perfect, thanks! | 17:33 |
| *** lunarlamp has joined #openstack-keystone | 17:33 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split catalog backend tests https://review.openstack.org/269125 | 17:35 |
| *** spandhe has joined #openstack-keystone | 17:36 | |
| *** browne has joined #openstack-keystone | 17:37 | |
| *** daemontool_ has joined #openstack-keystone | 17:37 | |
| *** anush has quit IRC | 17:38 | |
| *** rderose has quit IRC | 17:38 | |
| *** spandhe_ has joined #openstack-keystone | 17:40 | |
| *** spandhe has quit IRC | 17:40 | |
| *** spandhe_ is now known as spandhe | 17:40 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split policy backend tests https://review.openstack.org/269133 | 17:40 |
| *** daemontool has quit IRC | 17:41 | |
| *** jistr has quit IRC | 17:46 | |
| openstackgerrit | Merged openstack/python-keystoneclient: Update Client examples to use sessions https://review.openstack.org/285808 | 17:49 |
| *** mhickey has quit IRC | 17:49 | |
| shaleh | samueldmq: first +2, you just need to campaign for one more :-) | 17:50 |
| samueldmq | shaleh: there we go! | 17:51 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split identity backend tests https://review.openstack.org/269148 | 17:52 |
| samueldmq | shaleh: ^last one! just need one more cleaning 2 things up (I added TODO for things that were not just about moving code around) | 17:52 |
| *** trown|lunch is now known as trown | 17:53 | |
| shaleh | samueldmq: https://review.openstack.org/#/c/218610/ <-- Brant abandoned this due to lack of time. Might be something you could pick up. | 17:54 |
| patchbot | shaleh: patch 218610 - keystone - Change notifications tests to not start servers (ABANDONED) | 17:54 |
| *** gyee has joined #openstack-keystone | 17:55 | |
| *** ChanServ sets mode: +v gyee | 17:55 | |
| *** wxy has quit IRC | 17:59 | |
| samueldmq | shaleh: I will put on TODO list; still have to implement functional tests on ksc (I committed to it) | 18:00 |
| samueldmq | shaleh: but sure something to look at, thanks | 18:00 |
| shaleh | samueldmq: welcome | 18:01 |
| samueldmq | shaleh: gotta update last 5 patches, I thoguht we had get ride of test_backend_kvs :( | 18:05 |
| *** petertr7_away is now known as petertr7 | 18:05 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split token backend tests https://review.openstack.org/269111 | 18:06 |
| shaleh | samueldmq: grumble | 18:06 |
| shaleh | samueldmq: if we can get at least one +2/+2 that is less hassle for you | 18:06 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split trust backend tests https://review.openstack.org/269115 | 18:07 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split catalog backend tests https://review.openstack.org/269125 | 18:08 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split policy backend tests https://review.openstack.org/269133 | 18:09 |
| *** shangxdy has quit IRC | 18:09 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split identity backend tests https://review.openstack.org/269148 | 18:10 |
| *** permalac has quit IRC | 18:12 | |
| *** yarkot_ has joined #openstack-keystone | 18:13 | |
| raildo | dstanek: ping, what is the best option to handle with backward compatibility following your suggestion? https://review.openstack.org/#/c/134095/ update all endpoints with region_id==None? | 18:18 |
| patchbot | raildo: patch 134095 - keystone - Constraint to prevent duplicate endpoints | 18:18 |
| *** lhcheng has joined #openstack-keystone | 18:19 | |
| *** ChanServ sets mode: +v lhcheng | 18:19 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Cleanup from from split of token backend tests https://review.openstack.org/288622 | 18:20 |
| *** yarkot_ has quit IRC | 18:21 | |
| *** _pece has quit IRC | 18:23 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split assignment backend tests https://review.openstack.org/268307 | 18:24 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split resource backend tests https://review.openstack.org/268702 | 18:26 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split token backend tests https://review.openstack.org/269111 | 18:27 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split trust backend tests https://review.openstack.org/269115 | 18:28 |
| *** fpatwa_ has joined #openstack-keystone | 18:28 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split catalog backend tests https://review.openstack.org/269125 | 18:28 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split policy backend tests https://review.openstack.org/269133 | 18:29 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split token backend tests https://review.openstack.org/269111 | 18:31 |
| samueldmq | sooo cool to rebase | 18:32 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split trust backend tests https://review.openstack.org/269115 | 18:32 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split catalog backend tests https://review.openstack.org/269125 | 18:32 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split policy backend tests https://review.openstack.org/269133 | 18:32 |
| *** fpatwa_ has quit IRC | 18:33 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Split identity backend tests https://review.openstack.org/269148 | 18:36 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Cleanup from from split of token backend tests https://review.openstack.org/288622 | 18:37 |
| *** henrynash has quit IRC | 18:41 | |
| *** pcaruana has quit IRC | 18:41 | |
| *** spzala has quit IRC | 18:48 | |
| *** spzala has joined #openstack-keystone | 18:48 | |
| lbragstad | stevemar I'm going to push a wip fix for https://bugs.launchpad.net/keystone/+bug/1552795 | 18:49 |
| openstack | Launchpad bug 1552795 in OpenStack Identity (keystone) "enhance notification for user events with user name" [Undecided,New] | 18:49 |
| lbragstad | stevemar I think there are only a few tests not passing - but I have to step away... the nested domain logic is breaking a bunch of stuff | 18:49 |
| *** doug-fis_ is now known as doug-fish | 18:50 | |
| *** henrynash has joined #openstack-keystone | 18:52 | |
| *** ChanServ sets mode: +v henrynash | 18:52 | |
| *** henrynash has quit IRC | 18:53 | |
| *** jdennis has joined #openstack-keystone | 18:54 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Send notifications with entity name in payload https://review.openstack.org/288643 | 18:54 |
| *** anush has joined #openstack-keystone | 18:59 | |
| *** jorge_munoz has quit IRC | 19:01 | |
| *** pece has joined #openstack-keystone | 19:01 | |
| shaleh | samueldmq: one down! | 19:06 |
| *** rk4n_ has joined #openstack-keystone | 19:07 | |
| *** pece has quit IRC | 19:10 | |
| *** rk4n has quit IRC | 19:10 | |
| *** rk4n_ has quit IRC | 19:12 | |
| *** pece has joined #openstack-keystone | 19:17 | |
| dstanek | raildo: it's possible that the only way to do that is to enforce it in the driver | 19:21 |
| openstackgerrit | Merged openstack/keystone: Updated from global requirements https://review.openstack.org/288468 | 19:22 |
| openstackgerrit | Alexander Makarov proposed openstack/keystoneauth: Examples for kerberos and saml2 plugins https://review.openstack.org/288669 | 19:22 |
| *** jed56 has quit IRC | 19:23 | |
| *** gyee has quit IRC | 19:23 | |
| *** gyee has joined #openstack-keystone | 19:31 | |
| *** ChanServ sets mode: +v gyee | 19:31 | |
| samueldmq | shaleh: :D | 19:32 |
| *** tqtran-afk has joined #openstack-keystone | 19:34 | |
| *** sdake has quit IRC | 19:36 | |
| *** fangxu has joined #openstack-keystone | 19:37 | |
| *** sdake has joined #openstack-keystone | 19:37 | |
| *** pushkaru has quit IRC | 19:40 | |
| openstackgerrit | Sean Perry proposed openstack/keystone: Migrate_repo init version helper https://review.openstack.org/137640 | 19:42 |
| *** rk4n has joined #openstack-keystone | 19:45 | |
| *** rk4n has quit IRC | 19:50 | |
| *** fawadkhaliq has joined #openstack-keystone | 19:52 | |
| *** tqtran-afk is now known as tqtran | 19:54 | |
| *** slberger has quit IRC | 20:01 | |
| *** slberger has joined #openstack-keystone | 20:02 | |
| *** anush has quit IRC | 20:02 | |
| *** jorge_munoz has joined #openstack-keystone | 20:06 | |
| *** sheel has quit IRC | 20:07 | |
| raildo | dstanek: I was think of doing this in the script migration | 20:12 |
| *** jorge_munoz has quit IRC | 20:12 | |
| dstanek | raildo: you'd have to do that for old data, but you'd still have to modify the driver for new data | 20:12 |
| raildo | dstanek: ok, got it. I was think in do this in a different patch | 20:14 |
| *** jbell8 has joined #openstack-keystone | 20:16 | |
| *** roxanaghe has quit IRC | 20:16 | |
| dstanek | raildo: i would put a patch right before the existing one that "Makes region_id not null in the SQL driver" or something like that | 20:18 |
| raildo | dstanek: yes, this is the idea :) | 20:19 |
| raildo | dstanek: great, thanks | 20:19 |
| dstanek | raildo: i think doing this in the manager, like the other patch, isn't correct since it forces all drivers to be dumb just because SQL is dumb | 20:19 |
| *** slberger has quit IRC | 20:20 | |
| raildo | dstanek: makes sense, I think doing this in the manager could be a good solution when we want to do this independent of the driver, or any similar situation. | 20:21 |
| dstanek | raildo: since it breaks expectations i think it should only be done if necessary | 20:22 |
| htruta | dstanek, raildo: I'd rather make it not nullable at driver and decode/encode in the manager, as we do for domain_id | 20:23 |
| *** slberger has joined #openstack-keystone | 20:23 | |
| dstanek | htruta: i actually don't think the manager should know about the "fake" null | 20:24 |
| dstanek | htruta: it's a super leaky abstraction | 20:24 |
| *** rcarrillocruz has joined #openstack-keystone | 20:24 | |
| rcarrillocruz | hey folks | 20:24 |
| htruta | dstanek: right! this is done in the driver now, right? | 20:24 |
| rcarrillocruz | quick question: | 20:24 |
| rcarrillocruz | is 'member' role a predefined role on all openstack keystone installations? | 20:24 |
| dstanek | htruta: tbh, i'm not sure | 20:24 |
| rcarrillocruz | or is it something devstack creates? | 20:24 |
| htruta | dstanek: let me check | 20:24 |
| htruta | dstanek: it's in the driver: https://github.com/openstack/keystone/blob/master/keystone/resource/backends/sql.py#L31 | 20:25 |
| samueldmq | rcarrillocruz: I believe member is created by devstack, however there is an internal _member_ role | 20:25 |
| samueldmq | rcarrillocruz: see https://github.com/openstack/keystone/blob/b2b75412f15ad635273096b147999050fb0ac79b/keystone/common/config.py#L92-L102 | 20:26 |
| htruta | dstanek: manager just sends it "none" and the driver deals with the encoding and decoding | 20:26 |
| samueldmq | rcarrillocruz: there is an explanation there in the help text | 20:26 |
| rcarrillocruz | crinkle: ^ | 20:26 |
| rcarrillocruz | thx samueldmq | 20:27 |
| samueldmq | rcarrillocruz: the one devstack creates is "Member" https://github.com/openstack-dev/devstack/blob/7de80c56e5db1f283a71c0ef9fa2304e7d8e2090/tools/create_userrc.sh#L74 | 20:27 |
| samueldmq | rcarrillocruz: np | 20:27 |
| rcarrillocruz | now onto reading how they differ :D | 20:27 |
| crinkle | rcarrillocruz: samueldmq in my install I don't see _member_ in either `openstack role list` or in the database | 20:28 |
| dstanek | htruta: nice, although this is uncool https://github.com/openstack/keystone/blob/master/keystone/resource/core.py#L950 | 20:28 |
| *** fangxu has quit IRC | 20:28 | |
| htruta | dstanek: the weird thing is that this is only declared in manager, but never used | 20:29 |
| *** fpatwa_ has joined #openstack-keystone | 20:29 | |
| samueldmq | crinkle: devstack? | 20:29 |
| crinkle | samueldmq: no, installed with puppet from uca packages | 20:30 |
| crinkle | i don't see anything in the puppet that would have deleted the role | 20:30 |
| *** pushkaru has joined #openstack-keystone | 20:30 | |
| dstanek | htruta: yeah, it should be moved into the driver | 20:31 |
| dstanek | htruta: i'd immediately +2 that! | 20:31 |
| samueldmq | dstanek: bknudson: any clue on how default role (member_role_name) gets created? | 20:31 |
| bknudson | samueldmq: maybe on demand? | 20:32 |
| htruta | dstanek: isn't this in manager because we need it for backward compatibility? | 20:32 |
| samueldmq | bknudson: yes https://github.com/openstack/keystone/blob/10c7a00a64a6f0162cb18d52ead54f8fe7de94b0/keystone/assignment/core.py#L187 | 20:32 |
| samueldmq | bknudson: thanks | 20:32 |
| dstanek | crinkle: do you have a different role configured for member_role_name? | 20:32 |
| rcarrillocruz | crinkle: https://ask.openstack.org/en/question/4759/member-vs-_member_/ | 20:32 |
| samueldmq | crinkle: it's created on demand, see https://github.com/openstack/keystone/blob/10c7a00a64a6f0162cb18d52ead54f8fe7de94b0/keystone/assignment/core.py#L187 | 20:33 |
| rcarrillocruz | so no really defaults, just a recommendation and/or cargo-cult | 20:33 |
| samueldmq | brb | 20:33 |
| samueldmq | rcarrillocruz: cc | 20:33 |
| samueldmq | ^ | 20:33 |
| dstanek | htruta: what would need it? only our driver implementation should use it | 20:33 |
| *** fpatwa_ has quit IRC | 20:33 | |
| bknudson | we needed a role for when you assign a user to a project using the v2 API | 20:33 |
| htruta | dstanek: the legacy and the new driver. Either declare it there, or in each driver | 20:33 |
| crinkle | dtroyer: no | 20:33 |
| crinkle | er dstanek sorry | 20:33 |
| bknudson | legacy stuff | 20:34 |
| dstanek | htruta: but only the new driver version should use it so nothing else can be depending on it | 20:34 |
| *** jorge_munoz has joined #openstack-keystone | 20:35 | |
| crinkle | samueldmq: oh, so we need to give the user a default project before _member_ will be created? | 20:35 |
| htruta | dstanek: I'll see what happens when we move it | 20:35 |
| htruta | dstanek: but you're ok with this implementation on the endpoint conflict stuff, right? | 20:35 |
| *** jdennis has quit IRC | 20:37 | |
| *** jdennis has joined #openstack-keystone | 20:38 | |
| dstanek | htruta: i'm not sure. i'd have to look and see what the mysql docs say to do | 20:38 |
| *** sdake has quit IRC | 20:39 | |
| *** ericksonsantos has quit IRC | 20:45 | |
| samueldmq | crinkle: yes, using the v2 API | 20:49 |
| samueldmq | crinkle: then it will be created on first use, legacy stuff, as bknudson said | 20:50 |
| rcarrillocruz | crinkle: to be fair, ^ that tells me you should stick to 'user' role | 20:50 |
| rcarrillocruz | as, it won't matter | 20:50 |
| crinkle | rcarrillocruz: i concur, since we want to be using the v3 api anyway | 20:53 |
| rcarrillocruz | yup | 20:53 |
| crinkle | ty samueldmq and bknudson | 20:53 |
| rcarrillocruz | i +1'd your change | 20:53 |
| crinkle | \o/ | 20:53 |
| samueldmq | rcarrillocruz: np | 20:54 |
| *** rk4n has joined #openstack-keystone | 20:54 | |
| *** jdennis has quit IRC | 20:57 | |
| *** rk4n has quit IRC | 20:57 | |
| *** rk4n has joined #openstack-keystone | 20:58 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack/keystone: Cleanup from from split of token backend tests https://review.openstack.org/288622 | 21:01 |
| *** rk4n has quit IRC | 21:02 | |
| *** sdake has joined #openstack-keystone | 21:05 | |
| stevemar | samueldmq: your entire chain is approved! | 21:08 |
| *** rcarrillocruz has left #openstack-keystone | 21:08 | |
| samueldmq | stevemar: \o/ | 21:10 |
| samueldmq | bknudson: stevemar: thanks for the reviews :) | 21:10 |
| samueldmq | shaleh: ^ | 21:10 |
| lbragstad | stevemar quick question for you | 21:12 |
| lbragstad | and anyone else with opinion on how notification should be dealt with | 21:13 |
| lbragstad | stevemar it seems that we leverage most of our notification framework with `notification.Audit.<operation>` | 21:14 |
| lbragstad | it doesn't look like the original decorator is used anymore | 21:14 |
| lbragstad | stevemar should just go whole hog and issue *all* notifications with `notification.Audit.created` or do we still have a strong use case for keeping two implementations around? | 21:15 |
| *** __zouyee has joined #openstack-keystone | 21:15 | |
| shaleh | samueldmq: ^5 | 21:16 |
| *** raildo is now known as raildo-afk | 21:17 | |
| *** fangxu has joined #openstack-keystone | 21:18 | |
| lbragstad | or dstanek - since you're decorator savvy ^ | 21:18 |
| samueldmq | lbragstad: so we emit 2 types of notif ? | 21:19 |
| lbragstad | samueldmq we have two different ways to emit a notification | 21:19 |
| lbragstad | 1.) we either wrap a method with a notification decorator | 21:19 |
| lbragstad | 2.) we just use `notifications.Audit.created()` in the method. | 21:20 |
| samueldmq | lbragstad: do you want to use annotation for all cases? | 21:20 |
| stevemar | lbragstad: ohhh good point... i wonder if the decorator is used any more? | 21:20 |
| lbragstad | one way is this - notifications.Audit.updated(self._PROJECT, ret, initiator) | 21:21 |
| stevemar | lbragstad: i like the non-decorator approach | 21:21 |
| lbragstad | and the other is @notifications.role_assignment('created') | 21:21 |
| lbragstad | samueldmq the issue that i'm hitting is the inconsistency between the two implementations | 21:22 |
| samueldmq | lbragstad: what kind of inconsistency? | 21:22 |
| lbragstad | the decorated one only sends the resource ID that is being acted on | 21:22 |
| samueldmq | lbragstad: for write operations right ? (update/delete) | 21:22 |
| lbragstad | the inline method (`notifications.Audit.created()`) I swapped out the resource_id to be the resource reference so that we can include resource names in the notifications instead of just resource IDs | 21:23 |
| samueldmq | stevemar: I like either way :) | 21:23 |
| stevemar | lbragstad: notifications have been in need of a refactor for a while :) | 21:23 |
| samueldmq | stevemar: but I don't like usign lots of annotations in a single method, so if direct method call is clear, let's make it standard | 21:23 |
| lbragstad | stevemar ++ | 21:23 |
| *** roxanaghe has joined #openstack-keystone | 21:24 | |
| *** pauloewerton has quit IRC | 21:24 | |
| lbragstad | ok - so if we do this, we should probably change everything to use the same implementation | 21:24 |
| samueldmq | lbragstad: nice, so you're proposing we use only th direct calls everywhere (rather than annotated methods) | 21:24 |
| samueldmq | lbragstad: and add more info (resource names) | 21:24 |
| lbragstad | samueldmq yeah - unless people have a strong preference to keep the decorators | 21:24 |
| lbragstad | I can be convinced otherwise, but... | 21:24 |
| lbragstad | I'd rather have one implementation that handles all of our cases than two, where one handles all cases and one is just there because of the original implementation | 21:25 |
| samueldmq | lbragstad: completly agree on that | 21:25 |
| samueldmq | lbragstad: however if the one implementation should be decorator or not is the question | 21:25 |
| samueldmq | lbragstad: I am fine with direct calls, stevemar said he prefers it too | 21:25 |
| lbragstad | stevemar samueldmq cool - i suppose that should be broken out in a separate patch and not rolled into https://review.openstack.org/#/c/288643/ | 21:26 |
| patchbot | lbragstad: patch 288643 - keystone - Send notifications with entity name in payload | 21:26 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Send notifications with entity name in payload https://review.openstack.org/288643 | 21:28 |
| openstackgerrit | Sean Perry proposed openstack/keystone: Share engine between migration helpers. https://review.openstack.org/137778 | 21:28 |
| lbragstad | samueldmq stevemar updated - https://review.openstack.org/#/c/288643/2 | 21:30 |
| patchbot | lbragstad: patch 288643 - keystone - Send notifications with entity name in payload | 21:30 |
| shaleh | stevemar: thanks for the feedback on that migration patch. I am trying to clear out the list of lingering reviews. | 21:31 |
| stevemar | shaleh: i appreciate that! | 21:32 |
| shaleh | stevemar: there are plenty with mostly positive feedback but the original submitter just walked away | 21:32 |
| stevemar | shaleh: yes, i've noticed, makes them hard to abandon :\ | 21:32 |
| shaleh | stevemar: I made a list on the Keystone Office hours etherpad if you like | 21:32 |
| stevemar | shaleh: i'll take a peek | 21:33 |
| shaleh | stevemar: I have a list of likely abandon cases and another that the existing review is moribund and needs guidance. | 21:34 |
| stevemar | shaleh: i'd love the list of abandon-able ones :D | 21:34 |
| shaleh | stevemar: https://etherpad.openstack.org/p/keystone-office-hours <-- look for the abandon list. Links and all. | 21:35 |
| shaleh | stevemar: it is a short list currently, I have been chewing on it all week. | 21:35 |
| shaleh | stevemar: this is another Bug Friday kind of task we can assign people who understand what is happening but who lack +2 privs. | 21:36 |
| *** henrynash has joined #openstack-keystone | 21:37 | |
| *** ChanServ sets mode: +v henrynash | 21:37 | |
| *** roxanaghe has quit IRC | 21:37 | |
| *** __zouyee has quit IRC | 21:41 | |
| *** nkinder has quit IRC | 21:42 | |
| *** jorge_munoz has quit IRC | 21:43 | |
| stevemar | shaleh: abandoned a few, the revocation list one is still .... blah to me | 21:45 |
| shaleh | stevemar: yeah, I get that | 21:46 |
| *** knikolla has quit IRC | 21:48 | |
| *** roxanaghe has joined #openstack-keystone | 21:54 | |
| dstanek | lbragstad: decorators are evil! | 21:55 |
| dstanek | lbragstad: what were you referring to? | 21:55 |
| lbragstad | dstanek we seem to have two different ways to send notifications keystone | 21:55 |
| lbragstad | dstanek one was is with a decorator - which is how notifications were originally implemented (like, back in Folsom) | 21:56 |
| lbragstad | dstanek and the other way is to us an inline state like - `notifications.Audit.created()` inside the method that is doing the operation | 21:56 |
| * lbragstad dstanek this is because I'm working on fixing - https://bugs.launchpad.net/keystone/+bug/1552795 | 21:57 | |
| openstack | Launchpad bug 1552795 in OpenStack Identity (keystone) "enhance notification for user events with user name" [Undecided,In progress] - Assigned to Lance Bragstad (lbragstad) | 21:57 |
| lbragstad | dstanek and it seems like the decorated method of issuing notifications isn't really used much (most of the notification in keystone are issued with the inline statement) | 21:58 |
| lbragstad | dstanek so I propose that we either go one way or the other... | 21:58 |
| *** pcaruana has joined #openstack-keystone | 21:58 | |
| lbragstad | and make all notifications inline or decorators - because it will be easier to switch one implementation to accept/issue resource IDs and names than two | 21:59 |
| dstanek | lbragstad: you can't do everything via decorators because those only run before or after a function. you many need to notify based on things that happen in the function. | 21:59 |
| lbragstad | dstanek that's a good point | 21:59 |
| lbragstad | dstanek this goes without saying but the original implementation of notifications was only concerned about issuing the resource ID and that was it | 22:00 |
| lbragstad | as highlighted in that bug report above - people are starting to have use cases where they need more information outside of just an ID. | 22:00 |
| *** spzala has quit IRC | 22:01 | |
| dstanek | lbragstad: yeah, that makes sense. i can see why they would need that | 22:01 |
| lbragstad | i.e. as a consumer of keystone notifications - once you get an identity.uesr.deleted notification you can't exaclty ask keystone for more information with the ID | 22:01 |
| *** spzala has joined #openstack-keystone | 22:01 | |
| lbragstad | decorators always confuse me so I'm not opposed to this approach | 22:02 |
| *** roxanaghe has quit IRC | 22:04 | |
| *** roxanaghe has joined #openstack-keystone | 22:05 | |
| *** spzala has quit IRC | 22:06 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 22:07 |
| *** jbell8 has quit IRC | 22:07 | |
| *** ninag has quit IRC | 22:07 | |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove unused notification decorators https://review.openstack.org/288762 | 22:08 |
| lbragstad | dstanek stevemar samueldmq well - there is the start :) | 22:08 |
| *** jdennis has joined #openstack-keystone | 22:09 | |
| *** roxanaghe has quit IRC | 22:10 | |
| *** roxanaghe has joined #openstack-keystone | 22:10 | |
| *** e0ne has joined #openstack-keystone | 22:11 | |
| *** roxanagh_ has joined #openstack-keystone | 22:11 | |
| dstanek | lbragstad: nice. I'll take s look after dinner | 22:12 |
| stevemar | lbragstad: nice | 22:12 |
| *** roxanaghe has quit IRC | 22:12 | |
| stevemar | dstanek: dinner at 5? are you 50? | 22:12 |
| stevemar | or 80? | 22:12 |
| lbragstad | stevemar early dinners are the best! | 22:14 |
| stevemar | lbragstad: oh jeez | 22:14 |
| lbragstad | early dinner -> wheel of fortune -> bed time.. | 22:14 |
| stevemar | lbragstad: gonna have dinner, watch the wheel and bed | 22:15 |
| stevemar | lol | 22:15 |
| stevemar | wow | 22:15 |
| lbragstad | really... | 22:15 |
| *** spzala has joined #openstack-keystone | 22:15 | |
| lbragstad | stevemar that was weird | 22:15 |
| stevemar | lbragstad: save that for retirement! | 22:15 |
| stevemar | go watch the 10pm showing of deadpool | 22:15 |
| lbragstad | stevemar ++ awesome movie | 22:15 |
| *** gordc has quit IRC | 22:17 | |
| *** jdennis has quit IRC | 22:23 | |
| *** lhcheng has quit IRC | 22:25 | |
| *** petertr7 is now known as petertr7_away | 22:26 | |
| *** trown is now known as trown|outtypewww | 22:26 | |
| *** jdennis has joined #openstack-keystone | 22:27 | |
| *** jorge_munoz has joined #openstack-keystone | 22:27 | |
| *** fpatwa_ has joined #openstack-keystone | 22:30 | |
| *** jorge_munoz has quit IRC | 22:32 | |
| dstanek | stevemar: :p early dinner so i can beat the rush to my favorite all you can eat fish place | 22:32 |
| stevemar | dstanek: all you can eat fish? that's very specific | 22:33 |
| *** lhcheng has joined #openstack-keystone | 22:33 | |
| *** ChanServ sets mode: +v lhcheng | 22:33 | |
| *** fpatwa_ has quit IRC | 22:34 | |
| shaleh | gah, I really do not like the ones where it works in the debugger and fails in reality | 22:36 |
| shaleh | stevemar: I am working on that INIT_VERSION in migrate_repo patch. I get test failures because a db version is not returned. But when I use pdb to trace it everything looks fine. Yay. | 22:38 |
| stevemar | ha | 22:38 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove the notification.disabled decorator https://review.openstack.org/288776 | 22:38 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove _disable_project from the resource API https://review.openstack.org/288777 | 22:38 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove _disable_domain from the resource API https://review.openstack.org/288778 | 22:38 |
| stevemar | lbragstad: oh? | 22:40 |
| lbragstad | stevemar oh - yes | 22:40 |
| stevemar | lbragstad: i think any 'disabled' are always false | 22:41 |
| lbragstad | stevemar nope - they default to True | 22:44 |
| *** pushkaru has quit IRC | 22:44 | |
| *** pushkaru has joined #openstack-keystone | 22:44 | |
| lbragstad | stevemar https://github.com/openstack/keystone/blob/9d6ab5d6a9eb4fc07714a49666537333ccb58e20/keystone/notifications.py#L154 | 22:44 |
| *** sheel has joined #openstack-keystone | 22:45 | |
| stevemar | hmm, true | 22:48 |
| shaleh | stevemar, lbragstad WTF? http://paste.openstack.org/show/489406/ that patch is enough to break that test. I now get a '0' for the db version instead of 66 like expected. | 22:48 |
| shaleh | test_start_version_db_init_version() I mean. | 22:49 |
| *** henrynash has quit IRC | 22:50 | |
| *** e0ne has quit IRC | 22:55 | |
| *** slberger has quit IRC | 22:58 | |
| *** fangxu has quit IRC | 22:58 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 22:59 |
| *** edmondsw has quit IRC | 23:05 | |
| *** fangxu has joined #openstack-keystone | 23:08 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 23:09 |
| *** roxanagh_ has quit IRC | 23:09 | |
| *** slberger has joined #openstack-keystone | 23:13 | |
| *** e0ne has joined #openstack-keystone | 23:15 | |
| gyee | stevemar, morgan, it's OK to backport this one as it is API impact? https://bugs.launchpad.net/keystone/+bug/1541621 | 23:15 |
| openstack | Launchpad bug 1541621 in OpenStack Identity (keystone) "Invalid fernet X-Subject-Token token should result in 404 instead of 401" [Medium,Fix released] - Assigned to Lance Bragstad (lbragstad) | 23:15 |
| stevemar | gyee: propose it and see how it goes :P | 23:16 |
| gyee | stevemar, k, thanks | 23:16 |
| stevemar | gyee: i *just* released a new liberty version :P | 23:16 |
| gyee | ahhh | 23:16 |
| *** slberger1 has joined #openstack-keystone | 23:16 | |
| *** slberger has quit IRC | 23:18 | |
| openstackgerrit | Brant Knudson proposed openstack/keystone: WIP - Generate swagger https://review.openstack.org/287499 | 23:19 |
| stevemar | bknudson: you are up to no good with your swagger | 23:21 |
| bknudson | stevemar: paste http://paste.openstack.org/raw/489412/ into http://editor.swagger.io/#/ | 23:21 |
| bknudson | stevemar: I guess that doesn't work... maybe pastebin has a limit on the size | 23:23 |
| *** spzala has quit IRC | 23:24 | |
| bknudson | alternatively can checkout https://review.openstack.org/#/c/287499/ and then curl -H "Accept: application/swagger" http://localhost:35357/v3 | 23:24 |
| patchbot | bknudson: patch 287499 - keystone - WIP - Generate swagger | 23:24 |
| *** spzala has joined #openstack-keystone | 23:24 | |
| *** sdake has quit IRC | 23:25 | |
| stevemar | bknudson: i got most of it | 23:25 |
| stevemar | bknudson: that looks freaking sweet | 23:25 |
| stevemar | i am pretty sure bknudson is magical | 23:25 |
| bknudson | so what I think might work is we can merge this with the result of the docs swagger migration | 23:26 |
| *** pgbridge has quit IRC | 23:26 | |
| bknudson | I don't know if we actually want keystone to serve up the swagger doc, although maybe that would be useful, too. | 23:26 |
| *** roxanaghe has joined #openstack-keystone | 23:27 | |
| shaleh | bknudson: keystone serving it sounds like a good idea | 23:27 |
| *** spzala has quit IRC | 23:29 | |
| *** Trident has quit IRC | 23:33 | |
| *** fawadkhaliq has quit IRC | 23:38 | |
| *** fawadkhaliq has joined #openstack-keystone | 23:39 | |
| shaleh | I love fixing too cute code. | 23:49 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Consolidate @notifications.internal into Audit https://review.openstack.org/288798 | 23:49 |
| openstackgerrit | Lance Bragstad proposed openstack/keystone: Remove unused notification method and class https://review.openstack.org/288799 | 23:49 |
| shaleh | property foo in the parent class that only subclasses make work by having a _foo variable. Code half uses property and half doesn't. | 23:50 |
| *** spzala has joined #openstack-keystone | 23:55 | |
| *** slberger1 has left #openstack-keystone | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!