*** browne has quit IRC | 00:07 | |
*** sdake has quit IRC | 00:14 | |
openstackgerrit | Merged openstack/pycadf: Remove unused pngmath Sphinx extension https://review.openstack.org/286215 | 00:18 |
---|---|---|
*** henrynash has quit IRC | 00:21 | |
*** henrynash has joined #openstack-keystone | 00:21 | |
*** ChanServ sets mode: +v henrynash | 00:21 | |
*** mylu has quit IRC | 00:21 | |
openstackgerrit | Merged openstack/keystone: Use requst local in-process cache per request https://review.openstack.org/272007 | 00:30 |
*** boris-42 has quit IRC | 00:34 | |
*** markvoelker has quit IRC | 00:38 | |
*** mylu has joined #openstack-keystone | 00:39 | |
openstackgerrit | henry-nash proposed openstack/keystone: Projects acting as domains https://review.openstack.org/231289 | 00:42 |
*** fangxu has quit IRC | 00:52 | |
kfox1111 | whats the legacy_endpoint_id in keystone? | 00:59 |
*** mylu has quit IRC | 01:02 | |
*** fangxu has joined #openstack-keystone | 01:05 | |
henrynash | stevemar: I fixed the merge issue between projects as a domain and the (now merged) https://review.openstack.org/#/c/272007/ | 01:05 |
patchbot | henrynash: patch 272007 - keystone - Use requst local in-process cache per request (MERGED) | 01:05 |
*** EinstCrazy has joined #openstack-keystone | 01:06 | |
henrynash | stevemar: At the moment it looks like this will beat shadow users in, so I’ll let you +2A it (https://review.openstack.org/#/c/231289/64) | 01:07 |
patchbot | henrynash: patch 231289 - keystone - Projects acting as domains | 01:07 |
*** mylu has joined #openstack-keystone | 01:08 | |
*** jasonsb has joined #openstack-keystone | 01:12 | |
openstackgerrit | Merged openstack/python-keystoneclient: Update developer docs for keystoneauth session https://review.openstack.org/285817 | 01:13 |
*** jorge_munoz has quit IRC | 01:14 | |
stevemar | thanks henrynash | 01:17 |
*** sigmavirus24 is now known as sigmavirus24_awa | 01:17 | |
*** henrynash has quit IRC | 01:31 | |
*** sheel has joined #openstack-keystone | 01:36 | |
*** markvoelker has joined #openstack-keystone | 01:38 | |
*** dan_nguyen has quit IRC | 01:42 | |
*** ninag has joined #openstack-keystone | 01:45 | |
*** jamielennox is now known as jamielennox|away | 01:45 | |
*** mylu has quit IRC | 01:49 | |
*** ninag has quit IRC | 01:50 | |
*** mylu has joined #openstack-keystone | 01:54 | |
*** lhcheng has quit IRC | 01:55 | |
*** mylu has quit IRC | 01:56 | |
*** doug-fish has quit IRC | 01:58 | |
*** dims has quit IRC | 02:04 | |
*** mylu has joined #openstack-keystone | 02:05 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Shadow users - Shadow federated users https://review.openstack.org/279162 | 02:06 |
*** markvoelker has quit IRC | 02:08 | |
*** markvoelker has joined #openstack-keystone | 02:08 | |
*** dims has joined #openstack-keystone | 02:08 | |
*** bjornar has quit IRC | 02:11 | |
*** dims has quit IRC | 02:13 | |
*** mylu has quit IRC | 02:15 | |
*** dims has joined #openstack-keystone | 02:17 | |
*** mylu has joined #openstack-keystone | 02:18 | |
*** mylu_ has joined #openstack-keystone | 02:19 | |
*** mylu has quit IRC | 02:20 | |
*** bjornar has joined #openstack-keystone | 02:20 | |
*** mylu_ has quit IRC | 02:22 | |
*** mylu has joined #openstack-keystone | 02:25 | |
*** mylu has quit IRC | 02:27 | |
*** fawadkhaliq has quit IRC | 02:27 | |
*** ninag has joined #openstack-keystone | 02:31 | |
*** blogan has quit IRC | 02:32 | |
*** mylu has joined #openstack-keystone | 02:38 | |
*** nisha has joined #openstack-keystone | 02:41 | |
*** fpatwa_ has joined #openstack-keystone | 02:43 | |
*** ninag has quit IRC | 02:44 | |
*** fpatwa__ has joined #openstack-keystone | 02:46 | |
*** fpatwa_ has quit IRC | 02:46 | |
*** fpatwa__ has quit IRC | 02:48 | |
*** fpatwa_ has joined #openstack-keystone | 02:51 | |
*** csoukup has joined #openstack-keystone | 02:51 | |
openstackgerrit | ayoung proposed openstack/keystone: Remove unneeded revocation events https://review.openstack.org/285134 | 02:54 |
*** csoukup has quit IRC | 02:55 | |
*** mylu has quit IRC | 03:04 | |
*** spandhe has quit IRC | 03:07 | |
*** fpatwa_ has quit IRC | 03:13 | |
*** bjornar has quit IRC | 03:15 | |
*** woodster_ has quit IRC | 03:16 | |
openstackgerrit | Pandiyan proposed openstack/keystone: Add driver details in architecture doc https://review.openstack.org/280802 | 03:19 |
*** dims has quit IRC | 03:19 | |
*** jorge_munoz has joined #openstack-keystone | 03:21 | |
*** mylu has joined #openstack-keystone | 03:22 | |
*** jorge_munoz has quit IRC | 03:22 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Add driver details in architecture doc https://review.openstack.org/280802 | 03:26 |
openstackgerrit | Steve Martinelli proposed openstack/keystone: add hints to list_services for templated backend https://review.openstack.org/286142 | 03:29 |
*** ninag has joined #openstack-keystone | 03:29 | |
*** Nakato has quit IRC | 03:31 | |
*** ninag has quit IRC | 03:33 | |
*** ninag has joined #openstack-keystone | 03:33 | |
*** ccard_ has quit IRC | 03:34 | |
*** richm has quit IRC | 03:37 | |
*** ninag has quit IRC | 03:37 | |
*** nisha_ has joined #openstack-keystone | 03:39 | |
*** nisha has quit IRC | 03:43 | |
*** dave-mccowan has quit IRC | 03:45 | |
*** Nakato has joined #openstack-keystone | 03:45 | |
*** ccard_ has joined #openstack-keystone | 03:47 | |
*** links has joined #openstack-keystone | 03:49 | |
*** chlong_ has quit IRC | 04:03 | |
*** tellesnobrega is now known as tellesnobrega_af | 04:12 | |
*** nisha_ has quit IRC | 04:14 | |
*** fangxu has quit IRC | 04:16 | |
*** fawadkhaliq has joined #openstack-keystone | 04:18 | |
*** sheel has quit IRC | 04:27 | |
*** fpatwa_ has joined #openstack-keystone | 04:44 | |
*** diazjf has joined #openstack-keystone | 04:57 | |
*** nisha has joined #openstack-keystone | 05:02 | |
*** blogan_ has joined #openstack-keystone | 05:18 | |
*** spandhe has joined #openstack-keystone | 05:25 | |
*** mylu has quit IRC | 05:30 | |
*** fpatwa_ has quit IRC | 05:33 | |
*** mylu has joined #openstack-keystone | 05:34 | |
*** fawadkhaliq has quit IRC | 05:42 | |
*** mylu has quit IRC | 05:46 | |
*** mylu has joined #openstack-keystone | 05:47 | |
*** jaosorior has joined #openstack-keystone | 05:49 | |
*** fawadkhaliq has joined #openstack-keystone | 05:58 | |
*** sheel has joined #openstack-keystone | 06:02 | |
*** Nirupama has joined #openstack-keystone | 06:04 | |
*** spandhe_ has joined #openstack-keystone | 06:06 | |
*** spandhe has quit IRC | 06:08 | |
*** spandhe_ is now known as spandhe | 06:08 | |
*** rcernin has joined #openstack-keystone | 06:09 | |
*** sdake has joined #openstack-keystone | 06:11 | |
*** nisha_ has joined #openstack-keystone | 06:15 | |
*** nisha has quit IRC | 06:19 | |
*** Nirupama has quit IRC | 06:20 | |
*** e0ne has joined #openstack-keystone | 06:23 | |
*** Nirupama has joined #openstack-keystone | 06:24 | |
*** sdake has quit IRC | 06:27 | |
*** diazjf has quit IRC | 06:29 | |
*** e0ne has quit IRC | 06:31 | |
*** sdake has joined #openstack-keystone | 06:33 | |
*** e0ne has joined #openstack-keystone | 06:33 | |
*** e0ne has quit IRC | 06:34 | |
*** mariusv has quit IRC | 06:35 | |
*** roxanaghe has quit IRC | 06:39 | |
*** lhcheng has joined #openstack-keystone | 06:40 | |
*** ChanServ sets mode: +v lhcheng | 06:40 | |
*** mylu has quit IRC | 06:45 | |
*** fangxu has joined #openstack-keystone | 06:49 | |
*** Nirupama has quit IRC | 06:51 | |
*** lunarlamp has joined #openstack-keystone | 06:56 | |
*** nisha_ has quit IRC | 07:01 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Fix the migration issue for the user doesn't have a password https://review.openstack.org/285152 | 07:05 |
*** fangxu has quit IRC | 07:08 | |
*** sdake has quit IRC | 07:10 | |
*** sdake has joined #openstack-keystone | 07:12 | |
*** spandhe has quit IRC | 07:15 | |
EinstCrazy | does anyone know how to create a default domain? | 07:16 |
*** henrynash has joined #openstack-keystone | 07:17 | |
*** ChanServ sets mode: +v henrynash | 07:17 | |
*** fangxu has joined #openstack-keystone | 07:21 | |
*** henrynash has quit IRC | 07:23 | |
*** lhcheng has quit IRC | 07:32 | |
*** fpatwa_ has joined #openstack-keystone | 07:33 | |
*** Nirupama has joined #openstack-keystone | 07:34 | |
*** fpatwa_ has quit IRC | 07:38 | |
*** lhcheng has joined #openstack-keystone | 07:38 | |
*** ChanServ sets mode: +v lhcheng | 07:38 | |
*** roxanaghe has joined #openstack-keystone | 07:39 | |
*** roxanaghe has quit IRC | 07:44 | |
*** sdake has quit IRC | 07:48 | |
*** lhcheng has quit IRC | 07:59 | |
*** belmoreira has joined #openstack-keystone | 08:01 | |
*** fawadkhaliq has quit IRC | 08:08 | |
*** pcaruana has joined #openstack-keystone | 08:09 | |
*** lhcheng has joined #openstack-keystone | 08:22 | |
*** ChanServ sets mode: +v lhcheng | 08:22 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: Return 404 instead of 401 for tokens w/o roles https://review.openstack.org/277436 | 08:23 |
*** henrynash has joined #openstack-keystone | 08:37 | |
*** ChanServ sets mode: +v henrynash | 08:37 | |
*** daemontool__ has joined #openstack-keystone | 08:38 | |
*** rk4n has joined #openstack-keystone | 08:39 | |
*** roxanaghe has joined #openstack-keystone | 08:41 | |
*** daemontool_ has quit IRC | 08:41 | |
*** fhubik has joined #openstack-keystone | 08:44 | |
*** roxanaghe has quit IRC | 08:46 | |
*** openstackgerrit has quit IRC | 08:48 | |
*** openstackgerrit has joined #openstack-keystone | 08:48 | |
openstackgerrit | henry-nash proposed openstack/keystone: Deprecate domain driver interface methods https://review.openstack.org/286452 | 09:04 |
*** fangxu has quit IRC | 09:04 | |
*** rk4n has quit IRC | 09:06 | |
*** lhcheng has quit IRC | 09:07 | |
*** rk4n has joined #openstack-keystone | 09:08 | |
*** jistr has joined #openstack-keystone | 09:14 | |
*** fhubik has quit IRC | 09:24 | |
*** fhubik has joined #openstack-keystone | 09:27 | |
*** e0ne has joined #openstack-keystone | 09:28 | |
*** fpatwa_ has joined #openstack-keystone | 09:34 | |
henrynash | stevemar: there’s a follow up patch to projects acting as domains (https://review.openstack.org/#/c/286452/1) - no functional changes, but deprecating domain driver methods…getting this in would allow us to remove this in L | 09:36 |
patchbot | henrynash: patch 286452 - keystone - Deprecate domain driver interface methods | 09:36 |
henrynash | stevemar: not a bug deal if we don’t get this in, but good to get things depreacted as soon as we can | 09:36 |
samueldmq | morning keystoners | 09:37 |
*** fhubik has quit IRC | 09:38 | |
*** e0ne has quit IRC | 09:38 | |
henrynash | samueldmq: one thing for you to take a quick squint at: there’s a follow up patch to projects acting as domains (https://review.openstack.org/#/c/286452/1) - no functional changes, but deprecating domain driver methods…getting this in would allow us to remove this in L | 09:38 |
patchbot | henrynash: patch 286452 - keystone - Deprecate domain driver interface methods | 09:38 |
*** fpatwa_ has quit IRC | 09:38 | |
samueldmq | henrynash: sure | 09:39 |
henrynash | samueldmq: thx….leaving the domain table for now, we can remove that later | 09:39 |
samueldmq | henrynash: shadow users and domains as projs still on gate ? :( | 09:39 |
henrynash | samueldmq: so shadow users failed jenkins…so has been re-submitted…. | 09:40 |
henrynash | samueldmq: projs as a domain is close to merging | 09:40 |
*** rha has joined #openstack-keystone | 09:40 | |
*** rha has quit IRC | 09:40 | |
*** rha has joined #openstack-keystone | 09:40 | |
*** roxanaghe has joined #openstack-keystone | 09:42 | |
samueldmq | henrynash: nice, +2'ed 286452, looks neat | 09:43 |
henrynash | samueldmq: thx | 09:44 |
*** mylu has joined #openstack-keystone | 09:45 | |
*** roxanaghe has quit IRC | 09:46 | |
*** mylu has quit IRC | 09:50 | |
samueldmq | henrynash: so is_domain in tokens will wait for next cycle ? | 09:51 |
henrynash | samuelmdq: I’d love to get it in….but not sure we have time | 09:51 |
samueldmq | henrynash: same to me; that would be a good step forward | 09:52 |
samueldmq | henrynash: since we have announced to others this new way to deal with domain scoped tokens | 09:52 |
samueldmq | (specially horizon) | 09:52 |
*** EinstCrazy has quit IRC | 09:54 | |
samueldmq | henrynash: looks like the change is trivial ? https://review.openstack.org/#/c/197331 | 09:54 |
*** EinstCrazy has joined #openstack-keystone | 09:54 | |
henrynash | samueldmq: yes, might try to work up a patch…but have to head out for a couple of hours | 09:55 |
henrynash | samueldmq: might get it done before I head out…hold on! | 10:00 |
samueldmq | henrynash: great, I may give another updates if needed, perhaps htruta and raildo-afk too | 10:01 |
openstackgerrit | henry-nash proposed openstack/keystone: Add is_domain in token response https://review.openstack.org/197331 | 10:02 |
samueldmq | henrynash: that was quick! | 10:03 |
henrynash | samuedlmq: I thought it would need fixing up but the rebase rsolved the errors! | 10:04 |
samueldmq | henrynash: do you think it needs more tests ? like in test_v3_auth ? | 10:04 |
samueldmq | henrynash: nice | 10:04 |
henrynash | samueldmq: it may well do…take a look and feel free to add | 10:05 |
samueldmq | henrynash: sure | 10:05 |
*** henrynash has quit IRC | 10:05 | |
*** e0ne has joined #openstack-keystone | 10:11 | |
*** Nirupama has quit IRC | 10:13 | |
*** EinstCrazy has quit IRC | 10:15 | |
*** EinstCrazy has joined #openstack-keystone | 10:16 | |
*** EinstCrazy has quit IRC | 10:21 | |
*** GB21 has joined #openstack-keystone | 10:34 | |
-openstackstatus- NOTICE: Gerrit is going to be restarted due to poor performance | 10:36 | |
*** ChanServ changes topic to "Gerrit is going to be restarted due to poor performance" | 10:36 | |
*** daemontool has joined #openstack-keystone | 10:36 | |
*** daemontool__ has quit IRC | 10:40 | |
*** ChanServ changes topic to "mitaka-3 feature freeze on FEB 29 - please prioritize reviews accordingly! | Mitaka-3: https://launchpad.net/keystone/+milestone/mitaka-3" | 10:42 | |
-openstackstatus- NOTICE: gerrit finished restartign | 10:42 | |
*** roxanaghe has joined #openstack-keystone | 10:42 | |
*** rcarrillocruz has joined #openstack-keystone | 10:47 | |
*** roxanaghe has quit IRC | 10:47 | |
rcarrillocruz | heya folks | 10:51 |
rcarrillocruz | i'm trying to test out some ansible/shade features with keystone v3 | 10:51 |
rcarrillocruz | not finding instructions on how to setup devstack with keystone v3 | 10:52 |
rcarrillocruz | saw https://review.openstack.org/#/c/274703/ | 10:52 |
patchbot | rcarrillocruz: patch 274703 - openstack-dev/devstack - Revert "Move default Keystone API version to v3" (MERGED) | 10:52 |
rcarrillocruz | apparently there are issues | 10:52 |
rcarrillocruz | how folks do keystone v3 for their daily testing? any pointers? | 10:52 |
*** rvba` is now known as rvba | 10:59 | |
*** chlong_ has joined #openstack-keystone | 11:01 | |
*** mvk has quit IRC | 11:03 | |
*** dims has joined #openstack-keystone | 11:03 | |
*** tellesnobrega_af is now known as tellesnobrega | 11:08 | |
*** mvk has joined #openstack-keystone | 11:20 | |
*** rodrigods has quit IRC | 11:29 | |
*** rodrigods has joined #openstack-keystone | 11:29 | |
*** henrynash has joined #openstack-keystone | 11:31 | |
*** ChanServ sets mode: +v henrynash | 11:31 | |
*** fpatwa_ has joined #openstack-keystone | 11:35 | |
*** fpatwa_ has quit IRC | 11:39 | |
henrynash | samueldmq: on the is_domain token, looking at the testing, I think there is quite a lot of work….I’ll do more later today, but I think it looks too much to get in for m3 | 11:45 |
*** mylu has joined #openstack-keystone | 11:46 | |
*** mylu has quit IRC | 11:51 | |
*** Nirupama has joined #openstack-keystone | 11:53 | |
*** mylu has joined #openstack-keystone | 11:58 | |
*** mhickey has joined #openstack-keystone | 12:06 | |
*** bjornar__ has quit IRC | 12:07 | |
*** daemontool_ has joined #openstack-keystone | 12:07 | |
*** pauloewerton has joined #openstack-keystone | 12:07 | |
*** bjornar__ has joined #openstack-keystone | 12:09 | |
*** daemontool has quit IRC | 12:10 | |
openstackgerrit | Merged openstack/keystone-specs: Fix cascade operations documentation https://review.openstack.org/274836 | 12:17 |
*** raildo-afk is now known as raildo | 12:18 | |
*** Nirupama has quit IRC | 12:20 | |
*** GB21 has quit IRC | 12:23 | |
*** henrynash has quit IRC | 12:26 | |
*** dave-mccowan has joined #openstack-keystone | 12:27 | |
*** daemontool__ has joined #openstack-keystone | 12:34 | |
*** jaosorior has quit IRC | 12:36 | |
*** jaosorior has joined #openstack-keystone | 12:37 | |
*** daemontool_ has quit IRC | 12:37 | |
*** gordc has joined #openstack-keystone | 12:40 | |
openstackgerrit | Merged openstack/keystone: Projects acting as domains https://review.openstack.org/231289 | 12:41 |
*** roxanaghe has joined #openstack-keystone | 12:44 | |
openstackgerrit | Merged openstack/keystone: Shadow users - Shadow federated users https://review.openstack.org/279162 | 12:44 |
*** roxanaghe has quit IRC | 12:48 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/286565 | 12:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/286565 | 13:01 |
*** dims has quit IRC | 13:02 | |
*** links has quit IRC | 13:07 | |
*** dims has joined #openstack-keystone | 13:08 | |
*** sdake has joined #openstack-keystone | 13:16 | |
*** ninag has joined #openstack-keystone | 13:20 | |
*** sdake has quit IRC | 13:21 | |
*** sdake has joined #openstack-keystone | 13:21 | |
*** ninag has quit IRC | 13:22 | |
*** ninag has joined #openstack-keystone | 13:22 | |
*** mylu has quit IRC | 13:24 | |
openstackgerrit | Raildo Mascena proposed openstack/keystone: Constraint to prevent duplicate endpoints https://review.openstack.org/134095 | 13:31 |
raildo | stevemar: rebased ^ | 13:31 |
*** richm has joined #openstack-keystone | 13:36 | |
*** fpatwa_ has joined #openstack-keystone | 13:36 | |
*** mylu has joined #openstack-keystone | 13:36 | |
*** fpatwa_ has quit IRC | 13:40 | |
breton | raildo: is something missing in https://review.openstack.org/#/c/134095/20/keystone/tests/unit/test_sql_upgrade.py ? | 13:48 |
patchbot | breton: patch 134095 - keystone - Constraint to prevent duplicate endpoints | 13:48 |
raildo | breton: I don't think so, if you make a diff, you'll see that we just change the script number in related tests on the last patches (for example https://review.openstack.org/#/c/134095/17..20/keystone/tests/unit/test_sql_upgrade.py) | 13:50 |
patchbot | raildo: patch 134095 - keystone - Constraint to prevent duplicate endpoints | 13:50 |
*** sdake_ has joined #openstack-keystone | 13:50 | |
breton | CONF.shadow_users.driver | 13:51 |
breton | this thing broke me with existing config | 13:51 |
raildo | breton: I ran the tests here and works, but I'll do a double check on it | 13:52 |
breton | raildo: yeah, it won't fail -- there is no test. | 13:52 |
breton | raildo: "test_endpoint_unique_constraint_fails_if_duplicates" has not assertions or any places where it could fail | 13:53 |
breton | raildo: because it doesn't even upgrade to 95 | 13:53 |
*** mylu has quit IRC | 13:54 | |
*** sdake has quit IRC | 13:54 | |
raildo | breton: I see, I'll fix this, we should expect a error when we upgrade to 95 | 13:55 |
raildo | breton: thanks | 13:55 |
breton | cool | 13:55 |
*** diazjf has joined #openstack-keystone | 13:56 | |
*** mylu has joined #openstack-keystone | 14:00 | |
openstackgerrit | Merged openstack/keystone: Add driver details in architecture doc https://review.openstack.org/280802 | 14:05 |
samueldmq | Change 231289 has been successfully merged into the git repository by Jenkins | 14:05 |
samueldmq | raildo: htruta ^ | 14:06 |
samueldmq | patch 231289 | 14:06 |
patchbot | samueldmq: https://review.openstack.org/#/c/231289/ - keystone - Projects acting as domains (MERGED) | 14:06 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/286565 | 14:07 |
raildo | samueldmq: we are the champions, my friend \o/ | 14:07 |
samueldmq | raildo: :) | 14:10 |
*** mylu has quit IRC | 14:14 | |
*** jamie_h has joined #openstack-keystone | 14:15 | |
*** petertr7_away is now known as petertr7 | 14:17 | |
*** sdake_ is now known as sdake | 14:19 | |
*** henrynash has joined #openstack-keystone | 14:20 | |
*** ChanServ sets mode: +v henrynash | 14:20 | |
*** jsavak has joined #openstack-keystone | 14:22 | |
*** woodster_ has joined #openstack-keystone | 14:24 | |
breton | raildo: http://paste.openstack.org/show/488756/ what am I doing wrong? | 14:24 |
breton | that's on clean mysql database | 14:26 |
raildo | breton: you need to set up the region_id, the constraint is enforced by service_id, region_id and interface | 14:26 |
breton | so if there is no region_id, there still can be duplicate endpoints? | 14:27 |
breton | what if i don't care about region, because i have only one? | 14:27 |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Closure table for HMT https://review.openstack.org/285521 | 14:27 |
raildo | breton: hum... I think so | 14:27 |
raildo | I think that constraint doesn't works with none values | 14:28 |
*** henrynash has quit IRC | 14:29 | |
raildo | breton: if you just have one region, you can use this region to create the endpoint | 14:29 |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Closure table for HMT https://review.openstack.org/285521 | 14:29 |
breton | raildo: ok, what if i have 0 regions? :) | 14:30 |
breton | I really don't know if it's real-life scenario | 14:30 |
amakarov | dolphm, notmorgan Hi! Please take a look at the closure table patch ^^ | 14:30 |
raildo | breton: me nether :P | 14:30 |
raildo | breton: we can ask for a core view on this point | 14:31 |
*** edmondsw has joined #openstack-keystone | 14:31 | |
*** henrynash has joined #openstack-keystone | 14:39 | |
*** ChanServ sets mode: +v henrynash | 14:39 | |
*** EinstCrazy has joined #openstack-keystone | 14:39 | |
*** d0ugal has quit IRC | 14:39 | |
*** d0ugal has joined #openstack-keystone | 14:40 | |
*** d0ugal has quit IRC | 14:40 | |
*** mylu has joined #openstack-keystone | 14:41 | |
*** d0ugal has joined #openstack-keystone | 14:41 | |
*** GB21 has joined #openstack-keystone | 14:42 | |
*** sdake has quit IRC | 14:49 | |
*** EinstCrazy has quit IRC | 14:50 | |
*** EinstCrazy has joined #openstack-keystone | 14:50 | |
*** knikolla has joined #openstack-keystone | 14:51 | |
*** daemontool_ has joined #openstack-keystone | 14:53 | |
*** doug-fish has joined #openstack-keystone | 14:55 | |
*** sdake has joined #openstack-keystone | 14:56 | |
*** daemontool__ has quit IRC | 14:56 | |
*** e0ne has quit IRC | 14:56 | |
henrynash | ayoung, stevemar: see if you think it’s OK to get https://review.openstack.org/#/c/286452/ in the m3 | 14:57 |
patchbot | henrynash: patch 286452 - keystone - Deprecate domain driver interface methods | 14:57 |
*** edmondsw has quit IRC | 14:57 | |
ayoung | henrynash, just deprecate? Probably. Will be noisy | 14:57 |
ayoung | But we have to do it at some point | 14:57 |
henrynash | ayoung: no…its only the driver methods…nothing calls them anymore | 14:57 |
lbragstad | xek dstanek ping | 14:58 |
ayoung | henrynash, ah | 14:58 |
henrynash | ayoung: not going to deprecate the manager methods until next release | 14:58 |
ayoung | henrynash, yeah, then that is appropriate | 14:58 |
xek | lbragstad, hi | 14:58 |
lbragstad | xek dstanek available to visit? | 14:58 |
*** csoukup has joined #openstack-keystone | 14:58 | |
*** mylu has quit IRC | 14:59 | |
ayoung | henrynash, so, one thing to consider for Newton. Everything we deprecate should go into one set of tests, and be callable with a flag that disables the deprecation warnings, so the unit tests can run clean. All The non-deprecate tests run without that flag, and have a top tlevel check that no deprecation warnings were thrown | 15:00 |
henrynash | ayoung: be back on soon | 15:00 |
*** henrynash has quit IRC | 15:00 | |
xek | lbragstad, dstanek, dolphm, I started an etherpad https://etherpad.openstack.org/p/keystone-online-schema-migrations | 15:01 |
xek | the main thing that interests me is what cases do you think should be tested | 15:01 |
*** fawadkhaliq has joined #openstack-keystone | 15:02 | |
*** mylu has joined #openstack-keystone | 15:02 | |
xek | I plan on working on the simplest case next week, that is upgrade the DB schema to the latest version, then run tempest from the stable version | 15:02 |
lbragstad | xek not sure if you reviewed it yet but we took a bunch of notes at the mid-cycle https://etherpad.openstack.org/p/keystone-mitaka-midcycle | 15:02 |
*** spandhe has joined #openstack-keystone | 15:03 | |
*** spandhe has quit IRC | 15:03 | |
xek | lbragstad, I'm browsing it now... | 15:03 |
lbragstad | xek so you mean to upgrade the keystone database to the latest, run keystone at stable/liberty and run tempest against that? | 15:03 |
lbragstad | xek most of the notes are in "Thursday PM" section | 15:04 |
xek | lbragstad, yes | 15:04 |
*** mylu has quit IRC | 15:05 | |
dstanek | xek: I think what you had is fine, but we just were ready for it yet | 15:06 |
dstanek | Weren't | 15:06 |
lbragstad | dstanek and a big reason for that was shadow users, right? | 15:06 |
dstanek | There is still lots of details that need to be worked out | 15:06 |
lbragstad | dstanek there were other things going in too though | 15:06 |
xek | did you decide at the meeting on which approach to take? | 15:07 |
dstanek | lbragstad: yes and likely all of the project work too | 15:07 |
xek | "update schema (expand), update code, convert data (migrate), prune schema (contract)" - this was my proposal | 15:07 |
dstanek | xek: no | 15:07 |
lbragstad | xek we didn't finalize a direction | 15:07 |
lbragstad | xek we talked about each of the options | 15:07 |
lbragstad | xek the interesting idea that we came up with was the PoC project | 15:08 |
xek | or, to be more precise, this is what nova does | 15:08 |
dstanek | xek: there are still took many details missing. Like how updates happen. Keystone first or db first? How do we do breaking changes? | 15:09 |
xek | in the POC project, on which databases do you think the migrations should be tested? | 15:10 |
lbragstad | xek we were thinking we'd create a really simple application that isn't openstack specific | 15:10 |
lbragstad | xek and the application would have database migrations | 15:11 |
lbragstad | and we could automate upgrading and downgrading the databse | 15:11 |
lbragstad | and the idea would be to observe the amount of "jitter" | 15:11 |
lbragstad | noticeable through the application because of the migrations | 15:11 |
lbragstad | dstanek that was the gist of it right? | 15:12 |
dstanek | We also talked about the zero downtime language and we're uncomfortable saying we could really be zero. That's one reason for the poc | 15:12 |
*** EinstCrazy has quit IRC | 15:12 | |
lbragstad | yeah - especially since part of it depends on the architecture | 15:13 |
xek | from the two approaches, I see that the consensus is that the expand/contract should be done in the same release? | 15:13 |
dstanek | lbragstad: exactly | 15:13 |
xek | and the POC would be implemented for the two scenarios? | 15:14 |
lbragstad | xek yeah that was another part of the discussion - how do we make it so that we don't have migrations that last 3 cycles | 15:14 |
lbragstad | xek it could be | 15:14 |
xek | have you thought if we would use sqlalchemy with alembic or sqlalchemy migrations? | 15:14 |
xek | how far should we differentiate from current keystone implementation? | 15:15 |
dstanek | xek: we have talked about moving to alembic in general | 15:15 |
dstanek | xek: are you talking about the poc? | 15:16 |
xek | yes | 15:16 |
dstanek | Good question | 15:17 |
lbragstad | I thought we mentioned just using oslo_db to interact with the database | 15:17 |
lbragstad | but I'm not sure about the migrations | 15:18 |
lbragstad | iirc it sounds like sqlalchemy migrations that were very similar to what keystone has | 15:18 |
lbragstad | sounded* | 15:18 |
*** sdake_ has joined #openstack-keystone | 15:20 | |
dstanek | xek: i'm not really sure that it matters for this particular test | 15:20 |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:20 | |
dstanek | xek: i think we'd stick with sqlalchemy-migration | 15:20 |
*** mylu has joined #openstack-keystone | 15:21 | |
xek | lbragstad, yes... I asked this question, because nova experimented with expand/contract migrations in one release, but later dropped it, because it included large experimental changes which didn't work | 15:21 |
lbragstad | xek do you recall what the major reasons were why it didn't work? | 15:22 |
xek | they tried to generate the sql migrations online, by looking at the current db state | 15:22 |
xek | and it didn't work as planned... | 15:23 |
*** sdake has quit IRC | 15:23 | |
*** daemontool__ has joined #openstack-keystone | 15:24 | |
xek | I think doing this poc is a great idea, when do we start? :) | 15:24 |
*** mylu has quit IRC | 15:24 | |
lbragstad | dstanek xek so - do you think we should start this by adding the CI first or the PoC? | 15:25 |
lbragstad | I think we should lean towards the PoC | 15:25 |
lbragstad | first | 15:25 |
dstanek | poc | 15:25 |
dstanek | lbragstad: i don't think we should do anything until we define the upgrade process | 15:25 |
xek | I'm not sure, because if we want to copy the nova approach, which I think is already proven, than we can start with the CI | 15:26 |
lbragstad | and in order to do that we need the results from the PoC | 15:26 |
xek | however, if we want to create something new, the poc would be the starting point | 15:26 |
lbragstad | but did the nova approach work? | 15:26 |
dstanek | xek: how do they do breaking changes? | 15:27 |
xek | lbragstad, yes, they are following the standard of not changing the schema in non addititive way | 15:27 |
breton | alembic didn't work out because we wanted to rely on oslo_db, and oslo_db part was not ready yet | 15:27 |
xek | they also test a multinode setup with grenade | 15:27 |
lbragstad | xek so they *only* ever add things | 15:27 |
*** daemontool_ has quit IRC | 15:28 | |
breton | and I also heard that zzzeek wanted to add ability to run sa-m migrations in alembic. I am not sure how far that went. | 15:28 |
xek | they remove things a cycle after removing the code which uses them | 15:28 |
dstanek | xek: that removal potentially causes downtime right? | 15:29 |
lbragstad | dstanek yep - I think it can | 15:29 |
xek | it may cause locks on the db | 15:29 |
dstanek | so basically instead of doing that when a deployer gets the feature we do it the next release? what does that save us? | 15:30 |
xek | the old code may still run and use the db as if the schema didn't change | 15:32 |
dstanek | xek: when is the code updated in the process of an upgrade? | 15:32 |
xek | after changing the schema | 15:33 |
dstanek | xek: so how do you do a change that is not compatible? can we no longer do that ever? | 15:34 |
*** jorge_munoz has joined #openstack-keystone | 15:34 | |
*** slberger has joined #openstack-keystone | 15:34 | |
xek | dstanek, making non compatible changes would happen in a couple of releases | 15:34 |
xek | for example: | 15:35 |
xek | 1. add a column in first release | 15:35 |
xek | this release uses an old column and the new column to migrate the data | 15:35 |
xek | 2. stop using the old column | 15:35 |
xek | 3. remove the column at the beginning of the third release which doesn't use it | 15:36 |
*** mylu has joined #openstack-keystone | 15:37 | |
*** fpatwa_ has joined #openstack-keystone | 15:37 | |
dstanek | xek: that's a vey simple case, what about something like http://git.openstack.org/cgit/openstack/keystone/commit/?id=312a041862dc48b776715ccb2585d21cc479f5fb | 15:38 |
xek | release 0+1 can run together, as well as releases 1+2, 2+3 | 15:38 |
dstanek | or any of the project as domain work we are currently doing | 15:38 |
dstanek | what is "0+1" referring to? | 15:38 |
*** mylu has quit IRC | 15:39 | |
xek | dstanek, release 0 (the old release) can run with release 1, using the schema from release 1 | 15:39 |
dstanek | xek: that's why we aren't ready yet. too many things happening in M (and N) that violate that | 15:40 |
*** fpatwa_ has quit IRC | 15:41 | |
*** mylu has joined #openstack-keystone | 15:42 | |
xek | dstanek, maybe the new release would not support the new feature, until a change is made in the config | 15:42 |
*** ryanpetrello has quit IRC | 15:43 | |
xek | after enabling it, we would stop being backward compatible by not using the old tables | 15:43 |
*** ryanpetrello has joined #openstack-keystone | 15:44 | |
dstanek | xek: that's possible, but we'd have to do migrations only at that time. so there are still issues to be worked out | 15:44 |
stevemar | o/ | 15:45 |
dstanek | stevemar: hola | 15:47 |
xek | dstanek, nova does this by running migration scripts | 15:47 |
xek | dstanek, the scripts can be run when convenient, outside of the schema changes | 15:48 |
dstanek | xek: so they have instructions to run a particular migration if a feature is turned on? | 15:49 |
dstanek | xek: will that migration ever be forced? | 15:49 |
xek | I agree it is extra work | 15:50 |
xek | it is checked when removing things | 15:50 |
xek | typically, the migration script nulls the values or removes the old, migrated rows, and the schema migration which does a remove, checks if it is not removing any data | 15:51 |
stevemar | breton: you had me scared a little there, with your shadow users bug -- i also did the same :) | 15:52 |
breton | :p | 15:53 |
*** gokrokve has joined #openstack-keystone | 15:54 | |
dstanek | xek: (hypothetical) release M would have included shadow users code that could read out of either the old or new database. a config option to turn on the feature would make it read out of the new tables. there would be an optional migration that runs if the config option is enabled. then in N the migration is mandatory. is that correct? | 15:55 |
xek | dstanek, yes | 15:56 |
dstanek | xek: how does the code know when to read from the new tables? a keystone restart? | 15:56 |
xek | dstanek, correct, a restart would probably be needed to stop initializing the old sqlalchemy models | 15:58 |
*** jsavak has quit IRC | 15:59 | |
xek | I made a POC to demonstrate this config change here https://review.openstack.org/#/c/269693/ | 15:59 |
patchbot | xek: patch 269693 - keystone - POC Online Schema Migration: Add BinaryHex field | 15:59 |
*** jsavak has joined #openstack-keystone | 16:00 | |
xek | dstanek, the model is initialised with different fields, depending on compatibility mode | 16:00 |
*** tellesnobrega is now known as tellesnobrega_af | 16:02 | |
dstanek | xek: so at least at this pace we'd always be taking keystone offline to do the migrations which is what we have now. i think that's partially why morgan called the gains speculative | 16:02 |
notmorgan | dstanek: ++ | 16:03 |
xek | dstanek, we wouldn't have to kill the old application in this case | 16:03 |
dstanek | xek: it wouldn't work with the new tables | 16:04 |
*** kevinbenton has quit IRC | 16:04 | |
notmorgan | xek: i also am adamantly against "different deployments have different schemas" - it realy doesn't make sense *and* there is no guarantee that something wont add back in string vs uuid data down the line. The BinaryUUID column is not a win in flexibility or usability, and it's minor at best improvement. There are other places to improve our schema | 16:04 |
notmorgan | and you may have deployments locked forever in the "string" mode. | 16:05 |
notmorgan | we never said the ID had to be a uuid - therefore we can't / shouldn't change that now. | 16:05 |
*** jaosorior is now known as jaosorior_away | 16:06 | |
notmorgan | note, i am being specific about the binary field, not online migrations in this case | 16:06 |
notmorgan | but back to the thing on online migrations - we still need keystone down for the migration, it's fairly speculative improvement -- | 16:07 |
xek | notmorgan, I'm showing this only to demonstrate that a "schema braking" change could be done in one release cycle, I agree that the binary field was not a good idea | 16:07 |
notmorgan | xek: ok cool. :) | 16:07 |
notmorgan | xek: yay we're on the same page then | 16:07 |
* notmorgan was't sure there. | 16:07 | |
xek | :) | 16:08 |
bknudson | there's no need to get all entries with id > 'some value', so the ids should be stored as binary | 16:09 |
*** chlong_ has quit IRC | 16:10 | |
xek | dstanek, when working in a compatible way, the new implementation would have to place data in both, the new, and the old tables | 16:11 |
*** henrynash has joined #openstack-keystone | 16:11 | |
*** ChanServ sets mode: +v henrynash | 16:11 | |
henrynash | ayoung: were you OK with +2/A o https://review.openstack.org/#/c/286452/ | 16:12 |
patchbot | henrynash: patch 286452 - keystone - Deprecate domain driver interface methods | 16:12 |
dstanek | xek: that increases the risk or bugs and timeline for landing features | 16:12 |
dstanek | xek: we discussed a lot of this during the mid-cycle | 16:12 |
*** e0ne has joined #openstack-keystone | 16:13 | |
xek | dstanek, in my poc, with the CopyColumn there is actually little new code added | 16:14 |
ayoung | henrynash, yes, sorry, thought I had pushed the button on that | 16:14 |
henrynash | ayoung: no worries | 16:14 |
henrynash | ayoung: thx | 16:15 |
xek | dstanek, I'm not sure if this would be the pattern for all migrations, but in this case, the old code landed under an if, and the new implementation was just "appended", so the risk of bugs is minimal | 16:20 |
*** tellesnobrega_af is now known as tellesnobrega | 16:20 | |
xek | lbragstad, dstanek, at the midcycle, did you maybe talk about other approaches to minimizing upgrade downtime? | 16:22 |
openstackgerrit | Sean Dague proposed openstack/keystone: remove pyc files before running tests https://review.openstack.org/286687 | 16:22 |
lbragstad | xek i think we tried but a lot of the discussion came down to data we didn't have | 16:22 |
notmorgan | xek: we did, the one we hit closest to was code can always handle n-1 schema, so upgrade code (everywhere), then upgrade schema | 16:22 |
henrynash | bknduson: on https://review.openstack.org/#/c/286452/1 we do test the project driver interface in the test above the one being removed | 16:23 |
patchbot | henrynash: patch 286452 - keystone - Deprecate domain driver interface methods | 16:23 |
notmorgan | xek: but it was not more than guess work because there is a lot of data missing as lbragstad said | 16:23 |
bknudson | henrynash: ok. the methods should still be removed from the V9 adapter | 16:24 |
notmorgan | xek: the other concern was if we change [for example] the username column, in the proposed model we need now user_2 table or username_2 column | 16:24 |
notmorgan | at what point do we have username_2334 column [contrived example] | 16:24 |
henrynash | bknduson: agree with that…are you OK with that as a follow up patch (since that isn’t required to classify those methods as deprecated)? | 16:24 |
bknudson | henrynash: a follow-up patch works for me. | 16:25 |
notmorgan | and that seems like a hard to manage/follow schema/maintenance headaches | 16:25 |
henrynash | bknudson: ok, great, thanks for thre review | 16:25 |
*** jbell8 has joined #openstack-keystone | 16:25 | |
notmorgan | xek: that was one of the big questions that kept coming up | 16:25 |
xek | I personally wouldn't mind appending something like _v99 or _99 to a column | 16:26 |
*** belmoreira has quit IRC | 16:28 | |
notmorgan | xek: right - as a dev, that's great. as someone who has to look at the db/manage it/work with it/wonder where data broke, it makes operator life less fun if there are 10 username columns [for whatever reason] | 16:29 |
xek | notmorgan, there should be no more than 2 versions at the same time | 16:30 |
notmorgan | xek: it causes index expansions, i am unsure if column drops are non-blocking | 16:30 |
notmorgan | xek: can't guarantee that. if you have 2 changes in a cycle that are breaking, they're two different migrations | 16:30 |
notmorgan | and you need to assume someone is chasing master with code | 16:30 |
*** kevinbenton has joined #openstack-keystone | 16:30 | |
notmorgan | and migrations | 16:30 |
notmorgan | if it was strictly isolated to a release, i agree with you (6-mo windows) | 16:31 |
notmorgan | xek: i think the easiest solution and with the fewest moving parts is: code supports schema (release-1), and upgrade code everywhere then schema once code is upgraded. | 16:33 |
notmorgan | xek: but it still results in some blips/downtime requirements. | 16:33 |
*** fawadkhaliq has quit IRC | 16:33 | |
notmorgan | xek: that is if we're trying to minimize downtime for upgrades. it's worth exploring, but i worry that we will add a lot of complexity for a small improvement. | 16:34 |
*** mylu has quit IRC | 16:35 | |
openstackgerrit | henry-nash proposed openstack/keystone: Remove unused domain driver method in legacy wrapper https://review.openstack.org/286699 | 16:36 |
xek | notmorgan, I feel that this approach is more troublesome, because each new feature would have to adhere to this, in case of upgrading the schema before upgrading the code, additive changes would stay as-is, only incompatible changes would need extra work | 16:37 |
notmorgan | xek: i think you're underestimating the amount of work "additive" changes are ;) | 16:38 |
*** e0ne has quit IRC | 16:38 | |
bknudson | notmorgan: deployers consider no-downtime upgrades one of their most important requirements | 16:39 |
*** e0ne has joined #openstack-keystone | 16:40 | |
notmorgan | bknudson: i'd like to know what "no downtime" upgrade is to each deployer. i'm going to guess we'll get about as many different answers as we have deployers | 16:42 |
bknudson | I wonder if the product group ever came up with a user story? | 16:42 |
notmorgan | bknudson: it would be good if they did | 16:43 |
notmorgan | bknudson: part of the issue is there isn't a user story in a lot of cases; it's just implmented by (say nova) one of the projects | 16:43 |
*** josecastroleon has quit IRC | 16:43 | |
notmorgan | then there are holes/gaps/issues and we either can't do the same thing w/o horrible experience because we didn't hve a clear target to begin with | 16:43 |
notmorgan | or non-consistent | 16:44 |
notmorgan | bknudson: but meh, like i said, worth exploring. | 16:45 |
xek | bknudson, notmorgan, they track it here: https://wiki.openstack.org/wiki/ProductTeam/User_Stories/Rolling_Upgrades | 16:45 |
openstackgerrit | Sean Dague proposed openstack/keystone: remove pyc files before running tests https://review.openstack.org/286687 | 16:45 |
bknudson | xek: thank you! | 16:45 |
bknudson | I thought they'd use a git repo | 16:45 |
bknudson | http://specs.openstack.org/openstack/openstack-user-stories/user-stories/draft/rollingupgrades.html | 16:46 |
raildo | ayoung: lbragstad did you have some minutes to see my comment here? https://review.openstack.org/#/c/258650/26/keystone/token/provider.py | 16:46 |
patchbot | raildo: patch 258650 - keystone - [WIP]Make fernet default token provider | 16:46 |
lbragstad | raildo yeah, I can take a look in a minute | 16:47 |
raildo | lbragstad: thanks :D | 16:47 |
ayoung | raildo, not yet | 16:47 |
ayoung | raildo, need to work throug a few things first. If lbragstad can take it, so much the better | 16:47 |
notmorgan | xek: ah there we go | 16:48 |
bknudson | xek: I don't think the user story they have there totally answers our questions | 16:48 |
notmorgan | i think the user story is a good starting place | 16:48 |
bknudson | also it's hard to read due to not formatting correctly | 16:48 |
notmorgan | i also think it's really 2 specs | 16:48 |
notmorgan | dataplane upgrades and control plane upgrades | 16:48 |
notmorgan | they're linked but one is clearly easier than the other ;) | 16:49 |
notmorgan | (control plane is often easier in my experience) | 16:49 |
notmorgan | bknudson: ++ hard to read | 16:49 |
*** rk4n has quit IRC | 16:51 | |
notmorgan | xek: i also have an edge case question that needs to be answered as part of this: what happens in the case of a broken schema upgrade migration, is it expected to restore from backup (this is in the add-only bit)? how about... rolling it back for $insert_reason_here? | 16:51 |
*** gokrokve has quit IRC | 16:52 | |
henrynash | stevemar: ping | 16:52 |
stevemar | henrynash: poke | 16:52 |
notmorgan | xek: just so we have an answer for folks when it comes up, not that it's a blocker or reason not to push forward | 16:52 |
henrynash | stevemar: just an fyi that https://review.openstack.org/#/c/286452/ is gating…if we can get this into m3 it would be nice from a deprecations point of view, not fucntional changes, but if you had to cut m3 without it, that’s OK | 16:53 |
patchbot | henrynash: patch 286452 - keystone - Deprecate domain driver interface methods | 16:53 |
*** josecastroleon has joined #openstack-keystone | 16:53 | |
henrynash | stevemar: it just means we can stop supporting domain driver methods in P, rather than wait till Q | 16:55 |
xek | notmorgan, I think in case of braking the schema or braking the data migration part, the operator would need to restore from backup, but in case of code misbehaving in other ways, the operator could still use the old version on the same (upgraded) schema | 16:55 |
stevemar | henrynash: it's OK to include it in the RC period | 16:55 |
*** rcernin has quit IRC | 16:55 | |
notmorgan | xek: thats fine, just want to mak sure we clearly outline that :) | 16:55 |
henrynash | stevemar: ah, OK…wasn’t sure if we “froze” definition of teh V9 driver at m3 | 16:55 |
henrynash | stevemar: it will merge in about an hour, anyway | 16:55 |
notmorgan | henrynash: OMG YOU BROKE THE DEFINITION :) | 16:56 |
notmorgan | henrynash: :P | 16:56 |
henrynash | notmorgan: spank me now | 16:56 |
notmorgan | henrynash: haha | 16:56 |
*** fawadkhaliq has joined #openstack-keystone | 16:56 | |
stevemar | keep it pg henrynash | 16:57 |
*** jbell8 has quit IRC | 16:57 | |
*** mylu has joined #openstack-keystone | 16:57 | |
*** jbell8 has joined #openstack-keystone | 16:57 | |
henrynash | stevemar: tmi, tmi | 16:58 |
notmorgan | stevemar: "pg" in the UK or "pg" in the US, or "pg" in the supr conservative area of the us? | 16:58 |
henrynash | notmorgan: I’l take “pg” in the Trump camp…gives me carte balnche to do anything | 16:59 |
notmorgan | henrynash: AHAHAHAH | 16:59 |
stevemar | hehe | 17:00 |
stevemar | someone push https://review.openstack.org/#/c/286687/ please :) | 17:00 |
patchbot | stevemar: patch 286687 - keystone - remove pyc files before running tests | 17:00 |
notmorgan | stevemar: marked https://bugs.launchpad.net/keystone/+bug/1551836 as m-3 and high prio since it has landed | 17:01 |
openstack | Launchpad bug 1551836 in Trove "CORS middleware's latent configuration options need to change" [Undecided,New] | 17:01 |
notmorgan | stevemar: uhm. just do it man... just do it! :P | 17:01 |
notmorgan | stevemar: *chants* Power of the PTL *chants* | 17:01 |
stevemar | notmorgan: there's a whole crowd of y'all here :P | 17:01 |
*** twm2016 has joined #openstack-keystone | 17:02 | |
henrynash | stevemar: fyi, no need to wait for https://review.openstack.org/#/c/286699/1 , it’s https://review.openstack.org/#/c/286452/1 that actually marks them as deprecated | 17:02 |
patchbot | henrynash: patch 286699 - keystone - Remove unused domain driver method in legacy wrapper | 17:02 |
patchbot | henrynash: patch 286452 - keystone - Deprecate domain driver interface methods | 17:02 |
notmorgan | stevemar: see thats where you're mistaken | 17:02 |
openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: Revert "Fix cascade operations documentation" https://review.openstack.org/286716 | 17:02 |
notmorgan | stevemar: we're all virtual constructs ... on the internet no one knows you're a dog...erm bot | 17:03 |
*** gyee has joined #openstack-keystone | 17:03 | |
*** ChanServ sets mode: +v gyee | 17:03 | |
*** henrynash has quit IRC | 17:03 | |
*** david8hu has joined #openstack-keystone | 17:03 | |
notmorgan | stevemar: abandoned? | 17:03 |
*** jsavak has quit IRC | 17:03 | |
twm2016 | Hi everyone, I have fix proposed to keystone but it needs some code-reviews, it hasn't been updated in 4 days. Can someone take a look at it please? https://review.openstack.org/#/c/285393/ | 17:04 |
patchbot | twm2016: patch 285393 - keystone - Add validation parameter "max_name_size" | 17:04 |
*** jsavak has joined #openstack-keystone | 17:05 | |
*** jistr has quit IRC | 17:05 | |
notmorgan | twm2016: maybe we just lift the 64 limit? | 17:05 |
notmorgan | twm2016: instead of making it configurable? | 17:05 |
*** jbell8 has quit IRC | 17:06 | |
notmorgan | twm2016: i'm fine with either, but this feels like a case where config might be overkill and not super useful. | 17:06 |
*** mylu has quit IRC | 17:06 | |
notmorgan | twm2016: basically, i am asking if config is really needed. because if config is needed, we're reallllly pushing the limits on freeze | 17:07 |
twm2016 | @notmorgan: I'm glad you're okay with it. I was addressing what the bugs says that the db schema is 255. | 17:07 |
*** pcaruana has quit IRC | 17:07 | |
notmorgan | stevemar: ^ cc | 17:07 |
notmorgan | twm2016: right. so an alternative would just make the validation 255 vs. config :) still addresses the bug. | 17:07 |
*** jorge_munoz has quit IRC | 17:08 | |
twm2016 | @notmorgan: So you're suggesting to not use conf and set 255 in the condition? like if len(username) > 255: | 17:11 |
notmorgan | twm2016: pretty much no need to use conf. lets ask stevemar, i'll move to a +2 w/ the config depending on his view | 17:11 |
notmorgan | twm2016: i +1'd it and commented on the review | 17:11 |
*** dan_nguyen has joined #openstack-keystone | 17:11 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: Revert "Fix cascade operations documentation" https://review.openstack.org/286716 | 17:12 |
openstackgerrit | Steve Martinelli proposed openstack/keystone-specs: Revert "Fix cascade operations documentation" https://review.openstack.org/286716 | 17:13 |
notmorgan | stevemar: also https://review.openstack.org/#/c/277198/ do you want me to push that forward? cause... it's bad but there is no good option until oslo.cache has a .set_defaults | 17:14 |
patchbot | notmorgan: patch 277198 - keystone - Default caching to on for request-local caching. | 17:14 |
*** GB21 has quit IRC | 17:15 | |
stevemar | notmorgan: eww umm | 17:15 |
*** mylu has joined #openstack-keystone | 17:15 | |
*** dims_ has joined #openstack-keystone | 17:17 | |
*** dims has quit IRC | 17:19 | |
notmorgan | yeah, right? | 17:20 |
*** timcline has joined #openstack-keystone | 17:20 | |
notmorgan | stevemar: anyway.. | 17:21 |
openstackgerrit | Morgan Fainberg proposed openstack/keystone: Default caching to on for request-local caching. https://review.openstack.org/277198 | 17:21 |
*** josecastroleon has quit IRC | 17:23 | |
openstackgerrit | Raildo Mascena proposed openstack/keystone: Constraint to prevent duplicate endpoints https://review.openstack.org/134095 | 17:26 |
*** mylu has quit IRC | 17:27 | |
*** notmorgan is now known as morgan | 17:28 | |
stevemar | as soon as 285152 merges, i'll be tagging mitaka-3 | 17:29 |
*** rk4n has joined #openstack-keystone | 17:30 | |
morgan | stevemar: look at the validation (username) patch^ | 17:31 |
morgan | stevemar: config or no config. | 17:31 |
openstackgerrit | Alexander Makarov proposed openstack/keystone: Closure table for HMT https://review.openstack.org/285521 | 17:34 |
*** jbell8 has joined #openstack-keystone | 17:34 | |
*** GB21 has joined #openstack-keystone | 17:35 | |
*** fpatwa_ has joined #openstack-keystone | 17:38 | |
*** StefanPaetowJisc has joined #openstack-keystone | 17:39 | |
*** mhickey has quit IRC | 17:40 | |
*** petertr7 is now known as petertr7_away | 17:41 | |
*** lhcheng has joined #openstack-keystone | 17:42 | |
*** ChanServ sets mode: +v lhcheng | 17:42 | |
*** fpatwa_ has quit IRC | 17:42 | |
*** nkinder has joined #openstack-keystone | 17:44 | |
*** fhubik has joined #openstack-keystone | 17:47 | |
*** jsavak has quit IRC | 17:47 | |
*** jsavak has joined #openstack-keystone | 17:48 | |
StefanPaetowJisc | Hi stevemar, we briefly spoke on here the week before last during the Openstack meetup in Manchester... Just FYI - I'll try to join the meeting this week but that's contingent on my mobile signal remaining consistent. | 17:49 |
*** rk4n has quit IRC | 17:50 | |
*** StefanPaetowJisc has quit IRC | 17:50 | |
*** rk4n has joined #openstack-keystone | 17:50 | |
*** fhubik has quit IRC | 17:51 | |
*** StefanPaetowJisc has joined #openstack-keystone | 17:51 | |
*** sdake_ has quit IRC | 17:51 | |
*** henrynash has joined #openstack-keystone | 17:51 | |
*** ChanServ sets mode: +v henrynash | 17:51 | |
*** nkinder has quit IRC | 17:53 | |
*** roxanaghe has joined #openstack-keystone | 17:53 | |
*** shaleh has joined #openstack-keystone | 17:57 | |
*** tsymanczyk has joined #openstack-keystone | 18:00 | |
stevemar | poke for ajayaa, amakarov, ayoung, breton, browne, davechen, david8hu, dolphm, dstanek, edmondsw, ericksonsantos, geoffarnold, gyee, henrynash, hogepodge, htruta, jamielennox, joesavak, lbragstad, lhcheng, marekd, morganfainberg, nkinder, raildo, rodrigods, roxanaghe, samueldmq, shaleh, stevemar, tsymanczyk, topol, vivekd, wanghong, claudiub, rderose, samleon, xek, MaxPC, tjcocozz, jorge_munoz << KEYSTONE MEETING! | 18:01 |
*** StefanPaetowJi-1 has joined #openstack-keystone | 18:01 | |
*** rderose has joined #openstack-keystone | 18:01 | |
*** jsavak has quit IRC | 18:02 | |
*** jsavak has joined #openstack-keystone | 18:03 | |
*** timcline has quit IRC | 18:04 | |
*** timcline has joined #openstack-keystone | 18:05 | |
*** StefanPaetowJisc has quit IRC | 18:05 | |
*** StefanPaetowJi-1 is now known as StefanPaetowJisc | 18:05 | |
*** e0ne has quit IRC | 18:08 | |
*** timcline has quit IRC | 18:10 | |
*** GB21 has quit IRC | 18:11 | |
*** jed56 has quit IRC | 18:13 | |
*** openstackgerrit has quit IRC | 18:18 | |
*** openstackgerrit has joined #openstack-keystone | 18:18 | |
*** spandhe has joined #openstack-keystone | 18:18 | |
*** twm2016 has quit IRC | 18:21 | |
*** haneef has joined #openstack-keystone | 18:26 | |
*** serverascode has quit IRC | 18:26 | |
*** zhiyan has quit IRC | 18:27 | |
*** blogan_ is now known as blogan | 18:27 | |
*** zhiyan has joined #openstack-keystone | 18:28 | |
*** permalac has quit IRC | 18:31 | |
*** jaosorior_away is now known as jaosorior | 18:31 | |
*** serverascode has joined #openstack-keystone | 18:32 | |
*** permalac has joined #openstack-keystone | 18:34 | |
*** permalac has quit IRC | 18:34 | |
*** jorge_munoz has joined #openstack-keystone | 18:36 | |
*** petertr7_away is now known as petertr7 | 18:37 | |
*** StefanPaetowJisc has quit IRC | 18:39 | |
*** StefanPaetowJisc has joined #openstack-keystone | 18:40 | |
raildo | ayoung: i had the same error db type could not be determined | 18:44 |
bknudson | tox is overkill for running one test, just do .tox/py34/bin/python -m unittest | 18:44 |
raildo | bknudson: thanks :) | 18:45 |
*** dims has joined #openstack-keystone | 18:45 | |
*** petertr7 is now known as petertr7_away | 18:50 | |
*** wolsen has quit IRC | 18:50 | |
*** dims_ has quit IRC | 18:52 | |
*** knikolla has quit IRC | 18:52 | |
*** BAKfr has quit IRC | 18:52 | |
*** afazekas has quit IRC | 18:52 | |
*** john5223 has quit IRC | 18:52 | |
*** SpamapS has quit IRC | 18:54 | |
*** openstack has joined #openstack-keystone | 19:08 | |
*** openstack has joined #openstack-keystone | 19:09 | |
ayoung | stevemar, I think you jumped the gun on https://review.openstack.org/#/c/286687/3 | 19:12 |
patchbot | ayoung: patch 286687 - keystone - remove pyc files before running tests | 19:12 |
*** phalmos has quit IRC | 19:12 | |
ayoung | that kills all the pyc files in the venv, too | 19:12 |
bknudson | ayoung: why is it a problem to remove the pyc files from the venv? | 19:12 |
ayoung | bknudson, its just not the intention of the patch. | 19:12 |
ayoung | there is a hell of a lot more to regen including files that have nothing to do with keystone that way | 19:12 |
*** openstack has joined #openstack-keystone | 19:14 | |
ayoung | bknudson, take a look | 19:14 |
dstanek | ++ to only in keystone | 19:15 |
bknudson | ayoung: you only changed py34, not all of them | 19:16 |
ayoung | ah... | 19:16 |
ayoung | that was the one I was working on..you are rigjht | 19:16 |
*** SpamapS has joined #openstack-keystone | 19:16 | |
ayoung | bknudson, changing now... | 19:16 |
ayoung | and testing | 19:16 |
bknudson | thanks | 19:16 |
*** openstackstatus has joined #openstack-keystone | 19:17 | |
*** ChanServ sets mode: +v openstackstatus | 19:17 | |
bknudson | there's openstackstatus | 19:17 |
*** openstackgerrit has joined #openstack-keystone | 19:19 | |
*** fangxu has joined #openstack-keystone | 19:20 | |
*** mylu has joined #openstack-keystone | 19:23 | |
*** petertr7 is now known as petertr7_away | 19:25 | |
*** errr has quit IRC | 19:25 | |
*** smurke_ has quit IRC | 19:25 | |
*** sudorandom has quit IRC | 19:25 | |
*** navidp has quit IRC | 19:25 | |
*** odyssey4me has quit IRC | 19:25 | |
*** briancurtin has quit IRC | 19:25 | |
*** ctracey has quit IRC | 19:25 | |
*** johnthetubaguy has quit IRC | 19:25 | |
*** petertr7_away is now known as petertr7 | 19:28 | |
*** StefanPaetowJisc has quit IRC | 19:30 | |
*** errr has joined #openstack-keystone | 19:31 | |
*** smurke_ has joined #openstack-keystone | 19:31 | |
*** sudorandom has joined #openstack-keystone | 19:31 | |
*** navidp has joined #openstack-keystone | 19:31 | |
*** odyssey4me has joined #openstack-keystone | 19:31 | |
*** briancurtin has joined #openstack-keystone | 19:31 | |
*** ctracey has joined #openstack-keystone | 19:31 | |
*** johnthetubaguy has joined #openstack-keystone | 19:31 | |
*** jrist has quit IRC | 19:31 | |
bknudson | stevemar: is there still an oauth plugin in keystoneauth? | 19:31 |
bknudson | stevemar: http://docs.openstack.org/developer/keystoneauth/authentication-plugins.html#v3-oauth-1-0a-plugins references an OAuth plugin but there isn't one (the link doesn't work) | 19:32 |
stevemar | bknudson: there should be | 19:33 |
*** StefanPaetowJisc has joined #openstack-keystone | 19:35 | |
bknudson | I can't find it | 19:36 |
*** sigmavirus24 is now known as sigmavirus24_awa | 19:37 | |
*** StefanPaetowJisc has quit IRC | 19:37 | |
*** StefanPaetowJisc has joined #openstack-keystone | 19:38 | |
*** fpatwa_ has joined #openstack-keystone | 19:38 | |
*** fpatwa_ has quit IRC | 19:43 | |
*** david_cu has joined #openstack-keystone | 19:45 | |
openstackgerrit | guang-yee proposed openstack/keystone: Return 404 instead of 401 for tokens w/o roles https://review.openstack.org/277436 | 19:47 |
openstackgerrit | guang-yee proposed openstack/keystone: Return 404 instead of 401 for tokens w/o roles https://review.openstack.org/277436 | 19:48 |
*** gyee has quit IRC | 19:48 | |
*** spandhe has quit IRC | 19:50 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 19:52 | |
*** spandhe has joined #openstack-keystone | 19:52 | |
*** StefanPaetowJisc has quit IRC | 19:55 | |
*** jrist has joined #openstack-keystone | 19:55 | |
*** josecastroleon has joined #openstack-keystone | 19:58 | |
*** david-lyle has quit IRC | 19:59 | |
stevemar | bknudson: gdi | 20:01 |
*** sdake has quit IRC | 20:05 | |
*** daemontool__ has joined #openstack-keystone | 20:05 | |
*** jsavak has quit IRC | 20:07 | |
*** jsavak has joined #openstack-keystone | 20:08 | |
*** henrynash has quit IRC | 20:08 | |
*** daemontool_ has quit IRC | 20:09 | |
openstackgerrit | Sam Leong proposed openstack/keystoneauth: Auth plugin for X.509 tokenless authz https://review.openstack.org/283905 | 20:09 |
*** david-lyle has joined #openstack-keystone | 20:09 | |
*** gokrokve has joined #openstack-keystone | 20:12 | |
*** fangxu has quit IRC | 20:12 | |
*** jaosorior has quit IRC | 20:12 | |
bknudson | stevemar: where did it go? | 20:13 |
*** mylu has quit IRC | 20:15 | |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Update test run instructions https://review.openstack.org/286813 | 20:16 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Fix exported symbol in identity.v3 https://review.openstack.org/286814 | 20:16 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Editorial nits for docs https://review.openstack.org/286815 | 20:16 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Improve usability of docs https://review.openstack.org/286816 | 20:16 |
*** sdake has joined #openstack-keystone | 20:16 | |
*** jorge_munoz has quit IRC | 20:17 | |
*** mylu has joined #openstack-keystone | 20:17 | |
*** jasonsb has quit IRC | 20:18 | |
*** jbell8 has joined #openstack-keystone | 20:22 | |
openstackgerrit | Lance Bragstad proposed openstack/keystone: Return 404 instead of 401 for tokens w/o roles https://review.openstack.org/277436 | 20:23 |
lbragstad | raildo new patch ^ | 20:24 |
*** jorge_munoz has joined #openstack-keystone | 20:26 | |
*** josecastroleon has quit IRC | 20:27 | |
*** sdake has quit IRC | 20:31 | |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Add links to federation plugins https://review.openstack.org/286824 | 20:33 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Remove unavailable parameter https://review.openstack.org/286825 | 20:34 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Generate FederationBaseAuth constructor parameters https://review.openstack.org/286826 | 20:34 |
*** phalmos has quit IRC | 20:34 | |
lbragstad | stevemar do we have restrictions on config option changes wrt m-3's deadline? https://review.openstack.org/#/c/285393/2 | 20:34 |
patchbot | lbragstad: patch 285393 - keystone - Add validation parameter "max_name_size" | 20:34 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Generate FederationBaseAuth constructor parameters https://review.openstack.org/286826 | 20:34 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Remove unavailable parameter https://review.openstack.org/286825 | 20:34 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Add links to federation plugins https://review.openstack.org/286824 | 20:35 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Improve usability of docs https://review.openstack.org/286816 | 20:35 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Editorial nits for docs https://review.openstack.org/286815 | 20:35 |
openstackgerrit | Brant Knudson proposed openstack/keystoneauth: Fix exported symbol in identity.v3 https://review.openstack.org/286814 | 20:35 |
*** jsavak has quit IRC | 20:35 | |
raildo | stevemar: ping, on https://review.openstack.org/#/c/134095/ if region_id is none, there still can be duplicate endpoints. Is that OK? | 20:36 |
patchbot | raildo: patch 134095 - keystone - Constraint to prevent duplicate endpoints | 20:36 |
*** e0ne has joined #openstack-keystone | 20:38 | |
*** alejandrito has joined #openstack-keystone | 20:38 | |
raildo | stevemar: since the constraint is a combination of service_id, region_id and interface | 20:38 |
*** mylu has quit IRC | 20:39 | |
*** sdake has joined #openstack-keystone | 20:43 | |
*** pcaruana has joined #openstack-keystone | 20:44 | |
*** jamielennox|away is now known as jamielennox | 20:45 | |
*** roxanaghe has quit IRC | 20:45 | |
lbragstad | does anyone else get this when running tests locally - http://cdn.pasteraw.com/7w6v7eavvyrqmltcuseh63f6wf68v7j ? | 20:46 |
*** jamie_h has quit IRC | 20:46 | |
*** e0ne has quit IRC | 20:47 | |
stevemar | bknudson: not sure if it ever made the move! | 20:47 |
*** jsavak has joined #openstack-keystone | 20:48 | |
raildo | lbragstad: https://bugs.launchpad.net/keystone/+bug/1551751 | 20:48 |
openstack | Launchpad bug 1551751 in OpenStack Identity (keystone) "shadow users break on old config" [Undecided,Invalid] | 20:48 |
stevemar | lbragstad: you betcha - we lived with bug 1279750 for many releases, we can live with it for another release | 20:48 |
openstack | bug 1279750 in OpenStack Identity (keystone) "username validation 64 chars but can be 255 in database" [Low,In progress] https://launchpad.net/bugs/1279750 - Assigned to Trevor McCasland (twm2016) | 20:48 |
openstackgerrit | Merged openstack/keystone: Deprecate domain driver interface methods https://review.openstack.org/286452 | 20:49 |
*** gyee has joined #openstack-keystone | 20:50 | |
*** ChanServ sets mode: +v gyee | 20:50 | |
ayoung | lbragstad, yes | 20:50 |
ayoung | lbragstad, I rebuilt the venv | 20:50 |
lbragstad | ah | 20:51 |
lbragstad | ayoung raildo thanks | 20:52 |
raildo | np | 20:52 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/286565 | 20:52 |
*** e0ne has joined #openstack-keystone | 20:55 | |
*** sdake has quit IRC | 20:56 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 20:58 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 20:58 | |
*** e0ne has quit IRC | 20:59 | |
*** sdake has joined #openstack-keystone | 20:59 | |
*** fangxu has joined #openstack-keystone | 21:00 | |
*** jsavak has quit IRC | 21:04 | |
*** raildo is now known as raildo-afk | 21:07 | |
*** david-lyle has quit IRC | 21:08 | |
*** david-lyle has joined #openstack-keystone | 21:17 | |
*** mylu has joined #openstack-keystone | 21:20 | |
*** pauloewerton has quit IRC | 21:25 | |
*** phalmos has joined #openstack-keystone | 21:28 | |
*** dims_ has joined #openstack-keystone | 21:31 | |
*** jorge_munoz has quit IRC | 21:33 | |
*** dims has quit IRC | 21:33 | |
*** jbell8 has quit IRC | 21:35 | |
*** fpatwa_ has joined #openstack-keystone | 21:39 | |
openstackgerrit | Trevor McCasland proposed openstack/keystone: Change validation parameter max_param_size https://review.openstack.org/286852 | 21:43 |
*** fpatwa_ has quit IRC | 21:44 | |
openstackgerrit | Brant Knudson proposed openstack/keystone: Stop using oslotest.BaseTestCase https://review.openstack.org/281579 | 21:44 |
*** jbell8 has joined #openstack-keystone | 21:46 | |
*** petertr7 is now known as petertr7_away | 21:53 | |
*** fawadkhaliq has quit IRC | 21:54 | |
openstackgerrit | Merged openstack/keystoneauth: Fix typos and improve formatting in migrating.rst https://review.openstack.org/286018 | 21:57 |
*** pcaruana has quit IRC | 22:01 | |
*** phalmos has quit IRC | 22:02 | |
*** jbell8 has quit IRC | 22:02 | |
*** dims_ has quit IRC | 22:02 | |
*** fawadkhaliq has joined #openstack-keystone | 22:04 | |
*** knikolla has quit IRC | 22:04 | |
*** phalmos has joined #openstack-keystone | 22:06 | |
openstackgerrit | Merged openstack/keystone: Fix the migration issue for the user doesn't have a password https://review.openstack.org/285152 | 22:09 |
*** petertr7_away is now known as petertr7 | 22:10 | |
*** dims has joined #openstack-keystone | 22:10 | |
*** rk4n has quit IRC | 22:11 | |
openstackgerrit | Brant Knudson proposed openstack/keystone-specs: WIP - Swagger definition https://review.openstack.org/286865 | 22:12 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/286565 | 22:12 |
*** jorge_munoz has joined #openstack-keystone | 22:18 | |
*** alejandrito has quit IRC | 22:18 | |
openstackgerrit | Steve Martinelli proposed openstack/keystone: remove pyc files before running tests https://review.openstack.org/286687 | 22:20 |
*** petertr7 is now known as petertr7_away | 22:20 | |
*** timcline has joined #openstack-keystone | 22:23 | |
*** josecastroleon has joined #openstack-keystone | 22:24 | |
*** mvk has joined #openstack-keystone | 22:26 | |
*** phalmos has quit IRC | 22:27 | |
*** henrynash has joined #openstack-keystone | 22:27 | |
*** ChanServ sets mode: +v henrynash | 22:27 | |
*** phalmos has joined #openstack-keystone | 22:27 | |
*** david-lyle has quit IRC | 22:29 | |
*** tsymanczyk has quit IRC | 22:31 | |
stevemar | bknudson: proposed a release | 22:34 |
bknudson | stevemar: of what? | 22:34 |
stevemar | bknudson: of keystone! | 22:35 |
stevemar | https://review.openstack.org/#/c/286866/ | 22:35 |
patchbot | stevemar: patch 286866 - releases - release keystone mitaka-3 | 22:35 |
bknudson | stevemar: is keystone ready for a release? | 22:35 |
bknudson | is the world ready for a keystone release? | 22:35 |
stevemar | bknudson: what else needs to land? | 22:35 |
stevemar | bknudson: i think we both know that the world can't handle us | 22:35 |
bknudson | stevemar: are we the first? | 22:36 |
bknudson | we strive to be first to release | 22:36 |
stevemar | bknudson: i think so | 22:36 |
bknudson | what do you think about dropping keystoneclient and switching to a client generated from swagger? | 22:37 |
stevemar | sounds interesting, i saw the patch... | 22:37 |
stevemar | i need to read up on it | 22:37 |
stevemar | got any sources? | 22:38 |
bknudson | stevemar: if you take https://review.openstack.org/286865 and put the swagger.yaml into http://editor.swagger.io/#/ there's a button to generate client | 22:38 |
stevemar | bknudson: nice | 22:40 |
jamielennox | do we have consensus on swagger? | 22:41 |
jamielennox | if we can plug keystoneauth into it i'd love to ditch the clients | 22:41 |
bknudson | the docs team is working on switching from the wadls to swagger | 22:41 |
bknudson | using a tool called fairyslipper (that I think they developed) | 22:41 |
stevemar | i was just gonna ask how this ties into fairyslipper | 22:41 |
bknudson | I doubt that the swagger it generates is going to be adequate for keystone since our wadls are so crappy | 22:41 |
bknudson | I did take a quick look at fairyslipper but didn't figure out how to run it... I think it's a web service | 22:42 |
* jamielennox feels like we've had this conversation before | 22:44 | |
bknudson | deja vu all over again | 22:44 |
jamielennox | the generated client isn't too bad | 22:44 |
stevemar | bknudson: nice, built in v2 and v3 python support] | 22:45 |
jamielennox | however given the investment in keystoneauth etc, what would be really interesting is writing our own codegen or figuring out how to plug into theirs | 22:45 |
bknudson | from what I saw you can customize the code generator (it's java :( ) | 22:46 |
*** spzala has joined #openstack-keystone | 22:46 | |
bknudson | the important thing in the generated client is to be able to take a requests session... should be good from there | 22:47 |
jamielennox | wait - java | 22:47 |
jamielennox | bknudson: generated client i'm seeing is urllib3 | 22:48 |
bknudson | jamielennox: https://github.com/swagger-api/swagger-codegen#customizing-the-generator | 22:48 |
jamielennox | bknudson: yea, looking at that now | 22:48 |
stevemar | bknudson: jamielennox i'd like to see the APIs/specs use swagger | 22:50 |
*** mylu has quit IRC | 22:50 | |
bknudson | it's going to be a lot of work to switch over we've got like 200 apis | 22:51 |
bknudson | might be able to automate some of it | 22:51 |
jamielennox | bknudson: that's super interesting, i think we could do a bunch of this with just templates | 22:53 |
*** spzala has quit IRC | 22:54 | |
* jamielennox looks at job list | 22:54 | |
*** josecastroleon has quit IRC | 22:54 | |
bknudson | you can put references in the swagger so you don't have to duplicate everything already | 22:54 |
bknudson | i'll try it on the sample swagger doc for users | 22:55 |
jamielennox | stevemar, bknudson: re- https://review.openstack.org/#/c/285102/ does default region name make sense there? | 22:55 |
patchbot | jamielennox: patch 285102 - keystone - Add identity endpoint creation to bootstrap | 22:55 |
bknudson | jamielennox: is it RegionOne? | 22:55 |
*** diazjf has quit IRC | 22:55 | |
jamielennox | bknudson: i left it unset - should it be? | 22:55 |
*** dims has quit IRC | 22:55 | |
*** timcline has quit IRC | 22:56 | |
bknudson | jamielennox: I'm not the right person to answer this. I have no idea what regions are. Maybe gyee ? | 22:57 |
bknudson | I thought region was required, and devstack always set RegionOne for some reason | 22:57 |
jamielennox | bknudson: i know we default to RegionOne in some places | 22:57 |
jamielennox | and i think it might set None which is not good | 22:57 |
*** mylu has joined #openstack-keystone | 22:58 | |
*** slberger has left #openstack-keystone | 22:58 | |
*** josecastroleon has joined #openstack-keystone | 22:59 | |
stevemar | jamielennox: want to kick off the rest of bknudson's doc changes: https://review.openstack.org/#/q/project:openstack/keystoneauth | 23:00 |
bknudson | we'll need to know if no-region-id is required for service catalog NG | 23:00 |
*** david-lyle has joined #openstack-keystone | 23:00 | |
*** dims has joined #openstack-keystone | 23:00 | |
jamielennox | stevemar: i did a few, then i stopped getting the option of voting | 23:01 |
jamielennox | stevemar: thought gerrit had finally disowned me | 23:01 |
stevemar | jamielennox: no no, bknudson is just a noob at rebasing | 23:01 |
stevemar | jamielennox: they are all there though | 23:01 |
jamielennox | stevemar: for you: https://review.openstack.org/#/c/286814/ | 23:01 |
patchbot | jamielennox: patch 286814 - keystoneauth - Fix exported symbol in identity.v3 | 23:02 |
gyee | bknudson, jamielennox, afaik, region is optional in SC | 23:04 |
dstanek | bknudson: how are you getting https://review.openstack.org/#/c/280671/1/keystone/tests/unit/common/test_notifications.py to fail? | 23:05 |
patchbot | dstanek: patch 280671 - keystone - Enables the notification tests in py3 | 23:05 |
gyee | if we want to maintain the position of "all services in SC must be authenticated by a single Keystone" then region is merely a collection of services | 23:06 |
*** ianw has quit IRC | 23:07 | |
gyee | if not, it would become a more profound conversation :-) | 23:07 |
stevemar | nice catch jamielennox | 23:07 |
*** doug-fis_ has joined #openstack-keystone | 23:09 | |
*** doug-fis_ has quit IRC | 23:09 | |
*** doug-fis_ has joined #openstack-keystone | 23:09 | |
*** doug-fish has quit IRC | 23:13 | |
*** chlong_ has joined #openstack-keystone | 23:13 | |
*** doug-fis_ has quit IRC | 23:14 | |
dstanek | ok, i'm sick of capstone :-) need to do more keystone stuff before i burn out | 23:15 |
gyee | capstone! | 23:15 |
stevemar | dstanek: stop working on capstone, whatever the heck that is | 23:15 |
gyee | stevemar, we need to put a franchise tag on dstanek | 23:16 |
*** Ephur has joined #openstack-keystone | 23:16 | |
*** sheel has quit IRC | 23:17 | |
stevemar | gyee: we should give him a contract that makes him exclusively work for us | 23:17 |
gyee | ++ | 23:17 |
*** rk4n has joined #openstack-keystone | 23:21 | |
gyee | stevemar, dstanek, https://etherpad.openstack.org/p/OpenStack-Bug-Smash-Mitaka-BayArea | 23:23 |
gyee | Sean and I are plan on to be there, for one day at least | 23:23 |
gyee | not sure if you guys have anything higher priority besides Mitaka RC bugs | 23:24 |
stevemar | ffs, why does our test templated_catalog have IDs, but not our shipped one | 23:27 |
*** josecastroleon has quit IRC | 23:29 | |
*** jorge_munoz has quit IRC | 23:29 | |
*** spandhe has quit IRC | 23:30 | |
*** spandhe has joined #openstack-keystone | 23:33 | |
*** darrenc is now known as darrenc_afk | 23:33 | |
dstanek | stevemar: it keeps you guessing | 23:35 |
dstanek | gyee: we're almost out of bugs to smash! | 23:36 |
gyee | dstanek, in that case, we'll just show up and party :-) | 23:37 |
*** ChanServ sets mode: +o stevemar | 23:38 | |
dstanek | gyee: i'm hoping that by next week we can be under 150 open | 23:39 |
*** fpatwa_ has joined #openstack-keystone | 23:40 | |
*** david-lyle has quit IRC | 23:41 | |
*** shaleh has quit IRC | 23:41 | |
gyee | only 150? not bad | 23:41 |
*** fpatwa_ has quit IRC | 23:45 | |
dstanek | gyee: oops. i mean under 125. we're already under 150 | 23:46 |
*** doug-fish has joined #openstack-keystone | 23:46 | |
*** sdake has quit IRC | 23:47 | |
*** doug-fish has quit IRC | 23:47 | |
lbragstad | dstanek that's awesome | 23:48 |
*** mylu has quit IRC | 23:49 | |
*** darrenc_afk is now known as darrenc | 23:50 | |
*** mylu has joined #openstack-keystone | 23:51 | |
gyee | dstanek, you make that bug dashboard look good :-) | 23:52 |
*** gordc has quit IRC | 23:53 | |
dstanek | gyee: not i, there's lots of people working on it | 23:53 |
*** csoukup has quit IRC | 23:54 | |
*** mylu has quit IRC | 23:55 | |
gyee | dstanek, https://review.openstack.org/#/c/281086/1/keystoneauth1/identity/v3/totp.py, I am trying to understand your suggestion | 23:55 |
patchbot | gyee: patch 281086 - keystoneauth - Support TOTP auth plugin | 23:55 |
gyee | dstanek, you mean don't subclass base.AuthConstructor? | 23:56 |
dstanek | gyee: yeah, isn't that for supporting the old way to create a session? | 23:58 |
gyee | dstanek, that's not a session though | 23:59 |
*** mylu has joined #openstack-keystone | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!