*** EinstCrazy has joined #openstack-keystone | 00:10 | |
*** EinstCrazy has quit IRC | 00:15 | |
*** EinstCrazy has joined #openstack-keystone | 00:32 | |
*** EinstCrazy has quit IRC | 00:36 | |
*** dims_ has quit IRC | 01:02 | |
*** davechen has joined #openstack-keystone | 01:10 | |
*** miyagishi_t has joined #openstack-keystone | 01:21 | |
*** dims has joined #openstack-keystone | 01:25 | |
*** EinstCrazy has joined #openstack-keystone | 01:26 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users: unified identity https://review.openstack.org/261131 | 01:29 |
---|---|---|
*** fangxu has quit IRC | 01:42 | |
*** markvoelker has joined #openstack-keystone | 01:43 | |
*** markvoelker has quit IRC | 01:48 | |
*** EinstCrazy has quit IRC | 02:03 | |
*** dims has quit IRC | 02:04 | |
*** EinstCrazy has joined #openstack-keystone | 02:05 | |
*** EinstCrazy has quit IRC | 02:05 | |
*** EinstCrazy has joined #openstack-keystone | 02:05 | |
*** EinstCra_ has joined #openstack-keystone | 02:13 | |
*** EinstCrazy has quit IRC | 02:13 | |
*** EinstCrazy has joined #openstack-keystone | 02:15 | |
*** EinstCra_ has quit IRC | 02:15 | |
*** EinstCra_ has joined #openstack-keystone | 02:17 | |
*** EinstCrazy has quit IRC | 02:20 | |
*** ayoung has quit IRC | 02:27 | |
stevemar | davechen: oh noes, fernet is broken? :| | 02:31 |
*** EinstCra_ has quit IRC | 02:34 | |
*** EinstCrazy has joined #openstack-keystone | 02:35 | |
davechen | stevemar: yes | 02:37 |
davechen | stevemar: i am working on that | 02:37 |
davechen | just identified it's a regression | 02:37 |
davechen | i was struggled to setup openstack based on the latest code, sigh. | 02:37 |
davechen | stevemar: it's already Christmas Eve here, why it still online? you are crazy! | 02:39 |
davechen | /it/you | 02:39 |
stevemar | davechen: just checking on some bugs, hardly working :P | 02:42 |
davechen | stevemar: you are fast, i am just filed the bug, enjoy the holiday with your family, all the best! | 02:43 |
*** markvoelker has joined #openstack-keystone | 02:44 | |
*** dims has joined #openstack-keystone | 02:48 | |
*** markvoelker has quit IRC | 02:49 | |
*** dims_ has joined #openstack-keystone | 02:50 | |
davechen | blame on this statement "return self.crypto.encrypt(payload).rstrip(b'=').decode('utf-8')" | 02:51 |
davechen | it doesn't work on python27 | 02:51 |
davechen | will propose the fix shortly. | 02:51 |
*** EinstCrazy has quit IRC | 02:52 | |
*** EinstCra_ has joined #openstack-keystone | 02:53 | |
*** dims has quit IRC | 02:53 | |
*** EinstCra_ has quit IRC | 02:55 | |
*** EinstCrazy has joined #openstack-keystone | 02:55 | |
*** dims_ has quit IRC | 03:03 | |
notmorgan | davechen: what is broken in fernet? | 03:07 |
notmorgan | oh | 03:07 |
* notmorgan catches up | 03:07 | |
notmorgan | really? the strip ? | 03:07 |
notmorgan | when did that land? | 03:08 |
notmorgan | davechen: i ask because i've been running a pretty recent vintage keystone with fernet under py27 | 03:08 |
*** fangxu has joined #openstack-keystone | 03:08 | |
stevemar | notmorgan: bknudson_ did some py3 handling work for fernet | 03:09 |
davechen | notmorgan: couples of days before. | 03:09 |
notmorgan | so it landed within the last couple days? | 03:09 |
davechen | notmorgan: yes. | 03:09 |
notmorgan | ok | 03:09 |
*** markvoelker has joined #openstack-keystone | 03:09 | |
notmorgan | if it was much more than ~1wk ago, i would say something else is going on | 03:09 |
davechen | it's broken if you configure the token as ferent. | 03:09 |
notmorgan | because i'm running a keystone using fernet under py27 from just over a week ago | 03:10 |
notmorgan | and it works as expected | 03:10 |
notmorgan | maybe 2wks at most. | 03:10 |
davechen | try the latest code, and you will hit the issue. | 03:10 |
notmorgan | also why would that fail in py27 | 03:10 |
davechen | :) | 03:10 |
stevemar | notmorgan: https://review.openstack.org/#/c/231711/ | 03:10 |
notmorgan | unless crypto is doing dumb things | 03:10 |
davechen | expected byte string object for header value, value of type unicode found | 03:10 |
notmorgan | oh | 03:10 |
davechen | this is the only message i got from mod wigs | 03:11 |
notmorgan | yeah mod_wsgi issue | 03:11 |
notmorgan | ok | 03:11 |
notmorgan | yeah craptastic | 03:11 |
* notmorgan comments again about how mod_wsgi sucks in many odd ways. | 03:11 | |
davechen | just roll back that line of code, it will work as expected. | 03:11 |
notmorgan | but not as bad as eventlet | 03:11 |
notmorgan | eh, there are other options. | 03:11 |
notmorgan | but for now i'd do just that and roll it back | 03:12 |
* notmorgan has low expectations keystone will really work under py3 in the near future | 03:12 | |
davechen | lol, i am always using mod_wsgi since i always use devstack. | 03:12 |
notmorgan | right. and if you're using eventlet you're doing it wrong :) | 03:12 |
stevemar | notmorgan: i know it's server code, but not really... https://review.openstack.org/#/c/261057/ | 03:13 |
davechen | notmorgan: eventually, all of those sutff will run on py3. | 03:13 |
notmorgan | davechen: maybe | 03:13 |
notmorgan | stevemar: you know if the gate is horribly broken somehow i'd just single approver push that stuff as ptl | 03:14 |
notmorgan | i did in the past | 03:14 |
stevemar | notmorgan: i am comfy doing that for OSC, but not keystone (yet) | 03:14 |
* notmorgan mehs. | 03:14 | |
stevemar | also it's not "broken" it's producing warnings and not actually verifying stuff | 03:14 |
stevemar | but its still passing... | 03:15 |
stevemar | semantics | 03:15 |
notmorgan | so i'd still do single approver for that type of change | 03:15 |
notmorgan | hacking / non-production / OMG BROKEN | 03:15 |
notmorgan | same category | 03:15 |
* notmorgan shrugs | 03:15 | |
notmorgan | again... i'm also not PTL anymore | 03:15 |
stevemar | :P | 03:15 |
*** links has joined #openstack-keystone | 03:24 | |
*** fangxu has quit IRC | 04:37 | |
openstackgerrit | Merged openstack/keystone: Fix pep8 job https://review.openstack.org/261057 | 05:27 |
*** yinbiao has joined #openstack-keystone | 05:28 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/keystone: Updating sample configuration file https://review.openstack.org/261048 | 05:29 |
*** ajayaa has joined #openstack-keystone | 05:31 | |
*** yinbiao has left #openstack-keystone | 05:34 | |
*** markvoelker has quit IRC | 05:45 | |
*** oomichi_ has joined #openstack-keystone | 06:09 | |
*** oomichi has quit IRC | 06:09 | |
openstackgerrit | Maho Koshiya proposed openstack/python-keystoneclient: Add wrapper classes for return-request-id-to-caller https://review.openstack.org/261188 | 06:16 |
*** Nirupama has joined #openstack-keystone | 06:20 | |
*** markvoelker has joined #openstack-keystone | 06:45 | |
*** markvoelker has quit IRC | 06:50 | |
*** markvoelker has joined #openstack-keystone | 07:16 | |
openstackgerrit | Dave Chen proposed openstack/keystone: Convert unicode to str when creating a fernet token https://review.openstack.org/261205 | 07:16 |
*** urulama has quit IRC | 07:27 | |
*** urulama has joined #openstack-keystone | 07:28 | |
davechen | breton: we cannot use six.binary_type or six.string_types. | 07:37 |
davechen | breton: six.binary_type will make it return byte which is encode's work not decode's work | 07:38 |
davechen | pls see my reply | 07:38 |
*** breitz has quit IRC | 07:40 | |
*** breitz1 has joined #openstack-keystone | 07:40 | |
davechen | post your comment anyway, i am going to fix the typo in the commit message, thanks for the review! | 07:43 |
openstackgerrit | Dave Chen proposed openstack/keystone: Convert unicode to str when creating a fernet token https://review.openstack.org/261205 | 07:46 |
breton | davechen: so do I get it right that mod-wsgi required the header to be of a specific type? | 07:54 |
breton | > TypeError: expected byte string object for header value, value of type unicode found | 07:54 |
breton | > byte string object for header value | 07:54 |
breton | that's why I am concerned -- byte string object is str() in python2 and bytes() in python3 | 07:55 |
davechen | breton: i assume byte string here is not meaning we need byte always, i didn't try to convert this to byte and i think mod wsgi should work if it's byte. | 07:56 |
breton | if my guess of the reason (wrong type for header) is correct, it should be unit-tested for the returned type. Something like an assertion isinstance(response['token-header'], str) | 07:57 |
davechen | but what we will do should based on the correct logic from current implementation. | 07:57 |
breton | because if we don't make that test now, it will fail in future again | 07:58 |
davechen | i have added a note there | 07:58 |
davechen | i am not sure what's the value mod wsgi is validating. response['token-header'] is just a guess. | 07:59 |
*** vostrosa has joined #openstack-keystone | 08:00 | |
breton | then we should find out! | 08:00 |
davechen | so, if we want to unit test this, we need to know mod wsgi's behavior at first and this should be out of scope of keystone. | 08:00 |
breton | maybe not unit test, maybe functionally test. | 08:01 |
davechen | ++ | 08:01 |
davechen | i think tempest or our functionally test should care about that. | 08:02 |
breton | regardless, we should make sure that it won't happen again. | 08:02 |
davechen | sure. | 08:02 |
breton | I also wonder if it's mod-wsgi-only problem | 08:02 |
breton | maybe uwsgi + (apache | nginx) will also explode on this. | 08:03 |
davechen | i am also curious about that, so far, from what the info i got it's mod wsgi issue. | 08:03 |
davechen | mod wsgi should fix this i think, what we will do is just a workaournd i think :) | 08:04 |
davechen | breton: are you off these days? | 08:04 |
davechen | off from the office not off from the work i meant :) | 08:05 |
breton | davechen: nope. It's not a holiday in Russia yet :) | 08:07 |
breton | our holidays are from January 1 to January 10 | 08:07 |
davechen | not far away. | 08:08 |
*** e0ne has joined #openstack-keystone | 08:22 | |
stevemar | davechen: when are you heading back home? (or are you already back?) | 08:27 |
stevemar | breton: thanks for reviewing a bunch of patches yesterday :) | 08:27 |
davechen | stevemar: already back. | 08:27 |
davechen | back for couples of days. | 08:27 |
stevemar | davechen: great! | 08:27 |
davechen | stevemar: i was hoping to work there forever, at least it's good for joining the meeting. :) | 08:29 |
stevemar | davechen: hehe, i appreciated it, i'm guessing it was very educational | 08:29 |
davechen | stevemar: i need a certificate. | 08:30 |
stevemar | davechen: what kind of certificate? :P | 08:30 |
davechen | certificate for very educational | 08:31 |
stevemar | davechen: ah | 08:33 |
*** pnavarro has joined #openstack-keystone | 08:35 | |
*** _zouyee has joined #openstack-keystone | 08:39 | |
*** albertom has quit IRC | 08:54 | |
*** albertom has joined #openstack-keystone | 09:02 | |
*** e0ne has quit IRC | 09:03 | |
*** wanghua has joined #openstack-keystone | 09:11 | |
*** markvoelker has quit IRC | 09:16 | |
*** Nirupama has quit IRC | 09:16 | |
davechen | stevemar, breton: pls expect the test case will be added in the next day, need to get so many invoices be reimbursed. | 09:17 |
stevemar | davechen: haha | 09:18 |
stevemar | davechen: of course :) | 09:18 |
*** EinstCrazy has quit IRC | 09:19 | |
*** EinstCra_ has joined #openstack-keystone | 09:19 | |
*** urulama has quit IRC | 09:22 | |
*** urulama has joined #openstack-keystone | 09:22 | |
*** EinstCra_ has quit IRC | 09:25 | |
*** EinstCrazy has joined #openstack-keystone | 09:25 | |
*** EinstCrazy has quit IRC | 09:26 | |
*** EinstCrazy has joined #openstack-keystone | 09:26 | |
*** EinstCrazy has quit IRC | 09:37 | |
*** vgridnev has joined #openstack-keystone | 09:40 | |
*** e0ne has joined #openstack-keystone | 09:41 | |
*** oomichi_ is now known as oomichi_away | 09:44 | |
*** davechen has left #openstack-keystone | 09:47 | |
ktychkova | What is wrong with such request: | 10:01 |
ktychkova | openstack --os-auth-type token_endpoint --os-token="ADMIN" --os-url="http://127.0.0.1:35357/v2.0" service create --name keystone3 --description "OpenStack Identity" identity | 10:01 |
ktychkova | Missing parameter(s): | 10:01 |
ktychkova | Set a service AUTH_URL, with --os-auth-url, OS_AUTH_URL or auth.auth_url | 10:01 |
ktychkova | Acoording docs it should work | 10:01 |
*** GB21 has joined #openstack-keystone | 10:08 | |
*** jasonsb has joined #openstack-keystone | 10:11 | |
openstackgerrit | Ankit Agrawal proposed openstack/keystone: Replace unicode with six.text_type https://review.openstack.org/261253 | 10:15 |
*** markvoelker has joined #openstack-keystone | 10:17 | |
*** albertom has quit IRC | 10:21 | |
*** markvoelker has quit IRC | 10:21 | |
*** albertom has joined #openstack-keystone | 10:23 | |
*** albertom has quit IRC | 10:29 | |
*** albertom has joined #openstack-keystone | 10:41 | |
*** mfedosin has joined #openstack-keystone | 10:48 | |
*** _zouyee has quit IRC | 11:05 | |
breton | ~> | 11:05 |
breton | ~> | 11:05 |
breton | ~> | 11:05 |
breton | dammit | 11:05 |
*** markvoelker has joined #openstack-keystone | 11:18 | |
*** miyagishi_t has quit IRC | 11:18 | |
*** markvoelker has quit IRC | 11:22 | |
*** roxanaghe has joined #openstack-keystone | 11:29 | |
breton | we broke something else. Admin token doesn't work for me now. | 11:35 |
*** ajayaa has quit IRC | 11:39 | |
*** roxanaghe has quit IRC | 11:42 | |
*** jasonsb has quit IRC | 11:45 | |
*** jasonsb has joined #openstack-keystone | 11:47 | |
*** dims has joined #openstack-keystone | 11:48 | |
breton | nope, we didn't. It is just not validated. | 11:51 |
*** _zouyee has joined #openstack-keystone | 11:52 | |
*** jasonsb has quit IRC | 11:56 | |
*** EinstCrazy has joined #openstack-keystone | 11:59 | |
*** zqfan has joined #openstack-keystone | 12:03 | |
openstackgerrit | Merged openstack/keystone: Updating sample configuration file https://review.openstack.org/261048 | 12:07 |
*** GB21 has quit IRC | 12:13 | |
*** urulama has quit IRC | 12:20 | |
*** urulama has joined #openstack-keystone | 12:21 | |
*** vgridnev has quit IRC | 13:03 | |
*** markvoelker has joined #openstack-keystone | 13:03 | |
*** vgridnev has joined #openstack-keystone | 13:06 | |
*** vgridnev has quit IRC | 13:07 | |
*** markvoelker has quit IRC | 13:07 | |
*** vgridnev has joined #openstack-keystone | 13:13 | |
*** ajayaa has joined #openstack-keystone | 13:20 | |
*** urulama has quit IRC | 13:20 | |
*** urulama has joined #openstack-keystone | 13:21 | |
*** ajayaa has quit IRC | 13:26 | |
*** links has quit IRC | 13:29 | |
*** pnavarro has quit IRC | 13:37 | |
*** chlong has quit IRC | 13:42 | |
*** nodir has joined #openstack-keystone | 13:49 | |
*** jasonsb has joined #openstack-keystone | 13:49 | |
openstackgerrit | gordon chung proposed openstack/keystonemiddleware: use the same context across a request https://review.openstack.org/216889 | 13:50 |
*** chlong has joined #openstack-keystone | 13:54 | |
*** vgridnev has quit IRC | 13:59 | |
*** vgridnev has joined #openstack-keystone | 14:00 | |
*** mfedosin has quit IRC | 14:01 | |
*** boris-42 has quit IRC | 14:13 | |
*** dslevin_ has quit IRC | 14:17 | |
*** dslev has joined #openstack-keystone | 14:27 | |
*** dims has quit IRC | 14:32 | |
*** links has joined #openstack-keystone | 14:35 | |
*** dims has joined #openstack-keystone | 14:35 | |
*** markvoelker has joined #openstack-keystone | 14:49 | |
openstackgerrit | Ron De Rose proposed openstack/keystone: Shadow users: unified identity https://review.openstack.org/261131 | 14:52 |
*** markvoelker has quit IRC | 14:54 | |
*** EinstCrazy has quit IRC | 15:04 | |
*** EinstCrazy has joined #openstack-keystone | 15:04 | |
*** _zouyee has quit IRC | 15:20 | |
*** tonytan4ever has joined #openstack-keystone | 15:36 | |
*** vgridnev has quit IRC | 15:43 | |
*** exploreshaifali has joined #openstack-keystone | 15:59 | |
*** urulama has quit IRC | 16:00 | |
*** links has quit IRC | 16:05 | |
*** wanghua has quit IRC | 16:23 | |
*** boris-42 has joined #openstack-keystone | 16:24 | |
*** e0ne has quit IRC | 16:38 | |
*** aix has quit IRC | 16:41 | |
*** exploreshaifali has quit IRC | 16:42 | |
*** vgridnev has joined #openstack-keystone | 16:45 | |
*** tonytan4ever has quit IRC | 16:48 | |
*** markvoelker has joined #openstack-keystone | 16:50 | |
*** markvoelker has quit IRC | 16:54 | |
*** jasonsb has quit IRC | 16:55 | |
*** jasonsb has joined #openstack-keystone | 16:57 | |
*** albertom has quit IRC | 17:03 | |
*** albertom has joined #openstack-keystone | 17:11 | |
*** jed56 has joined #openstack-keystone | 17:47 | |
*** nodir has quit IRC | 17:58 | |
*** openstackstatus has quit IRC | 18:05 | |
*** openstack has joined #openstack-keystone | 18:05 | |
*** openstackstatus has joined #openstack-keystone | 18:06 | |
*** ChanServ sets mode: +v openstackstatus | 18:06 | |
*** markvoelker has joined #openstack-keystone | 18:17 | |
*** henrynash has joined #openstack-keystone | 18:34 | |
*** ChanServ sets mode: +v henrynash | 18:34 | |
*** lhcheng has joined #openstack-keystone | 18:55 | |
*** ChanServ sets mode: +v lhcheng | 18:55 | |
notmorgan | ktychkova: there is a bug in OCC | 19:07 |
notmorgan | ktychkova: i expect to have it fixed soonish | 19:07 |
*** pnavarro has joined #openstack-keystone | 19:46 | |
*** henrynash has quit IRC | 19:46 | |
*** jed56 has quit IRC | 19:53 | |
*** dave-mccowan has joined #openstack-keystone | 20:03 | |
*** markvoelker has quit IRC | 20:18 | |
*** lhcheng has quit IRC | 20:24 | |
*** albertom has quit IRC | 20:33 | |
*** albertom has joined #openstack-keystone | 20:41 | |
*** breitz1 has quit IRC | 20:45 | |
*** henrynash has joined #openstack-keystone | 21:03 | |
*** ChanServ sets mode: +v henrynash | 21:03 | |
*** markvoelker has joined #openstack-keystone | 21:18 | |
*** markvoelker has quit IRC | 21:23 | |
*** dave-mccowan has quit IRC | 21:24 | |
*** albertom has quit IRC | 21:38 | |
*** markvoelker has joined #openstack-keystone | 21:39 | |
*** ajayaa has joined #openstack-keystone | 21:42 | |
*** henrynash has quit IRC | 21:42 | |
*** albertom has joined #openstack-keystone | 21:45 | |
*** vostrosa has quit IRC | 21:56 | |
*** alejandrito has joined #openstack-keystone | 21:58 | |
breton | what is occ? | 22:05 |
breton | osc I guess, ok | 22:06 |
*** henrynash has joined #openstack-keystone | 22:07 | |
*** ChanServ sets mode: +v henrynash | 22:07 | |
*** sdake_ has joined #openstack-keystone | 22:15 | |
*** vgridnev has quit IRC | 22:16 | |
*** albertom has quit IRC | 22:18 | |
notmorgan | os-client-config | 22:18 |
notmorgan | https://git.openstack.org/cgit/openstack/os-client-config | 22:19 |
*** albertom has joined #openstack-keystone | 22:25 | |
*** alejandrito has quit IRC | 22:27 | |
*** ajayaa has quit IRC | 22:55 | |
*** sdake_ has quit IRC | 23:00 | |
*** sdake has joined #openstack-keystone | 23:02 | |
*** henrynash has quit IRC | 23:07 | |
*** albertom has quit IRC | 23:09 | |
*** pnavarro has quit IRC | 23:11 | |
*** sdake has quit IRC | 23:14 | |
*** albertom has joined #openstack-keystone | 23:15 | |
*** henrynash has joined #openstack-keystone | 23:19 | |
*** ChanServ sets mode: +v henrynash | 23:19 | |
*** zqfan has quit IRC | 23:21 | |
*** sdake has joined #openstack-keystone | 23:30 | |
*** markvoelker has quit IRC | 23:39 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!