| morganfainberg | gyee, there is a difference between shoving crap into structured data and extending a structured data model | 00:00 |
|---|---|---|
| gyee | hahaha | 00:00 |
| morganfainberg | gyee, everyting v2 at this point is pretty much the former | 00:00 |
| * jamielennox just discovered that my mail client is not syncing the openstack-dev folder thought it had been quiet | 00:00 | |
| morganfainberg | jamielennox, v | 00:00 |
| morganfainberg | jamielennox, https://www.surveymonkey.com/results/SM-LX589JF8/ | 00:00 |
| gyee | well, we shove trust in v2 | 00:00 |
| morganfainberg | gyee, we also blindly shove the entire metadata into it | 00:00 |
| gyee | and issue_data | 00:00 |
| morganfainberg | among a whole lot of other things that is just "oh whatever you pass to us" | 00:00 |
| * gyee eschew metadata | 00:01 | |
| morganfainberg | i'm not opposed to a custom field model that can be used to extend that data | 00:01 |
| morganfainberg | i am opposed to "here put everything into that token ... and this... and this... and this" | 00:01 |
| openstackgerrit | A change was merged to openstack/keystonemiddleware: Remove intersphinx mappings https://review.openstack.org/112480 | 00:01 |
| jamielennox | morganfainberg: 11% custom provider :O | 00:02 |
| morganfainberg | gyee, maybe the right answer is "issue_token" calls "get_base_token_data", "get_custom_structured_data", "format_token", "create_token_id", return data | 00:02 |
| morganfainberg | gyee, the two that go on the driver are "get_custom_structured_data and create_token_id | 00:03 |
| gyee | morganfainberg, ++ | 00:03 |
| gyee | we need to provide hooks for extensions | 00:03 |
| gyee | we need it for federation anyway | 00:04 |
| morganfainberg | anything that is custom structured data would be <ID>:<VALUE> and go in something like 'OS-EXTENDED-DATA:id':<value> | 00:04 |
| morganfainberg | gyee, the in-tree keystone things can have special case code and labels (OS-TRUST, OS-FEDERATED, etc) | 00:04 |
| gyee | morganfainberg, works for me, bring some sanity to customization | 00:04 |
| *** bknudson has joined #openstack-keystone | 00:04 | |
| morganfainberg | darn it, bknudson missed the convo :( | 00:05 |
| bknudson | ?? | 00:05 |
| gyee | morganfainberg, on a different topic, after running tox, etc/keystone.conf.sample got modified | 00:05 |
| morganfainberg | bknudson, refactoring issue tokens and validate token to be 100% on the manager, so the workflow wouild be | 00:05 |
| gyee | is it my env or this is a bug | 00:05 |
| bknudson | it makes sense to have everything in the manager | 00:06 |
| *** dims has quit IRC | 00:06 | |
| gyee | all I did was 1) git clone keystone and 2) tox | 00:06 |
| morganfainberg | bknudson, issue_token gets basic token data, gets driver customized data (e.g. HP has custom data in the tokens), formats the token V2/V3/VXX, and then does create_id(token_data) | 00:06 |
| gyee | freaking keystone.conf.sample got changed while running tox | 00:06 |
| gyee | w | 00:06 |
| gyee | t | 00:06 |
| gyee | f? | 00:06 |
| *** dims has joined #openstack-keystone | 00:06 | |
| morganfainberg | gyee, tox runs *all* environments, py26, 27, 33, sample_config | 00:06 |
| gyee | morganfainberg, the default option | 00:07 |
| morganfainberg | gyee, so.. you ran the sample_config generator by running bare "tox" instead of tox -e<environment> | 00:07 |
| bknudson | morganfainberg: is it needed for juno? | 00:07 |
| morganfainberg | bknudson, it'd be needed for non-persistent tokens | 00:07 |
| morganfainberg | bknudson, which at this point i don't think can land 100% in junoi | 00:07 |
| openstackgerrit | A change was merged to openstack/keystonemiddleware: Add a test for re-caching a token https://review.openstack.org/114848 | 00:07 |
| morganfainberg | bknudson, v2 tokens are so wild-west i can't make CMS extracted code work cleanly, there is a lot of assumption that we've looked up the metadata_ref etc in the current provider code | 00:08 |
| morganfainberg | bknudson, and a lot of "we'll just throw whatever data you want into the tokens,pass it on in" | 00:08 |
| bknudson | I can't figure out that code anymore. | 00:08 |
| gyee | rtfc | 00:08 |
| morganfainberg | bknudson, i got ~50% through moving to cms extracting the pki tokens and ran into "oh except for all these edge cases in v2 tokens because we didn't specify the token format" | 00:09 |
| morganfainberg | bknudson, i figure i can keep *most* of that functionality but define what we've got going into the tokens at least somewhat reasonably so we can do a cms decode and know what to expect | 00:10 |
| morganfainberg | bknudson, and make it clear what the data is not just blobs of "oh we got some dict we'll just leave that lying around" | 00:10 |
| *** dims has quit IRC | 00:11 | |
| morganfainberg | most of these issues are keystone internals only not really issues with what auth_token sees | 00:11 |
| *** stevemar has joined #openstack-keystone | 00:14 | |
| bknudson | morganfainberg: what does auth_token have to do with it? | 00:15 |
| morganfainberg | bknudson, nothing, just auth-token already relies on cms and does the right thing™, so the issues i'm running into isn't middleware related was all i was pointing out | 00:15 |
| bknudson | there's a lot of functions that are like v2_token v3_token and you don't know whether that's the input version or the response version? | 00:15 |
| bknudson | it's wacky | 00:15 |
| jamielennox | bknudson: https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/auth/identity/v2.py#L116 causes problems with keystonemiddleware tests | 00:16 |
| bknudson | we'd have to have a really canonical way to convert a v3 to a v2 token | 00:16 |
| *** HenryG_ is now known as HenryG | 00:16 | |
| jamielennox | they setup a password plugin with no parameters and expect the stubbing to work | 00:16 |
| jamielennox | technically a breakage but is it better to just fix auth_token? | 00:17 |
| bknudson | otherwise I think we'd wind up with a change that's not backwards compat | 00:17 |
| bknudson | jamielennox: where's the middleware test? | 00:17 |
| bknudson | and how did you find out it broke keystonemiddleware? | 00:18 |
| bknudson | wouldn't the original code break keystonemiddleware too? | 00:18 |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: Hash for PKIZ https://review.openstack.org/114654 | 00:18 |
| jamielennox | bknudson: all of them https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/tests/test_auth_token_middleware.py#L224 | 00:18 |
| *** praneshp has quit IRC | 00:19 | |
| jamielennox | easily fixed with http://paste.openstack.org/show/100188/ but is it a compatibility issue we care about? | 00:19 |
| bknudson | jamielennox: I'm still trying to figure out how it worked before... the parameters were required, so that would have failed. | 00:20 |
| jamielennox | no, it loads them via _conf_get so it was passing a parameter but it was passing None | 00:20 |
| morganfainberg | bknudson, that was what i've been driving towards with the token_model, and if the formatter could do that conversion, easy | 00:21 |
| jamielennox | the auth request that was being constructed wouldn't have worked, but it doesn't matter because we are mocking the response | 00:21 |
| bknudson | jamielennox: so you could fix keystoneclient... instead of using None use a different sentinel. | 00:22 |
| jamielennox | because of https://github.com/openstack/keystonemiddleware/blob/master/keystonemiddleware/auth_token.py#L1038 | 00:22 |
| *** Kui has joined #openstack-keystone | 00:22 | |
| jamielennox | ugly, but i don't think we have another option because otherwise the tests won't work for middleware with newer client | 00:23 |
| bknudson | jamielennox: I think you need to do that. | 00:23 |
| bknudson | middleware tests can also be changed. | 00:23 |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: Move fake session to HTTPClient https://review.openstack.org/108868 | 00:24 |
| openstackgerrit | A change was merged to openstack/keystone: Configurable python-keystoneclient repo https://review.openstack.org/103283 | 00:24 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Allow passing None for username in v2.Password https://review.openstack.org/116757 | 00:36 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Enhance V3 extensions to provide JSON Home data https://review.openstack.org/103983 | 00:37 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Change the sub-routers to provide JSON Home data https://review.openstack.org/111577 | 00:37 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Change OS-INHERIT extension to provide JSON Home data https://review.openstack.org/111578 | 00:37 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Enhance V3 extension class to integrate JSON Home data https://review.openstack.org/111579 | 00:37 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Enhance GET /v3 to handle Accept header https://review.openstack.org/115462 | 00:37 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/keystonemiddleware: Always supply a username to auth_token tests setup https://review.openstack.org/116760 | 00:39 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/keystonemiddleware: Create an Auth Plugin to pass to users https://review.openstack.org/107222 | 00:41 |
| *** jorge_munoz has joined #openstack-keystone | 00:52 | |
| *** mitz has joined #openstack-keystone | 00:53 | |
| *** jorge_munoz has quit IRC | 00:58 | |
| *** diegows has joined #openstack-keystone | 00:59 | |
| *** wanghong has joined #openstack-keystone | 01:05 | |
| *** dims_ has joined #openstack-keystone | 01:25 | |
| *** zzzeek has quit IRC | 01:26 | |
| *** zzzeek has joined #openstack-keystone | 01:28 | |
| *** richm has quit IRC | 01:39 | |
| *** marcoemorais has quit IRC | 01:40 | |
| *** diegows has quit IRC | 01:51 | |
| *** alex_xu has joined #openstack-keystone | 01:55 | |
| *** shakamunyi has quit IRC | 02:05 | |
| *** toddnni has joined #openstack-keystone | 02:15 | |
| *** gokrokve_ has quit IRC | 02:15 | |
| *** shakamunyi has joined #openstack-keystone | 02:23 | |
| *** rushiagr_away is now known as rushiagr | 02:24 | |
| *** rushiagr is now known as rushiagr_away | 02:25 | |
| *** dims_ has quit IRC | 02:29 | |
| *** dims_ has joined #openstack-keystone | 02:29 | |
| *** david-lyle has quit IRC | 02:31 | |
| *** gyee has quit IRC | 02:47 | |
| *** dims__ has joined #openstack-keystone | 02:48 | |
| *** dims_ has quit IRC | 02:48 | |
| *** Kui has quit IRC | 02:48 | |
| *** vhoward has left #openstack-keystone | 02:51 | |
| *** ncoghlan has joined #openstack-keystone | 02:52 | |
| openstackgerrit | A change was merged to openstack/keystone: assignment controller error path fix https://review.openstack.org/116647 | 02:52 |
| *** gokrokve has joined #openstack-keystone | 02:53 | |
| *** ncoghlan is now known as ncoghlan_afk | 02:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/111620 | 02:55 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/116255 | 02:59 |
| *** dims__ has quit IRC | 03:00 | |
| *** KanagarajM has joined #openstack-keystone | 03:03 | |
| *** Kui has joined #openstack-keystone | 03:11 | |
| *** ncoghlan_afk is now known as ncoghlan | 03:19 | |
| *** Kui has quit IRC | 03:24 | |
| *** Kui has joined #openstack-keystone | 03:25 | |
| *** zzzeek has quit IRC | 03:37 | |
| *** harlowja is now known as harlowja_away | 03:47 | |
| *** harlowja_away is now known as harlowja | 03:48 | |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Mark methods on token_api deprecated https://review.openstack.org/115347 | 03:49 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove trust dependency on token_api https://review.openstack.org/109462 | 03:49 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Revoke by Audit Id / Audit Id Chain instead of expires https://review.openstack.org/114864 | 03:49 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Update AuthContextMiddleware to not use token_api https://review.openstack.org/113429 | 03:49 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add extra guarding to revoke_by_audit_id methods https://review.openstack.org/115147 | 03:50 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Notification Constant Cleanup and internal notify type https://review.openstack.org/115337 | 03:50 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove assignment_api dependency on token_api https://review.openstack.org/115338 | 03:50 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove wsgi and base controller dependency on token_api https://review.openstack.org/115205 | 03:50 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove identity_api dependency on token_api https://review.openstack.org/115045 | 03:50 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove SAML2 plugin dependency on token_api https://review.openstack.org/115012 | 03:50 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove oauth controller dependency on token_api https://review.openstack.org/115343 | 03:50 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add __repr__ to KeystoneToken model https://review.openstack.org/113430 | 03:50 |
| *** marcoemorais has joined #openstack-keystone | 03:53 | |
| *** marcoemorais has quit IRC | 03:54 | |
| morganfainberg | i think i'm losing my mind | 03:57 |
| morganfainberg | i've now had rebases fail and revert code on my ~4 times today | 03:57 |
| morganfainberg | :( | 03:57 |
| *** vhoward has joined #openstack-keystone | 03:59 | |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Revoke by Audit Id / Audit Id Chain instead of expires https://review.openstack.org/114864 | 04:02 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Revoke by Audit Id / Audit Id Chain instead of expires https://review.openstack.org/114864 | 04:02 |
| *** david-lyle has joined #openstack-keystone | 04:02 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Allow overriding endpoint URLs in session https://review.openstack.org/116543 | 04:04 |
| *** zzzeek has joined #openstack-keystone | 04:06 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Versioned Endpoint hack for Sessions https://review.openstack.org/90632 | 04:07 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: [WIP] Add template hacks to identity plugins https://review.openstack.org/112752 | 04:07 |
| *** david-lyle has quit IRC | 04:07 | |
| *** zzzeek has quit IRC | 04:11 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/keystonemiddleware: Replace httpretty with requests-mock https://review.openstack.org/112777 | 04:11 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Mark methods on token_api deprecated https://review.openstack.org/115347 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove trust dependency on token_api https://review.openstack.org/109462 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Update AuthContextMiddleware to not use token_api https://review.openstack.org/113429 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add extra guarding to revoke_by_audit_id methods https://review.openstack.org/115147 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Notification Constant Cleanup and internal notify type https://review.openstack.org/115337 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove assignment_api dependency on token_api https://review.openstack.org/115338 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove wsgi and base controller dependency on token_api https://review.openstack.org/115205 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove identity_api dependency on token_api https://review.openstack.org/115045 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove SAML2 plugin dependency on token_api https://review.openstack.org/115012 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Remove oauth controller dependency on token_api https://review.openstack.org/115343 | 04:12 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add __repr__ to KeystoneToken model https://review.openstack.org/113430 | 04:12 |
| morganfainberg | stevemar, why does git hate me so much :( | 04:13 |
| stevemar | morganfainberg, cause of your rebase bonanza | 04:14 |
| morganfainberg | stevemar, i had to get a visual git explorer out to solve this rebase issue | 04:14 |
| stevemar | eek | 04:14 |
| morganfainberg | and it involved a lot of reflog viewing | 04:14 |
| *** praneshp has joined #openstack-keystone | 04:16 | |
| stevemar | morganfainberg, i got a q for your | 04:16 |
| stevemar | you* | 04:16 |
| morganfainberg | stevemar, sure | 04:17 |
| morganfainberg | stevemar, before i go and call it a night | 04:17 |
| stevemar | morganfainberg, https://review.openstack.org/#/c/111576/6/keystone/auth/routers.py | 04:17 |
| stevemar | where is the spec for OS-PKI ? | 04:17 |
| stevemar | line 42... | 04:17 |
| morganfainberg | stevemar, uhm... | 04:19 |
| morganfainberg | stevemar you mean identity-api bits? | 04:19 |
| morganfainberg | stevemar, that is the token revocation list, predates the -specs repo | 04:19 |
| stevemar | is there any info on it on identity-api? | 04:19 |
| *** praneshp_ has joined #openstack-keystone | 04:21 | |
| morganfainberg | must be missing | 04:21 |
| morganfainberg | but the router is there | 04:21 |
| *** praneshp has quit IRC | 04:21 | |
| *** praneshp_ is now known as praneshp | 04:21 | |
| stevemar | yeah, i know the router exists, weird that we don't have it doced | 04:26 |
| stevemar | ahh apparently GET /v3/auth/tokens/OS-PKI/revoked should be deprecated | 04:27 |
| stevemar | also | 04:27 |
| stevemar | https://bugs.launchpad.net/openstack-api-site/+bug/1304606 | 04:27 |
| uvirtbot | Launchpad bug 1304606 in openstack-api-site "Identity API v3 OS-PKI extension is undocumented" [High,Triaged] | 04:27 |
| stevemar | awful | 04:28 |
| stevemar | f'ing awful | 04:28 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/identity-api: Clean up JSON home API https://review.openstack.org/116784 | 04:30 |
| openstackgerrit | Kanagaraj Manickam proposed a change to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 04:32 |
| *** zzzeek has joined #openstack-keystone | 04:36 | |
| *** oomichi_away has quit IRC | 04:37 | |
| *** chandankumar has joined #openstack-keystone | 04:43 | |
| *** zzzeek has quit IRC | 04:44 | |
| *** amirosh has joined #openstack-keystone | 04:52 | |
| *** david-lyle has joined #openstack-keystone | 05:03 | |
| *** david-lyle has quit IRC | 05:07 | |
| openstackgerrit | A change was merged to openstack/keystone: Back off initial migration to 35 https://review.openstack.org/114827 | 05:12 |
| openstackgerrit | A change was merged to openstack/keystone: Make SQL the default backend for Identity & Assignment unit tests. https://review.openstack.org/116528 | 05:12 |
| *** zzzeek has joined #openstack-keystone | 05:15 | |
| *** shakamunyi has quit IRC | 05:16 | |
| *** KanagarajM has quit IRC | 05:17 | |
| openstackgerrit | A change was merged to openstack/keystone: Provide the V3 routers to the V3 extension controller https://review.openstack.org/111574 | 05:17 |
| *** chandankumar has quit IRC | 05:18 | |
| *** yasukun has joined #openstack-keystone | 05:19 | |
| *** zzzeek has quit IRC | 05:20 | |
| *** chandankumar has joined #openstack-keystone | 05:32 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Create SAML generation route and controller https://review.openstack.org/114138 | 05:36 |
| *** KanagarajM has joined #openstack-keystone | 05:36 | |
| *** ajayaa has joined #openstack-keystone | 05:46 | |
| *** stevemar has quit IRC | 05:54 | |
| *** ncoghlan is now known as ncoghlan_afk | 05:57 | |
| *** k4n0 has joined #openstack-keystone | 05:57 | |
| *** gokrokve has quit IRC | 06:00 | |
| *** david-lyle has joined #openstack-keystone | 06:04 | |
| *** alex_xu has quit IRC | 06:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Imported Translations from Transifex https://review.openstack.org/111920 | 06:05 |
| *** david-lyle has quit IRC | 06:08 | |
| *** ajayaa has quit IRC | 06:15 | |
| *** ukalifon has joined #openstack-keystone | 06:16 | |
| *** zzzeek has joined #openstack-keystone | 06:17 | |
| *** alex_xu has joined #openstack-keystone | 06:17 | |
| *** afazekas has joined #openstack-keystone | 06:17 | |
| *** zzzeek has quit IRC | 06:22 | |
| *** gokrokve has joined #openstack-keystone | 06:27 | |
| *** ajayaa has joined #openstack-keystone | 06:28 | |
| *** gokrokve has quit IRC | 06:28 | |
| *** gokrokve has joined #openstack-keystone | 06:29 | |
| *** dvorak has quit IRC | 06:29 | |
| *** gokrokve has quit IRC | 06:30 | |
| *** harlowja is now known as harlowja_away | 06:31 | |
| *** gokrokve has joined #openstack-keystone | 06:31 | |
| *** jimbaker has quit IRC | 06:31 | |
| *** jimbaker has joined #openstack-keystone | 06:35 | |
| *** jimbaker has quit IRC | 06:35 | |
| *** jimbaker has joined #openstack-keystone | 06:35 | |
| *** gokrokve has quit IRC | 06:35 | |
| openstackgerrit | A change was merged to openstack/keystone: Enhance V3 version controller to provide JSON Home response https://review.openstack.org/111575 | 06:36 |
| *** alex_xu has quit IRC | 06:44 | |
| *** ncoghlan_afk is now known as ncoghlan | 06:50 | |
| *** RicoLin has joined #openstack-keystone | 06:57 | |
| *** RicoLin has joined #openstack-keystone | 06:58 | |
| *** alex_xu has joined #openstack-keystone | 06:58 | |
| *** IamNewB has joined #openstack-keystone | 07:01 | |
| *** rushiagr_away is now known as rushiagr | 07:02 | |
| IamNewB | Hello, I wanted to browse keystone server code, but not able to understand from where to start. I wanted to know when we run keystonecommand like user-role-list, where it lands in keystone server code | 07:04 |
| *** david-lyle has joined #openstack-keystone | 07:05 | |
| *** david-lyle has quit IRC | 07:09 | |
| *** zzzeek has joined #openstack-keystone | 07:18 | |
| *** wanghong has quit IRC | 07:20 | |
| *** zzzeek has quit IRC | 07:24 | |
| *** gokrokve has joined #openstack-keystone | 07:29 | |
| *** gokrokve has quit IRC | 07:33 | |
| *** Daviey has quit IRC | 07:34 | |
| *** IamNewB has quit IRC | 07:38 | |
| *** Daviey has joined #openstack-keystone | 07:40 | |
| *** jamielennox is now known as jamielennox|away | 08:03 | |
| *** david-lyle has joined #openstack-keystone | 08:05 | |
| *** david-lyle has quit IRC | 08:10 | |
| *** KanagarajM2 has joined #openstack-keystone | 08:11 | |
| *** KanagarajM has quit IRC | 08:12 | |
| openstackgerrit | Dave Chen proposed a change to openstack/keystone: Inaccurate description found in keystone's manual o Add sudo prefix in commandline as normal user don't have permission to make changes on dist-packages or site-packages by default. o The link will be made in the dist-packages instead of sit https://review.openstack.org/116820 | 08:19 |
| *** zzzeek has joined #openstack-keystone | 08:20 | |
| *** henrynash has joined #openstack-keystone | 08:21 | |
| openstackgerrit | Marcos Fermín Lobo proposed a change to openstack/keystone: Implement validation on the Catalog V3 resources https://review.openstack.org/96266 | 08:23 |
| *** zzzeek has quit IRC | 08:25 | |
| *** gokrokve has joined #openstack-keystone | 08:29 | |
| *** gokrokve has quit IRC | 08:34 | |
| *** ajayaa has quit IRC | 08:37 | |
| openstackgerrit | Kanagaraj Manickam proposed a change to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 08:45 |
| openstackgerrit | Kanagaraj Manickam proposed a change to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 08:49 |
| *** ncoghlan has quit IRC | 08:56 | |
| *** bdossant has joined #openstack-keystone | 08:58 | |
| *** david-lyle has joined #openstack-keystone | 09:06 | |
| *** ajayaa has joined #openstack-keystone | 09:07 | |
| *** david-lyle has quit IRC | 09:10 | |
| bdossant | Hi! Can anyone tell me if in Juno the "Domain-specific Drivers" feature will be ready? I see that theres already documentation on this but cloning the master repo I havent able to make it work with LDAP and SQL domain drivers | 09:11 |
| *** aix has joined #openstack-keystone | 09:17 | |
| *** alex_xu has quit IRC | 09:18 | |
| *** ajayaa has quit IRC | 09:19 | |
| *** ajayaa has joined #openstack-keystone | 09:20 | |
| *** zzzeek has joined #openstack-keystone | 09:21 | |
| openstackgerrit | Kanagaraj Manickam proposed a change to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 09:25 |
| *** zzzeek has quit IRC | 09:27 | |
| *** gokrokve has joined #openstack-keystone | 09:29 | |
| *** gokrokve has quit IRC | 09:31 | |
| *** gokrokve has joined #openstack-keystone | 09:31 | |
| *** amirosh has quit IRC | 09:35 | |
| *** gokrokve has quit IRC | 09:35 | |
| *** amirosh_ has joined #openstack-keystone | 09:37 | |
| *** praneshp has quit IRC | 09:43 | |
| *** jasondotstar|afk has quit IRC | 10:01 | |
| *** david-lyle has joined #openstack-keystone | 10:07 | |
| *** david-lyle has quit IRC | 10:12 | |
| *** XEye has joined #openstack-keystone | 10:18 | |
| *** gokrokve has joined #openstack-keystone | 10:29 | |
| openstackgerrit | Ajaya Agrawal proposed a change to openstack/keystone: Implemented caching in identity layer. https://review.openstack.org/110575 | 10:32 |
| openstackgerrit | Kanagaraj Manickam proposed a change to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 10:34 |
| *** gokrokve has quit IRC | 10:34 | |
| *** david-lyle has joined #openstack-keystone | 11:08 | |
| *** david-lyle has quit IRC | 11:12 | |
| *** renlt has joined #openstack-keystone | 11:13 | |
| *** bvandenh has joined #openstack-keystone | 11:14 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/keystone: Comparision of database models and migrations. https://review.openstack.org/80630 | 11:24 |
| *** zzzeek has joined #openstack-keystone | 11:25 | |
| *** gokrokve has joined #openstack-keystone | 11:29 | |
| *** zzzeek has quit IRC | 11:30 | |
| *** aix has quit IRC | 11:31 | |
| *** gokrokve has quit IRC | 11:33 | |
| openstackgerrit | Alexey Miroshkin proposed a change to openstack/keystone: Prevent domains creation for the default LDAP+SQL https://review.openstack.org/116858 | 11:35 |
| *** diegows has joined #openstack-keystone | 11:48 | |
| *** rushiagr is now known as rushiagr_away | 11:58 | |
| openstackgerrit | Kanagaraj Manickam proposed a change to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 12:07 |
| *** david-lyle has joined #openstack-keystone | 12:08 | |
| *** gordc has joined #openstack-keystone | 12:12 | |
| *** david-lyle has quit IRC | 12:13 | |
| *** KanagarajM2 has quit IRC | 12:18 | |
| *** stevemar has joined #openstack-keystone | 12:26 | |
| *** zzzeek has joined #openstack-keystone | 12:26 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed a change to openstack/keystone: Improve list role assignments filters performance https://review.openstack.org/116682 | 12:27 |
| *** gokrokve has joined #openstack-keystone | 12:29 | |
| *** alex_xu has joined #openstack-keystone | 12:31 | |
| *** zzzeek has quit IRC | 12:32 | |
| *** jaosorior has joined #openstack-keystone | 12:33 | |
| *** gokrokve has quit IRC | 12:34 | |
| *** aix has joined #openstack-keystone | 12:41 | |
| *** dvorak has joined #openstack-keystone | 12:45 | |
| *** k4n0 has quit IRC | 12:49 | |
| *** miqui has joined #openstack-keystone | 12:58 | |
| *** joesavak has joined #openstack-keystone | 13:01 | |
| *** bknudson has quit IRC | 13:06 | |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: IdP SAML Metadata generator https://review.openstack.org/114850 | 13:08 |
| *** topol has joined #openstack-keystone | 13:08 | |
| *** david-lyle has joined #openstack-keystone | 13:09 | |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: Generate IdP Metadata with keystone-manage. https://review.openstack.org/115564 | 13:10 |
| *** Kui has quit IRC | 13:12 | |
| openstackgerrit | Ilya Pekelny proposed a change to openstack/keystone: Use metadata.create_all() to fill a test database https://review.openstack.org/93558 | 13:13 |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: Routes for Keystone-IdP metadata endpoint. https://review.openstack.org/115883 | 13:13 |
| *** david-lyle has quit IRC | 13:13 | |
| *** nkinder has quit IRC | 13:18 | |
| *** inteq has joined #openstack-keystone | 13:23 | |
| *** gokrokve has joined #openstack-keystone | 13:29 | |
| *** gokrokve has quit IRC | 13:33 | |
| *** chandankumar has quit IRC | 13:38 | |
| *** yasukun has quit IRC | 13:40 | |
| *** chandankumar has joined #openstack-keystone | 13:41 | |
| *** ajayaa has quit IRC | 13:41 | |
| *** chandankumar has quit IRC | 13:53 | |
| *** chandankumar has joined #openstack-keystone | 13:54 | |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Implement validation on the Catalog V3 resources https://review.openstack.org/96266 | 13:56 |
| *** david-lyle has joined #openstack-keystone | 13:57 | |
| *** gokrokve has joined #openstack-keystone | 14:00 | |
| *** chandankumar has quit IRC | 14:06 | |
| *** bknudson has joined #openstack-keystone | 14:10 | |
| *** dims has joined #openstack-keystone | 14:11 | |
| *** jasondotstar has joined #openstack-keystone | 14:12 | |
| *** nkinder has joined #openstack-keystone | 14:12 | |
| *** cjellick has joined #openstack-keystone | 14:15 | |
| ByteSore | hi people, got a question.. i've been testing alot today with glance authentication.. i can't get it to work. when i run a glance index i'm getting an error in the api.log: NotAuthenticated: Authentication required i have the OS_USERNAME and all set to the right info. if i check it with swift the credentials do work. | 14:17 |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Make BaseValidationTestCase https://review.openstack.org/109098 | 14:19 |
| *** cjellick has quit IRC | 14:21 | |
| *** cjellick has joined #openstack-keystone | 14:21 | |
| *** henrynash has quit IRC | 14:22 | |
| *** jorge_munoz has joined #openstack-keystone | 14:23 | |
| lbragstad | hockeynut: I believe this was the review/bug with ssl certs that's already been purposed | 14:23 |
| lbragstad | https://review.openstack.org/#/c/88207/ | 14:23 |
| lbragstad | hockeynut: I'll reference them in the bug that you opened | 14:24 |
| *** ekarlso has quit IRC | 14:31 | |
| openstackgerrit | Thiago Paiva Brito proposed a change to openstack/python-keystoneclient: Implementing hierarchical calls on keystoneclient v3 (python only) https://review.openstack.org/115770 | 14:32 |
| *** jorge_munoz has quit IRC | 14:34 | |
| *** jorge_munoz has joined #openstack-keystone | 14:34 | |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Add libxmlsec1 as external package dependency on OS X https://review.openstack.org/116907 | 14:39 |
| *** zzzeek has joined #openstack-keystone | 14:43 | |
| dstanek | lbragstad: what changes are you making to https://review.openstack.org/#/c/86484/ ? | 14:44 |
| dstanek | lbragstad: i have a change to test_validation.py that i've put in front of it locally | 14:44 |
| hockeynut | hi lbragstag - thanks for the info - I'll keep an eye on that one. | 14:48 |
| hockeynut | hi lbragstad - thanks for the info - I'll keep an eye on that one. | 14:48 |
| *** dims has quit IRC | 14:51 | |
| *** amirosh_ has quit IRC | 14:53 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Create additional docs for role assignment events https://review.openstack.org/114813 | 14:54 |
| *** dims has joined #openstack-keystone | 14:54 | |
| openstackgerrit | Dolph Mathews proposed a change to openstack/identity-api: Clean up JSON home API https://review.openstack.org/116784 | 14:54 |
| lbragstad | dstanek: the update_schema_validator | 14:55 |
| lbragstad | dstanek: should be update_project_validator and update_domain_validator | 14:56 |
| lbragstad | https://review.openstack.org/#/c/86484/40/keystone/tests/test_validation.py | 14:56 |
| dstanek | lbragstad: i just read the comment about merging the commit - no need to do that anymore - i've been working on testing this morning and i already changed that | 14:56 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Change V3 router classes to provide JSON Home data https://review.openstack.org/111576 | 14:57 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Enhance V3 extensions to provide JSON Home data https://review.openstack.org/103983 | 14:57 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Change the sub-routers to provide JSON Home data https://review.openstack.org/111577 | 14:57 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Change OS-INHERIT extension to provide JSON Home data https://review.openstack.org/111578 | 14:57 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Enhance V3 extension class to integrate JSON Home data https://review.openstack.org/111579 | 14:57 |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Enhance GET /v3 to handle Accept header https://review.openstack.org/115462 | 14:58 |
| lbragstad | dstanek: gotcha, | 14:59 |
| lbragstad | I wasn't aware, I thought this was in WIP https://review.openstack.org/#/c/110336/1 | 14:59 |
| lbragstad | so I was going to roll in to the assignment API validation patch | 14:59 |
| dstanek | lbragstad: i added a bunch of test cases to a commit that i put before yours and i rolled that one into yours | 15:00 |
| dstanek | lbragstad: i also removed the Base* concept since there was no shared setup | 15:00 |
| lbragstad | dstanek: was that on the api-validation branch? | 15:01 |
| dstanek | lbragstad: my new work? | 15:01 |
| lbragstad | yes | 15:01 |
| dstanek | yes, or at least it will be once i push - making sure i have all of the usecases in the tests | 15:02 |
| lbragstad | dstanek: cool | 15:02 |
| lbragstad | dstanek: once you push, I can probably go through and start abandoning duplicate or unnecessary reviews | 15:02 |
| openstackgerrit | Rodrigo Duarte proposed a change to openstack/keystone: Base methods to handle hierarchical projects https://review.openstack.org/111841 | 15:04 |
| openstackgerrit | Rodrigo Duarte proposed a change to openstack/keystone: Add parent_project_id field https://review.openstack.org/111840 | 15:04 |
| openstackgerrit | Rodrigo Duarte proposed a change to openstack/keystone: Create, update and delete hierarchical projects https://review.openstack.org/111842 | 15:04 |
| *** ChanServ sets mode: +o dolphm | 15:06 | |
| *** amirosh has joined #openstack-keystone | 15:07 | |
| dolphm | lbragstad: that would be nice :) | 15:07 |
| openstackgerrit | Rodrigo Duarte proposed a change to openstack/keystone: Inherited roles to projects https://review.openstack.org/116921 | 15:12 |
| *** amirosh has quit IRC | 15:22 | |
| *** renlt has quit IRC | 15:27 | |
| *** chandankumar has joined #openstack-keystone | 15:27 | |
| *** ekarlso has joined #openstack-keystone | 15:29 | |
| dolphm | stevemar: danke https://review.openstack.org/#/c/114813/ | 15:31 |
| *** topol has quit IRC | 15:31 | |
| stevemar | dolphm, bitte | 15:33 |
| *** zzzeek has quit IRC | 15:34 | |
| hockeynut | morning folks - I am trying to run keystone-manage pki_setup and its not doing a darn thing - just comes back to command prompt. Verbose and Debug give me no output either. Am I supposed to run it from any particular directory? | 15:34 |
| *** achudnovets has joined #openstack-keystone | 15:36 | |
| dstanek | hockeynut: are you trying to replace existing files? | 15:36 |
| hockeynut | yes | 15:36 |
| dolphm | dstanek: does it avoid stomping on existing files? | 15:37 |
| dstanek | hockeynut: i thought that it would log an error for that, but i don't think you can do that | 15:37 |
| dstanek | dolphm: yes, i think so | 15:37 |
| hockeynut | dstanek it does nothing. just returns to cmd prompt. No output. Files are untouched. | 15:37 |
| dstanek | hockeynut: i'm pretty sure that it won't overwrite anything | 15:37 |
| *** ukalifon has quit IRC | 15:39 | |
| hockeynut | dstanek I could remove/rename if that is whats needed | 15:39 |
| dstanek | hockeynut: yes, that should work fine | 15:40 |
| *** ekarlso has quit IRC | 15:40 | |
| hockeynut | dstanek I shall give that a try. Fingers crossed... | 15:40 |
| *** ekarlso has joined #openstack-keystone | 15:40 | |
| dstanek | hockeynut: here is the bug https://bugs.launchpad.net/keystone/+bug/1308778 - i'll submit a patch to warn people about it once i'm done with what i'm working on | 15:41 |
| uvirtbot | Launchpad bug 1308778 in keystone "keystone-manage ssl_setup does not overwrite existing files" [Medium,In progress] | 15:41 |
| *** zzzeek has joined #openstack-keystone | 15:41 | |
| hockeynut | uvirtbot yep, saw that. | 15:42 |
| uvirtbot | hockeynut: Error: "yep," is not a valid command. | 15:42 |
| morganfainberg | uvirtbot, good bot. | 15:42 |
| uvirtbot | morganfainberg: Error: "good" is not a valid command. | 15:42 |
| dstanek | uvirtbot: ssshhhh | 15:42 |
| uvirtbot | dstanek: Error: "ssshhhh" is not a valid command. | 15:42 |
| morganfainberg | LOL | 15:42 |
| hockeynut | one of those days... | 15:43 |
| *** wwriverrat has joined #openstack-keystone | 15:47 | |
| *** stevemar has quit IRC | 15:48 | |
| *** stevemar has joined #openstack-keystone | 15:48 | |
| lbragstad | hockeynut: there is a review up to make a --rebuild option for ssl_setup, the same could probably be done for pki_setup | 15:50 |
| hockeynut | lbragstad that would be cool. | 15:51 |
| *** wwriverrat has left #openstack-keystone | 15:51 | |
| lbragstad | hockeynut: https://review.openstack.org/#/c/88207/ | 15:51 |
| lbragstad | that is the review | 15:51 |
| lbragstad | I'll comment on it and see if we can get that same --rebuild option leveraged for pki_setup as well | 15:52 |
| lbragstad | if we're doing it for one, we might as well do it for both | 15:52 |
| hockeynut | lbragstad thanks, that would be epic | 15:52 |
| dstanek | lbragstad: i think those things don't have much movement because they are only dev tools and not production tools | 15:53 |
| lbragstad | correct | 15:53 |
| lbragstad | hockeynut: you're only using this for dev, right? | 15:54 |
| hockeynut | lbragstad correct | 15:54 |
| lbragstad | hockeynut: ok, cool | 15:54 |
| hockeynut | :-D | 15:55 |
| *** wwriverrat1 has joined #openstack-keystone | 15:55 | |
| *** wwriverrat1 has left #openstack-keystone | 15:55 | |
| *** wwriverrat1 has joined #openstack-keystone | 15:56 | |
| *** wwriverrat1 has left #openstack-keystone | 15:57 | |
| *** amerine has joined #openstack-keystone | 15:57 | |
| *** bvandenh has quit IRC | 15:57 | |
| *** wwriverrat has joined #openstack-keystone | 15:57 | |
| *** zzzeek has quit IRC | 16:00 | |
| *** gyee has joined #openstack-keystone | 16:05 | |
| lbragstad | dstanek: for the validation test cases, we are going to add a BaseValidationTestCase and keep ValidationTestCase, right? | 16:06 |
| *** alex_xu has quit IRC | 16:06 | |
| dstanek | lbragstad: no i removed Base* and renamed Validation* | 16:06 |
| lbragstad | dstanek: ok, so everything will extend ValidationTestCase | 16:07 |
| dstanek | lbragstad: working on the last 2 update cases now | 16:07 |
| dstanek | lbragstad: no, nothing extends that because there is no shared setup | 16:07 |
| lbragstad | dstanek: ok | 16:07 |
| dstanek | lbragstad: i have everything extending testtools.TestCase | 16:07 |
| lbragstad | dstanek: ok, so are we going to keep all classes in test_validation.py or break them out into something like test_assignment_validation.py? | 16:08 |
| dstanek | lbragstad: right now i was planning on keeping them together so that we can get this stuff landed - i'd love to move this over to the unit tests shortly after | 16:09 |
| *** wwriverrat has left #openstack-keystone | 16:09 | |
| *** alex_xu has joined #openstack-keystone | 16:09 | |
| *** xianghui has quit IRC | 16:13 | |
| *** rodrigods has joined #openstack-keystone | 16:14 | |
| *** afazekas has quit IRC | 16:14 | |
| *** xianghui has joined #openstack-keystone | 16:15 | |
| lbragstad | dstanek: works for me | 16:15 |
| lbragstad | dstanek: so test cases for all validation stuff should live in test_validation.py, just getting ready so that once you push your work I can refactor the other patches as needed | 16:16 |
| *** marcoemorais has joined #openstack-keystone | 16:18 | |
| *** richm has joined #openstack-keystone | 16:21 | |
| dstanek | lbragstad: i just thought of another usecase | 16:26 |
| dstanek | lbragstad: can booleans be nullable during updates? | 16:27 |
| dstanek | i suspect not | 16:27 |
| lbragstad | dstanek: no, I don't think so | 16:27 |
| lbragstad | dstanek: if you're updating a boolean value it should be a true boolean | 16:27 |
| bknudson | see this little bird on https://review.openstack.org/#/c/111576/7 ? | 16:33 |
| *** gokrokve_ has joined #openstack-keystone | 16:35 | |
| *** gokrokve has quit IRC | 16:38 | |
| *** nkinder has quit IRC | 16:41 | |
| dstanek | lbragstad: sorry i'm stuck in rebase hell | 16:43 |
| lbragstad | dstanek: conflicts? | 16:43 |
| morganfainberg | dolphm, stevemar, dstanek i want to suppress the deprecation warning for the persistence manager (token_api) for testing, any thoughts on the best approach, i'm thinking a instance variable we set in test setup on token_api, just because it's silly to spam the logs with "DEPRECATED" (a lot of tests use token_api still and probably will for the foreseeable future) | 16:43 |
| morganfainberg | and test-only config options are silly | 16:44 |
| dstanek | lbragstad: kinda sorta | 16:44 |
| dstanek | morganfainberg: just for that one case or for all deprecation warnings? | 16:45 |
| stevemar | morganfainberg, sounds reasonable | 16:45 |
| dstanek | morganfainberg: theoretically you could filter the log | 16:45 |
| morganfainberg | dstanek, just that one case, since it doesn't use @versionutils | 16:45 |
| dstanek | morganfainberg: ah | 16:45 |
| dolphm | morganfainberg: then maybe we shouldn't be deprecating it? pending deprecation? | 16:46 |
| morganfainberg | dstanek, @versionutils doesn't work on non-class (post instantiated) methods. | 16:46 |
| dolphm | morganfainberg: i feel the same about xml middleware | 16:46 |
| morganfainberg | dolphm, well for non-test cases it *should* be deprecated | 16:46 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/111620 | 16:46 |
| morganfainberg | i guess i can update everything to use token_provider_api.persistence | 16:47 |
| morganfainberg | thats a better idea | 16:47 |
| morganfainberg | i'll do that | 16:47 |
| openstackgerrit | A change was merged to openstack/keystone: Revoke by Audit Id / Audit Id Chain instead of expires https://review.openstack.org/114864 | 16:47 |
| morganfainberg | woot! | 16:48 |
| morganfainberg | ^ | 16:48 |
| stevemar | morganfainberg, noooo the rest of your stuff failed to merge :( | 16:49 |
| morganfainberg | stevemar, it was a failure because the venv didn't build | 16:49 |
| morganfainberg | just needs rechecks | 16:49 |
| stevemar | phew! | 16:50 |
| openstackgerrit | Kanagaraj Manickam proposed a change to openstack/keystone: Endpoint table is missing reference to region table https://review.openstack.org/113183 | 16:51 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/111620 | 16:54 |
| *** topol has joined #openstack-keystone | 17:00 | |
| *** rushiagr_away is now known as rushiagr | 17:00 | |
| *** amcrn has joined #openstack-keystone | 17:00 | |
| *** amirosh has joined #openstack-keystone | 17:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/111620 | 17:02 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Implement validation on Assignment V3 API https://review.openstack.org/86484 | 17:08 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Adds tests that show how update with validation work https://review.openstack.org/116954 | 17:08 |
| dstanek | lbragstad: this show the update problem that i was talking about a few weeks ago | 17:09 |
| *** aix has quit IRC | 17:10 | |
| *** aix has joined #openstack-keystone | 17:10 | |
| dstanek | lbragstad: ok, i also have two commits that i'm holding back until this stuff gets merged | 17:11 |
| dstanek | lbragstad: one moves the unit tests to a different directory and the other splits up the tests into a few smaller classes | 17:12 |
| lbragstad | dstanek: sweet, reviewing | 17:13 |
| dstanek | let me know if the update tests don't make sense | 17:14 |
| dstanek | the existing code/approach wouldn't let us update to null values | 17:14 |
| *** harlowja_away is now known as harlowja | 17:15 | |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/111620 | 17:15 |
| richm | question about the keystone.wsgi script - it is installed in /usr/share/keystone/keystone.wsgi on fedora/rhel | 17:16 |
| richm | where is it installed on debian/ubuntu? | 17:16 |
| *** marcoemorais has quit IRC | 17:16 | |
| *** praneshp has joined #openstack-keystone | 17:16 | |
| dstanek | this should be an easy one - https://review.openstack.org/#/c/111620/ | 17:17 |
| *** marcoemorais has joined #openstack-keystone | 17:17 | |
| *** marcoemorais has quit IRC | 17:17 | |
| *** marcoemorais has joined #openstack-keystone | 17:18 | |
| dstanek | richm: from the actual packagers? | 17:21 |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/111620 | 17:23 |
| dstanek | richm: on debian it looks like /usr/share/keystone/wsgi.py based on https://packages.debian.org/jessie/all/python-keystone/filelist | 17:23 |
| *** jimbaker has quit IRC | 17:24 | |
| *** jimbaker has joined #openstack-keystone | 17:24 | |
| *** jimbaker has quit IRC | 17:24 | |
| *** jimbaker has joined #openstack-keystone | 17:24 | |
| *** marcoemorais has quit IRC | 17:26 | |
| richm | dstanek: yes, the actual packages | 17:28 |
| *** amcrn has quit IRC | 17:28 | |
| *** RicoLin has quit IRC | 17:28 | |
| richm | dstanek: I'm working on the puppet-keystone modules so that puppet/packstack/foreman/etc. installs can automatically set up keystone to use wsgi | 17:28 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Make persistence manager in token_provider_api private https://review.openstack.org/116961 | 17:29 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Update tests to not use token_api https://review.openstack.org/116962 | 17:29 |
| dstanek | richm: i think that wsgi.py is what you are looking for, but i have not installed the package myself | 17:29 |
| *** marcoemorais has joined #openstack-keystone | 17:29 | |
| dstanek | richm: on unbuntu i didn't see it anywhere, but i may not have been Googling hard enough | 17:30 |
| richm | dstanek: ok - thanks | 17:30 |
| morganfainberg | stevemar, ^ those two should be easy to review compared ot the rest of the chain | 17:33 |
| dstanek | lbragstad: my review made a design decision where where to specify the nullablitiy of a parameter | 17:35 |
| dstanek | lbragstad: i removed it from the description property schema and moved it to the object schema where i think it belongs | 17:36 |
| dstanek | lbragstad: this is because description (or any other field) may not be nullable in all objects | 17:36 |
| lbragstad | dstanek: https://review.openstack.org/#/c/116954 makes sense | 17:39 |
| lbragstad | walking through the nullable method | 17:39 |
| *** henrynash has joined #openstack-keystone | 17:39 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Transform a Keystone token to a SAML assertion https://review.openstack.org/110542 | 17:43 |
| *** gokrokve has joined #openstack-keystone | 17:47 | |
| *** aix has quit IRC | 17:47 | |
| lbragstad | {'type': ['string', 'null']} and replace it with {‘type': [['string', 'null'], 'null']} | 17:48 |
| lbragstad | dstanek: so when using the nullable method, we take something that could be: | 17:48 |
| lbragstad | {'type': ['string', 'null']} and replace it with {‘type': [['string', 'null'], 'null']} | 17:48 |
| dstanek | lbragstad: no because ['string', 'null'] is already nullable | 17:50 |
| *** gokrokve_ has quit IRC | 17:50 | |
| lbragstad | dstanek: here at line 54, isn't that what we're doing? https://review.openstack.org/#/c/116954/1/keystone/tests/test_validation.py | 17:51 |
| dstanek | lbragstad: the reason to use the nullable method is to turn a type of 'string' into a type or ['string', 'null'] | 17:51 |
| *** gokrokve has quit IRC | 17:51 | |
| dstanek | lbragstad: which param are you refering to? | 17:52 |
| lbragstad | line 53, sorry | 17:52 |
| lbragstad | 'description': validation.nullable(parameter_types.description), | 17:52 |
| dstanek | lbragstad: line 39 here https://review.openstack.org/#/c/116954/1/keystone/common/validation/parameter_types.py | 17:52 |
| lbragstad | which passes https://github.com/openstack/keystone/blob/master/keystone/common/validation/parameter_types.py#L38-L40 to the nullable method | 17:52 |
| *** chandankumar has quit IRC | 17:53 | |
| dstanek | lbragstad: it's not anymore, see the link above | 17:54 |
| lbragstad | ah ha | 17:54 |
| lbragstad | yep, you're right | 17:54 |
| lbragstad | dstanek: so we can create the dictionaries to non-nullable and call validation.nullable iff we need to | 17:56 |
| dstanek | yes, similar to how SQL models work | 17:56 |
| lbragstad | dstanek: awesome, makes sense now | 17:57 |
| lbragstad | dstanek: I had one comment on spelling but I can fix that | 17:57 |
| lbragstad | dstanek: I think this looks good | 17:57 |
| dstanek | otherwise you'll have things like 'description' and 'description_nullable' | 17:57 |
| dstanek | lbragstad: if you push another version can you update my commit message? | 17:59 |
| lbragstad | dstanek: cool, so description can always be {'type': 'string'} | 17:59 |
| lbragstad | dstanek: yep, I can | 17:59 |
| dstanek | lbragstad: thx - yep always required to have a value until it's not | 18:00 |
| dstanek | lbragstad: this means that the nullable function would also be used in create schemas for optional parameters | 18:00 |
| *** arborism has joined #openstack-keystone | 18:03 | |
| *** nkinder has joined #openstack-keystone | 18:04 | |
| *** arborism is now known as amcrn | 18:07 | |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Adds tests that show how update with validation works https://review.openstack.org/116954 | 18:09 |
| lbragstad | dstanek: ^ fixed up the spelling and the commit message | 18:10 |
| dstanek | lbragstad: you'll have to rebase your other review on top of that now | 18:11 |
| *** jamielennox has joined #openstack-keystone | 18:11 | |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Implement validation on Assignment V3 API https://review.openstack.org/86484 | 18:11 |
| lbragstad | dstanek: done | 18:11 |
| dstanek | lbragstad: nice, thanks | 18:13 |
| lbragstad | dstanek: thank you | 18:13 |
| *** marcoemorais has quit IRC | 18:14 | |
| *** marcoemorais has joined #openstack-keystone | 18:14 | |
| *** marcoemorais has quit IRC | 18:15 | |
| *** zzzeek has joined #openstack-keystone | 18:15 | |
| *** marcoemorais has joined #openstack-keystone | 18:15 | |
| *** gokrokve has joined #openstack-keystone | 18:19 | |
| *** marcoemorais has quit IRC | 18:21 | |
| *** marcoemorais has joined #openstack-keystone | 18:21 | |
| *** PsionTheory has joined #openstack-keystone | 18:23 | |
| *** marcoemorais has quit IRC | 18:28 | |
| *** marcoemorais has joined #openstack-keystone | 18:28 | |
| openstackgerrit | A change was merged to openstack/identity-api: Clean up JSON home API https://review.openstack.org/116784 | 18:33 |
| *** bvandenh has joined #openstack-keystone | 18:45 | |
| *** rushiagr is now known as rushiagr_away | 18:45 | |
| *** jasondotstar has quit IRC | 18:56 | |
| afaranha | henrynash: Hi, as I'm reviewing https://review.openstack.org/#/c/115362/8/keystone/contrib/endpoint_policy/backends/sql.py in line 260 there's a comment about using "region" column instead of region_id, but as this patch depends on the patch that migrate the table to have the region_id column ( https://review.openstack.org/#/c/113183/11 ), I think this code should be implemented with the changes in the table, using "region_id" instead | 18:56 |
| henrynash | afaranha: yes, the code will be changed to use region_id | 18:57 |
| henrynash | afaranha: just waiting for the patch I’m dependant on to settle down | 18:57 |
| *** jsavak has joined #openstack-keystone | 18:59 | |
| afaranha | Ah, ok, I'll just finish reviewing and wait for the patch to put the review :) | 19:00 |
| henrynash | afaranha: ok, thx | 19:01 |
| morganfainberg | dolphm, +2 on the uuid default | 19:01 |
| morganfainberg | dolphm, btw | 19:01 |
| dolphm | morganfainberg: with three +2's, i put it on the starred list | 19:01 |
| dolphm | actually, the bug was already targeted to juno | 19:02 |
| dolphm | https://bugs.launchpad.net/keystone/+bug/1350000 | 19:02 |
| *** joesavak has quit IRC | 19:02 | |
| uvirtbot | Launchpad bug 1350000 in keystone "UUID is a more friendly default token provider than PKI" [Wishlist,In progress] | 19:02 |
| morganfainberg | yeah, it's just suffering from the big-red-x syndrom | 19:02 |
| dolphm | jamielennox: any idea when ayoung will be back to lift that? | 19:03 |
| jamielennox | dolphm: he's out this week | 19:03 |
| morganfainberg | dolphm, infra *might* be able to remove a score (super admin powers of gerrit) | 19:04 |
| dolphm | we could also just use a new change-id but :( | 19:04 |
| dolphm | i'd rather not circumvent the vote | 19:04 |
| morganfainberg | dolphm, honestly, based on comments and the IRC chatter it's going to be hard to sell it. | 19:04 |
| dolphm | unless there's like a hundreds upvotes on the patch | 19:04 |
| dolphm | morganfainberg: hard to sell uuid? | 19:05 |
| morganfainberg | dolphm, as the default | 19:05 |
| morganfainberg | to ayoung that is | 19:05 |
| *** harlowja has quit IRC | 19:06 | |
| dolphm | everyone needs to vote one way or the other | 19:06 |
| morganfainberg | i meant from the lifting the -2 | 19:06 |
| dolphm | morganfainberg: right | 19:07 |
| gyee | I thought arguing performance without some concrete numbers is a waste of time | 19:07 |
| dolphm | gyee: if you have performance numbers on PKI vs UUID that'd be super interesting | 19:07 |
| *** harlowja has joined #openstack-keystone | 19:08 | |
| gyee | dolphm, unfortunately, I don't | 19:08 |
| gyee | what I meant was the only way to win a performance argument is with real numbers | 19:08 |
| jamielennox | oh, in about 2 weeks i'm dissapearing for 4 weeks - i realize we are busy now but i need to get people to do some client reviewing | 19:09 |
| lbragstad | dstanek: we can abandon this guy, right? https://review.openstack.org/#/c/110338/1 | 19:09 |
| jamielennox | possibly even do some little fixes to those patches to get them in whilst i'm away | 19:09 |
| lbragstad | I think that was built into the assignment api validation patch | 19:09 |
| dolphm | jamielennox: that's a rough time to step away from the client! :( i'm always happy to pitch in making small fixes, but i'll likely be mostly focused on RC1 in that time period | 19:10 |
| morganfainberg | towards the end of september there will be a week i'll be around but busy up in the bay area so less present | 19:10 |
| dstanek | lbragstad: not sure | 19:10 |
| dolphm | morganfainberg: alrighty | 19:10 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/identity-api: API for auth-specific-data routes https://review.openstack.org/115423 | 19:10 |
| dolphm | i'll be out for a week at some point in the next couple months because bandwagon | 19:10 |
| dstanek | lbragstad: i have one more thing to add to my patch. have you started to work on the assignment one again? | 19:10 |
| dolphm | bknudson bots don't need vacation, right? | 19:11 |
| morganfainberg | dolphm, we figured any kind of work stuff that requires face to face is best done late RC when things *should* be a bit more calm | 19:11 |
| jamielennox | yea, realize that, it's going to make me really busy just prior to summit - but life stuff | 19:11 |
| dolphm | jamielennox: ++ | 19:11 |
| lbragstad | dstanek: you need to add something to https://review.openstack.org/#/c/116954/2 ? | 19:11 |
| lbragstad | dstanek: I wasn't working on the assignment patch at the moment, I was going through some stale validation reviews | 19:11 |
| dstanek | lbragstad: that's the one, ok i'll push then | 19:12 |
| lbragstad | dstanek: ok | 19:12 |
| dolphm | henrynash: stevemar: lbragstad: jamielennox: i'd appreciate any sort of vote on https://review.openstack.org/#/c/110488/ | 19:12 |
| dstanek | lbragstad: i've started commenting on how to fix some of the other validation reviews | 19:12 |
| lbragstad | dstanek: ok, on the api/validation branch | 19:13 |
| jamielennox | gyee: want to have a look at https://review.openstack.org/#/c/113742/7 for me | 19:17 |
| gyee | jamielennox, looking | 19:18 |
| bknudson | uvirtbot takes plenty of vacations | 19:18 |
| uvirtbot | bknudson: Error: "takes" is not a valid command. | 19:18 |
| morganfainberg | uvirtbot, vacation | 19:19 |
| uvirtbot | morganfainberg: Error: "vacation" is not a valid command. | 19:19 |
| dolphm | lol | 19:19 |
| morganfainberg | uvirtbot help | 19:19 |
| uvirtbot | morganfainberg: (help [<plugin>] [<command>]) -- This command gives a useful description of what <command> does. <plugin> is only necessary if the command is in more than one plugin. | 19:19 |
| dolphm | uvirtbot: take-vacation | 19:19 |
| uvirtbot | dolphm: Error: "take-vacation" is not a valid command. | 19:19 |
| bknudson | needs the vacation plugin | 19:19 |
| lbragstad | have we ever crashed uvirtbot ? | 19:20 |
| morganfainberg | lbragstad, don't think so | 19:20 |
| dstanek | lbragstad: what were you basing the schemas off of? many of them don't match the SQL models | 19:21 |
| morganfainberg | uvirtbot list | 19:21 |
| uvirtbot | morganfainberg: Admin, Anonymous, Bugtracker, Channel, Config, Misc, Owner, and User | 19:21 |
| *** amcrn has quit IRC | 19:21 | |
| dolphm | uvirtbot: ping | 19:21 |
| uvirtbot | pong | 19:21 |
| dolphm | win | 19:21 |
| lbragstad | dstanek: I was basing it off the API spec | 19:21 |
| dolphm | UVIRTBOT #hasapurpose | 19:21 |
| uvirtbot | dolphm: Error: "#hasapurpose" is not a valid command. | 19:21 |
| *** ChanServ sets mode: +o morganfainberg | 19:21 | |
| * lbragstad thinks keystone accepts the challenge of crashing uvirtbot | 19:22 | |
| morganfainberg | LOL | 19:22 |
| morganfainberg | nice dolph | 19:22 |
| morganfainberg | nice | 19:22 |
| lbragstad | dstanek: some of the controllers or resource Manager did things like: | 19:23 |
| *** ChanServ sets mode: +v uvirtbot | 19:23 | |
| lbragstad | https://github.com/openstack/keystone/blob/master/keystone/catalog/controllers.py#L215 | 19:23 |
| bknudson | looks like uvirtbot just got more powerful | 19:24 |
| *** arborism has joined #openstack-keystone | 19:24 | |
| dolphm | morganfainberg: okay i'm pretty sure i can crash uvirtbot, get -infra ready | 19:24 |
| morganfainberg | dolphm, it isn't run by -infra | 19:24 |
| morganfainberg | dolphm, i think it's run by some one specific | 19:24 |
| dolphm | dammit it already has a catch for that | 19:25 |
| lbragstad | dstanek: for example, the sql table doesn't require `type` | 19:25 |
| lbragstad | https://github.com/openstack/keystone/blob/master/keystone/common/sql/migrate_repo/versions/035_havana.py#L129 | 19:25 |
| morganfainberg | dolphm, oh you were going to have it tell itself to tell something | 19:25 |
| stevemar | ultron, it that you? uvirtbot | 19:25 |
| jamielennox | gyee: this one would be useful as well: https://review.openstack.org/#/c/113415/ | 19:26 |
| dolphm | uvirtbot who am i | 19:26 |
| jamielennox | gyee: i pick on you because it works | 19:26 |
| uvirtbot | dolphm: Error: "who" is not a valid command. | 19:26 |
| dolphm | uvirtbot: whoami | 19:26 |
| uvirtbot | dolphm: I don't recognize you. | 19:26 |
| morganfainberg | uvirtbot whoareyou | 19:27 |
| uvirtbot | morganfainberg: Error: "whoareyou" is not a valid command. | 19:27 |
| *** jasondotstar has joined #openstack-keystone | 19:28 | |
| gyee | jamielennox, heh, you'd think this is my fulltime job | 19:29 |
| lbragstad | dstanek: I would say the schema are based on a mix of what the identity-api spec says, what's _required_ in the controllers, and what's enforced by the backends. | 19:29 |
| lbragstad | s/schema/schemas/ | 19:29 |
| *** amirosh has quit IRC | 19:29 | |
| dstanek | lbragstad: this is gonna be fun! | 19:29 |
| lbragstad | dstanek: :) | 19:29 |
| dolphm | morganfainberg: is it just me, or are there check jobs that aren't being picked up by build nodes? | 19:37 |
| morganfainberg | dolphm, new check jobs or ones queueed? | 19:37 |
| dolphm | morganfainberg: old jobs | 19:37 |
| dolphm | morganfainberg: look at the oldest check jobs on http://status.openstack.org/zuul/ | 19:37 |
| morganfainberg | dolphm, something is wonky, but there was some AZ shifting for build nodes | 19:37 |
| morganfainberg | wondering if stuff is wedged because it was targeted to something that wont ever build now | 19:38 |
| *** dims has quit IRC | 19:38 | |
| *** dims has joined #openstack-keystone | 19:39 | |
| *** gyee has quit IRC | 19:40 | |
| lbragstad | dstanek: I think https://review.openstack.org/#/c/116954/2/ will fail pep8 because assignment_schema is imported but never used https://review.openstack.org/#/c/116954/2/keystone/tests/test_validation.py | 19:40 |
| henrynash | dolphm: +2’d the UUID default | 19:46 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Implementation of Endpoint Grouping https://review.openstack.org/111949 | 19:53 |
| dolphm | topol: have you used partials before? | 19:54 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Implementation of Endpoint Grouping https://review.openstack.org/111949 | 19:57 |
| stevemar | dolphm, add this to your starred list please https://review.openstack.org/#/c/111949/ | 19:58 |
| dolphm | stevemar: why is it not on my starred list already? | 19:58 |
| stevemar | i believe there was a mix up, it's the endpoint grouping code | 19:59 |
| * stevemar shrugs | 19:59 | |
| *** marcoemorais has quit IRC | 19:59 | |
| stevemar | i updated the commit msg to point to the bp correctly | 19:59 |
| dolphm | stevemar: is it stable? | 19:59 |
| *** marcoemorais has joined #openstack-keystone | 19:59 | |
| dolphm | stevemar: oh it was an orphan | 19:59 |
| stevemar | yes, all lonely | 20:00 |
| *** marcoemorais has quit IRC | 20:00 | |
| dolphm | stevemar: have you reviewed it? | 20:00 |
| stevemar | dolphm, nope | 20:00 |
| stevemar | dolphm, i only know about it because i was going to move it to Kilo https://review.openstack.org/#/c/116633/ | 20:01 |
| *** marcoemorais has joined #openstack-keystone | 20:01 | |
| dolphm | stevemar: that introduces a new API as well, right? | 20:01 |
| stevemar | dolphm, the spec was approved, the code was up before FPF, it just fell through the cracks | 20:01 |
| stevemar | yes | 20:01 |
| dolphm | stevemar: API review link? | 20:02 |
| topol | dolphm, no | 20:02 |
| topol | dolphm, why | 20:02 |
| stevemar | dolphm, i doubt there is one | 20:02 |
| *** joesavak has joined #openstack-keystone | 20:03 | |
| dolphm | topol: stevemar suggested you use partials in your review, like http://pasteraw.com/dldbc3prwjqolq42wmq23hwp1ubiokn | 20:03 |
| *** marcoemorais has quit IRC | 20:03 | |
| stevemar | dolphm, yes apparently it's merged https://review.openstack.org/#/c/106292/12/v3/src/markdown/identity-api-v3-os-ep-filter-ext.md | 20:03 |
| *** marcoemorais has joined #openstack-keystone | 20:04 | |
| topol | Hi dolphm, so i tried them and they somehow upset mock | 20:04 |
| dolphm | oh. but not completely reviewed by keystone | 20:04 |
| topol | dolphm got a one less argument error | 20:04 |
| stevemar | i had a few goes at it | 20:04 |
| *** shakamunyi has joined #openstack-keystone | 20:04 | |
| stevemar | dolphm, topol i don't think partials are necessary for that | 20:04 |
| stevemar | we can fix it up later | 20:05 |
| dolphm | stevemar: agree, but it is a good suggestion | 20:05 |
| topol | dolphm +++ | 20:05 |
| dolphm | stevemar: the review itself would be easier with partials | 20:05 |
| dolphm | if they work | 20:05 |
| dolphm | with tests | 20:05 |
| *** jsavak has quit IRC | 20:05 | |
| stevemar | might be some funkiness with tests | 20:05 |
| stevemar | anywho | 20:05 |
| topol | stevemar were you able to make partials work??? | 20:06 |
| stevemar | endpoint groups does had identity API too | 20:06 |
| stevemar | nope | 20:06 |
| dolphm | topol: i think something must be funky with your implementation | 20:06 |
| dolphm | stevemar: does had? | 20:06 |
| topol | dolphm, how so? | 20:07 |
| dolphm | topol: because tests are passing with my implementation... which test is failing for you? | 20:07 |
| stevemar | does have* | 20:07 |
| dolphm | topol: http://pasteraw.com/kbk47is679341h313tc0f5pqlbkvrvo | 20:08 |
| *** dims_ has joined #openstack-keystone | 20:09 | |
| topol | dolphm, so let me retry what you know will work :-) | 20:09 |
| topol | dolphm, so did you already push a new patch up that I can just pulldown | 20:10 |
| dolphm | topol: i did not, but i'd be happy to | 20:11 |
| topol | dolphm sure. Im not proud | 20:11 |
| *** shakamunyi has quit IRC | 20:11 | |
| openstackgerrit | Dolph Mathews proposed a change to openstack/keystone: Add audit support to keystone federation https://review.openstack.org/114337 | 20:11 |
| dolphm | topol: ^^ | 20:12 |
| topol | dolphm, that was very kind of you | 20:12 |
| topol | dolphm, I didnt get you anything | 20:12 |
| *** dims has quit IRC | 20:12 | |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Adds tests that show how update with validation works https://review.openstack.org/116954 | 20:12 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Implement validation on Assignment V3 API https://review.openstack.org/86484 | 20:12 |
| dolphm | topol: you can get me the same changes in the top portion of the file :) https://review.openstack.org/#/c/114337/8/keystone/auth/plugins/mapped.py | 20:13 |
| dolphm | topol: _handle_scoped_token() | 20:13 |
| dolphm | topol: you can also share with me the logic of the PENDING notifications - doesn't seem useful on fast operations like auth? | 20:14 |
| *** dims_ has quit IRC | 20:14 | |
| topol | dolphm, I can do _handle_scoped_token() | 20:15 |
| dolphm | topol: and now that i look at them both, it looks like you should be able to share the same partial in both methods? | 20:17 |
| *** dims has joined #openstack-keystone | 20:17 | |
| dstanek | lbragstad: i was going to start fixing some of the reviews. are you working on any of them at the moment? | 20:18 |
| lbragstad | dstanek: yes, | 20:19 |
| lbragstad | I have the policy and credential api validation patches ready to review once 116954 goes in | 20:19 |
| lbragstad | dstanek: working on addressing your comments in the catalog validation review | 20:19 |
| lbragstad | dstanek: the funny thing about services is that the identity-api documentation lists a bunch of optional parameters you can specify, but they just get tossed into the extra column anyway | 20:20 |
| lbragstad | dstanek: so, if you pass 'name' and 'description' on a service update or create request, it goes into the extra column | 20:21 |
| topol | dolphm, yours worked. You were right and I was wrong. But I was betting on you :-) | 20:21 |
| *** dims has quit IRC | 20:22 | |
| dolphm | topol: was your partial buidling missing something i assume? | 20:22 |
| dolphm | topol: also left you another -1 :) | 20:23 |
| topol | dolphm, I guess. It was late at night and decided to defer that and come back to it | 20:23 |
| topol | dolphm, a -1 on my code. not a shock :-) | 20:23 |
| dolphm | topol: thankfully it's coffee time now though right?! | 20:24 |
| *** bvandenh has quit IRC | 20:24 | |
| topol | dolphm, I refuse to enjoy coffee until I get a new patch out that makes us all feel better | 20:24 |
| stevemar | dstanek, matt R looked at the docs for notifications :) help me close out a BP https://review.openstack.org/#/c/114813/ | 20:25 |
| dstanek | lbragstad: that's unfortunate | 20:25 |
| dolphm | stevemar: would you have time to review that API patch before we target the endpoint policy grouping thing to juno-3? | 20:26 |
| dolphm | endpoint obfuscation* grouping thing | 20:26 |
| dstanek | stevemar: +2ed it - any reason not to +A too? | 20:27 |
| stevemar | dolphm, the API has been merged, way back when | 20:27 |
| stevemar | dstanek, don't think so | 20:27 |
| dstanek | stevemar: then done | 20:27 |
| dolphm | stevemar: right, but it didn't get two +2's from keystone core | 20:27 |
| stevemar | right | 20:27 |
| stevemar | re-review it even in it's merged state? | 20:27 |
| dolphm | stevemar: yes | 20:28 |
| stevemar | dolphm, fine, but you gotta review these, they actually benefit you a bit: https://review.openstack.org/#/c/116639/ and https://review.openstack.org/#/c/116641/ | 20:28 |
| dstanek | lbragstad: can you base your work on that review so that we can start reviewing those too or would be rather wait? | 20:28 |
| dolphm | stevemar: lol | 20:28 |
| dolphm | stevemar: happy to | 20:29 |
| *** arborism has quit IRC | 20:29 | |
| dolphm | stevemar: what about an abandoned spec dir? | 20:29 |
| dolphm | of some kind? | 20:29 |
| lbragstad | dstanek: sure, just wrapping up the catalog patch | 20:29 |
| stevemar | i was thinking that... | 20:29 |
| dolphm | nova wants to just leave unworked specs in juno/ but that seems messy | 20:29 |
| stevemar | agreed | 20:29 |
| dolphm | moving them to kilo/ feels like we're championing them | 20:29 |
| stevemar | definitely not juno | 20:29 |
| stevemar | it does | 20:29 |
| stevemar | untargeted? | 20:30 |
| dolphm | stevemar: that's not very clear | 20:30 |
| dolphm | stevemar: but *we* would know what that means | 20:30 |
| ekarlso | does keystone use multiple workers ? | 20:30 |
| stevemar | dolphm, i'm lazy so i vote kilo | 20:30 |
| stevemar | if they still don't merge, then lima | 20:31 |
| dolphm | consigned/ lol | 20:31 |
| dolphm | stevemar: they'll just be carried forward forever that way | 20:31 |
| dolphm | stevemar: not maintainable | 20:31 |
| stevemar | just shows how much technical debt we have | 20:31 |
| dolphm | gaveup/ | 20:31 |
| stevemar | alright, technical debt | 20:31 |
| stevemar | new category | 20:31 |
| dolphm | but some are feature requests | 20:31 |
| dolphm | most? | 20:32 |
| dolphm | walkouts/ | 20:32 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/identity-api: Update region entries to include URLs https://review.openstack.org/114118 | 20:33 |
| dolphm | forfeited/ | 20:34 |
| dolphm | that might be my favorite | 20:34 |
| dolphm | morganfainberg: thoughts? ^ | 20:34 |
| dstanek | dolphm: haha, i like forfeited | 20:35 |
| lbragstad | dstanek: about the region id comment here, | 20:35 |
| lbragstad | https://review.openstack.org/#/c/96266/29/keystone/catalog/schema.py | 20:35 |
| lbragstad | you talking about the string_id type that we were trying here, https://review.openstack.org/#/c/108862/ right? | 20:35 |
| *** amcrn has joined #openstack-keystone | 20:38 | |
| dolphm | stevemar: i'll bring it up in the cross project meeting | 20:39 |
| dolphm | stevemar: i don't think i'm a fan of just pushing them forward though, unless you're going to work on it yourself | 20:39 |
| stevemar | we moved open id connect forward | 20:39 |
| stevemar | cause well, i plan to work on it | 20:40 |
| *** gyee has joined #openstack-keystone | 20:40 | |
| topol | dolphm, is there a way for me to do the partial stuff without doing copy paste of the following line in both scop and unscoped methods? | 20:40 |
| topol | send_notification = functools.partial( | 20:40 |
| topol | notifications.send_saml_audit_notification, 'authenticate', | 20:40 |
| topol | context, user_id, group_ids, identity_provider, protocol) | 20:40 |
| dolphm | topol: put it in a wider scope, even module level if that's appropriate | 20:40 |
| dolphm | topol: err, i take that back! no | 20:41 |
| topol | dolphm, even if the values havent been bound yet its safe? | 20:41 |
| dolphm | topol: ++ the values don't exist | 20:41 |
| dolphm | topol: need to define it in each method | 20:41 |
| dolphm | topol: my mistake | 20:41 |
| topol | dolphm, K, cool. even a broken clock is right twice a day. That was my turn :-0 | 20:41 |
| dolphm | topol: lol. | 20:42 |
| dstanek | lbragstad: yes, unless you think we won't have that in | 20:42 |
| lbragstad | dstanek: that has the lazy load stuff that needs to be worked in yet I think? | 20:42 |
| dstanek | lbragstad: or something... | 20:43 |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: Allow providing a default value to CLI loading https://review.openstack.org/113742 | 20:44 |
| dstanek | we could also punt on that until we know how we want it to work and leave the hex_uuid | 20:44 |
| topol | dolphm, I now realized how I butchered functools when I tried it but Im too embarrased to say what I did | 20:47 |
| topol | dolphm, morganfainberg would disown me as a father | 20:47 |
| dolphm | topol: lol | 20:48 |
| dolphm | topol: at least you learned something! | 20:48 |
| *** morganfainberg is now known as morganfainberg_Z | 20:49 | |
| topol | dolphm, I certainly did. Thanks for keeping me honest | 20:50 |
| dstanek | topol++ | 20:50 |
| *** henrynash has quit IRC | 20:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/116255 | 20:54 |
| stevemar | dolphm, want me to upload a new patch for identity api (endpoint grouping)? | 20:55 |
| bknudson | we should all learn to love function pointers and hate OO. | 20:56 |
| stevemar | there will be lots of changes, minor stuff | 20:56 |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Adds tests that show how update with validation works https://review.openstack.org/116954 | 20:58 |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Implement validation on Policy V3 API https://review.openstack.org/104065 | 20:58 |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Implement validation on Policy V3 API https://review.openstack.org/104065 | 21:02 |
| *** marcoemorais has quit IRC | 21:02 | |
| lbragstad | dstanek: ^ Policy rebased on top of your changes | 21:02 |
| *** marcoemorais has joined #openstack-keystone | 21:03 | |
| *** marcoemorais has quit IRC | 21:04 | |
| *** marcoemorais has joined #openstack-keystone | 21:04 | |
| topol | dolphm ever seen the move apocalypse now | 21:04 |
| topol | movie? | 21:04 |
| *** dims has joined #openstack-keystone | 21:10 | |
| dolphm | topol: it's been like a decade, but yes | 21:15 |
| *** cjellick_ has joined #openstack-keystone | 21:15 | |
| *** cjellick has quit IRC | 21:16 | |
| topol | dolphm, I just use the following movie quote: "don't get off the boat" with stevemar but he could not appreciate the reference | 21:16 |
| *** cjellick_ has quit IRC | 21:19 | |
| *** shakamunyi has joined #openstack-keystone | 21:19 | |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Implement validation on Credential V3 https://review.openstack.org/98522 | 21:28 |
| lbragstad | dstanek: ^ credential API rebased on your change | 21:28 |
| *** morganfainberg_Z is now known as morganfainberg | 21:33 | |
| morganfainberg | dolphm, was at lunch back now, reading up | 21:33 |
| dolphm | lbragstad: on which change? | 21:34 |
| dolphm | lbragstad: oh nvm | 21:34 |
| morganfainberg | dolphm, ok thoughts on which change? | 21:34 |
| dolphm | morganfainberg: these https://review.openstack.org/#/c/116639/1 | 21:35 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/identity-api: Clean up endpoint grouping API https://review.openstack.org/117028 | 21:35 |
| dolphm | morganfainberg: i think we should move them into some other dir, like abandoned/ or forfeited/ | 21:35 |
| morganfainberg | yeah moving to kilo is wrong unless we're blessing them at this point for inclusion in kilo | 21:35 |
| morganfainberg | i'm not opposed to doing that | 21:35 |
| stevemar | dolphm, https://review.openstack.org/#/c/117028/ | 21:35 |
| morganfainberg | just if it is moved to kilo it's a "yes this is being planned for that release" | 21:36 |
| dolphm | morganfainberg: i'm just opposed to moving them to kilo/ if we don't have someone committing to work it | 21:36 |
| morganfainberg | dolphm, ++ | 21:36 |
| dolphm | but i don't want them in juno/ either (which i think is nova's approach) | 21:36 |
| stevemar | dolphm, gimmie a name and i'll make it happen | 21:36 |
| morganfainberg | shardy said he'd try for kilo. | 21:36 |
| dolphm | stevemar: holy crap | 21:36 |
| morganfainberg | but i'd wait till we're closer | 21:36 |
| dolphm | stevemar: reference the BP | 21:36 |
| stevemar | dolphm, you said to go through it | 21:36 |
| dolphm | stevemar: my battery is at 2% - i'll follow up later | 21:37 |
| morganfainberg | dolphm, PLUGIN! | 21:37 |
| stevemar | some of it is cleaning up endpoint filters use of silly --param-name-- and real values | 21:37 |
| *** gordc has left #openstack-keystone | 21:37 | |
| stevemar | yeah i had like 12 comments | 21:38 |
| stevemar | but it was merged :( | 21:38 |
| dstanek | dolphm: is the plan for https://review.openstack.org/#/c/113183 to expose region and region_id to the client? | 21:38 |
| dolphm | dstanek: yes, region for backwards compat, and region_id for forward consistency across the API | 21:39 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/identity-api: Clean up endpoint grouping API https://review.openstack.org/117028 | 21:39 |
| morganfainberg | LOL look at the gate queue | 21:39 |
| dolphm | dstanek: which matches spec | 21:39 |
| dolphm | morganfainberg: OUR DAY HAS COME | 21:40 |
| * dolphm battery dies | 21:40 | |
| dstanek | dolphm: one spec mentioned region and the other mentioned region_id ... they have me very confused | 21:40 |
| morganfainberg | dolphm, plugin.... | 21:40 |
| morganfainberg | plug in! | 21:40 |
| openstackgerrit | Lance Bragstad proposed a change to openstack/keystone: Implement validation on the Catalog V3 API https://review.openstack.org/96266 | 21:41 |
| *** harlowja is now known as harlowja_away | 21:43 | |
| topol | dolphm, stevemar, I made all the required updates except adding the new Credential. I have to take my son to soccer practice but will push a complete patch later tonite | 21:45 |
| stevemar | inexcusable! | 21:46 |
| stevemar | have fun :) | 21:46 |
| morganfainberg | topol, really family before code? :P | 21:46 |
| topol | dolphm, stevemar called me out in front of my boss :-). He's brutal | 21:46 |
| morganfainberg | topol, have a good one man. | 21:46 |
| topol | Thanks son | 21:46 |
| stevemar | morganfainberg, if shardy says he'll pick it up in Kilo, then we should just move it to kilo | 21:47 |
| morganfainberg | he said in the review he'll try | 21:47 |
| stevemar | i can't see jamielennox or ayoung not picking up explicit unscoped in kilo either | 21:47 |
| jamielennox | what's up? i haven't been watching | 21:47 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/keystone: Create SAML generation route and controller https://review.openstack.org/114138 | 21:49 |
| *** henrynash has joined #openstack-keystone | 21:50 | |
| openstackgerrit | A change was merged to openstack/keystone: Create additional docs for role assignment events https://review.openstack.org/114813 | 21:50 |
| openstackgerrit | A change was merged to openstack/keystone: Change V3 router classes to provide JSON Home data https://review.openstack.org/111576 | 21:50 |
| openstackgerrit | A change was merged to openstack/keystone: Change the sub-routers to provide JSON Home data https://review.openstack.org/111577 | 21:54 |
| *** dims has quit IRC | 21:55 | |
| *** dims has joined #openstack-keystone | 21:56 | |
| *** praneshp has quit IRC | 21:56 | |
| *** praneshp has joined #openstack-keystone | 21:57 | |
| *** praneshp has joined #openstack-keystone | 21:57 | |
| *** topol has quit IRC | 21:59 | |
| *** harlowja_away is now known as harlowja | 22:00 | |
| *** dims has quit IRC | 22:00 | |
| jamielennox | are we looking at having the default token format changed for Juno or is this a Kilo thing? | 22:04 |
| *** jorge_munoz has quit IRC | 22:10 | |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: Transform a Keystone token to a SAML assertion https://review.openstack.org/110542 | 22:12 |
| *** bknudson has quit IRC | 22:13 | |
| *** PsionTheory has quit IRC | 22:16 | |
| openstackgerrit | henry-nash proposed a change to openstack/keystone: backend for policy endpoint extension https://review.openstack.org/115362 | 22:21 |
| *** vhoward- has joined #openstack-keystone | 22:22 | |
| *** vhoward has quit IRC | 22:22 | |
| *** rharwood_ has joined #openstack-keystone | 22:31 | |
| *** uvirtbot` has joined #openstack-keystone | 22:31 | |
| *** stevemar has quit IRC | 22:32 | |
| *** gokrokve_ has joined #openstack-keystone | 22:33 | |
| *** afaranha1 has joined #openstack-keystone | 22:35 | |
| *** montanvi has joined #openstack-keystone | 22:35 | |
| *** marcoemorais has quit IRC | 22:36 | |
| *** marcoemorais has joined #openstack-keystone | 22:36 | |
| *** david-ly_ has joined #openstack-keystone | 22:36 | |
| *** praneshp_ has joined #openstack-keystone | 22:37 | |
| *** wwriverrat1 has joined #openstack-keystone | 22:37 | |
| *** rharwood has quit IRC | 22:37 | |
| *** bambam1 has quit IRC | 22:37 | |
| *** uvirtbot has quit IRC | 22:37 | |
| *** hockeynut has quit IRC | 22:37 | |
| *** rharwood_ is now known as rharwood | 22:37 | |
| *** david-lyle has quit IRC | 22:38 | |
| *** praneshp has quit IRC | 22:39 | |
| *** praneshp_ is now known as praneshp | 22:39 | |
| *** _nonameentername has joined #openstack-keystone | 22:40 | |
| *** radez_g0` has joined #openstack-keystone | 22:40 | |
| *** wwriverrat1 has quit IRC | 22:42 | |
| *** wwriverrat1 has joined #openstack-keystone | 22:42 | |
| *** joesavak has quit IRC | 22:43 | |
| *** gokrokve has quit IRC | 22:43 | |
| *** openstackgerrit has quit IRC | 22:43 | |
| *** afaranha has quit IRC | 22:43 | |
| *** nonameentername has quit IRC | 22:43 | |
| *** radez_g0n3 has quit IRC | 22:43 | |
| *** lsmola has quit IRC | 22:43 | |
| *** chmouel_ has quit IRC | 22:43 | |
| *** chmouel has joined #openstack-keystone | 22:43 | |
| *** lsmola has joined #openstack-keystone | 22:45 | |
| *** samuelmz has quit IRC | 22:45 | |
| *** samuelmz has joined #openstack-keystone | 22:45 | |
| *** wwriverrat1 has left #openstack-keystone | 22:46 | |
| *** HenryG has quit IRC | 22:46 | |
| *** jaosorior has quit IRC | 22:52 | |
| *** montanvi has quit IRC | 22:55 | |
| *** montanvi has joined #openstack-keystone | 22:55 | |
| *** praneshp has quit IRC | 22:55 | |
| *** praneshp has joined #openstack-keystone | 22:55 | |
| *** radez_g0` has quit IRC | 22:55 | |
| *** radez_g0` has joined #openstack-keystone | 22:55 | |
| *** lsmola has quit IRC | 22:56 | |
| *** lsmola has joined #openstack-keystone | 22:56 | |
| *** amerine_ has joined #openstack-keystone | 22:59 | |
| *** amerine has quit IRC | 23:01 | |
| *** Kui has joined #openstack-keystone | 23:03 | |
| *** david-ly_ is now known as david-lyle | 23:04 | |
| *** montanvi is now known as bambam1 | 23:16 | |
| *** Kui has quit IRC | 23:19 | |
| *** henrynash has quit IRC | 23:34 | |
| *** bknudson has joined #openstack-keystone | 23:37 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!