| openstackgerrit | A change was merged to openstack/keystone: Don't need session.flush in context managed by session https://review.openstack.org/78143 | 00:03 |
|---|---|---|
| openstackgerrit | A change was merged to openstack/keystone: Removes a redundant test https://review.openstack.org/77069 | 00:07 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Configurable temporary directory for tests https://review.openstack.org/79217 | 00:18 |
| *** leseb has joined #openstack-keystone | 00:20 | |
| *** leseb has quit IRC | 00:24 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Cleanup test setup/config https://review.openstack.org/79219 | 00:40 |
| jamielennox | dolphm: i really doubt your here, but regarding endpoint_type vs interface, yes the correct name is interface but i went with endpoint_type because it is used for this all throughout accessinfo and the service catalog | 00:53 |
| jamielennox | as far as i can see the only reference to 'interface' is within the endpoint parsing of the service catalog itself | 00:54 |
| jamielennox | is this something we are attempting to change people on/ | 00:54 |
| openstackgerrit | A change was merged to openstack/keystone: Fix webob.exc.HTTPForbidden parameter miss https://review.openstack.org/75741 | 01:06 |
| *** zhiyan_ is now known as zhiyan | 01:24 | |
| *** stevemar has joined #openstack-keystone | 01:46 | |
| *** daneyon has quit IRC | 01:50 | |
| *** daneyon has joined #openstack-keystone | 01:50 | |
| *** daneyon has quit IRC | 01:55 | |
| *** daneyon has joined #openstack-keystone | 01:56 | |
| *** daneyon_ has joined #openstack-keystone | 01:57 | |
| *** daneyon has quit IRC | 01:57 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove unnecessary config_files implementation https://review.openstack.org/79225 | 02:03 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove unnecessary calls to self.config() https://review.openstack.org/79226 | 02:03 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove duplication when picking test config files https://review.openstack.org/79219 | 02:03 |
| *** mberlin1 has joined #openstack-keystone | 02:08 | |
| *** daneyon_ has quit IRC | 02:08 | |
| *** mberlin has quit IRC | 02:10 | |
| *** stevemar has quit IRC | 02:18 | |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: Provide more data to AuthMethod plugins https://review.openstack.org/78523 | 02:26 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Overrides filter builtin using six https://review.openstack.org/70816 | 02:32 |
| *** david-lyle has joined #openstack-keystone | 03:10 | |
| *** bknudson has quit IRC | 03:14 | |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: increase default revocation_cache_time https://review.openstack.org/78700 | 03:24 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Use assertIsNone when comparing against None https://review.openstack.org/78118 | 04:02 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Adds style checks to ease reviewer burden https://review.openstack.org/78119 | 04:02 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Add a space after the hash for block comments https://review.openstack.org/78116 | 04:02 |
| openstackgerrit | David Stanek proposed a change to openstack/keystone: Removes the use of mutables as default args https://review.openstack.org/78117 | 04:02 |
| *** stevemar has joined #openstack-keystone | 04:12 | |
| *** chandan_kumar has joined #openstack-keystone | 04:43 | |
| *** chandan_kumar has quit IRC | 04:52 | |
| *** saju_m has joined #openstack-keystone | 04:59 | |
| *** chandan_kumar has joined #openstack-keystone | 05:01 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Authenticate via oauth https://review.openstack.org/77977 | 05:17 |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Add request/access token and consumer support for keystoneclient https://review.openstack.org/60820 | 05:17 |
| *** stevemar has quit IRC | 05:21 | |
| *** gokrokve has quit IRC | 05:24 | |
| *** gokrokve_ has joined #openstack-keystone | 05:26 | |
| *** gokrokve_ has quit IRC | 05:31 | |
| *** gokrokve has joined #openstack-keystone | 05:38 | |
| *** saju_m has quit IRC | 05:54 | |
| openstackgerrit | Jenkins proposed a change to openstack/keystone: Imported Translations from Transifex https://review.openstack.org/78525 | 06:00 |
| *** saju_m has joined #openstack-keystone | 06:02 | |
| *** corsir has quit IRC | 06:08 | |
| *** jaosorior has joined #openstack-keystone | 06:36 | |
| *** gokrokve has quit IRC | 07:05 | |
| *** gokrokve has joined #openstack-keystone | 07:06 | |
| *** gokrokve has quit IRC | 07:09 | |
| *** gokrokve has joined #openstack-keystone | 07:39 | |
| *** gokrokve has quit IRC | 07:44 | |
| openstackgerrit | Marcos FermÃn Lobo proposed a change to openstack/keystone: LDAP global roles and group roles assignments https://review.openstack.org/76568 | 08:13 |
| *** saju_m has quit IRC | 08:22 | |
| *** saju_m has joined #openstack-keystone | 08:28 | |
| *** gokrokve has joined #openstack-keystone | 08:39 | |
| *** leseb has joined #openstack-keystone | 08:41 | |
| *** gokrokve has quit IRC | 08:44 | |
| *** saju_m has quit IRC | 08:50 | |
| *** saju_m has joined #openstack-keystone | 09:04 | |
| *** saju_m has quit IRC | 09:10 | |
| *** saju_m has joined #openstack-keystone | 09:11 | |
| openstackgerrit | mouad benchchaoui proposed a change to openstack/python-keystoneclient: Fix retry logic https://review.openstack.org/77907 | 09:22 |
| *** henrynash has joined #openstack-keystone | 09:25 | |
| *** henrynash has quit IRC | 09:36 | |
| *** gokrokve has joined #openstack-keystone | 09:39 | |
| *** gokrokve has quit IRC | 09:44 | |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: Validate groups presence for federated authn https://review.openstack.org/79284 | 09:49 |
| *** andreaf has joined #openstack-keystone | 09:56 | |
| *** henrynash has joined #openstack-keystone | 10:14 | |
| *** gokrokve has joined #openstack-keystone | 10:39 | |
| *** gokrokve has quit IRC | 10:44 | |
| *** lbragstad has joined #openstack-keystone | 10:49 | |
| *** lbragstad__ has quit IRC | 10:50 | |
| *** henrynash has quit IRC | 10:51 | |
| *** henrynash has joined #openstack-keystone | 11:00 | |
| *** saju_m has quit IRC | 11:05 | |
| *** andreaf has quit IRC | 11:21 | |
| *** gokrokve has joined #openstack-keystone | 11:39 | |
| *** gokrokve_ has joined #openstack-keystone | 11:41 | |
| *** henrynash has quit IRC | 11:44 | |
| *** gokrokve has quit IRC | 11:44 | |
| *** gokrokve_ has quit IRC | 11:45 | |
| *** leseb has quit IRC | 11:47 | |
| *** leseb has joined #openstack-keystone | 11:47 | |
| *** andreaf has joined #openstack-keystone | 11:48 | |
| *** lbragstad has quit IRC | 11:51 | |
| *** leseb has quit IRC | 11:51 | |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: Validate groups presence for federated authn https://review.openstack.org/79284 | 11:55 |
| openstackgerrit | wanghong proposed a change to openstack/keystone: remove hardcoded SQL queries in tests https://review.openstack.org/79296 | 12:02 |
| *** henrynash has joined #openstack-keystone | 12:05 | |
| *** henrynash has quit IRC | 12:09 | |
| *** bvandenh has joined #openstack-keystone | 12:13 | |
| openstackgerrit | wanghong proposed a change to openstack/keystone: remove the unused variable in test_sql_upgrade https://review.openstack.org/79297 | 12:14 |
| *** henrynash has joined #openstack-keystone | 12:15 | |
| *** henrynash has quit IRC | 12:18 | |
| *** lbragstad has joined #openstack-keystone | 12:27 | |
| *** david-lyle has quit IRC | 12:28 | |
| *** gokrokve has joined #openstack-keystone | 12:39 | |
| *** leseb has joined #openstack-keystone | 12:39 | |
| *** gokrokve has quit IRC | 12:44 | |
| *** dims_ has quit IRC | 12:44 | |
| *** ayoung-ZZZZZZZzz has quit IRC | 12:45 | |
| *** henrynash has joined #openstack-keystone | 12:53 | |
| *** topol has joined #openstack-keystone | 12:54 | |
| *** dims_ has joined #openstack-keystone | 12:56 | |
| *** nkinder_ has quit IRC | 13:18 | |
| *** devlaps has joined #openstack-keystone | 13:36 | |
| *** stevemar has joined #openstack-keystone | 13:38 | |
| *** bknudson has joined #openstack-keystone | 13:38 | |
| *** gokrokve has joined #openstack-keystone | 13:39 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Add request/access token and consumer support for keystoneclient https://review.openstack.org/60820 | 13:43 |
| *** gokrokve has quit IRC | 13:44 | |
| *** ChanServ sets mode: +o dolphm | 13:47 | |
| *** jagee has joined #openstack-keystone | 13:47 | |
| *** prad has joined #openstack-keystone | 13:53 | |
| *** prad has quit IRC | 13:53 | |
| *** browne has joined #openstack-keystone | 13:55 | |
| openstackgerrit | Steve Martinelli proposed a change to openstack/python-keystoneclient: Authenticate via oauth https://review.openstack.org/77977 | 13:56 |
| dstanek | anyone else having trouble running the full test suite? it seems that I'm running out of memory again for the last 238 tests | 13:57 |
| dolphm | dstanek: running with tox or testr? | 13:58 |
| dstanek | tox | 13:58 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove unnecessary calls to self.config() https://review.openstack.org/79226 | 13:58 |
| dolphm | dstanek: running it now... | 13:58 |
| dstanek | dolphm: how much ram do you have? | 13:59 |
| dolphm | dstanek: 8gb | 13:59 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove unnecessary config_files implementation https://review.openstack.org/79225 | 13:59 |
| dstanek | ah, you won't have problems then - i'm in the process of creating a new bigger vm | 13:59 |
| dstanek | i was running a 2g performance server | 14:00 |
| dolphm | dstanek: ah, i'm just running on my laptop | 14:00 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove duplication when picking test config files https://review.openstack.org/79219 | 14:00 |
| dstanek | i think i can fix this with some changes to testtools - tests shouldn't get so big | 14:01 |
| dstanek | dolphm: alright, i just figured out my morning... | 14:01 |
| bknudson | fix the memory leak | 14:02 |
| bknudson | just wait until we're running tests in parallel | 14:02 |
| dstanek | bknudson: that'll be fun - i'm going to plug the hole | 14:03 |
| bknudson | I got a laptop with more cpus so the lack of parallel testing affects me now | 14:03 |
| *** jagee has quit IRC | 14:04 | |
| dstanek | bknudson: i forget where morganfainberg_Z left off | 14:05 |
| bknudson | I'm sure there's lots to do. | 14:05 |
| dolphm | dstanek: i also wrote an ansible playbook for most of that raspberry pi project... deployed it temporarily to http://gatewatch.dolphm.com/ | 14:05 |
| jaosorior | I've been trying to run the full test suit in my laptop, but have been getting errors while trying to run keystone.tests.test_keystoneclient.KcMasterTestCase, is this normal? | 14:05 |
| dstanek | jaosorior: what are the errors? can you put the traceback in paste.openstack.org? | 14:06 |
| jaosorior | sure | 14:07 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove duplication when picking test config files https://review.openstack.org/79219 | 14:07 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Configurable temporary directory for tests https://review.openstack.org/79217 | 14:07 |
| jaosorior | this is the error message when running ./run_tests.sh -x : http://paste.openstack.org/show/73024/ | 14:08 |
| jaosorior | though, almost every test in keystone.tests.test_keystoneclient.KcMasterTestCase fails for me :/ | 14:08 |
| bknudson | For assistance, contact <a href="http://internal.ericsson.com/page/hub_inside/support/it/index.jsp">IT Service Desk.</a> | 14:09 |
| bknudson | that's an odd error | 14:09 |
| bknudson | it looks like it's not connecting to the local debug keystone server but some other system. | 14:10 |
| jaosorior | uhm, maybe it's my local environment | 14:10 |
| *** nkinder_ has joined #openstack-keystone | 14:11 | |
| jaosorior | is there any configuration file for the local debug keystone server? | 14:11 |
| dstanek | what is www-proxy.ericsson.se? | 14:11 |
| jaosorior | or somewhere were I can tweak this? | 14:11 |
| jaosorior | a proxy server | 14:11 |
| dstanek | it looks to me like BlueCoat-Security-Appliance is intercepting all traffic | 14:12 |
| dstanek | which is wierd because you are trying to get to localhost | 14:12 |
| *** daneyon has joined #openstack-keystone | 14:12 | |
| jaosorior | which is odd :/ | 14:13 |
| dstanek | you may need to talk to your IT staff | 14:13 |
| *** daneyon has quit IRC | 14:13 | |
| dolphm | jaosorior: i think your laptop has been compromised by your employer :P | 14:13 |
| *** daneyon has joined #openstack-keystone | 14:13 | |
| jaosorior | thanks for the help, it seems I'll have to deal with this somehow to get it working | 14:13 |
| dstanek | i've never seem security software that intercepts local traffic, but it doesn't mean it doesn't happen | 14:14 |
| dstanek | jaosorior: virtual box or a cloud vm is how i usually work | 14:14 |
| dolphm | jaosorior: you could also develop on a cloud server or in a local vm to avoid running into that | 14:14 |
| dolphm | dstanek: ++ | 14:14 |
| dstanek | although you probably can't install VB | 14:14 |
| dolphm | dstanek: VB? | 14:14 |
| dstanek | virtual box | 14:15 |
| *** jagee has joined #openstack-keystone | 14:15 | |
| dolphm | vbox* | 14:15 |
| jaosorior | I can use VB, that's no issue, but I would prefer to be able to run this on my machine | 14:15 |
| dolphm | dstanek: you had me thinking visual basic | 14:15 |
| bknudson | I thought VisualBasic | 14:15 |
| dstanek | dolphm: :-P | 14:15 |
| jaosorior | is there any file were I can configure the local test server? | 14:15 |
| dstanek | jaosorior: to do what? | 14:16 |
| bknudson | I think the tests read the keystone/tests/test_overrides.conf | 14:16 |
| dolphm | jaosorior: for the most part, tests shouldn't require external configuration | 14:16 |
| jaosorior | I'm aware of that, but I'm trying to come up with a temporal workaround | 14:17 |
| dolphm | jaosorior: it's literally starting a service on localhost with a high port number and testing against it | 14:17 |
| dolphm | jaosorior: there's no config there, as the ports are chosen randomly | 14:17 |
| jaosorior | oh, alright | 14:18 |
| dstanek | jaosorior: it would be interesting to see what happens if you run a web server on a high port and then access that through the browser | 14:19 |
| jaosorior | is there a parameter I can use for run_tests.sh to exclude tests? in the meantime | 14:19 |
| *** topol has quit IRC | 14:23 | |
| dstanek | jaosorior: not that i know of, but you can just delete the file temporarily | 14:25 |
| *** leseb has quit IRC | 14:25 | |
| dstanek | jaosorior: the last time i needed to exclude tests i did it the complicated way and filtered the list of tests generated with subunit using grep - i would probably not do that again | 14:26 |
| jaosorior | It's passing now, I had to tweak some environment variable of mine | 14:26 |
| *** leseb has joined #openstack-keystone | 14:26 | |
| jaosorior | but if I recall there are some unit testing frameworks that handle these exclusions without the usage of grep | 14:27 |
| jaosorior | haven't gotten very acquainted to subunit yet though | 14:27 |
| jaosorior | would you consider it useful if I try to add similar functionality to the run_tests.sh? | 14:27 |
| dolphm | jaosorior: what did you change? | 14:28 |
| jaosorior | I added some exception to my proxy environment variables. It was just an error in my general setup | 14:29 |
| *** leseb has quit IRC | 14:30 | |
| *** wchrisj has joined #openstack-keystone | 14:30 | |
| *** leseb has joined #openstack-keystone | 14:32 | |
| dolphm | dstanek: test run went fine, but i totally forgot to watch it's memory usage :P | 14:32 |
| dolphm | i did run into this though in py26 and py27 (i've actually seen this before, but ignored it..) http://pasteraw.com/8bjrvo8svubuvpanp7gh4xy23orf471 | 14:33 |
| *** david-lyle has joined #openstack-keystone | 14:33 | |
| dstanek | dolphm: did the test for that fail? | 14:34 |
| dolphm | dstanek: yeah | 14:35 |
| *** rwsu has joined #openstack-keystone | 14:36 | |
| dolphm | i'm still on tox 1.6.1 (did 1.7 ever get fixed?) | 14:36 |
| *** mberlin1 has quit IRC | 14:36 | |
| bknudson | i've never seen a failure in test_keepalive_and_keepidle_set | 14:37 |
| *** gokrokve has joined #openstack-keystone | 14:39 | |
| dstanek | dolphm: i'm on 1.6.1 and i haven't seen that error | 14:40 |
| *** ayoung has joined #openstack-keystone | 14:41 | |
| *** gokrokve_ has joined #openstack-keystone | 14:41 | |
| *** gokrokve has quit IRC | 14:43 | |
| *** dolphm has quit IRC | 14:48 | |
| *** packet has joined #openstack-keystone | 14:49 | |
| *** tellesnobrega has quit IRC | 14:49 | |
| *** raildo has quit IRC | 14:49 | |
| *** dolphm_ has joined #openstack-keystone | 14:49 | |
| openstackgerrit | Jenkins proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/76691 | 14:49 |
| bknudson | jenkins will never get that change merged if it keeps changing | 14:50 |
| *** ayoung has quit IRC | 14:50 | |
| *** ayoung has joined #openstack-keystone | 14:50 | |
| *** dolphm_ is now known as dolphm | 14:50 | |
| *** ChanServ sets mode: +o dolphm | 14:50 | |
| *** gokrokve_ has quit IRC | 14:51 | |
| openstackgerrit | Jenkins proposed a change to openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/75586 | 14:52 |
| *** devlaps has quit IRC | 14:54 | |
| dolphm | dstanek: the total duration for running tox -e py27 has basically doubled for me in the past week :-/ | 14:55 |
| dolphm | running again... | 14:56 |
| dolphm | (last run: http://pasteraw.com/6tq28ennwt6myo0pjjs6eeqp7ohxh6w ) | 14:56 |
| bknudson | I think new migrations wind up being O(n*n) | 14:57 |
| bknudson | if so, squashing migrations would speed it up again | 14:58 |
| *** thedodd has joined #openstack-keystone | 14:58 | |
| dstanek | bknudson: is that a work in progress or a wishlist item? | 15:03 |
| bknudson | dstanek: morganfainberg_Z has a change lined up for J | 15:04 |
| *** leseb has quit IRC | 15:05 | |
| *** leseb has joined #openstack-keystone | 15:05 | |
| *** bvandenh has quit IRC | 15:06 | |
| *** gokrokve has joined #openstack-keystone | 15:08 | |
| *** leseb has quit IRC | 15:09 | |
| *** leseb has joined #openstack-keystone | 15:11 | |
| *** jraim has quit IRC | 15:15 | |
| *** jraim has joined #openstack-keystone | 15:17 | |
| *** stevemar has quit IRC | 15:21 | |
| openstackgerrit | Marek Denis proposed a change to openstack/keystone: Validate groups presence for federated authn https://review.openstack.org/79284 | 15:24 |
| *** stevemar has joined #openstack-keystone | 15:25 | |
| mhu | Hi, is there a documented way to update the sql backend for a contrib ? Namely, run the scripts there: https://github.com/openstack/keystone/tree/master/keystone/contrib/federation/migrate_repo/ | 15:39 |
| *** gokrokve has quit IRC | 15:40 | |
| mhu | I am using a devstack and the identity_providers table is not created when installing keystone | 15:43 |
| lbragstad | mhu: db_sync? | 15:50 |
| mhu | lbragstad, doesn't seem to work | 15:51 |
| mhu | I did 'keystone-manage db_sync', it exited silently, and the table hasn't been created | 15:52 |
| dstanek | mhu: did you enable the extension? | 15:54 |
| dstanek | http://docs.openstack.org/developer/keystone/extensions/federation-configuration.html | 15:55 |
| dstanek | mhu: ^ | 15:55 |
| mhu | dstanek, thanks a lot !! | 15:55 |
| mhu | I bet it's the part with db_sync | 15:55 |
| mhu | dstanek, lbragstad : yep, that did it alright - thanks for your help | 15:56 |
| *** devlaps has joined #openstack-keystone | 16:16 | |
| *** gyee has joined #openstack-keystone | 16:19 | |
| *** mberlin has joined #openstack-keystone | 16:21 | |
| *** raildo has joined #openstack-keystone | 16:26 | |
| *** gokrokve has joined #openstack-keystone | 16:26 | |
| dstanek | mhu: np | 16:27 |
| *** harlowja has joined #openstack-keystone | 16:49 | |
| *** browne has quit IRC | 16:53 | |
| *** marcoemorais has joined #openstack-keystone | 16:55 | |
| *** browne has joined #openstack-keystone | 17:00 | |
| *** amcrn has quit IRC | 17:04 | |
| ayoung | nkinder_, can you bring https://review.openstack.org/#/c/73935/ back to life. | 17:06 |
| *** leseb has quit IRC | 17:06 | |
| ayoung | morganfainberg_Z, let me know when you are up, and we can talk about the revoke/clear patch | 17:08 |
| *** leseb has joined #openstack-keystone | 17:11 | |
| *** morganfainberg_Z is now known as morganfainberg | 17:11 | |
| *** richm has joined #openstack-keystone | 17:12 | |
| morganfainberg | bknudson, huh what do i have lined up for J? | 17:12 |
| morganfainberg | ayoung, here now | 17:13 |
| ayoung | morganfainberg, so, do you need help in coming up with the test ? | 17:14 |
| openstackgerrit | ayoung proposed a change to openstack/python-keystoneclient: Split sample PKI token generation https://review.openstack.org/74930 | 17:14 |
| ayoung | morganfainberg, I'mreferring to https://review.openstack.org/#/c/79174/ | 17:15 |
| morganfainberg | yeah | 17:15 |
| ayoung | morganfainberg, the test would be slightly artificial | 17:15 |
| morganfainberg | yes | 17:15 |
| morganfainberg | i saw your comment | 17:15 |
| ayoung | the isdea was that in the real world, we would use the token expiry as the point after we could drop a revocation event | 17:16 |
| ayoung | but if a token was set with an artificially long expiry | 17:16 |
| ayoung | we could drop the event, and then that token would start passing | 17:16 |
| ayoung | in geenral, revocation events don't revoke into the future | 17:16 |
| ayoung | ,but we could do that, too | 17:16 |
| morganfainberg | that can't be done short of mucking with the data outside of the control of keystone | 17:16 |
| morganfainberg | the artificial expiry | 17:16 |
| morganfainberg | or custom provider | 17:16 |
| ayoung | test_revoke should be able to do that | 17:17 |
| morganfainberg | hm. | 17:17 |
| ayoung | you can call cms to sign a token yourself if you really want | 17:17 |
| morganfainberg | i think that fall outside of the scope of the test i wrote | 17:17 |
| morganfainberg | tbh | 17:17 |
| morganfainberg | that sounds like a completely different test case | 17:17 |
| ayoung | infact, since token_values is all that is handed off, you can just hand jam them | 17:18 |
| ayoung | morganfainberg, ok, let me give it a stab | 17:18 |
| ayoung | we can add out +1s together to get to a singele +2 if desired | 17:18 |
| morganfainberg | ayoung, sure. | 17:19 |
| morganfainberg | in either case i want to get that review in today | 17:19 |
| morganfainberg | however we need to do that | 17:19 |
| morganfainberg | s/through/in gate | 17:19 |
| *** jaosorior has quit IRC | 17:20 | |
| *** lbragstad has left #openstack-keystone | 17:23 | |
| *** lbragstad has joined #openstack-keystone | 17:24 | |
| *** amcrn has joined #openstack-keystone | 17:27 | |
| ayoung | morganfainberg, OK...so first off, you were passing the token iteslef into the event | 17:28 |
| ayoung | err | 17:28 |
| ayoung | into the tree | 17:28 |
| ayoung | it needs to be the flattened version from | 17:29 |
| ayoung | contrib/revoke/model.py | 17:29 |
| ayoung | It can be a simple dictionary like | 17:29 |
| morganfainberg | ayoung, i am using the v2 token values method | 17:29 |
| morganfainberg | ayoung, look at line 150 | 17:30 |
| ayoung | https://review.openstack.org/#/c/79174/3/keystone/tests/test_revoke.py | 17:30 |
| ayoung | Ah...I see it | 17:30 |
| ayoung | missed that | 17:30 |
| morganfainberg | ayoung, yep | 17:30 |
| morganfainberg | ayoung, no worries | 17:30 |
| ayoung | morganfainberg, no need, I think | 17:30 |
| ayoung | lets just test the dictionary here | 17:30 |
| morganfainberg | i was aiming for the "expected" value based on something that a token kind of looks like | 17:31 |
| morganfainberg | but if you'd rather it be a hand-crafted flattend value set, sure | 17:31 |
| morganfainberg | though, i think that is how we got into the mess where our sample tokens don't look like "real" tokens | 17:32 |
| *** andreaf has quit IRC | 17:34 | |
| ayoung | morganfainberg, wel...I don't disagree....the code was originally split out or other reasons. | 17:34 |
| ayoung | I like the idea of beating on the v2 and v3 translation functions | 17:34 |
| lbragstad | morganfainberg: quick question on the region migration review whenever you've got a minute | 17:35 |
| morganfainberg | lbragstad, sure | 17:35 |
| lbragstad | so, I took your and jay's suggestions and implemented them | 17:35 |
| lbragstad | http://paste.openstack.org/show/73045/ | 17:35 |
| morganfainberg | wow i forgot i even looked at that review :P | 17:35 |
| lbragstad | I sync'd down to 36, since that was the migration before jay's region table addition | 17:36 |
| lbragstad | :) | 17:36 |
| ayoung | morganfainberg, blank_token_data is in the post form, though | 17:36 |
| ayoung | not pre | 17:36 |
| morganfainberg | ayoung, ah, that isn't clear | 17:36 |
| ayoung | morganfainberg, I don't think I wrote that | 17:37 |
| morganfainberg | also... why is _blank_token_data in model.py? it's only used for testing | 17:37 |
| lbragstad | for some reason, it doesn't look like it's picking up the right constraint, | 17:37 |
| morganfainberg | lbragstad, i see that looking at that now. | 17:37 |
| ayoung | Um...guess I did... | 17:37 |
| ayoung | doesn't really seem to belong in the model...looks like test code | 17:38 |
| ayoung | only your code uses it | 17:38 |
| *** jaypipes has joined #openstack-keystone | 17:39 | |
| morganfainberg | _sample_blank_token uses it, and that is used in a few places | 17:39 |
| morganfainberg | or | 17:39 |
| morganfainberg | not | 17:39 |
| morganfainberg | wow. | 17:39 |
| morganfainberg | huh | 17:39 |
| ayoung | yeah... | 17:39 |
| jaypipes | ho | 17:39 |
| jaypipes | wow | 17:39 |
| jaypipes | huh | 17:39 |
| jaypipes | hi | 17:39 |
| * lbragstad waves at jaypipes | 17:39 | |
| morganfainberg | jaypipes, such comment | 17:39 |
| jaypipes | :) | 17:40 |
| ayoung | I think that it should be used to default the token_data | 17:40 |
| ayoung | but it probably should be _ | 17:40 |
| morganfainberg | oh ick. lbragstad | 17:40 |
| lbragstad | lol the sql error? | 17:40 |
| morganfainberg | the "unique" keyword might be the issue | 17:41 |
| morganfainberg | vs. how we "mostly" just apply the constraint explicitly as a constraint afterwards | 17:41 |
| morganfainberg | i'm guessing "unique" does something very dumb | 17:41 |
| lbragstad | .. kinda what I was thinking... | 17:41 |
| lbragstad | so that would leave us with having to create a temp table, move the data from region table over, drop the old region table, and recreate without the 'unique=True' part... right? | 17:42 |
| morganfainberg | i'm looking at the SQLA code now | 17:42 |
| jaypipes | lbragstad: if you do a print of region_table.indexes right before the uc.drop() call, what does it print? | 17:42 |
| lbragstad | jaypipes: checking | 17:42 |
| jaypipes | morganfainberg: I'm thinking the same as you.. might be the default "name" of the index... | 17:43 |
| morganfainberg | yep | 17:43 |
| morganfainberg | unique constraints with unique kw looks like a non-named constraint | 17:43 |
| morganfainberg | which is bad | 17:43 |
| jaypipes | morganfainberg: right. oslo.db has all that fixed up, though. | 17:43 |
| lbragstad | set([Index(u'description', Column(u'description', VARCHAR(length=255), table=<region>, nullable=False), unique=True)]) | 17:43 |
| jaypipes | morganfainberg: I don't like the UC naming convention in oslo.db, but at least it is consistent. | 17:44 |
| morganfainberg | lbragstad, can you do a 'show create table' ? | 17:44 |
| jaypipes | lbragstad: OK, one sec... checking to see if UniqueConstraint() has a "name" kwarg | 17:44 |
| morganfainberg | jaypipes, fair, i like consistent naming. | 17:44 |
| morganfainberg | jaypipes, it does. | 17:44 |
| morganfainberg | jaypipes. https://review.openstack.org/#/c/78169/1/keystone/common/sql/migrate_repo/versions/036_havana.py look at line 204 | 17:45 |
| morganfainberg | for example | 17:45 |
| morganfainberg | it's a sql-a migrate ism it looks like | 17:45 |
| jaypipes | lbragstad: ok, change line 16 in that paste to desc_uc = constraint.UniqueConstraint('description', table=region_table, name="description") | 17:45 |
| morganfainberg | uhm. | 17:46 |
| morganfainberg | jaypipes, sec | 17:46 |
| jaypipes | what? | 17:46 |
| morganfainberg | hmm | 17:46 |
| morganfainberg | ok, so i need to see what the key ends up being | 17:47 |
| jaypipes | morganfainberg: "description" see lbragstad paste above. | 17:47 |
| morganfainberg | not sure if thats what SQLA is doing | 17:47 |
| * lbragstad fist pump! | 17:47 | |
| lbragstad | yeah | 17:47 |
| lbragstad | that works | 17:47 |
| jaypipes | w00tness. | 17:47 |
| * lbragstad pasting | 17:47 | |
| morganfainberg | oh ok | 17:47 |
| morganfainberg | i am concerned that it wont "work" in all SQL backends though | 17:48 |
| morganfainberg | since it seems like SQLA lets the backend do some magic name assignment sometimes | 17:48 |
| morganfainberg | but i haven't tracked that down 100% to be sure | 17:48 |
| jaypipes | morganfainberg: fair point. lbragstad, instead of hard-coding "description" as the name, probably worth taking the index name from the return of region_table.indexes[0] | 17:48 |
| morganfainberg | yeah. | 17:48 |
| morganfainberg | that sounds more correct | 17:48 |
| morganfainberg | jaypipes, ++ | 17:48 |
| *** gyee has quit IRC | 17:49 | |
| lbragstad | ++ | 17:49 |
| lbragstad | good diea | 17:49 |
| lbragstad | http://paste.openstack.org/ | 17:49 |
| jaypipes | lbragstad: might want to double check the structure of the Index class with a print dir(region_table.indexes[0]) to see if there is a name attribute. | 17:49 |
| jaypipes | lbragstad: did you want me to paste something? ;) | 17:49 |
| morganfainberg | jaypipes, if there isn't a consistent name, we might want a temp/pivot and recreate. | 17:50 |
| jaypipes | morganfainberg: ? | 17:50 |
| morganfainberg | jaypipes, it sucks to need to do, but it ensures we have consistency | 17:50 |
| lbragstad | jaypipes: hah nope... my ^ - C are a little fast today | 17:50 |
| lbragstad | http://paste.openstack.org/show/73047/ | 17:50 |
| morganfainberg | create new table, migrate data, rename table | 17:50 |
| jaypipes | morganfainberg: not sure that is needed, as the __table__.indexes collection should give us the introspection we need (all we need is the index/constraint name in this case, no?) | 17:51 |
| morganfainberg | if the tables.indexes[0] doesn't have a name | 17:51 |
| lbragstad | morganfainberg: jaypipes yeah, we have done that before, migration 16 iirc | 17:51 |
| morganfainberg | jaypipes, well, the issue is non-named constaints can't be migrated | 17:51 |
| morganfainberg | jaypipes, sql-a has this issue | 17:51 |
| morganfainberg | jaypipes at least last i heard | 17:51 |
| morganfainberg | sql-a-migrate that is | 17:51 |
| jaypipes | morganfainberg: ah, yes, that is indeed true... poop. | 17:51 |
| morganfainberg | jaypipes, so if we dno't have a name, lets just migrate a new "fixed" table (sucky but solves the issue cleanly) | 17:52 |
| lbragstad | so we will have to create tmp, migrate data, drop old, and recreate regions without unique=True | 17:52 |
| jaypipes | yes, I suppose so. :( | 17:52 |
| morganfainberg | lbragstad, i _think_ you can do create tmp, migrate data to tmp (with correct structure), drop old, rename tmp | 17:52 |
| jaypipes | lbragstad: but don't we need to do that anyway with the change to nullable=True on description? | 17:52 |
| morganfainberg | one less table create | 17:52 |
| lbragstad | morganfainberg: ok, sounds like a plan | 17:53 |
| morganfainberg | jaypipes, nullalble should be a alterable attribute | 17:53 |
| jaypipes | lbragstad: thx for your patience, man! | 17:53 |
| morganfainberg | jaypipes, since it's not held as an index/key | 17:53 |
| lbragstad | jaypipes: I think dolphm wanted to keep that nullable=False | 17:53 |
| morganfainberg | jaypipes, indexes and keys are not held in the column on all engines | 17:53 |
| lbragstad | and we can carry a fix in the manager to set it to '' if it isn't provided | 17:53 |
| jaypipes | morganfainberg: hmm, yes, that is true for the upgrade. downgrade needs to be guarded, though. | 17:53 |
| morganfainberg | jaypipes, sure, downgrade would need de-conflicting | 17:54 |
| jaypipes | morganfainberg needs deconflicting :P | 17:54 |
| morganfainberg | jaypipes, though tbh, i'd probably just make the downgrade a no-op and fix the migrate up to include it. | 17:54 |
| morganfainberg | if is nullable, do nothing, if isn't drop nullable. fix previous migrate to not include nullable, and downgrade is "do nothing" | 17:54 |
| *** browne has quit IRC | 17:55 | |
| *** browne has joined #openstack-keystone | 17:55 | |
| jaypipes | fair enough. | 17:55 |
| jaypipes | no harm no foul on that one. | 17:55 |
| morganfainberg | yep | 17:55 |
| morganfainberg | i actually like that methodology for non-shipped code. | 17:56 |
| morganfainberg | lets people track master and lets us "fix" issues without worrying about conflict resolution etc. | 17:56 |
| lbragstad | I'll work on another patch and hope to get something pushed up today | 17:57 |
| morganfainberg | lbragstad, sounds good | 17:57 |
| lbragstad | morganfainberg: jaypipes thanks again for the help, it's really appreciated | 17:57 |
| morganfainberg | lbragstad, thanks for working on this, it is a bit painful so patience is also appreciated. | 17:58 |
| jaypipes | lbragstad: any time! | 17:58 |
| jaypipes | trust me, I know how painful the migration crap is, so again, ty for helping with it. | 17:58 |
| morganfainberg | jaypipes, https://review.openstack.org/#/c/78169/ | 17:59 |
| morganfainberg | jaypipes, i have some work to do for that to land in J, but yes, migrations can be painful | 17:59 |
| jaypipes | heh, yeah. | 18:00 |
| *** marcoemorais has quit IRC | 18:04 | |
| *** marcoemorais has joined #openstack-keystone | 18:05 | |
| *** marcoemorais has quit IRC | 18:05 | |
| *** marcoemorais has joined #openstack-keystone | 18:05 | |
| openstackgerrit | ayoung proposed a change to openstack/keystone: Call an existing method in sync cache for revoke events https://review.openstack.org/79174 | 18:08 |
| *** zhiyan is now known as zhiyan_ | 18:08 | |
| morganfainberg | ayoung, that looks reasonable, running a test locally before tossing a +1 on it | 18:09 |
| ayoung | morganfainberg, thanks | 18:10 |
| morganfainberg | ayoung, works as expected! nice :) | 18:11 |
| morganfainberg | also i'm loving mock.patch.object | 18:11 |
| ayoung | morganfainberg, took me a second to debug, cuz I had token[user_id] = user_id | 18:11 |
| morganfainberg | hehe | 18:12 |
| morganfainberg | oops | 18:12 |
| ayoung | yeah, kinda panicked there for a second | 18:12 |
| morganfainberg | i've _never_ done that before /s | 18:12 |
| morganfainberg | "Why isn't this dict working?! i set the key!!!" | 18:12 |
| morganfainberg | ok +1 added specifically calling out the expanded test. | 18:13 |
| morganfainberg | oh | 18:14 |
| morganfainberg | minor nit should be fixed. | 18:14 |
| morganfainberg | line 169, remove it instead of commenting it out | 18:14 |
| morganfainberg | ayoung, ^ | 18:14 |
| ayoung | yep | 18:14 |
| *** zhiyan_ is now known as zhiyan | 18:19 | |
| ayoung | running unit tests in tox provides a real lack of feedback | 18:21 |
| morganfainberg | ayoung, testr | 18:22 |
| morganfainberg | ayoung, it's not tox's fault | 18:22 |
| morganfainberg | it's the runner being annoying | 18:22 |
| ayoung | morganfainberg, run_tests.sh provides feedback | 18:22 |
| *** leseb has quit IRC | 18:22 | |
| ayoung | and that uses testr, too | 18:22 |
| *** leseb has joined #openstack-keystone | 18:22 | |
| morganfainberg | ayoung, hm. | 18:23 |
| morganfainberg | we could probably do the same thing in the standard tox runs | 18:23 |
| ayoung | morganfainberg, Or provide a switch...I suspect that the CI doesn't need the log spew | 18:24 |
| morganfainberg | ayoung, looking to see if we can do something posargs specific | 18:25 |
| ayoung | morganfainberg, it turns out that I had rebooted my machine and not run testmount, so it was not doing the ramdisk trick | 18:25 |
| morganfainberg | ahh | 18:25 |
| ayoung | morganfainberg, I usually realize that when I see how slow each test is running | 18:26 |
| *** leseb has quit IRC | 18:27 | |
| ayoung | morganfainberg, so, I just ran the master version of python-keystoneclient, but with the popen args changes to : universal_newlines=False and it runs fine in 27 | 18:29 |
| ayoung | going to try with -epy33 | 18:29 |
| ayoung | and..it fails like immediately | 18:29 |
| ayoung | db type could not be determined | 18:30 |
| *** zhiyan is now known as zhiyan_ | 18:34 | |
| ayoung | morganfainberg, OK...I learned something | 18:34 |
| ayoung | https://ask.openstack.org/en/question/5310/db-type-could-not-be-determined/ | 18:34 |
| morganfainberg | orly | 18:35 |
| morganfainberg | wtf. | 18:35 |
| morganfainberg | sure. | 18:35 |
| *** gyee has joined #openstack-keystone | 18:37 | |
| openstackgerrit | ayoung proposed a change to openstack/keystone: Call an existing method in sync cache for revoke events https://review.openstack.org/79174 | 18:41 |
| morganfainberg | ayoung, LGTM | 18:42 |
| *** leseb has joined #openstack-keystone | 18:45 | |
| *** leseb has quit IRC | 18:45 | |
| *** leseb has joined #openstack-keystone | 18:45 | |
| dstanek | i wonder is there is an option for testr to not store the test history | 18:47 |
| *** leseb has quit IRC | 18:50 | |
| morganfainberg | dstanek, does not look like it | 18:52 |
| *** daneyon has quit IRC | 18:54 | |
| morganfainberg | ayoung, tox -epy27 -- --subunit | subunit-2to1 | tools/colorizer.py | 18:54 |
| ayoung | neato | 18:54 |
| morganfainberg | that should, afaict do what run_tests does | 18:55 |
| morganfainberg | checking now | 18:55 |
| ayoung | morganfainberg, we can submit a change to run_tests.sh to do that | 18:55 |
| dstanek | morganfainberg: really? i wouldn't expect the pipes to work there | 18:55 |
| morganfainberg | ayoung, yeah if it works | 18:55 |
| dstanek | ayoung: that is what run_tests is doing right? | 18:55 |
| ayoung | I would be willing to bet that using run_tests.sh to run tox would be the right long term direction | 18:55 |
| ayoung | it means we don't duplicate how we test, we just provide a shortcut and "teach people tox" approach | 18:56 |
| morganfainberg | dstanek, might need a little extra guarding for bash-isms | 18:56 |
| dstanek | ayoung: http://git.openstack.org/cgit/openstack/keystone/tree/run_tests.sh#n89 | 18:56 |
| morganfainberg | dstanek, sure. | 18:57 |
| dstanek | testr make all this stuff so overly complicated | 18:57 |
| ayoung | dstanek, um...if you recommend switching out our testing infrastructure again, I will beat you with morganfainberg 's +2 pin in a wool sock | 18:58 |
| dstanek | ayoung: i didn't recommend it in the first place :-) that was the official open stack direction :-( | 18:58 |
| ayoung | dstanek, I meant that run_tests.sh should just do "tox -epy27" | 18:59 |
| dstanek | it's part of the reinvent everything game plan | 18:59 |
| ayoung | and run_tests.sh -pep8 do to -epep8 | 18:59 |
| ayoung | and so forth. I'm collecting notes for a cheat sheet | 18:59 |
| dstanek | ayoung: yeah, i think that would be a good plan | 18:59 |
| ayoung | like, whenc toc -epy33 fails remove the .test--repost times.db file | 18:59 |
| ayoung | although I suspect we should probably just recommend wiping that whole subdir | 19:00 |
| dstanek | ayoung: although for that to work we'd have to figure out the pipelining | 19:01 |
| ayoung | what about the pipelining? | 19:02 |
| morganfainberg | ayoung, dstanek tox -epy27 -- --subunit | subunit-2to1 | tools/colorizer.py works just fine | 19:02 |
| morganfainberg | just need to make sure python-subunit and six are installed on the system | 19:02 |
| dstanek | morganfainberg: oh, nice | 19:02 |
| ayoung | from testtools import StreamToExtendedDecorator | 19:03 |
| ayoung | ImportError: cannot import name StreamToExtendedDecorator | 19:03 |
| dstanek | i wonder if you can use tox to run those | 19:03 |
| ayoung | must be able to | 19:03 |
| morganfainberg | i can absolutely get a change for run_tests to do that, the only question is making run tests use the "right" env for python version | 19:03 |
| ayoung | morganfainberg, run_tests.sh for Keystone can default to 27 until we can get a clean 33 run | 19:03 |
| ayoung | once we do, lets switch it to 33 | 19:03 |
| morganfainberg | or we could just add to tox.ini -e " | 19:03 |
| morganfainberg | erm | 19:04 |
| ayoung | and make a gentlemen's pact to code primarily in 33, with 27 being the afterthought | 19:04 |
| morganfainberg | a subunit-2to1 env | 19:04 |
| dstanek | morganfainberg: the way i have thought about it in the past was to create a bash helper script and have to run that | 19:04 |
| morganfainberg | so it would use whatever the "base" version is | 19:04 |
| ayoung | oh, and run pep before the unit tests | 19:04 |
| morganfainberg | hmmm. | 19:05 |
| dstanek | but i never did it because the run_test.sh script would call tox and tox would run yet another shell script - it just made me too sad | 19:05 |
| morganfainberg | we could just make run_tests "smart" | 19:05 |
| morganfainberg | it already is the helper script | 19:05 |
| morganfainberg | and tox already has env's for everything | 19:05 |
| morganfainberg | so, two options, new tox env "subunit_2to1" | 19:06 |
| morganfainberg | which just uses the base/default python version | 19:06 |
| dstanek | morganfainberg: pipelining doesn't work directly in tox does it? | 19:06 |
| morganfainberg | eg. what pep8 does | 19:06 |
| morganfainberg | sure it does. | 19:06 |
| morganfainberg | it just executes whatever commands | 19:06 |
| dstanek | why not put it there then and call it a day? | 19:06 |
| dstanek | i swear i tried it and ran into issues | 19:07 |
| * morganfainberg checks | 19:07 | |
| dstanek | so instead of the 'python setup.py testr' command you would copy the pipeline from run_tests.sh | 19:07 |
| morganfainberg | ok let me see what i can convince tox to do. | 19:08 |
| ayoung | dstanek, how is your python 33 kungfu? I am trying to make a swtich in the popen call to deal with binary data and, well it is crapping out | 19:08 |
| morganfainberg | might need to explicitly invoke bash | 19:08 |
| ayoung | to use atechnical term | 19:08 |
| ayoung | TypeError: 'str' does not support the buffer interface | 19:08 |
| dstanek | morganfainberg: like a "bash -c 'blah'""? | 19:09 |
| morganfainberg | dstanek, ah you're right, we're in pure python | 19:09 |
| morganfainberg | dstanek, can't use bash-isms | 19:09 |
| dstanek | ayoung: decent | 19:09 |
| morganfainberg | dstanek, lets not do that | 19:09 |
| ayoung | dstanek, when calling popen, I was passing universal_newlines=True | 19:09 |
| morganfainberg | but it works | 19:10 |
| ayoung | but, I suspect it is using that to detect "is this a text going both directions" | 19:10 |
| dstanek | morganfainberg: when i thought about it i didn't like any solution i came up with so i just stopped thinking about it :-) | 19:10 |
| morganfainberg | well.. it looks like it works | 19:10 |
| ayoung | If I set universal_newlines = False, it seems like code that is expecting binary is getting a string and barfing on it | 19:10 |
| dstanek | ayoung: which review? | 19:10 |
| dstanek | i've been using nosetests because everytime i have an import error testr won't give me a traceback | 19:11 |
| ayoung | dstanek, https://review.openstack.org/#/c/71181/18/keystoneclient/common/cms.py has it ,but I think I am going to post a simpler one for just this change first | 19:11 |
| ayoung | I'll post a draft | 19:11 |
| morganfainberg | dstanek, eyah /bin/bash -c "<stuff>" does exactly that | 19:13 |
| morganfainberg | not sure i want to spew all the timing stuff into the CI logs though | 19:13 |
| morganfainberg | ayoung, dstanek, i'm more inclined to make a new tox target. | 19:13 |
| ayoung | dstanek, https://review.openstack.org/#/c/79411/ | 19:13 |
| ayoung | dstanek, you can see that just encoding the outgoing text does not seem to be enough | 19:14 |
| ayoung | in fact, it seems to be irrelevant | 19:14 |
| morganfainberg | dstanek, ayoung, so new tox target run_tests uses? or ... just spew the content into the CI logs? | 19:15 |
| morganfainberg | new target can just use the base python version | 19:16 |
| morganfainberg | so whatever you're using locally would be the target. | 19:16 |
| ayoung | morganfainberg, if we add a new target, it will not be run yet by CI, right? It explicitly runs pep8 and py27 in different targets anyway | 19:16 |
| morganfainberg | correct | 19:16 |
| morganfainberg | but do we want that info in the CI logs. | 19:17 |
| morganfainberg | actually... i think this is an infra question | 19:17 |
| ayoung | run_tests.sh could do tox -epep8 and then tox -epy27 | 19:17 |
| morganfainberg | if they have a strong feeling one side or the other. | 19:17 |
| morganfainberg | ayoung, yeah i can have it do it just like that | 19:17 |
| ayoung | with all of the coloring | 19:17 |
| morganfainberg | w/ the extra args to make it colorful | 19:17 |
| morganfainberg | like i said, provided you have subunit and six installed | 19:17 |
| morganfainberg | if we make it a tox target, six and subunit are installed in the venvs | 19:18 |
| morganfainberg | run_tests would just use the new tox target vs. py27 | 19:18 |
| ayoung | morganfainberg, sounds right to me | 19:19 |
| ayoung | morganfainberg, 2 reviews | 19:19 |
| ayoung | one for the new tox target, a second to use it in run_tests.sh | 19:19 |
| morganfainberg | eh, nah, 1 review | 19:19 |
| ayoung | the second that is going to require some finagling | 19:19 |
| ayoung | but the first review is valuable all by itself | 19:20 |
| dstanek | what's the benefit using having a new venv? | 19:20 |
| ayoung | nah, use the same env as the py27 call | 19:20 |
| ayoung | just different args | 19:20 |
| morganfainberg | ayoung, subunit_27 and subunit_33 | 19:20 |
| *** raildo has quit IRC | 19:21 | |
| ayoung | morganfainberg, so...could we do the same kind of thing to make it easy to run postgres, mysql, and LDAP live tests? | 19:21 |
| dstanek | morganfainberg: and then have it reuse the existing py27 and py33 envs right? | 19:21 |
| morganfainberg | dstanek, ++ | 19:21 |
| dstanek | nice | 19:21 |
| morganfainberg | ayoung, uhm... that would be harder since that is based on config files | 19:21 |
| ayoung | yeah, I know....but we need something like that. How does the autodiscovery work? | 19:22 |
| ayoung | Could we somehow make those tests triggered by putting them in a different directory or require some env var? | 19:22 |
| dstanek | ayoung: my guess is that if you have in py33 you have to convert the value of text to bytes | 19:22 |
| ayoung | dstanek, wouldn't that be "encode" | 19:23 |
| *** leseb has joined #openstack-keystone | 19:23 | |
| dstanek | ayoung: http://docs.python.org/3/library/functions.html#bytearray | 19:24 |
| dstanek | althought i would have expected encode to work | 19:26 |
| ayoung | dstanek, so strutils.to_bytes ? | 19:26 |
| ayoung | https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/openstack/common/strutils.py#L170 | 19:26 |
| morganfainberg | ok | 19:26 |
| morganfainberg | so we can't make tox behave automatically | 19:26 |
| morganfainberg | because tox uses py27, py26, and py33 as magic venvs | 19:27 |
| morganfainberg | soooooo | 19:27 |
| morganfainberg | i'm going to make run_tests smarter | 19:27 |
| dstanek | ayoung: i don't see you doing the encode on the text | 19:28 |
| ayoung | https://review.openstack.org/#/c/79411/1/keystoneclient/common/cms.py line 108 | 19:28 |
| ayoung | and 222 | 19:28 |
| dstanek | morganfainberg: you can't have tox use one of those as the venv for a new target? | 19:28 |
| morganfainberg | dstanek, you can, but if you run subunit outside of py33, it'll install the "base" version | 19:29 |
| morganfainberg | so you might be calling it subunit_py33 and end up with a py27 install | 19:29 |
| morganfainberg | "pyXX" is a magic venv | 19:29 |
| morganfainberg | i'd rather keep that | 19:29 |
| morganfainberg | and just tell people "use run_tests, no really" | 19:29 |
| morganfainberg | and i'll add an option to run py33 or py26 to run_tests | 19:30 |
| dstanek | ayoung: i don't think strutils is actually encoding the data and giving you bytes | 19:30 |
| morganfainberg | but it'll do the same thing as tox -epy27 but just with subunit output | 19:30 |
| ayoung | dstanek, um... I think you are right | 19:31 |
| dstanek | ayoung: it seems that function is just stoopid! | 19:31 |
| ayoung | dstanek, but I tried a plain six call with similar results | 19:31 |
| openstackgerrit | A change was merged to openstack/python-keystoneclient: Updated from global requirements https://review.openstack.org/75586 | 19:32 |
| openstackgerrit | Morgan Fainberg proposed a change to openstack/keystone: Add slowest output to tox runs (testr) https://review.openstack.org/79422 | 19:33 |
| *** raildo has joined #openstack-keystone | 19:33 | |
| dstanek | ayoung: what happens when you just do a plain old str.encode('utf-8') | 19:35 |
| *** daneyon has joined #openstack-keystone | 19:37 | |
| *** gokrokve_ has joined #openstack-keystone | 19:40 | |
| ayoung | dstanek, just tried that...I'll paste | 19:41 |
| ayoung | File "./keystoneclient/common/cms.py", line 90, in _process_communicate_handle_oserror | 19:42 |
| ayoung | err += process.stderr.read() | 19:42 |
| ayoung | TypeError: Can't convert 'bytes' object to str implicitly | 19:42 |
| ayoung | that one looks dealable | 19:42 |
| ayoung | still instances of TypeError: Type str doesn't support the buffer API | 19:42 |
| raildo | dolphm: pig | 19:44 |
| raildo | ping* | 19:44 |
| *** gokrokve has quit IRC | 19:44 | |
| *** daneyon has left #openstack-keystone | 19:48 | |
| ayoung | gyee, https://review.openstack.org/#/c/74908/ you are going to want that for your X509 work. | 19:52 |
| bknudson | I'm getting all sorts of warnings from doc build with the requirements change. | 19:53 |
| *** serapontiy has joined #openstack-keystone | 19:54 | |
| raildo | ayoung: I was interested in contributing to the federation and would like to know how I can do this, is there any functionality that can help, or test, or extend to the client | 19:56 |
| raildo | Could you help me or you know who should I contact? | 19:57 |
| openstackgerrit | Richard Megginson proposed a change to openstack/keystone: better handling for empty/None ldap values https://review.openstack.org/76002 | 19:57 |
| morganfainberg | ayoung, so, --fail-fast is the onlything i'm running up against issues duplicating | 19:58 |
| morganfainberg | erm --failfast | 19:58 |
| morganfainberg | how much does that option get used in testing? | 19:59 |
| morganfainberg | dstanek, bknudson, ^ | 20:00 |
| bknudson | morganfainberg: I've never used it. | 20:01 |
| bknudson | I just end the job when it fails | 20:02 |
| morganfainberg | if we can get rid of that, i can make run_tests use tox exclusively | 20:02 |
| bknudson | I don't use run_tests. | 20:02 |
| morganfainberg | bknudson, right, but if did the same thing as tox -epy27 (for example) just w/ subunit output, would you be more inclined to use it? | 20:02 |
| bknudson | since the tests are run essentially in random order what's the difference the first one to fail? | 20:03 |
| morganfainberg | bknudson, use the same venv etc. | 20:03 |
| morganfainberg | bknudson, eh, some people like to fix each test along the way | 20:03 |
| dstanek | morganfainberg: i think i added that for ayoung | 20:03 |
| morganfainberg | or have it explode on the first error vs. just keep going | 20:03 |
| morganfainberg | i personally never use it | 20:04 |
| bknudson | I've done that with -- --failing | 20:04 |
| dstanek | morganfainberg: i almost exclusively use nosetests | 20:04 |
| morganfainberg | dstanek, sure. | 20:05 |
| bknudson | I wouldn't trust that somebody would change run_tests on me. So I'll continue to use tox | 20:05 |
| bknudson | Since that's what the build does | 20:06 |
| morganfainberg | bknudson, aye | 20:06 |
| morganfainberg | though i'm going to start using tox -e<env> -- --subunit | subunit-2to1 | tools/colorizer.py | 20:07 |
| bknudson | could make an alias for it | 20:07 |
| morganfainberg | bknudson, ++ | 20:08 |
| bknudson | morganfainberg: can't put it in tox.ini? | 20:08 |
| bknudson | due to the pipes? | 20:08 |
| morganfainberg | bknudson, well, we could make that the default. | 20:08 |
| morganfainberg | bknudson, but the command needs to be /bin/bash -c "python setup.py testr --<things> --testr-args='--subunit {posargs}' | subunit-2to1 | tools/colorizer.py" | 20:09 |
| morganfainberg | bknudson, it's kinda uglty | 20:09 |
| morganfainberg | but it does work. | 20:09 |
| morganfainberg | also, not sure if infra wants the "speed of each test printed in the CI logs from jenkins" | 20:10 |
| bknudson | let's not break infra | 20:10 |
| morganfainberg | aye | 20:10 |
| morganfainberg | i think i need to submit a feature add for tox, to allow some form of {env:KEY} to just be optional | 20:12 |
| morganfainberg | vs. raising an error of the envvar isn't set | 20:12 |
| bknudson | Looks like https://review.openstack.org/#/c/76691/ broke on the doc build... started generating warnings. | 20:12 |
| bknudson | I was able to recreate locally, but don't have time to look at it right now. | 20:12 |
| *** jamielennox is now known as jamielennox|away | 20:15 | |
| *** serapontiy has quit IRC | 20:26 | |
| gyee | ayoung, about https://review.openstack.org/#/c/74908/3/keystoneclient/middleware/auth_token.py | 20:27 |
| gyee | why are we still using v2 auth? | 20:27 |
| gyee | line 450-460 | 20:27 |
| bknudson | morganfainberg: sounds like tox is re-implementing bash | 20:29 |
| morganfainberg | heh | 20:29 |
| morganfainberg | somewhat | 20:29 |
| dolphm | anyone know Peter Feiner on IRC? (alias=pete5 according to launchpad) | 20:30 |
| morganfainberg | dolphm, that name sounds familiar | 20:30 |
| lbragstad | dolphm: I've reviewed his code before | 20:30 |
| *** ayoung has quit IRC | 20:32 | |
| dstanek | dolphm: i'm pretty sure i've seen his code, but i've never talked to him on irc | 20:34 |
| *** leseb has quit IRC | 20:38 | |
| *** raildo has quit IRC | 20:55 | |
| *** leseb has joined #openstack-keystone | 21:01 | |
| *** pete5 has joined #openstack-keystone | 21:01 | |
| *** leseb has quit IRC | 21:06 | |
| *** amcrn has quit IRC | 21:06 | |
| *** packet has quit IRC | 21:06 | |
| *** pete5 has quit IRC | 21:07 | |
| *** pete5 has joined #openstack-keystone | 21:08 | |
| *** packet has joined #openstack-keystone | 21:11 | |
| *** amcrn has joined #openstack-keystone | 21:12 | |
| *** packet has quit IRC | 21:12 | |
| *** jamielennox|away is now known as jamielennox | 21:17 | |
| openstackgerrit | A change was merged to openstack/keystone: Use config fixture https://review.openstack.org/79104 | 21:27 |
| jamielennox | dolphm: will https://review.openstack.org/#/c/60752/ won't make icehouse if i fix it up? (Guessing no) | 21:29 |
| bknudson | jamielennox: it's keystoneclient... isn't linked to a release. | 21:30 |
| morganfainberg | jamielennox, keystoneclient isn't linked to a release | 21:30 |
| morganfainberg | bknudson, beat me to it | 21:30 |
| bknudson | morganfainberg: jinx! | 21:30 |
| morganfainberg | bknudson OH NOES! | 21:30 |
| jamielennox | damnit, wrong link | 21:30 |
| jamielennox | https://review.openstack.org/#/c/78068/ | 21:30 |
| openstackgerrit | Jenkins proposed a change to openstack/keystone: Updated from global requirements https://review.openstack.org/76691 | 21:31 |
| bknudson | morganfainberg: I saw that the config fixture went in... that's great. | 21:31 |
| morganfainberg | jamielennox, i would aim that for J1 | 21:31 |
| jamielennox | it can be considered a bug fix or a feature addition - if it's a feature then i think i'll drop it because it's ugly and will be much easier with pecan | 21:31 |
| morganfainberg | jamielennox, it's not "broken" in I | 21:31 |
| morganfainberg | jamielennox, land that first thing J1 | 21:32 |
| jamielennox | morganfainberg: debatable | 21:32 |
| morganfainberg | well. | 21:32 |
| morganfainberg | jamielennox, how "broken" is it? | 21:32 |
| morganfainberg | is it "this is really bad an unusable why are we even trying" | 21:32 |
| morganfainberg | ? | 21:32 |
| jamielennox | no, you can somewhat fix it | 21:32 |
| morganfainberg | hmm | 21:32 |
| jamielennox | ok, leave it | 21:33 |
| morganfainberg | jamielennox, i'm not opposed to it going in | 21:33 |
| jamielennox | you can put the right url in mostly because no-one really uses the internalURL anyway | 21:33 |
| morganfainberg | if there is a real concern, lets get it in. | 21:33 |
| jamielennox | there's about 2 or 3 reviews i put in right after freeze | 21:34 |
| jamielennox | :( | 21:34 |
| morganfainberg | so... it doesn't have a red x | 21:34 |
| morganfainberg | let me look it over real quick | 21:34 |
| jamielennox | right, i've got a hold on a couple of others so i wasn't sure | 21:34 |
| morganfainberg | jamielennox, ok so it's bigger than I'd want in this late | 21:36 |
| jamielennox | yea\ | 21:36 |
| morganfainberg | but i could buy that this is a valid item to get in | 21:36 |
| morganfainberg | i think it's a risk evaluation, how likely will this be to break anyone if it lands | 21:36 |
| jamielennox | alright, i'll fix it today and let us debate it at the meeting | 21:36 |
| morganfainberg | if there is more than a nominal risk, i'd want to hold it. | 21:36 |
| morganfainberg | good idea | 21:36 |
| jamielennox | but it's an ugly patch | 21:36 |
| morganfainberg | eh, we've landed worse close to the end | 21:37 |
| *** jimbaker has quit IRC | 21:39 | |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Add 'methods' to all v3 test tokens https://review.openstack.org/74955 | 21:40 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Use AccessInfo in auth_token middleware https://review.openstack.org/74956 | 21:40 |
| *** ayoung has joined #openstack-keystone | 21:42 | |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Remove duplication when picking test config files https://review.openstack.org/79219 | 21:48 |
| openstackgerrit | Brant Knudson proposed a change to openstack/keystone: Configurable temporary directory for tests https://review.openstack.org/79217 | 21:48 |
| morganfainberg | bknudson, +++++++++ | 21:48 |
| morganfainberg | yay! | 21:48 |
| lbragstad | bknudson: nice! | 21:48 |
| bknudson | I hope it makes things easier. | 21:49 |
| *** marekd|email-me is now known as marekd | 21:49 | |
| morganfainberg | bknudson, next step in the long road to parallel testing is to rip out the large volumn of "config" files | 21:53 |
| bknudson | morganfainberg: this gets rid of one of them. | 21:53 |
| morganfainberg | bknudson, :) | 21:53 |
| morganfainberg | bknudson, i can't fix the LDAP ones and the "livetests" require some special magic to keep working | 21:54 |
| bknudson | morganfainberg: it's going to be hard to make the live tests run in parallel... especially ldap | 21:54 |
| morganfainberg | but i think i can remove 100% of the rest of the configs | 21:54 |
| marekd | stevemar dolphm bknudson ayoung dstanek: Gentlemen, anyone willing to take a look at https://review.openstack.org/#/c/79284/ ? :-) | 21:54 |
| bknudson | you'd need a separate tree for each thread | 21:54 |
| morganfainberg | nah, live tests you should run with explicit non-parallel options | 21:54 |
| morganfainberg | or | 21:54 |
| bknudson | for sql you'd need a separate schema (in db2, or database in mysql) | 21:55 |
| morganfainberg | yeah | 21:55 |
| morganfainberg | there are some tools to do that on demand iirc | 21:55 |
| morganfainberg | but those should (for the time being) only be run in single-worker mode (env var) | 21:55 |
| bknudson | morganfainberg: I finally got a computer with more than 2 cpus, so the lack of parallel testing actually affects me now | 21:56 |
| *** dims_ has quit IRC | 21:58 | |
| morganfainberg | bknudson, hehe | 21:58 |
| stevemar | marekd, i will be looking at it in about an hour or two | 21:59 |
| stevemar | food time firts | 21:59 |
| stevemar | first* | 21:59 |
| marekd | stevemar: thanks a lot. It's enough to have some feedback in next 12 hours :-) | 22:02 |
| *** marekd is now known as marekd|away | 22:03 | |
| *** stevemar has quit IRC | 22:04 | |
| jamielennox | hey guys, so client review | 22:05 |
| jamielennox | https://review.openstack.org/#/c/77026/ | 22:05 |
| jamielennox | https://review.openstack.org/#/c/77491/ | 22:05 |
| jamielennox | and if you want more click on my name :) | 22:06 |
| *** petertoft has joined #openstack-keystone | 22:09 | |
| *** andreaf has joined #openstack-keystone | 22:10 | |
| *** jimbaker has joined #openstack-keystone | 22:10 | |
| *** jimbaker has quit IRC | 22:10 | |
| *** jimbaker has joined #openstack-keystone | 22:10 | |
| openstackgerrit | ldbragst proposed a change to openstack/keystone: Use class attribute to represent 'user' and 'group' https://review.openstack.org/74263 | 22:10 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Handle Token/Endpoint authentication https://review.openstack.org/79474 | 22:15 |
| *** lbragstad has quit IRC | 22:15 | |
| *** dims_ has joined #openstack-keystone | 22:16 | |
| *** leseb has joined #openstack-keystone | 22:18 | |
| dstanek | marekd|away: i just posted a review - i -1ed it because i think there is a bug | 22:19 |
| dstanek | marekd|away: but i also think that there maybe a way to make it more reusable | 22:19 |
| *** nkinder_ has quit IRC | 22:20 | |
| dstanek | bknudson: take a look at the review i just did on https://review.openstack.org/#/c/79284 | 22:20 |
| dstanek | bknudson: i'm interested in hearing your opinion on my idea | 22:20 |
| bknudson | dstanek: I like that idea. I'm not a fan of changing the identity API every time there's a change somewhere. | 22:20 |
| morganfainberg | totally idle thought... | 22:21 |
| morganfainberg | how opposed to making the identity SQL backend able to be in a different DB would everyone be (not required, optionally) | 22:21 |
| morganfainberg | not sure how... that would work with oslo.db | 22:21 |
| *** nkinder has joined #openstack-keystone | 22:22 | |
| bknudson | can't imagine anyone opposed to that. | 22:22 |
| morganfainberg | but might be a useful deployment strategy | 22:22 |
| bknudson | morganfainberg: the identity SQL backend would have its own engine. | 22:22 |
| morganfainberg | bknudson, yeah but people are opposed to things for odd reasons | 22:22 |
| morganfainberg | bknudson, ah ++ ok | 22:22 |
| bknudson | we could have all the sql backends have their own engine | 22:23 |
| morganfainberg | bknudson, i'm kindof thinking that might be a solid idea | 22:23 |
| morganfainberg | bknudson, if undefined use the standard one. | 22:23 |
| morganfainberg | erm "default" | 22:23 |
| morganfainberg | e.g. connect string | 22:23 |
| bknudson | morganfainberg: I think there's a foreign key from assignment to identity that would have to be broken | 22:23 |
| morganfainberg | bknudson, then it should be broken :) | 22:23 |
| bknudson | or identity to assignment. | 22:24 |
| bknudson | otherwise LDAP wouldn't work | 22:24 |
| morganfainberg | i'll toss a BP up for J | 22:24 |
| openstackgerrit | Jamie Lennox proposed a change to openstack/python-keystoneclient: Convert auth_token to use session https://review.openstack.org/74908 | 22:25 |
| *** petertoft has quit IRC | 22:32 | |
| *** thedodd has quit IRC | 22:35 | |
| morganfainberg | bknudson, do you want to stick in the per-testr worker logic in _calc_tmpdir? | 22:35 |
| morganfainberg | bknudson, rather than making that change later? | 22:35 |
| morganfainberg | bknudson, we'll need it in either case, but i'm fine with adding it when we get down the line | 22:36 |
| bknudson | morganfainberg: I'd rather make that change later since it's a separate enhancement | 22:36 |
| morganfainberg | k | 22:36 |
| morganfainberg | checking before i +2 this change | 22:36 |
| bknudson | morganfainberg: that one will probably have to create the directory, too, so it will be more complicated | 22:37 |
| morganfainberg | yeah | 22:37 |
| bknudson | morganfainberg: maybe it will be as easy as doing a mkdtemp... wasn't thinking about it before. | 22:38 |
| morganfainberg | it will be, but lets just do that when we get to that bridge | 22:38 |
| morganfainberg | +2 across your test changes (4 i count) | 22:38 |
| bknudson | you'd get multiple pristine databases but that's no big deal | 22:38 |
| morganfainberg | files/config/config_files/etc | 22:38 |
| bknudson | I tried switching some of those tests to in-memory but that didn't work. | 22:39 |
| bknudson | didn't look into it too much | 22:39 |
| morganfainberg | yeah. | 22:39 |
| bknudson | it should work. | 22:39 |
| morganfainberg | i _think_ we could do the pristine db check w/ lockutils magic. | 22:40 |
| morganfainberg | make 1 pristine db, and copy from that | 22:40 |
| bknudson | morganfainberg: right... I'm not sure it's worth it though. They don't take up that much space. | 22:41 |
| *** bknudson has left #openstack-keystone | 22:51 | |
| openstackgerrit | Matthieu Huin proposed a change to openstack/keystone: Add missing documentation for enabling federation auth plugin https://review.openstack.org/79483 | 22:55 |
| *** marekd|away is now known as marekd | 22:55 | |
| *** david-lyle has quit IRC | 22:56 | |
| marekd | dstanek: what bug? | 22:57 |
| *** gokrokve_ has quit IRC | 22:58 | |
| *** henrynash has quit IRC | 23:00 | |
| marekd | dstanek: anyway, thanks.I am not sure if I understood you correctly. You suggested to hold off with my changes until we all get some consensus, or with switching to driver's hints? | 23:00 |
| marekd | dstanek: ah, just noticed your comment. | 23:03 |
| marekd | dstanek: you are probably right....but I would go even further -> compare sets so we are sure all the values are equal, not only lengths. | 23:04 |
| dstanek | marekd: yeah, the bug is in the comparing of the lists | 23:05 |
| *** andreaf has quit IRC | 23:06 | |
| mhu | marekd, got a few questions about federation, do you have time to talk about it now ? | 23:06 |
| *** amcrn has quit IRC | 23:07 | |
| dstanek | marekd: i meant hold off on make changes related to my hints comment - i | 23:07 |
| dstanek | i'd like to hear what others have to say on the matter | 23:07 |
| openstackgerrit | Matthieu Huin proposed a change to openstack/keystone: Add missing documentation for enabling federation auth plugin https://review.openstack.org/79483 | 23:09 |
| *** leseb has quit IRC | 23:10 | |
| *** amcrn has joined #openstack-keystone | 23:10 | |
| marekd | dstanek: ok, we can discuss it during tomorrows keystone meeting. | 23:12 |
| marekd | mhu: hey, are you USA/Canada timezone? | 23:12 |
| mhu | marekd, no, french tz | 23:13 |
| mhu | but not sleepy yet :) | 23:13 |
| marekd | I am Switzerland/France tz. | 23:14 |
| marekd | mhu: but, whatever, go ahead :-) | 23:14 |
| mhu | marekd, it's not an emergency, it can wait until tomorrow morning | 23:15 |
| marekd | mhu: I should be at work before 9am our tz, is it okay to talk then ? | 23:17 |
| mhu | sure | 23:17 |
| mhu | I'll send you an e-mail in a minute explaining my problem, I should be at work between 9:30 and 10 | 23:18 |
| mhu | we can talk about it then | 23:18 |
| marekd | ok! | 23:18 |
| mhu | thanks and good night ! | 23:18 |
| marekd | at least one person who is online during 'normal' hours :D | 23:18 |
| mhu | ahaha | 23:19 |
| *** leseb has joined #openstack-keystone | 23:27 | |
| openstackgerrit | Matthieu Huin proposed a change to openstack/identity-api: Fix for federation token request examples https://review.openstack.org/79491 | 23:39 |
| *** gokrokve has joined #openstack-keystone | 23:40 | |
| morganfainberg | ayoung, https://bitbucket.org/hpk42/tox/pull-request/86/support-optional-env-variable-substitution/diff this will (if accepted) make it so we can support things like --failfast in run_tests if using tox | 23:46 |
| morganfainberg | ayoung, for now, i can't keep feature parity if we want --failfast support | 23:46 |
| *** bknudson has joined #openstack-keystone | 23:52 | |
| *** jagee has quit IRC | 23:52 | |
| morganfainberg | dstanek, for J are we interested in converting our internal notification/callback stuff to blinker? I know you brought that up. | 23:57 |
| *** leseb has quit IRC | 23:57 | |
| morganfainberg | dstanek, looks like it might be a much cleaner interface | 23:58 |
| *** leseb has joined #openstack-keystone | 23:58 | |
| morganfainberg | dstanek, but I am not sure we could do the de-dupe work we currently do. | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!