| openstackgerrit | zhangshuai proposed openstack/karbor: Add metadata parameter to checkpoint API https://review.openstack.org/352748 | 01:18 |
|---|---|---|
| *** zhangshuai has joined #openstack-karbor | 01:24 | |
| *** zhurong has joined #openstack-karbor | 01:41 | |
| *** wujiajun has joined #openstack-karbor | 02:01 | |
| *** yinwei_computer has quit IRC | 02:45 | |
| *** yinwei_computer has joined #openstack-karbor | 02:46 | |
| *** gouthamr has quit IRC | 03:12 | |
| *** zhurong has quit IRC | 03:40 | |
| openstackgerrit | zengchen proposed openstack/karbor: Prepare for refactoring clients used in protect service https://review.openstack.org/404644 | 06:28 |
| *** Jeffrey4l_ has joined #openstack-karbor | 06:30 | |
| *** Jeffrey4l has quit IRC | 06:34 | |
| *** Jeffrey4l_ is now known as Jeffrey4l | 06:34 | |
| *** zhurong has joined #openstack-karbor | 06:36 | |
| openstackgerrit | zengchen proposed openstack/karbor: Update the way of getting endpoint of other service https://review.openstack.org/407990 | 06:50 |
| openstackgerrit | zengchen proposed openstack/karbor: Update the way of getting endpoint of other service https://review.openstack.org/407990 | 07:01 |
| openstackgerrit | zengchen proposed openstack/karbor: Update the way of getting endpoint of other service https://review.openstack.org/407990 | 07:05 |
| openstackgerrit | zengchen proposed openstack/karbor: Update the way of getting endpoint of other service https://review.openstack.org/407990 | 07:10 |
| *** c00281451 has joined #openstack-karbor | 07:11 | |
| *** c00281451 is now known as zengchen | 07:11 | |
| zengchen | ping yuvalb | 07:19 |
| openstackgerrit | zengchen proposed openstack/karbor: Update the way of getting endpoint of other service https://review.openstack.org/407990 | 07:32 |
| *** yuval has joined #openstack-karbor | 07:47 | |
| openstackgerrit | zengchen proposed openstack/karbor: Prepare for refactoring clients used in protect service https://review.openstack.org/404644 | 07:47 |
| openstackgerrit | chenying proposed openstack/karbor: Update the glance backup protection plugin https://review.openstack.org/416824 | 07:49 |
| yuval | hey zengchen | 07:49 |
| zengchen | yuval:hi, how are you? | 07:49 |
| yuval | zengchen: very well, you? | 07:50 |
| zengchen | yuval:I just want to tell you something about 'git mv'. | 07:50 |
| zengchen | yuval:if I run 'git mv /utils.py /clients/utils.py' and modify the utils.py. then the grit will not show the udpate as rename /utils.py to /clients/utils.py but show it as delete /utils.py and add /clients/utils.py. | 07:50 |
| yuval | zengchen: I ran into it as well in the past. Because there are some changes after the move gerrit is confused and thinks it is a new file | 07:51 |
| yuval | zengchen: it is ok | 07:51 |
| zengchen | yuval:I am updating my patch, then you will review conveniently. | 07:52 |
| zengchen | yuval:I decide rename the utils.py in the first patch, and update it in second patch. then you will see the difference. | 07:53 |
| yuval | zengchen: in the comments here, in line 81-82 ( https://review.openstack.org/#/c/404644/10/karbor/services/protection/client_factory.py ), what I meant is that if 'session' or 'keystone_plugin' is not in kwargs, kwargs['session'] will give KeyError | 07:54 |
| zengchen | yuval:let me take a look. | 07:55 |
| yuval | and regarding the init function: can we have it handle cases where it is called twice? i.e: not loading the same modules again | 07:56 |
| zengchen | yuval:about first one. I don't understand. why 'session' and 'keystone_plugin' not in kwargs? what i have done set the value in kwargs. | 08:00 |
| zengchen | yuval:and regarding the init function. if do as before, then we may have to solve the problem of loading same client twice. but if do as i have done ,i don't see any problem. | 08:03 |
| openstackgerrit | zengchen proposed openstack/karbor: Update the way of getting endpoint of other service https://review.openstack.org/407990 | 08:07 |
| yuval | zengchen: if you always inject 'session' argument into kwargs, how can the "if kwargs.get('session')" condition not satisified? (here, for example: https://review.openstack.org/#/c/408382/3/karbor/services/protection/clients/glance.py ) | 08:10 |
| zengchen | yuval:kwargs['session'] = cls._generate_session(context, service) means 'session' must in kwargs, but not means kwargs['session'] is not None, because cls._generate_session may return None. | 08:13 |
| yuval | zengchen: only when _generate_session fails | 08:13 |
| zengchen | yuval:yes | 08:14 |
| zengchen | yvual:so if kwargs.get('session') == None, then it will run original codes. | 08:15 |
| openstackgerrit | zengchen proposed openstack/karbor: Fix token expire wich may happen in using clients https://review.openstack.org/408382 | 08:20 |
| *** yamamoto has quit IRC | 08:21 | |
| chenying_ | ping yuva | 08:53 |
| chenying_ | ping yuval | 08:53 |
| chenying_ | yuval The patch about glance plugin has been updated. :) | 08:53 |
| *** yamamoto has joined #openstack-karbor | 09:00 | |
| *** yamamoto has quit IRC | 09:07 | |
| *** zhurong has quit IRC | 09:44 | |
| *** yamamoto has joined #openstack-karbor | 09:45 | |
| *** yamamoto has quit IRC | 09:49 | |
| *** yamamoto has joined #openstack-karbor | 10:28 | |
| *** yamamoto has quit IRC | 10:29 | |
| *** zengyingzhe has quit IRC | 10:30 | |
| *** zengyingzhe has joined #openstack-karbor | 10:30 | |
| *** yamamoto has joined #openstack-karbor | 10:38 | |
| *** tommylikehu has joined #openstack-karbor | 10:49 | |
| *** yamamoto has quit IRC | 10:56 | |
| openstackgerrit | Merged openstack/python-karborclient: Check the resource when creating a plan https://review.openstack.org/418280 | 10:59 |
| openstackgerrit | zengchen proposed openstack/karbor: Prepare for refactoring clients used in protect service https://review.openstack.org/404644 | 11:01 |
| *** yamamoto has joined #openstack-karbor | 11:30 | |
| *** yamamoto has quit IRC | 11:34 | |
| openstackgerrit | wu proposed openstack/python-karborclient: Make command 'karbor provider-show' print pretty https://review.openstack.org/421239 | 12:14 |
| openstackgerrit | chenying proposed openstack/karbor: Update the glance backup protection plugin https://review.openstack.org/416824 | 12:35 |
| openstackgerrit | wu proposed openstack/python-karborclient: Make command 'karbor provider-show' print pretty https://review.openstack.org/421239 | 12:46 |
| *** gouthamr has joined #openstack-karbor | 12:48 | |
| *** zhangshuai has quit IRC | 13:36 | |
| *** zhangshuai has joined #openstack-karbor | 13:37 | |
| *** tommylikehu_ has joined #openstack-karbor | 13:58 | |
| *** zhangshuai has quit IRC | 14:03 | |
| *** zhangshuai has joined #openstack-karbor | 14:03 | |
| *** yamamoto has joined #openstack-karbor | 14:31 | |
| *** leon_wang has joined #openstack-karbor | 14:34 | |
| *** yamamoto has quit IRC | 14:35 | |
| *** leon_wang has quit IRC | 15:45 | |
| *** tommylikehu_ has quit IRC | 16:04 | |
| *** yuval has quit IRC | 16:05 | |
| *** zhangshuai has quit IRC | 16:23 | |
| *** zhangshuai has joined #openstack-karbor | 16:24 | |
| *** wujiajun has quit IRC | 16:26 | |
| *** wujiajun has joined #openstack-karbor | 16:26 | |
| *** dimak has quit IRC | 18:01 | |
| *** dimak has joined #openstack-karbor | 18:02 | |
| *** diablo_rojo has joined #openstack-karbor | 19:39 | |
| diablo_rojo | Hello, just wanted to give you all a reminder that the period for the Travel Support Program for the PTG ends today. We would love to get more people from karbor to the PTG. Here is the link to the TSP Application: https://openstackfoundation.formstack.com/forms/travelsupportptg_atlanta | 19:39 |
| *** tommylikehu has quit IRC | 19:40 | |
| *** Jeffrey4l has quit IRC | 21:35 | |
| *** Jeffrey4l has joined #openstack-karbor | 21:48 | |
| *** diablo_rojo has quit IRC | 21:54 | |
| *** gouthamr has quit IRC | 22:01 | |
| *** yamamoto has joined #openstack-karbor | 22:11 | |
| *** tommylikehu_ has joined #openstack-karbor | 23:11 | |
| *** tommylikehu_ has quit IRC | 23:11 | |
| *** tommylik_ has joined #openstack-karbor | 23:11 | |
| *** tommylik_ has quit IRC | 23:12 | |
| *** gouthamr has joined #openstack-karbor | 23:27 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!