| toabctl | vsevolod__, re https://storyboard.openstack.org/#!/story/2011116 - I don't fully understand where the expansion of the parameters happens in the end. if I just hardcode the required param in the J2String->expand() method (like https://paste.opendev.org/show/bUE3m55rzHOweOmPTMtE/), the example passes. but I don't know how to pass the global params down to that. | 08:10 |
|---|---|---|
| toabctl | ok. I think I found a solution. I'll post a patch soon | 09:29 |
| opendevreview | Thomas Bechtold proposed jjb/jenkins-job-builder master: Story 2011116: recursively find jinja2 vars from templates https://review.opendev.org/c/jjb/jenkins-job-builder/+/918293 | 10:16 |
| toabctl | @vsevolod__, ^^ is the fix. cloud you have a look please? | 10:16 |
| vsevolod__ | toabctl, yep, looks good to me | 11:25 |
| toabctl | vsevolod__, does JJB require a 2nd reviewer nowadays to get this merged? and what about the unrelated failures in the CI? | 11:26 |
| vsevolod__ | No, it just requires workflow+1 | 11:59 |
| vsevolod__ | failure is unrelated, yes | 11:59 |
| vsevolod__ | should be fixed by someone first... | 11:59 |
| opendevreview | Thomas Bechtold proposed jjb/jenkins-job-builder master: Story 2011116: recursively find jinja2 vars from templates https://review.opendev.org/c/jjb/jenkins-job-builder/+/918293 | 12:45 |
| toabctl | the problem is that I can't reproduce those failures locally. I get another list of errors... | 12:58 |
| opendevreview | Thomas Bechtold proposed jjb/jenkins-job-builder master: Fix _pseudo_parse_arglist from Sphinx https://review.opendev.org/c/jjb/jenkins-job-builder/+/918331 | 15:57 |
| toabctl | vsevolod__, https://review.opendev.org/c/jjb/jenkins-job-builder/+/918331 should solve the documentation problem. can you review & merge please? | 15:58 |
| opendevreview | Thomas Bechtold proposed jjb/jenkins-job-builder master: Fix _pseudo_parse_arglist from Sphinx https://review.opendev.org/c/jjb/jenkins-job-builder/+/918331 | 16:21 |
| opendevreview | Thomas Bechtold proposed jjb/jenkins-job-builder master: Story 2011116: recursively find jinja2 vars from templates https://review.opendev.org/c/jjb/jenkins-job-builder/+/918293 | 16:21 |
| vsevolod__ | Cool | 16:48 |
| vsevolod__ | But fix lint complaint, please, first | 16:49 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!