| abelur | https://www.irccloud.com/pastebin/MHpZXOaz/include-raw.diff | 00:36 |
|---|---|---|
| abelur | vsevolod_: Can you review the diff above if its the correct approach to migrate JJB 5x to 6x, basically tryping to update the jobs and macro without parameters? TIA | 00:37 |
| abelur | I've only preserved the extra braces i.e `{} -> {{}}` where we are using some kind a inline bash substitution. Most bash vars dont need both a "" and "{}". I've removed those since its the same as "$VAR" == "${VAR}". | 00:39 |
| vsevolod_ | When you change include-raw to include-raw-escape, you don't need to change included file itself | 07:03 |
| vsevolod_ | I am talking about package-listing.sh | 07:04 |
| vsevolod_ | and sysstat.sh | 07:04 |
| vsevolod_ | and, again, you should compare output before and after move to 6.0. They should be equal - then everything is fine. | 07:04 |
| vsevolod_ | use jenkins-jobs test -o <dir-before>/<dir-after> and then diff -ru <dir-before> <dir-after> | 07:05 |
| abelur | vsevolod_: oh okay, so this is not required `+workspace="${{WORKSPACE:-}}"` and removing the braces around `${VAR}` isnt required? | 08:20 |
| abelur | These bash variables might be alright, but there are instances where we are using bash inline substitution. ex: "${WORKSPACE:-}". There are hugh number of changes considering we use include-raw in several places. | 08:20 |
| vsevolod_ | Yep, not required | 08:20 |
| abelur | 👍 | 08:21 |
| abelur | One other thing that caused this confusion is the release email sent out on the list, which suggests that "For every job and macro without parameters: Duplicate curly braces: {...} -> {{...}};". I guess these are only the paramerters that are being passed to the script and not all variable. | 08:34 |
| abelur | vsevolod_: publishers macro don't seem to be expanding correctly. I;m unsure how to fix this: | 12:30 |
| abelur | https://www.irccloud.com/pastebin/txHSXOCL/ | 12:31 |
| abelur | https://www.irccloud.com/pastebin/9zlWH9gt/ | 12:32 |
| vsevolod_ | Hard to tell without sources | 12:40 |
| vsevolod_ | Don't see problem in traceback | 12:41 |
| abelur | I resolved this, its not related to JJB 6.x at all. Sorry for the noise! | 12:52 |
| vsevolod_ | No problems | 13:44 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!