| *** larainema has joined #openstack-jjb | 01:59 | |
| *** hashar has joined #openstack-jjb | 13:28 | |
| *** hashar has quit IRC | 13:32 | |
| *** larainema has quit IRC | 15:27 | |
| *** kandie has joined #openstack-jjb | 18:24 | |
| kandie | hi, i was about to submit a patch to allow dashes in variable names, only to now notice that this was done before in b92336aa95c7b06316ece9e0537fb3d7c150279c and later reverted in c33dbaaaae0cc760498924dc25c7c99396c5702b - does anyone remember the reason for the revert? | 18:25 |
|---|---|---|
| zxiiro | kandie: it broke JJB for some users. You can review the comments in these patches https://review.opendev.org/#/q/b92336aa95c7b06316ece9e0537fb3d7c150279c | 18:32 |
| kandie | zxiiro: thank you sir | 18:32 |
| kandie | are you open to reconsidering that change, if we looked into the other issue that surfaced from it? | 19:23 |
| zxiiro | kandie: I'm open to accepting that change provided that issues with it are resolved because it breaks projects I work on. | 19:26 |
| zxiiro | kandie: the revert was not a rejection of the patch itself. | 19:27 |
| zxiiro | kandie: just no one's stepped up to carry the patch forward after that breaking issue. | 19:27 |
| kandie | for some context: this change is one of a few UX improvements we're trying to make before rolling JJB out to the company (200+ programmers), and this particular change may be less controversial than some others, like macros not receiving variables from the caller's scope (e.g. a project) - can you advice on how to proceed? do u think it's better for us to maintain a fork? (i prefer not) | 19:27 |
| kandie | zxiiro: ok that's good to hear! i am willing to look into it, i just signed the ICLA and CCLA | 19:27 |
| zxiiro | kandie: you don't need to fork. Split your changes into reasonable separate feature requests and we can review them individually and work with you to get them made in. | 19:28 |
| kandie | zxiiro: perfect | 19:28 |
| zxiiro | kandie: forking JJB is a bad idea as there's really no one working on it these days. Fragmenting an already small community is bad. We need people to step up and help maintain JJB. | 19:28 |
| kandie | zxiiro: that is good to know and i am all for it | 19:29 |
| zxiiro | For the most part I just review and merge patches that the community proposes occassionally. There's really no one actively working on new features in JJB anymore. | 19:29 |
| kandie | i followed the guide in https://docs.openstack.org/infra/manual/developers.html but it didn't mention the storyboard: would you prefer for me to file an issue in the storyboard first and then reference it in the gerrit patch? | 19:31 |
| zxiiro | kandie: one concern I'd have though is if you're proposing new features I'd hope you'd stick around to support it as if it breaks any workflows I'm more likely to just revert it. | 19:31 |
| kandie | zxiiro: that's understandable, is there any way to trigger downstream tests or have insight into potentially breaking changes? | 19:32 |
| zxiiro | kandie: we mainly use this IRC channel, the mailing list on google-groups and Gerrit directly these days. IMO there's not enough of us to be formal with things like Storyboard. | 19:32 |
| zxiiro | kandie: for bigger topics you can send an email to the group. | 19:32 |
| zxiiro | kandie: nope but I can test downstreams pretty quickly. I'm involved with a few Linux Foundation projects which use JJB heavily. 5000+ jobs we can at the very list do a syntax check against. | 19:34 |
| kandie | zxiiro: thank you for the info, we'll post on IRC and take it to the mailing list if it seems necessary | 19:37 |
| kandie | zxiiro: let me share with you the list of items we're trying to address | 19:37 |
| kandie | zxiiro: not to waste your time, i'm gathering more accurate information from the people who reported the problems (i also want to verify the issues myself) -- i'll get back to you when that's done, thanks again | 20:16 |
| zxiiro | kandie: sure, I'd say probably shoot an email to the list. There's some folks who maybe interested that may not be active in this channel anymore. | 20:21 |
| *** openstack has joined #openstack-jjb | 21:17 | |
| *** ChanServ sets mode: +o openstack | 21:17 | |
| *** harlowja has quit IRC | 22:23 | |
| *** lennyb has joined #openstack-jjb | 22:41 | |
| Liskni_si | there's some more relevant comments in https://review.opendev.org/#/c/587227/ | 23:04 |
| Liskni_si | I vaguely remember that the resolution was that expansion as object stays, so I went through the codebase and looked for places that might blow up the way they did in zxiiro's case | 23:04 |
| Liskni_si | and then I did https://github.com/gooddata/jenkins-job-builder/commit/181b669ca1b3bb022eaf59a3c17d06eb6ecbb838 | 23:05 |
| Liskni_si | "I'm going to submit this later upstream." and apparently I never did | 23:05 |
| Liskni_si | burned out, left the job. | 23:05 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!