*** ssbarnea has joined #openstack-jjb | 02:25 | |
*** ssbarnea|bkp2 has quit IRC | 02:25 | |
openstackgerrit | Norbert Grünwald proposed openstack-infra/jenkins-job-builder master: Add support for the "Gitlab Logo Plugin" https://review.openstack.org/609640 | 06:43 |
---|---|---|
*** hashar has joined #openstack-jjb | 07:05 | |
*** electrofelix has joined #openstack-jjb | 07:59 | |
*** ssbarnea has quit IRC | 12:05 | |
*** ssbarnea has joined #openstack-jjb | 12:07 | |
*** openstackgerrit has quit IRC | 14:36 | |
*** openstackgerrit has joined #openstack-jjb | 16:07 | |
openstackgerrit | Tomas Janousek proposed openstack/python-jenkins master: Test requested URLs in test_getall https://review.openstack.org/588937 | 16:07 |
openstackgerrit | Tomas Janousek proposed openstack/python-jenkins master: Clean up job/folder path handling https://review.openstack.org/588938 | 16:07 |
openstackgerrit | Tomas Janousek proposed openstack/python-jenkins master: Replace build_jobs_list_responses with actual Jenkins responses https://review.openstack.org/588939 | 16:07 |
openstackgerrit | Tomas Janousek proposed openstack/python-jenkins master: Request multiple folder levels at once in get_all_jobs https://review.openstack.org/588940 | 16:07 |
openstackgerrit | Tomas Janousek proposed openstack/python-jenkins master: Merge jobs_in_folder_named_job into jobs_in_folder https://review.openstack.org/591370 | 16:07 |
zxiiro | Liskni_si: thanks, I've removed my -1s the series of patches appear to work for me. | 17:59 |
*** electrofelix has quit IRC | 18:14 | |
Liskni_si | zxiiro: awesome! :-) | 18:17 |
harlowja | can we get the -2 taken off https://review.openstack.org/#/c/603838/ | 19:18 |
harlowja | (i'd like that to merge) | 19:18 |
openstackgerrit | Merged openstack/python-jenkins master: Test requested URLs in test_getall https://review.openstack.org/588937 | 19:19 |
openstackgerrit | Merged openstack/python-jenkins master: Clean up job/folder path handling https://review.openstack.org/588938 | 19:19 |
zxiiro | harlowja: ping the person who left it to rereview it | 19:22 |
zxiiro | harlowja: in this case it's ssbarnea | 19:22 |
zxiiro | harlowja: no one else can remove -2's other than the person who left it in the first place. | 19:23 |
harlowja | ssbarnea, ping :-P | 19:23 |
harlowja | ya, that's why i don't like -2 | 19:23 |
harlowja | to hardcore, lol | 19:23 |
zxiiro | Yep. I try to reserve it for when I really disagree with something. | 19:24 |
ssbarnea | harlowja: pinging me wroked! :D | 19:24 |
zxiiro | use it sparingly hehe | 19:24 |
ssbarnea | indeed, it was probably too much | 19:24 |
openstackgerrit | Merged openstack/python-jenkins master: Replace build_jobs_list_responses with actual Jenkins responses https://review.openstack.org/588939 | 19:25 |
ssbarnea | i got hit by a similar problem recently and is a real PITA if the one that gave you the -2 is not available. | 19:25 |
harlowja | yerp | 19:25 |
harlowja | but u are around | 19:25 |
harlowja | so +2 to that, ha | 19:26 |
ssbarnea | harlowja:" btw, I really hate seeing your name in UPPERCASE on commit, is like someone yelling at me ;) | 19:26 |
ssbarnea | maybe you can change it in the future,... | 19:27 |
harlowja | I did that? | 19:27 |
ssbarnea | ahh, not you | 19:27 |
harlowja | :) | 19:27 |
ssbarnea | original uploader | 19:27 |
harlowja | be like buddha with names | 19:28 |
ssbarnea | it was his first commit so lets be positive :) | 19:28 |
harlowja | it is just a name :-P | 19:28 |
zxiiro | In Git only the email matters really | 19:28 |
harlowja | breathe in, breathe out | 19:28 |
harlowja | ha | 19:28 |
ssbarnea | zxiiro: any other core around to +W https://review.openstack.org/#/c/608321/ ? | 19:29 |
zxiiro | ssbarnea: doesn't seem like a big deal so I'll just go ahead with it | 19:29 |
ssbarnea | yeah, i just didn't want to mess my stats on self-workflows :D | 19:30 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Adds option to specify secret id for github https://review.openstack.org/603838 | 19:38 |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Make jjb-tox-cross-python-jenkins job voting https://review.openstack.org/608321 | 19:43 |
*** hashar has quit IRC | 21:01 | |
openstackgerrit | Merged openstack-infra/jenkins-job-builder master: Add support for the "Gitlab Logo Plugin" https://review.openstack.org/609640 | 22:20 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!